@vibescope/mcp-server 0.4.5 → 0.4.6

package/src/handlers/roles.test.ts

@@ -1,305 +1,305 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import {
-	getRoleSettings,
-	updateRoleSettings,
-	setSessionRole,
-	getAgentsByRole,
-} from './roles.js';
-import { createMockContext } from './__test-utils__.js';
-import { mockApiClient } from './__test-setup__.js';
-
-// ============================================================================
-// getRoleSettings Tests
-// ============================================================================
-
-describe('getRoleSettings', () => {
-	beforeEach(() => vi.clearAllMocks());
-
-	it('should return error for missing project_id', async () => {
-		const ctx = createMockContext();
-
-		const result = await getRoleSettings({}, ctx);
-
-		expect(result.result).toMatchObject({
-			error: 'project_id is required',
-		});
-	});
-
-	it('should get role settings successfully', async () => {
-		const mockRoles = [
-			{ role: 'developer', enabled: true, display_name: 'Developer' },
-			{ role: 'validator', enabled: true, display_name: 'Validator' },
-		];
-		mockApiClient.proxy.mockResolvedValue({
-			ok: true,
-			data: { roles: mockRoles },
-		});
-		const ctx = createMockContext();
-
-		const result = await getRoleSettings(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(result.result).toMatchObject({ roles: mockRoles });
-		expect(mockApiClient.proxy).toHaveBeenCalledWith(
-			'get_role_settings',
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' }
-		);
-	});
-
-	it('should return error from API', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: false,
-			error: 'Project not found',
-		});
-		const ctx = createMockContext();
-
-		const result = await getRoleSettings(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			error: 'Project not found',
-		});
-	});
-});
-
-// ============================================================================
-// updateRoleSettings Tests
-// ============================================================================
-
-describe('updateRoleSettings', () => {
-	beforeEach(() => vi.clearAllMocks());
-
-	it('should return error for missing project_id', async () => {
-		const ctx = createMockContext();
-
-		const result = await updateRoleSettings({ role: 'developer' }, ctx);
-
-		expect(result.result).toMatchObject({
-			error: 'project_id is required',
-		});
-	});
-
-	it('should return error for missing role', async () => {
-		const ctx = createMockContext();
-
-		const result = await updateRoleSettings(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			error: 'role is required',
-		});
-	});
-
-	it('should update role settings successfully', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: true,
-			data: { success: true, role: 'validator' },
-		});
-		const ctx = createMockContext();
-
-		const result = await updateRoleSettings(
-			{
-				project_id: '123e4567-e89b-12d3-a456-426614174000',
-				role: 'validator',
-				enabled: true,
-				auto_assign_validation: true,
-			},
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			success: true,
-			role: 'validator',
-		});
-		expect(mockApiClient.proxy).toHaveBeenCalledWith(
-			'update_role_settings',
-			expect.objectContaining({
-				project_id: '123e4567-e89b-12d3-a456-426614174000',
-				role: 'validator',
-				enabled: true,
-				auto_assign_validation: true,
-			})
-		);
-	});
-
-	it('should return error from API', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: false,
-			error: 'Access denied',
-		});
-		const ctx = createMockContext();
-
-		const result = await updateRoleSettings(
-			{
-				project_id: '123e4567-e89b-12d3-a456-426614174000',
-				role: 'validator',
-			},
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			error: 'Access denied',
-		});
-	});
-});
-
-// ============================================================================
-// setSessionRole Tests
-// ============================================================================
-
-describe('setSessionRole', () => {
-	beforeEach(() => vi.clearAllMocks());
-
-	it('should return error for missing role', async () => {
-		const ctx = createMockContext();
-
-		const result = await setSessionRole({}, ctx);
-
-		expect(result.result).toMatchObject({
-			error: 'role is required',
-		});
-	});
-
-	it('should accept custom roles (open-ended)', async () => {
-		const ctx = createMockContext();
-
-		const result = await setSessionRole({ role: 'custom_role' }, ctx);
-
-		// Roles are now open-ended - any role name is accepted
-		expect(result.result).toMatchObject({
-			success: true,
-			role: 'custom_role',
-		});
-	});
-
-	it('should set local role when no active session', async () => {
-		const ctx = createMockContext({ sessionId: null });
-
-		const result = await setSessionRole({ role: 'validator' }, ctx);
-
-		expect(result.result).toMatchObject({
-			success: true,
-			role: 'validator',
-			message: expect.stringContaining('Local role set to validator'),
-		});
-	});
-
-	it('should update session role on server when session active', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: true,
-			data: { success: true, session_id: 'session-123', role: 'deployer' },
-		});
-		const ctx = createMockContext({ sessionId: 'session-123' });
-
-		const result = await setSessionRole({ role: 'deployer' }, ctx);
-
-		expect(result.result).toMatchObject({
-			success: true,
-			session_id: 'session-123',
-			role: 'deployer',
-		});
-		expect(mockApiClient.proxy).toHaveBeenCalledWith(
-			'set_session_role',
-			expect.objectContaining({
-				session_id: 'session-123',
-				role: 'deployer',
-			})
-		);
-	});
-
-	it('should update local state when setting role', async () => {
-		const updateSession = vi.fn();
-		const ctx = createMockContext({ sessionId: null });
-		ctx.updateSession = updateSession;
-
-		await setSessionRole({ role: 'reviewer' }, ctx);
-
-		expect(updateSession).toHaveBeenCalledWith({ currentRole: 'reviewer' });
-	});
-
-	it('should return error from API when updating session', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: false,
-			error: 'Session not found',
-		});
-		const ctx = createMockContext({ sessionId: 'session-123' });
-
-		const result = await setSessionRole({ role: 'maintainer' }, ctx);
-
-		expect(result.result).toMatchObject({
-			error: 'Session not found',
-		});
-	});
-});
-
-// ============================================================================
-// getAgentsByRole Tests
-// ============================================================================
-
-describe('getAgentsByRole', () => {
-	beforeEach(() => vi.clearAllMocks());
-
-	it('should return error for missing project_id', async () => {
-		const ctx = createMockContext();
-
-		const result = await getAgentsByRole({}, ctx);
-
-		expect(result.result).toMatchObject({
-			error: 'project_id is required',
-		});
-	});
-
-	it('should get agents by role successfully', async () => {
-		const mockAgentsByRole = {
-			developer: [
-				{ session_id: 'session-1', agent_name: 'Edge', status: 'active' },
-			],
-			validator: [],
-			deployer: [],
-			reviewer: [],
-			maintainer: [],
-		};
-		mockApiClient.proxy.mockResolvedValue({
-			ok: true,
-			data: { agents_by_role: mockAgentsByRole, total_active: 1 },
-		});
-		const ctx = createMockContext();
-
-		const result = await getAgentsByRole(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			agents_by_role: mockAgentsByRole,
-			total_active: 1,
-		});
-		expect(mockApiClient.proxy).toHaveBeenCalledWith(
-			'get_agents_by_role',
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000', counts_only: true }
-		);
-	});
-
-	it('should return error from API', async () => {
-		mockApiClient.proxy.mockResolvedValue({
-			ok: false,
-			error: 'Project not found',
-		});
-		const ctx = createMockContext();
-
-		const result = await getAgentsByRole(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(result.result).toMatchObject({
-			error: 'Project not found',
-		});
-	});
-});
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import {
+	getRoleSettings,
+	updateRoleSettings,
+	setSessionRole,
+	getAgentsByRole,
+} from './roles.js';
+import { createMockContext } from './__test-utils__.js';
+import { mockApiClient } from './__test-setup__.js';
+
+// ============================================================================
+// getRoleSettings Tests
+// ============================================================================
+
+describe('getRoleSettings', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should return error for missing project_id', async () => {
+		const ctx = createMockContext();
+
+		const result = await getRoleSettings({}, ctx);
+
+		expect(result.result).toMatchObject({
+			error: 'project_id is required',
+		});
+	});
+
+	it('should get role settings successfully', async () => {
+		const mockRoles = [
+			{ role: 'developer', enabled: true, display_name: 'Developer' },
+			{ role: 'validator', enabled: true, display_name: 'Validator' },
+		];
+		mockApiClient.proxy.mockResolvedValue({
+			ok: true,
+			data: { roles: mockRoles },
+		});
+		const ctx = createMockContext();
+
+		const result = await getRoleSettings(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({ roles: mockRoles });
+		expect(mockApiClient.proxy).toHaveBeenCalledWith(
+			'get_role_settings',
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' }
+		);
+	});
+
+	it('should return error from API', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: false,
+			error: 'Project not found',
+		});
+		const ctx = createMockContext();
+
+		const result = await getRoleSettings(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			error: 'Project not found',
+		});
+	});
+});
+
+// ============================================================================
+// updateRoleSettings Tests
+// ============================================================================
+
+describe('updateRoleSettings', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should return error for missing project_id', async () => {
+		const ctx = createMockContext();
+
+		const result = await updateRoleSettings({ role: 'developer' }, ctx);
+
+		expect(result.result).toMatchObject({
+			error: 'project_id is required',
+		});
+	});
+
+	it('should return error for missing role', async () => {
+		const ctx = createMockContext();
+
+		const result = await updateRoleSettings(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			error: 'role is required',
+		});
+	});
+
+	it('should update role settings successfully', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: true,
+			data: { success: true, role: 'validator' },
+		});
+		const ctx = createMockContext();
+
+		const result = await updateRoleSettings(
+			{
+				project_id: '123e4567-e89b-12d3-a456-426614174000',
+				role: 'validator',
+				enabled: true,
+				auto_assign_validation: true,
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			role: 'validator',
+		});
+		expect(mockApiClient.proxy).toHaveBeenCalledWith(
+			'update_role_settings',
+			expect.objectContaining({
+				project_id: '123e4567-e89b-12d3-a456-426614174000',
+				role: 'validator',
+				enabled: true,
+				auto_assign_validation: true,
+			})
+		);
+	});
+
+	it('should return error from API', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: false,
+			error: 'Access denied',
+		});
+		const ctx = createMockContext();
+
+		const result = await updateRoleSettings(
+			{
+				project_id: '123e4567-e89b-12d3-a456-426614174000',
+				role: 'validator',
+			},
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			error: 'Access denied',
+		});
+	});
+});
+
+// ============================================================================
+// setSessionRole Tests
+// ============================================================================
+
+describe('setSessionRole', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should return error for missing role', async () => {
+		const ctx = createMockContext();
+
+		const result = await setSessionRole({}, ctx);
+
+		expect(result.result).toMatchObject({
+			error: 'role is required',
+		});
+	});
+
+	it('should accept custom roles (open-ended)', async () => {
+		const ctx = createMockContext();
+
+		const result = await setSessionRole({ role: 'custom_role' }, ctx);
+
+		// Roles are now open-ended - any role name is accepted
+		expect(result.result).toMatchObject({
+			success: true,
+			role: 'custom_role',
+		});
+	});
+
+	it('should set local role when no active session', async () => {
+		const ctx = createMockContext({ sessionId: null });
+
+		const result = await setSessionRole({ role: 'validator' }, ctx);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			role: 'validator',
+			message: expect.stringContaining('Local role set to validator'),
+		});
+	});
+
+	it('should update session role on server when session active', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: true,
+			data: { success: true, session_id: 'session-123', role: 'deployer' },
+		});
+		const ctx = createMockContext({ sessionId: 'session-123' });
+
+		const result = await setSessionRole({ role: 'deployer' }, ctx);
+
+		expect(result.result).toMatchObject({
+			success: true,
+			session_id: 'session-123',
+			role: 'deployer',
+		});
+		expect(mockApiClient.proxy).toHaveBeenCalledWith(
+			'set_session_role',
+			expect.objectContaining({
+				session_id: 'session-123',
+				role: 'deployer',
+			})
+		);
+	});
+
+	it('should update local state when setting role', async () => {
+		const updateSession = vi.fn();
+		const ctx = createMockContext({ sessionId: null });
+		ctx.updateSession = updateSession;
+
+		await setSessionRole({ role: 'reviewer' }, ctx);
+
+		expect(updateSession).toHaveBeenCalledWith({ currentRole: 'reviewer' });
+	});
+
+	it('should return error from API when updating session', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: false,
+			error: 'Session not found',
+		});
+		const ctx = createMockContext({ sessionId: 'session-123' });
+
+		const result = await setSessionRole({ role: 'maintainer' }, ctx);
+
+		expect(result.result).toMatchObject({
+			error: 'Session not found',
+		});
+	});
+});
+
+// ============================================================================
+// getAgentsByRole Tests
+// ============================================================================
+
+describe('getAgentsByRole', () => {
+	beforeEach(() => vi.clearAllMocks());
+
+	it('should return error for missing project_id', async () => {
+		const ctx = createMockContext();
+
+		const result = await getAgentsByRole({}, ctx);
+
+		expect(result.result).toMatchObject({
+			error: 'project_id is required',
+		});
+	});
+
+	it('should get agents by role successfully', async () => {
+		const mockAgentsByRole = {
+			developer: [
+				{ session_id: 'session-1', agent_name: 'Edge', status: 'active' },
+			],
+			validator: [],
+			deployer: [],
+			reviewer: [],
+			maintainer: [],
+		};
+		mockApiClient.proxy.mockResolvedValue({
+			ok: true,
+			data: { agents_by_role: mockAgentsByRole, total_active: 1 },
+		});
+		const ctx = createMockContext();
+
+		const result = await getAgentsByRole(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			agents_by_role: mockAgentsByRole,
+			total_active: 1,
+		});
+		expect(mockApiClient.proxy).toHaveBeenCalledWith(
+			'get_agents_by_role',
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000', counts_only: true }
+		);
+	});
+
+	it('should return error from API', async () => {
+		mockApiClient.proxy.mockResolvedValue({
+			ok: false,
+			error: 'Project not found',
+		});
+		const ctx = createMockContext();
+
+		const result = await getAgentsByRole(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.result).toMatchObject({
+			error: 'Project not found',
+		});
+	});
+});