@vibescope/mcp-server 0.2.0 → 0.2.2

package/src/handlers/decisions.test.ts

@@ -119,23 +119,26 @@ describe('logDecision', () => {
 		);
 	});
 
-	it('should throw error when API call fails', async () => {
+	it('should return error when API call fails', async () => {
 		mockApiClient.logDecision.mockResolvedValue({
 			ok: false,
 			error: 'Insert failed',
 		});
 		const ctx = createMockContext();
 
-		await expect(
-			logDecision(
-				{
-					project_id: '123e4567-e89b-12d3-a456-426614174000',
-					title: 'Test',
-					description: 'Test',
-				},
-				ctx
-			)
-		).rejects.toThrow('Failed to log decision: Insert failed');
+		const result = await logDecision(
+			{
+				project_id: '123e4567-e89b-12d3-a456-426614174000',
+				title: 'Test',
+				description: 'Test',
+			},
+			ctx
+		);
+
+		expect(result.isError).toBe(true);
+		expect(result.result).toMatchObject({
+			error: 'Insert failed',
+		});
 	});
 });
 
@@ -198,7 +201,7 @@ describe('getDecisions', () => {
 		});
 	});
 
-	it('should call API client getDecisions', async () => {
+	it('should call API client getDecisions with options', async () => {
 		mockApiClient.getDecisions.mockResolvedValue({
 			ok: true,
 			data: { decisions: [] },
@@ -211,23 +214,27 @@ describe('getDecisions', () => {
 		);
 
 		expect(mockApiClient.getDecisions).toHaveBeenCalledWith(
-			'123e4567-e89b-12d3-a456-426614174000'
+			'123e4567-e89b-12d3-a456-426614174000',
+			{ limit: 50, offset: 0, search_query: undefined }
 		);
 	});
 
-	it('should throw error when query fails', async () => {
+	it('should return error when query fails', async () => {
 		mockApiClient.getDecisions.mockResolvedValue({
 			ok: false,
 			error: 'Query failed',
 		});
 		const ctx = createMockContext();
 
-		await expect(
-			getDecisions(
-				{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-				ctx
-			)
-		).rejects.toThrow('Failed to fetch decisions: Query failed');
+		const result = await getDecisions(
+			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.isError).toBe(true);
+		expect(result.result).toMatchObject({
+			error: 'Query failed',
+		});
 	});
 });
 
@@ -286,18 +293,21 @@ describe('deleteDecision', () => {
 		);
 	});
 
-	it('should throw error when delete fails', async () => {
+	it('should return error when delete fails', async () => {
 		mockApiClient.deleteDecision.mockResolvedValue({
 			ok: false,
 			error: 'Delete failed',
 		});
 		const ctx = createMockContext();
 
-		await expect(
-			deleteDecision(
-				{ decision_id: '123e4567-e89b-12d3-a456-426614174000' },
-				ctx
-			)
-		).rejects.toThrow('Failed to delete decision: Delete failed');
+		const result = await deleteDecision(
+			{ decision_id: '123e4567-e89b-12d3-a456-426614174000' },
+			ctx
+		);
+
+		expect(result.isError).toBe(true);
+		expect(result.result).toMatchObject({
+			error: 'Delete failed',
+		});
 	});
 });

package/src/handlers/decisions.ts

@@ -10,22 +10,31 @@
  */
 
 import type { Handler, HandlerRegistry } from './types.js';
-import { validateRequired, validateUUID } from '../validators.js';
+import { parseArgs, uuidValidator } from '../validators.js';
 import { getApiClient } from '../api-client.js';
 
-export const logDecision: Handler = async (args, ctx) => {
-	const { project_id, title, description, rationale, alternatives_considered } = args as {
-		project_id: string;
-		title: string;
-		description: string;
-		rationale?: string;
-		alternatives_considered?: string[];
-	};
+// Argument schemas for type-safe parsing
+const logDecisionSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	title: { type: 'string' as const, required: true as const },
+	description: { type: 'string' as const, required: true as const },
+	rationale: { type: 'string' as const },
+	alternatives_considered: { type: 'array' as const },
+};
 
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
-	validateRequired(title, 'title');
-	validateRequired(description, 'description');
+const getDecisionsSchema = {
+	project_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+	limit: { type: 'number' as const, default: 50 },
+	offset: { type: 'number' as const, default: 0 },
+	search_query: { type: 'string' as const },
+};
+
+const deleteDecisionSchema = {
+	decision_id: { type: 'string' as const, required: true as const, validate: uuidValidator },
+};
+
+export const logDecision: Handler = async (args, ctx) => {
+	const { project_id, title, description, rationale, alternatives_considered } = parseArgs(args, logDecisionSchema);
 
 	const { session } = ctx;
 	const apiClient = getApiClient();
@@ -34,30 +43,29 @@ export const logDecision: Handler = async (args, ctx) => {
 		title,
 		description,
 		rationale,
-		alternatives_considered
+		alternatives_considered: alternatives_considered as string[] | undefined
 	}, session.currentSessionId || undefined);
 
 	if (!response.ok) {
-		throw new Error(`Failed to log decision: ${response.error}`);
+		return { result: { error: response.error || 'Failed to log decision' }, isError: true };
 	}
 
 	return { result: { success: true, title, decision_id: response.data?.decision_id } };
 };
 
-export const getDecisions: Handler = async (args, ctx) => {
-	const { project_id } = args as {
-		project_id: string;
-	};
-
-	validateRequired(project_id, 'project_id');
-	validateUUID(project_id, 'project_id');
+export const getDecisions: Handler = async (args, _ctx) => {
+	const { project_id, limit, offset, search_query } = parseArgs(args, getDecisionsSchema);
 
 	const apiClient = getApiClient();
 
-	const response = await apiClient.getDecisions(project_id);
+	const response = await apiClient.getDecisions(project_id, {
+		limit,
+		offset,
+		search_query
+	});
 
 	if (!response.ok) {
-		throw new Error(`Failed to fetch decisions: ${response.error}`);
+		return { result: { error: response.error || 'Failed to fetch decisions' }, isError: true };
 	}
 
 	return {
@@ -67,18 +75,15 @@ export const getDecisions: Handler = async (args, ctx) => {
 	};
 };
 
-export const deleteDecision: Handler = async (args, ctx) => {
-	const { decision_id } = args as { decision_id: string };
-
-	validateRequired(decision_id, 'decision_id');
-	validateUUID(decision_id, 'decision_id');
+export const deleteDecision: Handler = async (args, _ctx) => {
+	const { decision_id } = parseArgs(args, deleteDecisionSchema);
 
 	const apiClient = getApiClient();
 
 	const response = await apiClient.deleteDecision(decision_id);
 
 	if (!response.ok) {
-		throw new Error(`Failed to delete decision: ${response.error}`);
+		return { result: { error: response.error || 'Failed to delete decision' }, isError: true };
 	}
 
 	return { result: { success: true } };