@vibeorm/migrate 2.0.0-alpha.5 → 2.0.0-alpha.7

package/dist/runner.d.ts

@@ -2,21 +2,40 @@
  * Migration runner: generate named migrations from IR diffs, apply them with
  * bookkeeping in `_vibe_migrations`, report status, and repair records.
  *
- * Concurrency: `applyMigrations` takes an advisory lock for the whole run —
- * `pg_advisory_lock(1447645253)` on postgres ("VIBE" in ASCII, blocking,
- * released in a finally), `GET_LOCK('vibeorm_migrate', 60)` on mysql (throws
- * VIBE_MIGRATION on timeout). sqlite needs none: it is single-writer and
- * `BEGIN` serializes. Locks are session-scoped — the SqlExecutor contract
- * (types.ts) requires one session for the whole operation.
+ * Concurrency: `applyMigrations` and `rollbackMigration` take an advisory lock
+ * for the whole run — `pg_advisory_lock(1447645253)` on postgres ("VIBE" in
+ * ASCII, blocking, released in a finally), `GET_LOCK('vibeorm_migrate', 60)`
+ * on mysql (throws VIBE_MIGRATION on timeout). sqlite needs none: it is
+ * single-writer and `BEGIN` serializes. Locks are session-scoped — the
+ * SqlExecutor contract (types.ts) requires one session for the whole
+ * operation.
  *
- * Execution strategy per dialect (`DIALECT_CAPABILITIES[dialect]`):
+ * Lock ORDER matters: the lock is taken BEFORE `ensureMigrationsTable`, never
+ * after. Two concurrent first-time runs against a fresh postgres database
+ * would otherwise both issue `CREATE TABLE IF NOT EXISTS _vibe_migrations`,
+ * which is a catalog race on postgres (a duplicate-key error on
+ * `pg_type_typname_nsp_index`, not a no-op). `migrationStatus` and
+ * `resolveMigration` deliberately take NO lock — wrapping reads in the
+ * migration lock would make `status` block behind a running migrate — so two
+ * concurrent FIRST-EVER `status`/`resolve` calls on a fresh database can still
+ * hit that race; retrying either is enough, since the table then exists.
+ *
+ * Execution strategy per dialect (`DIALECT_CAPABILITIES[dialect]`) AND per
+ * script:
  *
  * - transactionalDdl (postgres, sqlite): each migration runs inside
- *   BEGIN/COMMIT with its bookkeeping INSERT — atomic. EXCEPT sqlite scripts
- *   containing a table-rebuild block, which manage their own transactions
- *   (execute.ts `usesSelfManagedTransactions`); those run unwrapped and are
- *   re-runnable (the rebuild recipe is effectively idempotent), with the
- *   record written after the script completes.
+ *   BEGIN/COMMIT with its bookkeeping INSERT — atomic.
+ * - EXCEPT sqlite scripts containing a table-rebuild block, which manage their
+ *   own transactions (execute.ts `usesSelfManagedTransactions`) and therefore
+ *   cannot be wrapped. Those take the SAME per-statement bookkeeping as mysql
+ *   (below). They are NOT simply "re-runnable": a pure rebuild block is
+ *   effectively idempotent, but any plain statement in the same script
+ *   auto-commits on its own, so without a recorded statement_index a crash
+ *   wedged the migration forever (every later run replayed statements that had
+ *   already run). Resuming into a rebuild block rewinds to that block's
+ *   `PRAGMA foreign_keys=OFF` (execute.ts `selfManagedResumeStart`): the block
+ *   is transactional, so nothing of it survived, and the pragma is
+ *   session-scoped and gone after a crash.
  * - mysql (transactionalDdl: false — DDL auto-commits): the runner records
  *   PER-STATEMENT progress instead. The row is inserted up front
  *   (statement_index 0), advanced after every statement, and on failure the
@@ -26,6 +45,10 @@
  *   reaches the statement count (or its checksum is empty — resolveMigration
  *   records, which store statement_index 2147483647).
  *
+ * `usesStatementBookkeeping` is the ONE predicate deciding which of the two
+ * regimes a (dialect, script) pair is in; apply, status and rollback all read
+ * it, so they can never disagree about whether a record is complete.
+ *
  * Checksums (sha256 over the joined SQL) pin a migration's content:
  * re-applying a renamed-or-edited migration is a VIBE_MIGRATION error, never
  * a silent divergence.
@@ -61,7 +84,8 @@ export declare function generateMigration(params: {
  * Apply migrations in order under an advisory lock (see module doc).
  * Already-recorded migrations are checksum-verified and skipped; a mismatch
  * throws VIBE_MIGRATION (a recorded migration whose SQL changed is
- * corruption, not drift to paper over). On mysql, a partially-applied
+ * corruption, not drift to paper over). Where progress is recorded per
+ * statement (mysql, and self-managed sqlite scripts), a partially-applied
  * migration RESUMES from its recorded statement_index. Records created by
  * `resolveMigration` (empty checksum) skip verification.
  */
@@ -101,15 +125,17 @@ export declare function resolveMigration(params: {
  * the record pins a checksum — its up SQL must still match (rolling back with
  * drifted files would run a down that no longer mirrors what was applied).
  *
- * Dialect behavior mirrors apply: postgres/sqlite run the down inside
- * BEGIN/COMMIT with the bookkeeping DELETE (atomic; sqlite rebuild scripts
- * run unwrapped, see module doc). mysql DDL auto-commits, so progress is
- * recorded per-statement in the existing `statement_index` column, NEGATIVE
- * to mark the rollback direction: after k down statements, the row stores
- * -(k+1). A failed mysql rollback resumes from the recorded statement on the
- * next call; `applyMigrations` refuses a mid-rollback record. A partially
- * APPLIED mysql migration cannot be rolled back — its down mirrors the full
- * up; finish applying (apply resumes) or repair with `resolveMigration`.
+ * Dialect behavior mirrors apply exactly (same `usesStatementBookkeeping`
+ * predicate, read over the DOWN script): postgres/sqlite run the down inside
+ * BEGIN/COMMIT with the bookkeeping DELETE (atomic). mysql DDL auto-commits,
+ * and a sqlite down containing a table-rebuild block cannot be wrapped, so
+ * both record progress per-statement in the existing `statement_index`
+ * column, NEGATIVE to mark the rollback direction: after k down statements,
+ * the row stores -(k+1). A failed rollback resumes from the recorded
+ * statement on the next call; `applyMigrations` refuses a mid-rollback record
+ * (that check reads the sign only, so it holds for every dialect). A
+ * partially APPLIED migration cannot be rolled back — its down mirrors the
+ * full up; finish applying (apply resumes) or repair with `resolveMigration`.
  */
 export declare function rollbackMigration(params: {
     executor: SqlExecutor;

package/dist/runner.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"runner.d.ts","sourceRoot":"","sources":["../src/runner.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AAIH,OAAO,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAexE,OAAO,KAAK,EAAE,aAAa,EAAE,aAAa,EAAE,eAAe,EAAE,WAAW,EAAE,MAAM,YAAY,CAAC;AAI7F,2EAA2E;AAC3E,eAAO,MAAM,qBAAqB,EAAE,MAA2B,CAAC;AAsChE,iDAAiD;AACjD,wBAAsB,qBAAqB,CAAC,MAAM,EAAE;IAClD,QAAQ,EAAE,WAAW,CAAC;IACtB,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAEhB;AAED,6EAA6E;AAC7E,wBAAgB,iBAAiB,CAAC,MAAM,EAAE;IAAE,GAAG,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,GAAG,MAAM,CAE5E;AAID;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE;IACxC,IAAI,EAAE,QAAQ,CAAC;IACf,EAAE,EAAE,QAAQ,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,8EAA8E;IAC9E,UAAU,CAAC,EAAE,SAAS,aAAa,EAAE,CAAC;CACvC,GAAG,aAAa,CA6BhB;AAID;;;;;;;GAOG;AACH,wBAAsB,eAAe,CAAC,MAAM,EAAE;IAC5C,QAAQ,EAAE,WAAW,CAAC;IACtB,UAAU,EAAE,SAAS,aAAa,EAAE,CAAC;IACrC,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,aAAa,CAAC,CA6DzB;AAID,8DAA8D;AAC9D,wBAAsB,eAAe,CAAC,MAAM,EAAE;IAC5C,QAAQ,EAAE,WAAW,CAAC;IACtB,UAAU,EAAE,SAAS,aAAa,EAAE,CAAC;IACrC,gDAAgD;IAChD,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,eAAe,CAAC,CAqC3B;AAID;;;;;GAKG;AACH,wBAAsB,gBAAgB,CAAC,MAAM,EAAE;IAC7C,QAAQ,EAAE,WAAW,CAAC;IACtB,IAAI,EAAE,MAAM,CAAC;IACb,EAAE,EAAE,SAAS,GAAG,aAAa,CAAC;IAC9B,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,gDAAgD;IAChD,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAkBhB;AAID;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAsB,iBAAiB,CAAC,MAAM,EAAE;IAC9C,QAAQ,EAAE,WAAW,CAAC;IACtB,SAAS,EAAE,aAAa,CAAC;IACzB,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAsDhB"}
+{"version":3,"file":"runner.d.ts","sourceRoot":"","sources":["../src/runner.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAsDG;AAIH,OAAO,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAgBxE,OAAO,KAAK,EAAE,aAAa,EAAE,aAAa,EAAE,eAAe,EAAE,WAAW,EAAE,MAAM,YAAY,CAAC;AAI7F,2EAA2E;AAC3E,eAAO,MAAM,qBAAqB,EAAE,MAA2B,CAAC;AAsChE,iDAAiD;AACjD,wBAAsB,qBAAqB,CAAC,MAAM,EAAE;IAClD,QAAQ,EAAE,WAAW,CAAC;IACtB,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAEhB;AAED,6EAA6E;AAC7E,wBAAgB,iBAAiB,CAAC,MAAM,EAAE;IAAE,GAAG,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,GAAG,MAAM,CAE5E;AAID;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE;IACxC,IAAI,EAAE,QAAQ,CAAC;IACf,EAAE,EAAE,QAAQ,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,8EAA8E;IAC9E,UAAU,CAAC,EAAE,SAAS,aAAa,EAAE,CAAC;CACvC,GAAG,aAAa,CA6BhB;AAID;;;;;;;;GAQG;AACH,wBAAsB,eAAe,CAAC,MAAM,EAAE;IAC5C,QAAQ,EAAE,WAAW,CAAC;IACtB,UAAU,EAAE,SAAS,aAAa,EAAE,CAAC;IACrC,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,aAAa,CAAC,CA4DzB;AAID,8DAA8D;AAC9D,wBAAsB,eAAe,CAAC,MAAM,EAAE;IAC5C,QAAQ,EAAE,WAAW,CAAC;IACtB,UAAU,EAAE,SAAS,aAAa,EAAE,CAAC;IACrC,gDAAgD;IAChD,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,eAAe,CAAC,CAsC3B;AAID;;;;;GAKG;AACH,wBAAsB,gBAAgB,CAAC,MAAM,EAAE;IAC7C,QAAQ,EAAE,WAAW,CAAC;IACtB,IAAI,EAAE,MAAM,CAAC;IACb,EAAE,EAAE,SAAS,GAAG,aAAa,CAAC;IAC9B,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,gDAAgD;IAChD,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAkBhB;AAID;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,wBAAsB,iBAAiB,CAAC,MAAM,EAAE;IAC9C,QAAQ,EAAE,WAAW,CAAC;IACtB,SAAS,EAAE,aAAa,CAAC;IACzB,8CAA8C;IAC9C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB,GAAG,OAAO,CAAC,IAAI,CAAC,CAsDhB"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vibeorm/migrate",
-  "version": "2.0.0-alpha.5",
+  "version": "2.0.0-alpha.7",
   "description": "Migration engine for VibeORM v2 — IR differ, per-dialect DDL, migration runner, introspection",
   "keywords": [
     "orm",
@@ -44,8 +44,8 @@
     "bun": ">=1.2.0"
   },
   "dependencies": {
-    "@vibeorm/schema": "2.0.0-alpha.4",
-    "@vibeorm/sql": "2.0.0-alpha.4"
+    "@vibeorm/schema": "2.0.0-alpha.5",
+    "@vibeorm/sql": "2.0.0-alpha.5"
   },
   "publishConfig": {
     "access": "public"