@vibecheckai/cli 3.5.0 → 3.5.2

package/bin/runners/lib/polish/backend-checks.js

@@ -1,148 +0,0 @@
-/**
- * Backend Polish Checks
- * 
- * Checks for backend production readiness:
- * - Health endpoints
- * - Graceful shutdown
- * - Rate limiting
- * - Input validation
- */
-
-"use strict";
-
-const path = require("path");
-const { pathExists, findAllFiles, fileContains, readFileSafe } = require('./utils');
-const { detectInstalledLibraries } = require('./library-detection');
-
-/**
- * Check for health endpoint
- */
-async function checkHealthEndpoint(projectPath, options = {}) {
-  const findings = [];
-  
-  // Search for health endpoint patterns
-  const files = await findAllFiles(projectPath, /\.(ts|js)$/);
-  let hasHealthEndpoint = false;
-  
-  for (const file of files) {
-    const content = await readFileSafe(file);
-    if (content && /\/health|\/healthz|\/ready|\/live/i.test(content)) {
-      hasHealthEndpoint = true;
-      break;
-    }
-  }
-  
-  if (!hasHealthEndpoint) {
-    findings.push({
-      id: 'missing-health-endpoint',
-      category: 'backend',
-      priority: 'high',
-      title: 'Missing Health Check Endpoint',
-      description: 'No health check endpoint found. Required for container orchestration (K8s, ECS).',
-      fix: 'Add a /health or /healthz endpoint that returns 200 OK',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for graceful shutdown handling
- */
-async function checkGracefulShutdown(projectPath, options = {}) {
-  const findings = [];
-  
-  const files = await findAllFiles(projectPath, /\.(ts|js)$/);
-  let hasGracefulShutdown = false;
-  
-  for (const file of files) {
-    const content = await readFileSafe(file);
-    if (content && /SIGTERM|SIGINT|graceful.*shutdown|process\.on.*exit/i.test(content)) {
-      hasGracefulShutdown = true;
-      break;
-    }
-  }
-  
-  if (!hasGracefulShutdown) {
-    findings.push({
-      id: 'missing-graceful-shutdown',
-      category: 'backend',
-      priority: 'medium',
-      title: 'No Graceful Shutdown Handler',
-      description: 'No SIGTERM/SIGINT handlers found. Server may not shut down cleanly.',
-      fix: 'Add process.on("SIGTERM", ...) to handle graceful shutdown',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for rate limiting
- */
-async function checkRateLimiting(projectPath, options = {}) {
-  const findings = [];
-  const { coverage } = detectInstalledLibraries(projectPath);
-  
-  if (coverage.rateLimiting && coverage.rateLimiting.length > 0) {
-    return findings;
-  }
-  
-  // Search for rate limiting patterns
-  const files = await findAllFiles(projectPath, /\.(ts|js)$/);
-  let hasRateLimiting = false;
-  
-  for (const file of files) {
-    const content = await readFileSafe(file);
-    if (content && /rateLimit|rate-limit|throttle|limiter/i.test(content)) {
-      hasRateLimiting = true;
-      break;
-    }
-  }
-  
-  if (!hasRateLimiting) {
-    findings.push({
-      id: 'missing-rate-limiting',
-      category: 'backend',
-      priority: 'high',
-      title: 'No Rate Limiting',
-      description: 'No rate limiting found. API is vulnerable to abuse and DoS attacks.',
-      fix: 'Install express-rate-limit or similar package to protect your API',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Run all backend checks
- */
-async function runChecks(projectPath, options = {}) {
-  const allFindings = [];
-  
-  const checks = [
-    checkHealthEndpoint,
-    checkGracefulShutdown,
-    checkRateLimiting,
-  ];
-  
-  for (const check of checks) {
-    try {
-      const findings = await check(projectPath, options);
-      allFindings.push(...findings);
-    } catch (error) {
-      if (options.verbose) {
-        console.warn(`Check failed: ${check.name}`, error.message);
-      }
-    }
-  }
-  
-  return allFindings;
-}
-
-module.exports = {
-  runChecks,
-  checkHealthEndpoint,
-  checkGracefulShutdown,
-  checkRateLimiting,
-};

package/bin/runners/lib/polish/documentation-checks.js

@@ -1,111 +0,0 @@
-/**
- * Documentation Polish Checks
- * 
- * Checks for documentation completeness:
- * - README.md
- * - API documentation
- * - CHANGELOG
- * - Contributing guide
- */
-
-"use strict";
-
-const path = require("path");
-const { pathExists, readFileSafe } = require('./utils');
-
-/**
- * Check for README.md
- */
-async function checkReadme(projectPath, options = {}) {
-  const findings = [];
-  
-  const hasReadme = await pathExists(path.join(projectPath, 'README.md'));
-  
-  if (!hasReadme) {
-    findings.push({
-      id: 'missing-readme',
-      category: 'documentation',
-      priority: 'medium',
-      title: 'Missing README.md',
-      description: 'No README.md found. New users won\'t know how to use this project.',
-      fix: 'Create a README.md with setup instructions and usage examples',
-    });
-    return findings;
-  }
-  
-  // Check README quality
-  const readme = await readFileSafe(path.join(projectPath, 'README.md'));
-  if (readme && readme.length < 200) {
-    findings.push({
-      id: 'readme-too-short',
-      category: 'documentation',
-      priority: 'low',
-      title: 'README.md Too Short',
-      description: 'README has minimal content. Consider adding more details.',
-      fix: 'Expand README with installation, usage, and configuration sections',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for CHANGELOG
- */
-async function checkChangelog(projectPath, options = {}) {
-  const findings = [];
-  
-  const changelogPaths = ['CHANGELOG.md', 'HISTORY.md', 'CHANGES.md'];
-  let hasChangelog = false;
-  
-  for (const p of changelogPaths) {
-    if (await pathExists(path.join(projectPath, p))) {
-      hasChangelog = true;
-      break;
-    }
-  }
-  
-  if (!hasChangelog) {
-    findings.push({
-      id: 'missing-changelog',
-      category: 'documentation',
-      priority: 'low',
-      title: 'Missing CHANGELOG',
-      description: 'No changelog found. Hard to track version changes.',
-      fix: 'Create CHANGELOG.md to document version history',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Run all documentation checks
- */
-async function runChecks(projectPath, options = {}) {
-  const allFindings = [];
-  
-  const checks = [
-    checkReadme,
-    checkChangelog,
-  ];
-  
-  for (const check of checks) {
-    try {
-      const findings = await check(projectPath, options);
-      allFindings.push(...findings);
-    } catch (error) {
-      if (options.verbose) {
-        console.warn(`Check failed: ${check.name}`, error.message);
-      }
-    }
-  }
-  
-  return allFindings;
-}
-
-module.exports = {
-  runChecks,
-  checkReadme,
-  checkChangelog,
-};

package/bin/runners/lib/polish/frontend-checks.js

@@ -1,168 +0,0 @@
-/**
- * Frontend Polish Checks
- * 
- * Checks for frontend production readiness:
- * - Error boundaries
- * - 404 pages
- * - Loading states
- * - Empty states
- * - Toast notifications
- */
-
-"use strict";
-
-const path = require("path");
-const { pathExists, findAllFiles, fileContains, readFileSafe } = require('./utils');
-const { hasLibrary, detectInstalledLibraries } = require('./library-detection');
-
-/**
- * Check for error boundary implementation
- */
-async function checkErrorBoundary(projectPath, options = {}) {
-  const findings = [];
-  const { deps, coverage } = detectInstalledLibraries(projectPath);
-  
-  // Skip if using error boundary library
-  if (coverage.errorBoundary && coverage.errorBoundary.length > 0) {
-    return findings;
-  }
-  
-  // Check for custom error boundary
-  const files = await findAllFiles(projectPath, /\.(tsx?|jsx?)$/);
-  let hasErrorBoundary = false;
-  
-  for (const file of files) {
-    const content = await readFileSafe(file);
-    if (content && /componentDidCatch|ErrorBoundary|error-boundary/i.test(content)) {
-      hasErrorBoundary = true;
-      break;
-    }
-  }
-  
-  if (!hasErrorBoundary) {
-    findings.push({
-      id: 'missing-error-boundary',
-      category: 'frontend',
-      priority: 'high',
-      title: 'Missing Error Boundary',
-      description: 'No React Error Boundary found. Add one to gracefully handle JavaScript errors.',
-      fix: 'Install react-error-boundary or create a custom ErrorBoundary component',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for 404 page
- */
-async function check404Page(projectPath, options = {}) {
-  const findings = [];
-  
-  // Check common 404 page locations
-  const possiblePaths = [
-    'pages/404.tsx',
-    'pages/404.jsx',
-    'pages/404.js',
-    'app/not-found.tsx',
-    'app/not-found.jsx',
-    'app/not-found.js',
-    'src/pages/404.tsx',
-    'src/pages/404.jsx',
-    'src/app/not-found.tsx',
-  ];
-  
-  let has404 = false;
-  for (const p of possiblePaths) {
-    if (await pathExists(path.join(projectPath, p))) {
-      has404 = true;
-      break;
-    }
-  }
-  
-  if (!has404) {
-    findings.push({
-      id: 'missing-404-page',
-      category: 'frontend',
-      priority: 'medium',
-      title: 'Missing 404 Page',
-      description: 'No custom 404 page found. Users will see a generic error.',
-      fix: 'Create a pages/404.tsx (Next.js Pages) or app/not-found.tsx (Next.js App Router)',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for loading states
- */
-async function checkLoadingStates(projectPath, options = {}) {
-  const findings = [];
-  const { coverage } = detectInstalledLibraries(projectPath);
-  
-  // Skip if using loading/skeleton libraries
-  if ((coverage.spinner && coverage.spinner.length > 0) ||
-      (coverage.skeleton && coverage.skeleton.length > 0)) {
-    return findings;
-  }
-  
-  // Check for loading patterns in code
-  const files = await findAllFiles(projectPath, /\.(tsx?|jsx?)$/);
-  let hasLoadingPattern = false;
-  
-  for (const file of files) {
-    const content = await readFileSafe(file);
-    if (content && /isLoading|loading\s*\?|Spinner|Skeleton|LoadingState/i.test(content)) {
-      hasLoadingPattern = true;
-      break;
-    }
-  }
-  
-  if (!hasLoadingPattern) {
-    findings.push({
-      id: 'missing-loading-states',
-      category: 'frontend',
-      priority: 'medium',
-      title: 'No Loading States Found',
-      description: 'No loading indicators found. Users may think the app is frozen during data fetching.',
-      fix: 'Add loading states to async operations using isLoading flags or skeleton components',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Run all frontend checks
- */
-async function runChecks(projectPath, options = {}) {
-  const allFindings = [];
-  
-  const checks = [
-    checkErrorBoundary,
-    check404Page,
-    checkLoadingStates,
-  ];
-  
-  for (const check of checks) {
-    try {
-      const findings = await check(projectPath, options);
-      allFindings.push(...findings);
-    } catch (error) {
-      // Log but don't fail
-      if (options.verbose) {
-        console.warn(`Check failed: ${check.name}`, error.message);
-      }
-    }
-  }
-  
-  return allFindings;
-}
-
-module.exports = {
-  runChecks,
-  checkErrorBoundary,
-  check404Page,
-  checkLoadingStates,
-};

package/bin/runners/lib/polish/index.js

@@ -1,71 +0,0 @@
-/**
- * Polish Checks - Modular Production Readiness Checks
- * 
- * Extracted from runPolish.js for maintainability and testability.
- * Each category has its own module with specific checks.
- */
-
-"use strict";
-
-// Re-export check modules
-const frontendChecks = require('./frontend-checks');
-const backendChecks = require('./backend-checks');
-const securityChecks = require('./security-checks');
-const performanceChecks = require('./performance-checks');
-const documentationChecks = require('./documentation-checks');
-const infrastructureChecks = require('./infrastructure-checks');
-
-// Utility functions
-const { pathExists, readFileSafe, fileContains, findAllFiles } = require('./utils');
-
-// Library detection
-const { LIBRARY_ALTERNATIVES, hasLibrary, detectInstalledLibraries } = require('./library-detection');
-
-module.exports = {
-  // Check modules
-  frontendChecks,
-  backendChecks,
-  securityChecks,
-  performanceChecks,
-  documentationChecks,
-  infrastructureChecks,
-  
-  // Utilities
-  pathExists,
-  readFileSafe,
-  fileContains,
-  findAllFiles,
-  
-  // Library detection
-  LIBRARY_ALTERNATIVES,
-  hasLibrary,
-  detectInstalledLibraries,
-  
-  // Run all checks
-  async runAllChecks(projectPath, options = {}) {
-    const results = {
-      frontend: await frontendChecks.runChecks(projectPath, options),
-      backend: await backendChecks.runChecks(projectPath, options),
-      security: await securityChecks.runChecks(projectPath, options),
-      performance: await performanceChecks.runChecks(projectPath, options),
-      documentation: await documentationChecks.runChecks(projectPath, options),
-      infrastructure: await infrastructureChecks.runChecks(projectPath, options),
-    };
-    
-    // Calculate totals
-    const allFindings = Object.values(results).flat();
-    const byPriority = {
-      critical: allFindings.filter(f => f.priority === 'critical').length,
-      high: allFindings.filter(f => f.priority === 'high').length,
-      medium: allFindings.filter(f => f.priority === 'medium').length,
-      low: allFindings.filter(f => f.priority === 'low').length,
-    };
-    
-    return {
-      findings: allFindings,
-      byCategory: results,
-      byPriority,
-      total: allFindings.length,
-    };
-  },
-};

package/bin/runners/lib/polish/infrastructure-checks.js

@@ -1,131 +0,0 @@
-/**
- * Infrastructure Polish Checks
- * 
- * Checks for infrastructure configuration:
- * - Docker setup
- * - CI/CD configuration
- * - Monitoring setup
- */
-
-"use strict";
-
-const path = require("path");
-const { pathExists, readFileSafe } = require('./utils');
-const { detectInstalledLibraries } = require('./library-detection');
-
-/**
- * Check for Docker configuration
- */
-async function checkDocker(projectPath, options = {}) {
-  const findings = [];
-  
-  const hasDockerfile = await pathExists(path.join(projectPath, 'Dockerfile'));
-  const hasDockerCompose = await pathExists(path.join(projectPath, 'docker-compose.yml')) ||
-                           await pathExists(path.join(projectPath, 'docker-compose.yaml'));
-  
-  if (!hasDockerfile) {
-    findings.push({
-      id: 'missing-dockerfile',
-      category: 'infrastructure',
-      priority: 'medium',
-      title: 'Missing Dockerfile',
-      description: 'No Dockerfile found. Containerization recommended for production.',
-      fix: 'Create a Dockerfile for consistent deployments',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for CI/CD configuration
- */
-async function checkCICD(projectPath, options = {}) {
-  const findings = [];
-  
-  const ciPaths = [
-    '.github/workflows',
-    '.gitlab-ci.yml',
-    '.circleci/config.yml',
-    'Jenkinsfile',
-    '.travis.yml',
-    'azure-pipelines.yml',
-  ];
-  
-  let hasCICD = false;
-  for (const p of ciPaths) {
-    if (await pathExists(path.join(projectPath, p))) {
-      hasCICD = true;
-      break;
-    }
-  }
-  
-  if (!hasCICD) {
-    findings.push({
-      id: 'missing-cicd',
-      category: 'infrastructure',
-      priority: 'medium',
-      title: 'No CI/CD Configuration',
-      description: 'No CI/CD pipeline found. Automated testing and deployment recommended.',
-      fix: 'Add GitHub Actions, GitLab CI, or similar CI/CD configuration',
-    });
-  }
-  
-  return findings;
-}
-
-/**
- * Check for monitoring setup
- */
-async function checkMonitoring(projectPath, options = {}) {
-  const findings = [];
-  const { coverage } = detectInstalledLibraries(projectPath);
-  
-  if (coverage.monitoring && coverage.monitoring.length > 0) {
-    return findings;
-  }
-  
-  findings.push({
-    id: 'no-monitoring',
-    category: 'infrastructure',
-    priority: 'medium',
-    title: 'No Monitoring Configured',
-    description: 'No monitoring/observability libraries found. Hard to debug production issues.',
-    fix: 'Add Sentry, DataDog, or OpenTelemetry for monitoring',
-  });
-  
-  return findings;
-}
-
-/**
- * Run all infrastructure checks
- */
-async function runChecks(projectPath, options = {}) {
-  const allFindings = [];
-  
-  const checks = [
-    checkDocker,
-    checkCICD,
-    checkMonitoring,
-  ];
-  
-  for (const check of checks) {
-    try {
-      const findings = await check(projectPath, options);
-      allFindings.push(...findings);
-    } catch (error) {
-      if (options.verbose) {
-        console.warn(`Check failed: ${check.name}`, error.message);
-      }
-    }
-  }
-  
-  return allFindings;
-}
-
-module.exports = {
-  runChecks,
-  checkDocker,
-  checkCICD,
-  checkMonitoring,
-};