@vibecheckai/cli 3.2.5 → 3.3.0

package/bin/runners/lib/doctor/modules/dependencies.js

@@ -1,325 +1,325 @@
-/**
- * Dependencies Diagnostics Module
- * 
- * Checks for outdated packages, vulnerabilities, and dependency health
- */
-
-const fs = require('fs');
-const path = require('path');
-const { execSync } = require('child_process');
-const { SEVERITY, CATEGORY, FIX_TYPE } = require('../types');
-
-const MODULE_ID = 'dependencies';
-
-function createDiagnostics(projectPath) {
-  return [
-    {
-      id: `${MODULE_ID}.outdated`,
-      name: 'Outdated Packages',
-      category: CATEGORY.DEPENDENCIES,
-      parallel: true,
-      check: async () => {
-        try {
-          // Try npm outdated (returns non-zero if outdated packages exist)
-          const result = execSync('npm outdated --json 2>/dev/null || echo "{}"', {
-            cwd: projectPath,
-            encoding: 'utf8',
-            timeout: 30000,
-            stdio: ['pipe', 'pipe', 'pipe'],
-          }).trim();
-          
-          const outdated = JSON.parse(result || '{}');
-          const count = Object.keys(outdated).length;
-          
-          const metadata = { count, packages: outdated };
-          
-          // Check for major version updates
-          const majorUpdates = Object.entries(outdated).filter(([_, info]) => {
-            const current = parseInt((info.current || '0').split('.')[0]);
-            const latest = parseInt((info.latest || '0').split('.')[0]);
-            return latest > current;
-          });
-          
-          if (majorUpdates.length > 0) {
-            return {
-              severity: SEVERITY.INFO,
-              message: `${count} outdated (${majorUpdates.length} major)`,
-              detail: `Major updates: ${majorUpdates.slice(0, 3).map(([n]) => n).join(', ')}${majorUpdates.length > 3 ? '...' : ''}`,
-              metadata,
-              fixes: [{
-                type: FIX_TYPE.COMMAND,
-                description: 'Update all packages',
-                command: 'npm update',
-                autoFixable: false,
-              }],
-            };
-          }
-          
-          if (count > 0) {
-            return {
-              severity: SEVERITY.INFO,
-              message: `${count} minor/patch updates available`,
-              metadata,
-            };
-          }
-          
-          return {
-            severity: SEVERITY.PASS,
-            message: 'All packages up to date',
-            metadata,
-          };
-        } catch {
-          return {
-            severity: SEVERITY.INFO,
-            message: 'Could not check for outdated packages',
-          };
-        }
-      },
-    },
-    {
-      id: `${MODULE_ID}.audit`,
-      name: 'Security Vulnerabilities',
-      category: CATEGORY.DEPENDENCIES,
-      parallel: true,
-      check: async () => {
-        try {
-          const result = execSync('npm audit --json 2>/dev/null || echo "{}"', {
-            cwd: projectPath,
-            encoding: 'utf8',
-            timeout: 60000,
-            stdio: ['pipe', 'pipe', 'pipe'],
-          }).trim();
-          
-          let audit;
-          try {
-            audit = JSON.parse(result || '{}');
-          } catch {
-            return {
-              severity: SEVERITY.INFO,
-              message: 'Could not parse audit results',
-            };
-          }
-          
-          const vulnerabilities = audit.metadata?.vulnerabilities || {};
-          const total = vulnerabilities.total || 0;
-          const critical = vulnerabilities.critical || 0;
-          const high = vulnerabilities.high || 0;
-          const moderate = vulnerabilities.moderate || 0;
-          const low = vulnerabilities.low || 0;
-          
-          const metadata = { total, critical, high, moderate, low };
-          
-          if (critical > 0) {
-            return {
-              severity: SEVERITY.ERROR,
-              message: `${critical} critical vulnerabilities`,
-              detail: `Total: ${total} (${high} high, ${moderate} moderate, ${low} low)`,
-              metadata,
-              fixes: [
-                {
-                  type: FIX_TYPE.COMMAND,
-                  description: 'Auto-fix vulnerabilities',
-                  command: 'npm audit fix',
-                  autoFixable: true,
-                },
-                {
-                  type: FIX_TYPE.COMMAND,
-                  description: 'Force fix (may have breaking changes)',
-                  command: 'npm audit fix --force',
-                  dangerous: true,
-                  autoFixable: false,
-                },
-              ],
-            };
-          }
-          
-          if (high > 0) {
-            return {
-              severity: SEVERITY.WARNING,
-              message: `${high} high severity vulnerabilities`,
-              detail: `Total: ${total} (${moderate} moderate, ${low} low)`,
-              metadata,
-              fixes: [{
-                type: FIX_TYPE.COMMAND,
-                description: 'Auto-fix vulnerabilities',
-                command: 'npm audit fix',
-                autoFixable: true,
-              }],
-            };
-          }
-          
-          if (total > 0) {
-            return {
-              severity: SEVERITY.INFO,
-              message: `${total} low/moderate vulnerabilities`,
-              metadata,
-            };
-          }
-          
-          return {
-            severity: SEVERITY.PASS,
-            message: 'No known vulnerabilities',
-            metadata,
-          };
-        } catch {
-          return {
-            severity: SEVERITY.INFO,
-            message: 'Could not run security audit',
-          };
-        }
-      },
-    },
-    {
-      id: `${MODULE_ID}.peer_deps`,
-      name: 'Peer Dependencies',
-      category: CATEGORY.DEPENDENCIES,
-      parallel: true,
-      check: async () => {
-        try {
-          const result = execSync('npm ls --json 2>&1 || true', {
-            cwd: projectPath,
-            encoding: 'utf8',
-            timeout: 30000,
-            stdio: ['pipe', 'pipe', 'pipe'],
-          });
-          
-          // Look for peer dependency warnings
-          const peerWarnings = (result.match(/WARN.*peer/gi) || []).length;
-          const missingPeers = (result.match(/missing peer/gi) || []).length;
-          
-          const metadata = { peerWarnings, missingPeers };
-          
-          if (missingPeers > 0) {
-            return {
-              severity: SEVERITY.WARNING,
-              message: `${missingPeers} missing peer dependencies`,
-              metadata,
-              fixes: [{
-                type: FIX_TYPE.COMMAND,
-                description: 'Install peer dependencies',
-                command: 'npm install --legacy-peer-deps',
-                autoFixable: false,
-              }],
-            };
-          }
-          
-          return {
-            severity: SEVERITY.PASS,
-            message: 'Peer dependencies satisfied',
-            metadata,
-          };
-        } catch {
-          return {
-            severity: SEVERITY.INFO,
-            message: 'Could not check peer dependencies',
-          };
-        }
-      },
-    },
-    {
-      id: `${MODULE_ID}.duplicate`,
-      name: 'Duplicate Packages',
-      category: CATEGORY.DEPENDENCIES,
-      parallel: true,
-      check: async () => {
-        try {
-          const result = execSync('npm dedupe --dry-run 2>&1 || true', {
-            cwd: projectPath,
-            encoding: 'utf8',
-            timeout: 30000,
-            stdio: ['pipe', 'pipe', 'pipe'],
-          });
-          
-          const wouldDedupe = result.includes('removed') || result.includes('dedupe');
-          
-          if (wouldDedupe) {
-            return {
-              severity: SEVERITY.INFO,
-              message: 'Deduplication possible',
-              fixes: [{
-                type: FIX_TYPE.COMMAND,
-                description: 'Deduplicate packages',
-                command: 'npm dedupe',
-                autoFixable: true,
-              }],
-            };
-          }
-          
-          return {
-            severity: SEVERITY.PASS,
-            message: 'No duplicates found',
-          };
-        } catch {
-          return {
-            severity: SEVERITY.INFO,
-            message: 'Could not check for duplicates',
-          };
-        }
-      },
-    },
-    {
-      id: `${MODULE_ID}.engines`,
-      name: 'Engine Requirements',
-      category: CATEGORY.DEPENDENCIES,
-      parallel: true,
-      check: async () => {
-        const pkgPath = path.join(projectPath, 'package.json');
-        
-        try {
-          const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
-          
-          if (!pkg.engines) {
-            return {
-              severity: SEVERITY.INFO,
-              message: 'No engine requirements specified',
-              fixes: [{
-                type: FIX_TYPE.MANUAL,
-                description: 'Add "engines" field to package.json to enforce Node version',
-                autoFixable: false,
-              }],
-            };
-          }
-          
-          const nodeReq = pkg.engines.node;
-          const npmReq = pkg.engines.npm;
-          
-          const metadata = { nodeReq, npmReq };
-          
-          // Basic semver check against current version
-          if (nodeReq) {
-            const currentMajor = parseInt(process.version.slice(1).split('.')[0]);
-            const minMatch = nodeReq.match(/>=?\s*(\d+)/);
-            const minRequired = minMatch ? parseInt(minMatch[1]) : 0;
-            
-            if (currentMajor < minRequired) {
-              return {
-                severity: SEVERITY.ERROR,
-                message: `Node ${process.version} does not satisfy "${nodeReq}"`,
-                metadata,
-                fixes: [{
-                  type: FIX_TYPE.COMMAND,
-                  description: `Upgrade to Node ${minRequired}+`,
-                  command: `nvm install ${minRequired}`,
-                  autoFixable: false,
-                }],
-              };
-            }
-          }
-          
-          return {
-            severity: SEVERITY.PASS,
-            message: nodeReq ? `node: ${nodeReq}` : 'Specified',
-            metadata,
-          };
-        } catch {
-          return {
-            severity: SEVERITY.INFO,
-            message: 'Could not check engine requirements',
-          };
-        }
-      },
-    },
-  ];
-}
-
-module.exports = { MODULE_ID, createDiagnostics };
+/**
+ * Dependencies Diagnostics Module
+ * 
+ * Checks for outdated packages, vulnerabilities, and dependency health
+ */
+
+const fs = require('fs');
+const path = require('path');
+const { execSync } = require('child_process');
+const { SEVERITY, CATEGORY, FIX_TYPE } = require('../types');
+
+const MODULE_ID = 'dependencies';
+
+function createDiagnostics(projectPath) {
+  return [
+    {
+      id: `${MODULE_ID}.outdated`,
+      name: 'Outdated Packages',
+      category: CATEGORY.DEPENDENCIES,
+      parallel: true,
+      check: async () => {
+        try {
+          // Try npm outdated (returns non-zero if outdated packages exist)
+          const result = execSync('npm outdated --json 2>/dev/null || echo "{}"', {
+            cwd: projectPath,
+            encoding: 'utf8',
+            timeout: 30000,
+            stdio: ['pipe', 'pipe', 'pipe'],
+          }).trim();
+          
+          const outdated = JSON.parse(result || '{}');
+          const count = Object.keys(outdated).length;
+          
+          const metadata = { count, packages: outdated };
+          
+          // Check for major version updates
+          const majorUpdates = Object.entries(outdated).filter(([_, info]) => {
+            const current = parseInt((info.current || '0').split('.')[0]);
+            const latest = parseInt((info.latest || '0').split('.')[0]);
+            return latest > current;
+          });
+          
+          if (majorUpdates.length > 0) {
+            return {
+              severity: SEVERITY.INFO,
+              message: `${count} outdated (${majorUpdates.length} major)`,
+              detail: `Major updates: ${majorUpdates.slice(0, 3).map(([n]) => n).join(', ')}${majorUpdates.length > 3 ? '...' : ''}`,
+              metadata,
+              fixes: [{
+                type: FIX_TYPE.COMMAND,
+                description: 'Update all packages',
+                command: 'npm update',
+                autoFixable: false,
+              }],
+            };
+          }
+          
+          if (count > 0) {
+            return {
+              severity: SEVERITY.INFO,
+              message: `${count} minor/patch updates available`,
+              metadata,
+            };
+          }
+          
+          return {
+            severity: SEVERITY.PASS,
+            message: 'All packages up to date',
+            metadata,
+          };
+        } catch {
+          return {
+            severity: SEVERITY.INFO,
+            message: 'Could not check for outdated packages',
+          };
+        }
+      },
+    },
+    {
+      id: `${MODULE_ID}.audit`,
+      name: 'Security Vulnerabilities',
+      category: CATEGORY.DEPENDENCIES,
+      parallel: true,
+      check: async () => {
+        try {
+          const result = execSync('npm audit --json 2>/dev/null || echo "{}"', {
+            cwd: projectPath,
+            encoding: 'utf8',
+            timeout: 60000,
+            stdio: ['pipe', 'pipe', 'pipe'],
+          }).trim();
+          
+          let audit;
+          try {
+            audit = JSON.parse(result || '{}');
+          } catch {
+            return {
+              severity: SEVERITY.INFO,
+              message: 'Could not parse audit results',
+            };
+          }
+          
+          const vulnerabilities = audit.metadata?.vulnerabilities || {};
+          const total = vulnerabilities.total || 0;
+          const critical = vulnerabilities.critical || 0;
+          const high = vulnerabilities.high || 0;
+          const moderate = vulnerabilities.moderate || 0;
+          const low = vulnerabilities.low || 0;
+          
+          const metadata = { total, critical, high, moderate, low };
+          
+          if (critical > 0) {
+            return {
+              severity: SEVERITY.ERROR,
+              message: `${critical} critical vulnerabilities`,
+              detail: `Total: ${total} (${high} high, ${moderate} moderate, ${low} low)`,
+              metadata,
+              fixes: [
+                {
+                  type: FIX_TYPE.COMMAND,
+                  description: 'Auto-fix vulnerabilities',
+                  command: 'npm audit fix',
+                  autoFixable: true,
+                },
+                {
+                  type: FIX_TYPE.COMMAND,
+                  description: 'Force fix (may have breaking changes)',
+                  command: 'npm audit fix --force',
+                  dangerous: true,
+                  autoFixable: false,
+                },
+              ],
+            };
+          }
+          
+          if (high > 0) {
+            return {
+              severity: SEVERITY.WARNING,
+              message: `${high} high severity vulnerabilities`,
+              detail: `Total: ${total} (${moderate} moderate, ${low} low)`,
+              metadata,
+              fixes: [{
+                type: FIX_TYPE.COMMAND,
+                description: 'Auto-fix vulnerabilities',
+                command: 'npm audit fix',
+                autoFixable: true,
+              }],
+            };
+          }
+          
+          if (total > 0) {
+            return {
+              severity: SEVERITY.INFO,
+              message: `${total} low/moderate vulnerabilities`,
+              metadata,
+            };
+          }
+          
+          return {
+            severity: SEVERITY.PASS,
+            message: 'No known vulnerabilities',
+            metadata,
+          };
+        } catch {
+          return {
+            severity: SEVERITY.INFO,
+            message: 'Could not run security audit',
+          };
+        }
+      },
+    },
+    {
+      id: `${MODULE_ID}.peer_deps`,
+      name: 'Peer Dependencies',
+      category: CATEGORY.DEPENDENCIES,
+      parallel: true,
+      check: async () => {
+        try {
+          const result = execSync('npm ls --json 2>&1 || true', {
+            cwd: projectPath,
+            encoding: 'utf8',
+            timeout: 30000,
+            stdio: ['pipe', 'pipe', 'pipe'],
+          });
+          
+          // Look for peer dependency warnings
+          const peerWarnings = (result.match(/WARN.*peer/gi) || []).length;
+          const missingPeers = (result.match(/missing peer/gi) || []).length;
+          
+          const metadata = { peerWarnings, missingPeers };
+          
+          if (missingPeers > 0) {
+            return {
+              severity: SEVERITY.WARNING,
+              message: `${missingPeers} missing peer dependencies`,
+              metadata,
+              fixes: [{
+                type: FIX_TYPE.COMMAND,
+                description: 'Install peer dependencies',
+                command: 'npm install --legacy-peer-deps',
+                autoFixable: false,
+              }],
+            };
+          }
+          
+          return {
+            severity: SEVERITY.PASS,
+            message: 'Peer dependencies satisfied',
+            metadata,
+          };
+        } catch {
+          return {
+            severity: SEVERITY.INFO,
+            message: 'Could not check peer dependencies',
+          };
+        }
+      },
+    },
+    {
+      id: `${MODULE_ID}.duplicate`,
+      name: 'Duplicate Packages',
+      category: CATEGORY.DEPENDENCIES,
+      parallel: true,
+      check: async () => {
+        try {
+          const result = execSync('npm dedupe --dry-run 2>&1 || true', {
+            cwd: projectPath,
+            encoding: 'utf8',
+            timeout: 30000,
+            stdio: ['pipe', 'pipe', 'pipe'],
+          });
+          
+          const wouldDedupe = result.includes('removed') || result.includes('dedupe');
+          
+          if (wouldDedupe) {
+            return {
+              severity: SEVERITY.INFO,
+              message: 'Deduplication possible',
+              fixes: [{
+                type: FIX_TYPE.COMMAND,
+                description: 'Deduplicate packages',
+                command: 'npm dedupe',
+                autoFixable: true,
+              }],
+            };
+          }
+          
+          return {
+            severity: SEVERITY.PASS,
+            message: 'No duplicates found',
+          };
+        } catch {
+          return {
+            severity: SEVERITY.INFO,
+            message: 'Could not check for duplicates',
+          };
+        }
+      },
+    },
+    {
+      id: `${MODULE_ID}.engines`,
+      name: 'Engine Requirements',
+      category: CATEGORY.DEPENDENCIES,
+      parallel: true,
+      check: async () => {
+        const pkgPath = path.join(projectPath, 'package.json');
+        
+        try {
+          const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+          
+          if (!pkg.engines) {
+            return {
+              severity: SEVERITY.INFO,
+              message: 'No engine requirements specified',
+              fixes: [{
+                type: FIX_TYPE.MANUAL,
+                description: 'Add "engines" field to package.json to enforce Node version',
+                autoFixable: false,
+              }],
+            };
+          }
+          
+          const nodeReq = pkg.engines.node;
+          const npmReq = pkg.engines.npm;
+          
+          const metadata = { nodeReq, npmReq };
+          
+          // Basic semver check against current version
+          if (nodeReq) {
+            const currentMajor = parseInt(process.version.slice(1).split('.')[0]);
+            const minMatch = nodeReq.match(/>=?\s*(\d+)/);
+            const minRequired = minMatch ? parseInt(minMatch[1]) : 0;
+            
+            if (currentMajor < minRequired) {
+              return {
+                severity: SEVERITY.ERROR,
+                message: `Node ${process.version} does not satisfy "${nodeReq}"`,
+                metadata,
+                fixes: [{
+                  type: FIX_TYPE.COMMAND,
+                  description: `Upgrade to Node ${minRequired}+`,
+                  command: `nvm install ${minRequired}`,
+                  autoFixable: false,
+                }],
+              };
+            }
+          }
+          
+          return {
+            severity: SEVERITY.PASS,
+            message: nodeReq ? `node: ${nodeReq}` : 'Specified',
+            metadata,
+          };
+        } catch {
+          return {
+            severity: SEVERITY.INFO,
+            message: 'Could not check engine requirements',
+          };
+        }
+      },
+    },
+  ];
+}
+
+module.exports = { MODULE_ID, createDiagnostics };