@vibe-forge/workspace-assets 3.2.1 → 3.2.2-alpha.1

package/__tests__/adapter-asset-plan.spec.ts

@@ -280,64 +280,6 @@ describe('buildAdapterAssetPlan', () => {
     ]))
   })
 
-  it('keeps explicit skills CLI dependencies ahead of preselected home-bridged skills in overlays', async () => {
-    const workspace = await createWorkspace()
-    const realHome = process.env.__VF_PROJECT_REAL_HOME__
-    const tempInstallDir = join(workspace, '.tmp-install-skills-cli-foo')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'foo')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: foo\ndescription: Registry foo\n---\nUse the registry definition.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValue({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'foo',
-        name: 'foo',
-        sourcePath: installedSkillDir
-      }
-    })
-
-    await writeDocument(
-      join(realHome!, '.agents/skills/foo/SKILL.md'),
-      '---\ndescription: Home foo\n---\nUse the home definition.\n'
-    )
-    await writeDocument(
-      join(workspace, '.ai/skills/app-builder/SKILL.md'),
-      [
-        '---',
-        'name: app-builder',
-        'description: Build apps',
-        'dependencies:',
-        '  - anthropics/skills@foo',
-        '---',
-        'Build the app.'
-      ].join('\n')
-    )
-
-    const bundle = await resolveWorkspaceAssetBundle({
-      cwd: workspace,
-      configs: [undefined, undefined],
-      useDefaultVibeForgeMcpServer: false
-    })
-    const plan = await buildAdapterAssetPlan({
-      adapter: 'opencode',
-      bundle,
-      options: {
-        skills: {
-          include: ['foo', 'app-builder']
-        }
-      }
-    })
-
-    const fooOverlays = plan.overlays.filter(entry => entry.kind === 'skill' && entry.targetPath === 'skills/foo')
-    expect(fooOverlays).toHaveLength(1)
-    expect(fooOverlays[0]?.sourcePath).toContain(
-      '/.ai/caches/skill-dependencies/skills-cli/skills/latest/default/anthropics/skills/latest/foo'
-    )
-    expect(fooOverlays[0]?.sourcePath).not.toBe(join(realHome!, '.agents/skills/foo'))
-  })
-
   it('prunes excluded skill dependency subtrees from selected native overlays', async () => {
     const workspace = await createWorkspace()
 

package/__tests__/bundle.spec.ts

@@ -2,7 +2,6 @@
 import { join } from 'node:path'
 import process from 'node:process'
 
-import { readFile } from 'node:fs/promises'
 import { afterEach, describe, expect, it, vi } from 'vitest'
 
 const skillsCliMocks = vi.hoisted(() => ({
@@ -27,6 +26,7 @@ import { createWorkspace, installPluginPackage, writeDocument } from './test-hel
 
 afterEach(() => {
   vi.clearAllMocks()
+  vi.restoreAllMocks()
   vi.unstubAllGlobals()
 })
 
@@ -291,7 +291,7 @@ describe('resolveWorkspaceAssetBundle', () => {
 
       expect(bundle.skills).toEqual([])
       expect(warnSpy).toHaveBeenCalledWith(
-        expect.stringContaining('Ignoring invalid skills.homeBridge root "./team-skills"')
+        expect.stringContaining('Ignoring invalid skillsMeta.homeBridge root "./team-skills"')
       )
     } finally {
       warnSpy.mockRestore()
@@ -386,95 +386,9 @@ describe('resolveWorkspaceAssetBundle', () => {
     }))
   })
 
-  it('installs selected missing skill dependencies from the skills CLI cache', async () => {
+  it('does not install configured project skills during bundle resolution and warns when requested', async () => {
     const workspace = await createWorkspace()
-    const realHome = process.env.__VF_PROJECT_REAL_HOME__
-    const tempInstallDir = join(workspace, '.tmp-install-skills-cli')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'frontend-design')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: frontend-design\ndescription: UI design guidance\n---\nUse strong visual hierarchy.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValue({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'frontend-design',
-        name: 'frontend-design',
-        sourcePath: installedSkillDir
-      }
-    })
-
-    await writeDocument(
-      join(realHome!, '.agents/skills/frontend-design/SKILL.md'),
-      '---\ndescription: home frontend design\n---\nUse the home definition.'
-    )
-    await writeDocument(
-      join(workspace, '.ai/skills/app-builder/SKILL.md'),
-      [
-        '---',
-        'name: app-builder',
-        'description: Build apps',
-        'dependencies:',
-        '  - anthropics/skills@frontend-design',
-        '---',
-        'Build the app.'
-      ].join('\n')
-    )
-
-    const bundle = await resolveWorkspaceAssetBundle({
-      cwd: workspace,
-      configs: [undefined, undefined],
-      useDefaultVibeForgeMcpServer: false
-    })
-
-    expect(bundle.skills.map(asset => asset.name).sort()).toEqual(['app-builder', 'frontend-design'])
-    expect(bundle.skills.find(asset => asset.name === 'frontend-design')).toEqual(expect.objectContaining({
-      resolvedBy: 'home-bridge',
-      sourcePath: join(realHome!, '.agents/skills/frontend-design/SKILL.md')
-    }))
-
-    await buildAdapterAssetPlan({
-      adapter: 'opencode',
-      bundle,
-      options: {
-        skills: {
-          include: ['app-builder']
-        }
-      }
-    })
-
-    const dependency = bundle.skills.find(asset => asset.name === 'frontend-design')
-    expect(bundle.skills.map(asset => asset.name).sort()).toEqual(['app-builder', 'frontend-design'])
-    expect(dependency?.sourcePath).toContain(
-      '/.ai/caches/skill-dependencies/skills-cli/skills/latest/default/anthropics/skills/latest/frontend-design/'
-    )
-    expect(bundle.skills.find(asset => (
-      asset.name === 'frontend-design' && asset.resolvedBy === 'home-bridge'
-    ))).toBeUndefined()
-    expect(skillsCliMocks.findSkillsCli).not.toHaveBeenCalled()
-    expect(skillsCliMocks.installSkillsCliSkillToTemp).toHaveBeenCalledWith({
-      config: undefined,
-      skill: 'frontend-design',
-      source: 'anthropics/skills'
-    })
-  })
-
-  it('installs configured project skills before bundle resolution and rewrites renamed skill names', async () => {
-    const workspace = await createWorkspace()
-    const tempInstallDir = join(workspace, '.tmp-configured-install')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'design-review')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: design-review\ndescription: Review design work\n---\nReview the UI implementation.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValue({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'design-review',
-        name: 'design-review',
-        sourcePath: installedSkillDir
-      }
-    })
+    const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined)
 
     const bundle = await resolveWorkspaceAssetBundle({
       cwd: workspace,
@@ -487,22 +401,16 @@ describe('resolveWorkspaceAssetBundle', () => {
           }
         ]
       }, undefined],
-      syncConfiguredSkills: true,
+      warnMissingConfiguredSkills: true,
       useDefaultVibeForgeMcpServer: false
     })
 
-    expect(bundle.skills.map(asset => asset.name)).toContain('internal-review')
-    expect(skillsCliMocks.installSkillsCliSkillToTemp).toHaveBeenCalledWith({
-      config: undefined,
-      skill: 'design-review',
-      source: 'example-source/default/public'
-    })
-    await expect(readFile(join(workspace, '.ai/skills/internal-review/SKILL.md'), 'utf8')).resolves.toContain(
-      'name: internal-review'
-    )
+    expect(bundle.skills.map(asset => asset.name)).not.toContain('internal-review')
+    expect(skillsCliMocks.installSkillsCliSkillToTemp).not.toHaveBeenCalled()
+    expect(warn).toHaveBeenCalledWith(expect.stringContaining('Declared skills are not installed: internal-review'))
   })
 
-  it('skips configured skill reinstalls unless updateConfiguredSkills is enabled', async () => {
+  it('loads installed configured skills without attempting runtime updates', async () => {
     const workspace = await createWorkspace()
     await writeDocument(
       join(workspace, '.ai/skills/internal-review/SKILL.md'),
@@ -520,213 +428,12 @@ describe('resolveWorkspaceAssetBundle', () => {
           }
         ]
       }, undefined],
-      syncConfiguredSkills: true,
+      warnMissingConfiguredSkills: true,
       useDefaultVibeForgeMcpServer: false
     })
 
     expect(skippedBundle.skills.map(asset => asset.name)).toContain('internal-review')
     expect(skillsCliMocks.installSkillsCliSkillToTemp).not.toHaveBeenCalled()
-
-    const tempInstallDir = join(workspace, '.tmp-configured-update')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'design-review')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: design-review\ndescription: Updated skill\n---\nUpdated content.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValueOnce({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'design-review',
-        name: 'design-review',
-        sourcePath: installedSkillDir
-      }
-    })
-
-    await resolveWorkspaceAssetBundle({
-      cwd: workspace,
-      configs: [{
-        skills: [
-          {
-            name: 'design-review',
-            source: 'example-source/default/public',
-            rename: 'internal-review'
-          }
-        ]
-      }, undefined],
-      syncConfiguredSkills: true,
-      updateConfiguredSkills: true,
-      useDefaultVibeForgeMcpServer: false
-    })
-
-    expect(skillsCliMocks.installSkillsCliSkillToTemp).toHaveBeenCalledTimes(1)
-    await expect(readFile(join(workspace, '.ai/skills/internal-review/SKILL.md'), 'utf8')).resolves.toContain(
-      'Updated content.'
-    )
-  })
-
-  it('installs skill dependencies into the primary workspace shared cache', async () => {
-    const primary = await createWorkspace()
-    const worktree = await createWorkspace()
-    const previousPrimaryWorkspace = process.env.__VF_PROJECT_PRIMARY_WORKSPACE_FOLDER__
-    const tempInstallDir = join(worktree, '.tmp-install-skills-cli')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'frontend-design')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: frontend-design\ndescription: UI design guidance\n---\nUse primary cache.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValue({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'frontend-design',
-        name: 'frontend-design',
-        sourcePath: installedSkillDir
-      }
-    })
-
-    try {
-      process.env.__VF_PROJECT_PRIMARY_WORKSPACE_FOLDER__ = primary
-      await writeDocument(
-        join(worktree, '.ai/skills/app-builder/SKILL.md'),
-        [
-          '---',
-          'name: app-builder',
-          'description: Build apps',
-          'dependencies:',
-          '  - anthropics/skills@frontend-design',
-          '---',
-          'Build the app.'
-        ].join('\n')
-      )
-
-      const bundle = await resolveWorkspaceAssetBundle({
-        cwd: worktree,
-        configs: [undefined, undefined],
-        useDefaultVibeForgeMcpServer: false
-      })
-
-      await buildAdapterAssetPlan({
-        adapter: 'opencode',
-        bundle,
-        options: {
-          skills: {
-            include: ['app-builder']
-          }
-        }
-      })
-
-      const dependency = bundle.skills.find(asset => asset.name === 'frontend-design')
-      expect(dependency?.sourcePath).toContain(join(
-        primary,
-        '.ai/caches/skill-dependencies/skills-cli/skills/latest/default/anthropics/skills/latest/frontend-design/'
-      ))
-      expect(dependency?.sourcePath).not.toContain(join(worktree, '.ai/caches'))
-    } finally {
-      if (previousPrimaryWorkspace == null) {
-        delete process.env.__VF_PROJECT_PRIMARY_WORKSPACE_FOLDER__
-      } else {
-        process.env.__VF_PROJECT_PRIMARY_WORKSPACE_FOLDER__ = previousPrimaryWorkspace
-      }
-    }
-  })
-
-  it('reuses complete skill dependency caches without deleting or downloading them again', async () => {
-    const workspace = await createWorkspace()
-
-    const cachedSkillPath = join(
-      workspace,
-      '.ai/caches/skill-dependencies/skills-cli/skills/latest/default/anthropics/skills/latest/frontend-design/SKILL.md'
-    )
-    await writeDocument(
-      cachedSkillPath,
-      '---\nname: frontend-design\ndescription: Cached UI guidance\n---\nUse the cached copy.\n'
-    )
-    await writeDocument(
-      join(workspace, '.ai/skills/app-builder/SKILL.md'),
-      [
-        '---',
-        'name: app-builder',
-        'description: Build apps',
-        'dependencies:',
-        '  - anthropics/skills@frontend-design',
-        '---',
-        'Build the app.'
-      ].join('\n')
-    )
-
-    const bundle = await resolveWorkspaceAssetBundle({
-      cwd: workspace,
-      configs: [undefined, undefined],
-      useDefaultVibeForgeMcpServer: false
-    })
-
-    await buildAdapterAssetPlan({
-      adapter: 'opencode',
-      bundle,
-      options: {
-        skills: {
-          include: ['app-builder']
-        }
-      }
-    })
-
-    expect(skillsCliMocks.findSkillsCli).not.toHaveBeenCalled()
-    expect(skillsCliMocks.installSkillsCliSkillToTemp).not.toHaveBeenCalled()
-    expect(await readFile(cachedSkillPath, 'utf8')).toContain('Use the cached copy.')
-    expect(bundle.skills.map(asset => asset.name).sort()).toEqual(['app-builder', 'frontend-design'])
-  })
-
-  it('parses registry/source/version dependency specs and forwards them to the skills CLI installer', async () => {
-    const workspace = await createWorkspace()
-    const tempInstallDir = join(workspace, '.tmp-install-skills-cli')
-    const installedSkillDir = join(tempInstallDir, '.agents', 'skills', 'frontend-design')
-    await writeDocument(
-      join(installedSkillDir, 'SKILL.md'),
-      '---\nname: frontend-design\ndescription: UI design guidance\n---\nUse internal design tokens.\n'
-    )
-    skillsCliMocks.installSkillsCliSkillToTemp.mockResolvedValue({
-      tempDir: tempInstallDir,
-      installedSkill: {
-        dirName: 'frontend-design',
-        name: 'frontend-design',
-        sourcePath: installedSkillDir
-      }
-    })
-
-    await writeDocument(
-      join(workspace, '.ai/skills/app-builder/SKILL.md'),
-      [
-        '---',
-        'name: app-builder',
-        'description: Build apps',
-        'dependencies:',
-        '  - https://registry.example.com@example-source/default/public@frontend-design@1.0.3',
-        '---',
-        'Build the app.'
-      ].join('\n')
-    )
-
-    const bundle = await resolveWorkspaceAssetBundle({
-      cwd: workspace,
-      configs: [undefined, undefined],
-      useDefaultVibeForgeMcpServer: false
-    })
-
-    await buildAdapterAssetPlan({
-      adapter: 'opencode',
-      bundle,
-      options: {
-        skills: {
-          include: ['app-builder']
-        }
-      }
-    })
-
-    expect(skillsCliMocks.installSkillsCliSkillToTemp).toHaveBeenCalledWith({
-      registry: 'https://registry.example.com',
-      skill: 'frontend-design',
-      source: 'example-source/default/public',
-      version: '1.0.3'
-    })
   })
 
   it('loads workspace entities from the env-configured entities dir', async () => {