@vibe-agent-toolkit/cli 0.1.42 → 0.2.0-rc.10

package/dist/commands/skill/review.d.ts

@@ -9,11 +9,245 @@
  * This is a thin presentation layer. No new validation logic lives here —
  * the automated portion is the same code path used by `vat skills validate`.
  */
+import { type PackagingValidationResult } from '@vibe-agent-toolkit/agent-skills';
+import { type Report, type ValidationIssue } from '@vibe-agent-toolkit/schema';
 import { Command } from 'commander';
+import { z } from 'zod';
+import { type ChecklistSection } from './review-checklist.js';
 export interface SkillReviewCommandOptions {
     yaml?: boolean;
+    /** Treat warnings as failing: end on `FINDINGS` when any warning is present. */
+    strict?: boolean;
     debug?: boolean;
 }
+/** What the review reports beyond its findings. */
+export declare const SkillReviewDataSchema: z.ZodObject<{
+    skill: z.ZodString;
+    /** The path the caller named. */
+    source: z.ZodString;
+    metadata: z.ZodObject<{
+        skillLines: z.ZodNumber;
+        totalLines: z.ZodNumber;
+        fileCount: z.ZodNumber;
+        directFileCount: z.ZodNumber;
+        maxLinkDepth: z.ZodNumber;
+        excludedReferenceCount: z.ZodNumber;
+        excludedReferences: z.ZodArray<z.ZodObject<{
+            path: z.ZodString;
+            reason: z.ZodString;
+            matchedPattern: z.ZodOptional<z.ZodString>;
+        }, "strict", z.ZodTypeAny, {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }, {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }>, "many">;
+    }, "strict", z.ZodTypeAny, {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    }, {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    }>;
+    /**
+     * Every checklist section, in rubric order — including the ones no finding
+     * landed in, because the manual items are the point of a review and a
+     * section with nothing automated still has to be walked through.
+     */
+    sections: z.ZodArray<z.ZodObject<{
+        section: z.ZodString;
+        /** Codes of the envelope's findings that belong to this section, in finding order. */
+        codes: z.ZodArray<z.ZodString, "many">;
+        /** The judgment-call items a reviewer completes for this section. */
+        manual: z.ZodArray<z.ZodString, "many">;
+    }, "strict", z.ZodTypeAny, {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }, {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }>, "many">;
+}, "strict", z.ZodTypeAny, {
+    skill: string;
+    source: string;
+    metadata: {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    };
+    sections: {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }[];
+}, {
+    skill: string;
+    source: string;
+    metadata: {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    };
+    sections: {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }[];
+}>;
+export type SkillReviewData = z.infer<typeof SkillReviewDataSchema>;
+/** The document `--yaml` publishes. */
+export declare const SKILL_REVIEW_REPORT_SCHEMA: import("@vibe-agent-toolkit/schema").ReportZodSchema<z.ZodObject<{
+    skill: z.ZodString;
+    /** The path the caller named. */
+    source: z.ZodString;
+    metadata: z.ZodObject<{
+        skillLines: z.ZodNumber;
+        totalLines: z.ZodNumber;
+        fileCount: z.ZodNumber;
+        directFileCount: z.ZodNumber;
+        maxLinkDepth: z.ZodNumber;
+        excludedReferenceCount: z.ZodNumber;
+        excludedReferences: z.ZodArray<z.ZodObject<{
+            path: z.ZodString;
+            reason: z.ZodString;
+            matchedPattern: z.ZodOptional<z.ZodString>;
+        }, "strict", z.ZodTypeAny, {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }, {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }>, "many">;
+    }, "strict", z.ZodTypeAny, {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    }, {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    }>;
+    /**
+     * Every checklist section, in rubric order — including the ones no finding
+     * landed in, because the manual items are the point of a review and a
+     * section with nothing automated still has to be walked through.
+     */
+    sections: z.ZodArray<z.ZodObject<{
+        section: z.ZodString;
+        /** Codes of the envelope's findings that belong to this section, in finding order. */
+        codes: z.ZodArray<z.ZodString, "many">;
+        /** The judgment-call items a reviewer completes for this section. */
+        manual: z.ZodArray<z.ZodString, "many">;
+    }, "strict", z.ZodTypeAny, {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }, {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }>, "many">;
+}, "strict", z.ZodTypeAny, {
+    skill: string;
+    source: string;
+    metadata: {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    };
+    sections: {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }[];
+}, {
+    skill: string;
+    source: string;
+    metadata: {
+        skillLines: number;
+        totalLines: number;
+        fileCount: number;
+        directFileCount: number;
+        maxLinkDepth: number;
+        excludedReferenceCount: number;
+        excludedReferences: {
+            path: string;
+            reason: string;
+            matchedPattern?: string | undefined;
+        }[];
+    };
+    sections: {
+        codes: string[];
+        section: string;
+        manual: string[];
+    }[];
+}>>;
+export type SkillReviewReport = Report<SkillReviewData>;
 /**
  * Resolve the caller's argument to the absolute path of a skill markdown file.
  *
@@ -27,6 +261,19 @@ export interface SkillReviewCommandOptions {
  * the downstream packaging validator handles that.
  */
 export declare function resolveSkillPath(pathArg: string): string;
+/**
+ * The machine-readable review, for `--yaml` (e.g. CI consumption).
+ *
+ * `examined` is 1: a review looks at ONE skill, and the denominator says so
+ * rather than leaving a reader to infer it from `skill`. Pure, so the shape is
+ * unit-testable without a validator run.
+ *
+ * @param result - The validator's result
+ * @param skillPath - The path the caller named
+ * @param grouped - The findings by checklist section
+ * @returns The report
+ */
+export declare function buildReviewReport(result: PackagingValidationResult, skillPath: string, grouped: ReadonlyMap<ChecklistSection, readonly ValidationIssue[]>): SkillReviewReport;
 export declare function reviewCommand(pathArg: string | undefined, options: SkillReviewCommandOptions): Promise<void>;
 export declare function createSkillReviewCommand(): Command;
 //# sourceMappingURL=review.d.ts.map

package/dist/commands/skill/review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../../src/commands/skill/review.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAiBH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAkBpC,MAAM,WAAW,yBAAyB;IACxC,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,gBAAgB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAgCxD;AAyJD,wBAAsB,aAAa,CACjC,OAAO,EAAE,MAAM,GAAG,SAAS,EAC3B,OAAO,EAAE,yBAAyB,GACjC,OAAO,CAAC,IAAI,CAAC,CAmDf;AAED,wBAAgB,wBAAwB,IAAI,OAAO,CA+ClD"}
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../../src/commands/skill/review.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAKH,OAAO,EAGL,KAAK,yBAAyB,EAC/B,MAAM,kCAAkC,CAAC;AAE1C,OAAO,EAOL,KAAK,MAAM,EACX,KAAK,eAAe,EACrB,MAAM,4BAA4B,CAAC;AAEpC,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpC,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAWxB,OAAO,EAIL,KAAK,gBAAgB,EACtB,MAAM,uBAAuB,CAAC;AAE/B,MAAM,WAAW,yBAAyB;IACxC,IAAI,CAAC,EAAE,OAAO,CAAC;IACf,gFAAgF;IAChF,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAWD,mDAAmD;AACnD,eAAO,MAAM,qBAAqB;;IAEhC,iCAAiC;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;IAejC;;;;OAIG;;;QA5BH,sFAAsF;;QAEtF,qEAAqE;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EA4B5D,CAAC;AAEZ,MAAM,MAAM,eAAe,GAAG,CAAC,CAAC,KAAK,CAAC,OAAO,qBAAqB,CAAC,CAAC;AAEpE,uCAAuC;AACvC,eAAO,MAAM,0BAA0B;;IA1BrC,iCAAiC;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;IAejC;;;;OAIG;;;QA5BH,sFAAsF;;QAEtF,qEAAqE;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAiCM,CAAC;AAE9E,MAAM,MAAM,iBAAiB,GAAG,MAAM,CAAC,eAAe,CAAC,CAAC;AAExD;;;;;;;;;;;GAWG;AACH,wBAAgB,gBAAgB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CA6BxD;AA4FD;;;;;;;;;;;GAWG;AACH,wBAAgB,iBAAiB,CAC/B,MAAM,EAAE,yBAAyB,EACjC,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,WAAW,CAAC,gBAAgB,EAAE,SAAS,eAAe,EAAE,CAAC,GACjE,iBAAiB,CAwBnB;AAYD,wBAAsB,aAAa,CACjC,OAAO,EAAE,MAAM,GAAG,SAAS,EAC3B,OAAO,EAAE,yBAAyB,GACjC,OAAO,CAAC,IAAI,CAAC,CA2Df;AAED,wBAAgB,wBAAwB,IAAI,OAAO,CAkDlD"}

package/dist/commands/skill/review.js

@@ -11,19 +11,55 @@
  */
 import { existsSync, statSync } from 'node:fs';
 import { dirname } from 'node:path';
-import { calculateValidationStatus, countBySeverity, } from '@vibe-agent-toolkit/agent-schema';
 import { resolveAnchorRoot, validateSkillForPackaging, } from '@vibe-agent-toolkit/agent-skills';
+import { buildReport, calculateValidationStatus, countBySeverity, exitCodeForSeverityCounts, reportSchema, toFindings, } from '@vibe-agent-toolkit/schema';
 import { safePath } from '@vibe-agent-toolkit/utils';
 import { Command } from 'commander';
-import * as yaml from 'yaml';
+import { z } from 'zod';
 import { resolveProjectDeclaredEvalSuites, resolveSkillPackagingConfig } from '../../skill-resolution/packaging-config.js';
-import { handleCommandError } from '../../utils/command-error.js';
+import { handleReportCommandError } from '../../utils/command-error.js';
 import { formatIssueAnchor } from '../../utils/issue-anchor.js';
 import { createLogger } from '../../utils/logger.js';
+import { writeYamlOutput } from '../../utils/output.js';
 import { projectRootOrNull } from '../../utils/project-root-policy.js';
 import { renderSkillQualityFooter } from '../../utils/skill-quality-footer.js';
 import { applyConfigVerdicts } from '../../utils/verdict-helpers.js';
 import { CHECKLIST_SECTIONS, MANUAL_CHECKLIST_ITEMS, sectionForCode, } from './review-checklist.js';
+/** One checklist section: which automated findings landed in it, and what a reviewer walks through by hand. */
+const ReviewSectionSchema = z.object({
+    section: z.string(),
+    /** Codes of the envelope's findings that belong to this section, in finding order. */
+    codes: z.array(z.string()),
+    /** The judgment-call items a reviewer completes for this section. */
+    manual: z.array(z.string()),
+}).strict();
+/** What the review reports beyond its findings. */
+export const SkillReviewDataSchema = z.object({
+    skill: z.string(),
+    /** The path the caller named. */
+    source: z.string(),
+    metadata: z.object({
+        skillLines: z.number().int().nonnegative(),
+        totalLines: z.number().int().nonnegative(),
+        fileCount: z.number().int().nonnegative(),
+        directFileCount: z.number().int().nonnegative(),
+        maxLinkDepth: z.number().int().nonnegative(),
+        excludedReferenceCount: z.number().int().nonnegative(),
+        excludedReferences: z.array(z.object({
+            path: z.string(),
+            reason: z.string(),
+            matchedPattern: z.string().optional(),
+        }).strict()),
+    }).strict(),
+    /**
+     * Every checklist section, in rubric order — including the ones no finding
+     * landed in, because the manual items are the point of a review and a
+     * section with nothing automated still has to be walked through.
+     */
+    sections: z.array(ReviewSectionSchema),
+}).strict();
+/** The document `--yaml` publishes. */
+export const SKILL_REVIEW_REPORT_SCHEMA = reportSchema(SkillReviewDataSchema);
 /**
  * Resolve the caller's argument to the absolute path of a skill markdown file.
  *
@@ -38,11 +74,9 @@ import { CHECKLIST_SECTIONS, MANUAL_CHECKLIST_ITEMS, sectionForCode, } from './r
  */
 export function resolveSkillPath(pathArg) {
     const absolute = safePath.resolve(pathArg);
-    // eslint-disable-next-line security/detect-non-literal-fs-filename -- user-supplied path
     if (!existsSync(absolute)) {
         throw new Error(`Path does not exist: ${pathArg}`);
     }
-    // eslint-disable-next-line security/detect-non-literal-fs-filename -- user-supplied path
     const stat = statSync(absolute);
     if (stat.isFile()) {
         if (!absolute.endsWith('.md')) {
@@ -52,7 +86,6 @@ export function resolveSkillPath(pathArg) {
     }
     if (stat.isDirectory()) {
         const candidate = safePath.join(absolute, 'SKILL.md');
-        // eslint-disable-next-line security/detect-non-literal-fs-filename -- candidate constructed from validated dir
         if (!existsSync(candidate)) {
             throw new Error(`No SKILL.md found in directory: ${pathArg}. Point at the skill directory (containing SKILL.md) or the SKILL.md file directly.`);
         }
@@ -82,10 +115,10 @@ function groupIssuesBySection(issues) {
 }
 /**
  * Render the human-readable review report to stderr (logger). Structured
- * output goes to stdout via {@link outputYaml}.
+ * output goes to stdout via {@link buildReviewReport}.
  */
 function renderHumanReport(result, skillPath, grouped, logger) {
-    // One collapse, from agent-schema: `allErrors` carries info issues despite the
+    // One collapse, from schema: `allErrors` carries info issues despite the
     // name, and there is no `activeInfo` bucket to read them from.
     const counts = countBySeverity(result.allErrors);
     logger.info('');
@@ -134,48 +167,41 @@ function renderIssue(issue, logger) {
     }
 }
 /**
- * Emit a machine-readable review payload to stdout as YAML. Used by --yaml
- * (e.g. CI consumption).
+ * The machine-readable review, for `--yaml` (e.g. CI consumption).
+ *
+ * `examined` is 1: a review looks at ONE skill, and the denominator says so
+ * rather than leaving a reader to infer it from `skill`. Pure, so the shape is
+ * unit-testable without a validator run.
+ *
+ * @param result - The validator's result
+ * @param skillPath - The path the caller named
+ * @param grouped - The findings by checklist section
+ * @returns The report
  */
-function outputYaml(result, skillPath, grouped) {
-    const automated = {};
-    for (const section of CHECKLIST_SECTIONS) {
-        const issues = grouped.get(section) ?? [];
-        if (issues.length === 0)
-            continue;
-        automated[section] = issues.map(i => ({
-            code: i.code,
-            severity: i.severity,
-            message: i.message,
-            ...(i.location === undefined ? {} : { location: i.location }),
-            ...(i.line === undefined ? {} : { line: i.line }),
-            ...(i.field === undefined ? {} : { field: i.field }),
-            ...(i.fix === undefined ? {} : { fix: i.fix }),
-        }));
-    }
-    const manual = {};
-    for (const section of CHECKLIST_SECTIONS) {
-        const items = MANUAL_CHECKLIST_ITEMS[section];
-        if (items.length > 0) {
-            manual[section] = items;
-        }
-    }
-    const payload = {
-        skill: result.skillName,
-        source: skillPath,
-        // NOT `result.status`: that is the packaging GATE verdict, two-valued by
-        // design, so a review holding only warnings published `status: success`
-        // while the very same run exited 1. Review treats a warning as a finding
-        // you must look at (that is its documented exit-code contract), so the
-        // status channel has to be able to say so.
-        status: calculateValidationStatus(result.allErrors),
-        issueCounts: countBySeverity(result.allErrors),
-        metadata: result.metadata,
-        automated,
-        manual,
-    };
-    process.stdout.write('---\n');
-    process.stdout.write(yaml.stringify(payload, { indent: 2, lineWidth: 120, aliasDuplicateObjects: false }));
+export function buildReviewReport(result, skillPath, grouped) {
+    const findings = CHECKLIST_SECTIONS.flatMap((section) => toFindings(grouped.get(section) ?? []));
+    const sections = CHECKLIST_SECTIONS.map((section) => ({
+        section,
+        codes: toFindings(grouped.get(section) ?? []).map((issue) => issue.code),
+        manual: [...MANUAL_CHECKLIST_ITEMS[section]],
+    }));
+    return buildReport({
+        examined: 1,
+        findings,
+        data: {
+            skill: result.skillName,
+            source: skillPath,
+            metadata: {
+                ...result.metadata,
+                excludedReferences: result.metadata.excludedReferences.map((detail) => ({
+                    path: detail.path,
+                    reason: detail.reason,
+                    ...(detail.matchedPattern === undefined ? {} : { matchedPattern: detail.matchedPattern }),
+                })),
+            },
+            sections,
+        },
+    });
 }
 /** Footer: share the checklist link when any skill-level finding fires. */
 function renderFooter(result, logger) {
@@ -200,11 +226,18 @@ export async function reviewCommand(pathArg, options) {
         projectRootOrNull(process.cwd());
         const skillPath = resolveSkillPath(pathArg);
         logger.debug(`Reviewing SKILL.md at: ${skillPath}`);
-        const packagingConfig = (await resolveSkillPackagingConfig(skillPath)) ?? undefined;
+        // `'refuse'` on both: a review that cannot tell whether this skill is
+        // declared, or which suites are the project's, would report against the
+        // wrong rules at exit 0. The throw lands in the catch below →
+        // `handleReportCommandError`, exit 2.
+        const packagingConfig = (await resolveSkillPackagingConfig(skillPath, 'refuse')) ?? undefined;
         // Project-wide test input: a review of skill A must not count skill B's eval
         // suite as content A ships. Memoized per config root; `[]` in wild mode.
         const result = await validateSkillForPackaging(skillPath, packagingConfig, 'source', {
-            projectSkills: await resolveProjectDeclaredEvalSuites(skillPath),
+            projectSkills: await resolveProjectDeclaredEvalSuites(skillPath, 'refuse'),
+            // Same ruling as the discovery above: a review is acted on whole, so a
+            // directory the registry crawl cannot list refuses it by name.
+            unreadable: 'refuse',
         });
         // The anchor root for a single-skill review is the skill's own project
         // boundary — the same base the packaging validator anchored its issues
@@ -212,19 +245,20 @@ export async function reviewCommand(pathArg, options) {
         applyConfigVerdicts(result, packagingConfig?.targets, skillPath, resolveAnchorRoot(undefined, dirname(skillPath)));
         const grouped = groupIssuesBySection(result.allErrors);
         if (options.yaml) {
-            outputYaml(result, skillPath, grouped);
+            writeYamlOutput({ ...buildReviewReport(result, skillPath, grouped), durationMs: Date.now() - startTime });
         }
         else {
             renderHumanReport(result, skillPath, grouped, logger);
         }
         renderFooter(result, logger);
         // Same counts the status channel is derived from, so the two agree by
-        // construction: exit 1 ⟺ status is `warning` or `error`.
-        const counts = countBySeverity(result.allErrors);
-        process.exit(counts.errors > 0 || counts.warnings > 0 ? 1 : 0);
+        // construction. Errors fail; warnings fail only under `--strict` — this
+        // used to exit 1 on a warning while every sibling exited 1 on errors only,
+        // so the one verb meant for a human's review was the strictest gate.
+        process.exit(exitCodeForSeverityCounts(countBySeverity(result.allErrors), { strict: options.strict === true }));
     }
     catch (error) {
-        handleCommandError(error, logger, startTime, 'SkillReview');
+        handleReportCommandError(error, logger, startTime, 'SkillReview');
     }
 }
 export function createSkillReviewCommand() {
@@ -233,6 +267,7 @@ export function createSkillReviewCommand() {
         .description('Deep-review a single skill: automated findings plus a manual rubric walkthrough')
         .argument('<path>', 'Path to a SKILL.md file, a single-file skill (.md), or a skill directory containing SKILL.md')
         .option('--yaml', 'Emit machine-readable YAML on stdout (for CI consumption)')
+        .option('--strict', 'Exit 1 on warnings as well as errors')
         .option('--debug', 'Enable debug logging')
         .action(reviewCommand)
         .addHelpText('after', `
@@ -249,14 +284,16 @@ Description:
   Output:
     Default: human-readable report to stderr (automated findings grouped by
              checklist section, then the manual walkthrough).
-    --yaml:  structured YAML to stdout with automated + manual sections, plus
-             status (success | warning | error) and issueCounts
-             {errors, warnings, info}. The status agrees with the exit code by
-             construction: exit 1 iff status is 'warning' or 'error'.
+    --yaml:  the report envelope as YAML on stdout — status (ok | findings),
+             examined (always 1), findings, summary {errors, warnings, info},
+             and data.sections: every checklist section with the codes of
+             the findings that landed in it and its manual items. The exit
+             code is derived from the same summary: exit 1 iff
+             summary.errors + summary.warnings > 0.
 
 Exit Codes:
-  0 - No errors and no warnings emitted (an info-only review is 'success')
-  1 - At least one error or warning present (errors and warnings treated equally — this is a review, not a gate)
+  0 - No error-severity finding (warnings and info are in the report; --strict promotes warnings)
+  1 - At least one error present, or any warning under --strict
   2 - System error (path missing, internal failure)
 
 Requirements:

package/dist/commands/skill/review.js.map

@@ -1 +1 @@
-{"version":3,"file":"review.js","sourceRoot":"","sources":["../../../src/commands/skill/review.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,SAAS,CAAC;AAC/C,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAEpC,OAAO,EACL,yBAAyB,EACzB,eAAe,GAEhB,MAAM,kCAAkC,CAAC;AAC1C,OAAO,EACL,iBAAiB,EACjB,yBAAyB,GAE1B,MAAM,kCAAkC,CAAC;AAE1C,OAAO,EAAE,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AACrD,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpC,OAAO,KAAK,IAAI,MAAM,MAAM,CAAC;AAE7B,OAAO,EAAE,gCAAgC,EAAE,2BAA2B,EAAE,MAAM,4CAA4C,CAAC;AAC3H,OAAO,EAAE,kBAAkB,EAAE,MAAM,8BAA8B,CAAC;AAClE,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,YAAY,EAAe,MAAM,uBAAuB,CAAC;AAClE,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAC;AACvE,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,mBAAmB,EAAE,MAAM,gCAAgC,CAAC;AAErE,OAAO,EACL,kBAAkB,EAClB,sBAAsB,EACtB,cAAc,GAEf,MAAM,uBAAuB,CAAC;AAO/B;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,gBAAgB,CAAC,OAAe;IAC9C,MAAM,QAAQ,GAAG,QAAQ,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;IAE3C,yFAAyF;IACzF,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC1B,MAAM,IAAI,KAAK,CAAC,wBAAwB,OAAO,EAAE,CAAC,CAAC;IACrD,CAAC;IAED,yFAAyF;IACzF,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAEhC,IAAI,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC;QAClB,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;YAC9B,MAAM,IAAI,KAAK,CACb,6DAA6D,OAAO,EAAE,CACvE,CAAC;QACJ,CAAC;QACD,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,IAAI,IAAI,CAAC,WAAW,EAAE,EAAE,CAAC;QACvB,MAAM,SAAS,GAAG,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;QACtD,+GAA+G;QAC/G,IAAI,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE,CAAC;YAC3B,MAAM,IAAI,KAAK,CACb,mCAAmC,OAAO,qFAAqF,CAChI,CAAC;QACJ,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,IAAI,KAAK,CAAC,2CAA2C,OAAO,EAAE,CAAC,CAAC;AACxE,CAAC;AAED;;;;GAIG;AACH,SAAS,oBAAoB,CAC3B,MAAkC;IAElC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAuC,CAAC;IAC/D,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,OAAO,CAAC,GAAG,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAC3B,CAAC;IACD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,MAAM,OAAO,GAAG,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAC3C,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;IACpC,CAAC;IAED,MAAM,YAAY,GAA2B,EAAE,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;IAC/E,KAAK,MAAM,IAAI,IAAI,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC;QACpC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACzF,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CACxB,MAAiC,EACjC,SAAiB,EACjB,OAAiD,EACjD,MAAc;IAEd,+EAA+E;IAC/E,+DAA+D;IAC/D,MAAM,MAAM,GAAG,eAAe,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;IAEjD,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,oBAAoB,MAAM,CAAC,SAAS,EAAE,CAAC,CAAC;IACpD,MAAM,CAAC,IAAI,CAAC,WAAW,SAAS,EAAE,CAAC,CAAC;IACpC,MAAM,CAAC,IAAI,CACT,YAAY,MAAM,CAAC,MAAM,cAAc,MAAM,CAAC,QAAQ,gBAAgB,MAAM,CAAC,IAAI,OAAO,CACzF,CAAC;IACF,MAAM,CAAC,IAAI,CACT,aAAa,MAAM,CAAC,QAAQ,CAAC,UAAU,oBAAoB,MAAM,CAAC,QAAQ,CAAC,UAAU,uBAAuB,MAAM,CAAC,QAAQ,CAAC,SAAS,UAAU,CAChJ,CAAC;IAEF,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,oDAAoD,CAAC,CAAC;IAElE,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAC1C,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAClC,MAAM,GAAG,IAAI,CAAC;QACd,MAAM,CAAC,IAAI,CAAC,OAAO,OAAO,KAAK,MAAM,CAAC,MAAM,IAAI,CAAC,CAAC;QAClD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC3B,WAAW,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;QAC7B,CAAC;IACH,CAAC;IACD,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,MAAM,CAAC,IAAI,CAAC,yCAAyC,CAAC,CAAC;IACzD,CAAC;IAED,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,gEAAgE,CAAC,CAAC;IAC9E,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,KAAK,GAAG,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAC9C,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QACjC,MAAM,CAAC,IAAI,CAAC,OAAO,OAAO,GAAG,CAAC,CAAC;QAC/B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,MAAM,CAAC,IAAI,CAAC,WAAW,IAAI,EAAE,CAAC,CAAC;QACjC,CAAC;IACH,CAAC;AACH,CAAC;AAED,4DAA4D;AAC5D,SAAS,WAAW,CAAC,KAAsB,EAAE,MAAc;IACzD,MAAM,WAAW,GAAG,KAAK,CAAC,QAAQ,CAAC,WAAW,EAAE,CAAC;IACjD,MAAM,CAAC,IAAI,CAAC,UAAU,WAAW,MAAM,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IACvE,MAAM,MAAM,GAAG,iBAAiB,CAAC,KAAK,CAAC,CAAC;IACxC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QACzB,MAAM,CAAC,IAAI,CAAC,qBAAqB,MAAM,EAAE,CAAC,CAAC;IAC7C,CAAC;IACD,IAAI,KAAK,CAAC,GAAG,KAAK,SAAS,IAAI,KAAK,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;QAChD,MAAM,CAAC,IAAI,CAAC,gBAAgB,KAAK,CAAC,GAAG,EAAE,CAAC,CAAC;IAC3C,CAAC;AACH,CAAC;AAED;;;GAGG;AACH,SAAS,UAAU,CACjB,MAAiC,EACjC,SAAiB,EACjB,OAAiD;IAEjD,MAAM,SAAS,GAA8B,EAAE,CAAC;IAChD,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAC1C,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAClC,SAAS,CAAC,OAAO,CAAC,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;YACpC,IAAI,EAAE,CAAC,CAAC,IAAI;YACZ,QAAQ,EAAE,CAAC,CAAC,QAAQ;YACpB,OAAO,EAAE,CAAC,CAAC,OAAO;YAClB,GAAG,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC;YAC7D,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;YACjD,GAAG,CAAC,CAAC,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,CAAC,CAAC,KAAK,EAAE,CAAC;YACpD,GAAG,CAAC,CAAC,CAAC,GAAG,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,GAAG,EAAE,CAAC,CAAC,GAAG,EAAE,CAAC;SAC/C,CAAC,CAAC,CAAC;IACN,CAAC;IAED,MAAM,MAAM,GAAsC,EAAE,CAAC;IACrD,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,KAAK,GAAG,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAC9C,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,MAAM,CAAC,OAAO,CAAC,GAAG,KAAK,CAAC;QAC1B,CAAC;IACH,CAAC;IAED,MAAM,OAAO,GAAG;QACd,KAAK,EAAE,MAAM,CAAC,SAAS;QACvB,MAAM,EAAE,SAAS;QACjB,yEAAyE;QACzE,wEAAwE;QACxE,yEAAyE;QACzE,uEAAuE;QACvE,2CAA2C;QAC3C,MAAM,EAAE,yBAAyB,CAAC,MAAM,CAAC,SAAS,CAAC;QACnD,WAAW,EAAE,eAAe,CAAC,MAAM,CAAC,SAAS,CAAC;QAC9C,QAAQ,EAAE,MAAM,CAAC,QAAQ;QACzB,SAAS;QACT,MAAM;KACP,CAAC;IAEF,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IAC9B,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,EAAE,MAAM,EAAE,CAAC,EAAE,SAAS,EAAE,GAAG,EAAE,qBAAqB,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC;AAC7G,CAAC;AAED,2EAA2E;AAC3E,SAAS,YAAY,CAAC,MAAiC,EAAE,MAAc;IACrE,MAAM,YAAY,GAAG,IAAI,GAAG,EAAU,CAAC;IACvC,KAAK,MAAM,KAAK,IAAI,MAAM,CAAC,SAAS,EAAE,CAAC;QACrC,YAAY,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC/B,CAAC;IACD,MAAM,gBAAgB,GAAG,yBAAyB,CAAC,MAAM,CAAC,SAAS,CAAC,KAAK,SAAS,CAAC;IACnF,wBAAwB,CAAC,MAAM,EAAE,gBAAgB,EAAE,YAAY,CAAC,CAAC;AACnE,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,aAAa,CACjC,OAA2B,EAC3B,OAAkC;IAElC,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IAClE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAE7B,IAAI,CAAC;QACH,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,EAAE,EAAE,CAAC;YAC5C,MAAM,IAAI,KAAK,CAAC,2EAA2E,CAAC,CAAC;QAC/F,CAAC;QAED,wEAAwE;QACxE,4EAA4E;QAC5E,6EAA6E;QAC7E,4DAA4D;QAC5D,iBAAiB,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QAEjC,MAAM,SAAS,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;QAC5C,MAAM,CAAC,KAAK,CAAC,0BAA0B,SAAS,EAAE,CAAC,CAAC;QAEpD,MAAM,eAAe,GAAG,CAAC,MAAM,2BAA2B,CAAC,SAAS,CAAC,CAAC,IAAI,SAAS,CAAC;QACpF,6EAA6E;QAC7E,yEAAyE;QACzE,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,SAAS,EAAE,eAAe,EAAE,QAAQ,EAAE;YACnF,aAAa,EAAE,MAAM,gCAAgC,CAAC,SAAS,CAAC;SACjE,CAAC,CAAC;QACH,uEAAuE;QACvE,uEAAuE;QACvE,uDAAuD;QACvD,mBAAmB,CACjB,MAAM,EACN,eAAe,EAAE,OAAwC,EACzD,SAAS,EACT,iBAAiB,CAAC,SAAS,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC,CACjD,CAAC;QAEF,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QAEvD,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;YACjB,UAAU,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QACzC,CAAC;aAAM,CAAC;YACN,iBAAiB,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;QACxD,CAAC;QAED,YAAY,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;QAE7B,sEAAsE;QACtE,yDAAyD;QACzD,MAAM,MAAM,GAAG,eAAe,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QACjD,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,CAAC,QAAQ,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IACjE,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,kBAAkB,CAAC,KAAK,EAAE,MAAM,EAAE,SAAS,EAAE,aAAa,CAAC,CAAC;IAC9D,CAAC;AACH,CAAC;AAED,MAAM,UAAU,wBAAwB;IACtC,MAAM,OAAO,GAAG,IAAI,OAAO,CAAC,QAAQ,CAAC,CAAC;IAEtC,OAAO;SACJ,WAAW,CAAC,iFAAiF,CAAC;SAC9F,QAAQ,CAAC,QAAQ,EAAE,8FAA8F,CAAC;SAClH,MAAM,CAAC,QAAQ,EAAE,2DAA2D,CAAC;SAC7E,MAAM,CAAC,SAAS,EAAE,sBAAsB,CAAC;SACzC,MAAM,CAAC,aAAa,CAAC;SACrB,WAAW,CACV,OAAO,EACP;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAgCL,CACI,CAAC;IAEJ,OAAO,OAAO,CAAC;AACjB,CAAC"}
+{"version":3,"file":"review.js","sourceRoot":"","sources":["../../../src/commands/skill/review.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,SAAS,CAAC;AAC/C,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAEpC,OAAO,EACL,iBAAiB,EACjB,yBAAyB,GAE1B,MAAM,kCAAkC,CAAC;AAE1C,OAAO,EACL,WAAW,EACX,yBAAyB,EACzB,eAAe,EACf,yBAAyB,EACzB,YAAY,EACZ,UAAU,GAGX,MAAM,4BAA4B,CAAC;AACpC,OAAO,EAAE,QAAQ,EAAE,MAAM,2BAA2B,CAAC;AACrD,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpC,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB,OAAO,EAAE,gCAAgC,EAAE,2BAA2B,EAAE,MAAM,4CAA4C,CAAC;AAC3H,OAAO,EAAE,wBAAwB,EAAE,MAAM,8BAA8B,CAAC;AACxE,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,YAAY,EAAe,MAAM,uBAAuB,CAAC;AAClE,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AACxD,OAAO,EAAE,iBAAiB,EAAE,MAAM,oCAAoC,CAAC;AACvE,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,mBAAmB,EAAE,MAAM,gCAAgC,CAAC;AAErE,OAAO,EACL,kBAAkB,EAClB,sBAAsB,EACtB,cAAc,GAEf,MAAM,uBAAuB,CAAC;AAS/B,+GAA+G;AAC/G,MAAM,mBAAmB,GAAG,CAAC,CAAC,MAAM,CAAC;IACnC,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE;IACnB,sFAAsF;IACtF,KAAK,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;IAC1B,qEAAqE;IACrE,MAAM,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;CAC5B,CAAC,CAAC,MAAM,EAAE,CAAC;AAEZ,mDAAmD;AACnD,MAAM,CAAC,MAAM,qBAAqB,GAAG,CAAC,CAAC,MAAM,CAAC;IAC5C,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE;IACjB,iCAAiC;IACjC,MAAM,EAAE,CAAC,CAAC,MAAM,EAAE;IAClB,QAAQ,EAAE,CAAC,CAAC,MAAM,CAAC;QACjB,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QAC1C,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QAC1C,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QACzC,eAAe,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QAC/C,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QAC5C,sBAAsB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,EAAE;QACtD,kBAAkB,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,CAAC;YACnC,IAAI,EAAE,CAAC,CAAC,MAAM,EAAE;YAChB,MAAM,EAAE,CAAC,CAAC,MAAM,EAAE;YAClB,cAAc,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;SACtC,CAAC,CAAC,MAAM,EAAE,CAAC;KACb,CAAC,CAAC,MAAM,EAAE;IACX;;;;OAIG;IACH,QAAQ,EAAE,CAAC,CAAC,KAAK,CAAC,mBAAmB,CAAC;CACvC,CAAC,CAAC,MAAM,EAAE,CAAC;AAIZ,uCAAuC;AACvC,MAAM,CAAC,MAAM,0BAA0B,GAAG,YAAY,CAAC,qBAAqB,CAAC,CAAC;AAI9E;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,gBAAgB,CAAC,OAAe;IAC9C,MAAM,QAAQ,GAAG,QAAQ,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;IAE3C,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC1B,MAAM,IAAI,KAAK,CAAC,wBAAwB,OAAO,EAAE,CAAC,CAAC;IACrD,CAAC;IAED,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAEhC,IAAI,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC;QAClB,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;YAC9B,MAAM,IAAI,KAAK,CACb,6DAA6D,OAAO,EAAE,CACvE,CAAC;QACJ,CAAC;QACD,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,IAAI,IAAI,CAAC,WAAW,EAAE,EAAE,CAAC;QACvB,MAAM,SAAS,GAAG,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;QACtD,IAAI,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE,CAAC;YAC3B,MAAM,IAAI,KAAK,CACb,mCAAmC,OAAO,qFAAqF,CAChI,CAAC;QACJ,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,IAAI,KAAK,CAAC,2CAA2C,OAAO,EAAE,CAAC,CAAC;AACxE,CAAC;AAED;;;;GAIG;AACH,SAAS,oBAAoB,CAC3B,MAAkC;IAElC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAuC,CAAC;IAC/D,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,OAAO,CAAC,GAAG,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAC3B,CAAC;IACD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,MAAM,OAAO,GAAG,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAC3C,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC;IACpC,CAAC;IAED,MAAM,YAAY,GAA2B,EAAE,KAAK,EAAE,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;IAC/E,KAAK,MAAM,IAAI,IAAI,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC;QACpC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACzF,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED;;;GAGG;AACH,SAAS,iBAAiB,CACxB,MAAiC,EACjC,SAAiB,EACjB,OAAiD,EACjD,MAAc;IAEd,yEAAyE;IACzE,+DAA+D;IAC/D,MAAM,MAAM,GAAG,eAAe,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;IAEjD,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,oBAAoB,MAAM,CAAC,SAAS,EAAE,CAAC,CAAC;IACpD,MAAM,CAAC,IAAI,CAAC,WAAW,SAAS,EAAE,CAAC,CAAC;IACpC,MAAM,CAAC,IAAI,CACT,YAAY,MAAM,CAAC,MAAM,cAAc,MAAM,CAAC,QAAQ,gBAAgB,MAAM,CAAC,IAAI,OAAO,CACzF,CAAC;IACF,MAAM,CAAC,IAAI,CACT,aAAa,MAAM,CAAC,QAAQ,CAAC,UAAU,oBAAoB,MAAM,CAAC,QAAQ,CAAC,UAAU,uBAAuB,MAAM,CAAC,QAAQ,CAAC,SAAS,UAAU,CAChJ,CAAC;IAEF,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,oDAAoD,CAAC,CAAC;IAElE,IAAI,MAAM,GAAG,KAAK,CAAC;IACnB,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAC1C,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAClC,MAAM,GAAG,IAAI,CAAC;QACd,MAAM,CAAC,IAAI,CAAC,OAAO,OAAO,KAAK,MAAM,CAAC,MAAM,IAAI,CAAC,CAAC;QAClD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;YAC3B,WAAW,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;QAC7B,CAAC;IACH,CAAC;IACD,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,MAAM,CAAC,IAAI,CAAC,yCAAyC,CAAC,CAAC;IACzD,CAAC;IAED,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChB,MAAM,CAAC,IAAI,CAAC,gEAAgE,CAAC,CAAC;IAC9E,KAAK,MAAM,OAAO,IAAI,kBAAkB,EAAE,CAAC;QACzC,MAAM,KAAK,GAAG,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAC9C,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QACjC,MAAM,CAAC,IAAI,CAAC,OAAO,OAAO,GAAG,CAAC,CAAC;QAC/B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,MAAM,CAAC,IAAI,CAAC,WAAW,IAAI,EAAE,CAAC,CAAC;QACjC,CAAC;IACH,CAAC;AACH,CAAC;AAED,4DAA4D;AAC5D,SAAS,WAAW,CAAC,KAAsB,EAAE,MAAc;IACzD,MAAM,WAAW,GAAG,KAAK,CAAC,QAAQ,CAAC,WAAW,EAAE,CAAC;IACjD,MAAM,CAAC,IAAI,CAAC,UAAU,WAAW,MAAM,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IACvE,MAAM,MAAM,GAAG,iBAAiB,CAAC,KAAK,CAAC,CAAC;IACxC,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QACzB,MAAM,CAAC,IAAI,CAAC,qBAAqB,MAAM,EAAE,CAAC,CAAC;IAC7C,CAAC;IACD,IAAI,KAAK,CAAC,GAAG,KAAK,SAAS,IAAI,KAAK,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;QAChD,MAAM,CAAC,IAAI,CAAC,gBAAgB,KAAK,CAAC,GAAG,EAAE,CAAC,CAAC;IAC3C,CAAC;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,iBAAiB,CAC/B,MAAiC,EACjC,SAAiB,EACjB,OAAkE;IAElE,MAAM,QAAQ,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,UAAU,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IACjG,MAAM,QAAQ,GAAG,kBAAkB,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;QACpD,OAAO;QACP,KAAK,EAAE,UAAU,CAAC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC;QACxE,MAAM,EAAE,CAAC,GAAG,sBAAsB,CAAC,OAAO,CAAC,CAAC;KAC7C,CAAC,CAAC,CAAC;IACJ,OAAO,WAAW,CAAkB;QAClC,QAAQ,EAAE,CAAC;QACX,QAAQ;QACR,IAAI,EAAE;YACJ,KAAK,EAAE,MAAM,CAAC,SAAS;YACvB,MAAM,EAAE,SAAS;YACjB,QAAQ,EAAE;gBACR,GAAG,MAAM,CAAC,QAAQ;gBAClB,kBAAkB,EAAE,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;oBACtE,IAAI,EAAE,MAAM,CAAC,IAAI;oBACjB,MAAM,EAAE,MAAM,CAAC,MAAM;oBACrB,GAAG,CAAC,MAAM,CAAC,cAAc,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,cAAc,EAAE,MAAM,CAAC,cAAc,EAAE,CAAC;iBAC1F,CAAC,CAAC;aACJ;YACD,QAAQ;SACT;KACF,CAAC,CAAC;AACL,CAAC;AAED,2EAA2E;AAC3E,SAAS,YAAY,CAAC,MAAiC,EAAE,MAAc;IACrE,MAAM,YAAY,GAAG,IAAI,GAAG,EAAU,CAAC;IACvC,KAAK,MAAM,KAAK,IAAI,MAAM,CAAC,SAAS,EAAE,CAAC;QACrC,YAAY,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC/B,CAAC;IACD,MAAM,gBAAgB,GAAG,yBAAyB,CAAC,MAAM,CAAC,SAAS,CAAC,KAAK,SAAS,CAAC;IACnF,wBAAwB,CAAC,MAAM,EAAE,gBAAgB,EAAE,YAAY,CAAC,CAAC;AACnE,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,aAAa,CACjC,OAA2B,EAC3B,OAAkC;IAElC,MAAM,MAAM,GAAG,YAAY,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IAClE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAE7B,IAAI,CAAC;QACH,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,EAAE,EAAE,CAAC;YAC5C,MAAM,IAAI,KAAK,CAAC,2EAA2E,CAAC,CAAC;QAC/F,CAAC;QAED,wEAAwE;QACxE,4EAA4E;QAC5E,6EAA6E;QAC7E,4DAA4D;QAC5D,iBAAiB,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;QAEjC,MAAM,SAAS,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;QAC5C,MAAM,CAAC,KAAK,CAAC,0BAA0B,SAAS,EAAE,CAAC,CAAC;QAEpD,sEAAsE;QACtE,wEAAwE;QACxE,8DAA8D;QAC9D,sCAAsC;QACtC,MAAM,eAAe,GAAG,CAAC,MAAM,2BAA2B,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,IAAI,SAAS,CAAC;QAC9F,6EAA6E;QAC7E,yEAAyE;QACzE,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,SAAS,EAAE,eAAe,EAAE,QAAQ,EAAE;YACnF,aAAa,EAAE,MAAM,gCAAgC,CAAC,SAAS,EAAE,QAAQ,CAAC;YAC1E,uEAAuE;YACvE,+DAA+D;YAC/D,UAAU,EAAE,QAAQ;SACrB,CAAC,CAAC;QACH,uEAAuE;QACvE,uEAAuE;QACvE,uDAAuD;QACvD,mBAAmB,CACjB,MAAM,EACN,eAAe,EAAE,OAAwC,EACzD,SAAS,EACT,iBAAiB,CAAC,SAAS,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC,CACjD,CAAC;QAEF,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QAEvD,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;YACjB,eAAe,CAAC,EAAE,GAAG,iBAAiB,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,CAAC,EAAE,UAAU,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC;QAC5G,CAAC;aAAM,CAAC;YACN,iBAAiB,CAAC,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,MAAM,CAAC,CAAC;QACxD,CAAC;QAED,YAAY,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;QAE7B,sEAAsE;QACtE,wEAAwE;QACxE,2EAA2E;QAC3E,qEAAqE;QACrE,OAAO,CAAC,IAAI,CAAC,yBAAyB,CAAC,eAAe,CAAC,MAAM,CAAC,SAAS,CAAC,EAAE,EAAE,MAAM,EAAE,OAAO,CAAC,MAAM,KAAK,IAAI,EAAE,CAAC,CAAC,CAAC;IAClH,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,wBAAwB,CAAC,KAAK,EAAE,MAAM,EAAE,SAAS,EAAE,aAAa,CAAC,CAAC;IACpE,CAAC;AACH,CAAC;AAED,MAAM,UAAU,wBAAwB;IACtC,MAAM,OAAO,GAAG,IAAI,OAAO,CAAC,QAAQ,CAAC,CAAC;IAEtC,OAAO;SACJ,WAAW,CAAC,iFAAiF,CAAC;SAC9F,QAAQ,CAAC,QAAQ,EAAE,8FAA8F,CAAC;SAClH,MAAM,CAAC,QAAQ,EAAE,2DAA2D,CAAC;SAC7E,MAAM,CAAC,UAAU,EAAE,sCAAsC,CAAC;SAC1D,MAAM,CAAC,SAAS,EAAE,sBAAsB,CAAC;SACzC,MAAM,CAAC,aAAa,CAAC;SACrB,WAAW,CACV,OAAO,EACP;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;CAkCL,CACI,CAAC;IAEJ,OAAO,OAAO,CAAC;AACjB,CAAC"}

package/dist/commands/skill/test/configure.d.ts

@@ -5,6 +5,7 @@
  * Orchestration only. Domain logic lives in upsertTestConfig (agent-skills).
  * Mirrors review.ts error-handling conventions (handleCommandError / projectRootOrNull).
  */
+import { upsertTestConfig } from '@vibe-agent-toolkit/agent-skills';
 import { Command } from 'commander';
 export interface SkillTestConfigureOptions {
     auth?: string;
@@ -13,10 +14,65 @@ export interface SkillTestConfigureOptions {
     timeout?: string;
     stall?: string;
     model?: string;
+    /**
+     * Tri-state, like `run`'s: `true` from `--baseline`, `false` from
+     * `--no-baseline`, `undefined` when neither was typed — and only `undefined`
+     * leaves an existing `baseline:` in the config alone. Commander gives this shape
+     * only because `--baseline` is declared BEFORE `--no-baseline`; declaring the
+     * negation first would default it to `true` and make every `configure` call
+     * silently commit a baseline.
+     */
     baseline?: boolean;
     evals?: string;
     print?: boolean;
     debug?: boolean;
 }
+/**
+ * Assemble the knob patch handed to `upsertTestConfig`. Exported for testing: the
+ * option DECLARATIONS were pinned (Commander's `--baseline`/`--no-baseline`
+ * tri-state) and `upsertTestConfig` writes `false` correctly, but the assembly
+ * between them — the step that decides which typed flags become knobs at all — was
+ * not, so both `if (options.baseline === true)` (a `--no-baseline` that silently
+ * does nothing, i.e. the exact regression `--no-baseline` exists to prevent) and
+ * deleting the branch outright left the whole CLI suite green.
+ */
+export declare function buildKnobs(options: SkillTestConfigureOptions): Parameters<typeof upsertTestConfig>[2];
+/**
+ * Read the config at `configPath`, apply `knobs` to `skillName`'s test block, and
+ * hand back the YAML to write — refusing only what VAT would otherwise MISREAD.
+ *
+ * Exported and separated from the command because the command's own shape made
+ * both of this lane's defects untestable: the read and the schema check were
+ * inlined between a `process.cwd()` walk-up and a `writeFileSync`, so reaching
+ * them from a test meant `process.chdir`, which the Unix unit pool (threads)
+ * cannot do at all. Two defects therefore shipped with a green suite.
+ *
+ * 🔑 **The schema check goes through the SHARED reader**, not
+ * `ProjectConfigSchema.safeParse`. This was the THIRD config reader in the
+ * toolkit and the only one still carrying both defects the other two had fixed:
+ *
+ * - An unrecognized key was a hard refusal. `vat skill test configure my-skill
+ *   --max-turns 20` exited 1 on a config carrying `resources.metadata` — a
+ *   section this command never reads — refusing to write a change that had
+ *   nothing to do with it. Unknown keys are a warning now; see
+ *   {@link parseConfigAllowingUnknownKeys} for why.
+ * - The message was `validation.error.message`, which in Zod 3 is a **JSON dump
+ *   of the issue array**: no file named, no key named in words, no remedy.
+ *
+ * 🔑 **The read goes through `readTextContent`**, never `readFileSync(path,
+ * 'utf-8')`. This is a read-modify-WRITE path, so a UTF-16LE or BOM-prefixed
+ * config (what PowerShell 5.1 writes by default) was decoded as mojibake and then
+ * serialized back over the original — destroying a config whose only fault was
+ * its encoding.
+ *
+ * @param configPath - Absolute path to `vibe-agent-toolkit.config.yaml`
+ * @param skillName - The key under `skills.config` to upsert
+ * @param knobs - The knobs the operator typed; only these are changed
+ * @param onWarn - Receives the unknown-key warning, if any
+ * @returns The updated YAML, comments and key ordering preserved
+ * @throws Error when the UPDATED config would fail validation for any reason
+ *   other than an unknown key
+ */
+export declare function updateSkillTestConfig(configPath: string, skillName: string, knobs: Parameters<typeof upsertTestConfig>[2], onWarn: (message: string) => void): Promise<string>;
 export declare function createSkillTestConfigureCommand(): Command;
 //# sourceMappingURL=configure.d.ts.map

package/dist/commands/skill/test/configure.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"configure.d.ts","sourceRoot":"","sources":["../../../../src/commands/skill/test/configure.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAOH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAUpC,MAAM,WAAW,yBAAyB;IACxC,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAiGD,wBAAgB,+BAA+B,IAAI,OAAO,CAsCzD"}
+{"version":3,"file":"configure.d.ts","sourceRoot":"","sources":["../../../../src/commands/skill/test/configure.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAIH,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AAIpE,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAUpC,MAAM,WAAW,yBAAyB;IACxC,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,MAAM,CAAC;IACf;;;;;;;OAOG;IACH,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAkBD;;;;;;;;GAQG;AACH,wBAAgB,UAAU,CACxB,OAAO,EAAE,yBAAyB,GACjC,UAAU,CAAC,OAAO,gBAAgB,CAAC,CAAC,CAAC,CAAC,CA8BxC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmCG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,MAAM,EAClB,SAAS,EAAE,MAAM,EACjB,KAAK,EAAE,UAAU,CAAC,OAAO,gBAAgB,CAAC,CAAC,CAAC,CAAC,EAC7C,MAAM,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,IAAI,GAChC,OAAO,CAAC,MAAM,CAAC,CAiBjB;AAqCD,wBAAgB,+BAA+B,IAAI,OAAO,CAkDzD"}