@vforsh/notif 0.1.0 → 0.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vforsh/notif",
-  "version": "0.1.0",
+  "version": "0.3.0",
   "description": "CLI for sending push notifications via ntfy",
   "type": "module",
   "license": "MIT",
@@ -29,6 +29,7 @@
     "typescript": "^5"
   },
   "dependencies": {
+    "@vforsh/yadisk": "^1.1.0",
     "commander": "^14.0.3",
     "picocolors": "^1.1.1",
     "zod": "^4.3.6"

package/skill/notif/SKILL.md

@@ -29,7 +29,7 @@ notif --topic other-channel "Override topic"
 | `--priority` | `-p` | `1`=min, `2`=low, `3`=default, `4`=high, `5`=max |
 | `--tags` | `-T` | Comma-separated tags/emojis |
 | `--click` | | URL to open on tap |
-| `--file` | | Local file attachment |
+| `--file` | | Upload local file to storage provider, attach public URL |
 | `--attach` | | Remote URL attachment |
 | `--md` | | Markdown formatting |
 | `--delay` | | Schedule: `10s`, `30m`, ISO timestamp |
@@ -43,13 +43,14 @@ notif --topic other-channel "Override topic"
 
 **NEVER send `localhost` or `127.0.0.1` URLs in notifications.** Notifications arrive on mobile devices on the same Wi-Fi network — localhost is unreachable there.
 
-Replace with the machine's LAN IP before sending:
+Use `lan_ip` from config (check with `notif cfg ls`) instead:
 
 ```bash
-LAN_IP=$(ipconfig getifaddr en0)
-notif --click "http://$LAN_IP:3000" "Dev server ready"
+notif --click "http://192.168.1.12:3000" "Dev server ready"
 ```
 
+Fallback if `lan_ip` is not configured: `ipconfig getifaddr en0`.
+
 This applies to `--click` URLs, URLs in message body, and any other link.
 
 ## Config
@@ -58,12 +59,25 @@ This applies to `--click` URLs, URLs in message body, and any other link.
 - `notif cfg init` — interactive setup (TTY)
 - `notif cfg set <key> <value>` — set value (`server`, `topic`; secrets via stdin)
 - `notif cfg unset <key>` — remove value
-- `notif doctor` — verify setup (config, server reachability)
+- `notif doctor` — verify setup (config, server reachability, storage provider)
+
+### Config keys
+
+| Key | Description |
+|-----|-------------|
+| `server` | ntfy server URL |
+| `topic` | Default topic |
+| `user` | Auth user:pass (secret, set via stdin) |
+| `token` | Auth token (secret, set via stdin) |
+| `upload_provider` | Storage provider for `--file` uploads (e.g. `yadisk`) |
+| `upload_path` | Remote directory for uploads (default: `/notif-uploads`) |
+| `lan_ip` | Machine's LAN IP — use instead of `localhost` in notification URLs |
 
 ## Errors
 
 | Message | Cause |
 |---------|-------|
+| `No storage provider configured` | Run `notif cfg set upload_provider yadisk` |
 | `No server configured` | Run `notif cfg set server <url>` |
 | `No topic configured` | Run `notif cfg set topic <name>` |
 | `ntfy error 401` | Auth failed |

package/src/cli/commands/config.ts

@@ -68,12 +68,18 @@ export function registerConfigCommand(program: Command) {
 
 			const server = await prompt("server", current.server);
 			const topic = await prompt("topic", current.topic);
+			const upload_provider = await prompt("upload_provider", current.upload_provider);
+			const upload_path = await prompt("upload_path", current.upload_path);
+			const lan_ip = await prompt("lan_ip", current.lan_ip);
 			const user = await prompt("user", current.user, true);
 			const token = await prompt("token", current.token, true);
 
 			const updated: Config = {};
 			if (server) updated.server = server;
 			if (topic) updated.topic = topic;
+			if (upload_provider) updated.upload_provider = upload_provider;
+			if (upload_path) updated.upload_path = upload_path;
+			if (lan_ip) updated.lan_ip = lan_ip;
 			if (user) updated.user = user;
 			if (token) updated.token = token;
 

package/src/cli/commands/doctor.ts

@@ -82,6 +82,31 @@ const checks: Check[] = [
 			return { status: "pass", detail: "none (anonymous)" };
 		},
 	},
+	{
+		name: "Storage provider",
+		run: async () => {
+			const cfg = await readConfig();
+			const provider = process.env.NOTIF_UPLOAD_PROVIDER || cfg.upload_provider;
+			if (!provider) {
+				return {
+					status: "warn",
+					detail: "not configured (file uploads disabled)",
+					hint: "notif cfg set upload_provider yadisk",
+				};
+			}
+
+			const { KNOWN_PROVIDERS } = await import("../../lib/storage.ts");
+			if (!KNOWN_PROVIDERS.includes(provider)) {
+				return {
+					status: "fail",
+					detail: `unknown provider: ${provider}`,
+					hint: `known providers: ${KNOWN_PROVIDERS.join(", ")}`,
+				};
+			}
+
+			return { status: "pass", detail: provider };
+		},
+	},
 	{
 		name: "Server reachable",
 		run: async () => {

package/src/lib/config.ts

@@ -10,11 +10,14 @@ const ConfigSchema = z.object({
 	topic: z.string().optional(),
 	user: z.string().optional(),
 	token: z.string().optional(),
+	upload_provider: z.string().optional(),
+	upload_path: z.string().optional(),
+	lan_ip: z.string().optional(),
 });
 
 export type Config = z.infer<typeof ConfigSchema>;
 
-const VALID_KEYS = ["server", "topic", "user", "token"] as const;
+const VALID_KEYS = ["server", "topic", "user", "token", "upload_provider", "upload_path", "lan_ip"] as const;
 type ConfigKey = (typeof VALID_KEYS)[number];
 
 export function isValidKey(key: string): key is ConfigKey {

package/src/lib/publish.ts

@@ -1,4 +1,5 @@
 import { readConfig } from "./config.ts";
+import { getStorageProvider, buildRemotePath } from "./storage.ts";
 
 export interface PublishOptions {
 	server?: string;
@@ -18,6 +19,8 @@ export interface PublishOptions {
 	noFirebase?: boolean;
 	sequenceId?: string;
 	file?: string;
+	uploadProvider?: string;
+	uploadPath?: string;
 	user?: string;
 	token?: string;
 }
@@ -59,41 +62,24 @@ export async function publish(message: string | undefined, opts: PublishOptions)
 		authHeaders["Authorization"] = `Basic ${btoa(user)}`;
 	}
 
-	// File upload via PUT (must use headers for metadata)
+	// File upload via external storage provider → attach URL
 	if (opts.file) {
 		const file = Bun.file(opts.file);
 		if (!(await file.exists())) {
 			throw new Error(`File not found: ${opts.file}`);
 		}
 
-		const headers: Record<string, string> = { ...authHeaders };
-		if (opts.title) headers["Title"] = opts.title;
-		if (opts.priority) headers["Priority"] = opts.priority;
-		if (opts.tags) headers["Tags"] = opts.tags;
-		if (opts.click) headers["Click"] = opts.click;
-		if (opts.icon) headers["Icon"] = opts.icon;
-		if (opts.delay) headers["Delay"] = opts.delay;
-		if (opts.email) headers["Email"] = opts.email;
-		if (opts.actions) headers["Actions"] = opts.actions;
-		if (opts.markdown) headers["Markdown"] = "yes";
-		if (opts.noCache) headers["Cache"] = "no";
-		if (opts.noFirebase) headers["Firebase"] = "no";
-		if (opts.sequenceId) headers["X-Sequence-ID"] = opts.sequenceId;
-		headers["Filename"] = opts.filename || opts.file.split("/").pop() || opts.file;
-		if (message) headers["Message"] = message;
-
-		const resp = await fetch(`${baseUrl}/${topic}`, {
-			method: "PUT",
-			headers,
-			body: file,
-		});
-
-		if (!resp.ok) {
-			const text = await resp.text();
-			throw new Error(`ntfy error ${resp.status}: ${text}`);
+		const uploadProvider = opts.uploadProvider || process.env.NOTIF_UPLOAD_PROVIDER || config.upload_provider;
+		if (!uploadProvider) {
+			throw new Error("No storage provider configured. Run: notif config set upload_provider yadisk");
 		}
 
-		return (await resp.json()) as PublishResult;
+		const uploadPath = opts.uploadPath || process.env.NOTIF_UPLOAD_PATH || config.upload_path || "/uploads/notif-cli";
+		const remotePath = buildRemotePath(uploadPath, opts.file, opts.filename);
+		const provider = getStorageProvider(uploadProvider);
+		const publicUrl = await provider.upload(opts.file, remotePath);
+
+		if (!opts.click) opts.click = publicUrl;
 	}
 
 	// Regular message via JSON body (supports UTF-8 in all fields)

package/src/lib/storage.ts

@@ -0,0 +1,60 @@
+import { basename } from "node:path";
+
+export interface StorageProvider {
+	name: string;
+	upload(localPath: string, remotePath: string): Promise<string>; // returns public URL
+}
+
+export class YaDiskStorageProvider implements StorageProvider {
+	name = "yadisk";
+
+	async upload(localPath: string, remotePath: string): Promise<string> {
+		const pkg = "@vforsh/yadisk";
+		const { YaDiskClient, getCredentials } = await import(/* @vite-ignore */ pkg);
+		const credentials = getCredentials();
+		const client = new YaDiskClient(credentials);
+
+		const parentDir = remotePath.replace(/\/[^/]+$/, "");
+		if (parentDir) {
+			await client.mkdir(parentDir).catch(() => {}); // already exists is fine
+		}
+
+		await client.upload(remotePath, localPath);
+		const url = await client.publish(remotePath);
+		if (!url) {
+			const existing = await client.getPublicUrl(remotePath);
+			if (!existing) throw new Error(`Failed to get public URL for ${remotePath}`);
+			return existing;
+		}
+		return url;
+	}
+}
+
+const PROVIDERS: Record<string, () => StorageProvider> = {
+	yadisk: () => new YaDiskStorageProvider(),
+};
+
+export const KNOWN_PROVIDERS = Object.keys(PROVIDERS);
+
+export function getStorageProvider(name: string): StorageProvider {
+	const factory = PROVIDERS[name];
+	if (!factory) {
+		throw new Error(`Unknown storage provider: ${name}. Known: ${KNOWN_PROVIDERS.join(", ")}`);
+	}
+	return factory();
+}
+
+export function buildRemotePath(uploadDir: string, localPath: string, filenameOverride?: string): string {
+	const now = new Date();
+	const ts = [
+		now.getFullYear(),
+		String(now.getMonth() + 1).padStart(2, "0"),
+		String(now.getDate()).padStart(2, "0"),
+		"-",
+		String(now.getHours()).padStart(2, "0"),
+		String(now.getMinutes()).padStart(2, "0"),
+		String(now.getSeconds()).padStart(2, "0"),
+	].join("");
+	const filename = filenameOverride || basename(localPath);
+	return `${uploadDir.replace(/\/+$/, "")}/${ts}-${filename}`;
+}