@vertesia/workflow 1.1.1-dev.20260505.160410Z → 1.2.0

package/lib/types/activities/executeInteraction.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"executeInteraction.d.ts","sourceRoot":"","sources":["../../../src/activities/executeInteraction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAoB,YAAY,EAAmB,MAAM,oBAAoB,CAAC;AAErF,OAAO,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAC;AAElD,OAAO,EACH,2BAA2B,EAC3B,eAAe,EAMlB,MAAM,kBAAkB,CAAC;AAI1B,OAAO,EAAE,YAAY,EAAoB,MAAM,oBAAoB,CAAC;AAiDpE,MAAM,WAAW,0BAA0B;IACvC;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB;;;;OAIG;IACH,KAAK,CAAC,EAAE,MAAM,CAAC;IAEf;;OAEG;IACH,aAAa,CAAC,EAAE,GAAG,CAAC;IAEpB,uDAAuD;IACvD,eAAe,CAAC,EAAE,OAAO,CAAC;IAE1B;;OAEG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAC;IAEhB;;OAEG;IACH,sBAAsB,CAAC,EAAE,OAAO,CAAC;IAEjC;;OAEG;IACH,aAAa,CAAC,EAAE,YAAY,CAAC;IAE7B;;OAEG;IACH,2BAA2B,CAAC,EAAE,OAAO,CAAC;CACzC;AAED;;;;GAIG;AACH,MAAM,WAAW,wBAAyB,SAAQ,0BAA0B;IAExE,eAAe,EAAE,MAAM,CAAC;IACxB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;IACjC;;;;OAIG;IACH,kBAAkB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;IACzC,QAAQ,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,YAAY,CAAC,CAAC;CAC3C;AAED,MAAM,WAAW,kBAAmB,SAAQ,eAAe,CAAC,wBAAwB,CAAC;IACjF,IAAI,EAAE,oBAAoB,CAAC;CAC9B;AAED,wBAAsB,kBAAkB,CAAC,OAAO,EAAE,2BAA2B,CAAC,wBAAwB,CAAC,gBAoHtG;AAED,wBAAsB,8BAA8B,CAChD,MAAM,EAAE,cAAc,EACtB,eAAe,EAAE,MAAM,EACvB,MAAM,EAAE,0BAA0B,EAClC,WAAW,EAAE,GAAG,EAChB,KAAK,CAAC,EAAE,OAAO,oFAuFlB"}
+{"version":3,"file":"executeInteraction.d.ts","sourceRoot":"","sources":["../../../src/activities/executeInteraction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAoB,YAAY,EAAmB,MAAM,oBAAoB,CAAC;AAErF,OAAO,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAC;AAElD,OAAO,EACH,2BAA2B,EAC3B,eAAe,EAMlB,MAAM,kBAAkB,CAAC;AAI1B,OAAO,EAAE,YAAY,EAAoB,MAAM,oBAAoB,CAAC;AAiDpE,MAAM,WAAW,0BAA0B;IACvC;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB;;;;OAIG;IACH,KAAK,CAAC,EAAE,MAAM,CAAC;IAEf;;OAEG;IACH,aAAa,CAAC,EAAE,GAAG,CAAC;IAEpB,uDAAuD;IACvD,eAAe,CAAC,EAAE,OAAO,CAAC;IAE1B;;OAEG;IACH,IAAI,CAAC,EAAE,MAAM,EAAE,CAAC;IAEhB;;OAEG;IACH,sBAAsB,CAAC,EAAE,OAAO,CAAC;IAEjC;;OAEG;IACH,aAAa,CAAC,EAAE,YAAY,CAAC;IAE7B;;OAEG;IACH,2BAA2B,CAAC,EAAE,OAAO,CAAC;CACzC;AAED;;;;GAIG;AACH,MAAM,WAAW,wBAAyB,SAAQ,0BAA0B;IAExE,eAAe,EAAE,MAAM,CAAC;IACxB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;IACjC;;;;OAIG;IACH,kBAAkB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;IACzC,QAAQ,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,YAAY,CAAC,CAAC;CAC3C;AAED,MAAM,WAAW,kBAAmB,SAAQ,eAAe,CAAC,wBAAwB,CAAC;IACjF,IAAI,EAAE,oBAAoB,CAAC;CAC9B;AAED,wBAAsB,kBAAkB,CAAC,OAAO,EAAE,2BAA2B,CAAC,wBAAwB,CAAC,gBAqHtG;AAED,wBAAsB,8BAA8B,CAChD,MAAM,EAAE,cAAc,EACtB,eAAe,EAAE,MAAM,EACvB,MAAM,EAAE,0BAA0B,EAClC,WAAW,EAAE,GAAG,EAChB,KAAK,CAAC,EAAE,OAAO,oFAuFlB"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vertesia/workflow",
-  "version": "1.1.1-dev.20260505.160410Z",
+  "version": "1.2.0",
   "type": "module",
   "description": "Vertesia workflow DSL",
   "main": "./lib/esm/index.js",
@@ -44,10 +44,10 @@
     "tmp-promise": "^3.0.3",
     "yaml": "^2.6.0",
     "@llumiverse/common": "1.1.1-dev.20260505.151157Z",
-    "@vertesia/api-fetch-client": "1.1.1-dev.20260505.160410Z",
-    "@vertesia/common": "1.1.1-dev.20260505.160410Z",
-    "@vertesia/client": "1.1.1-dev.20260505.160410Z",
-    "@vertesia/memory": "1.1.1-dev.20260505.160410Z"
+    "@vertesia/api-fetch-client": "1.2.0",
+    "@vertesia/common": "1.2.0",
+    "@vertesia/client": "1.2.0",
+    "@vertesia/memory": "1.2.0"
   },
   "ts_dual_module": {
     "outDir": "lib",

package/src/activities/executeInteraction.test.ts

@@ -0,0 +1,83 @@
+import { ApplicationFailure } from '@temporalio/activity';
+import { MockActivityEnvironment } from '@temporalio/testing';
+import type { VertesiaClient } from '@vertesia/client';
+import { ContentEventName, type DSLActivityExecutionPayload } from '@vertesia/common';
+import type { ActivityContext } from '../dsl/setup/ActivityContext.js';
+import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest';
+import { executeInteraction, type ExecuteInteractionParams } from './executeInteraction.js';
+
+vi.mock('../dsl/setup/ActivityContext.js', async (importOriginal) => {
+    const actual = await importOriginal<typeof import('../dsl/setup/ActivityContext.js')>();
+    return { ...actual, setupActivity: vi.fn() };
+});
+
+let testEnv: MockActivityEnvironment;
+
+beforeAll(() => {
+    testEnv = new MockActivityEnvironment();
+});
+
+beforeEach(() => {
+    vi.clearAllMocks();
+});
+
+const createPayload = (): DSLActivityExecutionPayload<ExecuteInteractionParams> => ({
+    auth_token: 'mock-token',
+    account_id: 'test-account',
+    project_id: 'test-project',
+    params: {
+        interactionName: 'testInteraction',
+        prompt_data: {},
+    },
+    config: { studio_url: 'http://mock-studio', store_url: 'http://mock-store' },
+    workflow_name: 'test-workflow',
+    event: ContentEventName.create,
+    objectIds: ['test-object-id'],
+    input: { inputType: 'objectIds', objectIds: ['test-object-id'] },
+    vars: {},
+    activity: { name: 'executeInteraction', params: {} },
+});
+
+async function mockInteractionError(error: Error & { statusCode?: number; status?: number; code?: number }): Promise<void> {
+    const { setupActivity } = await import('../dsl/setup/ActivityContext.js');
+    const mockClient = {
+        interactions: {
+            executeByName: vi.fn().mockRejectedValue(error),
+        },
+    } as unknown as VertesiaClient;
+
+    vi.mocked(setupActivity).mockResolvedValue({
+        client: mockClient,
+        inputType: 'objectIds',
+        params: createPayload().params,
+    } as unknown as ActivityContext<ExecuteInteractionParams>);
+}
+
+describe('executeInteraction retryability', () => {
+    it('leaves 412 rendition-in-progress failures retryable', async () => {
+        await mockInteractionError(Object.assign(new Error('rendition in progress'), { statusCode: 412 }));
+
+        await expect(testEnv.run(executeInteraction, createPayload())).rejects.toMatchObject({
+            message: 'Interaction Execution failed testInteraction: rendition in progress',
+        });
+    });
+
+    it.each([
+        ['status', { status: 412 }],
+        ['code', { code: 412 }],
+    ])('leaves 412 failures retryable when reported as %s', async (_field, statusProps) => {
+        await mockInteractionError(Object.assign(new Error('precondition failed'), statusProps));
+
+        await expect(testEnv.run(executeInteraction, createPayload())).rejects.toMatchObject({
+            message: 'Interaction Execution failed testInteraction: precondition failed',
+        });
+    });
+
+    it('marks other 4xx failures as non-retryable', async () => {
+        await mockInteractionError(Object.assign(new Error('bad request'), { statusCode: 400 }));
+
+        await expect(testEnv.run(executeInteraction, createPayload())).rejects.toMatchObject({
+            nonRetryable: true,
+        } satisfies Partial<ApplicationFailure>);
+    });
+});

package/src/activities/executeInteraction.ts

@@ -203,7 +203,8 @@ export async function executeInteraction(payload: DSLActivityExecutionPayload<Ex
         if (error.statusCode === 429 && params.exit_on_resource_exhaustion) {
             throw new ResourceExhaustedError(error.statusCode, "Resource exhausted - rate limit exceeded");
         } else if (is4xxNonRetryable(error.status) || is4xxNonRetryable(error.statusCode) || is4xxNonRetryable(error.code) || error.retryable === false) {
-            // 4xx HTTP errors (except 429 rate-limit) are permanent client errors (e.g. model not found, invalid request).
+            // 4xx HTTP errors (except retryable statuses) are permanent client errors
+            // (e.g. model not found, invalid request).
             // Errors explicitly marked as non-retryable (e.g. LlumiverseError) also fall here.
             // They will not be resolved by retrying.
             throw ApplicationFailure.create({
@@ -341,9 +342,10 @@ export async function executeInteractionFromActivity(
 
 /**
  * Returns true for 4xx status codes that indicate permanent client errors.
- * 429 (Too Many Requests) is excluded because it is retryable.
+ * 412 (Precondition Failed) and 429 (Too Many Requests) are excluded because
+ * they are retryable.
  */
 function is4xxNonRetryable(code: number | undefined): boolean {
     if (code === undefined || typeof code !== 'number') return false;
-    return code >= 400 && code < 500 && code !== 429;
+    return code >= 400 && code < 500 && code !== 412 && code !== 429;
 }