@vertesia/ui 1.4.0 → 1.5.0-dev.20260713.151751Z

package/src/features/agent/chat/hooks/useFileProcessing.test.tsx

@@ -50,6 +50,76 @@ describe('useFileProcessing', () => {
         expect(result.current.processingFiles.has('file-1')).toBe(false);
     });
 
+    it('clears files on send without signaling FileRemoved and suppresses the server echo', async () => {
+        const client = createClient();
+        const toast = vi.fn();
+        const serverFileUpdates = new Map([['file-1', createReadyFile('file-1')]]);
+        const { result, rerender } = renderHook(
+            ({ updates }) => useFileProcessing(client, 'agent-run-1', updates, toast),
+            {
+                initialProps: { updates: serverFileUpdates },
+            },
+        );
+
+        expect(result.current.processingFiles.has('file-1')).toBe(true);
+
+        act(() => {
+            result.current.clearProcessingFiles();
+        });
+
+        // The agent already received the file via FileUploaded, so sending the message
+        // consumes it rather than retracting it — no FileRemoved signal.
+        expect(client.agents.sendSignal).not.toHaveBeenCalled();
+        expect(result.current.processingFiles.has('file-1')).toBe(false);
+
+        // A subsequent server echo for the same file must not re-add the chip.
+        rerender({ updates: new Map([['file-1', createReadyFile('file-1')]]) });
+        expect(result.current.processingFiles.has('file-1')).toBe(false);
+    });
+
+    it('preserves local artifact_path/reference when a server update omits them', async () => {
+        const client = createClient();
+        const toast = vi.fn();
+        const { result, rerender } = renderHook(
+            ({ updates }) => useFileProcessing(client, 'agent-run-1', updates, toast),
+            {
+                initialProps: { updates: new Map<string, ConversationFile>() },
+            },
+        );
+
+        const file = new File(['pdf'], 'report.pdf', { type: 'application/pdf' });
+        await act(async () => {
+            await result.current.handleFileUpload([file]);
+        });
+
+        const [fileId, local] = Array.from(result.current.processingFiles.entries())[0];
+        expect(local.artifact_path).toBe('files/report.pdf');
+        expect(local.reference).toBe('artifact:files/report.pdf');
+
+        // Server echoes READY but drops artifact_path/reference — the merge must backfill
+        // them from the local optimistic entry so the sent-message embed still resolves.
+        rerender({
+            updates: new Map<string, ConversationFile>([
+                [
+                    fileId,
+                    {
+                        id: fileId,
+                        name: 'report.pdf',
+                        content_type: 'application/pdf',
+                        size: 0,
+                        status: FileProcessingStatus.READY,
+                        started_at: 1_000,
+                    },
+                ],
+            ]),
+        });
+
+        const merged = result.current.processingFiles.get(fileId);
+        expect(merged?.status).toBe(FileProcessingStatus.READY);
+        expect(merged?.artifact_path).toBe('files/report.pdf');
+        expect(merged?.reference).toBe('artifact:files/report.pdf');
+    });
+
     it('does not signal an upload that was removed before upload completion', async () => {
         const client = createClient();
         const uploadArtifact = vi.mocked(client.agents.uploadArtifact);

package/src/features/agent/chat/hooks/useFileProcessing.ts

@@ -8,6 +8,7 @@ export interface UseFileProcessingResult {
     hasProcessingFiles: boolean;
     handleFileUpload: (files: File[]) => Promise<void>;
     removeProcessingFile: (fileId: string) => Promise<void>;
+    clearProcessingFiles: () => void;
 }
 
 type ToastFn = (opts: {
@@ -58,6 +59,12 @@ export function useFileProcessing(
     const removedFileIdsRef = useRef<Set<string>>(new Set());
     const previewUrlsRef = useRef<Map<string, string>>(new Map());
     const previousAgentRunId = useRef(agentRunId);
+    // Kept current so clearProcessingFiles() can read the latest tracked ids
+    // imperatively without being re-created on every render.
+    const localFilesRef = useRef(localFiles);
+    localFilesRef.current = localFiles;
+    const serverFileUpdatesRef = useRef(serverFileUpdates);
+    serverFileUpdatesRef.current = serverFileUpdates;
 
     const revokePreviewUrl = useCallback((fileId: string) => {
         const previewUrl = previewUrlsRef.current.get(fileId);
@@ -97,11 +104,17 @@ export function useFileProcessing(
         });
         serverFileUpdates.forEach((file, id) => {
             if (!removedFileIds.has(id)) {
-                const localPreviewUrl = (localFiles.get(id) as LocalConversationFile | undefined)?.preview_url;
-                merged.set(
-                    id,
-                    localPreviewUrl ? ({ ...file, preview_url: localPreviewUrl } as LocalConversationFile) : file,
-                );
+                // Server updates are authoritative for status, but may omit fields the local
+                // optimistic entry already knows: preview_url is never sent by the server, and
+                // artifact_path/reference can be absent on some updates. Backfill them from local
+                // so the sent-message embed and thumbnail resolution keep working.
+                const local = localFiles.get(id) as LocalConversationFile | undefined;
+                merged.set(id, {
+                    ...file,
+                    artifact_path: file.artifact_path ?? local?.artifact_path,
+                    reference: file.reference ?? local?.reference,
+                    ...(local?.preview_url ? { preview_url: local.preview_url } : {}),
+                } as LocalConversationFile);
             }
         });
         return merged;
@@ -224,5 +237,23 @@ export function useFileProcessing(
         [agentRunId, client, revokePreviewUrl, t, toast],
     );
 
-    return { processingFiles, hasProcessingFiles, handleFileUpload, removeProcessingFile };
+    // Clears the composer's uploaded-file chips after a message is sent. Unlike
+    // removeProcessingFile, this does NOT signal FileRemoved — the agent already
+    // received these files via FileUploaded, so the message consumes them rather
+    // than retracting them. The ids are added to removedFileIds so the server echo
+    // in the merge above cannot re-add a chip once the message has been sent.
+    const clearProcessingFiles = useCallback(() => {
+        previewUrlsRef.current.forEach(revokePreviewUrlValue);
+        previewUrlsRef.current.clear();
+        setRemovedFileIds((prev) => {
+            const next = new Set(prev);
+            for (const id of serverFileUpdatesRef.current.keys()) next.add(id);
+            for (const id of localFilesRef.current.keys()) next.add(id);
+            removedFileIdsRef.current = next;
+            return next;
+        });
+        setLocalFiles(new Map());
+    }, []);
+
+    return { processingFiles, hasProcessingFiles, handleFileUpload, removeProcessingFile, clearProcessingFiles };
 }

package/src/features/facets/AgentRunnerFacetsNav.tsx

@@ -161,8 +161,7 @@ export function AgentRunnerFacetsNav({
                         {actions && actions.length > 0 ? (
                             <div className="flex items-center gap-2 mb-1 me-2">
                                 {actions.map((action, index) => (
-                                    // biome-ignore lint/suspicious/noArrayIndexKey: list order is stable for this render
-                                    <div key={index}>{action}</div>
+                                    <div key={`action-${index}`}>{action}</div>
                                 ))}
                             </div>
                         ) : null}

package/src/features/facets/InteractionsFacetsNav.tsx

@@ -14,6 +14,15 @@ interface InteractionsFacetsNavProps {
     facets: ComputedFacetResponse;
     search: SearchInterface;
     env?: string | null;
+    /**
+     * Optional controlled filter state. When provided, the parent owns the filter list (and is
+     * responsible for translating it into the search query via {@link useInteractionsFilterHandler}).
+     * This lets other surfaces — e.g. per-row "quick filter" buttons in the table — add filters that
+     * show up in the filter bar. When omitted, the component manages its own filter state internally.
+     */
+    filters?: BaseFilter[];
+    setFilters?: React.Dispatch<React.SetStateAction<BaseFilter[]>>;
+    filterGroups?: FilterGroup[];
 }
 
 // Hook to create filter groups for interactions
@@ -84,14 +93,30 @@ export function useInteractionsFilterHandler(search: SearchInterface) {
 }
 
 // Component for interactions filtering
-export function InteractionsFacetsNav({ facets, search }: InteractionsFacetsNavProps) {
-    const [filters, setFilters] = useState<BaseFilter[]>([]);
-    const filterGroups = useInteractionsFilterGroups(facets);
+export function InteractionsFacetsNav({
+    facets,
+    search,
+    filters: controlledFilters,
+    setFilters: controlledSetFilters,
+    filterGroups: controlledFilterGroups,
+}: InteractionsFacetsNavProps) {
+    const [internalFilters, setInternalFilters] = useState<BaseFilter[]>([]);
+    const internalFilterGroups = useInteractionsFilterGroups(facets);
     const handleFilterLogic = useInteractionsFilterHandler(search);
 
+    // Controlled when the parent supplies both the filter list and its setter; otherwise self-managed.
+    const isControlled = controlledFilters !== undefined && controlledSetFilters !== undefined;
+    const filters = isControlled ? controlledFilters : internalFilters;
+    const filterGroups = controlledFilterGroups ?? internalFilterGroups;
+
     const handleFilterChange: React.Dispatch<React.SetStateAction<BaseFilter[]>> = (value) => {
-        const newFilters = typeof value === 'function' ? value(filters) : value;
-        setFilters(newFilters);
+        if (isControlled) {
+            // The parent's setter is expected to also run the filter→query translation.
+            controlledSetFilters(value);
+            return;
+        }
+        const newFilters = typeof value === 'function' ? value(internalFilters) : value;
+        setInternalFilters(newFilters);
         handleFilterLogic(newFilters);
     };
 

package/src/features/facets/PromptsFacetsNav.tsx

@@ -30,7 +30,6 @@ interface PromptsFacetsNavProps {
 
 // Hook to create filter groups for prompts
 export function usePromptsFilterGroups(facets: PromptsFacetsNavProps['facets']): FilterGroup[] {
-    void facets;
     const customFilterGroups: FilterGroup[] = [];
 
     // Add name filter as text type
@@ -57,6 +56,19 @@ export function usePromptsFilterGroups(facets: PromptsFacetsNavProps['facets']):
         customFilterGroups.push(rolesFilterGroup);
     }
 
+    // Add tags filter as stringList type (suggestions from facets, allows custom input)
+    const tagsFilterGroup = {
+        name: 'tags',
+        placeholder: 'Tags',
+        type: 'stringList' as const,
+        multiple: true,
+        options: (facets.tags ?? []).map((facet) => ({
+            label: facet._id,
+            value: facet._id,
+        })),
+    };
+    customFilterGroups.push(tagsFilterGroup);
+
     return customFilterGroups;
 }
 

package/src/features/facets/RunsFacetsNav.tsx

@@ -237,8 +237,7 @@ export function RunsFacetsNav({
                         {actions && actions.length > 0 ? (
                             <div className="flex items-center gap-2 mb-1 me-2">
                                 {actions.map((action, index) => (
-                                    // biome-ignore lint/suspicious/noArrayIndexKey: list order is stable for this render
-                                    <div key={index}>{action}</div>
+                                    <div key={`action-${index}`}>{action}</div>
                                 ))}
                             </div>
                         ) : null}

package/src/features/magic-pdf/AnnotatedImageSlider.tsx

@@ -290,8 +290,7 @@ export function AnnotatedImageSlider({ className, currentPage, onChange }: Annot
             <div ref={scrollContainerRef} className="flex flex-col items-center gap-2 flex-1 overflow-y-auto px-2">
                 {Array.from({ length: count }, (_, index) => (
                     <PageThumbnail
-                        // biome-ignore lint/suspicious/noArrayIndexKey: list order is stable for this render
-                        key={index}
+                        key={`page-thumb-${index}`}
                         currentPage={currentPage}
                         pageNumber={index + 1}
                         aspectRatio={aspectRatio}

package/src/features/magic-pdf/MagicPdfProvider.tsx

@@ -176,10 +176,10 @@ function extractMarkdownPages(content: string, totalPages: number): string[] {
 
         // Find the actual end by looking for the next delimiter or end of content
         const nextDelimiterMatch = content.slice(startIndex).match(/<!--\s*\{\s*"page"\s*:\s*\d+\s*\}\s*-->/);
-        const actualEndIndex = nextDelimiterMatch
-            ? // biome-ignore lint/style/noNonNullAssertion: intentional non-null assertion; TS can't prove narrowing here
-              startIndex + nextDelimiterMatch.index!
-            : content.length;
+        const actualEndIndex =
+            nextDelimiterMatch && nextDelimiterMatch.index !== undefined
+                ? startIndex + nextDelimiterMatch.index
+                : content.length;
 
         let pageContent = content.slice(startIndex, actualEndIndex).trim();
 

package/src/features/store/objects/DocumentSearchResults.tsx

@@ -58,10 +58,13 @@ interface DocumentSearchResultsWithDropZoneProps {
      * @returns
      */
     onUploadDone?: (objectIds: string[]) => Promise<void>;
+    /** Extra actions rendered in the results toolbar (e.g. selection actions). */
+    toolbarActions?: React.ReactNode;
 }
 export function DocumentSearchResultsWithDropZone({
     onUploadDone = async () => {},
     layout,
+    toolbarActions,
 }: DocumentSearchResultsWithDropZoneProps) {
     const search = useDocumentSearch();
     const toast = useToast();
@@ -111,7 +114,7 @@ export function DocumentSearchResultsWithDropZone({
         [search, uploadHandler],
     );
 
-    return <DocumentSearchResults layout={layout} onUpload={wrappedUploadHandler} />;
+    return <DocumentSearchResults layout={layout} onUpload={wrappedUploadHandler} toolbarActions={toolbarActions} />;
 }
 
 interface DocumentSearchResultsProps {
@@ -119,12 +122,15 @@ interface DocumentSearchResultsProps {
     allowFilter?: boolean;
     allowSearch?: boolean;
     onUpload?: (files: File[], type: string | null, collectionId?: string) => Promise<unknown>; // if defined, accept drag drop to upload
+    /** Extra actions rendered in the results toolbar (e.g. selection actions). */
+    toolbarActions?: React.ReactNode;
 }
 export function DocumentSearchResults({
     layout,
     onUpload,
     allowFilter = true,
     allowSearch = true,
+    toolbarActions,
 }: DocumentSearchResultsProps) {
     // Get the search context to access collectionId
     const { t } = useUITranslation();
@@ -346,6 +352,7 @@ export function DocumentSearchResults({
                 handleVectorSearch={handleVectorSearch}
                 handleRefetch={handleRefetch}
                 setIsGridView={setIsGridView}
+                toolbarActions={toolbarActions}
             />
             <div className="flex flex-col w-full flex-1 min-h-0 border rounded-md mb-2">
                 <div ref={scrollRef} className="flex-1 min-h-0 overflow-y-auto">
@@ -388,6 +395,7 @@ interface ToolsbarProps {
     handleVectorSearch: (query?: ComplexSearchQuery) => void;
     handleRefetch: () => void;
     setIsGridView: React.Dispatch<React.SetStateAction<boolean>>;
+    toolbarActions?: React.ReactNode;
 }
 function Toolsbar(props: ToolsbarProps) {
     const { t } = useUITranslation();
@@ -402,6 +410,7 @@ function Toolsbar(props: ToolsbarProps) {
         handleVectorSearch,
         handleRefetch,
         setIsGridView,
+        toolbarActions,
     } = props;
 
     return (
@@ -442,6 +451,7 @@ function Toolsbar(props: ToolsbarProps) {
                 </div>
             )}
             <div className="flex gap-1 items-center">
+                {toolbarActions}
                 <VTooltip description={t('store.refresh')} asChild size="xs" placement="top">
                     <Button variant="outline" onClick={handleRefetch} aria-label={t('store.refresh')}>
                         <RefreshCw size={16} />

package/src/features/store/objects/components/ContentOverview.tsx

@@ -831,8 +831,7 @@ function TranscriptPanel({
                 {segments && segments.length > 0 ? (
                     <div className="space-y-2">
                         {segments.map((segment, idx) => (
-                            // biome-ignore lint/suspicious/noArrayIndexKey: list order is stable for this render
-                            <div key={idx} className="flex gap-3 text-sm">
+                            <div key={`segment-${idx}`} className="flex gap-3 text-sm">
                                 <span className="text-muted font-mono text-xs shrink-0 pt-0.5">
                                     {formatTimestamp(segment.start)}
                                     {segment.end && ` - ${formatTimestamp(segment.end)}`}

package/src/features/store/objects/components/DocumentIcon.tsx

@@ -25,8 +25,7 @@ export function DocumentIconSkeleton({ isLoading = false, counts = 6 }: { isLoad
             {Array(counts)
                 .fill(0)
                 .map((_, index) => (
-                    // biome-ignore lint/suspicious/noArrayIndexKey: list order is stable for this render
-                    <div key={index} className="w-[15vw] animate-pulse">
+                    <div key={`skeleton-${index}`} className="w-[15vw] animate-pulse">
                         <Card className="relative flex flex-col border h-fit">
                             <div className="h-48 bg-muted rounded-t-xl flex items-center justify-center text-muted">
                                 &nbsp;

package/src/features/store/objects/components/DocumentInput.tsx

@@ -1,4 +1,4 @@
-import type { ContentObjectItem } from '@vertesia/common';
+import type { ContentObject, ContentObjectItem } from '@vertesia/common';
 import { Button, Styles, useFlag } from '@vertesia/ui/core';
 
 import { useUserSession } from '@vertesia/ui/session';
@@ -20,7 +20,7 @@ export function DocumentInput({ object }: DocumentInputProps) {
 
     const { off, on, isOn } = useFlag();
     const [actualValue, setValue] = useState(object.value != null ? String(object.value) : '');
-    const [doc, setDoc] = useState<ContentObjectItem | undefined>(undefined);
+    const [doc, setDoc] = useState<ContentObject | ContentObjectItem | undefined>(undefined);
 
     const _onChange = (event: ChangeEvent<HTMLInputElement>) => {
         const value = event.target.value;

package/src/features/store/objects/search/DocumentSearchContext.test.ts

@@ -1,5 +1,5 @@
 import type { ZenoClient } from '@vertesia/client';
-import type { ContentObjectItem } from '@vertesia/common';
+import type { ContentObjectItemApiResponse } from '@vertesia/common';
 import { describe, expect, it, vi } from 'vitest';
 import { DocumentSearch } from './DocumentSearchContext';
 
@@ -14,7 +14,7 @@ function createClient(searchImpl: () => Promise<unknown>): ZenoClient {
 describe('DocumentSearch', () => {
     it('settles loading state and preserves current objects when search fails', async () => {
         const error = new Error('search failed');
-        const currentObject = { id: 'object-1', name: 'Existing object' } as ContentObjectItem;
+        const currentObject = { id: 'object-1', name: 'Existing object' } as ContentObjectItemApiResponse;
         const search = new DocumentSearch(createClient(() => Promise.reject(error)));
         search.result.value = {
             objects: [currentObject],

package/src/features/store/objects/search/DocumentSearchContext.ts

@@ -4,7 +4,7 @@ import type {
     ComplexSearchQuery,
     ComputedFacetResponse,
     ComputeObjectFacetPayload,
-    ContentObjectItem,
+    ContentObjectItemApiResponse,
     FacetBucket,
     FacetSpec,
     ObjectSearchQuery,
@@ -14,7 +14,7 @@ import type { SearchInterface } from '@vertesia/ui/features';
 import { createContext, useContext } from 'react';
 
 interface DocumentSearchResult {
-    objects: ContentObjectItem[];
+    objects: ContentObjectItemApiResponse[];
     error?: Error;
     isLoading: boolean;
     hasMore?: boolean;
@@ -215,7 +215,7 @@ export class DocumentSearch implements SearchInterface {
 const DocumentSearchContext = createContext<DocumentSearch | undefined>(undefined);
 
 export function useDocumentSearch() {
-    // biome-ignore lint/style/noNonNullAssertion: intentional non-null assertion; TS can't prove narrowing here
+    // biome-ignore lint/style/noNonNullAssertion: intentionally tolerant — called outside its Provider by shared toolbars/action menus (e.g. on the object-detail page) where the context is undefined and callers handle it; throwing here crashes those pages (regressed in PR #6024)
     return useContext(DocumentSearchContext)!;
 }
 

package/src/features/store/objects/selection/ObjectsActionContext.tsx

@@ -1,6 +1,5 @@
 import type { ContentObjectTypeItem } from '@vertesia/common';
-import { ErrorBox, errorMessage, useFetch, useToast } from '@vertesia/ui/core';
-import { useUITranslation } from '@vertesia/ui/i18n';
+import { useToast } from '@vertesia/ui/core';
 import { useUserSession } from '@vertesia/ui/session';
 import { type ReactNode, useMemo } from 'react';
 
@@ -11,7 +10,6 @@ import { ChangeTypeAction } from './actions/ChangeTypeAction';
 import { DeleteObjectsAction, DeleteObjectsFromCollectionsAction } from './actions/DeleteObjectsAction';
 import { ExportPropertiesAction } from './actions/ExportPropertiesAction';
 import { RemoveFromCollectionAction } from './actions/RemoveFromCollectionAction';
-import { StartWorkflowAction, StartWorkflowComponent } from './actions/StartWorkflowComponent';
 import { ObjectsActionContext } from './ObjectsActionContextClass';
 import { ObjectsActionContextReact, useObjectsActionContext } from './ObjectsActionHooks';
 import type { ObjectsActionSpec } from './ObjectsActionSpec';
@@ -19,7 +17,6 @@ import type { ObjectsActionSpec } from './ObjectsActionSpec';
 const DEFAULT_ACTIONS: ObjectsActionSpec[] = [
     ExportPropertiesAction,
     ChangeTypeAction,
-    StartWorkflowAction,
     AddToCollectionAction,
     DeleteObjectsAction,
     RemoveFromCollectionAction,
@@ -31,27 +28,11 @@ interface ObjectsActionContextProps {
     type?: ContentObjectTypeItem;
 }
 export function ObjectsActionContextProvider({ children, type }: ObjectsActionContextProps) {
-    const { t } = useUITranslation();
     const selection = useDocumentSelection();
     const toast = useToast();
     const { client } = useUserSession();
     const search = useDocumentSearch();
 
-    const { data: rules, error } = useFetch<ObjectsActionSpec[]>(() => {
-        return client.workflows.rules.list().then((rules) => {
-            return rules
-                .map((rule) => ({
-                    id: rule.id,
-                    name: rule.name,
-                    description: rule.description,
-                    confirm: false,
-                    isWorkflow: true,
-                    component: StartWorkflowComponent,
-                }))
-                .sort((a, b) => a.name.localeCompare(b.name));
-        });
-    }, []);
-
     const context = useMemo(() => {
         const context = new ObjectsActionContext({
             selection,
@@ -61,14 +42,8 @@ export function ObjectsActionContextProvider({ children, type }: ObjectsActionCo
             type,
         });
         context.allActions = DEFAULT_ACTIONS;
-        // biome-ignore lint/style/noNonNullAssertion: intentional non-null assertion; TS can't prove narrowing here
-        context.wfRules = rules!;
         return context;
-    }, [client, search, selection, rules, toast, type]);
-
-    if (error) {
-        return <ErrorBox title={t('store.failedToFetchWorkflows')}>{errorMessage(error)}</ErrorBox>;
-    }
+    }, [client, search, selection, toast, type]);
 
     return (
         context && (

package/src/features/store/objects/selection/ObjectsActionContextClass.ts

@@ -4,9 +4,7 @@ export type ObjectsActionCallback = (params: ObjectsActionParams) => Promise<unk
 
 export class ObjectsActionContext {
     allActions: ObjectsActionSpec[] = [];
-    wfRules: ObjectsActionSpec[] = [];
     callbacks: Record<string, ObjectsActionCallback> = {};
-    startWorkflow?: ObjectsActionCallback;
 
     constructor(public params: Omit<ObjectsActionParams, 'action'>) {}
 
@@ -34,11 +32,7 @@ export class ObjectsActionContext {
     }
 
     findAction(actionId: string) {
-        let action = this.allActions.find((a) => a.id === actionId);
-        if (!action) {
-            action = this.wfRules.find((a) => a.id === actionId);
-        }
-        return action;
+        return this.allActions.find((a) => a.id === actionId);
     }
 
     async run(actionId: string): Promise<unknown> {

package/src/features/store/objects/selection/ObjectsActionHooks.ts

@@ -20,14 +20,3 @@ export function useObjectsActionCallback(name: string, cb: ObjectsActionCallback
     }, [ctx, name, cb]);
     return ctx;
 }
-
-export function useStartWorkflowCallback(cb: ObjectsActionCallback) {
-    const ctx = useObjectsActionContext();
-    useEffect(() => {
-        ctx.startWorkflow = cb;
-        return () => {
-            ctx.startWorkflow = undefined;
-        };
-    }, [cb, ctx]);
-    return ctx;
-}

package/src/features/store/objects/selection/SelectionActions.tsx

@@ -7,7 +7,7 @@ import { useState } from 'react';
 import { type DocumentSelection, useDocumentSelection } from '../DocumentSelectionProvider.js';
 import { DocumentUploadModal } from '../upload/DocumentUploadModal.js';
 import { ExportPropertiesAction } from './actions/ExportPropertiesAction';
-import { StartWorkflowAction } from './actions/StartWorkflowComponent';
+import { StartWorkflowButton } from './actions/StartWorkflowButton';
 import { ObjectsActionContextProvider } from './ObjectsActionContext';
 import { useObjectsActionContext } from './ObjectsActionHooks';
 import type { ObjectsActionSpec } from './ObjectsActionSpec';
@@ -16,13 +16,17 @@ interface SelectionActionsProps {
     type?: ContentObjectTypeItem;
     allowMutations?: boolean;
     allowDelete?: boolean;
+    /**
+     * Opt-in: shows the "Start Workflow" action. Defaults to `false` so it never leaks to read-only
+     * surfaces — callers must pass a permission-gated value (e.g. `canRunWorkflow(perms)`).
+     */
     allowWorkflowRun?: boolean;
 }
 export function SelectionActions({
     type,
     allowMutations = true,
     allowDelete = true,
-    allowWorkflowRun = true,
+    allowWorkflowRun = false,
 }: SelectionActionsProps) {
     const selection = useDocumentSelection();
     const size = selection.size();
@@ -48,11 +52,11 @@ export function SelectionActions({
                         </Button>
                     </div>
                 )}
+                {allowWorkflowRun && <StartWorkflowButton />}
                 <SelectionActionsPopover
                     selection={selection}
                     allowMutations={allowMutations}
                     allowDelete={allowDelete}
-                    allowWorkflowRun={allowWorkflowRun}
                 >
                     {(actions) =>
                         actions.length > 0 ? (
@@ -62,21 +66,11 @@ export function SelectionActions({
                         ) : null
                     }
                 </SelectionActionsPopover>
-                {/* StartWorkflowButton must be inside the context */}
-                {hasSelection && allowWorkflowRun && <ActionsWrapper selection={selection} />}
             </div>
         </ObjectsActionContextProvider>
     );
 }
 
-// Wrapper component that accesses the context
-interface ActionsWrapperProps {
-    selection: DocumentSelection;
-}
-function ActionsWrapper(_props: ActionsWrapperProps) {
-    return <StartWorkflowButton />;
-}
-
 export function UploadObjectsButton({
     collectionId,
     allowFolders = true,
@@ -113,19 +107,6 @@ export function UploadObjectsButton({
     );
 }
 
-function StartWorkflowButton() {
-    const ctx = useObjectsActionContext();
-    const { t } = useUITranslation();
-
-    const selection = ctx.params.selection;
-    const hasSelection = selection.hasSelection();
-
-    return (
-        hasSelection && (
-            <Button onClick={() => ctx.run(StartWorkflowAction.id)}>{t('store.actions.startWorkflow')}</Button>
-        )
-    );
-}
 function optionLayout(option: ObjectsActionSpec) {
     return {
         label: option.name,
@@ -142,9 +123,7 @@ function SelectionActionsPopover({
     children,
     allowMutations = true,
     allowDelete = true,
-    allowWorkflowRun = true,
-}: SelectionActionsPopoverProps &
-    Required<Pick<SelectionActionsProps, 'allowMutations' | 'allowDelete' | 'allowWorkflowRun'>>) {
+}: SelectionActionsPopoverProps & Required<Pick<SelectionActionsProps, 'allowMutations' | 'allowDelete'>>) {
     const context = useObjectsActionContext();
     const executeAction = (action: ObjectsActionSpec) => {
         context.run(action.id);
@@ -152,7 +131,6 @@ function SelectionActionsPopover({
     const actions = getAvailableActions(context.actions, selection, {
         allowMutations,
         allowDelete,
-        allowWorkflowRun,
     });
     const trigger = children(actions);
 
@@ -191,7 +169,7 @@ function PopoverBody({ executeAction, actions }: PopoverBodyProps) {
 function getAvailableActions(
     actions: ObjectsActionSpec[],
     selection: DocumentSelection,
-    permissions: Required<Pick<SelectionActionsProps, 'allowMutations' | 'allowDelete' | 'allowWorkflowRun'>>,
+    permissions: Required<Pick<SelectionActionsProps, 'allowMutations' | 'allowDelete'>>,
 ): ObjectsActionSpec[] {
     if (!selection?.hasSelection()) {
         return [ExportPropertiesAction];
@@ -201,9 +179,6 @@ function getAvailableActions(
         if (action.hideInList) {
             return false;
         }
-        if (action.id === 'startWorkflow') {
-            return permissions.allowWorkflowRun;
-        }
         if (action.id === 'delete' || action.id === 'deleteFromCollections') {
             return permissions.allowDelete;
         }