@vertesia/ui 1.0.0-dev.20260128.144200 → 1.0.0-dev.20260225.024852Z

package/src/features/store/objects/DocumentSearchResults.tsx

@@ -15,7 +15,7 @@ import { useEffect, useRef, useState } from "react";
 import { useDocumentFilterGroups, useDocumentFilterHandler } from "../../facets/DocumentsFacetsNav";
 import { ContentDispositionButton } from './components/ContentDispositionButton';
 import { ContentOverview } from './components/ContentOverview';
-import { useDownloadDocument } from './components/useDownloadObject';
+import { useDownloadFile } from './components/useDownloadFile';
 import { VectorSearchWidget } from './components/VectorSearchWidget';
 import { DocumentTable } from './DocumentTable';
 import { ExtendedColumnLayout } from './layout/DocumentTableColumn';
@@ -301,11 +301,11 @@ function Toolsbar(props: ToolsbarProps) {
         handleFilterChange,
         handleVectorSearch,
         handleRefetch,
-        setIsGridView
+        setIsGridView,
     } = props;
 
     return (
-        <div className="sticky top-0 z-10 bg-background py-2">
+        <div className="sticky top-0 z-10 bg-background py-2 flex justify-between items-center">
             {
                 allowFilter && (
                     <FilterProvider
@@ -320,10 +320,6 @@ function Toolsbar(props: ToolsbarProps) {
                                 }
                                 <FilterBtn />
                             </div>
-                            <div className="flex gap-1 items-center">
-                                <Button variant="outline" onClick={handleRefetch} alt="Refresh"><RefreshCw size={16} /></Button>
-                                <ContentDispositionButton onUpdate={setIsGridView} />
-                            </div>
                         </div>
                         <div className="flex gap-2 items-center pt-2">
                             <FilterBar />
@@ -340,13 +336,13 @@ function Toolsbar(props: ToolsbarProps) {
                                 allowSearch && <VectorSearchWidget onChange={handleVectorSearch} isLoading={isLoading} refresh={refreshTrigger} />
                             }
                         </div>
-                        <div className="flex gap-1 items-center">
-                            <Button variant="outline" onClick={handleRefetch} alt="Refresh"><RefreshCw size={16} /></Button>
-                            <ContentDispositionButton onUpdate={setIsGridView} />
-                        </div>
                     </div>
                 )
             }
+            <div className="flex gap-1 items-center">
+                <Button variant="outline" onClick={handleRefetch} alt="Refresh"><RefreshCw size={16} /></Button>
+                <ContentDispositionButton onUpdate={setIsGridView} />
+            </div>
         </div>
     );
 }
@@ -359,7 +355,7 @@ function OverviewDrawer({ object, onClose }: OverviewDrawerProps) {
     const { store } = useUserSession();
     const toast = useToast();
     const navigate = useNavigate();
-    const onDownload = useDownloadDocument(store, toast, object?.content?.source, object?.name || object?.content?.name);
+    const { downloadFromContentSource } = useDownloadFile({ client: store, toast });
 
     return object ? (
         <SidePanel title={object.properties?.title || object.name} isOpen={true} onClose={onClose}>
@@ -368,7 +364,7 @@ function OverviewDrawer({ object, onClose }: OverviewDrawerProps) {
                     <ExternalLink className="size-4" />
                 </Button>
                 {object.content?.source && (
-                    <Button variant="ghost" size="sm" title="Download" onClick={onDownload}>
+                    <Button variant="ghost" size="sm" title="Download" onClick={() => downloadFromContentSource(object.content!.source!, object.name || object.content?.name)}>
                         <Download className="size-4" />
                     </Button>
                 )}

package/src/features/store/objects/ExportPropertiesModal.tsx

@@ -14,14 +14,16 @@ export function ExportPropertiesModal({ isExporting, isOpen, onClose }: ExportPr
     const title = "Export Object Properties";
 
     return (
-        <Modal onClose={() => onClose(undefined)} isOpen={isOpen} className="relative overflow-visible">
+        <Modal onClose={() => onClose(undefined)} isOpen={isOpen}>
             <ModalTitle>{title}</ModalTitle>
-            {!isExporting &&
-                <SelectPanel onClose={onClose} />
-            }
-            {isExporting &&
-                <WaitingPanel />
-            }
+            <ModalBody>
+                {!isExporting &&
+                    <SelectPanel onClose={onClose} />
+                }
+                {isExporting &&
+                    <WaitingPanel />
+                }
+            </ModalBody>
         </Modal>
     )
 }

package/src/features/store/objects/components/ContentOverview.tsx

@@ -1,16 +1,17 @@
-import { useEffect, useState, memo, useRef, type RefObject } from "react";
+import { memo, useEffect, useRef, useState, type RefObject } from "react";
 
+import { AUDIO_RENDITION_NAME, AudioMetadata, ContentNature, ContentObject, ContentObjectStatus, DocAnalyzerProgress, DocProcessorOutputFormat, DocumentMetadata, ImageRenditionFormat, MarkdownRenditionFormat, PDF_RENDITION_NAME, POSTER_RENDITION_NAME, VideoMetadata, WorkflowExecutionStatus } from "@vertesia/common";
+import { Button, Portal, ResizableHandle, ResizablePanel, ResizablePanelGroup, Spinner, useToast } from "@vertesia/ui/core";
+import { NavLink } from "@vertesia/ui/router";
 import { useUserSession } from "@vertesia/ui/session";
-import { Button, Portal, ResizableHandle, ResizablePanel, ResizablePanelGroup, Spinner, useToast, VModal, VModalBody, VModalFooter, VModalTitle } from "@vertesia/ui/core";
 import { JSONDisplay, MarkdownRenderer, Progress, XMLViewer } from "@vertesia/ui/widgets";
-import { ContentNature, ContentObject, ContentObjectStatus, DocAnalyzerProgress, DocProcessorOutputFormat, DocumentMetadata, ImageRenditionFormat, VideoMetadata, AudioMetadata, POSTER_RENDITION_NAME, AUDIO_RENDITION_NAME, WorkflowExecutionStatus, PDF_RENDITION_NAME } from "@vertesia/common";
-import { Copy, Download, SquarePen, AlertTriangle, FileSearch } from "lucide-react";
-import { isPreviewableAsPdf, printElementToPdf, getWorkflowStatusColor, getWorkflowStatusName } from "../../../utils/index.js";
-import { PropertiesEditorModal } from "./PropertiesEditorModal";
-import { NavLink } from "@vertesia/ui/router";
+import { AlertTriangle, Copy, Download, FileSearch, SquarePen } from "lucide-react";
 import { MagicPdfView } from "../../../magic-pdf";
 import { SimplePdfViewer } from "../../../pdf-viewer";
-import { useObjectText, usePdfProcessingStatus, useOfficePdfConversion } from "./useContentPanelHooks.js";
+import { getWorkflowStatusColor, getWorkflowStatusName, isPreviewableAsPdf } from "../../../utils/index.js";
+import { PropertiesEditorModal } from "./PropertiesEditorModal";
+import { useObjectText, useOfficePdfConversion, usePdfProcessingStatus } from "./useContentPanelHooks.js";
+import { useDownloadFile } from "./useDownloadFile.js";
 
 // Web-supported image formats for browser display
 const WEB_SUPPORTED_IMAGE_FORMATS = ['image/jpeg', 'image/jpg', 'image/png', 'image/gif', 'image/webp', 'image/svg+xml'];
@@ -533,14 +534,11 @@ function TextActions({
     text,
     fullText,
     handleCopyContent,
-    textContainerRef,
 }: TextActionsProps) {
     const { client } = useUserSession();
     const toast = useToast();
-    const [loadingFormat, setLoadingFormat] = useState<"docx" | "pdf" | null>(null);
-    const [isPdfModalOpen, setIsPdfModalOpen] = useState(false);
-
     const content = object.content;
+    const { renderDocument, isDownloading } = useDownloadFile({ client, toast });
 
     const isMarkdown =
         content &&
@@ -550,137 +548,27 @@ function TextActions({
     // Get content processor type for file extension detection
     const contentProcessorType = getContentProcessorType(object);
 
-    const handleExportDocument = async (format: "docx" | "pdf") => {
+    const handleExportDocument = async (format: MarkdownRenditionFormat) => {
         // Prevent multiple concurrent exports
-        if (loadingFormat) return;
-
-        setLoadingFormat(format);
+        if (isDownloading) return;
 
         // Show immediate feedback
         toast({
             status: "info",
             title: `Preparing ${format.toUpperCase()}`,
-            description: "Fetching your document...",
+            description: "Rendering your document...",
             duration: 2000,
         });
 
-        try {
-            // Request document rendition from the server
-            const response = await client.objects.getRendition(object.id, {
-                format: format as any, // We're extending the format type
-                generate_if_missing: true,
-                sign_url: true,
-            });
-
-            if (response.status === "generating") {
-                toast({
-                    status: "info",
-                    title: "Generating document",
-                    description: `Please wait while we prepare your ${format.toUpperCase()} file...`,
-                    duration: 5000,
-                });
-
-                // Poll for completion
-                setTimeout(() => handleExportDocument(format), 3000);
-                return;
-            }
-
-            if (response.status === "failed") {
-                throw new Error("Document generation failed");
-            }
-
-            // Download the generated file or open in new window
-            if (response.renditions && response.renditions.length > 0) {
-                const downloadUrl = response.renditions[0];
-
-                if (format === 'pdf') {
-                    // Open PDF in new window
-                    window.open(downloadUrl, '_blank');
-                    toast({
-                        status: "success",
-                        title: "PDF opened",
-                        description: "PDF document opened in a new window",
-                        duration: 2000,
-                    });
-                } else {
-                    // Download DOCX file
-                    const link = document.createElement("a");
-                    link.href = downloadUrl;
-                    link.download = `${object.name || "document"}.${format}`;
-                    document.body.appendChild(link);
-                    link.click();
-                    document.body.removeChild(link);
-
-                    toast({
-                        status: "success",
-                        title: "Document exported",
-                        description: `Successfully exported to ${format.toUpperCase()} format`,
-                        duration: 2000,
-                    });
-                }
-            }
-        } catch (err) {
-            console.error(`Failed to export document as ${format}:`, err);
-            toast({
-                status: "error",
-                title: "Export failed",
-                description: `Failed to export document to ${format.toUpperCase()} format`,
-                duration: 5000,
-            });
-        } finally {
-            setLoadingFormat(null);
-        }
-    };
-
-    const handleExportDocx = () => handleExportDocument("docx");
-
-    const handleClientPdfExport = () => {
-        if (!textContainerRef.current) {
-            toast({
-                status: "error",
-                title: "PDF export failed",
-                description: "No content available to export",
-                duration: 3000,
-            });
-            return;
-        }
-        setIsPdfModalOpen(true);
-    };
-
-    const handleConfirmClientPdfExport = () => {
-        if (!textContainerRef.current) {
-            toast({
-                status: "error",
-                title: "PDF export failed",
-                description: "No content available to export",
-                duration: 3000,
-            });
-            return;
-        }
-
-        const baseName = object.name || object.id;
-        const pdfTitle = `${baseName || "document"} - content`;
-        const success = printElementToPdf(textContainerRef.current, pdfTitle);
-
-        if (!success) {
-            toast({
-                status: "error",
-                title: "PDF export failed",
-                description: "Unable to open print preview",
-                duration: 4000,
-            });
-            return;
-        }
-
-        toast({
-            status: "success",
-            title: "PDF export ready",
-            description: "Use your browser's Print dialog to save as PDF",
-            duration: 4000,
+        await renderDocument(object.id, {
+            format,
+            title: object.name || "document",
         });
-        setIsPdfModalOpen(false);
     };
 
+    const handleExportDocx = () => handleExportDocument(MarkdownRenditionFormat.docx);
+    const handleExportPdf = () => handleExportDocument(MarkdownRenditionFormat.pdf);
+
     const handleDownloadText = (e: React.MouseEvent) => {
         e.preventDefault();
         e.stopPropagation();
@@ -731,10 +619,10 @@ function TextActions({
                                 variant="ghost"
                                 size="sm"
                                 onClick={handleExportDocx}
-                                disabled={loadingFormat !== null}
+                                disabled={isDownloading}
                                 className="flex items-center gap-2"
                             >
-                                {loadingFormat === "docx" ? (
+                                {isDownloading ? (
                                     <Spinner size="sm" />
                                 ) : (
                                     <Download className="size-4" />
@@ -744,35 +632,21 @@ function TextActions({
                             <Button
                                 variant="ghost"
                                 size="sm"
-                                onClick={handleClientPdfExport}
+                                onClick={handleExportPdf}
+                                disabled={isDownloading}
                                 className="flex items-center gap-2"
                             >
-                                <Download className="size-4" />
+                                {isDownloading ? (
+                                    <Spinner size="sm" />
+                                ) : (
+                                    <Download className="size-4" />
+                                )}
                                 PDF
                             </Button>
                         </>
                     )}
                 </div>
             </div>
-            <VModal isOpen={isPdfModalOpen} onClose={() => setIsPdfModalOpen(false)}>
-                <VModalTitle>Export document as PDF</VModalTitle>
-                <VModalBody>
-                    <p className="mb-2">
-                        This will open your browser&apos;s print dialog with the current document content.
-                    </p>
-                    <p className="text-sm text-muted">
-                        To save a PDF, choose &quot;Save as PDF&quot; or a similar option in the print dialog.
-                    </p>
-                </VModalBody>
-                <VModalFooter align="right">
-                    <Button variant="ghost" size="sm" onClick={() => setIsPdfModalOpen(false)}>
-                        Cancel
-                    </Button>
-                    <Button size="sm" onClick={handleConfirmClientPdfExport}>
-                        Open print dialog
-                    </Button>
-                </VModalFooter>
-            </VModal>
         </>
     );
 }
@@ -911,7 +785,7 @@ function VideoPanel({ object }: { object: ContentObject }) {
 
     // Find mp4 or webm rendition by mime type, preferring mp4
     const webRendition = renditions.find(r => r.content.type === 'video/mp4') ||
-                         renditions.find(r => r.content.type === 'video/webm');
+        renditions.find(r => r.content.type === 'video/webm');
 
     // Check if original file is web-compatible
     const isOriginalWebSupported = content?.type && WEB_SUPPORTED_VIDEO_FORMATS.includes(content.type);

package/src/features/store/objects/components/PropertiesEditorModal.tsx

@@ -213,7 +213,6 @@ export function PropertiesEditorModal({ isOpen, onClose, object, refetch }: Prop
                             onChange={(update) => handleEditorChange(update.state.doc.toString())}
                             beforeMount={beforeMount}
                             theme={theme === 'dark' ? 'vs-dark' : 'vs'}
-                            minLines={40}
                         />
                     </div>
                 </ModalBody>

package/src/features/store/objects/components/SelectDocumentModal.tsx

@@ -1,5 +1,5 @@
 import { ContentObjectItem } from "@vertesia/common";
-import { VModal, VModalBody, VModalTitle } from "@vertesia/ui/core";
+import { Modal, ModalBody, ModalTitle } from "@vertesia/ui/core";
 import { SelectDocument } from "./SelectDocument";
 
 interface SelectDocumentModalProps {
@@ -10,11 +10,11 @@ interface SelectDocumentModalProps {
 }
 export function SelectDocumentModal({ isOpen, onClose }: SelectDocumentModalProps) {
     return (
-        <VModal onClose={() => onClose()} isOpen={!!isOpen} className='min-w-[60vw]'>
-            <VModalTitle>Select Content</VModalTitle>
-            <VModalBody className='pt-0 overflow-y-auto max-h-[80vh] min-h-[80vh]'>
+        <Modal onClose={() => onClose()} isOpen={!!isOpen} className='min-w-[60vw]'>
+            <ModalTitle>Select Content</ModalTitle>
+            <ModalBody className='pt-0 overflow-y-auto max-h-[80vh] min-h-[80vh]'>
                 {isOpen && <SelectDocument onChange={onClose} />}
-            </VModalBody>
-        </VModal>
+            </ModalBody>
+        </Modal>
     )
 }

package/src/features/store/objects/components/VectorSearchWidget.tsx

@@ -103,8 +103,8 @@ export function VectorSearchWidget({ onChange, isLoading, refresh, searchTypes }
     };
 
     return (
-        <div className="flex gap-1 items-center w-1/2">
-            <Input placeholder="Type what you are looking for, or select a filter" value={searchText} onChange={setSearchText} onKeyDown={handleKeyPress} />
+        <div className="flex gap-1 items-center">
+            <Input placeholder="Type what you are looking for, or select a filter" value={searchText} onChange={setSearchText} onKeyDown={handleKeyPress} className='min-w-[200px]' />
             <Button variant="ghost" onClick={() => setShowSettings(true)} alt="Semantic search settings" className="ml-1"><Settings size={18} /></Button>
             <Modal isOpen={showSettings} onClose={() => setShowSettings(false)}>
                 <ModalTitle>Search Types</ModalTitle>

package/src/features/store/objects/components/index.ts

@@ -4,6 +4,6 @@ export * from "./DocumentIcon"
 export * from "./DocumentInput"
 export * from "./SelectDocument"
 export * from "./SelectDocumentModal"
-export * from "./useDownloadObject"
+export * from "./useDownloadFile"
 export * from "./PropertiesEditorModal"
 export * from "./SaveVersionConfirmModal"

package/src/features/store/objects/components/useDownloadFile.ts

@@ -0,0 +1,237 @@
+import { VertesiaClient, ZenoClient } from "@vertesia/client";
+import { MarkdownRenditionFormat, RenderMarkdownPayload } from "@vertesia/common";
+import { useCallback, useState } from "react";
+import { ToastFn } from "@vertesia/ui/core";
+
+export interface UseDownloadFileOptions {
+    client: VertesiaClient | ZenoClient;
+    toast: ToastFn;
+}
+
+export interface RenderAndDownloadOptions {
+    /** Format to render to */
+    format: MarkdownRenditionFormat;
+    /** Title for the document */
+    title?: string;
+    /** Artifact run ID for resolving artifact URLs in content */
+    artifactRunId?: string;
+    /** Additional Pandoc options */
+    pandocOptions?: string[];
+}
+
+export interface UseDownloadFileResult {
+    /** Download a file from a content source URI (gs:// or file path) via the files API */
+    downloadFromContentSource: (uri: string, filename?: string) => Promise<void>;
+    /** Download a file from a direct URL (already signed or public) */
+    downloadFromUrl: (url: string, filename?: string) => void;
+    /** Render a document by objectId to PDF/DOCX and download the result */
+    renderDocument: (objectId: string, options: RenderAndDownloadOptions) => Promise<void>;
+    /** Render markdown content to PDF/DOCX and download the result */
+    renderContent: (content: string, options: RenderAndDownloadOptions) => Promise<void>;
+    /** Whether a download is currently in progress */
+    isDownloading: boolean;
+}
+
+/**
+ * Hook for downloading files from various sources.
+ * Handles GCS URIs (via client.files API), direct URLs, and markdown rendering.
+ */
+export function useDownloadFile({ client, toast }: UseDownloadFileOptions): UseDownloadFileResult {
+    const [isDownloading, setIsDownloading] = useState(false);
+
+    /**
+     * Download a file from a content source URI using the files API to get a signed URL.
+     */
+    const downloadFromContentSource = useCallback(async (uri: string, filename?: string) => {
+        if (!uri) return;
+
+        setIsDownloading(true);
+        try {
+            const result = await client.files.getDownloadUrlWithOptions({
+                file: uri,
+                name: filename
+            });
+
+            // Trigger download
+            triggerDownload(result.url, filename);
+        } catch (err) {
+            toast({
+                status: "error",
+                title: "Download failed",
+                description: err instanceof Error ? err.message : "Failed to get download URL",
+                duration: 5000,
+            });
+        } finally {
+            setIsDownloading(false);
+        }
+    }, [client, toast]);
+
+    /**
+     * Download a file from a direct URL (already signed or public).
+     */
+    const downloadFromUrl = useCallback((url: string, filename?: string) => {
+        if (!url) return;
+        triggerDownload(url, filename);
+    }, []);
+
+    /**
+     * Internal helper to handle the render result and trigger download.
+     */
+    const handleRenderResult = useCallback(async (
+        payload: RenderMarkdownPayload,
+        filename: string
+    ) => {
+        // Get the store client (ZenoClient has rendering, VertesiaClient has store.rendering)
+        const storeClient = 'store' in client ? client.store : client;
+
+        const rendition = await storeClient.rendering.render(payload);
+
+        // Use download_url if available (direct signed URL), otherwise fall back to file_uri
+        if (rendition.download_url) {
+            triggerDownload(rendition.download_url, filename);
+        } else if (rendition.file_uri) {
+            const result = await client.files.getDownloadUrlWithOptions({
+                file: rendition.file_uri,
+                name: filename
+            });
+            triggerDownload(result.url, filename);
+        } else {
+            throw new Error("No download URL or file URI in response");
+        }
+    }, [client]);
+
+    /**
+     * Render a document by objectId and download the result.
+     */
+    const renderDocument = useCallback(async (
+        objectId: string,
+        options: RenderAndDownloadOptions
+    ) => {
+        setIsDownloading(true);
+        try {
+            const filename = `${options.title || "document"}.${options.format}`;
+
+            await handleRenderResult({
+                object_id: objectId,
+                format: options.format,
+                title: options.title,
+                pandoc_options: options.pandocOptions,
+            }, filename);
+
+            toast({
+                status: "success",
+                title: "Document exported",
+                description: `Successfully exported to ${options.format.toUpperCase()}`,
+                duration: 2000,
+            });
+        } catch (err) {
+            toast({
+                status: "error",
+                title: "Export failed",
+                description: err instanceof Error ? err.message : "Failed to export document",
+                duration: 5000,
+            });
+        } finally {
+            setIsDownloading(false);
+        }
+    }, [handleRenderResult, toast]);
+
+    /**
+     * Render markdown content and download the result.
+     */
+    const renderContent = useCallback(async (
+        content: string,
+        options: RenderAndDownloadOptions
+    ) => {
+        setIsDownloading(true);
+        try {
+            const filename = `${options.title || "export"}.${options.format}`;
+
+            await handleRenderResult({
+                content,
+                format: options.format,
+                title: options.title,
+                artifact_run_id: options.artifactRunId,
+                pandoc_options: options.pandocOptions,
+            }, filename);
+
+            toast({
+                status: "success",
+                title: "Content exported",
+                description: `Successfully exported to ${options.format.toUpperCase()}`,
+                duration: 2000,
+            });
+        } catch (err) {
+            toast({
+                status: "error",
+                title: "Export failed",
+                description: err instanceof Error ? err.message : "Failed to export content",
+                duration: 5000,
+            });
+        } finally {
+            setIsDownloading(false);
+        }
+    }, [handleRenderResult, toast]);
+
+    return {
+        downloadFromContentSource,
+        downloadFromUrl,
+        renderDocument,
+        renderContent,
+        isDownloading,
+    };
+}
+
+/**
+ * Trigger a file download in the browser.
+ * Attempts to fetch and create a blob for proper filename control.
+ * Falls back to direct link if CORS blocks the fetch.
+ */
+function triggerDownload(url: string, filename?: string): void {
+    // Try to fetch and create blob for proper filename control
+    fetch(url)
+        .then(response => {
+            if (!response.ok) throw new Error(`HTTP ${response.status}`);
+            return response.blob();
+        })
+        .then(blob => {
+            const blobUrl = URL.createObjectURL(blob);
+            const a = document.createElement("a");
+            a.href = blobUrl;
+            a.download = filename || getFilenameFromUrl(url);
+            a.style.display = "none";
+            document.body.appendChild(a);
+            a.click();
+            setTimeout(() => {
+                document.body.removeChild(a);
+                URL.revokeObjectURL(blobUrl);
+            }, 100);
+        })
+        .catch(() => {
+            // CORS or fetch failed - fall back to direct link download
+            const a = document.createElement("a");
+            a.href = url;
+            a.download = filename || getFilenameFromUrl(url);
+            a.target = "_blank";
+            a.rel = "noopener noreferrer";
+            a.style.display = "none";
+            document.body.appendChild(a);
+            a.click();
+            setTimeout(() => {
+                document.body.removeChild(a);
+            }, 100);
+        });
+}
+
+/**
+ * Extract filename from URL path.
+ */
+function getFilenameFromUrl(url: string): string {
+    try {
+        const pathname = new URL(url).pathname;
+        const segments = pathname.split("/");
+        return segments[segments.length - 1] || "download";
+    } catch {
+        return "download";
+    }
+}

package/src/features/store/objects/search/DocumentSearchContext.ts

@@ -61,7 +61,7 @@ export class DocumentSearch implements SearchInterface {
 
     clearFilters(autoSearch: boolean = true) {
         // Preserve search-related fields when clearing filters
-        const { parent, full_text, vector, weights, score_aggregation, dynamic_scaling, limit, all_revisions } = this.query;
+        const { parent, full_text, vector, weights, score_aggregation, dynamic_scaling, limit } = this.query;
         this.query = {
             parent,
             ...(full_text !== undefined && { full_text }),
@@ -69,7 +69,6 @@ export class DocumentSearch implements SearchInterface {
             ...(weights !== undefined && { weights }),
             ...(score_aggregation !== undefined && { score_aggregation }),
             ...(dynamic_scaling !== undefined && { dynamic_scaling }),
-            ...(all_revisions !== undefined && { all_revisions }),
             ...(limit !== undefined && { limit })
         };