@vertesia/common 1.5.0-dev.20260807.073259Z → 1.5.0-dev.20260901.005903Z

package/src/store/process-validation.test.ts

@@ -1,635 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { PROCESS_DEFINITION_FORMAT_VERSION, type ProcessDefinitionBody } from './process.js';
-import {
-    getProcessDefinitionValidationResult,
-    getProcessInteractionValidationSelectors,
-    MAX_PROCESS_GUARD_DEPTH,
-    MAX_PROCESS_GUARD_NODES,
-    validateProcessDefinitionBody,
-} from './process-validation.js';
-
-function validDefinition(): ProcessDefinitionBody {
-    return {
-        format_version: PROCESS_DEFINITION_FORMAT_VERSION,
-        process: 'approval',
-        initial: 'review',
-        metadata: {
-            provenance: {
-                bpmn: {
-                    process_id: 'ApprovalProcess',
-                },
-            },
-        },
-        context: {
-            schema: {
-                type: 'object',
-                properties: {
-                    approved: { type: 'boolean' },
-                },
-                required: ['approved'],
-                additionalProperties: false,
-            },
-            initial: { approved: false },
-        },
-        nodes: {
-            review: {
-                type: 'human_task',
-                task: {
-                    title: 'Review',
-                    fields: [{ name: 'approved', type: 'boolean', required: true }],
-                },
-                transitions: [{ to: 'approved', trigger: 'user', metadata: { edge_kind: 'default' } }],
-            },
-            approved: {
-                type: 'final',
-            },
-        },
-    };
-}
-
-describe('process definition validation', () => {
-    it('accepts a structurally valid definition', () => {
-        expect(() => validateProcessDefinitionBody(validDefinition())).not.toThrow();
-    });
-
-    it('accepts inline script sources and script fanout children', () => {
-        const definition = validDefinition();
-        definition.resources = {
-            scripts: {
-                score_contract: {
-                    language: 'python',
-                    entrypoint: 'main.py',
-                    source: {
-                        type: 'inline',
-                        files: {
-                            'main.py': 'print("ok")',
-                            'lib/helpers.py': 'def score(value): return value',
-                        },
-                    },
-                    packages: ['pandas>=2.0'],
-                },
-                normalize_json: {
-                    language: 'javascript',
-                    entrypoint: 'main.js',
-                    source: {
-                        type: 'inline',
-                        files: { 'main.js': 'console.log("ok")' },
-                    },
-                    packages: ['zod@4.0.0'],
-                },
-                reshape_types: {
-                    language: 'typescript',
-                    entrypoint: 'main.ts',
-                    source: {
-                        type: 'inline',
-                        files: { 'main.ts': 'console.log("ok")' },
-                    },
-                    packages: ['@types/node', '@vertesia/client@latest'],
-                },
-            },
-        };
-        definition.initial = 'score';
-        definition.nodes.score = {
-            type: 'script',
-            script: 'score_contract',
-            timeout: 60,
-            writes: ['approved'],
-            transitions: [{ to: 'approved' }],
-        };
-        definition.nodes.fanout = {
-            type: 'foreach',
-            foreach: 'items',
-            node: {
-                type: 'script',
-                script: 'score_contract',
-            },
-            transitions: [{ to: 'approved' }],
-        };
-        definition.nodes.parallel = {
-            type: 'branch',
-            branches: [
-                {
-                    id: 'normalize',
-                    node: {
-                        type: 'script',
-                        script: 'normalize_json',
-                    },
-                },
-            ],
-            transitions: [{ to: 'approved' }],
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).not.toThrow();
-    });
-
-    it('rejects invalid script resources and references', () => {
-        const definition = validDefinition();
-        definition.resources = {
-            scripts: {
-                'bad resource': {
-                    language: 'python',
-                    entrypoint: 'missing.py',
-                    source: {
-                        type: 'inline',
-                        files: {
-                            '../escape.py': 'print("no")',
-                        },
-                    },
-                    packages: ['--index-url=evil', 'zod@latest`whoami`'],
-                },
-            },
-        };
-        definition.nodes.review = {
-            type: 'script',
-            script: 'missing',
-            timeout: 601,
-            transitions: [{ to: 'approved' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.errors).toContain('script resource "bad resource" has an invalid name');
-        expect(result.errors).toContain('script resource "bad resource" has unsafe file path "../escape.py"');
-        expect(result.errors).toContain(
-            'script resource "bad resource" entrypoint "missing.py" is not present in files',
-        );
-        expect(result.errors).toContain(
-            'script resource "bad resource" has unsafe package specification "--index-url=evil"',
-        );
-        expect(result.errors).toContain(
-            'script resource "bad resource" has unsafe package specification "zod@latest`whoami`"',
-        );
-        expect(result.errors).toContain('script node "review" references unknown script resource "missing"');
-        expect(result.errors).toContain('script node "review" timeout must be an integer between 1 and 600');
-    });
-
-    it('rejects script-only fields on other node types', () => {
-        const definition = validDefinition();
-        Object.assign(definition.nodes.review, { script: 'score', timeout: 30 });
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.errors).toContain('node "review" defines script but has type "human_task"');
-        expect(result.errors).toContain('node "review" defines timeout but has type "human_task"');
-    });
-
-    it('counts inline script sources against the process definition size cap', () => {
-        const definition = validDefinition();
-        definition.resources = {
-            scripts: {
-                oversized: {
-                    language: 'typescript',
-                    entrypoint: 'main.ts',
-                    source: {
-                        type: 'inline',
-                        files: { 'main.ts': 'x'.repeat(1024 * 1024) },
-                    },
-                },
-            },
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'process definition, including embedded resources, exceeds',
-        );
-    });
-
-    it('rejects missing transition targets', () => {
-        const definition = validDefinition();
-        definition.nodes.review.transitions = [{ to: 'missing' }];
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'node "review" has transition to "missing" which does not exist',
-        );
-    });
-
-    it('rejects missing branch targets', () => {
-        const definition = validDefinition();
-        definition.nodes.review.type = 'condition';
-        definition.nodes.review.task = undefined;
-        definition.nodes.review.transitions = undefined;
-        definition.nodes.review.branches = [{ to: 'missing', default: true }];
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'node "review" has branch to "missing" which does not exist',
-        );
-    });
-
-    it('rejects unsupported foreach child node types', () => {
-        const definition = validDefinition();
-        definition.initial = 'fanout';
-        definition.context.schema = {
-            type: 'object',
-            properties: {
-                items: { type: 'array', items: { type: 'string' } },
-            },
-            additionalProperties: true,
-        };
-        definition.context.initial = { items: [] };
-        definition.nodes = {
-            fanout: {
-                type: 'foreach',
-                foreach: 'items',
-                node: {
-                    type: 'human_task',
-                    task: {
-                        title: 'Review',
-                        fields: [],
-                    },
-                },
-                transitions: [{ to: 'approved' }],
-            },
-            approved: {
-                type: 'final',
-            },
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'foreach node "fanout" has unsupported child node type "human_task"',
-        );
-    });
-
-    it('accepts process nodes as standalone nodes and foreach children', () => {
-        const child = validDefinition();
-        child.process = 'child_approval';
-
-        const definition = validDefinition();
-        definition.initial = 'fanout';
-        definition.context.schema = {
-            type: 'object',
-            properties: {
-                items: { type: 'array', items: { type: 'object' } },
-                results: { type: 'array' },
-            },
-            additionalProperties: true,
-        };
-        definition.context.initial = { items: [] };
-        definition.nodes = {
-            fanout: {
-                type: 'foreach',
-                foreach: 'items',
-                as: 'item',
-                item_id: '{{item.id}}',
-                max_concurrency: 10,
-                collect: {
-                    into: 'results',
-                    include: ['status', 'index', 'item_id', 'output', 'child_run_id'],
-                },
-                node: {
-                    type: 'process',
-                    process_definition: child,
-                    input: { invoice: '{{item}}' },
-                    returns: { from: 'context.approved' },
-                },
-                transitions: [{ to: 'approved' }],
-            },
-            approved: {
-                type: 'final',
-            },
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).not.toThrow();
-    });
-
-    it('rejects fanout child nodes that define their own transitions', () => {
-        const child = validDefinition();
-        child.process = 'child_approval';
-
-        const definition = validDefinition();
-        definition.initial = 'fanout';
-        definition.context.schema = {
-            type: 'object',
-            properties: {
-                items: { type: 'array', items: { type: 'object' } },
-            },
-            additionalProperties: true,
-        };
-        definition.context.initial = { items: [] };
-        definition.nodes = {
-            fanout: {
-                type: 'foreach',
-                foreach: 'items',
-                node: {
-                    type: 'process',
-                    process_definition: child,
-                    transitions: [{ to: 'approved' }],
-                },
-                transitions: [{ to: 'approved' }],
-            },
-            approved: {
-                type: 'final',
-            },
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'foreach node "fanout" child node must not define transitions',
-        );
-    });
-
-    it('rejects process nodes without a referenced or inline process', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'process',
-            transitions: [{ to: 'approved' }],
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow(
-            'process node "review" is missing process or process_definition',
-        );
-    });
-
-    it('rejects set_context nodes that omit the updates envelope', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'tool',
-            tool: 'set_context',
-            input: {
-                approved: true,
-            },
-            writes: ['approved'],
-            transitions: [{ to: 'approved' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain('tool node "review" set_context input has unsupported property "approved"');
-        expect(result.errors).toContain('tool node "review" set_context input.updates must be an object');
-    });
-
-    it('accepts set_context nodes with the updates envelope', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'tool',
-            tool: 'set_context',
-            input: {
-                updates: {
-                    approved: true,
-                },
-                reason: 'mark approved in validation test',
-            },
-            writes: ['approved'],
-            transitions: [{ to: 'approved' }],
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).not.toThrow();
-    });
-
-    it('rejects set_context nodes that write undeclared or internal fields', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'tool',
-            tool: 'set_context',
-            input: {
-                updates: {
-                    approved: true,
-                    _current_node: 'approved',
-                },
-            },
-            writes: ['decision'],
-            transitions: [{ to: 'approved' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'tool node "review" set_context updates "approved" but writes does not allow it',
-        );
-        expect(result.errors).toContain(
-            'tool node "review" set_context cannot write reserved context field "_current_node"',
-        );
-    });
-
-    it('rejects unknown tools when a runtime tool catalog is provided', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'tool',
-            tool: 'missing_tool',
-            input: {},
-            transitions: [{ to: 'approved' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition, { knownTools: ['set_context'] });
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain('tool node "review" references unknown tool "missing_tool"');
-    });
-
-    it('rejects unknown interactions when a runtime interaction catalog is provided', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'interaction',
-            interaction: 'sys:MissingInteraction',
-            writes: ['approved'],
-            transitions: [{ to: 'approved' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition, { knownInteractions: ['sys:GeneralAgent'] });
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'interaction node "review" references unknown interaction "sys:MissingInteraction"',
-        );
-    });
-
-    it('rejects non-object result_schema on agent and interaction nodes', () => {
-        const definition = validDefinition();
-        definition.nodes.review = {
-            type: 'agent',
-            interaction: 'sys:GeneralAgent',
-            writes: ['approved'],
-            transitions: [{ to: 'approved' }],
-        };
-        Object.assign(definition.nodes.review, { result_schema: 'not a schema' });
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain('agent node "review" result_schema must be a JSON Schema object');
-    });
-
-    it('builds interaction selectors used by process validation', () => {
-        const selectors = getProcessInteractionValidationSelectors([
-            { type: 'sys', id: 'sys:GeneralAgent', name: 'GeneralAgent', title: 'General agent', tags: [] },
-            {
-                type: 'stored',
-                id: '65f000000000000000000001',
-                name: 'contract-risk',
-                version: 3,
-                title: 'Contract risk',
-                tags: [],
-            },
-            { type: 'app', id: 'claims/score', name: 'score_claim', title: 'Score claim', tags: [] },
-        ]);
-
-        expect(selectors).toContain('sys:GeneralAgent');
-        expect(selectors).toContain('GeneralAgent');
-        expect(selectors).toContain('contract-risk@draft');
-        expect(selectors).toContain('65f000000000000000000001@3');
-        expect(selectors).toContain('app:claims/score');
-    });
-
-    it('rejects string branch conditions so broken definitions do not save', () => {
-        const definition = validDefinition();
-        const branchWithStringCondition = {
-            to: 'approved',
-            condition: 'context.approved == true',
-        };
-        definition.nodes.review.type = 'condition';
-        definition.nodes.review.task = undefined;
-        definition.nodes.review.transitions = undefined;
-        definition.nodes.review.branches = [branchWithStringCondition];
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'node "review" branch at index 0 uses string condition; use JSON Logic in "when" instead',
-        );
-    });
-
-    it('rejects invalid foreach fanout controls', () => {
-        const definition = validDefinition();
-        definition.initial = 'fanout';
-        definition.context.schema = {
-            type: 'object',
-            properties: {
-                items: { type: 'array' },
-            },
-            additionalProperties: true,
-        };
-        definition.context.initial = { items: [] };
-        definition.nodes = {
-            fanout: {
-                type: 'foreach',
-                foreach: 'items',
-                max_concurrency: 0,
-                collect: {
-                    into: '',
-                    include: ['status'],
-                },
-                node: {
-                    type: 'process',
-                    process: '64f000000000000000000000',
-                },
-                transitions: [{ to: 'approved' }],
-            },
-            approved: {
-                type: 'final',
-            },
-        };
-        Object.assign(definition.nodes.fanout.collect ?? {}, { include: ['bogus'] });
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain('foreach node "fanout" max_concurrency must be a positive integer');
-        expect(result.errors).toContain('foreach node "fanout" collect.into is required');
-        expect(result.errors).toContain('foreach node "fanout" collect.include has invalid field "bogus"');
-    });
-
-    it('reports all structural errors without importing runtime schema validators', () => {
-        const definition = {
-            format_version: PROCESS_DEFINITION_FORMAT_VERSION,
-            process: '',
-            initial: 'missing',
-            context: {
-                schema: {},
-                initial: {},
-            },
-            nodes: {
-                review: {
-                    type: 'human_task',
-                },
-            },
-        } satisfies ProcessDefinitionBody;
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain('initial node "missing" does not exist');
-        expect(result.errors).toContain('human_task node "review" is missing task');
-    });
-
-    it('rejects human_task fields that use "id" instead of "name"', () => {
-        const definition = validDefinition();
-        definition.nodes.review.task = {
-            title: 'Review',
-            fields: [{ id: 'approved', type: 'boolean' } as unknown as { name: string; type: 'boolean' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'human_task node "review" task.fields[0].name must be a non-empty string (not "id")',
-        );
-    });
-
-    it('rejects human_task fields with an unsupported type', () => {
-        const definition = validDefinition();
-        definition.nodes.review.task = {
-            title: 'Review',
-            fields: [{ name: 'approved', type: 'date' } as unknown as { name: string; type: 'string' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'human_task node "review" task.fields[0].type must be one of string, number, boolean, select, text',
-        );
-    });
-
-    it('rejects select fields without options', () => {
-        const definition = validDefinition();
-        definition.nodes.review.task = {
-            title: 'Review',
-            fields: [{ name: 'decision', type: 'select' }],
-        };
-
-        const result = getProcessDefinitionValidationResult(definition);
-
-        expect(result.valid).toBe(false);
-        expect(result.errors).toContain(
-            'human_task node "review" task.fields[0] of type "select" requires a non-empty options[] array',
-        );
-    });
-
-    it('accepts human_task select fields with options', () => {
-        const definition = validDefinition();
-        definition.nodes.review.task = {
-            title: 'Review',
-            fields: [
-                {
-                    name: 'decision',
-                    type: 'select',
-                    options: ['approved', 'rejected'],
-                    required: true,
-                },
-            ],
-        };
-
-        expect(() => validateProcessDefinitionBody(definition)).not.toThrow();
-    });
-
-    it('rejects overly deep guard rules', () => {
-        const definition = validDefinition();
-        let guard: Record<string, unknown> = { var: 'approved' };
-        for (let index = 0; index < MAX_PROCESS_GUARD_DEPTH; index += 1) {
-            guard = { '!': [guard] };
-        }
-        definition.nodes.review.transitions = [{ to: 'approved', guard }];
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow('exceeds maximum depth');
-    });
-
-    it('rejects overly large guard rules', () => {
-        const definition = validDefinition();
-        definition.nodes.review.transitions = [
-            { to: 'approved', guard: { and: Array.from({ length: MAX_PROCESS_GUARD_NODES + 1 }, () => true) } },
-        ];
-
-        expect(() => validateProcessDefinitionBody(definition)).toThrow('exceeds maximum node count');
-    });
-});