@veritree/services 2.28.0 → 2.29.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@veritree/services",
-  "version": "2.28.0",
+  "version": "2.29.1",
   "description": "A collection of javascript functions/services to talk to veritree API",
   "type": "module",
   "main": "index.js",

package/src/helpers/api.js

@@ -217,29 +217,33 @@ export default class Api {
   getUrlParams(args) {
     this.setOrg();
     let isOrgLess = false;
-    let isOrgAs = false;
+    let isOrgIdAs = false;
+    let isOrgTypeAs = false;
     let orgIdParam = "";
     let orgTypeParam = "";
+    let argsClone = structuredClone(args); // avoids mutating object
 
     // while most of endpoints require an org id and type, some endpoints do not
-    if (args) {
-      isOrgLess = Object.hasOwn(args, "orgless");
-      isOrgAs =
-        Object.hasOwn(args, "org_id_as") && Object.hasOwn(args, "org_type_as");
+    if (argsClone) {
+      isOrgLess = Object.hasOwn(argsClone, "orgless");
+      isOrgIdAs = Object.hasOwn(argsClone, "org_id_as");
+      isOrgTypeAs = Object.hasOwn(argsClone, "org_type_as");
     }
 
     // a super admin user can create/edit data from other orgs
     // and for that, we can't use the org id and type in
     // the session.
-    if (isOrgAs) {
-      orgIdParam = `org_id=${args.org_id_as}`;
-      orgTypeParam = `&org_type=${args.org_type_as}`;
+    if (isOrgIdAs) {
+      this.orgId = argsClone.org_id_as;
+      delete argsClone.org_id_as;
+    }
 
-      delete args.org_id_as;
-      delete args.org_type_as;
+    if (isOrgTypeAs) {
+      this.orgType = argsClone.org_type_as;
+      delete argsClone.org_type_as;
     }
 
-    if (!isOrgLess && !isOrgAs) {
+    if (!isOrgLess) {
       if (this.orgId) {
         orgIdParam = `org_id=${this.orgId}`;
       }
@@ -247,13 +251,11 @@ export default class Api {
       if (this.orgType) {
         orgTypeParam = `&org_type=${this.orgType}`;
       }
-
-      if (args && args.orgType) {
-        orgTypeParam = `&org_type=${args.orgType}`;
-      }
     }
 
-    return `?${orgIdParam}${orgTypeParam}${createParamsStringFromArgs(args)}`;
+    return `?${orgIdParam}${orgTypeParam}${createParamsStringFromArgs(
+      argsClone
+    )}`;
   }
 
   /**