@verdaccio/store 7.0.0-next-7.20 → 7.0.0-next-8.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@verdaccio/store",
-  "version": "7.0.0-next-7.20",
+  "version": "7.0.0-next-8.21",
   "description": "loaders logic",
   "main": "./build/index.js",
   "types": "build/index.d.ts",
@@ -29,19 +29,19 @@
     "node": ">=18"
   },
   "dependencies": {
-    "@verdaccio/config": "7.0.0-next-7.20",
-    "@verdaccio/core": "7.0.0-next-7.20",
-    "@verdaccio/hooks": "7.0.0-next-7.20",
-    "@verdaccio/loaders": "7.0.0-next-7.20",
-    "@verdaccio/local-storage": "12.0.0-next-7.20",
-    "@verdaccio/logger": "7.0.0-next-7.20",
-    "@verdaccio/proxy": "7.0.0-next-7.20",
-    "@verdaccio/search": "7.0.0-next-7.9",
-    "@verdaccio/tarball": "12.0.0-next-7.20",
-    "@verdaccio/url": "12.0.0-next-7.20",
-    "@verdaccio/utils": "7.0.0-next-7.20",
+    "@verdaccio/config": "7.0.0-next-8.21",
+    "@verdaccio/core": "7.0.0-next-8.21",
+    "@verdaccio/hooks": "7.0.0-next-8.21",
+    "@verdaccio/loaders": "7.0.0-next-8.21",
+    "@verdaccio/local-storage": "12.0.0-next-8.21",
+    "@verdaccio/logger": "7.0.0-next-8.21",
+    "@verdaccio/proxy": "7.0.0-next-8.21",
+    "@verdaccio/search": "7.0.0-next-8.10",
+    "@verdaccio/tarball": "12.0.0-next-8.21",
+    "@verdaccio/url": "12.0.0-next-8.21",
+    "@verdaccio/utils": "7.0.0-next-8.21",
     "JSONStream": "1.3.5",
-    "debug": "4.3.4",
+    "debug": "4.3.6",
     "lodash": "4.17.21",
     "merge2": "1.4.1",
     "semver": "7.6.3"

package/src/local-storage.ts

@@ -2,7 +2,7 @@ import assert from 'assert';
 import buildDebug from 'debug';
 import _ from 'lodash';
 
-import { errorUtils, pluginUtils } from '@verdaccio/core';
+import { PLUGIN_CATEGORY, errorUtils, pluginUtils } from '@verdaccio/core';
 import { asyncLoadPlugin } from '@verdaccio/loaders';
 import LocalDatabase from '@verdaccio/local-storage';
 import { Config, Logger } from '@verdaccio/types';
@@ -75,7 +75,8 @@ class LocalStorage {
       (plugin) => {
         return typeof plugin.getPackageStorage !== 'undefined';
       },
-      this.config?.serverSettings?.pluginPrefix
+      this.config?.serverSettings?.pluginPrefix,
+      PLUGIN_CATEGORY.STORAGE
     );
 
     if (plugins.length > 1) {

package/src/storage.ts

@@ -15,6 +15,7 @@ import {
   HEADER_TYPE,
   HTTP_STATUS,
   MAINTAINERS,
+  PLUGIN_CATEGORY,
   SUPPORT_ERRORS,
   USERS,
   errorUtils,
@@ -24,7 +25,6 @@ import {
   validatioUtils,
 } from '@verdaccio/core';
 import { asyncLoadPlugin } from '@verdaccio/loaders';
-import { logger } from '@verdaccio/logger';
 import {
   IProxy,
   ISyncUplinksOptions,
@@ -101,7 +101,7 @@ class Storage {
   public readonly logger: Logger;
   public readonly uplinks: ProxyInstanceList;
   private searchService: Search;
-  public constructor(config: Config) {
+  public constructor(config: Config, logger: Logger) {
     this.config = config;
     this.logger = logger.child({ module: 'storage' });
     this.uplinks = setupUpLinks(config, this.logger);
@@ -501,7 +501,7 @@ class Storage {
       try {
         await this.checkAllowedToChangePackage(manifest, options.requestOptions.username);
       } catch (error: any) {
-        logger.error({ error: error.message }, 'getting package has failed: @{error}');
+        this.logger.error({ error: error.message }, 'getting package has failed: @{error}');
         throw errorUtils.getBadRequest(error.message);
       }
     }
@@ -647,7 +647,7 @@ class Storage {
    */
   public async init(config: Config): Promise<void> {
     if (this.localStorage === null) {
-      this.localStorage = new LocalStorage(this.config, logger);
+      this.localStorage = new LocalStorage(this.config, this.logger);
       await this.localStorage.init();
       debug('local init storage initialized');
       await this.localStorage.getSecret(config);
@@ -665,7 +665,8 @@ class Storage {
         (plugin: pluginUtils.ManifestFilter<Config>) => {
           return typeof plugin.filter_metadata !== 'undefined';
         },
-        this.config?.serverSettings?.pluginPrefix
+        this.config?.serverSettings?.pluginPrefix,
+        PLUGIN_CATEGORY.FILTER
       );
       debug('filters available %o', this.filters.length);
     }
@@ -713,13 +714,13 @@ class Storage {
       return results;
     }
 
-    logger.info(
+    this.logger.info(
       { t: query.text, q: query.quality, p: query.popularity, m: query.maintenance, s: query.size },
       'search by text @{t}| maintenance @{m}| quality @{q}| popularity @{p}'
     );
 
     if (typeof this.localStorage.getStoragePlugin().search === 'undefined') {
-      logger.info('plugin search not implemented yet');
+      this.logger.info('plugin search not implemented yet');
     } else {
       debug('search on each package by plugin query');
       const items = await this.localStorage.getStoragePlugin().search(query);
@@ -768,10 +769,10 @@ class Storage {
       manifest = normalizePackage(manifest);
     } catch (err: any) {
       if (err.code === STORAGE.NO_SUCH_FILE_ERROR || err.code === HTTP_STATUS.NOT_FOUND) {
-        logger.info({ pkgName, revision }, 'package not found');
+        this.logger.info({ pkgName, revision }, 'package not found');
         throw errorUtils.getNotFound();
       }
-      logger.error(
+      this.logger.error(
         { pkgName, revision, err: err.message },
         'error @{err} while reading package @{pkgName}-{revision}'
       );
@@ -790,7 +791,7 @@ class Storage {
       for (let attachment of attachments) {
         debug('remove attachment %s', attachment);
         await storage.deletePackage(attachment);
-        logger.info({ attachment }, 'attachment @{attachment} removed');
+        this.logger.info({ attachment }, 'attachment @{attachment} removed');
       }
       // remove package.json
       debug('remove package.json');
@@ -798,7 +799,7 @@ class Storage {
       // remove folder
       debug('remove package folder');
       await storage.removePackage();
-      logger.info({ pkgName }, 'package @{pkgName} removed');
+      this.logger.info({ pkgName }, 'package @{pkgName} removed');
     } catch (err: any) {
       this.logger.error({ err }, 'removed package has failed @{err.message}');
       throw errorUtils.getBadData(err.message);
@@ -897,7 +898,7 @@ class Storage {
           cache: true,
         },
         this.config,
-        logger
+        this.logger
       );
     }
     return uplink;
@@ -944,14 +945,14 @@ class Storage {
       try {
         const { name } = mergedManifest;
         await this.notify(mergedManifest, `${name}@${version}`);
-        logger.info({ name, version }, 'notify for @{name}@@{version} has been sent');
+        this.logger.info({ name, version }, 'notify for @{name}@@{version} has been sent');
       } catch (error: any) {
-        logger.error({ error: error.message }, 'notify batch service has failed: @{error}');
+        this.logger.error({ error: error.message }, 'notify batch service has failed: @{error}');
       }
       return message;
     } else {
       debug('invalid body format');
-      logger.warn(
+      this.logger.warn(
         { packageName: options.name },
         `wrong package format on publish a package @{packageName}`
       );
@@ -1146,7 +1147,7 @@ class Storage {
       }
     } catch (err: any) {
       debug('error on change or update a package with %o', err.message);
-      logger.error({ err: err.message }, 'error on publish new version: @{err}');
+      this.logger.error({ err: err.message }, 'error on publish new version: @{err}');
       throw err;
     }
 
@@ -1161,7 +1162,7 @@ class Storage {
       // addVersion will move the readme from the the published version to the root level
       await this.addVersion(name, versionToPublish, versions[versionToPublish], null, tarballStats);
     } catch (err: any) {
-      logger.error({ err: err.message }, 'updated version has failed: @{err}');
+      this.logger.error({ err: err.message }, 'updated version has failed: @{err}');
       debug('error on create a version for %o with error %o', name, err.message);
       throw err;
     }
@@ -1176,7 +1177,7 @@ class Storage {
       // 4. update once to the storage (easy peasy)
       mergedManifest = await this.mergeTagsNext(name, manifest[DIST_TAGS]);
     } catch (err: any) {
-      logger.error({ err: err.message }, 'merge version has failed: @{err}');
+      this.logger.error({ err: err.message }, 'merge version has failed: @{err}');
       debug('error on create a version for %o with error %o', name, err.message);
       // TODO: undo if this fails
       // 1. remove updated version
@@ -1190,14 +1191,14 @@ class Storage {
         signal: options.signal,
       });
     } catch (err: any) {
-      logger.error({ err: err.message }, 'upload tarball has failed: @{err}');
+      this.logger.error({ err: err.message }, 'upload tarball has failed: @{err}');
       // TODO: undo if this fails
       // 1. remove updated version
       // 2. remove new dist tags
       throw err;
     }
 
-    logger.info(
+    this.logger.info(
       { name, version: versionToPublish },
       'package @{name}@@{version} has been published'
     );
@@ -2028,7 +2029,7 @@ class Storage {
       manifest.maintainers.length > 0 &&
       !manifest.maintainers.some((maintainer) => maintainer.name === username)
     ) {
-      logger.error({ username }, '@{username} is not a maintainer (package owner)');
+      this.logger.error({ username }, '@{username} is not a maintainer (package owner)');
       throw Error('only owners are allowed to change package');
     }
   }

package/test/search.spec.ts

@@ -8,7 +8,7 @@ import { generatePackageMetadata } from '@verdaccio/test-helper';
 
 import { Storage } from '../src';
 
-setup({});
+const logger = setup({});
 
 describe('search', () => {
   describe('search manager utils', () => {
@@ -39,7 +39,7 @@ describe('search', () => {
         ...getDefaultConfig(),
         storage: await fileUtils.createTempStorageFolder('fix-1'),
       });
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       const abort = new AbortController();
       const pkgName = 'verdaccio';

package/test/storage.spec.ts

@@ -44,7 +44,7 @@ function generateRandomStorage() {
   return path.join(tempRoot, tempStorage);
 }
 
-setup({ type: 'stdout', format: 'pretty', level: 'trace' });
+const logger = setup({ type: 'stdout', format: 'pretty', level: 'trace' });
 
 const domain = 'https://registry.npmjs.org';
 const fakeHost = 'localhost:4873';
@@ -149,7 +149,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -194,7 +194,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const ac = new AbortController();
         setTimeout(() => {
@@ -239,7 +239,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         // create a package
         const bodyNewManifest1 = generatePackageMetadata(pkgName, '1.0.0');
@@ -328,7 +328,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest1 = generatePackageMetadata(pkgName, '1.0.0');
         const bodyNewManifest2 = generatePackageMetadata(pkgName, '1.0.0');
@@ -365,7 +365,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
 
@@ -395,7 +395,7 @@ describe('storage', () => {
         const mockDate = '2018-01-14T11:17:40.712Z';
         MockDate.set(mockDate);
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -442,7 +442,7 @@ describe('storage', () => {
         const mockDate = '2018-01-14T11:17:40.712Z';
         MockDate.set(mockDate);
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         // publish new package
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -516,7 +516,7 @@ describe('storage', () => {
     describe('star', () => {
       test.each([['foo']])('star package %s', async (pkgName) => {
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -549,7 +549,7 @@ describe('storage', () => {
         const mockDate = '2018-01-14T11:17:40.712Z';
         MockDate.set(mockDate);
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -591,7 +591,7 @@ describe('storage', () => {
         const mockDate = '2018-01-14T11:17:40.712Z';
         MockDate.set(mockDate);
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -630,7 +630,7 @@ describe('storage', () => {
 
       test.each([['foo']])('should unstar a package %s', async (pkgName) => {
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -667,7 +667,7 @@ describe('storage', () => {
 
       test.each([['foo']])('should handle missing username %s', async (pkgName) => {
         const config = getConfig('deprecate.yaml');
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -695,7 +695,7 @@ describe('storage', () => {
         ['foo', 'publishWithOwnerAndCheck.yaml'],
       ])('new package %s, %s (anonymous)', async (pkgName, configFile) => {
         const config = getConfig(configFile);
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         await storage.updateManifest(bodyNewManifest, {
@@ -717,7 +717,7 @@ describe('storage', () => {
         ['foo', 'publishWithOwnerAndCheck.yaml'],
       ])('new package %s, %s (logged in)', async (pkgName, configFile) => {
         const config = getConfig(configFile);
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const owner = { name: 'fooUser', email: '' };
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -742,7 +742,7 @@ describe('storage', () => {
         ['foo', 'publishWithOwnerAndCheck.yaml'],
       ])('add/remove owner %s, %s', async (pkgName, configFile) => {
         const config = getConfig(configFile);
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const firstOwner = { name: 'fooUser', email: '' };
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -802,7 +802,7 @@ describe('storage', () => {
         ['foo', 'publishWithOwnerAndCheck.yaml'],
       ])('should fail removing last owner %s, %s', async (pkgName, configFile) => {
         const config = getConfig(configFile);
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
         const owner = 'fooUser';
@@ -830,7 +830,7 @@ describe('storage', () => {
         'ok to publish as non-owner without check %s, %s',
         async (pkgName, configFile) => {
           const config = getConfig(configFile);
-          const storage = new Storage(config);
+          const storage = new Storage(config, logger);
           await storage.init(config);
           const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
           const owner = 'fooUser';
@@ -860,7 +860,7 @@ describe('storage', () => {
         'should fail publishing as non-owner with check %s, %s',
         async (pkgName, configFile) => {
           const config = getConfig(configFile);
-          const storage = new Storage(config);
+          const storage = new Storage(config, logger);
           await storage.init(config);
           const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
           const owner = 'fooUser';
@@ -898,7 +898,7 @@ describe('storage', () => {
           storage: generateRandomStorage(),
         })
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const ac = new AbortController();
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -938,7 +938,7 @@ describe('storage', () => {
           storage: generateRandomStorage(),
         })
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const abort = new AbortController();
         storage
@@ -978,7 +978,7 @@ describe('storage', () => {
           __dirname
         )
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const abort = new AbortController();
         storage
@@ -1022,7 +1022,7 @@ describe('storage', () => {
           __dirname
         )
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const ac = new AbortController();
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -1086,7 +1086,7 @@ describe('storage', () => {
           __dirname
         )
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const req = httpMocks.createRequest({
           method: 'GET',
@@ -1139,7 +1139,7 @@ describe('storage', () => {
           __dirname
         )
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       storage.init(config).then(() => {
         const ac = new AbortController();
         const bodyNewManifest = generatePackageMetadata(pkgName, '1.0.0');
@@ -1196,7 +1196,7 @@ describe('storage', () => {
           )
         );
 
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.syncUplinksMetadata(fooManifest.name, null, {
@@ -1220,7 +1220,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.syncUplinksMetadata(fooManifest.name, null, {
@@ -1241,7 +1241,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         const [manifest] = await storage.syncUplinksMetadata(fooManifest.name, fooManifest, {
           retry: { limit: 0 },
@@ -1263,7 +1263,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const [response] = await storage.syncUplinksMetadata(fooManifest.name, fooManifest);
@@ -1304,7 +1304,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const [response] = await storage.syncUplinksMetadata(fooManifest.name, null);
@@ -1326,7 +1326,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const [response] = await storage.syncUplinksMetadata(fooManifest.name, fooManifest);
@@ -1350,7 +1350,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const [response] = await storage.syncUplinksMetadata(fooManifest.name, fooManifest, {
@@ -1379,7 +1379,7 @@ describe('storage', () => {
             __dirname
           )
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const [response] = await storage.syncUplinksMetadata('foo', null, {
@@ -1400,7 +1400,7 @@ describe('storage', () => {
           storage: generateRandomStorage(),
         })
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       await expect(storage.getLocalDatabase()).resolves.toHaveLength(0);
     });
@@ -1420,7 +1420,7 @@ describe('storage', () => {
         },
         url: '/',
       });
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       const manifest = generatePackageMetadata('foo');
       const ac = new AbortController();
@@ -1449,7 +1449,7 @@ describe('storage', () => {
             storage: generateRandomStorage(),
           })
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await storage.saveToken({
           user: 'foo',
@@ -1471,7 +1471,7 @@ describe('storage', () => {
             storage: generateRandomStorage(),
           })
         );
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await storage.saveToken({
           user: 'foo',
@@ -1498,7 +1498,7 @@ describe('storage', () => {
           storage: generateRandomStorage(),
         })
       );
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       await expect(storage.removeTarball('foo', 'foo-1.0.0.tgz', 'rev', username)).rejects.toThrow(
         API_ERROR.NO_PACKAGE
@@ -1524,7 +1524,7 @@ describe('storage', () => {
         },
         url: '/',
       });
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
 
       const manifest = generatePackageMetadata('foo');
@@ -1573,7 +1573,7 @@ describe('storage', () => {
 
     test('ok to remove package as non-owner without check', async () => {
       const config = getConfig('publishWithOwnerDefault.yaml');
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       const owner = 'fooUser';
       const options = { ...defaultRequestOptions, username: owner };
@@ -1612,7 +1612,7 @@ describe('storage', () => {
 
     test('should fail as non-owner with check', async () => {
       const config = getConfig('publishWithOwnerAndCheck.yaml');
-      const storage = new Storage(config);
+      const storage = new Storage(config, logger);
       await storage.init(config);
       const owner = 'fooUser';
       const options = { ...defaultRequestOptions, username: owner };
@@ -1661,7 +1661,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1693,7 +1693,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1726,7 +1726,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1759,7 +1759,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1799,7 +1799,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1839,7 +1839,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
         await expect(
           storage.getPackageByOptions({
@@ -1873,7 +1873,7 @@ describe('storage', () => {
           },
           url: '/',
         });
-        const storage = new Storage(config);
+        const storage = new Storage(config, logger);
         await storage.init(config);
 
         const manifest = (await storage.getPackageByOptions({