@verdaccio/store 6.0.0-6-next.27 → 6.0.0-6-next.28

package/CHANGELOG.md

@@ -1,5 +1,86 @@
 # @verdaccio/store
 
+## 6.0.0-6-next.28
+
+### Major Changes
+
+- 9fc2e796: feat(plugins): improve plugin loader
+
+  ### Changes
+
+  - Add scope plugin support to 6.x https://github.com/verdaccio/verdaccio/pull/3227
+  - Avoid config collisions https://github.com/verdaccio/verdaccio/issues/928
+  - https://github.com/verdaccio/verdaccio/issues/1394
+  - `config.plugins` plugin path validations
+  - Updated algorithm for plugin loader.
+  - improved documentation (included dev)
+
+  ## Features
+
+  - Add scope plugin support to 6.x https://github.com/verdaccio/verdaccio/pull/3227
+  - Custom prefix:
+
+  ```
+  // config.yaml
+  server:
+    pluginPrefix: mycompany
+  middleware:
+    audit:
+        foo: 1
+  ```
+
+  This configuration will look up for `mycompany-audit` instead `Verdaccio-audit`.
+
+  ## Breaking Changes
+
+  ### sinopia plugins
+
+  - `sinopia` fallback support is removed, but can be restored using `pluginPrefix`
+
+  ### plugin filter
+
+  - method rename `filter_metadata`->`filterMetadata`
+
+  ### Plugin constructor does not merge configs anymore https://github.com/verdaccio/verdaccio/issues/928
+
+  The plugin receives as first argument `config`, which represents the config of the plugin. Example:
+
+  ```
+  // config.yaml
+  auth:
+    plugin:
+       foo: 1
+       bar: 2
+
+  export class Plugin<T> {
+    public constructor(config: T, options: PluginOptions) {
+      console.log(config);
+      // {foo:1, bar: 2}
+   }
+  }
+  ```
+
+### Minor Changes
+
+- 62c24b63: feat: add passwordValidationRegex property
+
+### Patch Changes
+
+- 43f32687: fix: abbreviated headers handle quality values
+- Updated dependencies [43f32687]
+- Updated dependencies [9fc2e796]
+- Updated dependencies [62c24b63]
+  - @verdaccio/core@6.0.0-6-next.48
+  - @verdaccio/config@6.0.0-6-next.48
+  - @verdaccio/loaders@6.0.0-6-next.17
+  - @verdaccio/local-storage@11.0.0-6-next.18
+  - @verdaccio/utils@6.0.0-6-next.16
+  - @verdaccio/tarball@11.0.0-6-next.17
+  - @verdaccio/url@11.0.0-6-next.14
+  - @verdaccio/hooks@6.0.0-6-next.18
+  - @verdaccio/logger@6.0.0-6-next.16
+  - @verdaccio/proxy@6.0.0-6-next.26
+
 ## 6.0.0-6-next.27
 
 ### Patch Changes

package/build/local-storage.d.ts

@@ -14,7 +14,7 @@ declare class LocalStorage {
     init(): Promise<void>;
     getStoragePlugin(): IPluginStorage;
     getSecret(config: Config): Promise<void>;
-    private _loadStorage;
-    private _loadStorePlugin;
+    private loadStorage;
+    private loadStorePlugin;
 }
 export { LocalStorage };

package/build/local-storage.js

@@ -41,7 +41,7 @@ class LocalStorage {
 
   async init() {
     if (this.storagePlugin === null) {
-      this.storagePlugin = this._loadStorage(this.config, this.logger);
+      this.storagePlugin = await this.loadStorage(this.config, this.logger);
       debug('storage plugin init');
       await this.storagePlugin.init();
       debug('storage plugin initialized');
@@ -65,25 +65,32 @@ class LocalStorage {
     return this.storagePlugin.setSecret(config.checkSecretKey(secretKey));
   }
 
-  _loadStorage(config, logger) {
-    const Storage = this._loadStorePlugin();
+  async loadStorage(config, logger) {
+    const Storage = await this.loadStorePlugin();
 
     if (_lodash.default.isNil(Storage)) {
       (0, _assert.default)(this.config.storage, 'CONFIG: storage path not defined');
+      debug('no custom storage found, loading default storage @verdaccio/local-storage');
       return new _localStorage.default(config, logger);
     }
 
     return Storage;
   }
 
-  _loadStorePlugin() {
-    const plugin_params = {
+  async loadStorePlugin() {
+    var _this$config, _this$config$serverSe;
+
+    const plugins = await (0, _loaders.asyncLoadPlugin)(this.config.store, {
       config: this.config,
       logger: this.logger
-    };
-    const plugins = (0, _loaders.loadPlugin)(this.config, this.config.store, plugin_params, plugin => {
+    }, plugin => {
       return plugin.getPackageStorage;
-    });
+    }, (_this$config = this.config) === null || _this$config === void 0 ? void 0 : (_this$config$serverSe = _this$config.serverSettings) === null || _this$config$serverSe === void 0 ? void 0 : _this$config$serverSe.pluginPrefix);
+
+    if (plugins.length > 1) {
+      this.logger.warn('more than one storage plugins has been detected, multiple storage are not supported, one will be selected automatically');
+    }
+
     return _lodash.default.head(plugins);
   }
 

package/build/local-storage.js.map

@@ -1 +1 @@
-{"version":3,"file":"local-storage.js","names":["debug","buildDebug","noSuchFile","resourceNotAvailable","LocalStorage","constructor","config","logger","child","sub","storagePlugin","init","_loadStorage","warn","getStoragePlugin","errorUtils","getInternalError","getSecret","secretKey","setSecret","checkSecretKey","Storage","_loadStorePlugin","_","isNil","assert","storage","LocalDatabase","plugin_params","plugins","loadPlugin","store","plugin","getPackageStorage","head"],"sources":["../src/local-storage.ts"],"sourcesContent":["import assert from 'assert';\nimport buildDebug from 'debug';\nimport _ from 'lodash';\n\nimport { errorUtils, pluginUtils } from '@verdaccio/core';\nimport { loadPlugin } from '@verdaccio/loaders';\nimport LocalDatabase from '@verdaccio/local-storage';\nimport { Config, Logger } from '@verdaccio/types';\n\nconst debug = buildDebug('verdaccio:storage:local');\n\nexport const noSuchFile = 'ENOENT';\nexport const resourceNotAvailable = 'EAGAIN';\nexport type IPluginStorage = pluginUtils.IPluginStorage<Config>;\n\n/**\n * Implements Storage interface (same for storage.js, local-storage.js, up-storage.js).\n */\nclass LocalStorage {\n  public config: Config;\n  public storagePlugin: IPluginStorage;\n  public logger: Logger;\n\n  public constructor(config: Config, logger: Logger) {\n    debug('local storage created');\n    this.logger = logger.child({ sub: 'fs' });\n    this.config = config;\n    // @ts-expect-error\n    this.storagePlugin = null;\n  }\n\n  public async init() {\n    if (this.storagePlugin === null) {\n      this.storagePlugin = this._loadStorage(this.config, this.logger);\n      debug('storage plugin init');\n      await this.storagePlugin.init();\n      debug('storage plugin initialized');\n    } else {\n      this.logger.warn('storage plugin has been already initialized');\n    }\n    return;\n  }\n\n  public getStoragePlugin(): IPluginStorage {\n    if (this.storagePlugin === null) {\n      throw errorUtils.getInternalError('storage plugin is not initialized');\n    }\n\n    return this.storagePlugin;\n  }\n\n  public async getSecret(config: Config): Promise<void> {\n    const secretKey = await this.storagePlugin.getSecret();\n\n    return this.storagePlugin.setSecret(config.checkSecretKey(secretKey));\n  }\n\n  private _loadStorage(config: Config, logger: Logger): IPluginStorage {\n    const Storage = this._loadStorePlugin();\n\n    if (_.isNil(Storage)) {\n      assert(this.config.storage, 'CONFIG: storage path not defined');\n      return new LocalDatabase(config, logger);\n    }\n    return Storage as IPluginStorage;\n  }\n\n  private _loadStorePlugin(): IPluginStorage | void {\n    const plugin_params = {\n      config: this.config,\n      logger: this.logger,\n    };\n\n    const plugins: IPluginStorage[] = loadPlugin<IPluginStorage>(\n      this.config,\n      this.config.store,\n      plugin_params,\n      (plugin): IPluginStorage => {\n        return plugin.getPackageStorage;\n      }\n    );\n\n    return _.head(plugins);\n  }\n}\n\nexport { LocalStorage };\n"],"mappings":";;;;;;;AAAA;;AACA;;AACA;;AAEA;;AACA;;AACA;;;;AAGA,MAAMA,KAAK,GAAG,IAAAC,cAAA,EAAW,yBAAX,CAAd;AAEO,MAAMC,UAAU,GAAG,QAAnB;;AACA,MAAMC,oBAAoB,GAAG,QAA7B;;;AAGP;AACA;AACA;AACA,MAAMC,YAAN,CAAmB;EAKVC,WAAW,CAACC,MAAD,EAAiBC,MAAjB,EAAiC;IACjDP,KAAK,CAAC,uBAAD,CAAL;IACA,KAAKO,MAAL,GAAcA,MAAM,CAACC,KAAP,CAAa;MAAEC,GAAG,EAAE;IAAP,CAAb,CAAd;IACA,KAAKH,MAAL,GAAcA,MAAd,CAHiD,CAIjD;;IACA,KAAKI,aAAL,GAAqB,IAArB;EACD;;EAEgB,MAAJC,IAAI,GAAG;IAClB,IAAI,KAAKD,aAAL,KAAuB,IAA3B,EAAiC;MAC/B,KAAKA,aAAL,GAAqB,KAAKE,YAAL,CAAkB,KAAKN,MAAvB,EAA+B,KAAKC,MAApC,CAArB;MACAP,KAAK,CAAC,qBAAD,CAAL;MACA,MAAM,KAAKU,aAAL,CAAmBC,IAAnB,EAAN;MACAX,KAAK,CAAC,4BAAD,CAAL;IACD,CALD,MAKO;MACL,KAAKO,MAAL,CAAYM,IAAZ,CAAiB,6CAAjB;IACD;;IACD;EACD;;EAEMC,gBAAgB,GAAmB;IACxC,IAAI,KAAKJ,aAAL,KAAuB,IAA3B,EAAiC;MAC/B,MAAMK,gBAAA,CAAWC,gBAAX,CAA4B,mCAA5B,CAAN;IACD;;IAED,OAAO,KAAKN,aAAZ;EACD;;EAEqB,MAATO,SAAS,CAACX,MAAD,EAAgC;IACpD,MAAMY,SAAS,GAAG,MAAM,KAAKR,aAAL,CAAmBO,SAAnB,EAAxB;IAEA,OAAO,KAAKP,aAAL,CAAmBS,SAAnB,CAA6Bb,MAAM,CAACc,cAAP,CAAsBF,SAAtB,CAA7B,CAAP;EACD;;EAEON,YAAY,CAACN,MAAD,EAAiBC,MAAjB,EAAiD;IACnE,MAAMc,OAAO,GAAG,KAAKC,gBAAL,EAAhB;;IAEA,IAAIC,eAAA,CAAEC,KAAF,CAAQH,OAAR,CAAJ,EAAsB;MACpB,IAAAI,eAAA,EAAO,KAAKnB,MAAL,CAAYoB,OAAnB,EAA4B,kCAA5B;MACA,OAAO,IAAIC,qBAAJ,CAAkBrB,MAAlB,EAA0BC,MAA1B,CAAP;IACD;;IACD,OAAOc,OAAP;EACD;;EAEOC,gBAAgB,GAA0B;IAChD,MAAMM,aAAa,GAAG;MACpBtB,MAAM,EAAE,KAAKA,MADO;MAEpBC,MAAM,EAAE,KAAKA;IAFO,CAAtB;IAKA,MAAMsB,OAAyB,GAAG,IAAAC,mBAAA,EAChC,KAAKxB,MAD2B,EAEhC,KAAKA,MAAL,CAAYyB,KAFoB,EAGhCH,aAHgC,EAI/BI,MAAD,IAA4B;MAC1B,OAAOA,MAAM,CAACC,iBAAd;IACD,CAN+B,CAAlC;IASA,OAAOV,eAAA,CAAEW,IAAF,CAAOL,OAAP,CAAP;EACD;;AAjEgB"}
+{"version":3,"file":"local-storage.js","names":["debug","buildDebug","noSuchFile","resourceNotAvailable","LocalStorage","constructor","config","logger","child","sub","storagePlugin","init","loadStorage","warn","getStoragePlugin","errorUtils","getInternalError","getSecret","secretKey","setSecret","checkSecretKey","Storage","loadStorePlugin","_","isNil","assert","storage","LocalDatabase","plugins","asyncLoadPlugin","store","plugin","getPackageStorage","serverSettings","pluginPrefix","length","head"],"sources":["../src/local-storage.ts"],"sourcesContent":["import assert from 'assert';\nimport buildDebug from 'debug';\nimport _ from 'lodash';\n\nimport { errorUtils, pluginUtils } from '@verdaccio/core';\nimport { asyncLoadPlugin } from '@verdaccio/loaders';\nimport LocalDatabase from '@verdaccio/local-storage';\nimport { Config, Logger } from '@verdaccio/types';\n\nconst debug = buildDebug('verdaccio:storage:local');\n\nexport const noSuchFile = 'ENOENT';\nexport const resourceNotAvailable = 'EAGAIN';\nexport type IPluginStorage = pluginUtils.IPluginStorage<Config>;\n\n/**\n * Implements Storage interface (same for storage.js, local-storage.js, up-storage.js).\n */\nclass LocalStorage {\n  public config: Config;\n  public storagePlugin: IPluginStorage;\n  public logger: Logger;\n\n  public constructor(config: Config, logger: Logger) {\n    debug('local storage created');\n    this.logger = logger.child({ sub: 'fs' });\n    this.config = config;\n    // @ts-expect-error\n    this.storagePlugin = null;\n  }\n\n  public async init() {\n    if (this.storagePlugin === null) {\n      this.storagePlugin = await this.loadStorage(this.config, this.logger);\n      debug('storage plugin init');\n      await this.storagePlugin.init();\n      debug('storage plugin initialized');\n    } else {\n      this.logger.warn('storage plugin has been already initialized');\n    }\n    return;\n  }\n\n  public getStoragePlugin(): IPluginStorage {\n    if (this.storagePlugin === null) {\n      throw errorUtils.getInternalError('storage plugin is not initialized');\n    }\n\n    return this.storagePlugin;\n  }\n\n  public async getSecret(config: Config): Promise<void> {\n    const secretKey = await this.storagePlugin.getSecret();\n\n    return this.storagePlugin.setSecret(config.checkSecretKey(secretKey));\n  }\n\n  private async loadStorage(config: Config, logger: Logger): Promise<IPluginStorage> {\n    const Storage = await this.loadStorePlugin();\n    if (_.isNil(Storage)) {\n      assert(this.config.storage, 'CONFIG: storage path not defined');\n      debug('no custom storage found, loading default storage @verdaccio/local-storage');\n      return new LocalDatabase(config, logger);\n    }\n    return Storage as IPluginStorage;\n  }\n\n  private async loadStorePlugin(): Promise<IPluginStorage | undefined> {\n    const plugins: IPluginStorage[] = await asyncLoadPlugin<IPluginStorage>(\n      this.config.store,\n      {\n        config: this.config,\n        logger: this.logger,\n      },\n      (plugin): IPluginStorage => {\n        return plugin.getPackageStorage;\n      },\n      this.config?.serverSettings?.pluginPrefix\n    );\n\n    if (plugins.length > 1) {\n      this.logger.warn(\n        'more than one storage plugins has been detected, multiple storage are not supported, one will be selected automatically'\n      );\n    }\n\n    return _.head(plugins);\n  }\n}\n\nexport { LocalStorage };\n"],"mappings":";;;;;;;AAAA;;AACA;;AACA;;AAEA;;AACA;;AACA;;;;AAGA,MAAMA,KAAK,GAAG,IAAAC,cAAA,EAAW,yBAAX,CAAd;AAEO,MAAMC,UAAU,GAAG,QAAnB;;AACA,MAAMC,oBAAoB,GAAG,QAA7B;;;AAGP;AACA;AACA;AACA,MAAMC,YAAN,CAAmB;EAKVC,WAAW,CAACC,MAAD,EAAiBC,MAAjB,EAAiC;IACjDP,KAAK,CAAC,uBAAD,CAAL;IACA,KAAKO,MAAL,GAAcA,MAAM,CAACC,KAAP,CAAa;MAAEC,GAAG,EAAE;IAAP,CAAb,CAAd;IACA,KAAKH,MAAL,GAAcA,MAAd,CAHiD,CAIjD;;IACA,KAAKI,aAAL,GAAqB,IAArB;EACD;;EAEgB,MAAJC,IAAI,GAAG;IAClB,IAAI,KAAKD,aAAL,KAAuB,IAA3B,EAAiC;MAC/B,KAAKA,aAAL,GAAqB,MAAM,KAAKE,WAAL,CAAiB,KAAKN,MAAtB,EAA8B,KAAKC,MAAnC,CAA3B;MACAP,KAAK,CAAC,qBAAD,CAAL;MACA,MAAM,KAAKU,aAAL,CAAmBC,IAAnB,EAAN;MACAX,KAAK,CAAC,4BAAD,CAAL;IACD,CALD,MAKO;MACL,KAAKO,MAAL,CAAYM,IAAZ,CAAiB,6CAAjB;IACD;;IACD;EACD;;EAEMC,gBAAgB,GAAmB;IACxC,IAAI,KAAKJ,aAAL,KAAuB,IAA3B,EAAiC;MAC/B,MAAMK,gBAAA,CAAWC,gBAAX,CAA4B,mCAA5B,CAAN;IACD;;IAED,OAAO,KAAKN,aAAZ;EACD;;EAEqB,MAATO,SAAS,CAACX,MAAD,EAAgC;IACpD,MAAMY,SAAS,GAAG,MAAM,KAAKR,aAAL,CAAmBO,SAAnB,EAAxB;IAEA,OAAO,KAAKP,aAAL,CAAmBS,SAAnB,CAA6Bb,MAAM,CAACc,cAAP,CAAsBF,SAAtB,CAA7B,CAAP;EACD;;EAEwB,MAAXN,WAAW,CAACN,MAAD,EAAiBC,MAAjB,EAA0D;IACjF,MAAMc,OAAO,GAAG,MAAM,KAAKC,eAAL,EAAtB;;IACA,IAAIC,eAAA,CAAEC,KAAF,CAAQH,OAAR,CAAJ,EAAsB;MACpB,IAAAI,eAAA,EAAO,KAAKnB,MAAL,CAAYoB,OAAnB,EAA4B,kCAA5B;MACA1B,KAAK,CAAC,2EAAD,CAAL;MACA,OAAO,IAAI2B,qBAAJ,CAAkBrB,MAAlB,EAA0BC,MAA1B,CAAP;IACD;;IACD,OAAOc,OAAP;EACD;;EAE4B,MAAfC,eAAe,GAAwC;IAAA;;IACnE,MAAMM,OAAyB,GAAG,MAAM,IAAAC,wBAAA,EACtC,KAAKvB,MAAL,CAAYwB,KAD0B,EAEtC;MACExB,MAAM,EAAE,KAAKA,MADf;MAEEC,MAAM,EAAE,KAAKA;IAFf,CAFsC,EAMrCwB,MAAD,IAA4B;MAC1B,OAAOA,MAAM,CAACC,iBAAd;IACD,CARqC,kBAStC,KAAK1B,MATiC,0EAStC,aAAa2B,cATyB,0DAStC,sBAA6BC,YATS,CAAxC;;IAYA,IAAIN,OAAO,CAACO,MAAR,GAAiB,CAArB,EAAwB;MACtB,KAAK5B,MAAL,CAAYM,IAAZ,CACE,yHADF;IAGD;;IAED,OAAOU,eAAA,CAAEa,IAAF,CAAOR,OAAP,CAAP;EACD;;AArEgB"}

package/build/storage.d.ts

@@ -12,7 +12,7 @@ export declare const resourceNotAvailable = "EAGAIN";
 export declare const PROTO_NAME = "__proto__";
 declare class Storage {
     localStorage: LocalStorage;
-    filters: IPluginFilters;
+    filters: IPluginFilters | null;
     readonly config: Config;
     readonly logger: Logger;
     readonly uplinks: ProxyInstanceList;
@@ -23,7 +23,7 @@ declare class Storage {
      Function changes a package info from local storage and all uplinks with write access./
      Used storages: local (write)
      */
-    changePackageNext(name: string, metadata: Manifest, revision: string): Promise<void>;
+    changePackage(name: string, metadata: Manifest, revision: string): Promise<void>;
     removePackage(name: string, revision: any): Promise<void>;
     /**
      Remove a tarball from a system
@@ -70,7 +70,7 @@ declare class Storage {
      * @param filters IPluginFilters
      * @returns Storage instance
      */
-    init(config: Config, filters?: IPluginFilters): Promise<void>;
+    init(config: Config): Promise<void>;
     /**
      * Consume the upstream and pipe it to a transformable stream.
      */
@@ -114,7 +114,6 @@ declare class Storage {
      */
     mergeTagsNext(name: string, tags: MergeTags): Promise<Manifest>;
     private getUpLinkForDistFile;
-    updateLocalMetadata(pkgName: string): Promise<void>;
     updateManifest(manifest: Manifest, options: UpdateManifestOptions): Promise<void>;
     private deprecate;
     private star;
@@ -183,14 +182,14 @@ declare class Storage {
      */
     private checkPackageRemote;
     private setDefaultRevision;
-    private writePackageNext;
+    private writePackage;
     /**
      * @param {*} name package name
      * @param {*} updateHandler function(package, cb) - update function
      * @param {*} callback callback that gets invoked after it's all updated
      * @return {Function}
      */
-    private updatePackageNext;
+    private updatePackage;
     /**
      *
      * @protected

package/build/storage.js

@@ -23,6 +23,8 @@ var _config = require("@verdaccio/config");
 
 var _core = require("@verdaccio/core");
 
+var _loaders = require("@verdaccio/loaders");
+
 var _logger = require("@verdaccio/logger");
 
 var _proxy = require("@verdaccio/proxy");
@@ -68,20 +70,20 @@ class Storage {
     this.logger = _logger.logger.child({
       module: 'storage'
     });
-    this.filters = []; // @ts-ignore
+    this.filters = null; // @ts-ignore
 
     this.localStorage = null;
     debug('uplinks available %o', Object.keys(this.uplinks));
   }
 
-  static ABBREVIATED_HEADER = 'application/vnd.npm.install-v1+json; q=1.0, application/json; q=0.8, */*';
+  static ABBREVIATED_HEADER = 'application/vnd.npm.install-v1+json';
   /**
    * Change an existing package (i.e. unpublish one version)
    Function changes a package info from local storage and all uplinks with write access./
    Used storages: local (write)
    */
 
-  async changePackageNext(name, metadata, revision) {
+  async changePackage(name, metadata, revision) {
     debug('change existing package for package %o revision %o', name, revision);
     debug(`change manifest tags for %o revision %s`, name, revision);
 
@@ -91,7 +93,7 @@ class Storage {
     }
 
     debug(`change manifest udapting manifest for %o`, name);
-    await this.updatePackageNext(name, async localData => {
+    await this.updatePackage(name, async localData => {
       // eslint-disable-next-line guard-for-in
       for (const version in localData.versions) {
         const incomingVersion = metadata.versions[version];
@@ -178,7 +180,7 @@ class Storage {
       throw err;
     }
 
-    const manifest = await this.updatePackageNext(name, async data => {
+    const manifest = await this.updatePackage(name, async data => {
       let newData = { ...data
       };
       delete data._attachments[filename];
@@ -634,10 +636,8 @@ class Storage {
    */
 
 
-  async init(config, filters = []) {
+  async init(config) {
     if (this.localStorage === null) {
-      this.filters = filters || [];
-      debug('filters available %o', filters);
       this.localStorage = new _localStorage.LocalStorage(this.config, _logger.logger);
       await this.localStorage.init();
       debug('local init storage initialized');
@@ -647,6 +647,18 @@ class Storage {
       debug('storage has been already initialized');
     }
 
+    if (!this.filters) {
+      var _this$config, _this$config$serverSe;
+
+      this.filters = await (0, _loaders.asyncLoadPlugin)(this.config.filters, {
+        config: this.config,
+        logger: this.logger
+      }, plugin => {
+        return plugin.filterMetadata;
+      }, (_this$config = this.config) === null || _this$config === void 0 ? void 0 : (_this$config$serverSe = _this$config.serverSettings) === null || _this$config$serverSe === void 0 ? void 0 : _this$config$serverSe.pluginPrefix);
+      debug('filters available %o', this.filters);
+    }
+
     return;
   }
   /**
@@ -876,7 +888,7 @@ class Storage {
 
 
   async mergeTagsNext(name, tags) {
-    return await this.updatePackageNext(name, async data => {
+    return await this.updatePackage(name, async data => {
       let newData = { ...data
       };
 
@@ -920,14 +932,6 @@ class Storage {
     return uplink;
   }
 
-  async updateLocalMetadata(pkgName) {
-    const storage = this.getPrivatePackageStorage(pkgName);
-
-    if (!storage) {
-      throw _core.errorUtils.getNotFound();
-    }
-  }
-
   async updateManifest(manifest, options) {
     if ((0, _2.isDeprecatedManifest)(manifest)) {
       // if the manifest is deprecated, we need to update the package.json
@@ -967,15 +971,14 @@ class Storage {
 
       throw _core.errorUtils.getBadRequest(_core.API_ERROR.UNSUPORTED_REGISTRY_CALL);
     }
-  } // eslint-disable-next-line @typescript-eslint/no-unused-vars
-
+  }
 
-  async deprecate(_body, _options) {
-    // // const storage: IPackageStorage = this.getPrivatePackageStorage(opname);
-    // if (typeof storage === 'undefined') {
-    //   throw errorUtils.getNotFound();
-    // }
-    throw _core.errorUtils.getInternalError('no implementation ready for npm deprecate');
+  async deprecate(manifest, options) {
+    const {
+      name
+    } = manifest;
+    debug('deprecating %s', name);
+    return this.changePackage(name, manifest, options.revision);
   } // eslint-disable-next-line @typescript-eslint/no-unused-vars
 
 
@@ -1073,7 +1076,7 @@ class Storage {
     const buffer = this.getBufferManifest(body._attachments[firstAttachmentKey].data);
 
     try {
-      var _this$config, _this$config$publish;
+      var _this$config2, _this$config2$publish;
 
       // we check if package exist already locally
       const manifest = await this.getPackagelocalByNameNext(name); // if continue, the version to be published does not exist
@@ -1083,7 +1086,7 @@ class Storage {
         throw _core.errorUtils.getConflict();
       }
 
-      const uplinksLook = ((_this$config = this.config) === null || _this$config === void 0 ? void 0 : (_this$config$publish = _this$config.publish) === null || _this$config$publish === void 0 ? void 0 : _this$config$publish.allow_offline) === false; // if execution get here, package does not exist locally, we search upstream
+      const uplinksLook = ((_this$config2 = this.config) === null || _this$config2 === void 0 ? void 0 : (_this$config2$publish = _this$config2.publish) === null || _this$config2$publish === void 0 ? void 0 : _this$config2$publish.allow_offline) === false; // if execution get here, package does not exist locally, we search upstream
 
       const remoteManifest = await this.checkPackageRemote(name, uplinksLook);
 
@@ -1268,7 +1271,7 @@ class Storage {
         try {
           debug('uploaded tarball %o for %o', filename, pkgName); // update the package metadata
 
-          await this.updatePackageNext(pkgName, async data => {
+          await this.updatePackage(pkgName, async data => {
             const newData = { ...data
             };
             debug('added _attachment for %o', pkgName);
@@ -1306,7 +1309,7 @@ class Storage {
 
   async addVersionNext(name, version, metadata, tag) {
     debug(`add version %s package for %s`, version, name);
-    await this.updatePackageNext(name, async data => {
+    await this.updatePackage(name, async data => {
       // keep only one readme per package
       data.readme = metadata.readme;
       debug('%s` readme mutated', name); // TODO: lodash remove
@@ -1470,13 +1473,15 @@ class Storage {
 
 
     if (_lodash.default.isNil(this.config._debug)) {
+      const prev = json._rev;
       json._rev = (0, _storageUtils.generateRevision)(json._rev);
+      debug('revision metadata for %s updated from %s to %s', json.name, prev, json._rev);
     }
 
     return json;
   }
 
-  async writePackageNext(name, json) {
+  async writePackage(name, json) {
     const storage = this.getPrivatePackageStorage(name);
 
     if (_lodash.default.isNil(storage)) {
@@ -1494,7 +1499,7 @@ class Storage {
    */
 
 
-  async updatePackageNext(name, updateHandler) {
+  async updatePackage(name, updateHandler) {
     const storage = this.getPrivatePackageStorage(name);
 
     if (!storage) {
@@ -1505,7 +1510,7 @@ class Storage {
     const updatedManifest = await storage.updatePackage(name, updateHandler); // after correctly updated write to the storage
 
     try {
-      await this.writePackageNext(name, (0, _storageUtils.normalizePackage)(updatedManifest));
+      await this.writePackage(name, (0, _storageUtils.normalizePackage)(updatedManifest));
       return updatedManifest;
     } catch (err) {
       if (err.code === resourceNotAvailable) {
@@ -1734,7 +1739,7 @@ class Storage {
 
 
   async applyFilters(manifest) {
-    if (this.filters.length === 0) {
+    if (this.filters === null || this.filters.length === 0) {
       return [manifest, []];
     }
 
@@ -1747,7 +1752,7 @@ class Storage {
       // and return it directly for
       // performance (i.e. need not be pure)
       try {
-        filteredManifest = await filter.filter_metadata(manifest);
+        filteredManifest = await filter.filterMetadata(manifest);
       } catch (err) {
         this.logger.error({
           err: err.message
@@ -1912,7 +1917,7 @@ class Storage {
 
     if (change) {
       debug('updating package info %o', name);
-      await this.writePackageNext(name, cacheManifest);
+      await this.writePackage(name, cacheManifest);
       return cacheManifest;
     } else {
       return cacheManifest;