@verdaccio/store 6.0.0-6-next.13 → 6.0.0-6-next.17

package/CHANGELOG.md

@@ -1,5 +1,113 @@
 # @verdaccio/store
 
+## 6.0.0-6-next.17
+
+### Major Changes
+
+- a828271d: refactor: download manifest endpoint and integrate fastify
+
+  Much simpler API for fetching a package
+
+  ```
+   const manifest = await storage.getPackageNext({
+        name,
+        uplinksLook: true,
+        req,
+        version: queryVersion,
+        requestOptions,
+   });
+  ```
+
+  > not perfect, the `req` still is being passed to the proxy (this has to be refactored at proxy package) and then removed from here, in proxy we pass the request instance to the `request` library.
+
+  ### Details
+
+  - `async/await` sugar for getPackage()
+  - Improve and reuse code between current implementation and new fastify endpoint (add scaffolding for request manifest)
+  - Improve performance
+  - Add new tests
+
+  ### Breaking changes
+
+  All storage plugins will stop to work since the storage uses `getPackageNext` method which is Promise based, I won't replace this now because will force me to update all plugins, I'll follow up in another PR. Currently will throw http 500
+
+### Minor Changes
+
+- b13a3fef: refactor: improve versions and dist-tag filters
+
+### Patch Changes
+
+- Updated dependencies [a828271d]
+- Updated dependencies [24b9be02]
+- Updated dependencies [e75c0a3b]
+- Updated dependencies [b13a3fef]
+  - @verdaccio/tarball@11.0.0-6-next.11
+  - @verdaccio/local-storage@11.0.0-6-next.11
+  - @verdaccio/utils@6.0.0-6-next.10
+  - @verdaccio/core@6.0.0-6-next.4
+  - @verdaccio/logger@6.0.0-6-next.8
+  - @verdaccio/proxy@6.0.0-6-next.16
+  - @verdaccio/config@6.0.0-6-next.12
+  - @verdaccio/loaders@6.0.0-6-next.8
+  - @verdaccio/streams@11.0.0-6-next.5
+
+## 6.0.0-6-next.16
+
+### Minor Changes
+
+- f86c31ed: feat: migrate web sidebar endpoint to fastify
+
+  reuse utils methods between packages
+
+### Patch Changes
+
+- Updated dependencies [f86c31ed]
+  - @verdaccio/utils@6.0.0-6-next.9
+  - @verdaccio/config@6.0.0-6-next.11
+  - @verdaccio/local-storage@11.0.0-6-next.10
+  - @verdaccio/proxy@6.0.0-6-next.15
+  - @verdaccio/loaders@6.0.0-6-next.7
+
+## 6.0.0-6-next.15
+
+### Patch Changes
+
+- Updated dependencies [6c1eb021]
+  - @verdaccio/core@6.0.0-6-next.3
+  - @verdaccio/logger@6.0.0-6-next.7
+  - @verdaccio/config@6.0.0-6-next.10
+  - @verdaccio/loaders@6.0.0-6-next.7
+  - @verdaccio/local-storage@11.0.0-6-next.10
+  - @verdaccio/proxy@6.0.0-6-next.14
+  - @verdaccio/utils@6.0.0-6-next.8
+
+## 6.0.0-6-next.14
+
+### Major Changes
+
+- 794af76c: Remove Node 12 support
+
+  - We need move to the new `undici` and does not support Node.js 12
+
+### Minor Changes
+
+- b702ea36: abort search request support for proxy
+- 154b2ecd: refactor: remove @verdaccio/commons-api in favor @verdaccio/core and remove duplications
+
+### Patch Changes
+
+- Updated dependencies [794af76c]
+- Updated dependencies [b702ea36]
+- Updated dependencies [154b2ecd]
+  - @verdaccio/config@6.0.0-6-next.9
+  - @verdaccio/core@6.0.0-6-next.2
+  - @verdaccio/streams@11.0.0-6-next.5
+  - @verdaccio/loaders@6.0.0-6-next.6
+  - @verdaccio/logger@6.0.0-6-next.6
+  - @verdaccio/utils@6.0.0-6-next.7
+  - @verdaccio/proxy@6.0.0-6-next.13
+  - @verdaccio/local-storage@11.0.0-6-next.9
+
 ## 6.0.0-6-next.13
 
 ### Patch Changes

package/build/local-storage.d.ts

@@ -1,7 +1,7 @@
 /// <reference types="node" />
 import { PassThrough } from 'stream';
-import { searchUtils, pluginUtils } from '@verdaccio/core';
-import { Token, TokenFilter, Package, Config, IUploadTarball, IReadTarball, MergeTags, Version, Callback, Logger, CallbackAction, StringValue } from '@verdaccio/types';
+import { pluginUtils, searchUtils } from '@verdaccio/core';
+import { Callback, CallbackAction, Config, IReadTarball, IUploadTarball, Logger, MergeTags, Package, StringValue, Token, TokenFilter, Version } from '@verdaccio/types';
 export declare type IPluginStorage = pluginUtils.IPluginStorage<Config>;
 export declare function normalizeSearchPackage(pkg: Package, searchItem: searchUtils.SearchItem): searchUtils.SearchPackageBody;
 export declare const PROTO_NAME = "__proto__";
@@ -88,11 +88,13 @@ declare class LocalStorage {
      * @return {ReadTarball}
      */
     private _streamSuccessReadTarBall;
+    getPackageMetadataNext(name: string): Promise<Package>;
     /**
      * Retrieve a package by name.
      * @param {*} name
      * @param {*} callback
      * @return {Function}
+     * @deprecated
      */
     getPackageMetadata(name: string, callback?: Callback): void;
     search(searchStream: PassThrough, query: searchUtils.SearchQuery): Promise<void>;
@@ -106,8 +108,10 @@ declare class LocalStorage {
      * Read a json file from storage.
      * @param {Object} storage
      * @param {Function} callback
+     * @deprecated
      */
     private _readPackage;
+    private _readPackageNext;
     /**
      * Retrieve either a previous created local package or a boilerplate.
      * @param {*} pkgName

package/build/local-storage.js

@@ -3,35 +3,31 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.PROTO_NAME = exports.LocalStorage = void 0;
 exports.normalizeSearchPackage = normalizeSearchPackage;
-exports.LocalStorage = exports.PROTO_NAME = void 0;
 
 var _assert = _interopRequireDefault(require("assert"));
 
-var _url = _interopRequireDefault(require("url"));
+var _debug = _interopRequireDefault(require("debug"));
 
 var _lodash = _interopRequireDefault(require("lodash"));
 
-var _debug = _interopRequireDefault(require("debug"));
-
-var _utils = require("@verdaccio/utils");
+var _url = _interopRequireDefault(require("url"));
 
 var _core = require("@verdaccio/core");
 
-var _commonsApi = require("@verdaccio/commons-api");
-
 var _loaders = require("@verdaccio/loaders");
 
 var _localStorage = _interopRequireDefault(require("@verdaccio/local-storage"));
 
 var _streams = require("@verdaccio/streams");
 
+var _utils = require("@verdaccio/utils");
+
 var _storageUtils = require("./storage-utils");
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
 const debug = (0, _debug.default)('verdaccio:storage:local');
 
 function normalizeSearchPackage(pkg, searchItem) {
@@ -75,12 +71,6 @@ exports.PROTO_NAME = PROTO_NAME;
 
 class LocalStorage {
   constructor(config, logger) {
-    _defineProperty(this, "config", void 0);
-
-    _defineProperty(this, "storagePlugin", void 0);
-
-    _defineProperty(this, "logger", void 0);
-
     debug('local storage created');
     this.logger = logger.child({
       sub: 'fs'
@@ -110,13 +100,13 @@ class LocalStorage {
 
     if (_lodash.default.isNil(storage)) {
       debug(`storage is missing for %o package cannot be added`, name);
-      return callback(_utils.ErrorCode.getNotFound('this package cannot be added'));
+      return callback(_core.errorUtils.getNotFound('this package cannot be added'));
     }
 
     storage.createPackage(name, (0, _storageUtils.generatePackageTemplate)(name), err => {
-      if (_lodash.default.isNull(err) === false && (err.code === _storageUtils.STORAGE.FILE_EXIST_ERROR || err.code === _commonsApi.HTTP_STATUS.CONFLICT)) {
+      if (_lodash.default.isNull(err) === false && (err.code === _storageUtils.STORAGE.FILE_EXIST_ERROR || err.code === _core.HTTP_STATUS.CONFLICT)) {
         debug(`error on creating a package for %o with error %o`, name, err.message);
-        return callback(_utils.ErrorCode.getConflict());
+        return callback(_core.errorUtils.getConflict());
       }
 
       const latest = (0, _utils.getLatestVersion)(pkg);
@@ -141,15 +131,15 @@ class LocalStorage {
     const storage = this._getLocalStorage(name);
 
     if (_lodash.default.isNil(storage)) {
-      throw _utils.ErrorCode.getNotFound();
+      throw _core.errorUtils.getNotFound();
     }
 
     return new Promise((resolve, reject) => {
       storage.readPackage(name, async (err, data) => {
         if (_lodash.default.isNil(err) === false) {
-          if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _commonsApi.HTTP_STATUS.NOT_FOUND) {
+          if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
             debug(`error on not found %o with error %o`, name, err.message);
-            return reject(_utils.ErrorCode.getNotFound());
+            return reject(_core.errorUtils.getNotFound());
           }
 
           return reject(err);
@@ -179,7 +169,7 @@ class LocalStorage {
           this.logger.error({
             err
           }, 'removed package has failed @{err.message}');
-          throw _utils.ErrorCode.getBadData(err.message);
+          throw _core.errorUtils.getBadData(err.message);
         }
       });
     });
@@ -219,7 +209,7 @@ class LocalStorage {
 
           version = (0, _storageUtils.cleanUpReadme)(version);
           debug('clean up readme for %o', versionId);
-          version.contributors = (0, _storageUtils.normalizeContributors)(version.contributors);
+          version.contributors = (0, _utils.normalizeContributors)(version.contributors);
           change = true;
           packageLocalJson.versions[versionId] = version;
 
@@ -245,10 +235,10 @@ class LocalStorage {
 
       debug('update dist-tags');
 
-      for (const tag in packageInfo[_commonsApi.DIST_TAGS]) {
-        if (!packageLocalJson[_commonsApi.DIST_TAGS][tag] || packageLocalJson[_commonsApi.DIST_TAGS][tag] !== packageInfo[_commonsApi.DIST_TAGS][tag]) {
+      for (const tag in packageInfo[_core.DIST_TAGS]) {
+        if (!packageLocalJson[_core.DIST_TAGS][tag] || packageLocalJson[_core.DIST_TAGS][tag] !== packageInfo[_core.DIST_TAGS][tag]) {
           change = true;
-          packageLocalJson[_commonsApi.DIST_TAGS][tag] = packageInfo[_commonsApi.DIST_TAGS][tag];
+          packageLocalJson[_core.DIST_TAGS][tag] = packageInfo[_core.DIST_TAGS][tag];
         }
       }
 
@@ -301,13 +291,13 @@ class LocalStorage {
       debug('%s` readme mutated', name); // TODO: lodash remove
 
       metadata = (0, _storageUtils.cleanUpReadme)(metadata);
-      metadata.contributors = (0, _storageUtils.normalizeContributors)(metadata.contributors);
+      metadata.contributors = (0, _utils.normalizeContributors)(metadata.contributors);
       debug('%s` contributors normalized', name);
       const hasVersion = data.versions[version] != null;
 
       if (hasVersion) {
         debug('%s version %s already exists', name, version);
-        return cb(_utils.ErrorCode.getConflict());
+        return cb(_core.errorUtils.getConflict());
       } // if uploaded tarball has a different shasum, it's very likely that we
       // have some kind of error
 
@@ -319,7 +309,7 @@ class LocalStorage {
           if (_lodash.default.isNil(data._attachments[tarball].shasum) === false && _lodash.default.isNil(metadata.dist.shasum) === false) {
             if (data._attachments[tarball].shasum != metadata.dist.shasum) {
               const errorMessage = `shasum error, ` + `${data._attachments[tarball].shasum} != ${metadata.dist.shasum}`;
-              return cb(_utils.ErrorCode.getBadRequest(errorMessage));
+              return cb(_core.errorUtils.getBadRequest(errorMessage));
             }
           }
 
@@ -348,7 +338,7 @@ class LocalStorage {
         await this.storagePlugin.add(name);
         cb();
       } catch (err) {
-        cb(_utils.ErrorCode.getBadData(err.message));
+        cb(_core.errorUtils.getBadData(err.message));
       }
     }, callback);
   }
@@ -368,12 +358,12 @@ class LocalStorage {
       for (const tag in tags) {
         // this handle dist-tag rm command
         if (_lodash.default.isNull(tags[tag])) {
-          delete data[_commonsApi.DIST_TAGS][tag];
+          delete data[_core.DIST_TAGS][tag];
           continue;
         }
 
         if (_lodash.default.isNil(data.versions[tags[tag]])) {
-          return cb(_utils.ErrorCode.getNotFound(_commonsApi.API_ERROR.VERSION_NOT_EXIST));
+          return cb(_core.errorUtils.getNotFound(_core.API_ERROR.VERSION_NOT_EXIST));
         }
 
         const version = tags[tag];
@@ -397,9 +387,9 @@ class LocalStorage {
   changePackage(name, incomingPkg, revision, callback) {
     debug(`change package tags for %o revision %s`, name, revision);
 
-    if (!_core.validatioUtils.isObject(incomingPkg.versions) || !_core.validatioUtils.isObject(incomingPkg[_commonsApi.DIST_TAGS])) {
+    if (!_core.validatioUtils.isObject(incomingPkg.versions) || !_core.validatioUtils.isObject(incomingPkg[_core.DIST_TAGS])) {
       debug(`change package bad data for %o`, name);
-      return callback(_utils.ErrorCode.getBadData());
+      return callback(_core.errorUtils.getBadData());
     }
 
     debug(`change package udapting package for %o`, name);
@@ -445,8 +435,8 @@ class LocalStorage {
         }
       }
 
-      localData[_commonsApi.USERS] = incomingPkg[_commonsApi.USERS];
-      localData[_commonsApi.DIST_TAGS] = incomingPkg[_commonsApi.DIST_TAGS];
+      localData[_core.USERS] = incomingPkg[_core.USERS];
+      localData[_core.DIST_TAGS] = incomingPkg[_core.DIST_TAGS];
       cb(null);
     }, function (err) {
       if (err) {
@@ -475,7 +465,7 @@ class LocalStorage {
         delete data._attachments[filename];
         cb(null);
       } else {
-        cb(_utils.ErrorCode.getNotFound('no such file available'));
+        cb(_core.errorUtils.getNotFound('no such file available'));
       }
     }, err => {
       if (err) {
@@ -499,7 +489,7 @@ class LocalStorage {
           return callback(null);
         });
       } else {
-        callback(_utils.ErrorCode.getInternalError());
+        callback(_core.errorUtils.getInternalError());
       }
     });
   }
@@ -537,7 +527,7 @@ class LocalStorage {
 
     if (name === PROTO_NAME) {
       process.nextTick(() => {
-        uploadStream.emit('error', _utils.ErrorCode.getForbidden());
+        uploadStream.emit('error', _core.errorUtils.getForbidden());
       });
       return uploadStream;
     } // FIXME: this condition will never met, storage is always defined
@@ -553,10 +543,10 @@ class LocalStorage {
     const writeStream = storage.writeTarball(filename);
     writeStream.on('error', err => {
       // @ts-ignore
-      if (err.code === _storageUtils.STORAGE.FILE_EXIST_ERROR || err.code === _commonsApi.HTTP_STATUS.CONFLICT) {
-        uploadStream.emit('error', _utils.ErrorCode.getConflict());
+      if (err.code === _storageUtils.STORAGE.FILE_EXIST_ERROR || err.code === _core.HTTP_STATUS.CONFLICT) {
+        uploadStream.emit('error', _core.errorUtils.getConflict());
         uploadStream.abort(); // @ts-ignore
-      } else if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _commonsApi.HTTP_STATUS.NOT_FOUND) {
+      } else if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
         // check if package exists to throw an appropriate message
         this.getPackageMetadata(name, function (_err) {
           if (_err) {
@@ -597,7 +587,7 @@ class LocalStorage {
 
     uploadStream.done = function () {
       if (!length) {
-        uploadStream.emit('error', _utils.ErrorCode.getBadData('refusing to accept zero-length file'));
+        uploadStream.emit('error', _core.errorUtils.getBadData('refusing to accept zero-length file'));
         writeStream.abort();
       } else {
         writeStream.done();
@@ -636,7 +626,7 @@ class LocalStorage {
   _createFailureStreamResponse() {
     const stream = new _streams.ReadTarball({});
     process.nextTick(() => {
-      stream.emit('error', _utils.ErrorCode.getNotFound('no such file available'));
+      stream.emit('error', _core.errorUtils.getNotFound('no such file available'));
     });
     return stream;
   }
@@ -652,7 +642,7 @@ class LocalStorage {
   _streamSuccessReadTarBall(storage, filename) {
     const stream = new _streams.ReadTarball({});
     const readTarballStream = storage.readTarball(filename);
-    const e404 = _utils.ErrorCode.getNotFound;
+    const e404 = _core.errorUtils.getNotFound;
 
     stream.abort = function () {
       if (_lodash.default.isNil(readTarballStream) === false) {
@@ -662,7 +652,7 @@ class LocalStorage {
 
     readTarballStream.on('error', function (err) {
       // @ts-ignore
-      if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _commonsApi.HTTP_STATUS.NOT_FOUND) {
+      if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
         stream.emit('error', e404('no such file available'));
       } else {
         stream.emit('error', err);
@@ -678,11 +668,26 @@ class LocalStorage {
     });
     return stream;
   }
+
+  async getPackageMetadataNext(name) {
+    const storage = this._getLocalStorage(name);
+
+    debug('get package metadata for %o', name);
+
+    if (typeof storage === 'undefined') {
+      // TODO: this might be a better an error to throw
+      // if storage is not there cannot be 404.
+      throw _core.errorUtils.getNotFound();
+    }
+
+    return await this._readPackageNext(name, storage);
+  }
   /**
    * Retrieve a package by name.
    * @param {*} name
    * @param {*} callback
    * @return {Function}
+   * @deprecated
    */
 
 
@@ -692,7 +697,7 @@ class LocalStorage {
     debug('get package metadata for %o', name);
 
     if (typeof storage === 'undefined') {
-      return callback(_utils.ErrorCode.getNotFound());
+      return callback(_core.errorUtils.getNotFound());
     }
 
     this._readPackage(name, storage, callback);
@@ -778,15 +783,16 @@ class LocalStorage {
    * Read a json file from storage.
    * @param {Object} storage
    * @param {Function} callback
+   * @deprecated
    */
 
 
   _readPackage(name, storage, callback) {
     storage.readPackage(name, (err, result) => {
       if (err) {
-        if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _commonsApi.HTTP_STATUS.NOT_FOUND) {
+        if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
           debug('package %s not found', name);
-          return callback(_utils.ErrorCode.getNotFound());
+          return callback(_core.errorUtils.getNotFound());
         }
 
         return callback(this._internalError(err, _storageUtils.STORAGE.PACKAGE_FILE_NAME, 'error reading'));
@@ -795,6 +801,24 @@ class LocalStorage {
       callback(err, (0, _storageUtils.normalizePackage)(result));
     });
   }
+
+  async _readPackageNext(name, storage) {
+    try {
+      const result = await storage.readPackageNext(name);
+      return (0, _storageUtils.normalizePackage)(result);
+    } catch (err) {
+      if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
+        debug('package %s not found', name);
+        throw _core.errorUtils.getNotFound();
+      }
+
+      this.logger.error({
+        err: err,
+        file: _storageUtils.STORAGE.PACKAGE_FILE_NAME
+      }, `error reading  @{file}: @{!err.message}`);
+      throw _core.errorUtils.getInternalError();
+    }
+  }
   /**
    * Retrieve either a previous created local package or a boilerplate.
    * @param {*} pkgName
@@ -815,7 +839,7 @@ class LocalStorage {
     storage.readPackage(pkgName, (err, data) => {
       // TODO: race condition
       if (_lodash.default.isNil(err) === false) {
-        if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _commonsApi.HTTP_STATUS.NOT_FOUND) {
+        if (err.code === _storageUtils.STORAGE.NO_SUCH_FILE_ERROR || err.code === _core.HTTP_STATUS.NOT_FOUND) {
           data = (0, _storageUtils.generatePackageTemplate)(pkgName);
         } else {
           return callback(this._internalError(err, _storageUtils.STORAGE.PACKAGE_FILE_NAME, 'error reading'));
@@ -843,7 +867,7 @@ class LocalStorage {
       err: err,
       file: file
     }, `${message}  @{file}: @{!err.message}`);
-    return _utils.ErrorCode.getInternalError();
+    return _core.errorUtils.getInternalError();
   }
   /**
    * @param {*} name package name
@@ -857,7 +881,7 @@ class LocalStorage {
     const storage = this._getLocalStorage(name);
 
     if (!storage) {
-      return callback(_utils.ErrorCode.getNotFound());
+      return callback(_core.errorUtils.getNotFound());
     }
 
     storage.updatePackage(name, updateHandler, this._writePackage.bind(this), _storageUtils.normalizePackage, callback);
@@ -965,7 +989,7 @@ class LocalStorage {
 
   saveToken(token) {
     if (_lodash.default.isFunction(this.storagePlugin.saveToken) === false) {
-      return Promise.reject(_utils.ErrorCode.getCode(_commonsApi.HTTP_STATUS.SERVICE_UNAVAILABLE, _commonsApi.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
+      return Promise.reject(_core.errorUtils.getCode(_core.HTTP_STATUS.SERVICE_UNAVAILABLE, _core.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
     }
 
     return this.storagePlugin.saveToken(token);
@@ -973,7 +997,7 @@ class LocalStorage {
 
   deleteToken(user, tokenKey) {
     if (_lodash.default.isFunction(this.storagePlugin.deleteToken) === false) {
-      return Promise.reject(_utils.ErrorCode.getCode(_commonsApi.HTTP_STATUS.SERVICE_UNAVAILABLE, _commonsApi.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
+      return Promise.reject(_core.errorUtils.getCode(_core.HTTP_STATUS.SERVICE_UNAVAILABLE, _core.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
     }
 
     return this.storagePlugin.deleteToken(user, tokenKey);
@@ -981,7 +1005,7 @@ class LocalStorage {
 
   readTokens(filter) {
     if (_lodash.default.isFunction(this.storagePlugin.readTokens) === false) {
-      return Promise.reject(_utils.ErrorCode.getCode(_commonsApi.HTTP_STATUS.SERVICE_UNAVAILABLE, _commonsApi.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
+      return Promise.reject(_core.errorUtils.getCode(_core.HTTP_STATUS.SERVICE_UNAVAILABLE, _core.SUPPORT_ERRORS.PLUGIN_MISSING_INTERFACE));
     }
 
     return this.storagePlugin.readTokens(filter);