@verdaccio/auth 6.0.0-6-next.26 → 6.0.0-6-next.28

package/test/auth-utils.spec.ts

@@ -24,7 +24,6 @@ import type { AllowActionCallbackResponse } from '@verdaccio/utils';
 import {
   ActionsAllowed,
   Auth,
-  IAuth,
   aesDecrypt,
   allow_action,
   getApiToken,
@@ -70,7 +69,8 @@ describe('Auth utilities', () => {
     methodNotBeenCalled: string
   ): Promise<string> {
     const config: Config = getConfig(configFileName, secret);
-    const auth: IAuth = new Auth(config);
+    const auth: Auth = new Auth(config);
+    await auth.init();
     // @ts-ignore
     const spy = jest.spyOn(auth, methodToSpy);
     // @ts-ignore
@@ -408,7 +408,8 @@ describe('Auth utilities', () => {
       test.concurrent('should return empty credential corrupted payload', async () => {
         const secret = 'b2df428b9929d3ace7c598bbf4e496b2';
         const config: Config = getConfig('security-legacy', secret);
-        const auth: IAuth = new Auth(config);
+        const auth: Auth = new Auth(config);
+        await auth.init();
         const token = auth.aesEncrypt(null);
         const security: Security = config.security;
         const credentials = getMiddlewareCredentials(

package/test/auth.spec.ts

@@ -1,7 +1,6 @@
-import _ from 'lodash';
+import path from 'path';
 
-import { IAuth } from '@verdaccio/auth';
-import { Config as AppConfig, ROLES } from '@verdaccio/config';
+import { Config as AppConfig, ROLES, getDefaultConfig } from '@verdaccio/config';
 import { errorUtils } from '@verdaccio/core';
 import { setup } from '@verdaccio/logger';
 import { Config } from '@verdaccio/types';
@@ -9,25 +8,34 @@ import { Config } from '@verdaccio/types';
 import { Auth } from '../src';
 import { authPluginFailureConf, authPluginPassThrougConf, authProfileConf } from './helper/plugin';
 
-setup([]);
+setup({});
 
 describe('AuthTest', () => {
-  test('should be defined', () => {
-    const config: Config = new AppConfig(_.cloneDeep(authProfileConf));
+  test('should init correctly', async () => {
+    const config: Config = new AppConfig({ ...authProfileConf });
     config.checkSecretKey('12345');
 
-    const auth: IAuth = new Auth(config);
+    const auth: Auth = new Auth(config);
+    await auth.init();
+    expect(auth).toBeDefined();
+  });
+
+  test('should load default auth plugin', async () => {
+    const config: Config = new AppConfig({ ...authProfileConf, auth: undefined });
+    config.checkSecretKey('12345');
 
+    const auth: Auth = new Auth(config);
+    await auth.init();
     expect(auth).toBeDefined();
   });
 
   describe('test authenticate method', () => {
     describe('test authenticate states', () => {
-      test('should be a success login', () => {
-        const config: Config = new AppConfig(_.cloneDeep(authProfileConf));
+      test('should be a success login', async () => {
+        const config: Config = new AppConfig({ ...authProfileConf });
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -50,11 +58,11 @@ describe('AuthTest', () => {
         });
       });
 
-      test('should be a fail on login', () => {
+      test('should be a fail on login', async () => {
         const config: Config = new AppConfig(authPluginFailureConf);
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -69,11 +77,11 @@ describe('AuthTest', () => {
     // that might make break the request
     // the @ts-ignore below are intended
     describe('test authenticate out of control inputs from plugins', () => {
-      test('should skip falsy values', () => {
-        const config: Config = new AppConfig(_.cloneDeep(authPluginPassThrougConf));
+      test('should skip falsy values', async () => {
+        const config: Config = new AppConfig({ ...authPluginPassThrougConf });
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -89,11 +97,11 @@ describe('AuthTest', () => {
         }
       });
 
-      test('should error truthy non-array', () => {
-        const config: Config = new AppConfig(_.cloneDeep(authPluginPassThrougConf));
+      test('should error truthy non-array', async () => {
+        const config: Config = new AppConfig({ ...authPluginPassThrougConf });
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -107,11 +115,11 @@ describe('AuthTest', () => {
         }
       });
 
-      test('should skip empty array', () => {
-        const config: Config = new AppConfig(_.cloneDeep(authPluginPassThrougConf));
+      test('should skip empty array', async () => {
+        const config: Config = new AppConfig({ ...authPluginPassThrougConf });
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -124,11 +132,11 @@ describe('AuthTest', () => {
         expect(callback.mock.calls[0][1]).toBeUndefined();
       });
 
-      test('should accept valid array', () => {
-        const config: Config = new AppConfig(_.cloneDeep(authPluginPassThrougConf));
+      test('should accept valid array', async () => {
+        const config: Config = new AppConfig({ ...authPluginPassThrougConf });
         config.checkSecretKey('12345');
-        const auth: IAuth = new Auth(config);
-
+        const auth: Auth = new Auth(config);
+        await auth.init();
         expect(auth).toBeDefined();
 
         const callback = jest.fn();
@@ -144,4 +152,31 @@ describe('AuthTest', () => {
       });
     });
   });
+
+  describe('test multiple authenticate methods', () => {
+    test('should skip falsy values', async () => {
+      const config: Config = new AppConfig({
+        ...getDefaultConfig(),
+        plugins: path.join(__dirname, './partials/plugin'),
+        auth: {
+          success: {},
+          'fail-invalid-method': {},
+        },
+      });
+      config.checkSecretKey('12345');
+      const auth: Auth = new Auth(config);
+      await auth.init();
+
+      return new Promise((resolve) => {
+        auth.authenticate('foo', 'bar', (err, value) => {
+          expect(value).toEqual({
+            name: 'foo',
+            groups: ['test', '$all', '$authenticated', '@all', '@authenticated', 'all'],
+            real_groups: ['test'],
+          });
+          resolve(value);
+        });
+      });
+    });
+  });
 });

package/test/helper/plugin.ts

@@ -4,21 +4,32 @@ import { getDefaultConfig } from '@verdaccio/config';
 
 export const authProfileConf = {
   ...getDefaultConfig(),
+  plugins: path.join(__dirname, '../partials/plugin'),
   auth: {
-    [`${path.join(__dirname, '../partials/plugin/authenticate.success')}`]: {},
+    success: {},
   },
 };
 
 export const authPluginFailureConf = {
   ...getDefaultConfig(),
+  plugins: path.join(__dirname, '../partials/plugin'),
   auth: {
-    [`${path.join(__dirname, '../partials/plugin/authenticate.fail.js')}`]: {},
+    fail: {},
   },
 };
 
 export const authPluginPassThrougConf = {
   ...getDefaultConfig(),
+  plugins: path.join(__dirname, '../partials/plugin'),
   auth: {
-    [`${path.join(__dirname, '../partials/plugin/authenticate.passthroug')}`]: {},
+    passthroug: {},
+  },
+};
+
+export const authFailInvalidMethod = {
+  ...getDefaultConfig(),
+  plugins: path.join(__dirname, '../partials/plugin'),
+  auth: {
+    'fail-invalid-method': {},
   },
 };

package/test/partials/plugin/verdaccio-fail/fail.js

@@ -0,0 +1,11 @@
+const { errorUtils } = require('@verdaccio/core');
+
+module.exports = function () {
+  return {
+    authenticate(user, pass, callback) {
+      /* user and pass are used here to forward errors
+      and success types respectively for testing purposes */
+      callback(errorUtils.getInternalError(), false);
+    },
+  };
+};

package/test/partials/plugin/verdaccio-fail/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "verdaccio-fail",
+  "main": "fail.js",
+  "version": "1.0.0"
+}

package/test/partials/plugin/verdaccio-fail-invalid-method/fail.js

@@ -0,0 +1,11 @@
+const { errorUtils } = require('@verdaccio/core');
+
+module.exports = function () {
+  return {
+    authenticateFake(user, pass, callback) {
+      /* user and pass are used here to forward errors
+      and success types respectively for testing purposes */
+      callback(errorUtils.getInternalError(), false);
+    },
+  };
+};

package/test/partials/plugin/verdaccio-fail-invalid-method/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "verdaccio-fail",
+  "main": "fail.js",
+  "version": "1.0.0"
+}

package/test/partials/plugin/verdaccio-passthroug/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "verdaccio-passthroug",
+  "main": "passthroug.js",
+  "version": "1.0.0"
+}

package/test/partials/plugin/verdaccio-success/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "verdaccio-success",
+  "main": "success.js",
+  "version": "1.0.0"
+}

package/tsconfig.build.json

@@ -2,8 +2,8 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "rootDir": "./src",
-    "outDir": "./build"
+    "outDir": "./build",
+    "noImplicitAny": false
   },
-  "include": ["src/**/*"],
-  "exclude": ["src/**/*.test.ts"]
+  "include": ["src/**/*"]
 }

package/tsconfig.json

@@ -2,25 +2,25 @@
   "extends": "../../tsconfig.reference",
   "compilerOptions": {
     "rootDir": "./src",
-    "outDir": "./build"
+    "outDir": "./build",
+    "noImplicitAny": true
   },
   "include": ["src/**/*.ts"],
-  "exclude": ["src/**/*.test.ts"],
   "references": [
     {
       "path": "../config"
     },
     {
-      "path": "../core/htpasswd"
+      "path": "../plugins/htpasswd"
     },
     {
-      "path": "../loaders"
+      "path": "../core/core"
     },
     {
-      "path": "../logger"
+      "path": "../loaders"
     },
     {
-      "path": "../mock"
+      "path": "../logger"
     },
     {
       "path": "../utils"

package/test/partials/plugin/authenticate.fail.js

@@ -1,11 +0,0 @@
-import { errorUtils } from '@verdaccio/core';
-
-module.exports = function () {
-  return {
-    authenticate(user, pass, callback) {
-      // we return an 500 error, the second argument must be false.
-      // https://verdaccio.org/docs/en/dev-plugins#onerror
-      callback(errorUtils.getInternalError(), false);
-    },
-  };
-};