@vercel/go 2.1.0 → 2.2.1

package/dist/analyze.go

@@ -197,7 +197,9 @@ func main() {
 			// find a valid `http.HandlerFunc` handler function
 			params := rf[fn.Type.Params.Pos()-offset : fn.Type.Params.End()-offset]
 			validHandlerFunc := (strings.Contains(string(params), "http.ResponseWriter") &&
-				strings.Contains(string(params), "*http.Request") && len(fn.Type.Params.List) == 2)
+				strings.Contains(string(params), "*http.Request") &&
+				len(fn.Type.Params.List) == 2 &&
+				(fn.Recv == nil || len(fn.Recv.List) == 0))
 
 			if validHandlerFunc {
 				// we found the first exported function with `http.HandlerFunc`
@@ -223,7 +225,7 @@ func main() {
 		if fn.Name.IsExported() == true {
 			for _, param := range fn.Type.Params.List {
 				paramStr := fmt.Sprintf("%s", param.Type)
-				if strings.Contains(string(paramStr), "http ResponseWriter") && len(fn.Type.Params.List) == 2 {
+				if strings.Contains(string(paramStr), "http ResponseWriter") && len(fn.Type.Params.List) == 2 && (fn.Recv == nil || len(fn.Recv.List) == 0) {
 					analyzed := analyze{
 						PackageName: parsed.Name.Name,
 						FuncName:    fn.Name.Name,

package/dist/index.js

@@ -17875,6 +17875,9 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
             throw new Error('Please change `package main` to `package handler`');
         }
         const outDir = await build_utils_1.getWriteableDirectory();
+        // in order to allow the user to have `main.go`,
+        // we need our `main.go` to be called something else
+        const mainGoFileName = 'main__vc__go__.go';
         if (packageName !== 'main') {
             const go = await go_helpers_1.createGo(workPath, goPath, process.platform, process.arch, {
                 cwd: entrypointDirname,
@@ -17898,7 +17901,6 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
                     throw err;
                 }
             }
-            const mainModGoFileName = 'main.go';
             const modMainGoContents = await fs_extra_1.readFile(__webpack_require__.ab + "main.go", 'utf8');
             let goPackageName = `${packageName}/${packageName}`;
             const goFuncName = `${packageName}.${handlerFunctionName}`;
@@ -17919,26 +17921,26 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
                 .replace('__VC_HANDLER_FUNC_NAME', goFuncName);
             if (isGoModExist && isGoModInRootDir) {
                 build_utils_1.debug('[mod-root] Write main file to ' + downloadPath);
-                await fs_extra_1.writeFile(path_1.join(downloadPath, mainModGoFileName), mainModGoContents);
+                await fs_extra_1.writeFile(path_1.join(downloadPath, mainGoFileName), mainModGoContents);
                 undoFileActions.push({
                     to: undefined,
-                    from: path_1.join(downloadPath, mainModGoFileName),
+                    from: path_1.join(downloadPath, mainGoFileName),
                 });
             }
             else if (isGoModExist && !isGoModInRootDir) {
                 build_utils_1.debug('[mod-other] Write main file to ' + goModPath);
-                await fs_extra_1.writeFile(path_1.join(goModPath, mainModGoFileName), mainModGoContents);
+                await fs_extra_1.writeFile(path_1.join(goModPath, mainGoFileName), mainModGoContents);
                 undoFileActions.push({
                     to: undefined,
-                    from: path_1.join(goModPath, mainModGoFileName),
+                    from: path_1.join(goModPath, mainGoFileName),
                 });
             }
             else {
                 build_utils_1.debug('[entrypoint] Write main file to ' + entrypointDirname);
-                await fs_extra_1.writeFile(path_1.join(entrypointDirname, mainModGoFileName), mainModGoContents);
+                await fs_extra_1.writeFile(path_1.join(entrypointDirname, mainGoFileName), mainModGoContents);
                 undoFileActions.push({
                     to: undefined,
-                    from: path_1.join(entrypointDirname, mainModGoFileName),
+                    from: path_1.join(entrypointDirname, mainGoFileName),
                 });
             }
             // move user go file to folder
@@ -17985,7 +17987,7 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
             build_utils_1.debug('Running `go build`...');
             const destPath = path_1.join(outDir, handlerFileName);
             try {
-                const src = [path_1.join(baseGoModPath, mainModGoFileName)];
+                const src = [path_1.join(baseGoModPath, mainGoFileName)];
                 await go.build(src, destPath);
             }
             catch (err) {
@@ -18004,9 +18006,6 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
             const mainGoContents = originalMainGoContents
                 .replace('"__VC_HANDLER_PACKAGE_NAME"', '')
                 .replace('__VC_HANDLER_FUNC_NAME', handlerFunctionName);
-            // in order to allow the user to have `main.go`,
-            // we need our `main.go` to be called something else
-            const mainGoFileName = 'main__vc__go__.go';
             // Go doesn't like to build files in different directories,
             // so now we place `main.go` together with the user code
             await fs_extra_1.writeFile(path_1.join(entrypointDirname, mainGoFileName), mainGoContents);
@@ -18075,8 +18074,14 @@ async function build({ files, entrypoint, config, workPath, meta = {}, }) {
 exports.build = build;
 async function renameHandlerFunction(fsPath, from, to) {
     let fileContents = await fs_extra_1.readFile(fsPath, 'utf8');
-    const fromRegex = new RegExp(`\\b${from}\\b`, 'g');
-    fileContents = fileContents.replace(fromRegex, to);
+    // This regex has to walk a fine line where it replaces the most-likely occurrences
+    // of the handler's identifier without clobbering other syntax.
+    // Left-hand Side: A single space was chosen because it can catch `func Handler`
+    //   as well as `var _ http.HandlerFunc = Index`.
+    // Right-hand Side: a word boundary was chosen because this can be an end of line
+    //   or an open paren (as in `func Handler(`).
+    const fromRegex = new RegExp(String.raw ` ${from}\b`, 'g');
+    fileContents = fileContents.replace(fromRegex, ` ${to}`);
     await fs_extra_1.writeFile(fsPath, fileContents);
 }
 function getNewHandlerFunctionName(originalFunctionName, entrypoint) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vercel/go",
-  "version": "2.1.0",
+  "version": "2.2.1",
   "license": "MIT",
   "main": "./dist/index",
   "homepage": "https://vercel.com/docs/runtimes#official-runtimes/go",
@@ -35,7 +35,7 @@
     "@types/jest": "28.1.6",
     "@types/node-fetch": "^2.3.0",
     "@types/tar": "^4.0.0",
-    "@vercel/build-utils": "5.3.0",
+    "@vercel/build-utils": "5.3.1",
     "@vercel/ncc": "0.24.0",
     "async-retry": "1.3.1",
     "execa": "^1.0.0",
@@ -45,5 +45,5 @@
     "tar": "4.4.6",
     "typescript": "4.3.4"
   },
-  "gitHead": "31f79c7de1944420b1f6fa5be9235c9b3f1d62b6"
+  "gitHead": "352cd00ef093be6549ddc260803aca1c2ecdc63c"
 }