@vercel/flags-core 1.8.2 → 1.8.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @vercel/flags-core
 
+## 1.8.3
+
+### Patch Changes
+
+- [#507](https://github.com/vercel/flags/pull/507) [`c43b9d9`](https://github.com/vercel/flags/commit/c43b9d9076009a6a70ca2de55020ebcb15b1a4cc) Thanks [@luismeyer](https://github.com/luismeyer)! - Retry transient datafile fetch failures across polling, build loading, and offline fallback reads. Fetches use up to three attempts within a shared ten-second deadline that includes authentication, backoff, and body parsing. Shutdown also cancels retries during polling initialization.
+
+- [#533](https://github.com/vercel/flags/pull/533) [`7027cb2`](https://github.com/vercel/flags/commit/7027cb271183566ee224c6a96d36cb12ce7cf2fa) Thanks [@dferber90](https://github.com/dferber90)! - Strip all occurrences of the `g` and `y` flags from regex conditions so cached regular expressions produce consistent results across users and repeated evaluations, including when both flags are present.
+
 ## 1.8.2
 
 ### Patch Changes

package/dist/{chunk-AMDRNXFQ.js → chunk-NPKDNJX6.js}

@@ -73,7 +73,7 @@ function getSplitBoundaries(outcome) {
 function getCompiledRegex(rhs) {
   const cached = compiledRegexCache.get(rhs);
   if (cached) return cached;
-  const compiled = new RegExp(rhs.pattern, rhs.flags.replace(/[gy]/, ""));
+  const compiled = new RegExp(rhs.pattern, rhs.flags.replace(/[gy]/g, ""));
   compiledRegexCache.set(rhs, compiled);
   return compiled;
 }
@@ -576,7 +576,7 @@ function bulkEvaluate(flags, shared) {
 }
 
 // package.json
-var version = "1.8.2";
+var version = "1.8.3";
 
 // src/lib/report-value.ts
 function internalReportValue(key, value, data) {
@@ -1526,40 +1526,86 @@ var BundledSource = class {
 
 // src/controller/fetch-datafile.ts
 var DEFAULT_FETCH_TIMEOUT_MS = 1e4;
+var DEFAULT_MAX_ATTEMPTS = 3;
+var DatafileHttpError = class extends Error {
+  constructor(status, statusText) {
+    super(`Failed to fetch data: ${statusText}`);
+    this.status = status;
+  }
+  status;
+  get retryable() {
+    return this.status === 408 || this.status === 429 || this.status >= 500;
+  }
+};
 async function fetchDatafile(options) {
-  const token = await options.auth.resolveToken();
+  options.signal?.throwIfAborted();
+  const maxAttempts = options.maxAttempts ?? DEFAULT_MAX_ATTEMPTS;
+  if (!Number.isInteger(maxAttempts) || maxAttempts < 1) {
+    throw new Error("maxAttempts must be a positive integer");
+  }
   const controller = new AbortController();
+  const { signal } = controller;
+  let rejectAbort;
+  const aborted = new Promise((_, reject) => {
+    rejectAbort = reject;
+  });
+  const onAbort = () => rejectAbort(signal.reason);
+  signal.addEventListener("abort", onAbort, { once: true });
+  const onExternalAbort = () => controller.abort(options.signal?.reason);
+  options.signal?.addEventListener("abort", onExternalAbort, { once: true });
   const timeoutId = setTimeout(
-    () => controller.abort(),
+    () => controller.abort(
+      new Error("@vercel/flags-core: Datafile fetch deadline exceeded")
+    ),
     DEFAULT_FETCH_TIMEOUT_MS
   );
-  const onExternalAbort = () => controller.abort();
-  if (options.signal) {
-    if (options.signal.aborted) {
-      clearTimeout(timeoutId);
-      throw new Error("Fetch aborted");
-    }
-    options.signal.addEventListener("abort", onExternalAbort, { once: true });
-  }
-  try {
+  let delay;
+  const fetchAttempt = async () => {
+    const token = await options.auth.resolveToken();
+    signal.throwIfAborted();
     const res = await options.fetch(`${options.host}/v1/datafile`, {
       headers: {
         Authorization: `Bearer ${token}`,
         "User-Agent": `VercelFlagsCore/${version}`,
         ...process.env.VERCEL_ENV ? { "X-Vercel-Env": process.env.VERCEL_ENV } : null
       },
-      signal: controller.signal
+      signal
     });
-    clearTimeout(timeoutId);
-    options.signal?.removeEventListener("abort", onExternalAbort);
+    signal.throwIfAborted();
     if (!res.ok) {
-      throw new Error(`Failed to fetch data: ${res.statusText}`);
+      void res.body?.cancel().catch(() => {
+      });
+      throw new DatafileHttpError(res.status, res.statusText);
     }
-    return res.json();
-  } catch (error) {
+    const data = await res.json();
+    signal.throwIfAborted();
+    return data;
+  };
+  try {
+    for (let attempt = 0; ; attempt++) {
+      if (attempt > 0) {
+        await Promise.race([
+          new Promise((resolve) => {
+            delay = setTimeout(resolve, 100 * 2 ** (attempt - 1));
+          }),
+          aborted
+        ]);
+      }
+      signal.throwIfAborted();
+      try {
+        return await Promise.race([fetchAttempt(), aborted]);
+      } catch (error) {
+        signal.throwIfAborted();
+        if (attempt === maxAttempts - 1 || error instanceof DatafileHttpError && !error.retryable) {
+          throw error instanceof Error ? error : new Error("Unknown fetch error");
+        }
+      }
+    }
+  } finally {
     clearTimeout(timeoutId);
+    clearTimeout(delay);
+    signal.removeEventListener("abort", onAbort);
     options.signal?.removeEventListener("abort", onExternalAbort);
-    throw error instanceof Error ? error : new Error("Unknown fetch error");
   }
 }
 
@@ -1655,13 +1701,16 @@ var PollingSource = class extends TypedEmitter {
    */
   async poll() {
     if (this.abortController?.signal.aborted) return;
+    this.abortController ??= new AbortController();
+    const controller = this.abortController;
     try {
       const data = await fetchDatafile({
         ...this.config,
-        signal: this.abortController?.signal
+        signal: controller.signal
       });
       this.emit("data", data);
     } catch (error) {
+      controller.signal.throwIfAborted();
       const err = error instanceof Error ? error : new Error("Unknown poll error");
       this.emit("error", err);
     }
@@ -1673,9 +1722,9 @@ var PollingSource = class extends TypedEmitter {
    */
   startInterval() {
     if (this.intervalId) return;
-    this.abortController = new AbortController();
     this.intervalId = setInterval(
-      () => void this.poll(),
+      () => void this.poll().catch(() => {
+      }),
       this.config.polling.intervalMs
     );
   }
@@ -2750,4 +2799,4 @@ export {
   resetDefaultFlagsClient,
   createClient
 };
-//# sourceMappingURL=chunk-AMDRNXFQ.js.map
+//# sourceMappingURL=chunk-NPKDNJX6.js.map