@vercel/build-utils 2.12.3-canary.29 → 2.12.3-canary.32

package/dist/convert-runtime-to-plugin.js

@@ -24,6 +24,22 @@ const shouldIgnorePath = (file, ignoreFilter, ignoreFile) => {
     }
     return isNative || ignoreFilter(file);
 };
+const getSourceFiles = async (workPath, ignoreFilter) => {
+    const list = await glob_1.default('**', {
+        cwd: workPath,
+    });
+    // We're not passing this as an `ignore` filter to the `glob` function above,
+    // so that we can re-use exactly the same `getIgnoreFilter` method that the
+    // Build Step uses (literally the same code). Note that this exclusion only applies
+    // when deploying. Locally, another exclusion is needed, which is handled
+    // further below in the `convertRuntimeToPlugin` function.
+    for (const file in list) {
+        if (shouldIgnorePath(file, ignoreFilter, true)) {
+            delete list[file];
+        }
+    }
+    return list;
+};
 /**
  * Convert legacy Runtime to a Plugin.
  * @param buildRuntime - a legacy build() function from a Runtime
@@ -33,22 +49,25 @@ const shouldIgnorePath = (file, ignoreFilter, ignoreFile) => {
 function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
     // This `build()` signature should match `plugin.build()` signature in `vercel build`.
     return async function build({ workPath }) {
-        const opts = { cwd: workPath };
-        const files = await glob_1.default('**', opts);
         // We also don't want to provide any files to Runtimes that were ignored
         // through `.vercelignore` or `.nowignore`, because the Build Step does the same.
         const ignoreFilter = await _1.getIgnoreFilter(workPath);
-        // We're not passing this as an `ignore` filter to the `glob` function above,
-        // so that we can re-use exactly the same `getIgnoreFilter` method that the
-        // Build Step uses (literally the same code). Note that this exclusion only applies
-        // when deploying. Locally, another exclusion further below is needed.
-        for (const file in files) {
-            if (shouldIgnorePath(file, ignoreFilter, true)) {
-                delete files[file];
+        // Retrieve the files that are currently available on the File System,
+        // before the Legacy Runtime has even started to build.
+        const sourceFilesPreBuild = await getSourceFiles(workPath, ignoreFilter);
+        // Instead of doing another `glob` to get all the matching source files,
+        // we'll filter the list of existing files down to only the ones
+        // that are matching the entrypoint pattern, so we're first creating
+        // a clean new list to begin.
+        const entrypoints = Object.assign({}, sourceFilesPreBuild);
+        const entrypointMatch = new RegExp(`^api/.*${ext}$`);
+        // Up next, we'll strip out the files from the list of entrypoints
+        // that aren't actually considered entrypoints.
+        for (const file in entrypoints) {
+            if (!entrypointMatch.test(file)) {
+                delete entrypoints[file];
             }
         }
-        const entrypointPattern = `api/**/*${ext}`;
-        const entrypoints = await glob_1.default(entrypointPattern, opts);
         const pages = {};
         const pluginName = packageName.replace('vercel-plugin-', '');
         const traceDir = path_1.join(workPath, `.output`, `inputs`, 
@@ -60,7 +79,7 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
         await fs_extra_1.default.ensureDir(traceDir);
         for (const entrypoint of Object.keys(entrypoints)) {
             const { output } = await buildRuntime({
-                files,
+                files: sourceFilesPreBuild,
                 entrypoint,
                 workPath,
                 config: {
@@ -70,8 +89,23 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
                     avoidTopLevelInstall: true,
                 },
             });
+            // Legacy Runtimes tend to pollute the `workPath` with compiled results,
+            // because the `workPath` used to be a place that was a place where they could
+            // just put anything, but nowadays it's the working directory of the `vercel build`
+            // command, which is the place where the developer keeps their source files,
+            // so we don't want to pollute this space unnecessarily. That means we have to clean
+            // up files that were created by the build, which is done further below.
+            const sourceFilesAfterBuild = await getSourceFiles(workPath, ignoreFilter);
+            // Further down, we will need the filename of the Lambda handler
+            // for placing it inside `server/pages/api`, but because Legacy Runtimes
+            // don't expose the filename directly, we have to construct it
+            // from the handler name, and then find the matching file further below,
+            // because we don't yet know its extension here.
+            const handler = output.handler;
+            const handlerMethod = handler.split('.').reverse()[0];
+            const handlerFileName = handler.replace(`.${handlerMethod}`, '');
             pages[entrypoint] = {
-                handler: output.handler,
+                handler: handler,
                 runtime: output.runtime,
                 memory: output.memory,
                 maxDuration: output.maxDuration,
@@ -86,15 +120,36 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
             // to the outputs that they are returning instead.
             for (const file in lambdaFiles) {
                 if (shouldIgnorePath(file, ignoreFilter, false)) {
-                    delete files[file];
+                    delete lambdaFiles[file];
                 }
             }
+            const handlerFilePath = Object.keys(lambdaFiles).find(item => {
+                return path_1.parse(item).name === handlerFileName;
+            });
+            const handlerFileOrigin = lambdaFiles[handlerFilePath || ''].fsPath;
+            if (!handlerFileOrigin) {
+                throw new Error(`Could not find a handler file. Please ensure that the list of \`files\` defined for the returned \`Lambda\` contains a file with the name ${handlerFileName} (+ any extension).`);
+            }
             const entry = path_1.join(workPath, '.output', 'server', 'pages', entrypoint);
             await fs_extra_1.default.ensureDir(path_1.dirname(entry));
-            await linkOrCopy(files[entrypoint].fsPath, entry);
+            await linkOrCopy(handlerFileOrigin, entry);
+            const toRemove = [];
+            // You can find more details about this at the point where the
+            // `sourceFilesAfterBuild` is created originally.
+            for (const file in sourceFilesAfterBuild) {
+                if (!sourceFilesPreBuild[file]) {
+                    const path = sourceFilesAfterBuild[file].fsPath;
+                    toRemove.push(fs_extra_1.default.remove(path));
+                }
+            }
+            await Promise.all(toRemove);
             const tracedFiles = [];
             Object.entries(lambdaFiles).forEach(async ([relPath, file]) => {
                 const newPath = path_1.join(traceDir, relPath);
+                // The handler was already moved into position above.
+                if (relPath === handlerFilePath) {
+                    return;
+                }
                 tracedFiles.push({ absolutePath: newPath, relativePath: relPath });
                 if (file.fsPath) {
                     await linkOrCopy(file.fsPath, newPath);
@@ -110,9 +165,9 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
             const nft = path_1.join(workPath, '.output', 'server', 'pages', `${entrypoint}.nft.json`);
             const json = JSON.stringify({
                 version: 1,
-                files: tracedFiles.map(f => ({
-                    input: normalize_path_1.normalizePath(path_1.relative(nft, f.absolutePath)),
-                    output: normalize_path_1.normalizePath(f.relativePath),
+                files: tracedFiles.map(file => ({
+                    input: normalize_path_1.normalizePath(path_1.relative(path_1.dirname(nft), file.absolutePath)),
+                    output: normalize_path_1.normalizePath(file.relativePath),
                 })),
             });
             await fs_extra_1.default.ensureDir(path_1.dirname(nft));

package/dist/index.js

@@ -32771,6 +32771,22 @@ const shouldIgnorePath = (file, ignoreFilter, ignoreFile) => {
     }
     return isNative || ignoreFilter(file);
 };
+const getSourceFiles = async (workPath, ignoreFilter) => {
+    const list = await glob_1.default('**', {
+        cwd: workPath,
+    });
+    // We're not passing this as an `ignore` filter to the `glob` function above,
+    // so that we can re-use exactly the same `getIgnoreFilter` method that the
+    // Build Step uses (literally the same code). Note that this exclusion only applies
+    // when deploying. Locally, another exclusion is needed, which is handled
+    // further below in the `convertRuntimeToPlugin` function.
+    for (const file in list) {
+        if (shouldIgnorePath(file, ignoreFilter, true)) {
+            delete list[file];
+        }
+    }
+    return list;
+};
 /**
  * Convert legacy Runtime to a Plugin.
  * @param buildRuntime - a legacy build() function from a Runtime
@@ -32780,22 +32796,25 @@ const shouldIgnorePath = (file, ignoreFilter, ignoreFile) => {
 function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
     // This `build()` signature should match `plugin.build()` signature in `vercel build`.
     return async function build({ workPath }) {
-        const opts = { cwd: workPath };
-        const files = await glob_1.default('**', opts);
         // We also don't want to provide any files to Runtimes that were ignored
         // through `.vercelignore` or `.nowignore`, because the Build Step does the same.
         const ignoreFilter = await _1.getIgnoreFilter(workPath);
-        // We're not passing this as an `ignore` filter to the `glob` function above,
-        // so that we can re-use exactly the same `getIgnoreFilter` method that the
-        // Build Step uses (literally the same code). Note that this exclusion only applies
-        // when deploying. Locally, another exclusion further below is needed.
-        for (const file in files) {
-            if (shouldIgnorePath(file, ignoreFilter, true)) {
-                delete files[file];
+        // Retrieve the files that are currently available on the File System,
+        // before the Legacy Runtime has even started to build.
+        const sourceFilesPreBuild = await getSourceFiles(workPath, ignoreFilter);
+        // Instead of doing another `glob` to get all the matching source files,
+        // we'll filter the list of existing files down to only the ones
+        // that are matching the entrypoint pattern, so we're first creating
+        // a clean new list to begin.
+        const entrypoints = Object.assign({}, sourceFilesPreBuild);
+        const entrypointMatch = new RegExp(`^api/.*${ext}$`);
+        // Up next, we'll strip out the files from the list of entrypoints
+        // that aren't actually considered entrypoints.
+        for (const file in entrypoints) {
+            if (!entrypointMatch.test(file)) {
+                delete entrypoints[file];
             }
         }
-        const entrypointPattern = `api/**/*${ext}`;
-        const entrypoints = await glob_1.default(entrypointPattern, opts);
         const pages = {};
         const pluginName = packageName.replace('vercel-plugin-', '');
         const traceDir = path_1.join(workPath, `.output`, `inputs`, 
@@ -32807,7 +32826,7 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
         await fs_extra_1.default.ensureDir(traceDir);
         for (const entrypoint of Object.keys(entrypoints)) {
             const { output } = await buildRuntime({
-                files,
+                files: sourceFilesPreBuild,
                 entrypoint,
                 workPath,
                 config: {
@@ -32817,8 +32836,23 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
                     avoidTopLevelInstall: true,
                 },
             });
+            // Legacy Runtimes tend to pollute the `workPath` with compiled results,
+            // because the `workPath` used to be a place that was a place where they could
+            // just put anything, but nowadays it's the working directory of the `vercel build`
+            // command, which is the place where the developer keeps their source files,
+            // so we don't want to pollute this space unnecessarily. That means we have to clean
+            // up files that were created by the build, which is done further below.
+            const sourceFilesAfterBuild = await getSourceFiles(workPath, ignoreFilter);
+            // Further down, we will need the filename of the Lambda handler
+            // for placing it inside `server/pages/api`, but because Legacy Runtimes
+            // don't expose the filename directly, we have to construct it
+            // from the handler name, and then find the matching file further below,
+            // because we don't yet know its extension here.
+            const handler = output.handler;
+            const handlerMethod = handler.split('.').reverse()[0];
+            const handlerFileName = handler.replace(`.${handlerMethod}`, '');
             pages[entrypoint] = {
-                handler: output.handler,
+                handler: handler,
                 runtime: output.runtime,
                 memory: output.memory,
                 maxDuration: output.maxDuration,
@@ -32833,15 +32867,36 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
             // to the outputs that they are returning instead.
             for (const file in lambdaFiles) {
                 if (shouldIgnorePath(file, ignoreFilter, false)) {
-                    delete files[file];
+                    delete lambdaFiles[file];
                 }
             }
+            const handlerFilePath = Object.keys(lambdaFiles).find(item => {
+                return path_1.parse(item).name === handlerFileName;
+            });
+            const handlerFileOrigin = lambdaFiles[handlerFilePath || ''].fsPath;
+            if (!handlerFileOrigin) {
+                throw new Error(`Could not find a handler file. Please ensure that the list of \`files\` defined for the returned \`Lambda\` contains a file with the name ${handlerFileName} (+ any extension).`);
+            }
             const entry = path_1.join(workPath, '.output', 'server', 'pages', entrypoint);
             await fs_extra_1.default.ensureDir(path_1.dirname(entry));
-            await linkOrCopy(files[entrypoint].fsPath, entry);
+            await linkOrCopy(handlerFileOrigin, entry);
+            const toRemove = [];
+            // You can find more details about this at the point where the
+            // `sourceFilesAfterBuild` is created originally.
+            for (const file in sourceFilesAfterBuild) {
+                if (!sourceFilesPreBuild[file]) {
+                    const path = sourceFilesAfterBuild[file].fsPath;
+                    toRemove.push(fs_extra_1.default.remove(path));
+                }
+            }
+            await Promise.all(toRemove);
             const tracedFiles = [];
             Object.entries(lambdaFiles).forEach(async ([relPath, file]) => {
                 const newPath = path_1.join(traceDir, relPath);
+                // The handler was already moved into position above.
+                if (relPath === handlerFilePath) {
+                    return;
+                }
                 tracedFiles.push({ absolutePath: newPath, relativePath: relPath });
                 if (file.fsPath) {
                     await linkOrCopy(file.fsPath, newPath);
@@ -32857,9 +32912,9 @@ function convertRuntimeToPlugin(buildRuntime, packageName, ext) {
             const nft = path_1.join(workPath, '.output', 'server', 'pages', `${entrypoint}.nft.json`);
             const json = JSON.stringify({
                 version: 1,
-                files: tracedFiles.map(f => ({
-                    input: normalize_path_1.normalizePath(path_1.relative(nft, f.absolutePath)),
-                    output: normalize_path_1.normalizePath(f.relativePath),
+                files: tracedFiles.map(file => ({
+                    input: normalize_path_1.normalizePath(path_1.relative(path_1.dirname(nft), file.absolutePath)),
+                    output: normalize_path_1.normalizePath(file.relativePath),
                 })),
             });
             await fs_extra_1.default.ensureDir(path_1.dirname(nft));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vercel/build-utils",
-  "version": "2.12.3-canary.29",
+  "version": "2.12.3-canary.32",
   "license": "MIT",
   "main": "./dist/index.js",
   "types": "./dist/index.d.js",
@@ -49,5 +49,5 @@
     "typescript": "4.3.4",
     "yazl": "2.4.3"
   },
-  "gitHead": "9b3aa41f2e8d40b560969305af8cf26dcd6da8c9"
+  "gitHead": "ba7bf2e4a60bc4c9fd35ad33a11d94f1dae2ac81"
 }