@venturewild/workspace 0.6.21 → 0.6.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@venturewild/workspace",
-  "version": "0.6.21",
+  "version": "0.6.23",
   "description": "Claude Code Web — Replit/Lovable-style chat-first browser UI that wraps the AI agent already installed on your machine.",
   "license": "MIT",
   "bin": {

package/server/src/auto-update.mjs

@@ -128,9 +128,11 @@ export async function fetchLatestVersion(channel, {
 /** Run `npm i -g <spec>`. Resolves {code, output, timedOut?, error?}; never rejects. */
 export function npmInstall(spec, {
   spawnImpl = spawn, timeoutMs = 180000, ensurePathImpl = ensureToolPath, env = process.env,
+  platform = process.platform,
 } = {}) {
   return new Promise((resolve) => {
-    const cmd = process.platform === 'win32' ? 'npm.cmd' : 'npm';
+    const isWin = platform === 'win32';
+    const cmd = isWin ? 'npm.cmd' : 'npm';
     // The always-on supervisor (our caller in the field) runs under launchd/GUI,
     // which inherits a MINIMAL PATH omitting ~/.npm-global, /usr/local/bin,
     // Homebrew, nvm — so a bare `npm` spawn would ENOENT (the 0.1.8 `claude`
@@ -140,7 +142,15 @@ export function npmInstall(spec, {
     try { ensurePathImpl(childEnv); } catch { /* best-effort — fall back to inherited PATH */ }
     let child;
     try {
-      child = spawnImpl(cmd, ['i', '-g', spec], { windowsHide: true, env: childEnv });
+      // On Windows npm is a `.cmd` shim, and Node >=18.20.2/20.12.2/22 REFUSES to
+      // spawn a .cmd/.bat directly (CVE-2024-27980 hardening) — it throws EINVAL
+      // synchronously. That is exactly how field auto-update failed instantly
+      // (code=-1 in ~16ms, never reaching npm). shell:true routes the shim
+      // through cmd.exe so it actually runs. The only interpolated arg is a
+      // package spec we build ourselves (a constant name + a semver from npm's
+      // own dist-tag), so there is no shell-injection surface. POSIX stays
+      // shell:false — npm is a real executable there.
+      child = spawnImpl(cmd, ['i', '-g', spec], { windowsHide: true, env: childEnv, shell: isWin });
     } catch (e) {
       return resolve({ code: -1, error: e?.message || String(e), output: '' });
     }
@@ -226,7 +236,7 @@ export class AutoUpdater {
     this.logImpl(`auto-update: installing ${this.packageName}@${target} (from ${from || 'unknown'})`);
     const install = await this.installImpl(`${this.packageName}@${target}`);
     if (install.code !== 0) {
-      this.logImpl(`auto-update: install failed code=${install.code}${install.timedOut ? ' (timeout)' : ''}`);
+      this.logImpl(`auto-update: install failed code=${install.code}${install.timedOut ? ' (timeout)' : ''}${install.error ? ` error=${install.error}` : ''}`);
       const rec = recordUpdate(this.globalDir, { from, to: target, at: this.nowImpl(), status: 'install-failed' });
       this.onUpdate?.(rec);
       return { ok: false, stage: 'install', install, rec };

package/server/src/index.mjs

@@ -76,6 +76,7 @@ import {
   seedDefault,
   workspaceIdForDir,
 } from './workspace-registry.mjs';
+import { ensureDataDirScaffold } from './workspace-scaffold.mjs';
 import { createWorkspaceRails } from './workspaces.mjs';
 import { matchCandidates } from './bazaar/mock-tickup.mjs';
 import { servePreviewFile, confineBuildDir } from './bazaar/preview-server.mjs';
@@ -182,6 +183,7 @@ export async function createServer(overrides = {}) {
   // Refuse to start on a public bind with a forgeable default secret. (C1/C2)
   assertSecureBinding(config);
   if (!existsSync(config.dataDir)) mkdirSync(config.dataDir, { recursive: true });
+  ensureDataDirScaffold(config.dataDir); // self-ignore from the user's git (principle #1)
 
   const activityBus = new ActivityBus();
   // Live workspace presence (R-followup): tracks which member EMAILS are currently
@@ -1040,8 +1042,17 @@ export async function createServer(overrides = {}) {
       name: w.name,
     };
   }
+  // Every workspace's dataDir, once per process, gets the self-ignoring `.gitignore`
+  // so a workspace opened from an existing git repo never leaks `.wild-workspace/`
+  // into the user's commits (principle #1). Guarded by a Set → O(1) after first touch.
+  const scaffoldedDataDirs = new Set();
   function workspaceFor(c) {
-    return c.get('workspace') || resolveWorkspace(c.req.header('x-workspace-id'));
+    const ws = c.get('workspace') || resolveWorkspace(c.req.header('x-workspace-id'));
+    if (ws?.dataDir && !scaffoldedDataDirs.has(ws.dataDir)) {
+      scaffoldedDataDirs.add(ws.dataDir);
+      ensureDataDirScaffold(ws.dataDir);
+    }
+    return ws;
   }
 
   // Persistent audit trail for privileged actions (SECURITY.md S8). The [http]

package/server/src/workspace-scaffold.mjs

@@ -0,0 +1,35 @@
+// Workspace dataDir scaffold — keeps wild-workspace's system state out of the user's
+// git repo (CLAUDE.md principle #1: "never write junk into the user's synced
+// workspace"). A workspace folder is frequently an existing git repo (the user opened
+// it via "Open a folder with your work"); without this, the `.wild-workspace/` dir we
+// create for sessions/canvas/settings/identity/resume-tokens shows up as untracked and
+// a `git add .` would commit it.
+//
+// The fix is SELF-CONTAINED: we drop a `.gitignore` INSIDE `.wild-workspace/` that
+// ignores its own contents (`*`), so git never sees the folder — WITHOUT touching the
+// user's own root `.gitignore` (honors the "never touch the user's project files"
+// rule the adopt flow follows). Idempotent + best-effort: a read-only fs must never
+// break a turn, and we never overwrite an existing `.gitignore`.
+
+import fs from 'node:fs';
+import path from 'node:path';
+
+export const SCAFFOLD_GITIGNORE =
+  '# wild-workspace system state — never commit into the user repo (CLAUDE.md principle #1)\n*\n';
+
+/**
+ * Ensure a workspace's `.wild-workspace/` dataDir exists and self-ignores from git.
+ * Safe to call often (cheap once the file exists). Returns true iff it wrote the file.
+ */
+export function ensureDataDirScaffold(dataDir) {
+  if (!dataDir || typeof dataDir !== 'string') return false;
+  try {
+    fs.mkdirSync(dataDir, { recursive: true });
+    const gi = path.join(dataDir, '.gitignore');
+    if (fs.existsSync(gi)) return false;
+    fs.writeFileSync(gi, SCAFFOLD_GITIGNORE);
+    return true;
+  } catch {
+    return false; // read-only fs / permissions — never throw into a request path
+  }
+}