@venizia/dev-configs 0.4.6 → 0.4.7-1

package/dist/linters/house/no-await-promise-chain.rule.js

@@ -0,0 +1,298 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoAwaitPromiseChainRule = void 0;
+const await_support_1 = require("./await-support");
+const common_1 = require("./common");
+const promise_chain_support_1 = require("./promise-chain-support");
+const STATEMENT_LISTS = new Set(['BlockStatement', 'Program', 'StaticBlock', 'SwitchCase']);
+/** The catch variable the fix writes when the handler has no parameter. */
+const CATCH_NAME = 'error';
+/** The identifiers a fallback value reads, and whether every node of it is a value the fix may move. */
+const collectValue = (opts) => {
+    const { node, parameter, identifiers } = opts;
+    const type = common_1.AstNode.getType({ node }) ?? '';
+    const value = (child) => collectValue({ node: child, parameter, identifiers });
+    switch (type) {
+        case 'Literal': {
+            return true;
+        }
+        case 'Identifier': {
+            identifiers.push(node);
+            return true;
+        }
+        case 'TemplateLiteral': {
+            return promise_chain_support_1.PromiseChainSupport.isConstant({ node });
+        }
+        case 'UnaryExpression': {
+            return promise_chain_support_1.PromiseChainSupport.isConstant({ node });
+        }
+        case 'ChainExpression': {
+            return value(common_1.AstNode.readField({ node, key: 'expression' }));
+        }
+        case 'MemberExpression': {
+            // Only a read of the error itself: `error.message`, `error?.response.status`.
+            const object = common_1.AstNode.readField({ node, key: 'object' });
+            const isRead = common_1.AstNode.readField({ node, key: 'computed' }) !== true ||
+                common_1.AstNode.getType({ node: common_1.AstNode.readField({ node, key: 'property' }) }) === 'Literal';
+            const isRooted = common_1.AstNode.getType({ node: object }) === 'MemberExpression' ||
+                (common_1.AstNode.getType({ node: object }) === 'Identifier' &&
+                    common_1.AstNode.readField({ node: object, key: 'name' }) === parameter);
+            return isRead && isRooted && parameter !== undefined && value(object);
+        }
+        case 'ArrayExpression': {
+            const elements = common_1.AstNode.readField({ node, key: 'elements' });
+            return (Array.isArray(elements) && elements.every((element) => element === null || value(element)));
+        }
+        case 'ObjectExpression': {
+            const properties = common_1.AstNode.readField({ node, key: 'properties' });
+            return (Array.isArray(properties) &&
+                properties.every((property) => common_1.AstNode.getType({ node: property }) === 'Property' &&
+                    common_1.AstNode.readField({ node: property, key: 'computed' }) !== true &&
+                    common_1.AstNode.readField({ node: property, key: 'method' }) !== true &&
+                    common_1.AstNode.readField({ node: property, key: 'kind' }) === 'init' &&
+                    value(common_1.AstNode.readField({ node: property, key: 'value' }))));
+        }
+        default: {
+            return false;
+        }
+    }
+};
+/** Whether `name` is declared in `scope` or any scope around it: a catch variable of that name would shadow it. */
+const isDeclaredAround = (opts) => {
+    for (let scope = opts.scope; scope; scope = scope.upper) {
+        if (scope.set.has(opts.name)) {
+            return true;
+        }
+    }
+    return false;
+};
+/**
+ * The plan of the fix for `awaitNode`, or `undefined` when the strict safe shape does not hold:
+ * `const|let x[: T] = await f().catch(() => <value>)` or `.catch((error) => <value>)`, alone in its declaration,
+ * in a statement list; `x` never written again and, without a type annotation, read only in its own function;
+ * the handler an expression-bodied, non-async arrow with at most one plain parameter; `<value>` a literal, an
+ * identifier, a read of the error (`error.message`) or an array or object literal of those; `f()` with no
+ * `.then`, `.catch` or `.finally` before and no `await` inside; no comment the fix would drop.
+ */
+const planFix = (opts) => {
+    const { awaitNode, sourceCode } = opts;
+    const call = common_1.AstNode.readField({ node: awaitNode, key: 'argument' });
+    const callee = common_1.AstNode.readField({ node: call, key: 'callee' });
+    const args = common_1.AstNode.readField({ node: call, key: 'arguments' });
+    if (common_1.AstNode.getType({ node: call }) !== 'CallExpression' ||
+        common_1.AstNode.readField({ node: call, key: 'optional' }) === true ||
+        common_1.AstNode.getType({ node: callee }) !== 'MemberExpression' ||
+        common_1.AstNode.readField({ node: callee, key: 'computed' }) === true ||
+        common_1.AstNode.readField({ node: callee, key: 'optional' }) === true ||
+        promise_chain_support_1.PromiseChainSupport.memberName({ member: callee }) !== 'catch' ||
+        !Array.isArray(args) ||
+        args.length !== 1) {
+        return undefined;
+    }
+    const handler = args[0];
+    const params = common_1.AstNode.readField({ node: handler, key: 'params' });
+    const body = common_1.AstNode.readField({ node: handler, key: 'body' });
+    const parameter = Array.isArray(params) ? params[0] : undefined;
+    if (common_1.AstNode.getType({ node: handler }) !== 'ArrowFunctionExpression' ||
+        common_1.AstNode.readField({ node: handler, key: 'async' }) === true ||
+        common_1.AstNode.getType({ node: body }) === 'BlockStatement' ||
+        common_1.AstNode.readField({ node: handler, key: 'returnType' }) ||
+        common_1.AstNode.readField({ node: handler, key: 'typeParameters' }) ||
+        !Array.isArray(params) ||
+        params.length > 1 ||
+        (parameter !== undefined &&
+            (common_1.AstNode.getType({ node: parameter }) !== 'Identifier' ||
+                common_1.AstNode.readField({ node: parameter, key: 'typeAnnotation' }) ||
+                common_1.AstNode.readField({ node: parameter, key: 'optional' }) === true))) {
+        return undefined;
+    }
+    const receiver = common_1.AstNode.readField({ node: callee, key: 'object' });
+    if (!await_support_1.AwaitSupport.isNode(receiver) ||
+        !await_support_1.AwaitSupport.isNode(body) ||
+        !await_support_1.AwaitSupport.isNode(handler) ||
+        promise_chain_support_1.PromiseChainSupport.hasChainOnSpine({ node: receiver }) ||
+        /\b(await|yield)\b/.test(sourceCode.getText(receiver))) {
+        return undefined;
+    }
+    const declarator = await_support_1.AwaitSupport.parentOf({ node: awaitNode });
+    const declaration = await_support_1.AwaitSupport.parentOf({ node: declarator });
+    const id = common_1.AstNode.readField({ node: declarator, key: 'id' });
+    const declarations = common_1.AstNode.readField({ node: declaration, key: 'declarations' });
+    const kind = String(common_1.AstNode.readField({ node: declaration, key: 'kind' }));
+    if (common_1.AstNode.getType({ node: declarator }) !== 'VariableDeclarator' ||
+        common_1.AstNode.readField({ node: declarator, key: 'init' }) !== awaitNode ||
+        common_1.AstNode.readField({ node: declarator, key: 'definite' }) === true ||
+        common_1.AstNode.getType({ node: id }) !== 'Identifier' ||
+        !await_support_1.AwaitSupport.isNode(declarator) ||
+        !await_support_1.AwaitSupport.isNode(declaration) ||
+        !Array.isArray(declarations) ||
+        declarations.length !== 1 ||
+        !['const', 'let'].includes(kind) ||
+        !STATEMENT_LISTS.has(common_1.AstNode.getType({ node: await_support_1.AwaitSupport.parentOf({ node: declaration }) }) ?? '')) {
+        return undefined;
+    }
+    const name = String(common_1.AstNode.readField({ node: id, key: 'name' }));
+    const typeAnnotation = common_1.AstNode.readField({ node: id, key: 'typeAnnotation' });
+    const annotation = await_support_1.AwaitSupport.isNode(typeAnnotation) ? sourceCode.getText(typeAnnotation) : '';
+    // `let x;` with no annotation takes its type from the assignments that follow, so TypeScript must see every
+    // read in the same function: a read from a nested function, an export or a `typeof` makes it an implicit any.
+    const variable = sourceCode.getDeclaredVariables(declarator).find((entry) => entry.name === name);
+    if (!variable) {
+        return undefined;
+    }
+    for (const reference of variable.references) {
+        if (reference.identifier === id) {
+            continue;
+        }
+        const parentType = common_1.AstNode.getType({
+            node: await_support_1.AwaitSupport.parentOf({ node: reference.identifier }),
+        });
+        if (reference.isWrite() ||
+            (annotation === '' &&
+                (reference.from.variableScope !== variable.scope.variableScope ||
+                    parentType === 'ExportSpecifier' ||
+                    parentType === 'TSTypeQuery'))) {
+            return undefined;
+        }
+    }
+    const parameterName = parameter === undefined
+        ? undefined
+        : String(common_1.AstNode.readField({ node: parameter, key: 'name' }));
+    const identifiers = [];
+    if (!collectValue({ node: body, parameter: parameterName, identifiers })) {
+        return undefined;
+    }
+    // `x = []` on a `let x;` with no annotation makes an evolving `any[]`, looser than the `never[]` it was.
+    const elements = common_1.AstNode.readField({ node: body, key: 'elements' });
+    if (annotation === '' &&
+        common_1.AstNode.getType({ node: body }) === 'ArrayExpression' &&
+        Array.isArray(elements) &&
+        elements.length === 0) {
+        return undefined;
+    }
+    const parameterVariable = sourceCode
+        .getDeclaredVariables(handler)
+        .find((entry) => entry.name === parameterName);
+    const errorReads = new Set(parameterVariable?.references.map((reference) => reference.identifier) ?? []);
+    const freeNames = new Set(identifiers
+        .filter((identifier) => !errorReads.has(identifier))
+        .map((identifier) => String(common_1.AstNode.readField({ node: identifier, key: 'name' }))));
+    // The fallback is evaluated after the `let`: reading the declared name there would read `undefined`.
+    if (freeNames.has(name)) {
+        return undefined;
+    }
+    const scope = sourceCode.getScope(declaration);
+    const isTaken = (candidate) => candidate === name ||
+        freeNames.has(candidate) ||
+        (candidate !== parameterName && isDeclaredAround({ scope, name: candidate }));
+    const base = parameterName ?? CATCH_NAME;
+    let catchName = base;
+    for (let index = 2; isTaken(catchName); index += 1) {
+        catchName = `${base}${index}`;
+    }
+    const comments = sourceCode.getCommentsInside(declaration);
+    const isInside = (range, inner) => range !== undefined && inner !== undefined && range[0] <= inner[0] && inner[1] <= range[1];
+    if (comments.some((comment) => !isInside(receiver.range, comment.range) && !isInside(body.range, comment.range))) {
+        return undefined;
+    }
+    const bodyStart = body.range?.[0] ?? 0;
+    let valueText = sourceCode.getText(body);
+    if (catchName !== parameterName && errorReads.size > 0) {
+        const edits = [...errorReads]
+            .filter(await_support_1.AwaitSupport.isNode)
+            .map((identifier) => {
+            const parent = await_support_1.AwaitSupport.parentOf({ node: identifier });
+            const isShorthand = common_1.AstNode.getType({ node: parent }) === 'Property' &&
+                common_1.AstNode.readField({ node: parent, key: 'shorthand' }) === true;
+            return {
+                range: identifier.range ?? [0, 0],
+                text: isShorthand ? `${parameterName}: ${catchName}` : catchName,
+            };
+        })
+            .sort((left, right) => right.range[0] - left.range[0]);
+        for (const edit of edits) {
+            valueText =
+                valueText.slice(0, edit.range[0] - bodyStart) +
+                    edit.text +
+                    valueText.slice(edit.range[1] - bodyStart);
+        }
+    }
+    return {
+        declaration,
+        kind,
+        name,
+        annotation,
+        receiverText: sourceCode.getText(receiver),
+        catchName,
+        isErrorRead: errorReads.size > 0,
+        valueText,
+    };
+};
+/**
+ * `venizia/no-await-promise-chain`. One expression uses one async style: `await` (in a try/catch when it can
+ * fail), or a promise chain that is not awaited. An `await` whose operand - after parentheses, `!`, `as`,
+ * `satisfies` and an optional chain - is a call of `.then`, `.catch` or `.finally` (`?.then(`, `['then'](`, a
+ * thenable such as a query builder) is reported once, however long the chain. A chain that is returned or stands
+ * as a statement is not awaited and is not reported, nor is `await Promise.all(xs.map(f))`, `await new Promise(...)`,
+ * `await x.then` (no call), or an `await` inside a callback of a chain.
+ *
+ * The fix is made for one shape only, `const|let x = await f().catch(() => <value>)` (see `planFix` for every
+ * condition), and writes `let x; try { x = await f(); } catch (error) { x = <value>; }` (`catch { ... }` when the value does not read the error): the `const` becomes a
+ * `let`, a type annotation stays, the catch variable takes the handler's parameter name (`error` without one,
+ * renamed when the name is taken), and is typed `any` when the value reads it, as the handler's parameter was.
+ * The try also catches a synchronous throw of `f()`, which the chain let through. Everything else is reported.
+ */
+class NoAwaitPromiseChainRule {
+    static { this.NAME = `${common_1.HOUSE_PLUGIN_NAMESPACE}/no-await-promise-chain`; }
+    static { this.RULE = {
+        meta: {
+            type: 'suggestion',
+            fixable: 'code',
+            schema: [],
+            messages: {
+                mixed: 'Do not `await` a promise chain (`.{{method}}(...)`): wrap `await f()` in try/catch, or drop the `await` and keep the chain.',
+                mixedConst: 'Do not `await` a promise chain (`.{{method}}(...)`): wrap `await f()` in try/catch, or drop the `await` and keep the chain. The fix writes the try/catch and turns the `const` into a `let`.',
+            },
+        },
+        create: (context) => {
+            const { sourceCode } = context;
+            return {
+                [common_1.AstNodeTypes.AWAIT_EXPRESSION]: (node) => {
+                    const method = promise_chain_support_1.PromiseChainSupport.chainMethodOf({
+                        node: common_1.AstNode.readField({ node, key: 'argument' }),
+                    });
+                    if (method === undefined) {
+                        return;
+                    }
+                    const plan = planFix({ awaitNode: node, sourceCode });
+                    context.report({
+                        node,
+                        messageId: plan?.kind === 'const' ? 'mixedConst' : 'mixed',
+                        data: { method },
+                        fix: plan
+                            ? (fixer) => {
+                                const indent = await_support_1.AwaitSupport.indentOf({ node: plan.declaration, sourceCode });
+                                const inner = `${indent}  `;
+                                // The optional catch binding when nothing reads the error: a named one would be an unused variable.
+                                const head = plan.isErrorRead ? `catch (${plan.catchName}: any)` : 'catch';
+                                return fixer.replaceText(plan.declaration, [
+                                    `let ${plan.name}${plan.annotation};`,
+                                    `${indent}try {`,
+                                    `${inner}${plan.name} = await ${plan.receiverText};`,
+                                    `${indent}} ${head} {`,
+                                    `${inner}${plan.name} = ${plan.valueText};`,
+                                    `${indent}}`,
+                                ].join('\n'));
+                            }
+                            : null,
+                    });
+                },
+            };
+        },
+    }; }
+    static build(opts = {}) {
+        return opts.severity ?? 'error';
+    }
+}
+exports.NoAwaitPromiseChainRule = NoAwaitPromiseChainRule;
+//# sourceMappingURL=no-await-promise-chain.rule.js.map

package/dist/linters/house/no-await-promise-chain.rule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-await-promise-chain.rule.js","sourceRoot":"","sources":["../../../src/linters/house/no-await-promise-chain.rule.ts"],"names":[],"mappings":";;;AAEA,mDAA+C;AAC/C,qCAAyE;AACzE,mEAA8D;AAE9D,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,gBAAgB,EAAE,SAAS,EAAE,aAAa,EAAE,YAAY,CAAC,CAAC,CAAC;AAC5F,2EAA2E;AAC3E,MAAM,UAAU,GAAG,OAAO,CAAC;AAc3B,wGAAwG;AACxG,MAAM,YAAY,GAAG,CAAC,IAIrB,EAAW,EAAE;IACZ,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,WAAW,EAAE,GAAG,IAAI,CAAC;IAC9C,MAAM,IAAI,GAAG,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,CAAC,IAAI,EAAE,CAAC;IAC7C,MAAM,KAAK,GAAG,CAAC,KAAc,EAAE,EAAE,CAAC,YAAY,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,WAAW,EAAE,CAAC,CAAC;IAExF,QAAQ,IAAI,EAAE,CAAC;QACb,KAAK,SAAS,CAAC,CAAC,CAAC;YACf,OAAO,IAAI,CAAC;QACd,CAAC;QACD,KAAK,YAAY,CAAC,CAAC,CAAC;YAClB,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACvB,OAAO,IAAI,CAAC;QACd,CAAC;QACD,KAAK,iBAAiB,CAAC,CAAC,CAAC;YACvB,OAAO,2CAAmB,CAAC,UAAU,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;QACD,KAAK,iBAAiB,CAAC,CAAC,CAAC;YACvB,OAAO,2CAAmB,CAAC,UAAU,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;QACD,KAAK,iBAAiB,CAAC,CAAC,CAAC;YACvB,OAAO,KAAK,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,YAAY,EAAE,CAAC,CAAC,CAAC;QAC/D,CAAC;QACD,KAAK,kBAAkB,CAAC,CAAC,CAAC;YACxB,8EAA8E;YAC9E,MAAM,MAAM,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC;YAC1D,MAAM,MAAM,GACV,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;gBACrD,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,EAAE,CAAC,KAAK,SAAS,CAAC;YACxF,MAAM,QAAQ,GACZ,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,kBAAkB;gBACxD,CAAC,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,YAAY;oBACjD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,SAAS,CAAC,CAAC;YAEpE,OAAO,MAAM,IAAI,QAAQ,IAAI,SAAS,KAAK,SAAS,IAAI,KAAK,CAAC,MAAM,CAAC,CAAC;QACxE,CAAC;QACD,KAAK,iBAAiB,CAAC,CAAC,CAAC;YACvB,MAAM,QAAQ,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;YAC9D,OAAO,CACL,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,QAAQ,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,CAAC,CAC3F,CAAC;QACJ,CAAC;QACD,KAAK,kBAAkB,CAAC,CAAC,CAAC;YACxB,MAAM,UAAU,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,YAAY,EAAE,CAAC,CAAC;YAClE,OAAO,CACL,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC;gBACzB,UAAU,CAAC,KAAK,CACd,CAAC,QAAQ,EAAE,EAAE,CACX,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,KAAK,UAAU;oBAClD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;oBAC/D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,KAAK,IAAI;oBAC7D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,MAAM;oBAC7D,KAAK,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC,CAAC,CAC7D,CACF,CAAC;QACJ,CAAC;QACD,OAAO,CAAC,CAAC,CAAC;YACR,OAAO,KAAK,CAAC;QACf,CAAC;IACH,CAAC;AACH,CAAC,CAAC;AAEF,mHAAmH;AACnH,MAAM,gBAAgB,GAAG,CAAC,IAAiD,EAAW,EAAE;IACtF,KAAK,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,EAAE,KAAK,EAAE,KAAK,GAAG,KAAK,CAAC,KAAK,EAAE,CAAC;QACxD,IAAI,KAAK,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YAC7B,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC,CAAC;AAEF;;;;;;;GAOG;AACH,MAAM,OAAO,GAAG,CAAC,IAAsD,EAAwB,EAAE;IAC/F,MAAM,EAAE,SAAS,EAAE,UAAU,EAAE,GAAG,IAAI,CAAC;IACvC,MAAM,IAAI,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;IACrE,MAAM,MAAM,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC;IAChE,MAAM,IAAI,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,GAAG,EAAE,WAAW,EAAE,CAAC,CAAC;IAEjE,IACE,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,KAAK,gBAAgB;QACpD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;QAC3D,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,kBAAkB;QACxD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;QAC7D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;QAC7D,2CAAmB,CAAC,UAAU,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,CAAC,KAAK,OAAO;QAC9D,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC;QACpB,IAAI,CAAC,MAAM,KAAK,CAAC,EACjB,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,OAAO,GAAY,IAAI,CAAC,CAAC,CAAC,CAAC;IACjC,MAAM,MAAM,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC;IACnE,MAAM,IAAI,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC;IAC/D,MAAM,SAAS,GAAY,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAEzE,IACE,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,KAAK,yBAAyB;QAChE,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC,KAAK,IAAI;QAC3D,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,KAAK,gBAAgB;QACpD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,YAAY,EAAE,CAAC;QACvD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,EAAE,gBAAgB,EAAE,CAAC;QAC3D,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC;QACtB,MAAM,CAAC,MAAM,GAAG,CAAC;QACjB,CAAC,SAAS,KAAK,SAAS;YACtB,CAAC,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,KAAK,YAAY;gBACpD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,gBAAgB,EAAE,CAAC;gBAC7D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI,CAAC,CAAC,EACtE,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,QAAQ,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC;IACpE,IACE,CAAC,4BAAY,CAAC,MAAM,CAAC,QAAQ,CAAC;QAC9B,CAAC,4BAAY,CAAC,MAAM,CAAC,IAAI,CAAC;QAC1B,CAAC,4BAAY,CAAC,MAAM,CAAC,OAAO,CAAC;QAC7B,2CAAmB,CAAC,eAAe,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;QACvD,mBAAmB,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,EACtD,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,UAAU,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;IAC9D,MAAM,WAAW,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;IAChE,MAAM,EAAE,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAAC;IAC9D,MAAM,YAAY,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,WAAW,EAAE,GAAG,EAAE,cAAc,EAAE,CAAC,CAAC;IACnF,MAAM,IAAI,GAAG,MAAM,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,WAAW,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC;IAE3E,IACE,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,KAAK,oBAAoB;QAC9D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,SAAS;QAClE,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;QACjE,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,KAAK,YAAY;QAC9C,CAAC,4BAAY,CAAC,MAAM,CAAC,UAAU,CAAC;QAChC,CAAC,4BAAY,CAAC,MAAM,CAAC,WAAW,CAAC;QACjC,CAAC,KAAK,CAAC,OAAO,CAAC,YAAY,CAAC;QAC5B,YAAY,CAAC,MAAM,KAAK,CAAC;QACzB,CAAC,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC;QAChC,CAAC,eAAe,CAAC,GAAG,CAClB,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC,IAAI,EAAE,CAC9E,EACD,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,IAAI,GAAG,MAAM,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC;IAClE,MAAM,cAAc,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,GAAG,EAAE,gBAAgB,EAAE,CAAC,CAAC;IAC9E,MAAM,UAAU,GAAG,4BAAY,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;IAEjG,4GAA4G;IAC5G,8GAA8G;IAC9G,MAAM,QAAQ,GAAG,UAAU,CAAC,oBAAoB,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;IAClG,IAAI,CAAC,QAAQ,EAAE,CAAC;QACd,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,KAAK,MAAM,SAAS,IAAI,QAAQ,CAAC,UAAU,EAAE,CAAC;QAC5C,IAAI,SAAS,CAAC,UAAU,KAAK,EAAE,EAAE,CAAC;YAChC,SAAS;QACX,CAAC;QACD,MAAM,UAAU,GAAG,gBAAO,CAAC,OAAO,CAAC;YACjC,IAAI,EAAE,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,SAAS,CAAC,UAAU,EAAE,CAAC;SAC5D,CAAC,CAAC;QACH,IACE,SAAS,CAAC,OAAO,EAAE;YACnB,CAAC,UAAU,KAAK,EAAE;gBAChB,CAAC,SAAS,CAAC,IAAI,CAAC,aAAa,KAAK,QAAQ,CAAC,KAAK,CAAC,aAAa;oBAC5D,UAAU,KAAK,iBAAiB;oBAChC,UAAU,KAAK,aAAa,CAAC,CAAC,EAClC,CAAC;YACD,OAAO,SAAS,CAAC;QACnB,CAAC;IACH,CAAC;IAED,MAAM,aAAa,GACjB,SAAS,KAAK,SAAS;QACrB,CAAC,CAAC,SAAS;QACX,CAAC,CAAC,MAAM,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC;IAClE,MAAM,WAAW,GAAc,EAAE,CAAC;IAClC,IAAI,CAAC,YAAY,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,aAAa,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC;QACzE,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,yGAAyG;IACzG,MAAM,QAAQ,GAAG,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;IACpE,IACE,UAAU,KAAK,EAAE;QACjB,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,KAAK,iBAAiB;QACrD,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC;QACvB,QAAQ,CAAC,MAAM,KAAK,CAAC,EACrB,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,iBAAiB,GAAG,UAAU;SACjC,oBAAoB,CAAC,OAAO,CAAC;SAC7B,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,aAAa,CAAC,CAAC;IACjD,MAAM,UAAU,GAAG,IAAI,GAAG,CACxB,iBAAiB,EAAE,UAAU,CAAC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,IAAI,EAAE,CAC7E,CAAC;IACF,MAAM,SAAS,GAAG,IAAI,GAAG,CACvB,WAAW;SACR,MAAM,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;SACnD,GAAG,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,MAAM,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,CACrF,CAAC;IAEF,qGAAqG;IACrG,IAAI,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;QACxB,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,KAAK,GAAG,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;IAC/C,MAAM,OAAO,GAAG,CAAC,SAAiB,EAAE,EAAE,CACpC,SAAS,KAAK,IAAI;QAClB,SAAS,CAAC,GAAG,CAAC,SAAS,CAAC;QACxB,CAAC,SAAS,KAAK,aAAa,IAAI,gBAAgB,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;IAChF,MAAM,IAAI,GAAG,aAAa,IAAI,UAAU,CAAC;IACzC,IAAI,SAAS,GAAG,IAAI,CAAC;IACrB,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,OAAO,CAAC,SAAS,CAAC,EAAE,KAAK,IAAI,CAAC,EAAE,CAAC;QACnD,SAAS,GAAG,GAAG,IAAI,GAAG,KAAK,EAAE,CAAC;IAChC,CAAC;IAED,MAAM,QAAQ,GAAG,UAAU,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;IAC3D,MAAM,QAAQ,GAAG,CAAC,KAAmC,EAAE,KAAmC,EAAE,EAAE,CAC5F,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,CAAC;IAC7F,IACE,QAAQ,CAAC,IAAI,CACX,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,EAAE,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,EAAE,OAAO,CAAC,KAAK,CAAC,CAC9F,EACD,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;IACvC,IAAI,SAAS,GAAG,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;IACzC,IAAI,SAAS,KAAK,aAAa,IAAI,UAAU,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;QACvD,MAAM,KAAK,GAAG,CAAC,GAAG,UAAU,CAAC;aAC1B,MAAM,CAAC,4BAAY,CAAC,MAAM,CAAC;aAC3B,GAAG,CAAC,CAAC,UAAU,EAAE,EAAE;YAClB,MAAM,MAAM,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;YAC3D,MAAM,WAAW,GACf,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,UAAU;gBAChD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,WAAW,EAAE,CAAC,KAAK,IAAI,CAAC;YAEjE,OAAO;gBACL,KAAK,EAAE,UAAU,CAAC,KAAK,IAAI,CAAC,CAAC,EAAE,CAAC,CAAC;gBACjC,IAAI,EAAE,WAAW,CAAC,CAAC,CAAC,GAAG,aAAa,KAAK,SAAS,EAAE,CAAC,CAAC,CAAC,SAAS;aACjE,CAAC;QACJ,CAAC,CAAC;aACD,IAAI,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAEzD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,SAAS;gBACP,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,SAAS,CAAC;oBAC7C,IAAI,CAAC,IAAI;oBACT,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,SAAS,CAAC,CAAC;QAC/C,CAAC;IACH,CAAC;IAED,OAAO;QACL,WAAW;QACX,IAAI;QACJ,IAAI;QACJ,UAAU;QACV,YAAY,EAAE,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC;QAC1C,SAAS;QACT,WAAW,EAAE,UAAU,CAAC,IAAI,GAAG,CAAC;QAChC,SAAS;KACV,CAAC;AACJ,CAAC,CAAC;AAEF;;;;;;;;;;;;;GAaG;AACH,MAAa,uBAAuB;aAClB,SAAI,GAAG,GAAG,+BAAsB,yBAAyB,CAAC;aAE1D,SAAI,GAAoB;QACtC,IAAI,EAAE;YACJ,IAAI,EAAE,YAAY;YAClB,OAAO,EAAE,MAAM;YACf,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE;gBACR,KAAK,EACH,6HAA6H;gBAC/H,UAAU,EACR,8LAA8L;aACjM;SACF;QACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;YAClB,MAAM,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;YAE/B,OAAO;gBACL,CAAC,qBAAY,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBACnD,MAAM,MAAM,GAAG,2CAAmB,CAAC,aAAa,CAAC;wBAC/C,IAAI,EAAE,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC;qBACnD,CAAC,CAAC;oBACH,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;wBACzB,OAAO;oBACT,CAAC;oBAED,MAAM,IAAI,GAAG,OAAO,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;oBAEtD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,IAAI,EAAE,IAAI,KAAK,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,OAAO;wBAC1D,IAAI,EAAE,EAAE,MAAM,EAAE;wBAChB,GAAG,EAAE,IAAI;4BACP,CAAC,CAAC,CAAC,KAAK,EAAE,EAAE;gCACR,MAAM,MAAM,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,WAAW,EAAE,UAAU,EAAE,CAAC,CAAC;gCAC7E,MAAM,KAAK,GAAG,GAAG,MAAM,IAAI,CAAC;gCAC5B,oGAAoG;gCACpG,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,UAAU,IAAI,CAAC,SAAS,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC;gCAE3E,OAAO,KAAK,CAAC,WAAW,CACtB,IAAI,CAAC,WAAW,EAChB;oCACE,OAAO,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC,UAAU,GAAG;oCACrC,GAAG,MAAM,OAAO;oCAChB,GAAG,KAAK,GAAG,IAAI,CAAC,IAAI,YAAY,IAAI,CAAC,YAAY,GAAG;oCACpD,GAAG,MAAM,KAAK,IAAI,IAAI;oCACtB,GAAG,KAAK,GAAG,IAAI,CAAC,IAAI,MAAM,IAAI,CAAC,SAAS,GAAG;oCAC3C,GAAG,MAAM,GAAG;iCACb,CAAC,IAAI,CAAC,IAAI,CAAC,CACb,CAAC;4BACJ,CAAC;4BACH,CAAC,CAAC,IAAI;qBACT,CAAC,CAAC;gBACL,CAAC;aACF,CAAC;QACJ,CAAC;KACF,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,OAAqC,EAAE;QAClD,OAAO,IAAI,CAAC,QAAQ,IAAI,OAAO,CAAC;IAClC,CAAC;;AA7DH,0DA8DC","sourcesContent":["import type { Rule, Scope, SourceCode } from 'eslint';\nimport type { TRuleSeverity } from '../rules/common';\nimport { AwaitSupport } from './await-support';\nimport { AstNode, AstNodeTypes, HOUSE_PLUGIN_NAMESPACE } from './common';\nimport { PromiseChainSupport } from './promise-chain-support';\n\nconst STATEMENT_LISTS = new Set(['BlockStatement', 'Program', 'StaticBlock', 'SwitchCase']);\n/** The catch variable the fix writes when the handler has no parameter. */\nconst CATCH_NAME = 'error';\n\n/** What the fix needs, read once from a `const x = await f().catch(h)` that passed every check. */\ninterface IFixPlan {\n  declaration: Rule.Node;\n  kind: string;\n  name: string;\n  annotation: string;\n  receiverText: string;\n  catchName: string;\n  isErrorRead: boolean;\n  valueText: string;\n}\n\n/** The identifiers a fallback value reads, and whether every node of it is a value the fix may move. */\nconst collectValue = (opts: {\n  node: unknown;\n  parameter: string | undefined;\n  identifiers: unknown[];\n}): boolean => {\n  const { node, parameter, identifiers } = opts;\n  const type = AstNode.getType({ node }) ?? '';\n  const value = (child: unknown) => collectValue({ node: child, parameter, identifiers });\n\n  switch (type) {\n    case 'Literal': {\n      return true;\n    }\n    case 'Identifier': {\n      identifiers.push(node);\n      return true;\n    }\n    case 'TemplateLiteral': {\n      return PromiseChainSupport.isConstant({ node });\n    }\n    case 'UnaryExpression': {\n      return PromiseChainSupport.isConstant({ node });\n    }\n    case 'ChainExpression': {\n      return value(AstNode.readField({ node, key: 'expression' }));\n    }\n    case 'MemberExpression': {\n      // Only a read of the error itself: `error.message`, `error?.response.status`.\n      const object = AstNode.readField({ node, key: 'object' });\n      const isRead =\n        AstNode.readField({ node, key: 'computed' }) !== true ||\n        AstNode.getType({ node: AstNode.readField({ node, key: 'property' }) }) === 'Literal';\n      const isRooted =\n        AstNode.getType({ node: object }) === 'MemberExpression' ||\n        (AstNode.getType({ node: object }) === 'Identifier' &&\n          AstNode.readField({ node: object, key: 'name' }) === parameter);\n\n      return isRead && isRooted && parameter !== undefined && value(object);\n    }\n    case 'ArrayExpression': {\n      const elements = AstNode.readField({ node, key: 'elements' });\n      return (\n        Array.isArray(elements) && elements.every((element) => element === null || value(element))\n      );\n    }\n    case 'ObjectExpression': {\n      const properties = AstNode.readField({ node, key: 'properties' });\n      return (\n        Array.isArray(properties) &&\n        properties.every(\n          (property) =>\n            AstNode.getType({ node: property }) === 'Property' &&\n            AstNode.readField({ node: property, key: 'computed' }) !== true &&\n            AstNode.readField({ node: property, key: 'method' }) !== true &&\n            AstNode.readField({ node: property, key: 'kind' }) === 'init' &&\n            value(AstNode.readField({ node: property, key: 'value' })),\n        )\n      );\n    }\n    default: {\n      return false;\n    }\n  }\n};\n\n/** Whether `name` is declared in `scope` or any scope around it: a catch variable of that name would shadow it. */\nconst isDeclaredAround = (opts: { scope: Scope.Scope | null; name: string }): boolean => {\n  for (let scope = opts.scope; scope; scope = scope.upper) {\n    if (scope.set.has(opts.name)) {\n      return true;\n    }\n  }\n\n  return false;\n};\n\n/**\n * The plan of the fix for `awaitNode`, or `undefined` when the strict safe shape does not hold:\n * `const|let x[: T] = await f().catch(() => <value>)` or `.catch((error) => <value>)`, alone in its declaration,\n * in a statement list; `x` never written again and, without a type annotation, read only in its own function;\n * the handler an expression-bodied, non-async arrow with at most one plain parameter; `<value>` a literal, an\n * identifier, a read of the error (`error.message`) or an array or object literal of those; `f()` with no\n * `.then`, `.catch` or `.finally` before and no `await` inside; no comment the fix would drop.\n */\nconst planFix = (opts: { awaitNode: Rule.Node; sourceCode: SourceCode }): IFixPlan | undefined => {\n  const { awaitNode, sourceCode } = opts;\n  const call = AstNode.readField({ node: awaitNode, key: 'argument' });\n  const callee = AstNode.readField({ node: call, key: 'callee' });\n  const args = AstNode.readField({ node: call, key: 'arguments' });\n\n  if (\n    AstNode.getType({ node: call }) !== 'CallExpression' ||\n    AstNode.readField({ node: call, key: 'optional' }) === true ||\n    AstNode.getType({ node: callee }) !== 'MemberExpression' ||\n    AstNode.readField({ node: callee, key: 'computed' }) === true ||\n    AstNode.readField({ node: callee, key: 'optional' }) === true ||\n    PromiseChainSupport.memberName({ member: callee }) !== 'catch' ||\n    !Array.isArray(args) ||\n    args.length !== 1\n  ) {\n    return undefined;\n  }\n\n  const handler: unknown = args[0];\n  const params = AstNode.readField({ node: handler, key: 'params' });\n  const body = AstNode.readField({ node: handler, key: 'body' });\n  const parameter: unknown = Array.isArray(params) ? params[0] : undefined;\n\n  if (\n    AstNode.getType({ node: handler }) !== 'ArrowFunctionExpression' ||\n    AstNode.readField({ node: handler, key: 'async' }) === true ||\n    AstNode.getType({ node: body }) === 'BlockStatement' ||\n    AstNode.readField({ node: handler, key: 'returnType' }) ||\n    AstNode.readField({ node: handler, key: 'typeParameters' }) ||\n    !Array.isArray(params) ||\n    params.length > 1 ||\n    (parameter !== undefined &&\n      (AstNode.getType({ node: parameter }) !== 'Identifier' ||\n        AstNode.readField({ node: parameter, key: 'typeAnnotation' }) ||\n        AstNode.readField({ node: parameter, key: 'optional' }) === true))\n  ) {\n    return undefined;\n  }\n\n  const receiver = AstNode.readField({ node: callee, key: 'object' });\n  if (\n    !AwaitSupport.isNode(receiver) ||\n    !AwaitSupport.isNode(body) ||\n    !AwaitSupport.isNode(handler) ||\n    PromiseChainSupport.hasChainOnSpine({ node: receiver }) ||\n    /\\b(await|yield)\\b/.test(sourceCode.getText(receiver))\n  ) {\n    return undefined;\n  }\n\n  const declarator = AwaitSupport.parentOf({ node: awaitNode });\n  const declaration = AwaitSupport.parentOf({ node: declarator });\n  const id = AstNode.readField({ node: declarator, key: 'id' });\n  const declarations = AstNode.readField({ node: declaration, key: 'declarations' });\n  const kind = String(AstNode.readField({ node: declaration, key: 'kind' }));\n\n  if (\n    AstNode.getType({ node: declarator }) !== 'VariableDeclarator' ||\n    AstNode.readField({ node: declarator, key: 'init' }) !== awaitNode ||\n    AstNode.readField({ node: declarator, key: 'definite' }) === true ||\n    AstNode.getType({ node: id }) !== 'Identifier' ||\n    !AwaitSupport.isNode(declarator) ||\n    !AwaitSupport.isNode(declaration) ||\n    !Array.isArray(declarations) ||\n    declarations.length !== 1 ||\n    !['const', 'let'].includes(kind) ||\n    !STATEMENT_LISTS.has(\n      AstNode.getType({ node: AwaitSupport.parentOf({ node: declaration }) }) ?? '',\n    )\n  ) {\n    return undefined;\n  }\n\n  const name = String(AstNode.readField({ node: id, key: 'name' }));\n  const typeAnnotation = AstNode.readField({ node: id, key: 'typeAnnotation' });\n  const annotation = AwaitSupport.isNode(typeAnnotation) ? sourceCode.getText(typeAnnotation) : '';\n\n  // `let x;` with no annotation takes its type from the assignments that follow, so TypeScript must see every\n  // read in the same function: a read from a nested function, an export or a `typeof` makes it an implicit any.\n  const variable = sourceCode.getDeclaredVariables(declarator).find((entry) => entry.name === name);\n  if (!variable) {\n    return undefined;\n  }\n  for (const reference of variable.references) {\n    if (reference.identifier === id) {\n      continue;\n    }\n    const parentType = AstNode.getType({\n      node: AwaitSupport.parentOf({ node: reference.identifier }),\n    });\n    if (\n      reference.isWrite() ||\n      (annotation === '' &&\n        (reference.from.variableScope !== variable.scope.variableScope ||\n          parentType === 'ExportSpecifier' ||\n          parentType === 'TSTypeQuery'))\n    ) {\n      return undefined;\n    }\n  }\n\n  const parameterName =\n    parameter === undefined\n      ? undefined\n      : String(AstNode.readField({ node: parameter, key: 'name' }));\n  const identifiers: unknown[] = [];\n  if (!collectValue({ node: body, parameter: parameterName, identifiers })) {\n    return undefined;\n  }\n\n  // `x = []` on a `let x;` with no annotation makes an evolving `any[]`, looser than the `never[]` it was.\n  const elements = AstNode.readField({ node: body, key: 'elements' });\n  if (\n    annotation === '' &&\n    AstNode.getType({ node: body }) === 'ArrayExpression' &&\n    Array.isArray(elements) &&\n    elements.length === 0\n  ) {\n    return undefined;\n  }\n\n  const parameterVariable = sourceCode\n    .getDeclaredVariables(handler)\n    .find((entry) => entry.name === parameterName);\n  const errorReads = new Set<unknown>(\n    parameterVariable?.references.map((reference) => reference.identifier) ?? [],\n  );\n  const freeNames = new Set(\n    identifiers\n      .filter((identifier) => !errorReads.has(identifier))\n      .map((identifier) => String(AstNode.readField({ node: identifier, key: 'name' }))),\n  );\n\n  // The fallback is evaluated after the `let`: reading the declared name there would read `undefined`.\n  if (freeNames.has(name)) {\n    return undefined;\n  }\n\n  const scope = sourceCode.getScope(declaration);\n  const isTaken = (candidate: string) =>\n    candidate === name ||\n    freeNames.has(candidate) ||\n    (candidate !== parameterName && isDeclaredAround({ scope, name: candidate }));\n  const base = parameterName ?? CATCH_NAME;\n  let catchName = base;\n  for (let index = 2; isTaken(catchName); index += 1) {\n    catchName = `${base}${index}`;\n  }\n\n  const comments = sourceCode.getCommentsInside(declaration);\n  const isInside = (range: [number, number] | undefined, inner: [number, number] | undefined) =>\n    range !== undefined && inner !== undefined && range[0] <= inner[0] && inner[1] <= range[1];\n  if (\n    comments.some(\n      (comment) => !isInside(receiver.range, comment.range) && !isInside(body.range, comment.range),\n    )\n  ) {\n    return undefined;\n  }\n\n  const bodyStart = body.range?.[0] ?? 0;\n  let valueText = sourceCode.getText(body);\n  if (catchName !== parameterName && errorReads.size > 0) {\n    const edits = [...errorReads]\n      .filter(AwaitSupport.isNode)\n      .map((identifier) => {\n        const parent = AwaitSupport.parentOf({ node: identifier });\n        const isShorthand =\n          AstNode.getType({ node: parent }) === 'Property' &&\n          AstNode.readField({ node: parent, key: 'shorthand' }) === true;\n\n        return {\n          range: identifier.range ?? [0, 0],\n          text: isShorthand ? `${parameterName}: ${catchName}` : catchName,\n        };\n      })\n      .sort((left, right) => right.range[0] - left.range[0]);\n\n    for (const edit of edits) {\n      valueText =\n        valueText.slice(0, edit.range[0] - bodyStart) +\n        edit.text +\n        valueText.slice(edit.range[1] - bodyStart);\n    }\n  }\n\n  return {\n    declaration,\n    kind,\n    name,\n    annotation,\n    receiverText: sourceCode.getText(receiver),\n    catchName,\n    isErrorRead: errorReads.size > 0,\n    valueText,\n  };\n};\n\n/**\n * `venizia/no-await-promise-chain`. One expression uses one async style: `await` (in a try/catch when it can\n * fail), or a promise chain that is not awaited. An `await` whose operand - after parentheses, `!`, `as`,\n * `satisfies` and an optional chain - is a call of `.then`, `.catch` or `.finally` (`?.then(`, `['then'](`, a\n * thenable such as a query builder) is reported once, however long the chain. A chain that is returned or stands\n * as a statement is not awaited and is not reported, nor is `await Promise.all(xs.map(f))`, `await new Promise(...)`,\n * `await x.then` (no call), or an `await` inside a callback of a chain.\n *\n * The fix is made for one shape only, `const|let x = await f().catch(() => <value>)` (see `planFix` for every\n * condition), and writes `let x; try { x = await f(); } catch (error) { x = <value>; }` (`catch { ... }` when the value does not read the error): the `const` becomes a\n * `let`, a type annotation stays, the catch variable takes the handler's parameter name (`error` without one,\n * renamed when the name is taken), and is typed `any` when the value reads it, as the handler's parameter was.\n * The try also catches a synchronous throw of `f()`, which the chain let through. Everything else is reported.\n */\nexport class NoAwaitPromiseChainRule {\n  static readonly NAME = `${HOUSE_PLUGIN_NAMESPACE}/no-await-promise-chain`;\n\n  static readonly RULE: Rule.RuleModule = {\n    meta: {\n      type: 'suggestion',\n      fixable: 'code',\n      schema: [],\n      messages: {\n        mixed:\n          'Do not `await` a promise chain (`.{{method}}(...)`): wrap `await f()` in try/catch, or drop the `await` and keep the chain.',\n        mixedConst:\n          'Do not `await` a promise chain (`.{{method}}(...)`): wrap `await f()` in try/catch, or drop the `await` and keep the chain. The fix writes the try/catch and turns the `const` into a `let`.',\n      },\n    },\n    create: (context) => {\n      const { sourceCode } = context;\n\n      return {\n        [AstNodeTypes.AWAIT_EXPRESSION]: (node: Rule.Node) => {\n          const method = PromiseChainSupport.chainMethodOf({\n            node: AstNode.readField({ node, key: 'argument' }),\n          });\n          if (method === undefined) {\n            return;\n          }\n\n          const plan = planFix({ awaitNode: node, sourceCode });\n\n          context.report({\n            node,\n            messageId: plan?.kind === 'const' ? 'mixedConst' : 'mixed',\n            data: { method },\n            fix: plan\n              ? (fixer) => {\n                  const indent = AwaitSupport.indentOf({ node: plan.declaration, sourceCode });\n                  const inner = `${indent}  `;\n                  // The optional catch binding when nothing reads the error: a named one would be an unused variable.\n                  const head = plan.isErrorRead ? `catch (${plan.catchName}: any)` : 'catch';\n\n                  return fixer.replaceText(\n                    plan.declaration,\n                    [\n                      `let ${plan.name}${plan.annotation};`,\n                      `${indent}try {`,\n                      `${inner}${plan.name} = await ${plan.receiverText};`,\n                      `${indent}} ${head} {`,\n                      `${inner}${plan.name} = ${plan.valueText};`,\n                      `${indent}}`,\n                    ].join('\\n'),\n                  );\n                }\n              : null,\n          });\n        },\n      };\n    },\n  };\n\n  static build(opts: { severity?: TRuleSeverity } = {}): TRuleSeverity {\n    return opts.severity ?? 'error';\n  }\n}\n"]}

package/dist/linters/house/no-inline-await.rule.d.ts

@@ -0,0 +1,20 @@
+import type { Rule } from 'eslint';
+import type { TRuleSeverity } from '../rules/common';
+/**
+ * `venizia/no-inline-await`. `await` stands alone: as a whole statement (`await f();`) or as the whole initializer
+ * of a declaration (`const result = await f();`). Inside any other expression - a call argument, a spread, an
+ * array or object, a ternary, a logical operator, a template literal, a member access, an assignment - it is
+ * reported, and `return g(await f())` is the same report. `return await f()` is `no-return-await`'s.
+ *
+ * The fix moves the `await` into a `const` in front of the statement. It is made only when nothing that does more
+ * than read a value runs before the `await` inside the statement, and when the `await` is not in a branch, a loop
+ * test, an unbraced `if` branch or an arrow expression body; those cases are reported and left alone.
+ */
+export declare class NoInlineAwaitRule {
+    static readonly NAME = "venizia/no-inline-await";
+    static readonly RULE: Rule.RuleModule;
+    static build(opts?: {
+        severity?: TRuleSeverity;
+    }): TRuleSeverity;
+}
+//# sourceMappingURL=no-inline-await.rule.d.ts.map

package/dist/linters/house/no-inline-await.rule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-inline-await.rule.d.ts","sourceRoot":"","sources":["../../../src/linters/house/no-inline-await.rule.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AACnC,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAIrD;;;;;;;;;GASG;AACH,qBAAa,iBAAiB;IAC5B,MAAM,CAAC,QAAQ,CAAC,IAAI,6BAA+C;IAEnE,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,CA0DnC;IAEF,MAAM,CAAC,KAAK,CAAC,IAAI,GAAE;QAAE,QAAQ,CAAC,EAAE,aAAa,CAAA;KAAO,GAAG,aAAa;CAGrE"}

package/dist/linters/house/no-inline-await.rule.js

@@ -0,0 +1,70 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoInlineAwaitRule = void 0;
+const await_support_1 = require("./await-support");
+const common_1 = require("./common");
+/**
+ * `venizia/no-inline-await`. `await` stands alone: as a whole statement (`await f();`) or as the whole initializer
+ * of a declaration (`const result = await f();`). Inside any other expression - a call argument, a spread, an
+ * array or object, a ternary, a logical operator, a template literal, a member access, an assignment - it is
+ * reported, and `return g(await f())` is the same report. `return await f()` is `no-return-await`'s.
+ *
+ * The fix moves the `await` into a `const` in front of the statement. It is made only when nothing that does more
+ * than read a value runs before the `await` inside the statement, and when the `await` is not in a branch, a loop
+ * test, an unbraced `if` branch or an arrow expression body; those cases are reported and left alone.
+ */
+class NoInlineAwaitRule {
+    static { this.NAME = `${common_1.HOUSE_PLUGIN_NAMESPACE}/no-inline-await`; }
+    static { this.RULE = {
+        meta: {
+            type: 'suggestion',
+            fixable: 'code',
+            schema: [],
+            messages: {
+                inline: '`await` stands alone as a statement or as the whole initializer of a declaration (`const result = await f();`), not inside an expression.',
+            },
+        },
+        create: (context) => {
+            const { sourceCode } = context;
+            return {
+                [common_1.AstNodeTypes.AWAIT_EXPRESSION]: (node) => {
+                    const parent = await_support_1.AwaitSupport.parentOf({ node });
+                    const parentType = common_1.AstNode.getType({ node: parent });
+                    const isWhole = (parentType === 'ExpressionStatement' &&
+                        common_1.AstNode.readField({ node: parent, key: 'expression' }) === node) ||
+                        (parentType === 'VariableDeclarator' &&
+                            common_1.AstNode.readField({ node: parent, key: 'init' }) === node);
+                    const isReturned = (parentType === 'ReturnStatement' || parentType === 'ArrowFunctionExpression') &&
+                        (common_1.AstNode.readField({ node: parent, key: 'argument' }) === node ||
+                            common_1.AstNode.readField({ node: parent, key: 'body' }) === node);
+                    if (isWhole || isReturned) {
+                        return;
+                    }
+                    const statement = await_support_1.AwaitSupport.hoistTarget({ awaitNode: node });
+                    const canFix = statement !== undefined &&
+                        !await_support_1.AwaitSupport.hasEffectBefore({ statement, awaitNode: node, sourceCode });
+                    context.report({
+                        node,
+                        messageId: 'inline',
+                        fix: canFix
+                            ? (fixer) => {
+                                const name = await_support_1.AwaitSupport.freshName({ node, base: 'result', sourceCode });
+                                const [start, end] = await_support_1.AwaitSupport.replaceRangeOf({ awaitNode: node, sourceCode });
+                                const indent = await_support_1.AwaitSupport.indentOf({ node: statement, sourceCode });
+                                return [
+                                    fixer.insertTextBefore(statement, `const ${name} = ${sourceCode.getText(node)};\n${indent}`),
+                                    fixer.replaceTextRange([start, end], name),
+                                ];
+                            }
+                            : null,
+                    });
+                },
+            };
+        },
+    }; }
+    static build(opts = {}) {
+        return opts.severity ?? 'error';
+    }
+}
+exports.NoInlineAwaitRule = NoInlineAwaitRule;
+//# sourceMappingURL=no-inline-await.rule.js.map

package/dist/linters/house/no-inline-await.rule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-inline-await.rule.js","sourceRoot":"","sources":["../../../src/linters/house/no-inline-await.rule.ts"],"names":[],"mappings":";;;AAEA,mDAA+C;AAC/C,qCAAyE;AAEzE;;;;;;;;;GASG;AACH,MAAa,iBAAiB;aACZ,SAAI,GAAG,GAAG,+BAAsB,kBAAkB,CAAC;aAEnD,SAAI,GAAoB;QACtC,IAAI,EAAE;YACJ,IAAI,EAAE,YAAY;YAClB,OAAO,EAAE,MAAM;YACf,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE;gBACR,MAAM,EACJ,2IAA2I;aAC9I;SACF;QACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;YAClB,MAAM,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;YAE/B,OAAO;gBACL,CAAC,qBAAY,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBACnD,MAAM,MAAM,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;oBAC/C,MAAM,UAAU,GAAG,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,CAAC;oBACrD,MAAM,OAAO,GACX,CAAC,UAAU,KAAK,qBAAqB;wBACnC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,YAAY,EAAE,CAAC,KAAK,IAAI,CAAC;wBAClE,CAAC,UAAU,KAAK,oBAAoB;4BAClC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,IAAI,CAAC,CAAC;oBAC/D,MAAM,UAAU,GACd,CAAC,UAAU,KAAK,iBAAiB,IAAI,UAAU,KAAK,yBAAyB,CAAC;wBAC9E,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,KAAK,IAAI;4BAC5D,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,IAAI,CAAC,CAAC;oBAE/D,IAAI,OAAO,IAAI,UAAU,EAAE,CAAC;wBAC1B,OAAO;oBACT,CAAC;oBAED,MAAM,SAAS,GAAG,4BAAY,CAAC,WAAW,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;oBAChE,MAAM,MAAM,GACV,SAAS,KAAK,SAAS;wBACvB,CAAC,4BAAY,CAAC,eAAe,CAAC,EAAE,SAAS,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;oBAE5E,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,QAAQ;wBACnB,GAAG,EAAE,MAAM;4BACT,CAAC,CAAC,CAAC,KAAK,EAAE,EAAE;gCACR,MAAM,IAAI,GAAG,4BAAY,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,UAAU,EAAE,CAAC,CAAC;gCAC1E,MAAM,CAAC,KAAK,EAAE,GAAG,CAAC,GAAG,4BAAY,CAAC,cAAc,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;gCAClF,MAAM,MAAM,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,UAAU,EAAE,CAAC,CAAC;gCAEtE,OAAO;oCACL,KAAK,CAAC,gBAAgB,CACpB,SAAS,EACT,SAAS,IAAI,MAAM,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,MAAM,MAAM,EAAE,CAC1D;oCACD,KAAK,CAAC,gBAAgB,CAAC,CAAC,KAAK,EAAE,GAAG,CAAC,EAAE,IAAI,CAAC;iCAC3C,CAAC;4BACJ,CAAC;4BACH,CAAC,CAAC,IAAI;qBACT,CAAC,CAAC;gBACL,CAAC;aACF,CAAC;QACJ,CAAC;KACF,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,OAAqC,EAAE;QAClD,OAAO,IAAI,CAAC,QAAQ,IAAI,OAAO,CAAC;IAClC,CAAC;;AAjEH,8CAkEC","sourcesContent":["import type { Rule } from 'eslint';\nimport type { TRuleSeverity } from '../rules/common';\nimport { AwaitSupport } from './await-support';\nimport { AstNode, AstNodeTypes, HOUSE_PLUGIN_NAMESPACE } from './common';\n\n/**\n * `venizia/no-inline-await`. `await` stands alone: as a whole statement (`await f();`) or as the whole initializer\n * of a declaration (`const result = await f();`). Inside any other expression - a call argument, a spread, an\n * array or object, a ternary, a logical operator, a template literal, a member access, an assignment - it is\n * reported, and `return g(await f())` is the same report. `return await f()` is `no-return-await`'s.\n *\n * The fix moves the `await` into a `const` in front of the statement. It is made only when nothing that does more\n * than read a value runs before the `await` inside the statement, and when the `await` is not in a branch, a loop\n * test, an unbraced `if` branch or an arrow expression body; those cases are reported and left alone.\n */\nexport class NoInlineAwaitRule {\n  static readonly NAME = `${HOUSE_PLUGIN_NAMESPACE}/no-inline-await`;\n\n  static readonly RULE: Rule.RuleModule = {\n    meta: {\n      type: 'suggestion',\n      fixable: 'code',\n      schema: [],\n      messages: {\n        inline:\n          '`await` stands alone as a statement or as the whole initializer of a declaration (`const result = await f();`), not inside an expression.',\n      },\n    },\n    create: (context) => {\n      const { sourceCode } = context;\n\n      return {\n        [AstNodeTypes.AWAIT_EXPRESSION]: (node: Rule.Node) => {\n          const parent = AwaitSupport.parentOf({ node });\n          const parentType = AstNode.getType({ node: parent });\n          const isWhole =\n            (parentType === 'ExpressionStatement' &&\n              AstNode.readField({ node: parent, key: 'expression' }) === node) ||\n            (parentType === 'VariableDeclarator' &&\n              AstNode.readField({ node: parent, key: 'init' }) === node);\n          const isReturned =\n            (parentType === 'ReturnStatement' || parentType === 'ArrowFunctionExpression') &&\n            (AstNode.readField({ node: parent, key: 'argument' }) === node ||\n              AstNode.readField({ node: parent, key: 'body' }) === node);\n\n          if (isWhole || isReturned) {\n            return;\n          }\n\n          const statement = AwaitSupport.hoistTarget({ awaitNode: node });\n          const canFix =\n            statement !== undefined &&\n            !AwaitSupport.hasEffectBefore({ statement, awaitNode: node, sourceCode });\n\n          context.report({\n            node,\n            messageId: 'inline',\n            fix: canFix\n              ? (fixer) => {\n                  const name = AwaitSupport.freshName({ node, base: 'result', sourceCode });\n                  const [start, end] = AwaitSupport.replaceRangeOf({ awaitNode: node, sourceCode });\n                  const indent = AwaitSupport.indentOf({ node: statement, sourceCode });\n\n                  return [\n                    fixer.insertTextBefore(\n                      statement,\n                      `const ${name} = ${sourceCode.getText(node)};\\n${indent}`,\n                    ),\n                    fixer.replaceTextRange([start, end], name),\n                  ];\n                }\n              : null,\n          });\n        },\n      };\n    },\n  };\n\n  static build(opts: { severity?: TRuleSeverity } = {}): TRuleSeverity {\n    return opts.severity ?? 'error';\n  }\n}\n"]}

package/dist/linters/house/no-new-error.rule.js

@@ -19,16 +19,16 @@ class NoNewErrorRule {
         },
         create: (context) => {
             const report = (opts) => context.report({ node: opts.node, messageId: 'newError', data: { form: opts.form } });
-            const isErrorIdentifier = (callee) => (0, common_1.nodeType)({ node: callee }) === 'Identifier' &&
-                (0, common_1.readField)({ node: callee, key: 'name' }) === 'Error';
+            const isErrorIdentifier = (callee) => common_1.AstNode.getType({ node: callee }) === 'Identifier' &&
+                common_1.AstNode.readField({ node: callee, key: 'name' }) === 'Error';
             return {
                 [common_1.AstNodeTypes.NEW_EXPRESSION]: (node) => {
-                    if (isErrorIdentifier((0, common_1.readField)({ node, key: 'callee' }))) {
+                    if (isErrorIdentifier(common_1.AstNode.readField({ node, key: 'callee' }))) {
                         report({ node, form: 'new Error(...)' });
                     }
                 },
                 [common_1.AstNodeTypes.CALL_EXPRESSION]: (node) => {
-                    if (isErrorIdentifier((0, common_1.readField)({ node, key: 'callee' }))) {
+                    if (isErrorIdentifier(common_1.AstNode.readField({ node, key: 'callee' }))) {
                         report({ node, form: 'Error(...)' });
                     }
                 },

package/dist/linters/house/no-new-error.rule.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-new-error.rule.js","sourceRoot":"","sources":["../../../src/linters/house/no-new-error.rule.ts"],"names":[],"mappings":";;;AAEA,qCAAqF;AAErF;;;;GAIG;AACH,MAAa,cAAc;aACT,SAAI,GAAG,GAAG,+BAAsB,eAAe,CAAC;aAEhD,SAAI,GAAoB;QACtC,IAAI,EAAE;YACJ,IAAI,EAAE,SAAS;YACf,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE;gBACR,QAAQ,EACN,2IAA2I;aAC9I;SACF;QACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;YAClB,MAAM,MAAM,GAAG,CAAC,IAAuC,EAAE,EAAE,CACzD,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,UAAU,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YAExF,MAAM,iBAAiB,GAAG,CAAC,MAAe,EAAE,EAAE,CAC5C,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,YAAY;gBAC3C,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,OAAO,CAAC;YAEvD,OAAO;gBACL,CAAC,qBAAY,CAAC,cAAc,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBACjD,IAAI,iBAAiB,CAAC,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC,EAAE,CAAC;wBAC1D,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,gBAAgB,EAAE,CAAC,CAAC;oBAC3C,CAAC;gBACH,CAAC;gBACD,CAAC,qBAAY,CAAC,eAAe,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBAClD,IAAI,iBAAiB,CAAC,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC,EAAE,CAAC;wBAC1D,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC,CAAC;oBACvC,CAAC;gBACH,CAAC;aACF,CAAC;QACJ,CAAC;KACF,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,OAAqC,EAAE;QAClD,OAAO,IAAI,CAAC,QAAQ,IAAI,OAAO,CAAC;IAClC,CAAC;;AArCH,wCAsCC","sourcesContent":["import type { Rule } from 'eslint';\nimport type { TRuleSeverity } from '../rules/common';\nimport { AstNodeTypes, HOUSE_PLUGIN_NAMESPACE, nodeType, readField } from './common';\n\n/**\n * `venizia/no-new-error`. An error is thrown through `getError({ message })` (or an `ApplicationError`),\n * never `new Error(...)` or `Error(...)`: only an ApplicationError carries the status, the message code and\n * args, and the `extra` every IGNIS layer reads.\n */\nexport class NoNewErrorRule {\n  static readonly NAME = `${HOUSE_PLUGIN_NAMESPACE}/no-new-error`;\n\n  static readonly RULE: Rule.RuleModule = {\n    meta: {\n      type: 'problem',\n      schema: [],\n      messages: {\n        newError:\n          'Throw through getError({ message }) (or an ApplicationError), not `{{form}}`: only an ApplicationError carries the status, code and args.',\n      },\n    },\n    create: (context) => {\n      const report = (opts: { node: Rule.Node; form: string }) =>\n        context.report({ node: opts.node, messageId: 'newError', data: { form: opts.form } });\n\n      const isErrorIdentifier = (callee: unknown) =>\n        nodeType({ node: callee }) === 'Identifier' &&\n        readField({ node: callee, key: 'name' }) === 'Error';\n\n      return {\n        [AstNodeTypes.NEW_EXPRESSION]: (node: Rule.Node) => {\n          if (isErrorIdentifier(readField({ node, key: 'callee' }))) {\n            report({ node, form: 'new Error(...)' });\n          }\n        },\n        [AstNodeTypes.CALL_EXPRESSION]: (node: Rule.Node) => {\n          if (isErrorIdentifier(readField({ node, key: 'callee' }))) {\n            report({ node, form: 'Error(...)' });\n          }\n        },\n      };\n    },\n  };\n\n  static build(opts: { severity?: TRuleSeverity } = {}): TRuleSeverity {\n    return opts.severity ?? 'error';\n  }\n}\n"]}
+{"version":3,"file":"no-new-error.rule.js","sourceRoot":"","sources":["../../../src/linters/house/no-new-error.rule.ts"],"names":[],"mappings":";;;AAEA,qCAAyE;AAEzE;;;;GAIG;AACH,MAAa,cAAc;aACT,SAAI,GAAG,GAAG,+BAAsB,eAAe,CAAC;aAEhD,SAAI,GAAoB;QACtC,IAAI,EAAE;YACJ,IAAI,EAAE,SAAS;YACf,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE;gBACR,QAAQ,EACN,2IAA2I;aAC9I;SACF;QACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;YAClB,MAAM,MAAM,GAAG,CAAC,IAAuC,EAAE,EAAE,CACzD,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,SAAS,EAAE,UAAU,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YAExF,MAAM,iBAAiB,GAAG,CAAC,MAAe,EAAE,EAAE,CAC5C,gBAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,KAAK,YAAY;gBAClD,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,KAAK,OAAO,CAAC;YAE/D,OAAO;gBACL,CAAC,qBAAY,CAAC,cAAc,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBACjD,IAAI,iBAAiB,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC,EAAE,CAAC;wBAClE,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,gBAAgB,EAAE,CAAC,CAAC;oBAC3C,CAAC;gBACH,CAAC;gBACD,CAAC,qBAAY,CAAC,eAAe,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBAClD,IAAI,iBAAiB,CAAC,gBAAO,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,CAAC,EAAE,CAAC;wBAClE,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC,CAAC;oBACvC,CAAC;gBACH,CAAC;aACF,CAAC;QACJ,CAAC;KACF,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,OAAqC,EAAE;QAClD,OAAO,IAAI,CAAC,QAAQ,IAAI,OAAO,CAAC;IAClC,CAAC;;AArCH,wCAsCC","sourcesContent":["import type { Rule } from 'eslint';\nimport type { TRuleSeverity } from '../rules/common';\nimport { AstNode, AstNodeTypes, HOUSE_PLUGIN_NAMESPACE } from './common';\n\n/**\n * `venizia/no-new-error`. An error is thrown through `getError({ message })` (or an `ApplicationError`),\n * never `new Error(...)` or `Error(...)`: only an ApplicationError carries the status, the message code and\n * args, and the `extra` every IGNIS layer reads.\n */\nexport class NoNewErrorRule {\n  static readonly NAME = `${HOUSE_PLUGIN_NAMESPACE}/no-new-error`;\n\n  static readonly RULE: Rule.RuleModule = {\n    meta: {\n      type: 'problem',\n      schema: [],\n      messages: {\n        newError:\n          'Throw through getError({ message }) (or an ApplicationError), not `{{form}}`: only an ApplicationError carries the status, code and args.',\n      },\n    },\n    create: (context) => {\n      const report = (opts: { node: Rule.Node; form: string }) =>\n        context.report({ node: opts.node, messageId: 'newError', data: { form: opts.form } });\n\n      const isErrorIdentifier = (callee: unknown) =>\n        AstNode.getType({ node: callee }) === 'Identifier' &&\n        AstNode.readField({ node: callee, key: 'name' }) === 'Error';\n\n      return {\n        [AstNodeTypes.NEW_EXPRESSION]: (node: Rule.Node) => {\n          if (isErrorIdentifier(AstNode.readField({ node, key: 'callee' }))) {\n            report({ node, form: 'new Error(...)' });\n          }\n        },\n        [AstNodeTypes.CALL_EXPRESSION]: (node: Rule.Node) => {\n          if (isErrorIdentifier(AstNode.readField({ node, key: 'callee' }))) {\n            report({ node, form: 'Error(...)' });\n          }\n        },\n      };\n    },\n  };\n\n  static build(opts: { severity?: TRuleSeverity } = {}): TRuleSeverity {\n    return opts.severity ?? 'error';\n  }\n}\n"]}

package/dist/linters/house/no-return-await.rule.d.ts

@@ -0,0 +1,15 @@
+import type { Rule } from 'eslint';
+import type { TRuleSeverity } from '../rules/common';
+/**
+ * `venizia/no-return-await`. A function returns the promise (`return f()`), never `return await f()`. Where the
+ * `await` matters (inside `try`, `catch` or `finally`) it is written on its own line:
+ * `const result = await f(); return result;`. An arrow whose body is an `await` is the same: `() => f()`.
+ */
+export declare class NoReturnAwaitRule {
+    static readonly NAME = "venizia/no-return-await";
+    static readonly RULE: Rule.RuleModule;
+    static build(opts?: {
+        severity?: TRuleSeverity;
+    }): TRuleSeverity;
+}
+//# sourceMappingURL=no-return-await.rule.d.ts.map

package/dist/linters/house/no-return-await.rule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-return-await.rule.d.ts","sourceRoot":"","sources":["../../../src/linters/house/no-return-await.rule.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AACnC,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAyBrD;;;;GAIG;AACH,qBAAa,iBAAiB;IAC5B,MAAM,CAAC,QAAQ,CAAC,IAAI,6BAA+C;IAEnE,MAAM,CAAC,QAAQ,CAAC,IAAI,EAAE,IAAI,CAAC,UAAU,CA0EnC;IAEF,MAAM,CAAC,KAAK,CAAC,IAAI,GAAE;QAAE,QAAQ,CAAC,EAAE,aAAa,CAAA;KAAO,GAAG,aAAa;CAGrE"}

package/dist/linters/house/no-return-await.rule.js

@@ -0,0 +1,92 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoReturnAwaitRule = void 0;
+const await_support_1 = require("./await-support");
+const common_1 = require("./common");
+const FUNCTION_TYPES = new Set([
+    'FunctionDeclaration',
+    'FunctionExpression',
+    'ArrowFunctionExpression',
+]);
+const STATEMENT_LISTS = new Set(['BlockStatement', 'Program', 'StaticBlock', 'SwitchCase']);
+/** `node` sits inside a `try`, `catch` or `finally` of its own function. */
+const isInTry = (node) => {
+    let current = await_support_1.AwaitSupport.parentOf({ node });
+    while (current && !FUNCTION_TYPES.has(common_1.AstNode.getType({ node: current }) ?? '')) {
+        if (common_1.AstNode.getType({ node: current }) === 'TryStatement') {
+            return true;
+        }
+        current = await_support_1.AwaitSupport.parentOf({ node: current });
+    }
+    return false;
+};
+/**
+ * `venizia/no-return-await`. A function returns the promise (`return f()`), never `return await f()`. Where the
+ * `await` matters (inside `try`, `catch` or `finally`) it is written on its own line:
+ * `const result = await f(); return result;`. An arrow whose body is an `await` is the same: `() => f()`.
+ */
+class NoReturnAwaitRule {
+    static { this.NAME = `${common_1.HOUSE_PLUGIN_NAMESPACE}/no-return-await`; }
+    static { this.RULE = {
+        meta: {
+            type: 'suggestion',
+            fixable: 'code',
+            schema: [],
+            messages: {
+                returnAwait: 'Return the promise (`return f()`), not `return await f()`; where the await matters (inside try, catch or finally) write `const result = await f(); return result;`.',
+            },
+        },
+        create: (context) => {
+            const { sourceCode } = context;
+            const reportAwait = (opts) => {
+                const argument = common_1.AstNode.readField({ node: opts.awaitNode, key: 'argument' });
+                const argumentText = await_support_1.AwaitSupport.isNode(argument) &&
+                    common_1.AstNode.getType({ node: argument }) !== 'SequenceExpression'
+                    ? sourceCode.getText(argument)
+                    : undefined;
+                context.report({
+                    node: opts.reported,
+                    messageId: 'returnAwait',
+                    fix: argumentText === undefined
+                        ? null
+                        : (fixer) => {
+                            if (!opts.statement || !isInTry(opts.statement)) {
+                                return fixer.replaceText(opts.awaitNode, argumentText);
+                            }
+                            const outer = await_support_1.AwaitSupport.parentOf({ node: opts.statement });
+                            if (!STATEMENT_LISTS.has(common_1.AstNode.getType({ node: outer }) ?? '')) {
+                                return null;
+                            }
+                            const name = await_support_1.AwaitSupport.freshName({
+                                node: opts.statement,
+                                base: 'result',
+                                sourceCode,
+                            });
+                            const indent = await_support_1.AwaitSupport.indentOf({ node: opts.statement, sourceCode });
+                            return fixer.replaceText(opts.statement, `const ${name} = await ${argumentText};\n${indent}return ${name};`);
+                        },
+                });
+            };
+            return {
+                [common_1.AstNodeTypes.RETURN_STATEMENT]: (node) => {
+                    const argument = common_1.AstNode.readField({ node, key: 'argument' });
+                    if (await_support_1.AwaitSupport.isNode(argument) &&
+                        common_1.AstNode.getType({ node: argument }) === 'AwaitExpression') {
+                        reportAwait({ reported: node, awaitNode: argument, statement: node });
+                    }
+                },
+                [common_1.AstNodeTypes.ARROW_FUNCTION_EXPRESSION]: (node) => {
+                    const body = common_1.AstNode.readField({ node, key: 'body' });
+                    if (await_support_1.AwaitSupport.isNode(body) && common_1.AstNode.getType({ node: body }) === 'AwaitExpression') {
+                        reportAwait({ reported: node, awaitNode: body });
+                    }
+                },
+            };
+        },
+    }; }
+    static build(opts = {}) {
+        return opts.severity ?? 'error';
+    }
+}
+exports.NoReturnAwaitRule = NoReturnAwaitRule;
+//# sourceMappingURL=no-return-await.rule.js.map