@venizia/dev-configs 0.4.6 → 0.4.7-0

package/dist/linters/house/no-return-await.rule.js

@@ -0,0 +1,92 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoReturnAwaitRule = void 0;
+const await_support_1 = require("./await-support");
+const common_1 = require("./common");
+const FUNCTION_TYPES = new Set([
+    'FunctionDeclaration',
+    'FunctionExpression',
+    'ArrowFunctionExpression',
+]);
+const STATEMENT_LISTS = new Set(['BlockStatement', 'Program', 'StaticBlock', 'SwitchCase']);
+/** `node` sits inside a `try`, `catch` or `finally` of its own function. */
+const isInTry = (node) => {
+    let current = await_support_1.AwaitSupport.parentOf({ node });
+    while (current && !FUNCTION_TYPES.has((0, common_1.nodeType)({ node: current }) ?? '')) {
+        if ((0, common_1.nodeType)({ node: current }) === 'TryStatement') {
+            return true;
+        }
+        current = await_support_1.AwaitSupport.parentOf({ node: current });
+    }
+    return false;
+};
+/**
+ * `venizia/no-return-await`. A function returns the promise (`return f()`), never `return await f()`. Where the
+ * `await` matters (inside `try`, `catch` or `finally`) it is written on its own line:
+ * `const result = await f(); return result;`. An arrow whose body is an `await` is the same: `() => f()`.
+ */
+class NoReturnAwaitRule {
+    static { this.NAME = `${common_1.HOUSE_PLUGIN_NAMESPACE}/no-return-await`; }
+    static { this.RULE = {
+        meta: {
+            type: 'suggestion',
+            fixable: 'code',
+            schema: [],
+            messages: {
+                returnAwait: 'Return the promise (`return f()`), not `return await f()`; where the await matters (inside try, catch or finally) write `const result = await f(); return result;`.',
+            },
+        },
+        create: (context) => {
+            const { sourceCode } = context;
+            const taken = new Map();
+            const reportAwait = (opts) => {
+                const argument = (0, common_1.readField)({ node: opts.awaitNode, key: 'argument' });
+                const argumentText = await_support_1.AwaitSupport.isNode(argument) && (0, common_1.nodeType)({ node: argument }) !== 'SequenceExpression'
+                    ? sourceCode.getText(argument)
+                    : undefined;
+                context.report({
+                    node: opts.reported,
+                    messageId: 'returnAwait',
+                    fix: argumentText === undefined
+                        ? null
+                        : (fixer) => {
+                            if (!opts.statement || !isInTry(opts.statement)) {
+                                return fixer.replaceText(opts.awaitNode, argumentText);
+                            }
+                            const outer = await_support_1.AwaitSupport.parentOf({ node: opts.statement });
+                            if (!STATEMENT_LISTS.has((0, common_1.nodeType)({ node: outer }) ?? '')) {
+                                return null;
+                            }
+                            const name = await_support_1.AwaitSupport.freshName({
+                                node: opts.statement,
+                                base: 'result',
+                                sourceCode,
+                                taken,
+                            });
+                            const indent = await_support_1.AwaitSupport.indentOf({ node: opts.statement, sourceCode });
+                            return fixer.replaceText(opts.statement, `const ${name} = await ${argumentText};\n${indent}return ${name};`);
+                        },
+                });
+            };
+            return {
+                [common_1.AstNodeTypes.RETURN_STATEMENT]: (node) => {
+                    const argument = (0, common_1.readField)({ node, key: 'argument' });
+                    if (await_support_1.AwaitSupport.isNode(argument) && (0, common_1.nodeType)({ node: argument }) === 'AwaitExpression') {
+                        reportAwait({ reported: node, awaitNode: argument, statement: node });
+                    }
+                },
+                [common_1.AstNodeTypes.ARROW_FUNCTION_EXPRESSION]: (node) => {
+                    const body = (0, common_1.readField)({ node, key: 'body' });
+                    if (await_support_1.AwaitSupport.isNode(body) && (0, common_1.nodeType)({ node: body }) === 'AwaitExpression') {
+                        reportAwait({ reported: node, awaitNode: body });
+                    }
+                },
+            };
+        },
+    }; }
+    static build(opts = {}) {
+        return opts.severity ?? 'error';
+    }
+}
+exports.NoReturnAwaitRule = NoReturnAwaitRule;
+//# sourceMappingURL=no-return-await.rule.js.map

package/dist/linters/house/no-return-await.rule.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-return-await.rule.js","sourceRoot":"","sources":["../../../src/linters/house/no-return-await.rule.ts"],"names":[],"mappings":";;;AAEA,mDAA+C;AAC/C,qCAAqF;AAErF,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC;IAC7B,qBAAqB;IACrB,oBAAoB;IACpB,yBAAyB;CAC1B,CAAC,CAAC;AACH,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,gBAAgB,EAAE,SAAS,EAAE,aAAa,EAAE,YAAY,CAAC,CAAC,CAAC;AAE5F,4EAA4E;AAC5E,MAAM,OAAO,GAAG,CAAC,IAAa,EAAW,EAAE;IACzC,IAAI,OAAO,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;IAE9C,OAAO,OAAO,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC;QACzE,IAAI,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,KAAK,cAAc,EAAE,CAAC;YACnD,OAAO,IAAI,CAAC;QACd,CAAC;QACD,OAAO,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;IACrD,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC,CAAC;AAEF;;;;GAIG;AACH,MAAa,iBAAiB;aACZ,SAAI,GAAG,GAAG,+BAAsB,kBAAkB,CAAC;aAEnD,SAAI,GAAoB;QACtC,IAAI,EAAE;YACJ,IAAI,EAAE,YAAY;YAClB,OAAO,EAAE,MAAM;YACf,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE;gBACR,WAAW,EACT,qKAAqK;aACxK;SACF;QACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;YAClB,MAAM,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;YAC/B,MAAM,KAAK,GAAG,IAAI,GAAG,EAAwB,CAAC;YAE9C,MAAM,WAAW,GAAG,CAAC,IAIpB,EAAE,EAAE;gBACH,MAAM,QAAQ,GAAG,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,IAAI,CAAC,SAAS,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;gBACtE,MAAM,YAAY,GAChB,4BAAY,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,KAAK,oBAAoB;oBACpF,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC;oBAC9B,CAAC,CAAC,SAAS,CAAC;gBAEhB,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,IAAI,CAAC,QAAQ;oBACnB,SAAS,EAAE,aAAa;oBACxB,GAAG,EACD,YAAY,KAAK,SAAS;wBACxB,CAAC,CAAC,IAAI;wBACN,CAAC,CAAC,CAAC,KAAK,EAAE,EAAE;4BACR,IAAI,CAAC,IAAI,CAAC,SAAS,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,CAAC;gCAChD,OAAO,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;4BACzD,CAAC;4BAED,MAAM,KAAK,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,SAAS,EAAE,CAAC,CAAC;4BAC9D,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC;gCAC1D,OAAO,IAAI,CAAC;4BACd,CAAC;4BAED,MAAM,IAAI,GAAG,4BAAY,CAAC,SAAS,CAAC;gCAClC,IAAI,EAAE,IAAI,CAAC,SAAS;gCACpB,IAAI,EAAE,QAAQ;gCACd,UAAU;gCACV,KAAK;6BACN,CAAC,CAAC;4BACH,MAAM,MAAM,GAAG,4BAAY,CAAC,QAAQ,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,SAAS,EAAE,UAAU,EAAE,CAAC,CAAC;4BAE3E,OAAO,KAAK,CAAC,WAAW,CACtB,IAAI,CAAC,SAAS,EACd,SAAS,IAAI,YAAY,YAAY,MAAM,MAAM,UAAU,IAAI,GAAG,CACnE,CAAC;wBACJ,CAAC;iBACR,CAAC,CAAC;YACL,CAAC,CAAC;YAEF,OAAO;gBACL,CAAC,qBAAY,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBACnD,MAAM,QAAQ,GAAG,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,GAAG,EAAE,UAAU,EAAE,CAAC,CAAC;oBACtD,IAAI,4BAAY,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,KAAK,iBAAiB,EAAE,CAAC;wBACxF,WAAW,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;oBACxE,CAAC;gBACH,CAAC;gBACD,CAAC,qBAAY,CAAC,yBAAyB,CAAC,EAAE,CAAC,IAAe,EAAE,EAAE;oBAC5D,MAAM,IAAI,GAAG,IAAA,kBAAS,EAAC,EAAE,IAAI,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC;oBAC9C,IAAI,4BAAY,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,IAAA,iBAAQ,EAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,KAAK,iBAAiB,EAAE,CAAC;wBAChF,WAAW,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;oBACnD,CAAC;gBACH,CAAC;aACF,CAAC;QACJ,CAAC;KACF,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,OAAqC,EAAE;QAClD,OAAO,IAAI,CAAC,QAAQ,IAAI,OAAO,CAAC;IAClC,CAAC;;AA/EH,8CAgFC","sourcesContent":["import type { Rule } from 'eslint';\nimport type { TRuleSeverity } from '../rules/common';\nimport { AwaitSupport } from './await-support';\nimport { AstNodeTypes, HOUSE_PLUGIN_NAMESPACE, nodeType, readField } from './common';\n\nconst FUNCTION_TYPES = new Set([\n  'FunctionDeclaration',\n  'FunctionExpression',\n  'ArrowFunctionExpression',\n]);\nconst STATEMENT_LISTS = new Set(['BlockStatement', 'Program', 'StaticBlock', 'SwitchCase']);\n\n/** `node` sits inside a `try`, `catch` or `finally` of its own function. */\nconst isInTry = (node: unknown): boolean => {\n  let current = AwaitSupport.parentOf({ node });\n\n  while (current && !FUNCTION_TYPES.has(nodeType({ node: current }) ?? '')) {\n    if (nodeType({ node: current }) === 'TryStatement') {\n      return true;\n    }\n    current = AwaitSupport.parentOf({ node: current });\n  }\n\n  return false;\n};\n\n/**\n * `venizia/no-return-await`. A function returns the promise (`return f()`), never `return await f()`. Where the\n * `await` matters (inside `try`, `catch` or `finally`) it is written on its own line:\n * `const result = await f(); return result;`. An arrow whose body is an `await` is the same: `() => f()`.\n */\nexport class NoReturnAwaitRule {\n  static readonly NAME = `${HOUSE_PLUGIN_NAMESPACE}/no-return-await`;\n\n  static readonly RULE: Rule.RuleModule = {\n    meta: {\n      type: 'suggestion',\n      fixable: 'code',\n      schema: [],\n      messages: {\n        returnAwait:\n          'Return the promise (`return f()`), not `return await f()`; where the await matters (inside try, catch or finally) write `const result = await f(); return result;`.',\n      },\n    },\n    create: (context) => {\n      const { sourceCode } = context;\n      const taken = new Map<unknown, Set<string>>();\n\n      const reportAwait = (opts: {\n        reported: Rule.Node;\n        awaitNode: Rule.Node;\n        statement?: Rule.Node;\n      }) => {\n        const argument = readField({ node: opts.awaitNode, key: 'argument' });\n        const argumentText =\n          AwaitSupport.isNode(argument) && nodeType({ node: argument }) !== 'SequenceExpression'\n            ? sourceCode.getText(argument)\n            : undefined;\n\n        context.report({\n          node: opts.reported,\n          messageId: 'returnAwait',\n          fix:\n            argumentText === undefined\n              ? null\n              : (fixer) => {\n                  if (!opts.statement || !isInTry(opts.statement)) {\n                    return fixer.replaceText(opts.awaitNode, argumentText);\n                  }\n\n                  const outer = AwaitSupport.parentOf({ node: opts.statement });\n                  if (!STATEMENT_LISTS.has(nodeType({ node: outer }) ?? '')) {\n                    return null;\n                  }\n\n                  const name = AwaitSupport.freshName({\n                    node: opts.statement,\n                    base: 'result',\n                    sourceCode,\n                    taken,\n                  });\n                  const indent = AwaitSupport.indentOf({ node: opts.statement, sourceCode });\n\n                  return fixer.replaceText(\n                    opts.statement,\n                    `const ${name} = await ${argumentText};\\n${indent}return ${name};`,\n                  );\n                },\n        });\n      };\n\n      return {\n        [AstNodeTypes.RETURN_STATEMENT]: (node: Rule.Node) => {\n          const argument = readField({ node, key: 'argument' });\n          if (AwaitSupport.isNode(argument) && nodeType({ node: argument }) === 'AwaitExpression') {\n            reportAwait({ reported: node, awaitNode: argument, statement: node });\n          }\n        },\n        [AstNodeTypes.ARROW_FUNCTION_EXPRESSION]: (node: Rule.Node) => {\n          const body = readField({ node, key: 'body' });\n          if (AwaitSupport.isNode(body) && nodeType({ node: body }) === 'AwaitExpression') {\n            reportAwait({ reported: node, awaitNode: body });\n          }\n        },\n      };\n    },\n  };\n\n  static build(opts: { severity?: TRuleSeverity } = {}): TRuleSeverity {\n    return opts.severity ?? 'error';\n  }\n}\n"]}

package/dist/linters/house/plugin.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../src/linters/house/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAOrC,qGAAqG;AACrG,eAAO,MAAM,iBAAiB,EAAE,MAAM,CAAC,MAQtC,CAAC"}
+{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../../src/linters/house/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAWrC,qGAAqG;AACrG,eAAO,MAAM,iBAAiB,EAAE,MAAM,CAAC,MAYtC,CAAC"}

package/dist/linters/house/plugin.js

@@ -3,17 +3,25 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.houseEslintPlugin = void 0;
 const common_1 = require("./common");
 const const_class_values_rule_1 = require("./const-class-values.rule");
+const effect_cleanup_consistency_rule_1 = require("./effect-cleanup-consistency.rule");
 const max_params_own_rule_1 = require("./max-params-own.rule");
+const no_async_hook_callback_rule_1 = require("./no-async-hook-callback.rule");
+const no_inline_await_rule_1 = require("./no-inline-await.rule");
 const no_leaked_render_rule_1 = require("./no-leaked-render.rule");
 const no_new_error_rule_1 = require("./no-new-error.rule");
+const no_return_await_rule_1 = require("./no-return-await.rule");
 /** The ESLint plugin that carries the house rules oxlint cannot express, registered as `venizia`. */
 exports.houseEslintPlugin = {
     meta: { name: `eslint-plugin-${common_1.HOUSE_PLUGIN_NAMESPACE}` },
     rules: {
         'const-class-values': const_class_values_rule_1.ConstClassValuesRule.RULE,
+        'effect-cleanup-consistency': effect_cleanup_consistency_rule_1.EffectCleanupConsistencyRule.RULE,
         'max-params-own': max_params_own_rule_1.MaxParamsOwnRule.RULE,
+        'no-async-hook-callback': no_async_hook_callback_rule_1.NoAsyncHookCallbackRule.RULE,
+        'no-inline-await': no_inline_await_rule_1.NoInlineAwaitRule.RULE,
         'no-leaked-render': no_leaked_render_rule_1.NoLeakedRenderRule.RULE,
         'no-new-error': no_new_error_rule_1.NoNewErrorRule.RULE,
+        'no-return-await': no_return_await_rule_1.NoReturnAwaitRule.RULE,
     },
 };
 //# sourceMappingURL=plugin.js.map

package/dist/linters/house/plugin.js.map

@@ -1 +1 @@
-{"version":3,"file":"plugin.js","sourceRoot":"","sources":["../../../src/linters/house/plugin.ts"],"names":[],"mappings":";;;AACA,qCAAkD;AAClD,uEAAiE;AACjE,+DAAyD;AACzD,mEAA6D;AAC7D,2DAAqD;AAErD,qGAAqG;AACxF,QAAA,iBAAiB,GAAkB;IAC9C,IAAI,EAAE,EAAE,IAAI,EAAE,iBAAiB,+BAAsB,EAAE,EAAE;IACzD,KAAK,EAAE;QACL,oBAAoB,EAAE,8CAAoB,CAAC,IAAI;QAC/C,gBAAgB,EAAE,sCAAgB,CAAC,IAAI;QACvC,kBAAkB,EAAE,0CAAkB,CAAC,IAAI;QAC3C,cAAc,EAAE,kCAAc,CAAC,IAAI;KACpC;CACF,CAAC","sourcesContent":["import type { ESLint } from 'eslint';\nimport { HOUSE_PLUGIN_NAMESPACE } from './common';\nimport { ConstClassValuesRule } from './const-class-values.rule';\nimport { MaxParamsOwnRule } from './max-params-own.rule';\nimport { NoLeakedRenderRule } from './no-leaked-render.rule';\nimport { NoNewErrorRule } from './no-new-error.rule';\n\n/** The ESLint plugin that carries the house rules oxlint cannot express, registered as `venizia`. */\nexport const houseEslintPlugin: ESLint.Plugin = {\n  meta: { name: `eslint-plugin-${HOUSE_PLUGIN_NAMESPACE}` },\n  rules: {\n    'const-class-values': ConstClassValuesRule.RULE,\n    'max-params-own': MaxParamsOwnRule.RULE,\n    'no-leaked-render': NoLeakedRenderRule.RULE,\n    'no-new-error': NoNewErrorRule.RULE,\n  },\n};\n"]}
+{"version":3,"file":"plugin.js","sourceRoot":"","sources":["../../../src/linters/house/plugin.ts"],"names":[],"mappings":";;;AACA,qCAAkD;AAClD,uEAAiE;AACjE,uFAAiF;AACjF,+DAAyD;AACzD,+EAAwE;AACxE,iEAA2D;AAC3D,mEAA6D;AAC7D,2DAAqD;AACrD,iEAA2D;AAE3D,qGAAqG;AACxF,QAAA,iBAAiB,GAAkB;IAC9C,IAAI,EAAE,EAAE,IAAI,EAAE,iBAAiB,+BAAsB,EAAE,EAAE;IACzD,KAAK,EAAE;QACL,oBAAoB,EAAE,8CAAoB,CAAC,IAAI;QAC/C,4BAA4B,EAAE,8DAA4B,CAAC,IAAI;QAC/D,gBAAgB,EAAE,sCAAgB,CAAC,IAAI;QACvC,wBAAwB,EAAE,qDAAuB,CAAC,IAAI;QACtD,iBAAiB,EAAE,wCAAiB,CAAC,IAAI;QACzC,kBAAkB,EAAE,0CAAkB,CAAC,IAAI;QAC3C,cAAc,EAAE,kCAAc,CAAC,IAAI;QACnC,iBAAiB,EAAE,wCAAiB,CAAC,IAAI;KAC1C;CACF,CAAC","sourcesContent":["import type { ESLint } from 'eslint';\nimport { HOUSE_PLUGIN_NAMESPACE } from './common';\nimport { ConstClassValuesRule } from './const-class-values.rule';\nimport { EffectCleanupConsistencyRule } from './effect-cleanup-consistency.rule';\nimport { MaxParamsOwnRule } from './max-params-own.rule';\nimport { NoAsyncHookCallbackRule } from './no-async-hook-callback.rule';\nimport { NoInlineAwaitRule } from './no-inline-await.rule';\nimport { NoLeakedRenderRule } from './no-leaked-render.rule';\nimport { NoNewErrorRule } from './no-new-error.rule';\nimport { NoReturnAwaitRule } from './no-return-await.rule';\n\n/** The ESLint plugin that carries the house rules oxlint cannot express, registered as `venizia`. */\nexport const houseEslintPlugin: ESLint.Plugin = {\n  meta: { name: `eslint-plugin-${HOUSE_PLUGIN_NAMESPACE}` },\n  rules: {\n    'const-class-values': ConstClassValuesRule.RULE,\n    'effect-cleanup-consistency': EffectCleanupConsistencyRule.RULE,\n    'max-params-own': MaxParamsOwnRule.RULE,\n    'no-async-hook-callback': NoAsyncHookCallbackRule.RULE,\n    'no-inline-await': NoInlineAwaitRule.RULE,\n    'no-leaked-render': NoLeakedRenderRule.RULE,\n    'no-new-error': NoNewErrorRule.RULE,\n    'no-return-await': NoReturnAwaitRule.RULE,\n  },\n};\n"]}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@venizia/dev-configs",
-  "version": "0.4.6",
+  "version": "0.4.7-0",
   "description": "Shareable development configurations for TypeScript projects: oxlint presets with per-rule builders, the ESLint naming-convention rule, the legacy ESLint flat config, and TypeScript compiler options with critical decorator support (experimentalDecorators, emitDecoratorMetadata, useDefineForClassFields). Single source of truth for consistent code style, type checking, and build settings across monorepo packages.",
   "keywords": [
     "build-tools",