@velocitycareerlabs/data-loader 1.21.0-dev-build.116437e4c → 1.21.0-dev-build.1a4a52f69

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@velocitycareerlabs/data-loader",
-  "version": "1.21.0-dev-build.116437e4c",
+  "version": "1.21.0-dev-build.1a4a52f69",
   "description": "A tool for uploading data to the different target systems.",
   "repository": "https://github.com/velocitycareerlabs/packages",
   "main": "src/index.js",
@@ -38,7 +38,8 @@
     "handlebars": "~4.7.7",
     "inquirer": "^8.0.0",
     "lodash": "~4.17.20",
-    "nanoid": "3.3.1"
+    "nanoid": "3.3.1",
+    "strip-bom-stream": "^4.0.0"
   },
-  "gitHead": "9c38fa005315bd7ed59a9826dcc4cd3ac551f1c6"
+  "gitHead": "a3ee6110e07a97077a2b8060a41b67f730d2a664"
 }

package/src/helpers/load-csv.js

@@ -1,5 +1,6 @@
 const fs = require('fs');
 const csv = require('csv-parser');
+const stripBom = require('strip-bom-stream');
 const { isString, indexOf } = require('lodash/fp');
 
 const loadCsv = (fileName) => {
@@ -7,6 +8,7 @@ const loadCsv = (fileName) => {
     const csvRows = [];
     let csvHeaders;
     fs.createReadStream(fileName)
+      .pipe(stripBom())
       .pipe(csv())
       .on('headers', (headers) => {
         // eslint-disable-next-line better-mutation/no-mutation

package/test/batch-issuing.test.js

@@ -1095,6 +1095,95 @@ describe('batch issuing test', () => {
     });
   });
 
+  it('should handle csv with BOM characters', async () => {
+    const options = {
+      csvFilename: path.join(__dirname, 'data/with-bom.csv'),
+      offerTemplateFilename: path.join(
+        __dirname,
+        'data/email-offer.template.json'
+      ),
+      termsUrl: 'http://example.com/terms.html',
+      did: 'did:ion:sap123',
+      idCredentialType: 'EmailV1.0',
+      vendorUseridColumn: 'email',
+      new: true,
+      dryrun: true,
+    };
+
+    const updates = await runBatchIssuing(options);
+    expect(
+      new Date(updates.disclosureRequest.activationDate).getTime()
+    ).toBeLessThan(Date.now());
+
+    expect(updates).toEqual({
+      disclosureRequest: {
+        configurationType: 'issuing',
+        vendorEndpoint: 'integrated-issuing-identification',
+        types: [
+          {
+            type: 'EmailV1.0',
+          },
+        ],
+        identityMatchers: {
+          rules: [
+            {
+              valueIndex: 0,
+              path: ['$.emails'],
+              rule: 'pick',
+            },
+          ],
+          vendorUserIdIndex: 2,
+        },
+        vendorDisclosureId: expect.any(Number),
+        setIssuingDefault: true,
+        duration: '1h', // 1 hour by default
+        offerMode: 'preloaded',
+        purpose: 'Issuing Career Credential', // by default have a generic message
+        activationDate: expect.stringMatching(ISO_DATETIME_TZ_FORMAT),
+        termsUrl: 'http://example.com/terms.html',
+        authTokenExpiresIn: 525600,
+      },
+      newExchangeOffers: [
+        {
+          newOffer: {
+            type: ['EmailV1.0'],
+            issuer: {
+              id: 'did:ion:sap123',
+            },
+            credentialSubject: {
+              vendorUserId: 'joan.lee@sap.com',
+              email: 'joan.lee@sap.com',
+            },
+
+            offerId: expect.any(String),
+          },
+          newExchange: {
+            type: 'ISSUING',
+            identityMatcherValues: ['joan.lee@sap.com'],
+          },
+        },
+        {
+          newOffer: {
+            type: ['EmailV1.0'],
+            issuer: {
+              id: 'did:ion:sap123',
+            },
+            credentialSubject: {
+              vendorUserId: 'john.smith@sap.com',
+              email: 'john.smith@sap.com',
+            },
+
+            offerId: expect.any(String),
+          },
+          newExchange: {
+            type: 'ISSUING',
+            identityMatcherValues: ['john.smith@sap.com'],
+          },
+        },
+      ],
+    });
+  });
+
   it('should load the templates and csv with vars', async () => {
     const options = {
       csvFilename: path.join(__dirname, 'data/variables.csv'),

package/test/data/with-bom.csv

@@ -0,0 +1,3 @@
+givenName,familyName,email,did
+Joan,Lee,joan.lee@sap.com,did:ion:sap123
+John,Smith,john.smith@sap.com,did:ion:sap123