@vellumai/credential-executor 0.10.3-dev.202606291709.2b4d83d → 0.10.3-dev.202606291850.7e0a3f7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vellumai/credential-executor",
-  "version": "0.10.3-dev.202606291709.2b4d83d",
+  "version": "0.10.3-dev.202606291850.7e0a3f7",
   "license": "MIT",
   "type": "module",
   "exports": {

package/src/__tests__/command-executor.test.ts

@@ -1345,11 +1345,14 @@ describe("server — run_authenticated_command handler", () => {
       defaultWorkspaceDir: testWorkspaceDir,
     });
 
-    const response = await handler({
-      credentialHandle: "local_static:test/api_key",
-      command: "",
-      purpose: "Test empty command",
-    });
+    const response = await handler(
+      {
+        credentialHandle: "local_static:test/api_key",
+        command: "",
+        purpose: "Test empty command",
+      },
+      { sessionId: "test-session" },
+    );
 
     expect(response.success).toBe(false);
     expect(response.error?.code).toBe("INVALID_COMMAND");
@@ -1366,11 +1369,14 @@ describe("server — run_authenticated_command handler", () => {
       defaultWorkspaceDir: testWorkspaceDir,
     });
 
-    const response = await handler({
-      credentialHandle: "local_static:test/api_key",
-      command: "just-a-plain-command --with-args",
-      purpose: "Test plain command",
-    });
+    const response = await handler(
+      {
+        credentialHandle: "local_static:test/api_key",
+        command: "just-a-plain-command --with-args",
+        purpose: "Test plain command",
+      },
+      { sessionId: "test-session" },
+    );
 
     expect(response.success).toBe(false);
     expect(response.error?.code).toBe("INVALID_COMMAND");
@@ -1388,11 +1394,14 @@ describe("server — run_authenticated_command handler", () => {
     });
 
     // This will fail at bundle resolution (fake digest), but the parse succeeds
-    const response = await handler({
-      credentialHandle: "local_static:test/api_key",
-      command: `${"a".repeat(64)}/list api /repos --method GET`,
-      purpose: "Test command parsing",
-    });
+    const response = await handler(
+      {
+        credentialHandle: "local_static:test/api_key",
+        command: `${"a".repeat(64)}/list api /repos --method GET`,
+        purpose: "Test command parsing",
+      },
+      { sessionId: "test-session" },
+    );
 
     // Should fail at bundle resolution, not at command parsing
     expect(response.error?.code).not.toBe("INVALID_COMMAND");

package/src/__tests__/http-executor.test.ts

@@ -280,7 +280,7 @@ function buildDeps(
       metadataStore: fixture.metadataStore,
       oauthConnections: createOAuthLookup(oauthConnections),
     },
-    sessionId: { current: "test-session" },
+    sessionId: "test-session",
     logger: silentLogger,
     ...overrides,
     auditStore: overrides.auditStore ?? new AuditStore(fixture.tmpDir),

package/src/__tests__/managed-integration.test.ts

@@ -42,7 +42,7 @@ import {
   createListGrantsHandler,
   createListAuditRecordsHandler,
 } from "../grants/rpc-handlers.js";
-import { CesRpcServer, type RpcHandlerRegistry, type ServeEndReason, type SessionIdRef } from "../server.js";
+import { CesRpcServer, type RpcHandlerRegistry, type ServeEndReason } from "../server.js";
 import { createLocalSecureKeyBackend } from "../materializers/local-secure-key-backend.js";
 
 // ---------------------------------------------------------------------------
@@ -412,7 +412,7 @@ describe("managed CES integration (real Unix socket)", () => {
     // -- Server gets the connection and wires up RPC ---------------------------
     const conn = await connectionPromise;
 
-    const sessionIdRef: SessionIdRef = { current: `integ-${Date.now()}` };
+    let observedSessionId = "";
     const handlers = buildMinimalHandlers(dataDir);
 
     serverRpcServer = new CesRpcServer({
@@ -426,7 +426,7 @@ describe("managed CES integration (real Unix socket)", () => {
       },
       signal: controller.signal,
       onHandshakeComplete: (hsSessionId) => {
-        sessionIdRef.current = hsSessionId;
+        observedSessionId = hsSessionId;
       },
     });
 
@@ -449,8 +449,10 @@ describe("managed CES integration (real Unix socket)", () => {
     expect(ack.protocolVersion).toBe(CES_PROTOCOL_VERSION);
     expect(ack.sessionId).toBe(handshakeSessionId);
 
-    // Verify onHandshakeComplete callback fired
-    expect(sessionIdRef.current).toBe(handshakeSessionId);
+    // Verify onHandshakeComplete callback fired and the server populated its
+    // per-connection SessionContext.
+    expect(observedSessionId).toBe(handshakeSessionId);
+    expect(serverRpcServer.currentSessionId).toBe(handshakeSessionId);
 
     // -- Step 2: RPC dispatch (list_grants) ------------------------------------
     const rpcId = "rpc-1";

package/src/commands/executor.ts

@@ -79,7 +79,6 @@ import { hashProposal, type AuditRecordSummary, type CommandGrantProposal } from
 import type { AuditStore } from "../audit/store.js";
 import type { PersistentGrantStore } from "../grants/persistent-store.js";
 import type { TemporaryGrantStore } from "../grants/temporary-store.js";
-import type { SessionIdRef } from "../server.js";
 
 // ---------------------------------------------------------------------------
 // Types
@@ -171,8 +170,8 @@ export interface CommandExecutorDeps {
   materializeCredential: MaterializeCredentialFn;
   /** Audit store for persisting token-free audit records. */
   auditStore?: AuditStore;
-  /** Mutable reference to the session ID for audit records. Updated to the handshake session ID once the RPC handshake completes. */
-  sessionId?: SessionIdRef;
+  /** Session ID for audit records, taken from the calling connection's SessionContext at dispatch time. */
+  sessionId?: string;
   /** CES operating mode (for toolstore path resolution). */
   cesMode?: CesMode;
   /** Egress proxy session start hooks (for creating the proxy server). */
@@ -567,7 +566,7 @@ export async function executeAuthenticatedCommand(
       credentialHandle: request.credentialHandle,
       toolName: "command",
       target: `${request.bundleDigest}/${request.profileName}`,
-      sessionId: deps.sessionId?.current ?? "unknown",
+      sessionId: deps.sessionId ?? "unknown",
       success: execResult.success,
       ...(execResult.error ? { errorMessage: execResult.error } : {}),
       timestamp: new Date().toISOString(),

package/src/http/executor.ts

@@ -43,7 +43,6 @@ import { materializeManagedToken, type ManagedMaterializerOptions } from "../mat
 import { resolveLocalSubject, type LocalSubjectResolverDeps } from "../subjects/local.js";
 import { checkCredentialPolicy } from "../subjects/policy.js";
 import { resolveManagedSubject, type ManagedSubjectResolverOptions } from "../subjects/managed.js";
-import type { SessionIdRef } from "../server.js";
 
 // ---------------------------------------------------------------------------
 // Auth injection constants
@@ -81,8 +80,8 @@ export interface HttpExecutorDeps {
   managedMaterializerOptions?: ManagedMaterializerOptions;
   /** Audit store for persisting token-free audit records. */
   auditStore: AuditStore;
-  /** Mutable reference to the session ID for audit records. Updated to the handshake session ID once the RPC handshake completes. */
-  sessionId: SessionIdRef;
+  /** Session ID for audit records, injected per call from the calling connection's SessionContext. */
+  sessionId?: string;
   /** Optional custom fetch implementation (for testing). */
   fetch?: typeof globalThis.fetch;
   /** Optional logger. */
@@ -185,7 +184,7 @@ export async function executeAuthenticatedHttpRequest(
     const audit = generateHttpAuditSummary({
       credentialHandle: request.credentialHandle,
       grantId,
-      sessionId: deps.sessionId.current,
+      sessionId: deps.sessionId ?? "unknown",
       method: request.method,
       url: request.url,
       success: false,
@@ -235,7 +234,7 @@ export async function executeAuthenticatedHttpRequest(
     const audit = generateHttpAuditSummary({
       credentialHandle: request.credentialHandle,
       grantId,
-      sessionId: deps.sessionId.current,
+      sessionId: deps.sessionId ?? "unknown",
       method: request.method,
       url: request.url,
       success: false,
@@ -261,7 +260,7 @@ export async function executeAuthenticatedHttpRequest(
   const audit = generateHttpAuditSummary({
     credentialHandle: request.credentialHandle,
     grantId,
-    sessionId: deps.sessionId.current,
+    sessionId: deps.sessionId ?? "unknown",
     method: request.method,
     url: request.url,
     success: true,

package/src/index.ts

@@ -29,7 +29,7 @@ export type {
   RpcHandlerRegistry,
   RpcMethodHandler,
   RunAuthenticatedCommandHandlerOptions,
-  SessionIdRef,
+  SessionContext,
 } from "./server.js";
 
 export {

package/src/main.ts

@@ -59,7 +59,6 @@ import {
   registerCommandExecutionHandler,
   registerManageSecureCommandToolHandler,
   type RpcHandlerRegistry,
-  type SessionIdRef,
 } from "./server.js";
 import {
   deleteBundleFromToolstore,
@@ -124,7 +123,6 @@ function getSecurityDir(): string {
 // ---------------------------------------------------------------------------
 
 function buildHandlers(
-  sessionIdRef: SessionIdRef,
   secureKeyBackend: SecureKeyBackend,
 ): RpcHandlerRegistry {
   // -- Grant stores ----------------------------------------------------------
@@ -174,7 +172,6 @@ function buildHandlers(
       oauthConnections,
     },
     auditStore,
-    sessionId: sessionIdRef,
   });
 
   // Register run_authenticated_command handler
@@ -216,7 +213,6 @@ function buildHandlers(
         };
       },
       auditStore,
-      sessionId: sessionIdRef,
       cesMode: "local",
       egressHooks: buildCesEgressHooks(),
     },
@@ -389,10 +385,9 @@ async function main(): Promise<void> {
   log.info("CES local startup: migrations complete");
 
   // Build the handler registry with all available RPC implementations.
-  // Use a mutable ref so audit records capture the handshake session ID
-  // once it's negotiated (the handshake completes before any RPC call).
-  const sessionIdRef: SessionIdRef = { current: `ces-local-${Date.now()}` };
-  const handlers = buildHandlers(sessionIdRef, secureKeyBackend);
+  // The handshake session ID is captured per connection in the server's
+  // SessionContext; handlers read it at call time for audit records.
+  const handlers = buildHandlers(secureKeyBackend);
 
   const rpcLog = getLogger("rpc");
   const server = new CesRpcServer({
@@ -405,10 +400,8 @@ async function main(): Promise<void> {
       error: (msg: string, ...args: unknown[]) => rpcLog.error({ args }, msg),
     },
     signal: controller.signal,
-    onHandshakeComplete: (hsSessionId) => {
-      sessionIdRef.current = hsSessionId;
-    },
-    // Local mode reads API keys from env/store directly — no-op handler.
+    // Local mode reads API keys from env/store directly — no-op handler so
+    // update_managed_credential is still registered and returns success.
     onApiKeyUpdate: () => {},
   });
 

package/src/managed-main.ts

@@ -57,7 +57,6 @@ import {
   registerManageSecureCommandToolHandler,
   type RpcHandlerRegistry,
   type ServeEndReason,
-  type SessionIdRef,
 } from "./server.js";
 import {
   deleteBundleFromToolstore,
@@ -120,7 +119,6 @@ function ensureDataDirs(): void {
 // ---------------------------------------------------------------------------
 
 function buildHandlers(
-  sessionIdRef: SessionIdRef,
   apiKeyRef: ApiKeyRef,
   assistantIdRef: AssistantIdRef,
   secureKeyBackend: SecureKeyBackend,
@@ -214,7 +212,6 @@ function buildHandlers(
       return getManagedMaterializerOptions();
     },
     auditStore,
-    sessionId: sessionIdRef,
   };
 
   const handlers = buildHandlersWithHttp(httpDeps);
@@ -283,7 +280,6 @@ function buildHandlers(
         }
       },
       auditStore,
-      sessionId: sessionIdRef,
       cesMode: "managed",
       egressHooks: buildCesEgressHooks(),
     },
@@ -677,14 +673,14 @@ async function main(): Promise<void> {
   // would otherwise leak ephemeral approvals across sessions. It is cleared at
   // the end of every session below so a reconnecting assistant must re-prompt.
   //
-  // The mutable refs carry the handshake-provided session ID, API key, and
-  // assistant ID; handlers read them at call time, so updating the refs when
-  // each session's handshake completes is all that's needed per connection.
-  const sessionIdRef: SessionIdRef = { current: `ces-managed-${Date.now()}` };
+  // The mutable refs carry the handshake-provided API key and assistant ID;
+  // handlers read them at call time. These don't vary across a daemon's
+  // connections, so they stay process-global. The per-connection session ID,
+  // by contrast, lives in each CesRpcServer's SessionContext (handlers read it
+  // at call time for audit attribution).
   const apiKeyRef: ApiKeyRef = { current: "" };
   const assistantIdRef: AssistantIdRef = { current: "" };
   const { handlers, temporaryGrantStore } = buildHandlers(
-    sessionIdRef,
     apiKeyRef,
     assistantIdRef,
     secureKeyBackend,
@@ -726,8 +722,7 @@ async function main(): Promise<void> {
         error: (msg: string, ...args: unknown[]) => rpcLog.error({ args }, msg),
       },
       signal: controller.signal,
-      onHandshakeComplete: (hsSessionId, hsApiKey, hsAssistantId) => {
-        sessionIdRef.current = hsSessionId;
+      onHandshakeComplete: (_hsSessionId, hsApiKey, hsAssistantId) => {
         // Overwrite the credential refs on every handshake. The handler
         // registry persists across reconnects, so a new session that omits
         // the API key / assistant ID must fail closed (falling back to the

package/src/server.ts

@@ -54,20 +54,33 @@ import {
 // ---------------------------------------------------------------------------
 
 /**
- * Mutable reference to the current session ID. Allows handlers that are
- * registered before the RPC handshake to read the actual handshake session
- * ID at call time (after the handshake completes and sets `.current`).
+ * Per-connection session context.
+ *
+ * Each accepted connection owns one `SessionContext`, created when the server
+ * is constructed and populated with the negotiated session ID at handshake.
+ * Handlers receive it as their second argument and read the session ID at call
+ * time — so a handler registry shared across connections attributes each call
+ * (e.g. audit records) to the originating connection.
+ *
+ * Identity that does not vary across a daemon's connections — the assistant
+ * API key and assistant ID — deliberately lives outside this context
+ * (process-global, see `managed-lazy-getters.ts`); only the per-connection
+ * session ID belongs here.
  */
-export interface SessionIdRef {
-  current: string;
+export interface SessionContext {
+  /** The RPC session ID negotiated at handshake. */
+  sessionId: string;
 }
 
 /**
- * Handler function for a single RPC method. Receives the validated
- * request payload and returns the response payload (or throws).
+ * Handler function for a single RPC method. Receives the validated request
+ * payload and the originating connection's `SessionContext`, and returns the
+ * response payload (or throws). Handlers that don't need the context may omit
+ * the second parameter.
  */
 export type RpcMethodHandler<TReq = unknown, TRes = unknown> = (
   request: TReq,
+  ctx: SessionContext,
 ) => Promise<TRes> | TRes;
 
 /**
@@ -112,7 +125,12 @@ export class CesRpcServer {
   private readonly onHandshakeComplete?: (sessionId: string, assistantApiKey?: string, assistantId?: string) => void;
 
   private handshakeComplete = false;
-  private sessionId: string | null = null;
+  /**
+   * This connection's session context. The object identity is stable for the
+   * life of the server and passed by reference to every handler; `sessionId` is
+   * populated when the handshake completes.
+   */
+  private readonly sessionContext: SessionContext = { sessionId: "" };
   private buffer = "";
   private closed = false;
 
@@ -187,7 +205,7 @@ export class CesRpcServer {
 
   /** The session ID established during handshake (null before handshake). */
   get currentSessionId(): string | null {
-    return this.sessionId;
+    return this.sessionContext.sessionId || null;
   }
 
   /** Shut down the server gracefully, destroying transport streams. */
@@ -270,7 +288,7 @@ export class CesRpcServer {
 
     if (accepted) {
       this.handshakeComplete = true;
-      this.sessionId = req.sessionId;
+      this.sessionContext.sessionId = req.sessionId;
       this.logger.log(`[ces-server] Handshake accepted for session ${req.sessionId}`);
       this.onHandshakeComplete?.(req.sessionId, req.assistantApiKey, req.assistantId);
     } else {
@@ -320,7 +338,7 @@ export class CesRpcServer {
     }
 
     try {
-      const result = await handler(validatedPayload);
+      const result = await handler(validatedPayload, this.sessionContext);
       this.sendRpcResponse(envelope, result);
     } catch (err) {
       const message = err instanceof Error ? err.message : String(err);
@@ -373,17 +391,19 @@ export class CesRpcServer {
 /**
  * Create a handler function for the `make_authenticated_request` RPC method.
  *
- * Binds the executor to the provided dependencies so it can be registered
- * in the RPC handler registry.
+ * Binds the executor to the provided dependencies so it can be registered in
+ * the RPC handler registry. The per-connection session ID is merged in from
+ * the SessionContext at call time (for audit attribution); all other deps —
+ * including the managed subject/materializer options — are taken as supplied.
  */
 export function createMakeAuthenticatedRequestHandler(
   deps: HttpExecutorDeps,
 ): RpcMethodHandler {
-  return async (request: unknown) => {
-    return executeAuthenticatedHttpRequest(
-      request as MakeAuthenticatedRequest,
-      deps,
-    );
+  return async (request: unknown, ctx: SessionContext) => {
+    return executeAuthenticatedHttpRequest(request as MakeAuthenticatedRequest, {
+      ...deps,
+      sessionId: ctx.sessionId,
+    });
   };
 }
 
@@ -452,7 +472,7 @@ export interface RunAuthenticatedCommandHandlerOptions {
 export function createRunAuthenticatedCommandHandler(
   options: RunAuthenticatedCommandHandlerOptions,
 ): RpcMethodHandler<RunAuthenticatedCommand, RunAuthenticatedCommandResponse> {
-  return async (request) => {
+  return async (request, ctx) => {
     // Parse the command string into bundle-digest/profile and argv
     const parseResult = parseCommandString(request.command);
     if (!parseResult.ok) {
@@ -504,10 +524,12 @@ export function createRunAuthenticatedCommandHandler(
       conversationId: request.conversationId,
     };
 
-    const result = await executeAuthenticatedCommand(
-      execRequest,
-      options.executorDeps,
-    );
+    // Bind the per-connection session ID (for audit attribution) into the
+    // executor deps for this call.
+    const result = await executeAuthenticatedCommand(execRequest, {
+      ...options.executorDeps,
+      sessionId: ctx.sessionId,
+    });
 
     // If the failure was due to a missing grant, return a structured
     // APPROVAL_REQUIRED response with the proposal so the approval