@vellumai/cli 0.6.6 → 0.7.1

package/src/__tests__/config-utils.test.ts

@@ -0,0 +1,146 @@
+import { readFileSync, rmSync } from "fs";
+import { describe, expect, test } from "bun:test";
+
+import { buildNestedConfig, writeInitialConfig } from "../lib/config-utils.js";
+
+function readInitialConfig(
+  configValues: Record<string, string>,
+): Record<string, unknown> {
+  const path = writeInitialConfig(configValues);
+  expect(path).toBeDefined();
+  try {
+    return JSON.parse(readFileSync(path!, "utf-8")) as Record<string, unknown>;
+  } finally {
+    if (path !== undefined) rmSync(path, { force: true });
+  }
+}
+
+describe("config-utils", () => {
+  test("buildNestedConfig only converts dot-notation values", () => {
+    expect(
+      buildNestedConfig({
+        "llm.default.provider": "anthropic",
+        "llm.default.model": "claude-sonnet-4-6",
+      }),
+    ).toEqual({
+      llm: {
+        default: {
+          provider: "anthropic",
+          model: "claude-sonnet-4-6",
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig does not add a mainAgent callSite for Anthropic defaults", () => {
+    expect(
+      readInitialConfig({
+        "llm.default.provider": "anthropic",
+        "llm.default.model": "claude-opus-4-7",
+      }),
+    ).toEqual({
+      llm: {
+        default: {
+          provider: "anthropic",
+          model: "claude-opus-4-7",
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig preserves profile-based Anthropic model selection", () => {
+    expect(
+      readInitialConfig({
+        "llm.activeProfile": "quality-optimized",
+        "llm.profiles.quality-optimized.provider": "anthropic",
+        "llm.profiles.quality-optimized.model": "claude-opus-4-7",
+        "llm.profiles.quality-optimized.maxTokens": "32000",
+      }),
+    ).toEqual({
+      llm: {
+        activeProfile: "quality-optimized",
+        profiles: {
+          "quality-optimized": {
+            provider: "anthropic",
+            model: "claude-opus-4-7",
+            maxTokens: "32000",
+          },
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig preserves explicit mainAgent overrides without rewriting them", () => {
+    expect(
+      readInitialConfig({
+        "llm.default.provider": "anthropic",
+        "llm.default.model": "claude-opus-4-7",
+        "llm.callSites.mainAgent.model": "claude-haiku-4-5-20251001",
+      }),
+    ).toEqual({
+      llm: {
+        default: {
+          provider: "anthropic",
+          model: "claude-opus-4-7",
+        },
+        callSites: {
+          mainAgent: {
+            model: "claude-haiku-4-5-20251001",
+          },
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig respects explicit non-default Anthropic models", () => {
+    expect(
+      readInitialConfig({
+        "llm.default.provider": "anthropic",
+        "llm.default.model": "claude-haiku-4-5-20251001",
+      }),
+    ).toEqual({
+      llm: {
+        default: {
+          provider: "anthropic",
+          model: "claude-haiku-4-5-20251001",
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig leaves active OpenAI profile config unchanged", () => {
+    expect(
+      readInitialConfig({
+        "llm.activeProfile": "fast",
+        "llm.profiles.fast.provider": "openai",
+        "llm.profiles.fast.model": "gpt-5.5",
+      }),
+    ).toEqual({
+      llm: {
+        activeProfile: "fast",
+        profiles: {
+          fast: {
+            provider: "openai",
+            model: "gpt-5.5",
+          },
+        },
+      },
+    });
+  });
+
+  test("writeInitialConfig does not add Opus for non-Anthropic providers", () => {
+    expect(
+      readInitialConfig({
+        "llm.default.provider": "openai",
+        "llm.default.model": "gpt-5.5",
+      }),
+    ).toEqual({
+      llm: {
+        default: {
+          provider: "openai",
+          model: "gpt-5.5",
+        },
+      },
+    });
+  });
+});

package/src/__tests__/env-drift.test.ts

@@ -4,25 +4,21 @@ import { join } from "node:path";
 
 import { SEEDS } from "../lib/environments/seeds.js";
 
-// Drift guard for the three TypeScript sites that each hardcode the set of
-// known environment names:
+// Drift guard for the TypeScript sites that hardcode the set of known
+// environment names:
 //
-//   1. cli/src/lib/environments/seeds.ts          — SEEDS record (source of truth)
-//   2. assistant/src/util/platform.ts             — KNOWN_ENVIRONMENTS set
-//   3. clients/chrome-extension/native-host/
-//         src/lockfile.ts                         — NON_PRODUCTION_ENVIRONMENTS set
+//   1. cli/src/lib/environments/seeds.ts  — SEEDS record (source of truth)
+//   2. assistant/src/util/platform.ts     — KNOWN_ENVIRONMENTS set
 //
 // Cross-package relative imports don't work here: assistant's tsconfig
-// restricts `include` to its own src tree, and the native host is a
-// standalone TS project with `rootDir: ./src`. So this test parses the
-// literal sets out of the two external files and asserts they agree with
-// CLI's SEEDS.
+// restricts `include` to its own src tree. So this test parses the literal
+// set out of the external file and asserts it agrees with CLI's SEEDS.
 //
 // FOLLOW-UP: split the env name list into a shared `packages/environments`
-// package (mirroring `packages/ces-contracts`, `credential-storage`) so
-// all three sites can `import { KNOWN_ENVIRONMENTS }` from one place and
-// this drift guard becomes a compile-time check. Planned alongside CLI-
-// driven context support — see the "Environments" design doc.
+// package (mirroring `packages/service-contracts`, `credential-storage`) so
+// both sites can `import { KNOWN_ENVIRONMENTS }` from one place and this
+// drift guard becomes a compile-time check. Planned alongside CLI-driven
+// context support — see the "Environments" design doc.
 
 const REPO_ROOT = join(import.meta.dir, "..", "..", "..");
 const ASSISTANT_PLATFORM = join(
@@ -32,14 +28,6 @@ const ASSISTANT_PLATFORM = join(
   "util",
   "platform.ts",
 );
-const NATIVE_HOST_LOCKFILE = join(
-  REPO_ROOT,
-  "clients",
-  "chrome-extension",
-  "native-host",
-  "src",
-  "lockfile.ts",
-);
 
 /**
  * Extract the string literals from a Set constructor body in a TS source
@@ -74,14 +62,4 @@ describe("KNOWN_ENVIRONMENTS drift guard (TS-side)", () => {
     );
     expect([...assistantNames].sort()).toEqual([...seedNames].sort());
   });
-
-  test("native-host/src/lockfile.ts NON_PRODUCTION_ENVIRONMENTS matches CLI SEEDS minus production", () => {
-    const source = readFileSync(NATIVE_HOST_LOCKFILE, "utf8");
-    const nativeNames = new Set(
-      extractSetLiterals(source, "NON_PRODUCTION_ENVIRONMENTS"),
-    );
-    const expected = new Set(seedNames);
-    expected.delete("production");
-    expect([...nativeNames].sort()).toEqual([...expected].sort());
-  });
 });

package/src/__tests__/llm-provider-env-var-parity.test.ts

@@ -2,10 +2,7 @@ import { readFileSync } from "node:fs";
 import { join } from "node:path";
 import { describe, expect, test } from "bun:test";
 
-import {
-  LLM_PROVIDER_ENV_VAR_NAMES,
-  SEARCH_PROVIDER_ENV_VAR_NAMES,
-} from "../shared/provider-env-vars.js";
+import { LLM_PROVIDER_ENV_VAR_NAMES } from "../shared/provider-env-vars.js";
 
 /**
  * Drift guard for the CLI-side LLM provider env-var mirror.
@@ -16,8 +13,6 @@ import {
  * `meta/llm-provider-catalog.json` — which is kept in sync with
  * `PROVIDER_CATALOG` by `assistant/src/__tests__/llm-catalog-parity.test.ts` —
  * and asserts the CLI's mirror matches the catalog's `envVar` entries.
- *
- * It also asserts the search-provider mirror matches `meta/provider-env-vars.json`.
  */
 
 const REPO_ROOT = join(import.meta.dir, "..", "..", "..");
@@ -32,21 +27,11 @@ interface LlmCatalog {
   providers: LlmCatalogEntry[];
 }
 
-interface SearchProviderRegistry {
-  version: number;
-  providers: Record<string, string>;
-}
-
 function loadLlmCatalog(): LlmCatalog {
   const path = join(REPO_ROOT, "meta", "llm-provider-catalog.json");
   return JSON.parse(readFileSync(path, "utf-8"));
 }
 
-function loadSearchProviderRegistry(): SearchProviderRegistry {
-  const path = join(REPO_ROOT, "meta", "provider-env-vars.json");
-  return JSON.parse(readFileSync(path, "utf-8"));
-}
-
 describe("CLI provider env-var parity", () => {
   test("LLM_PROVIDER_ENV_VAR_NAMES matches meta/llm-provider-catalog.json entries with envVar", () => {
     const catalog = loadLlmCatalog();
@@ -56,9 +41,4 @@ describe("CLI provider env-var parity", () => {
     }
     expect(LLM_PROVIDER_ENV_VAR_NAMES).toEqual(expected);
   });
-
-  test("SEARCH_PROVIDER_ENV_VAR_NAMES matches meta/provider-env-vars.json", () => {
-    const registry = loadSearchProviderRegistry();
-    expect(SEARCH_PROVIDER_ENV_VAR_NAMES).toEqual(registry.providers);
-  });
 });

package/src/__tests__/multi-local.test.ts

@@ -114,11 +114,6 @@ describe("multi-local", () => {
         expect(res.daemonPort).toBe(DEFAULT_DAEMON_PORT);
         expect(res.gatewayPort).toBe(DEFAULT_GATEWAY_PORT);
         expect(res.qdrantPort).toBe(DEFAULT_QDRANT_PORT);
-
-        // AND the PID file is under the instance's .vellum/
-        expect(res.pidFile).toBe(
-          join(res.instanceDir, ".vellum", "vellum.pid"),
-        );
       } finally {
         if (prevXdg !== undefined) {
           process.env.XDG_DATA_HOME = prevXdg;

package/src/__tests__/sleep.test.ts

@@ -52,7 +52,6 @@ function writeLockfile(): void {
               daemonPort: DEFAULT_DAEMON_PORT,
               gatewayPort: DEFAULT_GATEWAY_PORT,
               qdrantPort: DEFAULT_QDRANT_PORT,
-              pidFile: join(assistantRootDir, "vellum.pid"),
             },
           },
         ],
@@ -158,7 +157,7 @@ describe("sleep command", () => {
     expect(stopProcessByPidFileMock).toHaveBeenCalledTimes(2);
     expect(stopProcessByPidFileMock).toHaveBeenNthCalledWith(
       1,
-      join(assistantRootDir, "vellum.pid"),
+      join(assistantRootDir, "workspace", "vellum.pid"),
       "assistant",
     );
     expect(stopProcessByPidFileMock).toHaveBeenNthCalledWith(