@vellumai/cli 0.5.14 → 0.5.16

package/src/__tests__/teleport.test.ts

@@ -1,5 +1,6 @@
 import {
   afterAll,
+  afterEach,
   beforeEach,
   describe,
   expect,
@@ -33,6 +34,21 @@ const findAssistantByNameMock = spyOn(
   "findAssistantByName",
 ).mockReturnValue(null);
 
+const saveAssistantEntryMock = spyOn(
+  assistantConfig,
+  "saveAssistantEntry",
+).mockImplementation(() => {});
+
+const loadAllAssistantsMock = spyOn(
+  assistantConfig,
+  "loadAllAssistants",
+).mockReturnValue([]);
+
+const removeAssistantEntryMock = spyOn(
+  assistantConfig,
+  "removeAssistantEntry",
+).mockImplementation(() => {});
+
 const loadGuardianTokenMock = mock((_id: string) => ({
   accessToken: "local-token",
   accessTokenExpiresAt: new Date(Date.now() + 60_000).toISOString(),
@@ -49,6 +65,12 @@ mock.module("../lib/guardian-token.js", () => ({
 
 const readPlatformTokenMock = mock((): string | null => "platform-token");
 const fetchOrganizationIdMock = mock(async () => "org-123");
+const getPlatformUrlMock = mock(() => "https://platform.vellum.ai");
+const hatchAssistantMock = mock(async () => ({
+  id: "platform-new-id",
+  name: "platform-new",
+  status: "active",
+}));
 const platformInitiateExportMock = mock(async () => ({
   jobId: "job-1",
   status: "pending",
@@ -90,6 +112,8 @@ const platformImportBundleMock = mock(async () => ({
 mock.module("../lib/platform-client.js", () => ({
   readPlatformToken: readPlatformTokenMock,
   fetchOrganizationId: fetchOrganizationIdMock,
+  getPlatformUrl: getPlatformUrlMock,
+  hatchAssistant: hatchAssistantMock,
   platformInitiateExport: platformInitiateExportMock,
   platformPollExportStatus: platformPollExportStatusMock,
   platformDownloadExport: platformDownloadExportMock,
@@ -97,7 +121,47 @@ mock.module("../lib/platform-client.js", () => ({
   platformImportBundle: platformImportBundleMock,
 }));
 
-import { teleport } from "../commands/teleport.js";
+const hatchLocalMock = mock(async () => {});
+
+mock.module("../lib/hatch-local.js", () => ({
+  hatchLocal: hatchLocalMock,
+}));
+
+const hatchDockerMock = mock(async () => {});
+const retireDockerMock = mock(async () => {});
+
+const sleepContainersMock = mock(async () => {});
+const dockerResourceNamesMock = mock((name: string) => ({
+  assistantContainer: `${name}-assistant`,
+  gatewayContainer: `${name}-gateway`,
+  cesContainer: `${name}-ces`,
+  network: `${name}-net`,
+}));
+
+mock.module("../lib/docker.js", () => ({
+  hatchDocker: hatchDockerMock,
+  retireDocker: retireDockerMock,
+  sleepContainers: sleepContainersMock,
+  dockerResourceNames: dockerResourceNamesMock,
+}));
+
+const stopProcessByPidFileMock = mock(async () => true);
+
+mock.module("../lib/process.js", () => ({
+  stopProcessByPidFile: stopProcessByPidFileMock,
+}));
+
+const retireLocalMock = mock(async () => {});
+
+mock.module("../lib/retire-local.js", () => ({
+  retireLocal: retireLocalMock,
+}));
+
+import {
+  teleport,
+  parseArgs,
+  resolveOrHatchTarget,
+} from "../commands/teleport.js";
 import type { AssistantEntry } from "../lib/assistant-config.js";
 
 // ---------------------------------------------------------------------------
@@ -106,6 +170,9 @@ import type { AssistantEntry } from "../lib/assistant-config.js";
 
 afterAll(() => {
   findAssistantByNameMock.mockRestore();
+  saveAssistantEntryMock.mockRestore();
+  loadAllAssistantsMock.mockRestore();
+  removeAssistantEntryMock.mockRestore();
   rmSync(testDir, { recursive: true, force: true });
   delete process.env.VELLUM_LOCKFILE_DIR;
 });
@@ -122,6 +189,12 @@ beforeEach(() => {
   // Reset all mocks
   findAssistantByNameMock.mockReset();
   findAssistantByNameMock.mockReturnValue(null);
+  saveAssistantEntryMock.mockReset();
+  saveAssistantEntryMock.mockImplementation(() => {});
+  loadAllAssistantsMock.mockReset();
+  loadAllAssistantsMock.mockReturnValue([]);
+  removeAssistantEntryMock.mockReset();
+  removeAssistantEntryMock.mockImplementation(() => {});
 
   loadGuardianTokenMock.mockReset();
   loadGuardianTokenMock.mockReturnValue({
@@ -134,6 +207,14 @@ beforeEach(() => {
   readPlatformTokenMock.mockReturnValue("platform-token");
   fetchOrganizationIdMock.mockReset();
   fetchOrganizationIdMock.mockResolvedValue("org-123");
+  getPlatformUrlMock.mockReset();
+  getPlatformUrlMock.mockReturnValue("https://platform.vellum.ai");
+  hatchAssistantMock.mockReset();
+  hatchAssistantMock.mockResolvedValue({
+    id: "platform-new-id",
+    name: "platform-new",
+    status: "active",
+  });
   platformInitiateExportMock.mockReset();
   platformInitiateExportMock.mockResolvedValue({
     jobId: "job-1",
@@ -176,6 +257,19 @@ beforeEach(() => {
     },
   });
 
+  hatchLocalMock.mockReset();
+  hatchLocalMock.mockResolvedValue(undefined);
+  hatchDockerMock.mockReset();
+  hatchDockerMock.mockResolvedValue(undefined);
+  retireDockerMock.mockReset();
+  retireDockerMock.mockResolvedValue(undefined);
+  retireLocalMock.mockReset();
+  retireLocalMock.mockResolvedValue(undefined);
+  sleepContainersMock.mockReset();
+  sleepContainersMock.mockResolvedValue(undefined);
+  stopProcessByPidFileMock.mockReset();
+  stopProcessByPidFileMock.mockResolvedValue(true);
+
   // Mock process.exit to throw so we can catch it
   exitMock = mock((code?: number) => {
     throw new Error(`process.exit:${code}`);
@@ -187,8 +281,6 @@ beforeEach(() => {
   consoleErrorSpy = spyOn(console, "error").mockImplementation(() => {});
 });
 
-import { afterEach } from "bun:test";
-
 afterEach(() => {
   process.argv = originalArgv;
   process.exit = originalExit;
@@ -213,24 +305,44 @@ function makeEntry(
   };
 }
 
-/** Extract the URL string from a fetch mock call argument. */
-function extractUrl(arg: unknown): string {
-  if (typeof arg === "string") return arg;
-  if (arg && typeof arg === "object" && "url" in arg) {
-    return (arg as { url: string }).url;
-  }
-  return String(arg);
-}
-
-/** Filter fetch mock calls by URL substring. */
-function filterFetchCalls(
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  fetchMock: { mock: { calls: any[][] } },
-  substring: string,
-): unknown[][] {
-  return fetchMock.mock.calls.filter((call: unknown[]) =>
-    extractUrl(call[0]).includes(substring),
-  );
+/** Create a mock fetch that handles export and import endpoints. */
+function createFetchMock() {
+  return mock(async (url: string | URL | Request) => {
+    const urlStr = typeof url === "string" ? url : url.toString();
+    if (urlStr.includes("/export")) {
+      return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
+    }
+    if (urlStr.includes("/import-preflight")) {
+      return new Response(
+        JSON.stringify({
+          can_import: true,
+          summary: {
+            files_to_create: 1,
+            files_to_overwrite: 0,
+            files_unchanged: 0,
+            total_files: 1,
+          },
+        }),
+        { status: 200, headers: { "Content-Type": "application/json" } },
+      );
+    }
+    if (urlStr.includes("/import")) {
+      return new Response(
+        JSON.stringify({
+          success: true,
+          summary: {
+            total_files: 1,
+            files_created: 1,
+            files_overwritten: 0,
+            files_skipped: 0,
+            backups_created: 0,
+          },
+        }),
+        { status: 200, headers: { "Content-Type": "application/json" } },
+      );
+    }
+    return new Response("not found", { status: 404 });
+  });
 }
 
 // ---------------------------------------------------------------------------
@@ -254,7 +366,7 @@ describe("teleport arg parsing", () => {
     );
   });
 
-  test("missing --from and --to prints help and exits 1", async () => {
+  test("missing --from and env flag prints help and exits 1", async () => {
     setArgv();
     await expect(teleport()).rejects.toThrow("process.exit:1");
     expect(consoleLogSpy).toHaveBeenCalledWith(
@@ -262,7 +374,7 @@ describe("teleport arg parsing", () => {
     );
   });
 
-  test("missing --to prints help and exits 1", async () => {
+  test("missing env flag prints help and exits 1", async () => {
     setArgv("--from", "source");
     await expect(teleport()).rejects.toThrow("process.exit:1");
     expect(consoleLogSpy).toHaveBeenCalledWith(
@@ -270,126 +382,122 @@ describe("teleport arg parsing", () => {
     );
   });
 
-  test("missing --from prints help and exits 1", async () => {
-    setArgv("--to", "target");
-    await expect(teleport()).rejects.toThrow("process.exit:1");
-    expect(consoleLogSpy).toHaveBeenCalledWith(
-      expect.stringContaining("Usage:"),
+  test("--local sets targetEnv to 'local' with no name", () => {
+    const result = parseArgs(["--from", "source", "--local"]);
+    expect(result.from).toBe("source");
+    expect(result.targetEnv).toBe("local");
+    expect(result.targetName).toBeUndefined();
+  });
+
+  test("--docker my-name sets targetEnv to 'docker' and targetName to 'my-name'", () => {
+    const result = parseArgs(["--from", "source", "--docker", "my-name"]);
+    expect(result.from).toBe("source");
+    expect(result.targetEnv).toBe("docker");
+    expect(result.targetName).toBe("my-name");
+  });
+
+  test("--platform sets targetEnv to 'platform'", () => {
+    const result = parseArgs(["--from", "source", "--platform"]);
+    expect(result.from).toBe("source");
+    expect(result.targetEnv).toBe("platform");
+    expect(result.targetName).toBeUndefined();
+  });
+
+  test("multiple env flags error", () => {
+    expect(() => parseArgs(["--from", "src", "--local", "--docker"])).toThrow(
+      "process.exit:1",
+    );
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Only one environment flag"),
     );
   });
 
-  test("--from and --to are correctly parsed", async () => {
-    setArgv("--from", "source", "--to", "target");
+  test("--keep-source is parsed", () => {
+    const result = parseArgs(["--from", "source", "--docker", "--keep-source"]);
+    expect(result.keepSource).toBe(true);
+  });
+
+  test("--dry-run is parsed", () => {
+    const result = parseArgs(["--from", "source", "--local", "--dry-run"]);
+    expect(result.dryRun).toBe(true);
+  });
+
+  test("target name after env flag is consumed but --flags are not", () => {
+    const result = parseArgs(["--from", "source", "--docker", "--keep-source"]);
+    expect(result.targetEnv).toBe("docker");
+    expect(result.targetName).toBeUndefined();
+    expect(result.keepSource).toBe(true);
+  });
+});
+
+// ---------------------------------------------------------------------------
+// Same-environment rejection tests
+// ---------------------------------------------------------------------------
+
+describe("same-environment rejection", () => {
+  test("source local, target local -> error (after resolving target)", async () => {
+    setArgv("--from", "src", "--local", "dst");
+
+    const srcEntry = makeEntry("src", { cloud: "local" });
+    const dstEntry = makeEntry("dst", { cloud: "local" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "source") return makeEntry("source");
-      if (name === "target") return makeEntry("target");
+      if (name === "src") return srcEntry;
+      if (name === "dst") return dstEntry;
       return null;
     });
 
-    // This will attempt a fetch to the local export endpoint, which will fail.
-    // We just want to confirm parsing worked (i.e. it gets past the arg check).
-    // Mock global fetch to avoid network calls.
     const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async (url: string | URL | Request) => {
-      const urlStr = typeof url === "string" ? url : url.toString();
-      if (urlStr.includes("/export")) {
-        return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
-      }
-      // import endpoint — return valid JSON
-      return new Response(
-        JSON.stringify({
-          success: true,
-          summary: {
-            total_files: 1,
-            files_created: 1,
-            files_overwritten: 0,
-            files_skipped: 0,
-            backups_created: 0,
-          },
-        }),
-        { status: 200, headers: { "Content-Type": "application/json" } },
-      );
-    });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
-      await teleport();
-      // Should call findAssistantByName for both source and target
-      expect(findAssistantByNameMock).toHaveBeenCalledWith("source");
-      expect(findAssistantByNameMock).toHaveBeenCalledWith("target");
+      await expect(teleport()).rejects.toThrow("process.exit:1");
+      expect(consoleErrorSpy).toHaveBeenCalledWith(
+        expect.stringContaining("Cannot teleport between two local assistants"),
+      );
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("--dry-run flag is detected", async () => {
-    setArgv("--from", "source", "--to", "target", "--dry-run");
+  test("source docker, target docker -> error (after resolving target)", async () => {
+    setArgv("--from", "src", "--docker", "dst");
+
+    const srcEntry = makeEntry("src", { cloud: "docker" });
+    const dstEntry = makeEntry("dst", { cloud: "docker" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "source") return makeEntry("source");
-      if (name === "target") return makeEntry("target");
+      if (name === "src") return srcEntry;
+      if (name === "dst") return dstEntry;
       return null;
     });
 
     const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async (url: string | URL | Request) => {
-      const urlStr = typeof url === "string" ? url : url.toString();
-      if (urlStr.includes("/export")) {
-        return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
-      }
-      if (urlStr.includes("/import-preflight")) {
-        return new Response(
-          JSON.stringify({
-            can_import: true,
-            summary: {
-              files_to_create: 1,
-              files_to_overwrite: 0,
-              files_unchanged: 0,
-              total_files: 1,
-            },
-          }),
-          { status: 200, headers: { "Content-Type": "application/json" } },
-        );
-      }
-      return new Response("not found", { status: 404 });
-    });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
-      await teleport();
-      // In dry-run mode for local target, it should call the preflight endpoint
-      const preflightCalls = filterFetchCalls(fetchMock, "import-preflight");
-      expect(preflightCalls.length).toBe(1);
+      await expect(teleport()).rejects.toThrow("process.exit:1");
+      expect(consoleErrorSpy).toHaveBeenCalledWith(
+        expect.stringContaining(
+          "Cannot teleport between two docker assistants",
+        ),
+      );
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("unknown assistant name causes exit with error", async () => {
-    setArgv("--from", "nonexistent", "--to", "target");
-    findAssistantByNameMock.mockReturnValue(null);
-
-    await expect(teleport()).rejects.toThrow("process.exit:1");
-    expect(consoleErrorSpy).toHaveBeenCalledWith(
-      expect.stringContaining("not found in lockfile"),
-    );
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Cloud resolution tests
-// ---------------------------------------------------------------------------
-
-describe("teleport cloud resolution", () => {
-  test("entry with cloud: 'vellum' resolves to vellum", async () => {
-    setArgv("--from", "src", "--to", "dst");
+  test("source vellum, target platform -> error (after resolving target)", async () => {
+    setArgv("--from", "src", "--platform", "dst");
 
     const srcEntry = makeEntry("src", {
       cloud: "vellum",
       runtimeUrl: "https://platform.vellum.ai",
     });
-    const dstEntry = makeEntry("dst", { cloud: "local" });
+    const dstEntry = makeEntry("dst", {
+      cloud: "vellum",
+      runtimeUrl: "https://platform.vellum.ai",
+    });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
       if (name === "src") return srcEntry;
@@ -397,433 +505,496 @@ describe("teleport cloud resolution", () => {
       return null;
     });
 
-    // Platform export path: readPlatformToken → fetchOrganizationId → initiateExport → poll → download
-    // then local import
     const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async () => {
-      return new Response(
-        JSON.stringify({
-          success: true,
-          summary: {
-            total_files: 1,
-            files_created: 1,
-            files_overwritten: 0,
-            files_skipped: 0,
-            backups_created: 0,
-          },
-        }),
-        { status: 200, headers: { "Content-Type": "application/json" } },
-      );
-    });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
-      await teleport();
-      // Should have used platform export functions
-      expect(platformInitiateExportMock).toHaveBeenCalled();
-      expect(platformPollExportStatusMock).toHaveBeenCalled();
-      expect(platformDownloadExportMock).toHaveBeenCalled();
+      await expect(teleport()).rejects.toThrow("process.exit:1");
+      expect(consoleErrorSpy).toHaveBeenCalledWith(
+        expect.stringContaining(
+          "Cannot teleport between two platform assistants",
+        ),
+      );
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("entry with cloud: 'local' resolves to local", async () => {
-    setArgv("--from", "src", "--to", "dst");
+  test("same-env rejection happens before hatching (no orphaned assistants)", async () => {
+    setArgv("--from", "my-local", "--local");
 
-    const srcEntry = makeEntry("src", { cloud: "local" });
-    const dstEntry = makeEntry("dst", {
-      cloud: "vellum",
-      runtimeUrl: "https://platform.vellum.ai",
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-local") return localEntry;
+      return null;
     });
 
+    await expect(teleport()).rejects.toThrow("process.exit:1");
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Cannot teleport between two local assistants"),
+    );
+    // Crucially: no hatch should have been called — the early guard fires first
+    expect(hatchLocalMock).not.toHaveBeenCalled();
+    expect(hatchDockerMock).not.toHaveBeenCalled();
+    expect(hatchAssistantMock).not.toHaveBeenCalled();
+  });
+
+  test("same-env rejection before hatching for docker", async () => {
+    setArgv("--from", "my-docker", "--docker");
+
+    const dockerEntry = makeEntry("my-docker", { cloud: "docker" });
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "src") return srcEntry;
-      if (name === "dst") return dstEntry;
+      if (name === "my-docker") return dockerEntry;
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async () => {
-      return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
+    await expect(teleport()).rejects.toThrow("process.exit:1");
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Cannot teleport between two docker assistants"),
+    );
+    expect(hatchLocalMock).not.toHaveBeenCalled();
+    expect(hatchDockerMock).not.toHaveBeenCalled();
+    expect(hatchAssistantMock).not.toHaveBeenCalled();
+  });
+
+  test("same-env rejection before hatching for platform (vellum cloud)", async () => {
+    setArgv("--from", "my-cloud", "--platform");
+
+    const platformEntry = makeEntry("my-cloud", {
+      cloud: "vellum",
+      runtimeUrl: "https://platform.vellum.ai",
+    });
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-cloud") return platformEntry;
+      return null;
     });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
 
-    try {
-      await teleport();
-      // Local export uses fetch to /v1/migrations/export
-      const exportCalls = filterFetchCalls(fetchMock, "/v1/migrations/export");
-      expect(exportCalls.length).toBe(1);
-      // Platform import should be called
-      expect(platformImportBundleMock).toHaveBeenCalled();
-    } finally {
-      globalThis.fetch = originalFetch;
-    }
+    await expect(teleport()).rejects.toThrow("process.exit:1");
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining(
+        "Cannot teleport between two platform assistants",
+      ),
+    );
+    expect(hatchLocalMock).not.toHaveBeenCalled();
+    expect(hatchDockerMock).not.toHaveBeenCalled();
+    expect(hatchAssistantMock).not.toHaveBeenCalled();
   });
 
-  test("entry with no cloud but project set resolves to gcp (unsupported)", async () => {
-    setArgv("--from", "src", "--to", "dst");
+  test("flag says docker but resolved target is local -> rejects cloud mismatch", async () => {
+    // User passes --docker but the named target is actually a local assistant
+    setArgv("--from", "src", "--docker", "misidentified");
 
-    // cloud is empty string or undefined — resolveCloud checks entry.project
-    const srcEntry = makeEntry("src", {
-      cloud: "" as string,
-      project: "my-gcp-project",
-    });
-    const dstEntry = makeEntry("dst", { cloud: "local" });
+    const srcEntry = makeEntry("src", { cloud: "vellum" });
+    // Target is actually local despite the --docker flag
+    const dstEntry = makeEntry("misidentified", { cloud: "local" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
       if (name === "src") return srcEntry;
-      if (name === "dst") return dstEntry;
+      if (name === "misidentified") return dstEntry;
       return null;
     });
 
-    // GCP is unsupported, should print error and exit
     await expect(teleport()).rejects.toThrow("process.exit:1");
     expect(consoleErrorSpy).toHaveBeenCalledWith(
-      expect.stringContaining("only supports local and platform"),
+      expect.stringContaining("is a local assistant, not docker"),
     );
   });
+});
 
-  test("entry with no cloud and no project resolves to local", async () => {
-    setArgv("--from", "src", "--to", "dst");
+// ---------------------------------------------------------------------------
+// resolveOrHatchTarget tests
+// ---------------------------------------------------------------------------
 
-    // cloud is falsy, no project — resolveCloud returns "local"
-    const srcEntry = makeEntry("src", { cloud: "" as string });
-    const dstEntry = makeEntry("dst", { cloud: "local" });
+describe("resolveOrHatchTarget", () => {
+  test("existing assistant is returned without hatching", async () => {
+    const dockerEntry = makeEntry("my-docker", { cloud: "docker" });
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-docker") return dockerEntry;
+      return null;
+    });
+
+    const result = await resolveOrHatchTarget("docker", "my-docker");
+    expect(result).toBe(dockerEntry);
+    expect(hatchDockerMock).not.toHaveBeenCalled();
+    expect(consoleLogSpy).toHaveBeenCalledWith(
+      expect.stringContaining("Target: my-docker (docker)"),
+    );
+  });
 
+  test("name not found -> hatch docker", async () => {
+    const newEntry = makeEntry("new-one", { cloud: "docker" });
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "src") return srcEntry;
-      if (name === "dst") return dstEntry;
+      // First call: lookup by name -> not found
+      // Second call: after hatch -> found
+      if (name === "new-one" && hatchDockerMock.mock.calls.length > 0) {
+        return newEntry;
+      }
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async (url: string | URL | Request) => {
-      const urlStr = typeof url === "string" ? url : url.toString();
-      if (urlStr.includes("/export")) {
-        return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
+    const result = await resolveOrHatchTarget("docker", "new-one");
+    expect(hatchDockerMock).toHaveBeenCalledWith(
+      "vellum",
+      false,
+      "new-one",
+      false,
+      {},
+    );
+    expect(result).toBe(newEntry);
+  });
+
+  test("no name -> hatch local with null name, discovers via diff", async () => {
+    const existingEntry = makeEntry("existing-local", { cloud: "local" });
+    const newEntry = makeEntry("auto-generated", { cloud: "local" });
+
+    // Before hatch: only the existing entry
+    // After hatch: existing + new entry
+    loadAllAssistantsMock.mockImplementation(() => {
+      if (hatchLocalMock.mock.calls.length > 0) {
+        return [existingEntry, newEntry];
       }
-      // import endpoint
-      return new Response(
-        JSON.stringify({
-          success: true,
-          summary: {
-            total_files: 1,
-            files_created: 1,
-            files_overwritten: 0,
-            files_skipped: 0,
-            backups_created: 0,
-          },
-        }),
-        { status: 200, headers: { "Content-Type": "application/json" } },
-      );
+      return [existingEntry];
     });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
 
-    try {
-      await teleport();
-      // Should use local export (fetch to /v1/migrations/export)
-      const exportCalls = filterFetchCalls(fetchMock, "/v1/migrations/export");
-      expect(exportCalls.length).toBe(1);
-    } finally {
-      globalThis.fetch = originalFetch;
-    }
+    const result = await resolveOrHatchTarget("local");
+    expect(hatchLocalMock).toHaveBeenCalledWith(
+      "vellum",
+      null,
+      false,
+      false,
+      false,
+      {},
+    );
+    expect(result).toBe(newEntry);
+  });
+
+  test("platform with existing ID -> returns existing without hatching", async () => {
+    const platformEntry = makeEntry("uuid-123", {
+      cloud: "vellum",
+      runtimeUrl: "https://platform.vellum.ai",
+    });
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "uuid-123") return platformEntry;
+      return null;
+    });
+
+    const result = await resolveOrHatchTarget("platform", "uuid-123");
+    expect(result).toBe(platformEntry);
+    expect(hatchAssistantMock).not.toHaveBeenCalled();
+  });
+
+  test("platform with unknown name -> hatches via hatchAssistant", async () => {
+    findAssistantByNameMock.mockReturnValue(null);
+
+    const result = await resolveOrHatchTarget("platform", "nonexistent");
+    expect(hatchAssistantMock).toHaveBeenCalledWith("platform-token");
+    expect(saveAssistantEntryMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        assistantId: "platform-new-id",
+        cloud: "vellum",
+      }),
+    );
+    expect(result.assistantId).toBe("platform-new-id");
+  });
+
+  test("existing assistant with wrong cloud -> rejects", async () => {
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-local") return localEntry;
+      return null;
+    });
+
+    await expect(resolveOrHatchTarget("docker", "my-local")).rejects.toThrow(
+      "process.exit:1",
+    );
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("is a local assistant, not docker"),
+    );
+  });
+
+  test("name with path traversal -> rejects before hatching", async () => {
+    findAssistantByNameMock.mockReturnValue(null);
+
+    await expect(
+      resolveOrHatchTarget("docker", "../../../etc/passwd"),
+    ).rejects.toThrow("process.exit:1");
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("invalid characters"),
+    );
+    expect(hatchDockerMock).not.toHaveBeenCalled();
   });
 });
 
 // ---------------------------------------------------------------------------
-// Transfer routing tests
+// Auto-retire tests
 // ---------------------------------------------------------------------------
 
-describe("teleport transfer routing", () => {
-  test("local → platform calls local export endpoint and platform import", async () => {
-    setArgv("--from", "local-src", "--to", "platform-dst");
+describe("auto-retire", () => {
+  test("local -> docker: stops source before hatch, retires after import", async () => {
+    setArgv("--from", "my-local", "--docker");
+
+    const localEntry = makeEntry("my-local", {
+      cloud: "local",
+      resources: {
+        instanceDir: "/home/test",
+        pidFile: "/home/test/.vellum/assistant.pid",
+        signingKey: "key",
+        daemonPort: 7821,
+        gatewayPort: 7830,
+        qdrantPort: 6333,
+        cesPort: 8090,
+      },
+    });
+    const dockerEntry = makeEntry("new-docker", { cloud: "docker" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "local-src")
-        return makeEntry("local-src", { cloud: "local" });
-      if (name === "platform-dst")
-        return makeEntry("platform-dst", {
-          cloud: "vellum",
-          runtimeUrl: "https://platform.vellum.ai",
-        });
+      if (name === "my-local") return localEntry;
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async () => {
-      return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
+    // Simulate hatch creating a new docker entry
+    loadAllAssistantsMock.mockImplementation(() => {
+      if (hatchDockerMock.mock.calls.length > 0) {
+        return [localEntry, dockerEntry];
+      }
+      return [localEntry];
     });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+
+    const originalFetch = globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
       await teleport();
-
-      // Local export: should call fetch to /v1/migrations/export
-      const exportCalls = filterFetchCalls(fetchMock, "/v1/migrations/export");
-      expect(exportCalls.length).toBe(1);
-
-      // Platform import: should call platformImportBundle
-      expect(platformImportBundleMock).toHaveBeenCalled();
-
-      // Should NOT call platform export functions
-      expect(platformInitiateExportMock).not.toHaveBeenCalled();
+      // Source should be stopped (slept) before hatch
+      expect(stopProcessByPidFileMock).toHaveBeenCalled();
+      // Retire happens after successful import
+      expect(retireLocalMock).toHaveBeenCalledWith("my-local", localEntry);
+      expect(removeAssistantEntryMock).toHaveBeenCalledWith("my-local");
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("platform → local calls platform export functions and local import endpoint", async () => {
-    setArgv("--from", "platform-src", "--to", "local-dst");
+  test("docker -> local: sleeps containers before hatch, retires after import", async () => {
+    setArgv("--from", "my-docker", "--local");
+
+    const dockerEntry = makeEntry("my-docker", { cloud: "docker" });
+    const localEntry = makeEntry("new-local", { cloud: "local" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "platform-src")
-        return makeEntry("platform-src", {
-          cloud: "vellum",
-          runtimeUrl: "https://platform.vellum.ai",
-        });
-      if (name === "local-dst")
-        return makeEntry("local-dst", { cloud: "local" });
+      if (name === "my-docker") return dockerEntry;
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async () => {
-      return new Response(
-        JSON.stringify({
-          success: true,
-          summary: {
-            total_files: 3,
-            files_created: 2,
-            files_overwritten: 1,
-            files_skipped: 0,
-            backups_created: 1,
-          },
-        }),
-        { status: 200, headers: { "Content-Type": "application/json" } },
-      );
+    loadAllAssistantsMock.mockImplementation(() => {
+      if (hatchLocalMock.mock.calls.length > 0) {
+        return [dockerEntry, localEntry];
+      }
+      return [dockerEntry];
     });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+
+    const originalFetch = globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
       await teleport();
-
-      // Platform export: should call all three platform export functions
-      expect(platformInitiateExportMock).toHaveBeenCalled();
-      expect(platformPollExportStatusMock).toHaveBeenCalled();
-      expect(platformDownloadExportMock).toHaveBeenCalled();
-
-      // Local import: should call fetch to /v1/migrations/import (but not /import-preflight)
-      const importCalls = filterFetchCalls(
-        fetchMock,
-        "/v1/migrations/import",
-      ).filter((call) => !extractUrl(call[0]).includes("/import-preflight"));
-      expect(importCalls.length).toBe(1);
-
-      // Should NOT call platformImportBundle
-      expect(platformImportBundleMock).not.toHaveBeenCalled();
+      // Docker source should be slept (containers stopped) before hatch
+      expect(sleepContainersMock).toHaveBeenCalled();
+      // Retire happens after successful import
+      expect(retireDockerMock).toHaveBeenCalledWith("my-docker");
+      expect(removeAssistantEntryMock).toHaveBeenCalledWith("my-docker");
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("--dry-run calls preflight instead of import (local target)", async () => {
-    setArgv("--from", "src", "--to", "dst", "--dry-run");
+  test("--keep-source skips retire and removeAssistantEntry", async () => {
+    setArgv("--from", "my-local", "--docker", "--keep-source");
+
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    const dockerEntry = makeEntry("new-docker", { cloud: "docker" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "src") return makeEntry("src", { cloud: "local" });
-      if (name === "dst") return makeEntry("dst", { cloud: "local" });
+      if (name === "my-local") return localEntry;
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async (url: string | URL | Request) => {
-      const urlStr = typeof url === "string" ? url : url.toString();
-      if (urlStr.includes("/export")) {
-        return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
-      }
-      if (urlStr.includes("/import-preflight")) {
-        return new Response(
-          JSON.stringify({
-            can_import: true,
-            summary: {
-              files_to_create: 1,
-              files_to_overwrite: 0,
-              files_unchanged: 0,
-              total_files: 1,
-            },
-          }),
-          { status: 200, headers: { "Content-Type": "application/json" } },
-        );
+    loadAllAssistantsMock.mockImplementation(() => {
+      if (hatchDockerMock.mock.calls.length > 0) {
+        return [localEntry, dockerEntry];
       }
-      return new Response("not found", { status: 404 });
+      return [localEntry];
     });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+
+    const originalFetch = globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
       await teleport();
-
-      // Should call preflight endpoint
-      const preflightCalls = filterFetchCalls(fetchMock, "import-preflight");
-      expect(preflightCalls.length).toBe(1);
-
-      // Should NOT call the actual import endpoint
-      const importCalls = filterFetchCalls(fetchMock, "/import").filter(
-        (call) => !extractUrl(call[0]).includes("preflight"),
+      expect(retireLocalMock).not.toHaveBeenCalled();
+      expect(retireDockerMock).not.toHaveBeenCalled();
+      expect(removeAssistantEntryMock).not.toHaveBeenCalled();
+      expect(consoleLogSpy).toHaveBeenCalledWith(
+        expect.stringContaining("kept (--keep-source)"),
       );
-      expect(importCalls.length).toBe(0);
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("--dry-run calls platformImportPreflight instead of platformImportBundle (platform target)", async () => {
-    setArgv("--from", "src", "--to", "dst", "--dry-run");
+  test("platform transfers skip retire", async () => {
+    setArgv("--from", "my-local", "--platform");
+
+    const localEntry = makeEntry("my-local", { cloud: "local" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "src") return makeEntry("src", { cloud: "local" });
-      if (name === "dst")
-        return makeEntry("dst", {
-          cloud: "vellum",
-          runtimeUrl: "https://platform.vellum.ai",
-        });
+      if (name === "my-local") return localEntry;
       return null;
     });
 
     const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async () => {
-      return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
-    });
-    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
 
     try {
       await teleport();
-
-      // Should call platformImportPreflight
-      expect(platformImportPreflightMock).toHaveBeenCalled();
-
-      // Should NOT call platformImportBundle
-      expect(platformImportBundleMock).not.toHaveBeenCalled();
+      expect(retireLocalMock).not.toHaveBeenCalled();
+      expect(retireDockerMock).not.toHaveBeenCalled();
+      expect(removeAssistantEntryMock).not.toHaveBeenCalled();
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
 
-  test("platform → platform calls platform export and platform import", async () => {
-    setArgv("--from", "platform-src", "--to", "platform-dst");
+  test("dry-run without existing target does not hatch or export", async () => {
+    setArgv("--from", "my-local", "--docker", "--dry-run");
+
+    const localEntry = makeEntry("my-local", { cloud: "local" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "platform-src")
-        return makeEntry("platform-src", {
-          cloud: "vellum",
-          runtimeUrl: "https://platform.vellum.ai",
-        });
-      if (name === "platform-dst")
-        return makeEntry("platform-dst", {
-          cloud: "vellum",
-          runtimeUrl: "https://platform2.vellum.ai",
-        });
+      if (name === "my-local") return localEntry;
       return null;
     });
 
     await teleport();
 
-    // Platform export: should call all three platform export functions
-    expect(platformInitiateExportMock).toHaveBeenCalled();
-    expect(platformPollExportStatusMock).toHaveBeenCalled();
-    expect(platformDownloadExportMock).toHaveBeenCalled();
+    // Should NOT hatch, export, import, or retire
+    expect(hatchDockerMock).not.toHaveBeenCalled();
+    expect(hatchLocalMock).not.toHaveBeenCalled();
+    expect(hatchAssistantMock).not.toHaveBeenCalled();
+    expect(retireLocalMock).not.toHaveBeenCalled();
+    expect(retireDockerMock).not.toHaveBeenCalled();
+    expect(removeAssistantEntryMock).not.toHaveBeenCalled();
+  });
+
+  test("dry-run with existing target runs preflight without hatching", async () => {
+    setArgv("--from", "my-local", "--docker", "my-docker", "--dry-run");
+
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    const dockerEntry = makeEntry("my-docker", { cloud: "docker" });
+
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-local") return localEntry;
+      if (name === "my-docker") return dockerEntry;
+      return null;
+    });
+
+    const originalFetch = globalThis.fetch;
+    globalThis.fetch = createFetchMock() as unknown as typeof globalThis.fetch;
+
+    try {
+      await teleport();
 
-    // Platform import: should call platformImportBundle
-    expect(platformImportBundleMock).toHaveBeenCalled();
+      // Should NOT hatch or retire
+      expect(hatchDockerMock).not.toHaveBeenCalled();
+      expect(hatchLocalMock).not.toHaveBeenCalled();
+      expect(retireLocalMock).not.toHaveBeenCalled();
+      expect(retireDockerMock).not.toHaveBeenCalled();
+      expect(removeAssistantEntryMock).not.toHaveBeenCalled();
+    } finally {
+      globalThis.fetch = originalFetch;
+    }
   });
 });
 
 // ---------------------------------------------------------------------------
-// Edge case: extra/unrecognized arguments
+// Full flow tests
 // ---------------------------------------------------------------------------
 
-describe("teleport extra arguments", () => {
-  test("extra unrecognized flags are ignored and command works normally", async () => {
-    setArgv(
-      "--from",
-      "src",
-      "--to",
-      "dst",
-      "--bogus-flag",
-      "--another-unknown",
-    );
+describe("teleport full flow", () => {
+  test("hatch and import: --from my-local --docker", async () => {
+    setArgv("--from", "my-local", "--docker");
+
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    const dockerEntry = makeEntry("new-docker", { cloud: "docker" });
 
     findAssistantByNameMock.mockImplementation((name: string) => {
-      if (name === "src") return makeEntry("src", { cloud: "local" });
-      if (name === "dst") return makeEntry("dst", { cloud: "local" });
+      if (name === "my-local") return localEntry;
       return null;
     });
 
-    const originalFetch = globalThis.fetch;
-    const fetchMock = mock(async (url: string | URL | Request) => {
-      const urlStr = typeof url === "string" ? url : url.toString();
-      if (urlStr.includes("/export")) {
-        return new Response(new Uint8Array([1, 2, 3]), { status: 200 });
+    loadAllAssistantsMock.mockImplementation(() => {
+      if (hatchDockerMock.mock.calls.length > 0) {
+        return [localEntry, dockerEntry];
       }
-      return new Response(
-        JSON.stringify({
-          success: true,
-          summary: {
-            total_files: 1,
-            files_created: 1,
-            files_overwritten: 0,
-            files_skipped: 0,
-            backups_created: 0,
-          },
-        }),
-        { status: 200, headers: { "Content-Type": "application/json" } },
-      );
+      return [localEntry];
     });
+
+    const originalFetch = globalThis.fetch;
+    const fetchMock = createFetchMock();
     globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
 
     try {
       await teleport();
-      // Should have proceeded normally despite extra flags
-      expect(findAssistantByNameMock).toHaveBeenCalledWith("src");
-      expect(findAssistantByNameMock).toHaveBeenCalledWith("dst");
-      const exportCalls = filterFetchCalls(fetchMock, "/v1/migrations/export");
-      expect(exportCalls.length).toBe(1);
+
+      // Verify sequence: export, hatch, import, retire
+      expect(hatchDockerMock).toHaveBeenCalled();
+      expect(retireLocalMock).toHaveBeenCalledWith("my-local", localEntry);
+      expect(removeAssistantEntryMock).toHaveBeenCalledWith("my-local");
+      expect(consoleLogSpy).toHaveBeenCalledWith(
+        expect.stringContaining("Teleport complete"),
+      );
     } finally {
       globalThis.fetch = originalFetch;
     }
   });
-});
 
-// ---------------------------------------------------------------------------
-// Edge case: --from or --to without a following value
-// ---------------------------------------------------------------------------
+  test("existing target overwrite: --from my-local --docker my-existing", async () => {
+    setArgv("--from", "my-local", "--docker", "my-existing");
 
-describe("teleport malformed flag usage", () => {
-  test("--from as the last argument (no value) prints help and exits 1", async () => {
-    setArgv("--to", "target", "--from");
-    // --from is the last arg so parseArgs won't assign a value to `from`
-    // This should result in missing --from and trigger help + exit 1
-    await expect(teleport()).rejects.toThrow("process.exit:1");
-    expect(consoleLogSpy).toHaveBeenCalledWith(
-      expect.stringContaining("Usage:"),
-    );
-  });
+    const localEntry = makeEntry("my-local", { cloud: "local" });
+    const dockerEntry = makeEntry("my-existing", { cloud: "docker" });
 
-  test("--to as the last argument (no value) prints help and exits 1", async () => {
-    setArgv("--from", "source", "--to");
-    await expect(teleport()).rejects.toThrow("process.exit:1");
-    expect(consoleLogSpy).toHaveBeenCalledWith(
-      expect.stringContaining("Usage:"),
-    );
+    findAssistantByNameMock.mockImplementation((name: string) => {
+      if (name === "my-local") return localEntry;
+      if (name === "my-existing") return dockerEntry;
+      return null;
+    });
+
+    const originalFetch = globalThis.fetch;
+    const fetchMock = createFetchMock();
+    globalThis.fetch = fetchMock as unknown as typeof globalThis.fetch;
+
+    try {
+      await teleport();
+
+      // No hatch should happen — existing target is used
+      expect(hatchDockerMock).not.toHaveBeenCalled();
+      // Source should still be retired
+      expect(retireLocalMock).toHaveBeenCalledWith("my-local", localEntry);
+      expect(consoleLogSpy).toHaveBeenCalledWith(
+        expect.stringContaining("Teleport complete"),
+      );
+    } finally {
+      globalThis.fetch = originalFetch;
+    }
   });
 
-  test("--from --to target rejects flag-like value for --from, leaving from undefined", async () => {
-    setArgv("--from", "--to", "target");
-    // parseArgs sees --from then skips "--to" (starts with --) so from stays undefined.
-    // --to then correctly consumes "target". from is undefined → prints help and exits 1.
+  test("legacy --to flag shows deprecation message", async () => {
+    setArgv("--from", "source", "--to", "target");
+
     await expect(teleport()).rejects.toThrow("process.exit:1");
-    expect(consoleLogSpy).toHaveBeenCalledWith(
-      expect.stringContaining("Usage:"),
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.stringContaining("--to is deprecated"),
     );
   });
 });