@vellumai/cli 0.4.41 → 0.4.43

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vellumai/cli",
-  "version": "0.4.41",
+  "version": "0.4.43",
   "description": "CLI tools for vellum-assistant",
   "type": "module",
   "exports": {

package/src/__tests__/assistant-config.test.ts

@@ -5,7 +5,7 @@ import { join } from "node:path";
 
 // Point lockfile operations at a temp directory
 const testDir = mkdtempSync(join(tmpdir(), "cli-assistant-config-test-"));
-process.env.BASE_DATA_DIR = testDir;
+process.env.VELLUM_LOCKFILE_DIR = testDir;
 
 import {
   loadLatestAssistant,
@@ -13,12 +13,13 @@ import {
   removeAssistantEntry,
   loadAllAssistants,
   saveAssistantEntry,
+  getActiveAssistant,
   type AssistantEntry,
 } from "../lib/assistant-config.js";
 
 afterAll(() => {
   rmSync(testDir, { recursive: true, force: true });
-  delete process.env.BASE_DATA_DIR;
+  delete process.env.VELLUM_LOCKFILE_DIR;
 });
 
 function writeLockfile(data: unknown): void {
@@ -100,6 +101,36 @@ describe("assistant-config", () => {
     expect(all.map((e) => e.assistantId)).toEqual(["a", "c"]);
   });
 
+  test("removeAssistantEntry reassigns activeAssistant to remaining entry", () => {
+    writeLockfile({
+      assistants: [makeEntry("a"), makeEntry("b")],
+      activeAssistant: "a",
+    });
+    removeAssistantEntry("a");
+    expect(getActiveAssistant()).toBe("b");
+    expect(loadAllAssistants()).toHaveLength(1);
+  });
+
+  test("removeAssistantEntry clears activeAssistant when no entries remain", () => {
+    writeLockfile({
+      assistants: [makeEntry("only")],
+      activeAssistant: "only",
+    });
+    removeAssistantEntry("only");
+    expect(getActiveAssistant()).toBeNull();
+    expect(loadAllAssistants()).toHaveLength(0);
+  });
+
+  test("removeAssistantEntry preserves activeAssistant when removing a different entry", () => {
+    writeLockfile({
+      assistants: [makeEntry("a"), makeEntry("b"), makeEntry("c")],
+      activeAssistant: "a",
+    });
+    removeAssistantEntry("b");
+    expect(getActiveAssistant()).toBe("a");
+    expect(loadAllAssistants()).toHaveLength(2);
+  });
+
   test("loadLatestAssistant returns null when empty", () => {
     expect(loadLatestAssistant()).toBeNull();
   });

package/src/__tests__/constants.test.ts

@@ -23,6 +23,7 @@ describe("constants", () => {
     expect(VALID_REMOTE_HOSTS).toContain("local");
     expect(VALID_REMOTE_HOSTS).toContain("gcp");
     expect(VALID_REMOTE_HOSTS).toContain("aws");
+    expect(VALID_REMOTE_HOSTS).toContain("docker");
     expect(VALID_REMOTE_HOSTS).toContain("custom");
   });
 

package/src/__tests__/multi-local.test.ts

@@ -4,9 +4,9 @@ import { tmpdir } from "node:os";
 import { join } from "node:path";
 
 // Create a temp directory that acts as a fake home, so allocateLocalResources()
-// and defaultLocalResources() never touch the real ~/.vellum directory.
+// never touches the real ~/.vellum directory.
 const testDir = mkdtempSync(join(tmpdir(), "cli-multi-local-test-"));
-process.env.BASE_DATA_DIR = testDir;
+process.env.VELLUM_LOCKFILE_DIR = testDir;
 
 // Mock homedir() to return testDir — this isolates allocateLocalResources()
 // which uses homedir() directly for instance directory creation.
@@ -31,7 +31,6 @@ mock.module("../lib/port-probe.js", () => ({
 
 import {
   allocateLocalResources,
-  defaultLocalResources,
   resolveTargetAssistant,
   setActiveAssistant,
   getActiveAssistant,
@@ -39,11 +38,15 @@ import {
   saveAssistantEntry,
   type AssistantEntry,
 } from "../lib/assistant-config.js";
-import { DEFAULT_DAEMON_PORT } from "../lib/constants.js";
+import {
+  DEFAULT_DAEMON_PORT,
+  DEFAULT_GATEWAY_PORT,
+  DEFAULT_QDRANT_PORT,
+} from "../lib/constants.js";
 
 afterAll(() => {
   rmSync(testDir, { recursive: true, force: true });
-  delete process.env.BASE_DATA_DIR;
+  delete process.env.VELLUM_LOCKFILE_DIR;
 });
 
 function writeLockfile(data: unknown): void {
@@ -91,40 +94,54 @@ describe("multi-local", () => {
   });
 
   describe("allocateLocalResources() produces non-conflicting ports", () => {
-    test("two instances get distinct ports and dirs when first instance ports are occupied", async () => {
-      // After the first allocation grabs its ports, simulate those ports
-      // being in-use so the second allocation must pick different ones.
-      const a = await allocateLocalResources("instance-a");
+    test("first instance gets XDG path and default ports", async () => {
+      // GIVEN no local assistants exist in the lockfile
+
+      // WHEN we allocate resources for the first instance
+      const res = await allocateLocalResources("instance-a");
+
+      // THEN it gets an XDG instance directory under the home dir
+      expect(res.instanceDir).toBe(
+        join(testDir, ".local", "share", "vellum", "assistants", "instance-a"),
+      );
+
+      // AND it gets the default ports since no other instances exist
+      expect(res.daemonPort).toBe(DEFAULT_DAEMON_PORT);
+      expect(res.gatewayPort).toBe(DEFAULT_GATEWAY_PORT);
+      expect(res.qdrantPort).toBe(DEFAULT_QDRANT_PORT);
+    });
+
+    test("second instance gets distinct ports and dir when first instance is saved", async () => {
+      // GIVEN a first local assistant already exists in the lockfile
+      saveAssistantEntry(makeEntry("instance-a"));
+
+      // AND the default ports are occupied
       const occupiedPorts = new Set([
-        a.daemonPort,
-        a.gatewayPort,
-        a.qdrantPort,
+        DEFAULT_DAEMON_PORT,
+        DEFAULT_GATEWAY_PORT,
+        DEFAULT_QDRANT_PORT,
       ]);
       probePortMock.mockImplementation((port: number) =>
         Promise.resolve(occupiedPorts.has(port)),
       );
 
+      // WHEN we allocate resources for a second instance
       const b = await allocateLocalResources("instance-b");
 
-      // All six ports must be unique across both instances
-      const allPorts = [
-        a.daemonPort,
-        a.gatewayPort,
-        a.qdrantPort,
-        b.daemonPort,
-        b.gatewayPort,
-        b.qdrantPort,
-      ];
-      expect(new Set(allPorts).size).toBe(6);
-
-      // Instance dirs must be distinct
-      expect(a.instanceDir).not.toBe(b.instanceDir);
-      expect(a.instanceDir).toContain("instance-a");
+      // THEN the second instance gets non-default ports
+      expect(occupiedPorts.has(b.daemonPort)).toBe(false);
+      expect(occupiedPorts.has(b.gatewayPort)).toBe(false);
+      expect(occupiedPorts.has(b.qdrantPort)).toBe(false);
+
+      // AND it gets its own dedicated instance directory
       expect(b.instanceDir).toContain("instance-b");
     });
 
     test("skips ports that probePort reports as in-use", async () => {
-      // Simulate the default ports being occupied
+      // GIVEN a first local assistant already exists in the lockfile
+      saveAssistantEntry(makeEntry("existing"));
+
+      // AND the default daemon ports are occupied
       const portsInUse = new Set([
         DEFAULT_DAEMON_PORT,
         DEFAULT_DAEMON_PORT + 1,
@@ -133,24 +150,15 @@ describe("multi-local", () => {
         Promise.resolve(portsInUse.has(port)),
       );
 
+      // WHEN we allocate resources for a new instance
       const res = await allocateLocalResources("probe-test");
+
+      // THEN the daemon port skips all occupied ports
       expect(res.daemonPort).toBeGreaterThan(DEFAULT_DAEMON_PORT + 1);
       expect(portsInUse.has(res.daemonPort)).toBe(false);
     });
   });
 
-  describe("defaultLocalResources() returns legacy paths", () => {
-    test("instanceDir is homedir", () => {
-      const res = defaultLocalResources();
-      expect(res.instanceDir).toBe(testDir);
-    });
-
-    test("daemonPort is DEFAULT_DAEMON_PORT", () => {
-      const res = defaultLocalResources();
-      expect(res.daemonPort).toBe(DEFAULT_DAEMON_PORT);
-    });
-  });
-
   describe("resolveTargetAssistant() priority chain", () => {
     test("explicit name returns that entry", () => {
       writeLockfile({
@@ -226,14 +234,14 @@ describe("multi-local", () => {
     });
   });
 
-  describe("removeAssistantEntry() clears matching activeAssistant", () => {
-    test("set active to foo, remove foo, verify active is null", () => {
+  describe("removeAssistantEntry() reassigns activeAssistant on removal", () => {
+    test("set active to foo, remove foo, verify active is reassigned to bar", () => {
       writeLockfile({
         assistants: [makeEntry("foo"), makeEntry("bar")],
         activeAssistant: "foo",
       });
       removeAssistantEntry("foo");
-      expect(getActiveAssistant()).toBeNull();
+      expect(getActiveAssistant()).toBe("bar");
     });
 
     test("set active to foo, remove bar, verify active is still foo", () => {

package/src/__tests__/sleep.test.ts

@@ -0,0 +1,172 @@
+import {
+  afterAll,
+  beforeEach,
+  describe,
+  expect,
+  mock,
+  spyOn,
+  test,
+} from "bun:test";
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+// Create a temp directory and set VELLUM_LOCKFILE_DIR so the real
+// assistant-config module reads/writes the lockfile here instead of ~/.
+const testDir = mkdtempSync(join(tmpdir(), "sleep-command-test-"));
+const assistantRootDir = join(testDir, ".vellum");
+process.env.VELLUM_LOCKFILE_DIR = testDir;
+
+const stopProcessByPidFileMock = mock(async () => true);
+const isProcessAliveMock = mock((): { alive: boolean; pid: number | null } => ({
+  alive: false,
+  pid: null,
+}));
+
+mock.module("../lib/process.js", () => ({
+  isProcessAlive: isProcessAliveMock,
+  stopProcessByPidFile: stopProcessByPidFileMock,
+}));
+
+import { sleep } from "../commands/sleep.js";
+import {
+  DEFAULT_DAEMON_PORT,
+  DEFAULT_GATEWAY_PORT,
+  DEFAULT_QDRANT_PORT,
+} from "../lib/constants.js";
+
+// Write a lockfile entry so the real resolveTargetAssistant() finds our test
+// assistant without needing to mock the entire assistant-config module.
+function writeLockfile(): void {
+  writeFileSync(
+    join(testDir, ".vellum.lock.json"),
+    JSON.stringify(
+      {
+        assistants: [
+          {
+            assistantId: "sleep-test",
+            runtimeUrl: `http://127.0.0.1:${DEFAULT_DAEMON_PORT}`,
+            cloud: "local",
+            resources: {
+              instanceDir: testDir,
+              daemonPort: DEFAULT_DAEMON_PORT,
+              gatewayPort: DEFAULT_GATEWAY_PORT,
+              qdrantPort: DEFAULT_QDRANT_PORT,
+              pidFile: join(assistantRootDir, "vellum.pid"),
+            },
+          },
+        ],
+        activeAssistant: "sleep-test",
+      },
+      null,
+      2,
+    ),
+  );
+}
+
+function writeLeaseFile(callSessionIds: string[]): void {
+  mkdirSync(assistantRootDir, { recursive: true });
+  writeFileSync(
+    join(assistantRootDir, "active-call-leases.json"),
+    JSON.stringify(
+      {
+        version: 1,
+        leases: callSessionIds.map((callSessionId) => ({
+          callSessionId,
+          providerCallSid: null,
+          updatedAt: Date.now(),
+        })),
+      },
+      null,
+      2,
+    ),
+  );
+}
+
+describe("sleep command", () => {
+  let originalArgv: string[];
+
+  beforeEach(() => {
+    originalArgv = [...process.argv];
+    isProcessAliveMock.mockReset();
+    isProcessAliveMock.mockReturnValue({ alive: false, pid: null });
+    stopProcessByPidFileMock.mockReset();
+    stopProcessByPidFileMock.mockResolvedValue(true);
+    rmSync(assistantRootDir, { recursive: true, force: true });
+    writeLockfile();
+  });
+
+  afterAll(() => {
+    process.argv = originalArgv;
+    rmSync(testDir, { recursive: true, force: true });
+    delete process.env.VELLUM_LOCKFILE_DIR;
+  });
+
+  test("refuses normal sleep while an active call lease exists", async () => {
+    isProcessAliveMock.mockReturnValue({ alive: true, pid: 12345 });
+    writeLeaseFile(["call-active-1", "call-active-2"]);
+    process.argv = ["bun", "vellum", "sleep", "sleep-test"];
+
+    const consoleError = spyOn(console, "error").mockImplementation(() => {});
+    const exitMock = mock((code?: number) => {
+      throw new Error(`process.exit:${code}`);
+    });
+    const originalExit = process.exit;
+    process.exit = exitMock as unknown as typeof process.exit;
+
+    try {
+      await expect(sleep()).rejects.toThrow("process.exit:1");
+      expect(consoleError).toHaveBeenCalledWith(
+        expect.stringContaining("vellum sleep --force"),
+      );
+    } finally {
+      process.exit = originalExit;
+      consoleError.mockRestore();
+    }
+
+    expect(stopProcessByPidFileMock).not.toHaveBeenCalled();
+  });
+
+  test("proceeds when assistant is not running even with stale lease file", async () => {
+    isProcessAliveMock.mockReturnValue({ alive: false, pid: null });
+    writeLeaseFile(["call-stale-1"]);
+    process.argv = ["bun", "vellum", "sleep", "sleep-test"];
+
+    const consoleLog = spyOn(console, "log").mockImplementation(() => {});
+
+    try {
+      await sleep();
+    } finally {
+      consoleLog.mockRestore();
+    }
+
+    expect(stopProcessByPidFileMock).toHaveBeenCalledTimes(2);
+  });
+
+  test("force stops the assistant even when an active call lease exists", async () => {
+    writeLeaseFile(["call-active-1"]);
+    process.argv = ["bun", "vellum", "sleep", "sleep-test", "--force"];
+
+    const consoleLog = spyOn(console, "log").mockImplementation(() => {});
+
+    try {
+      await sleep();
+    } finally {
+      consoleLog.mockRestore();
+    }
+
+    expect(stopProcessByPidFileMock).toHaveBeenCalledTimes(2);
+    expect(stopProcessByPidFileMock).toHaveBeenNthCalledWith(
+      1,
+      join(assistantRootDir, "vellum.pid"),
+      "assistant",
+    );
+    expect(stopProcessByPidFileMock).toHaveBeenNthCalledWith(
+      2,
+      join(assistantRootDir, "gateway.pid"),
+      "gateway",
+      undefined,
+      7000,
+    );
+  });
+});

package/src/commands/client.ts

@@ -1,9 +1,12 @@
+import { hostname } from "os";
+
 import {
   findAssistantByName,
   getActiveAssistant,
   loadLatestAssistant,
 } from "../lib/assistant-config";
 import { GATEWAY_PORT, type Species } from "../lib/constants";
+import { getLocalLanIPv4, getMacLocalHostname } from "../lib/local";
 
 const ANSI = {
   reset: "\x1b[0m",
@@ -46,7 +49,7 @@ function parseArgs(): ParsedArgs {
     }
   }
 
-  let entry: ReturnType<typeof findAssistantByName>;
+  let entry: ReturnType<typeof findAssistantByName> = null;
   if (positionalName) {
     entry = findAssistantByName(positionalName);
     if (!entry) {
@@ -55,15 +58,30 @@ function parseArgs(): ParsedArgs {
       );
       process.exit(1);
     }
-  } else if (process.env.RUNTIME_URL) {
-    // Explicit env var — skip assistant resolution, will use env values below
-    entry = loadLatestAssistant();
   } else {
-    // Respect active assistant when set, otherwise fall back to latest
-    // for backward compatibility with remote-only setups.
+    const hasExplicitUrl =
+      process.env.RUNTIME_URL ||
+      flagArgs.includes("--url") ||
+      flagArgs.includes("-u");
     const active = getActiveAssistant();
-    const activeEntry = active ? findAssistantByName(active) : null;
-    entry = activeEntry ?? loadLatestAssistant();
+    if (active) {
+      entry = findAssistantByName(active);
+      if (!entry && !hasExplicitUrl) {
+        console.error(
+          `Active assistant '${active}' not found in lockfile. Set an active assistant with 'vellum use <name>'.`,
+        );
+        process.exit(1);
+      }
+    }
+    if (!entry && hasExplicitUrl) {
+      // URL provided but active assistant missing or unset — use latest for remaining defaults
+      entry = loadLatestAssistant();
+    } else if (!entry) {
+      console.error(
+        "No active assistant set. Set one with 'vellum use <name>' or specify a name: 'vellum client <name>'.",
+      );
+      process.exit(1);
+    }
   }
 
   let runtimeUrl =
@@ -90,7 +108,7 @@ function parseArgs(): ParsedArgs {
   }
 
   return {
-    runtimeUrl: runtimeUrl.replace(/\/+$/, ""),
+    runtimeUrl: maybeSwapToLocalhost(runtimeUrl.replace(/\/+$/, "")),
     assistantId,
     species,
     bearerToken,
@@ -99,6 +117,50 @@ function parseArgs(): ParsedArgs {
   };
 }
 
+/**
+ * If the hostname in `url` matches this machine's local DNS name, LAN IP, or
+ * raw hostname, replace it with 127.0.0.1 so the client avoids mDNS round-trips
+ * when talking to an assistant running on the same machine.
+ */
+function maybeSwapToLocalhost(url: string): string {
+  let parsed: URL;
+  try {
+    parsed = new URL(url);
+  } catch {
+    return url;
+  }
+
+  const urlHost = parsed.hostname.toLowerCase();
+
+  const localNames: string[] = [];
+
+  const host = hostname();
+  if (host) {
+    localNames.push(host.toLowerCase());
+    // Also consider the bare name without .local suffix
+    if (host.toLowerCase().endsWith(".local")) {
+      localNames.push(host.toLowerCase().slice(0, -".local".length));
+    }
+  }
+
+  const macHost = getMacLocalHostname();
+  if (macHost) {
+    localNames.push(macHost.toLowerCase());
+  }
+
+  const lanIp = getLocalLanIPv4();
+  if (lanIp) {
+    localNames.push(lanIp);
+  }
+
+  if (localNames.includes(urlHost)) {
+    parsed.hostname = "127.0.0.1";
+    return parsed.toString().replace(/\/+$/, "");
+  }
+
+  return url;
+}
+
 function printUsage(): void {
   console.log(`${ANSI.bold}vellum client${ANSI.reset} - Connect to a hatched assistant
 
@@ -106,7 +168,7 @@ ${ANSI.bold}USAGE:${ANSI.reset}
     vellum client [name] [options]
 
 ${ANSI.bold}ARGUMENTS:${ANSI.reset}
-    [name]                     Instance name (default: latest)
+    [name]                     Instance name (default: active)
 
 ${ANSI.bold}OPTIONS:${ANSI.reset}
     -u, --url <url>            Runtime URL