@vellumai/assistant 0.8.9-staging.2 → 0.8.9-staging.3

package/src/tools/network/web-fetch.ts

@@ -152,25 +152,56 @@ function isNullBodyStatus(status: number): boolean {
   return status === 204 || status === 205 || status === 304;
 }
 
+// The WHATWG `Response` constructor only accepts 101 or the range 200–599 and
+// throws a `RangeError` for anything else. Some servers — notably anti-bot
+// gateways like LinkedIn and various job boards — reply with non-standard codes
+// such as 999. Map those onto 502 so we can still build a Response; the real
+// upstream status is preserved via `upstreamStatusByResponse` for reporting.
+// See https://developer.mozilla.org/en-US/docs/Web/API/Response/Response
+const RESPONSE_STATUS_SWITCHING_PROTOCOLS = 101;
+const RESPONSE_STATUS_MIN = 200;
+const RESPONSE_STATUS_MAX = 599;
+
+function toConstructableStatus(status: number): number {
+  if (status === RESPONSE_STATUS_SWITCHING_PROTOCOLS) return status;
+  if (status >= RESPONSE_STATUS_MIN && status <= RESPONSE_STATUS_MAX) {
+    return status;
+  }
+  return 502;
+}
+
+const upstreamStatusByResponse = new WeakMap<Response, number>();
+
+// Returns the real status the upstream server sent, which may fall outside the
+// range the `Response` object can represent (e.g. 999). Falls back to
+// `response.status` for responses built by native `fetch`, whose undici
+// implementation already exposes non-standard codes directly.
+export function getUpstreamStatus(response: Response): number {
+  return upstreamStatusByResponse.get(response) ?? response.status;
+}
+
 export function buildFetchResponseFromNodeResponse(
   res: NodeHttpResponseLike,
 ): Response {
-  const status = res.statusCode ?? 502;
+  const upstreamStatus = res.statusCode ?? 502;
+  const status = toConstructableStatus(upstreamStatus);
   const responseHeaders = buildResponseHeaders(res.headers);
   const statusText = res.statusMessage ?? "";
 
-  if (isNullBodyStatus(status)) {
-    // Drain any unexpected bytes and produce a valid null-body fetch Response.
-    res.resume();
-    return new Response(null, { status, statusText, headers: responseHeaders });
-  }
+  const response = isNullBodyStatus(status)
+    ? // Drain any unexpected bytes and produce a valid null-body fetch Response.
+      (res.resume(),
+      new Response(null, { status, statusText, headers: responseHeaders }))
+    : new Response(Readable.toWeb(res) as unknown as BodyInit, {
+        status,
+        statusText,
+        headers: responseHeaders,
+      });
 
-  const body = Readable.toWeb(res);
-  return new Response(body as unknown as BodyInit, {
-    status,
-    statusText,
-    headers: responseHeaders,
-  });
+  if (status !== upstreamStatus) {
+    upstreamStatusByResponse.set(response, upstreamStatus);
+  }
+  return response;
 }
 
 function createAbortError(): Error {
@@ -252,7 +283,16 @@ const defaultRequestExecutor: WebFetchRequestExecutor = async (
 
   return await new Promise<Response>((resolve, reject) => {
     const req = requestFn(requestOptions, (res) => {
-      resolve(buildFetchResponseFromNodeResponse(res));
+      // Building the fetch Response runs inside this HTTP `response` event
+      // callback. Any synchronous throw here would escape as an uncaught
+      // exception and crash the daemon, so funnel failures into `reject` to
+      // keep them local to this request.
+      try {
+        resolve(buildFetchResponseFromNodeResponse(res));
+      } catch (err) {
+        res.resume();
+        reject(err);
+      }
     });
     req.once("error", reject);
     req.end();
@@ -730,9 +770,10 @@ export async function executeWebFetch(
         );
       }
 
+      const upstreamStatus = getUpstreamStatus(response);
       const location = response.headers.get("location");
       const isRedirect =
-        response.status >= 300 && response.status < 400 && !!location;
+        upstreamStatus >= 300 && upstreamStatus < 400 && !!location;
       if (!isRedirect) break;
 
       if (redirectCount >= MAX_REDIRECTS) {
@@ -741,7 +782,7 @@ export async function executeWebFetch(
           {
             url: requestedUrl,
             finalUrl: currentUrl.href,
-            status: response.status,
+            status: getUpstreamStatus(response),
             redirectCount,
           },
         );
@@ -761,7 +802,7 @@ export async function executeWebFetch(
           {
             url: requestedUrl,
             finalUrl: currentUrl.href,
-            status: response.status,
+            status: getUpstreamStatus(response),
             redirectCount,
           },
         );
@@ -773,7 +814,7 @@ export async function executeWebFetch(
           {
             url: requestedUrl,
             finalUrl: currentUrl.href,
-            status: response.status,
+            status: getUpstreamStatus(response),
             redirectCount,
           },
         );
@@ -785,7 +826,7 @@ export async function executeWebFetch(
           {
             url: requestedUrl,
             finalUrl: currentUrl.href,
-            status: response.status,
+            status: getUpstreamStatus(response),
             redirectCount,
           },
         );
@@ -805,7 +846,7 @@ export async function executeWebFetch(
             {
               url: requestedUrl,
               finalUrl: currentUrl.href,
-              status: response.status,
+              status: getUpstreamStatus(response),
               redirectCount,
             },
           );
@@ -817,7 +858,7 @@ export async function executeWebFetch(
             {
               url: requestedUrl,
               finalUrl: currentUrl.href,
-              status: response.status,
+              status: getUpstreamStatus(response),
               redirectCount,
             },
           );
@@ -844,7 +885,7 @@ export async function executeWebFetch(
         {
           url: requestedUrl,
           finalUrl: currentUrl.href,
-          status: response.status,
+          status: getUpstreamStatus(response),
           contentType,
           redirectCount,
         },
@@ -909,7 +950,7 @@ export async function executeWebFetch(
     const content = formatWebFetchOutput({
       requestedUrl: safeRequestedUrl,
       finalUrl: sanitizeUrlForOutput(currentUrl),
-      status: response.status,
+      status: getUpstreamStatus(response),
       statusText: response.statusText,
       contentType,
       bytesRead: body.bytesRead,
@@ -931,7 +972,7 @@ export async function executeWebFetch(
     const meta: WebFetchMetadata = {
       url: safeRequestedUrl,
       finalUrl: sanitizeUrlForOutput(currentUrl),
-      status: response.status,
+      status: getUpstreamStatus(response),
       contentType: contentType || undefined,
       byteCount: body.bytesRead,
       charCount: sliced.length,
@@ -945,7 +986,7 @@ export async function executeWebFetch(
     };
 
     if (!response.ok) {
-      const errorMessage = `Error: HTTP ${response.status}`;
+      const errorMessage = `Error: HTTP ${getUpstreamStatus(response)}`;
       return {
         content: `${errorMessage}\n\n${content}`,
         isError: true,

package/src/tools/ui-surface/definitions.ts

@@ -8,6 +8,7 @@
  */
 
 import { RiskLevel } from "../../permissions/types.js";
+import { ACTIVATION_MOMENT_PARAMS } from "../../telemetry/activation-funnel.js";
 import type {
   ToolContext,
   ToolDefinition,
@@ -204,6 +205,12 @@ export const uiShowTool = {
         description:
           "When true, clicking an action does not dismiss the surface — the card stays visible and only the clicked action is marked as spent. Use for launcher or menu-style cards where multiple buttons may be clicked. Defaults to false.",
       },
+      activation_moment: {
+        type: "string",
+        enum: ACTIVATION_MOMENT_PARAMS,
+        description:
+          "Activation-rail telemetry tag (cohort only). Set this when this surface IS one of the activation funnel moments; the milestone is recorded automatically when the user commits the surface. Omit for all non-activation surfaces.",
+      },
     },
     required: ["surface_type", "data"],
   },

package/src/acp/feature-gate.test.ts

@@ -1,48 +0,0 @@
-/**
- * Tests for the ACP feature gate.
- *
- * `isAcpEnabled` is an OR of the `acp` feature flag and the legacy
- * `config.acp.enabled` field: either switch enables the subsystem, and
- * neither implicitly flips the other.
- */
-
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-
-import { setOverridesForTesting } from "../__tests__/feature-flag-test-helpers.js";
-import type { AssistantConfig } from "../config/schema.js";
-import { ACP_FLAG_KEY, isAcpEnabled } from "./feature-gate.js";
-
-beforeEach(() => {
-  setOverridesForTesting({});
-});
-
-afterEach(() => {
-  setOverridesForTesting({});
-});
-
-/** Minimal AssistantConfig carrying only the `acp` section the gate reads. */
-function makeConfig(acpEnabled: boolean): AssistantConfig {
-  return {
-    acp: { enabled: acpEnabled, maxConcurrentSessions: 4, agents: {} },
-  } as AssistantConfig;
-}
-
-describe("isAcpEnabled", () => {
-  test("returns false when both the flag and config.acp.enabled are off", () => {
-    expect(isAcpEnabled(makeConfig(false))).toBe(false);
-  });
-
-  test("returns true when config.acp.enabled is true and the flag is off", () => {
-    expect(isAcpEnabled(makeConfig(true))).toBe(true);
-  });
-
-  test("returns true when the flag is on and config.acp.enabled is false", () => {
-    setOverridesForTesting({ [ACP_FLAG_KEY]: true });
-    expect(isAcpEnabled(makeConfig(false))).toBe(true);
-  });
-
-  test("explicit flag-off override does not defeat config.acp.enabled", () => {
-    setOverridesForTesting({ [ACP_FLAG_KEY]: false });
-    expect(isAcpEnabled(makeConfig(true))).toBe(true);
-  });
-});

package/src/acp/feature-gate.ts

@@ -1,34 +0,0 @@
-/**
- * ACP (Agent Client Protocol) feature gate.
- *
- * Single source of truth for whether the ACP subsystem is enabled. Modeled
- * on `credential-execution/feature-gates.ts`: the flag key is declared in
- * `meta/feature-flags/feature-flag-registry.json` and resolved through the
- * unified feature-flag resolver.
- *
- * The gate is an OR of two independent switches:
- *   1. `config.acp.enabled` — the original workspace config field. Preserved
- *      so existing workspaces with `acp.enabled: true` keep working without
- *      any migration.
- *   2. The `acp` feature flag — adds a UI toggle. Flag state is persisted by
- *      the gateway and hot-refreshed in the daemon via the
- *      `feature_flags_changed` SSE event, so toggling it takes effect
- *      without a restart or config-file edit.
- */
-
-import { isAssistantFeatureFlagEnabled } from "../config/assistant-feature-flags.js";
-import type { AssistantConfig } from "../config/schema.js";
-
-/** Gate for the ACP coding-agent subsystem (must match the registry). */
-export const ACP_FLAG_KEY = "acp" as const;
-
-/**
- * Whether ACP agent spawning/steering is enabled, via either the legacy
- * `acp.enabled` config field or the `acp` feature flag (see module doc).
- */
-export function isAcpEnabled(config: AssistantConfig): boolean {
-  return (
-    config.acp?.enabled === true ||
-    isAssistantFeatureFlagEnabled(ACP_FLAG_KEY, config)
-  );
-}