@vellumai/assistant 0.8.9-staging.1 → 0.8.9-staging.2

package/src/tools/apps/executors.ts

@@ -68,6 +68,73 @@ export type ProxyResolver = (
   input: Record<string, unknown>,
 ) => Promise<ExecutorResult>;
 
+/**
+ * Validate a `source_files` map (LLM input is not type-checked at runtime).
+ * Returns an error ExecutorResult when invalid, or null when absent/valid.
+ */
+function validateSourceFiles(sourceFiles: unknown): ExecutorResult | null {
+  if (sourceFiles == null) {
+    return null;
+  }
+  if (typeof sourceFiles !== "object" || Array.isArray(sourceFiles)) {
+    return {
+      content: JSON.stringify({
+        error:
+          "source_files must be an object mapping relative file paths to string contents",
+      }),
+      isError: true,
+    };
+  }
+  for (const [key, val] of Object.entries(sourceFiles)) {
+    if (typeof val !== "string") {
+      return {
+        content: JSON.stringify({
+          error: `source_files["${key}"] must be a string, got ${typeof val}`,
+        }),
+        isError: true,
+      };
+    }
+  }
+  return null;
+}
+
+/**
+ * Resolve an app name when the model omits it. The preview card's title is
+ * "always include" guidance and almost always present, so it's the best
+ * fallback — a real, meaningful name — before a generic placeholder.
+ */
+function resolveAppName(input: AppCreateInput): string {
+  const previewTitle =
+    input.preview && typeof input.preview.title === "string"
+      ? input.preview.title
+      : undefined;
+  for (const candidate of [input.name, previewTitle]) {
+    if (typeof candidate === "string" && candidate.trim() !== "") {
+      return candidate.trim();
+    }
+  }
+  return "New App";
+}
+
+/**
+ * Compile-result fields shared by the app_refresh and app_update responses.
+ * On failure the errors/warnings are surfaced so the agent can fix them.
+ */
+function compileResultPayload(
+  compileResult: Awaited<ReturnType<typeof compileApp>>,
+): Record<string, unknown> {
+  return {
+    compiled: compileResult.ok,
+    ...(compileResult.ok
+      ? { compile_duration_ms: compileResult.durationMs }
+      : {
+          compile_errors: compileResult.errors,
+          compile_warnings: compileResult.warnings,
+          compile_duration_ms: compileResult.durationMs,
+        }),
+  };
+}
+
 // ---------------------------------------------------------------------------
 // app_create
 // ---------------------------------------------------------------------------
@@ -92,7 +159,9 @@ export async function executeAppCreate(
   store: AppStore,
   proxyToolResolver?: ProxyResolver,
 ): Promise<ExecutorResult> {
-  const name = input.name;
+  // The model sometimes omits a name; resolve a sensible one rather than
+  // erroring out so the build still succeeds. Users can rename via app_update.
+  const name = resolveAppName(input);
   const description = input.description;
   const schemaJson = input.schema_json ?? "{}";
 
@@ -121,39 +190,9 @@ export async function executeAppCreate(
   const autoOpen = input.auto_open !== false; // default true
   const preview = input.preview;
 
-  // Validate required fields - LLM input is not type-checked at runtime
-  if (typeof name !== "string" || name.trim() === "") {
-    return {
-      content: JSON.stringify({
-        error: "name is required and must be a non-empty string",
-      }),
-      isError: true,
-    };
-  }
-
-  if (input.source_files != null) {
-    if (
-      typeof input.source_files !== "object" ||
-      Array.isArray(input.source_files)
-    ) {
-      return {
-        content: JSON.stringify({
-          error:
-            "source_files must be an object mapping relative file paths to string contents",
-        }),
-        isError: true,
-      };
-    }
-    for (const [key, val] of Object.entries(input.source_files)) {
-      if (typeof val !== "string") {
-        return {
-          content: JSON.stringify({
-            error: `source_files["${key}"] must be a string, got ${typeof val}`,
-          }),
-          isError: true,
-        };
-      }
-    }
+  const sourceFilesError = validateSourceFiles(input.source_files);
+  if (sourceFilesError) {
+    return sourceFilesError;
   }
 
   // Extract icon from preview if provided - only persist emoji-like values,
@@ -356,14 +395,7 @@ export async function executeAppRefresh(
         refreshed: true,
         appId: updated.id,
         name: updated.name,
-        compiled: compileResult.ok,
-        ...(compileResult.ok
-          ? { compile_duration_ms: compileResult.durationMs }
-          : {
-              compile_errors: compileResult.errors,
-              compile_warnings: compileResult.warnings,
-              compile_duration_ms: compileResult.durationMs,
-            }),
+        ...compileResultPayload(compileResult),
       }),
       isError: false,
     };
@@ -379,6 +411,85 @@ export async function executeAppRefresh(
   };
 }
 
+// ---------------------------------------------------------------------------
+// app_update
+// ---------------------------------------------------------------------------
+
+export interface AppUpdateInput {
+  app_id: string;
+  name?: string;
+  description?: string;
+  schema_json?: string;
+  source_files?: Record<string, string>;
+}
+
+export async function executeAppUpdate(
+  input: AppUpdateInput,
+  store: AppStore,
+): Promise<ExecutorResult> {
+  const app = store.getApp(input.app_id);
+  if (!app) {
+    return {
+      content: JSON.stringify({ error: `App '${input.app_id}' not found` }),
+      isError: true,
+    };
+  }
+
+  const sourceFilesError = validateSourceFiles(input.source_files);
+  if (sourceFilesError) {
+    return sourceFilesError;
+  }
+
+  if (input.source_files) {
+    for (const [filePath, content] of Object.entries(input.source_files)) {
+      store.writeAppFile(input.app_id, filePath, content);
+    }
+  }
+
+  const updates: Partial<
+    Pick<AppDefinition, "name" | "description" | "schemaJson">
+  > = {};
+  if (typeof input.name === "string" && input.name.trim() !== "") {
+    updates.name = input.name.trim();
+  }
+  if (typeof input.description === "string") {
+    updates.description = input.description;
+  }
+  if (typeof input.schema_json === "string") {
+    updates.schemaJson = input.schema_json;
+  }
+
+  // An empty update still bumps updatedAt, triggering a client surface refresh.
+  const updated = store.updateApp(input.app_id, updates);
+
+  // Multifile apps recompile so the agent sees any errors from the edited
+  // source instead of serving a stale dist (mirrors app_refresh).
+  if (app.formatVersion === 2) {
+    const appDir = getAppDirPath(input.app_id);
+    const compileResult = await compileApp(appDir);
+    return {
+      content: JSON.stringify({
+        updated: true,
+        appId: updated.id,
+        name: updated.name,
+        description: updated.description,
+        ...compileResultPayload(compileResult),
+      }),
+      isError: false,
+    };
+  }
+
+  return {
+    content: JSON.stringify({
+      updated: true,
+      appId: updated.id,
+      name: updated.name,
+      description: updated.description,
+    }),
+    isError: false,
+  };
+}
+
 // ---------------------------------------------------------------------------
 // app_generate_icon
 // ---------------------------------------------------------------------------

package/src/proactive-artifact/aux-message-injector.ts

@@ -1,97 +0,0 @@
-/**
- * Auxiliary message injection for proactive artifacts.
- *
- * Injects an assistant message into a conversation without going through
- * the normal agent loop. Defers injection while the conversation is
- * actively processing to preserve chronological message ordering.
- */
-
-import { createAssistantMessage } from "../agent/message-types.js";
-import { findConversation } from "../daemon/conversation-registry.js";
-import {
-  conversationMessagesSyncTag,
-  SYNC_TAGS,
-} from "../daemon/message-types/sync.js";
-import { addMessage } from "../memory/conversation-crud.js";
-import type { BroadcastFn } from "../notifications/adapters/macos.js";
-import { getLogger } from "../util/logger.js";
-
-const log = getLogger("aux-message-injector");
-const IDLE_POLL_MS = 200;
-const IDLE_TIMEOUT_MS = 60_000;
-
-async function waitForIdle(conversationId: string): Promise<boolean> {
-  const start = Date.now();
-  while (Date.now() - start < IDLE_TIMEOUT_MS) {
-    const conv = findConversation(conversationId);
-    if (!conv || !conv.isProcessing()) return true;
-    await new Promise((resolve) => setTimeout(resolve, IDLE_POLL_MS));
-  }
-  return false;
-}
-
-export async function injectAuxAssistantMessage(params: {
-  conversationId: string;
-  text: string;
-  broadcastMessage: BroadcastFn;
-}): Promise<void> {
-  const conv = findConversation(params.conversationId);
-  if (conv?.isProcessing()) {
-    const reachedIdle = await waitForIdle(params.conversationId);
-    if (!reachedIdle) {
-      log.warn(
-        { conversationId: params.conversationId },
-        "Timed out waiting for conversation idle; injecting anyway",
-      );
-    }
-  }
-
-  const msg = await addMessage(
-    params.conversationId,
-    "assistant",
-    JSON.stringify([{ type: "text", text: params.text }]),
-    { skipIndexing: true },
-  );
-
-  const current = findConversation(params.conversationId);
-  if (current && !current.isProcessing()) {
-    current.getMessages().push(createAssistantMessage(params.text));
-
-    params.broadcastMessage({
-      type: "assistant_text_delta",
-      text: params.text,
-      conversationId: params.conversationId,
-    });
-    params.broadcastMessage({
-      type: "message_complete",
-      conversationId: params.conversationId,
-      messageId: msg.id,
-      source: "aux",
-    });
-  }
-
-  // The injected aux message bumps `lastMessageAt`, which can move the
-  // row in the paginated sidebar window — that's a shape change. macOS
-  // refreshes its full list on `conversation_list_invalidated`; web
-  // refreshes via the paired `sync_changed` `conversationsList` tag.
-  //
-  // TODO(electron-cutover): drop the `conversation_list_invalidated`
-  // emission once macOS migrates to the Electron client and consumes
-  // `sync_changed` directly. See `runtime/sync/resource-sync-events.ts`
-  // for the symmetric helper used by route handlers.
-  params.broadcastMessage(
-    {
-      type: "conversation_list_invalidated",
-      reason: "reordered",
-    },
-    undefined,
-    { targetInterfaceId: "macos" },
-  );
-  params.broadcastMessage({
-    type: "sync_changed",
-    tags: [
-      SYNC_TAGS.conversationsList,
-      conversationMessagesSyncTag(params.conversationId),
-    ],
-  });
-}

package/src/proactive-artifact/decision.test.ts

@@ -1,226 +0,0 @@
-import { describe, expect, test } from "bun:test";
-
-import {
-  type DecisionOutput,
-  formatTranscript,
-  parseDecisionOutput,
-} from "./decision.js";
-
-describe("parseDecisionOutput", () => {
-  test("parses SHOULD_BUILD: yes with all fields correctly", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: app
-ARTIFACT_TITLE: Sarah's Marathon Training Pace Calculator
-ARTIFACT_DESCRIPTION: An interactive pace calculator that accounts for Sarah's goal of a sub-4-hour marathon, her current 9:30/mile easy pace, and the hilly terrain of the Boston course.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toEqual({
-      shouldBuild: true,
-      artifactType: "app",
-      artifactTitle: "Sarah's Marathon Training Pace Calculator",
-      artifactDescription:
-        "An interactive pace calculator that accounts for Sarah's goal of a sub-4-hour marathon, her current 9:30/mile easy pace, and the hilly terrain of the Boston course.",
-    });
-  });
-
-  test("parses SHOULD_BUILD: no with skip reason", () => {
-    const text = `SHOULD_BUILD: no
-SKIP_REASON: The conversation is too early and generic — the user has only asked a factual question with no personal context.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toEqual({
-      shouldBuild: false,
-      skipReason:
-        "The conversation is too early and generic — the user has only asked a factual question with no personal context.",
-    });
-  });
-
-  test("parses SHOULD_BUILD: no without skip reason defaults to 'no reason given'", () => {
-    const text = `SHOULD_BUILD: no`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toEqual({
-      shouldBuild: false,
-      skipReason: "no reason given",
-    });
-  });
-
-  test("returns null for missing SHOULD_BUILD line", () => {
-    const text = `ARTIFACT_TYPE: app
-ARTIFACT_TITLE: Some Title
-ARTIFACT_DESCRIPTION: Some description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("returns null when yes but ARTIFACT_TYPE is missing", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TITLE: Some Title
-ARTIFACT_DESCRIPTION: Some description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("returns null when yes but ARTIFACT_TYPE is invalid", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: widget
-ARTIFACT_TITLE: Some Title
-ARTIFACT_DESCRIPTION: Some description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("returns null when yes but ARTIFACT_TITLE is missing", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: document
-ARTIFACT_DESCRIPTION: Some description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("returns null when yes but ARTIFACT_DESCRIPTION is missing", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: document
-ARTIFACT_TITLE: Some Title`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("returns null when yes but ARTIFACT_TITLE is empty", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: app
-ARTIFACT_TITLE:
-ARTIFACT_DESCRIPTION: Some description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).toBeNull();
-  });
-
-  test("handles multi-line ARTIFACT_DESCRIPTION", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: document
-ARTIFACT_TITLE: Jake's Q3 OKR Tracker
-ARTIFACT_DESCRIPTION: A structured comparison table for Jake's three competing priorities:
-scaling the data pipeline from 10M to 50M events/day,
-hiring two senior engineers by September,
-and reducing p99 latency below 200ms.`;
-
-    const result = parseDecisionOutput(text) as DecisionOutput & {
-      shouldBuild: true;
-    };
-    expect(result).not.toBeNull();
-    expect(result.shouldBuild).toBe(true);
-    expect(result.artifactType).toBe("document");
-    expect(result.artifactTitle).toBe("Jake's Q3 OKR Tracker");
-    expect(result.artifactDescription).toContain(
-      "A structured comparison table",
-    );
-    expect(result.artifactDescription).toContain(
-      "reducing p99 latency below 200ms",
-    );
-  });
-
-  test("handles case-insensitive SHOULD_BUILD value", () => {
-    const text = `SHOULD_BUILD: Yes
-ARTIFACT_TYPE: app
-ARTIFACT_TITLE: Test Title
-ARTIFACT_DESCRIPTION: Test description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).not.toBeNull();
-    expect(result!.shouldBuild).toBe(true);
-  });
-
-  test("handles case-insensitive ARTIFACT_TYPE value", () => {
-    const text = `SHOULD_BUILD: yes
-ARTIFACT_TYPE: Document
-ARTIFACT_TITLE: Test Title
-ARTIFACT_DESCRIPTION: Test description.`;
-
-    const result = parseDecisionOutput(text);
-    expect(result).not.toBeNull();
-    expect((result as { artifactType: string }).artifactType).toBe("document");
-  });
-});
-
-describe("formatTranscript", () => {
-  test("formats plain text messages correctly", () => {
-    const messages = [
-      { role: "user", content: "Hello, I need help with my project" },
-      {
-        role: "assistant",
-        content: "I'd be happy to help! What kind of project?",
-      },
-      {
-        role: "user",
-        content: "I'm building a fitness tracker for marathon training",
-      },
-    ];
-
-    const result = formatTranscript(messages);
-    expect(result).toBe(
-      `[User]: Hello, I need help with my project
-
-[Assistant]: I'd be happy to help! What kind of project?
-
-[User]: I'm building a fitness tracker for marathon training`,
-    );
-  });
-
-  test("handles JSON content blocks", () => {
-    const messages = [
-      {
-        role: "user",
-        content: JSON.stringify([{ type: "text", text: "What is 2+2?" }]),
-      },
-      {
-        role: "assistant",
-        content: JSON.stringify([
-          { type: "text", text: "The answer is 4." },
-          { type: "text", text: "Would you like to know more?" },
-        ]),
-      },
-    ];
-
-    const result = formatTranscript(messages);
-    expect(result).toBe(
-      `[User]: What is 2+2?
-
-[Assistant]: The answer is 4.
-Would you like to know more?`,
-    );
-  });
-
-  test("handles mixed JSON and plain text messages", () => {
-    const messages = [
-      {
-        role: "user",
-        content: JSON.stringify([
-          { type: "text", text: "Help me plan my week" },
-        ]),
-      },
-      { role: "assistant", content: "Sure, what do you have coming up?" },
-    ];
-
-    const result = formatTranscript(messages);
-    expect(result).toBe(
-      `[User]: Help me plan my week
-
-[Assistant]: Sure, what do you have coming up?`,
-    );
-  });
-
-  test("handles unknown roles", () => {
-    const messages = [
-      { role: "system", content: "You are a helpful assistant" },
-    ];
-
-    const result = formatTranscript(messages);
-    expect(result).toBe("[system]: You are a helpful assistant");
-  });
-});