@vellumai/assistant 0.8.8 → 0.8.9-staging.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (360) hide show
  1. package/ARCHITECTURE.md +6 -6
  2. package/bun.lock +2 -2
  3. package/examples/plugins/echo/README.md +61 -60
  4. package/examples/plugins/echo/hooks/post-tool-use.ts +18 -0
  5. package/examples/plugins/echo/hooks/stop.ts +16 -0
  6. package/examples/plugins/echo/hooks/user-prompt-submit.ts +18 -0
  7. package/examples/plugins/echo/package.json +1 -2
  8. package/examples/plugins/echo/src/emit.ts +19 -0
  9. package/node_modules/@vellumai/skill-host-contracts/src/skill-host.ts +7 -6
  10. package/openapi.yaml +235 -6
  11. package/package.json +2 -2
  12. package/src/__tests__/agent-loop-callsite-precedence.test.ts +69 -14
  13. package/src/__tests__/agent-loop-exit-reason.test.ts +204 -144
  14. package/src/__tests__/agent-loop-mutable-latest-user-message.test.ts +50 -35
  15. package/src/__tests__/agent-loop-output-hooks.test.ts +357 -0
  16. package/src/__tests__/agent-loop-override-profile.test.ts +25 -6
  17. package/src/__tests__/agent-loop-provider-error-recording.test.ts +41 -21
  18. package/src/__tests__/agent-loop-thinking.test.ts +36 -20
  19. package/src/__tests__/agent-loop.test.ts +441 -96
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +14 -14
  21. package/src/__tests__/agent-wake-override-profile.test.ts +17 -21
  22. package/src/__tests__/anthropic-provider.test.ts +1 -1
  23. package/src/__tests__/app-builder-tool-scripts.test.ts +21 -0
  24. package/src/__tests__/app-control-flow.test.ts +1 -1
  25. package/src/__tests__/app-dir-path-guard.test.ts +1 -0
  26. package/src/__tests__/app-executors.test.ts +132 -0
  27. package/src/__tests__/approval-cascade.test.ts +5 -4
  28. package/src/__tests__/approval-routes-http.test.ts +4 -1
  29. package/src/__tests__/background-workers-disk-pressure.test.ts +1 -1
  30. package/src/__tests__/channel-approval-routes.test.ts +1 -1
  31. package/src/__tests__/channel-approvals.test.ts +1 -1
  32. package/src/__tests__/compaction-circuit.test.ts +258 -0
  33. package/src/__tests__/compaction-direct.test.ts +132 -0
  34. package/src/__tests__/compaction-events.test.ts +5 -5
  35. package/src/__tests__/compactor-web-search-strip.test.ts +213 -0
  36. package/src/__tests__/context-overflow-reducer.test.ts +1 -1
  37. package/src/__tests__/conversation-abort-tool-results.test.ts +6 -4
  38. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +7 -10
  39. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +78 -119
  40. package/src/__tests__/conversation-agent-loop-overflow.test.ts +142 -218
  41. package/src/__tests__/conversation-agent-loop.test.ts +297 -586
  42. package/src/__tests__/conversation-clean-command.test.ts +5 -2
  43. package/src/__tests__/conversation-confirmation-signals.test.ts +5 -4
  44. package/src/__tests__/conversation-crud-inference-profile.test.ts +7 -9
  45. package/src/__tests__/conversation-history-web-search.test.ts +1 -1
  46. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +4 -4
  47. package/src/__tests__/conversation-process-callsite.test.ts +14 -14
  48. package/src/__tests__/conversation-provider-retry-repair.test.ts +70 -65
  49. package/src/__tests__/conversation-queue.test.ts +9 -9
  50. package/src/__tests__/conversation-runtime-assembly.test.ts +923 -231
  51. package/src/__tests__/conversation-runtime-workspace.test.ts +115 -20
  52. package/src/__tests__/conversation-slash-queue.test.ts +6 -4
  53. package/src/__tests__/conversation-slash-unknown.test.ts +6 -4
  54. package/src/__tests__/conversation-speed-override.test.ts +10 -9
  55. package/src/__tests__/conversation-starter-routes.test.ts +14 -6
  56. package/src/__tests__/conversation-workspace-cache-state.test.ts +23 -20
  57. package/src/__tests__/conversation-workspace-injection.test.ts +68 -6
  58. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +14 -11
  59. package/src/__tests__/conversations-import-system-filter.test.ts +101 -0
  60. package/src/__tests__/credential-security-invariants.test.ts +0 -1
  61. package/src/__tests__/db-acp-history.test.ts +101 -0
  62. package/src/__tests__/dynamic-page-surface.test.ts +31 -0
  63. package/src/__tests__/empty-response-hook.test.ts +1 -1
  64. package/src/__tests__/file-write-tool.test.ts +63 -0
  65. package/src/__tests__/gateway-only-guard.test.ts +12 -2
  66. package/src/__tests__/guardian-grant-minting.test.ts +1 -1
  67. package/src/__tests__/guardian-routing-invariants.test.ts +2 -4
  68. package/src/__tests__/handlers-user-message-approval-consumption.test.ts +1 -1
  69. package/src/__tests__/heartbeat-disk-pressure.test.ts +1 -0
  70. package/src/__tests__/heartbeat-service.test.ts +1 -0
  71. package/src/__tests__/history-repair-hook.test.ts +1 -1
  72. package/src/__tests__/host-app-control-routes.test.ts +1 -1
  73. package/src/__tests__/host-cu-routes-targeted.test.ts +3 -3
  74. package/src/__tests__/inference-profile-reaper.test.ts +62 -0
  75. package/src/__tests__/inference-profile-session-handler.test.ts +86 -0
  76. package/src/__tests__/injector-background-turn.test.ts +13 -23
  77. package/src/__tests__/injector-chain.test.ts +268 -44
  78. package/src/__tests__/injector-disk-pressure.test.ts +210 -52
  79. package/src/__tests__/injector-document-comments.test.ts +97 -114
  80. package/src/__tests__/injector-pkb-v2-silenced.test.ts +2 -2
  81. package/src/__tests__/injector-v3-suppression.test.ts +4 -4
  82. package/src/__tests__/list-messages-client-message-id.test.ts +91 -0
  83. package/src/__tests__/list-messages-hidden-metadata.test.ts +38 -0
  84. package/src/__tests__/memory-retrieval-hook.test.ts +131 -26
  85. package/src/__tests__/memory-v2-static-injector.test.ts +86 -8
  86. package/src/__tests__/parallel-tool.benchmark.test.ts +35 -8
  87. package/src/__tests__/plugin-api-shim.test.ts +6 -9
  88. package/src/__tests__/plugin-bootstrap.test.ts +12 -23
  89. package/src/__tests__/plugin-registry.test.ts +3 -49
  90. package/src/__tests__/plugin-types.test.ts +0 -70
  91. package/src/__tests__/pre-model-call-sanitize.test.ts +109 -0
  92. package/src/__tests__/reaction-persistence.test.ts +1 -1
  93. package/src/__tests__/send-endpoint-busy.test.ts +4 -1
  94. package/src/__tests__/skill-feature-flags-integration.test.ts +33 -0
  95. package/src/__tests__/steer-tool-repair.test.ts +1 -1
  96. package/src/__tests__/subagent-call-site-routing.test.ts +1 -1
  97. package/src/__tests__/subagent-detail.test.ts +25 -7
  98. package/src/__tests__/subagent-fork-notifications.test.ts +1 -3
  99. package/src/__tests__/subagent-fork-spawn.test.ts +1 -1
  100. package/src/__tests__/subagent-manager-notify.test.ts +1 -3
  101. package/src/__tests__/subagent-notify-parent.test.ts +1 -3
  102. package/src/__tests__/subagent-spawn-tool-fork.test.ts +1 -1
  103. package/src/__tests__/title-generate-hook.test.ts +1 -1
  104. package/src/__tests__/tool-error-hook.test.ts +1 -1
  105. package/src/__tests__/tool-result-truncate-hook.test.ts +1 -1
  106. package/src/__tests__/user-plugin-loader.test.ts +54 -286
  107. package/src/acp/__tests__/agent-process.test.ts +161 -0
  108. package/src/acp/__tests__/client-handler.test.ts +40 -0
  109. package/src/acp/__tests__/helpers/acp-history-db.ts +82 -0
  110. package/src/acp/__tests__/helpers/exec-file-stub.ts +106 -0
  111. package/src/acp/__tests__/prepare-agent-env.test.ts +97 -0
  112. package/src/acp/__tests__/session-manager-persistence.test.ts +95 -28
  113. package/src/acp/__tests__/session-manager-resume.test.ts +888 -0
  114. package/src/acp/agent-process.ts +61 -1
  115. package/src/acp/auto-install.test.ts +280 -0
  116. package/src/acp/auto-install.ts +232 -0
  117. package/src/acp/client-handler.ts +31 -0
  118. package/src/acp/feature-gate.test.ts +48 -0
  119. package/src/acp/feature-gate.ts +34 -0
  120. package/src/acp/prepare-agent-env.ts +80 -27
  121. package/src/acp/resolve-agent.test.ts +225 -9
  122. package/src/acp/resolve-agent.ts +122 -17
  123. package/src/acp/resume-hint.ts +23 -0
  124. package/src/acp/session-manager.ts +507 -73
  125. package/src/agent/compaction-circuit.ts +60 -102
  126. package/src/agent/loop.ts +414 -248
  127. package/src/api/responses/conversation-message.ts +14 -1
  128. package/src/approvals/guardian-request-resolvers.ts +1 -1
  129. package/src/background-wake/next-wake.ts +1 -0
  130. package/src/cli/commands/db/__tests__/repair.test.ts +3 -1
  131. package/src/cli/commands/plugins.ts +43 -37
  132. package/src/cli/lib/__tests__/install-from-github.test.ts +429 -111
  133. package/src/cli/lib/__tests__/plugin-catalog-cache.test.ts +196 -0
  134. package/src/cli/lib/__tests__/plugin-details.test.ts +372 -0
  135. package/src/cli/lib/__tests__/plugin-marketplace.test.ts +220 -0
  136. package/src/cli/lib/__tests__/search-plugins.test.ts +226 -32
  137. package/src/cli/lib/install-from-github.ts +464 -55
  138. package/src/cli/lib/plugin-catalog-cache.ts +84 -0
  139. package/src/cli/lib/plugin-details.ts +409 -0
  140. package/src/cli/lib/plugin-marketplace.ts +197 -0
  141. package/src/cli/lib/search-plugins.ts +195 -29
  142. package/src/config/__tests__/feature-flag-registry-guard.test.ts +2 -2
  143. package/src/config/acp-defaults.test.ts +10 -0
  144. package/src/config/acp-defaults.ts +6 -0
  145. package/src/config/bundled-skills/acp/SKILL.md +85 -33
  146. package/src/config/bundled-skills/acp/TOOLS.json +4 -4
  147. package/src/config/bundled-skills/app-builder/SKILL.md +224 -381
  148. package/src/config/bundled-skills/app-builder/TOOLS.json +72 -2
  149. package/src/config/bundled-skills/app-builder/references/DESIGN_SYSTEM.md +48 -0
  150. package/src/config/bundled-skills/app-builder/references/RESPONSIVE.md +57 -0
  151. package/src/config/bundled-skills/app-builder/references/SLIDES.md +38 -0
  152. package/src/config/bundled-skills/app-builder/tools/app-list.ts +62 -0
  153. package/src/config/bundled-skills/app-builder/tools/app-update.ts +18 -0
  154. package/src/config/bundled-skills/document-editor/SKILL.md +28 -23
  155. package/src/config/bundled-skills/document-editor/TOOLS.json +1 -1
  156. package/src/config/bundled-tool-registry.ts +4 -0
  157. package/src/config/call-site-defaults.ts +0 -2
  158. package/src/config/feature-flag-registry.json +15 -6
  159. package/src/config/schemas/call-site-catalog.ts +0 -14
  160. package/src/config/schemas/heartbeat.ts +9 -0
  161. package/src/config/schemas/llm.ts +0 -2
  162. package/src/context/compactor.ts +22 -4
  163. package/src/context/strip-injections.ts +8 -2
  164. package/src/context/window-manager.ts +27 -13
  165. package/src/daemon/conversation-agent-loop-handlers.ts +10 -35
  166. package/src/daemon/conversation-agent-loop.ts +175 -1055
  167. package/src/daemon/conversation-lifecycle.ts +11 -255
  168. package/src/daemon/conversation-process.ts +8 -136
  169. package/src/daemon/conversation-registry.ts +159 -0
  170. package/src/daemon/conversation-runtime-assembly.ts +293 -392
  171. package/src/daemon/conversation-store.ts +9 -90
  172. package/src/daemon/conversation-surfaces.ts +24 -8
  173. package/src/daemon/conversation-workspace.ts +17 -0
  174. package/src/daemon/conversation.ts +404 -57
  175. package/src/daemon/disk-pressure-policy.ts +0 -1
  176. package/src/daemon/external-plugins-bootstrap.ts +14 -19
  177. package/src/daemon/handlers/conversations.ts +3 -1
  178. package/src/daemon/handlers/skills.ts +4 -1
  179. package/src/daemon/host-proxy-preactivation.ts +1 -3
  180. package/src/daemon/lifecycle.ts +21 -7
  181. package/src/daemon/server.ts +2 -0
  182. package/src/daemon/wake-conversation-ops.ts +269 -0
  183. package/src/embedded/plugin-api.ts +2 -2
  184. package/src/export/__tests__/transcript-formatter.test.ts +5 -0
  185. package/src/heartbeat/__tests__/heartbeat-service.test.ts +3 -0
  186. package/src/heartbeat/heartbeat-run-store.ts +23 -1
  187. package/src/heartbeat/heartbeat-service.ts +26 -0
  188. package/src/ipc/__tests__/browser-ipc.test.ts +1 -1
  189. package/src/ipc/__tests__/ui-request-route.test.ts +3 -3
  190. package/src/ipc/skill-routes/__tests__/memory.test.ts +15 -0
  191. package/src/ipc/skill-routes/memory.ts +4 -2
  192. package/src/memory/__tests__/jobs-worker-v2-schedule.test.ts +87 -0
  193. package/src/memory/conversation-crud.ts +29 -19
  194. package/src/memory/conversation-starter-checkpoints.ts +1 -0
  195. package/src/memory/db-init.ts +2 -0
  196. package/src/memory/job-handlers/conversation-starters.ts +13 -2
  197. package/src/memory/jobs/__tests__/embed-concept-page.test.ts +5 -4
  198. package/src/memory/jobs-worker.ts +25 -1
  199. package/src/memory/migrations/272-acp-session-history-cwd.ts +36 -0
  200. package/src/memory/migrations/index.ts +1 -0
  201. package/src/memory/schema/acp.ts +4 -0
  202. package/src/memory/v2/__tests__/consolidation-job.test.ts +3 -3
  203. package/src/memory/v2/consolidation-job.ts +13 -4
  204. package/src/plugin-api/constants.ts +4 -0
  205. package/src/plugin-api/index.ts +6 -5
  206. package/src/plugin-api/types.ts +75 -0
  207. package/src/plugins/defaults/compaction/compact.ts +59 -0
  208. package/src/{daemon → plugins/defaults/compaction}/context-overflow-reducer.ts +7 -7
  209. package/src/plugins/defaults/compaction/manager-store.ts +57 -0
  210. package/src/plugins/defaults/compaction/package.json +1 -2
  211. package/src/plugins/defaults/empty-response/package.json +0 -1
  212. package/src/plugins/defaults/history-repair/package.json +0 -1
  213. package/src/plugins/defaults/index.ts +135 -26
  214. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +100 -52
  215. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit-temp.ts +184 -74
  216. package/src/plugins/defaults/memory-retrieval/injector-chain.ts +2 -2
  217. package/src/plugins/defaults/{injectors/register.ts → memory-retrieval/injectors.ts} +148 -73
  218. package/src/plugins/defaults/memory-retrieval/unified-turn-context.ts +223 -0
  219. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/assign.test.ts +4 -4
  220. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/live-integration.test.ts +9 -6
  221. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/maintain-job.test.ts +5 -5
  222. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/orchestrate.test.ts +8 -5
  223. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/reconcile.test.ts +2 -2
  224. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/render-injection.test.ts +1 -1
  225. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/router.test.ts +10 -5
  226. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/selection-log-store.test.ts +8 -8
  227. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/selector.test.ts +5 -5
  228. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/shadow-plugin.test.ts +16 -17
  229. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/types.test.ts +2 -2
  230. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/assign.ts +9 -5
  231. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/capabilities.ts +5 -2
  232. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +14 -0
  233. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +19 -0
  234. package/src/plugins/defaults/memory-v3-shadow/injector.ts +75 -0
  235. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/maintain-job.ts +15 -8
  236. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/orchestrate.ts +2 -2
  237. package/src/plugins/defaults/memory-v3-shadow/package.json +14 -0
  238. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/page-content.ts +2 -2
  239. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/provider-blocks.ts +1 -1
  240. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/reconcile.ts +7 -3
  241. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/render-injection.ts +1 -1
  242. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/router.ts +5 -5
  243. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/selection-log-store.ts +4 -4
  244. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/selector.ts +7 -7
  245. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/shadow-plugin.ts +32 -94
  246. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/tree.ts +1 -1
  247. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/types.ts +1 -1
  248. package/src/plugins/defaults/title-generate/package.json +0 -1
  249. package/src/plugins/defaults/tool-error/package.json +0 -1
  250. package/src/plugins/defaults/tool-result-truncate/package.json +0 -1
  251. package/src/plugins/pipeline.ts +6 -293
  252. package/src/plugins/registry.ts +9 -37
  253. package/src/plugins/types.ts +76 -381
  254. package/src/plugins/user-loader.ts +30 -127
  255. package/src/prompts/__tests__/system-prompt.test.ts +6 -0
  256. package/src/prompts/templates/BOOTSTRAP-ACTIVATION-RAIL.md +35 -3
  257. package/src/runtime/__tests__/agent-wake.test.ts +555 -691
  258. package/src/runtime/__tests__/interactive-ui.test.ts +1 -1
  259. package/src/runtime/agent-wake.ts +108 -209
  260. package/src/runtime/assistant-event-hub.ts +1 -1
  261. package/src/runtime/channel-approvals.ts +1 -1
  262. package/src/runtime/interactive-ui.ts +1 -1
  263. package/src/runtime/routes/__tests__/acp-routes.test.ts +315 -55
  264. package/src/runtime/routes/__tests__/conversation-list-routes.test.ts +1 -1
  265. package/src/runtime/routes/__tests__/plugins-routes.test.ts +423 -73
  266. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +5 -4
  267. package/src/runtime/routes/__tests__/surface-content-routes.test.ts +4 -1
  268. package/src/runtime/routes/acp-routes.test.ts +89 -25
  269. package/src/runtime/routes/acp-routes.ts +81 -29
  270. package/src/runtime/routes/approval-routes.ts +1 -1
  271. package/src/runtime/routes/browser-routes.ts +1 -1
  272. package/src/runtime/routes/browser-tabs-routes.ts +6 -10
  273. package/src/runtime/routes/conversation-cli-routes.ts +1 -1
  274. package/src/runtime/routes/conversation-list-routes.ts +1 -1
  275. package/src/runtime/routes/conversation-query-routes.ts +1 -1
  276. package/src/runtime/routes/conversation-routes.ts +28 -2
  277. package/src/runtime/routes/conversation-starter-routes.ts +13 -7
  278. package/src/runtime/routes/conversations-import-routes.ts +24 -7
  279. package/src/runtime/routes/host-app-control-routes.ts +1 -1
  280. package/src/runtime/routes/host-cu-routes.ts +1 -1
  281. package/src/runtime/routes/identity-routes.ts +18 -3
  282. package/src/runtime/routes/inbound-message-handler.ts +1 -1
  283. package/src/runtime/routes/inference-profile-session-handler.ts +11 -0
  284. package/src/runtime/routes/inference-profile-session-reaper.ts +6 -0
  285. package/src/runtime/routes/memory-v3-routes.ts +16 -6
  286. package/src/runtime/routes/playground/helpers.ts +1 -1
  287. package/src/runtime/routes/plugins-routes.ts +337 -35
  288. package/src/runtime/routes/surface-conversation-resolver.ts +4 -3
  289. package/src/runtime/routes/work-items-routes.ts +2 -4
  290. package/src/runtime/services/conversation-serializer.ts +1 -1
  291. package/src/signals/cancel.ts +2 -4
  292. package/src/subagent/manager.ts +21 -5
  293. package/src/tools/acp/context.ts +20 -0
  294. package/src/tools/acp/list-agents.test.ts +8 -2
  295. package/src/tools/acp/spawn.test.ts +176 -195
  296. package/src/tools/acp/spawn.ts +37 -172
  297. package/src/tools/acp/steer.test.ts +105 -8
  298. package/src/tools/acp/steer.ts +48 -17
  299. package/src/tools/apps/executors.ts +166 -50
  300. package/src/tools/filesystem/write.ts +34 -0
  301. package/src/tools/subagent/spawn.ts +2 -4
  302. package/src/tools/ui-surface/definitions.ts +25 -5
  303. package/src/workspace/migrations/051-seed-conversation-summarization-callsite.ts +4 -5
  304. package/src/workspace/migrations/097-enable-adaptive-thinking-managed-profiles.ts +69 -45
  305. package/docs/plugins.md +0 -832
  306. package/examples/plugins/echo/register.ts +0 -143
  307. package/src/__tests__/circuit-breaker-pipeline.test.ts +0 -405
  308. package/src/__tests__/compaction-pipeline.test.ts +0 -210
  309. package/src/__tests__/compaction-timeout-recovery.test.ts +0 -251
  310. package/src/__tests__/overflow-reduce-pipeline.test.ts +0 -667
  311. package/src/__tests__/pipeline-runner.test.ts +0 -554
  312. package/src/__tests__/plugin-external-api.test.ts +0 -68
  313. package/src/daemon/wake-target-adapter.ts +0 -253
  314. package/src/plugins/defaults/circuit-breaker/middlewares/circuitBreaker.ts +0 -93
  315. package/src/plugins/defaults/circuit-breaker/package.json +0 -15
  316. package/src/plugins/defaults/circuit-breaker/register.ts +0 -39
  317. package/src/plugins/defaults/compaction/middlewares/compaction.ts +0 -25
  318. package/src/plugins/defaults/compaction/register.ts +0 -35
  319. package/src/plugins/defaults/compaction/terminal.ts +0 -73
  320. package/src/plugins/defaults/empty-response/register.ts +0 -23
  321. package/src/plugins/defaults/history-repair/register.ts +0 -24
  322. package/src/plugins/defaults/overflow-reduce/middlewares/overflowReduce.ts +0 -126
  323. package/src/plugins/defaults/overflow-reduce/package.json +0 -15
  324. package/src/plugins/defaults/overflow-reduce/register.ts +0 -42
  325. package/src/plugins/defaults/title-generate/register.ts +0 -35
  326. package/src/plugins/defaults/tool-error/register.ts +0 -23
  327. package/src/plugins/defaults/tool-result-truncate/register.ts +0 -24
  328. package/src/plugins/external-api.ts +0 -104
  329. package/src/proactive-artifact/aux-message-injector.ts +0 -97
  330. package/src/proactive-artifact/decision.test.ts +0 -226
  331. package/src/proactive-artifact/decision.ts +0 -165
  332. package/src/proactive-artifact/index.ts +0 -7
  333. package/src/proactive-artifact/job.test.ts +0 -962
  334. package/src/proactive-artifact/job.ts +0 -372
  335. package/src/proactive-artifact/message-copy.ts +0 -58
  336. package/src/proactive-artifact/trigger-state.test.ts +0 -286
  337. package/src/proactive-artifact/trigger-state.ts +0 -123
  338. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/capabilities.test.ts +0 -0
  339. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/core.test.ts +0 -0
  340. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/fixtures/eval-turns.json +0 -0
  341. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/fixtures/live-turns.json +0 -0
  342. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/health.test.ts +0 -0
  343. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/needle.test.ts +0 -0
  344. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/provider-blocks.test.ts +0 -0
  345. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/snapshot.test.ts +0 -0
  346. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/tree.test.ts +0 -0
  347. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/working-set-eviction.test.ts +0 -0
  348. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/working-set-skeleton.test.ts +0 -0
  349. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/core.ts +0 -0
  350. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/README.md +0 -0
  351. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/assignments.json +0 -0
  352. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/core.json +0 -0
  353. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-a/topic-x.md +0 -0
  354. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-a/topic-y.md +0 -0
  355. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-b/topic-z.md +0 -0
  356. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/health.ts +0 -0
  357. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/llm-retry.ts +0 -0
  358. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/needle.ts +0 -0
  359. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/snapshot.ts +0 -0
  360. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/working-set.ts +0 -0
@@ -1,17 +1,22 @@
1
1
  /**
2
- * Tests for the user plugin loader (PR 29).
2
+ * Tests for the user plugin loader.
3
3
  *
4
4
  * Redirects `getWorkspaceDir()` into a per-test temp directory via
5
5
  * `VELLUM_WORKSPACE_DIR` so `loadUserPlugins()` walks an isolated tree
6
6
  * that we populate on demand.
7
7
  *
8
- * Covers:
9
- * - A plugin whose `register.ts` calls `registerPlugin()` at import time
10
- * ends up in the registry after `loadUserPlugins()` resolves.
11
- * - A plugin whose `register.ts` throws during import is logged + skipped;
12
- * other plugins in the same directory still load.
13
- * - A missing `getWorkspaceDir()/plugins/` directory is a no-op (zero installed
14
- * user plugins is the default shape of a fresh daemon).
8
+ * The loader's own responsibility is directory discovery and dispatch: it
9
+ * scans `<workspaceDir>/plugins/*` and hands every subdirectory carrying a
10
+ * `package.json` to `loadExternalPlugin`. The plugin-build mechanics
11
+ * (manifest parsing, hook/tool wiring, the per-plugin timeout, error
12
+ * isolation) are covered directly in `external-plugin-loader.test.ts`; here
13
+ * we assert the discovery contract:
14
+ *
15
+ * - A directory with a `package.json` is loaded and registered.
16
+ * - A directory without a `package.json` is skipped silently.
17
+ * - A missing `getWorkspaceDir()/plugins/` directory is a no-op (zero
18
+ * installed user plugins is the default shape of a fresh daemon).
19
+ * - One failing plugin does not prevent a sibling from registering.
15
20
  */
16
21
  import { mkdirSync, rmSync, writeFileSync } from "node:fs";
17
22
  import { tmpdir } from "node:os";
@@ -26,7 +31,6 @@ import { loadUserPlugins } from "../plugins/user-loader.js";
26
31
 
27
32
  // Isolate every run under its own tempdir so parallel test files (and
28
33
  // repeated runs of this file) cannot collide on `<workspaceDir>/plugins/`.
29
- // Each describe-scope gets a fresh subdirectory.
30
34
  const TEST_WORKSPACE_DIR = join(
31
35
  tmpdir(),
32
36
  `vellum-user-plugin-loader-test-${process.pid}-${Date.now()}`,
@@ -37,30 +41,26 @@ process.env.VELLUM_WORKSPACE_DIR = TEST_WORKSPACE_DIR;
37
41
  const PLUGINS_DIR = join(TEST_WORKSPACE_DIR, "plugins");
38
42
 
39
43
  /**
40
- * Write a plugin directory with a `register.ts` (TypeScript source, so bun
41
- * can import it at test time without a build step) that executes the given
42
- * body. The body has access to `registerPlugin` via a relative import back
43
- * into the repo's registry module.
44
- *
45
- * `relativeRegistryImport` points from the synthetic plugin file at
46
- * `<TEST_WORKSPACE_DIR>/plugins/<name>/register.ts` to the real
47
- * registry source at `<repo>/assistant/src/plugins/registry.ts`. Using a
48
- * relative path (rather than a project-root alias) keeps the test hermetic
49
- * and matches how an on-disk user plugin would actually import the
50
- * registry's public API in a real install.
44
+ * Write a directory-convention plugin: a `package.json` manifest plus any
45
+ * surface files (`hooks/<name>.ts`, `tools/<name>.ts`) whose default export
46
+ * the loader wires up.
51
47
  */
52
- function writePlugin(name: string, body: string): void {
48
+ function writePlugin(
49
+ name: string,
50
+ pkg: Record<string, unknown>,
51
+ files: Record<string, string> = {},
52
+ ): void {
53
53
  const pluginDir = join(PLUGINS_DIR, name);
54
54
  mkdirSync(pluginDir, { recursive: true });
55
- // Resolve the absolute path to the registry module so the synthetic
56
- // register.ts can import it. bun happily resolves `.ts` files at runtime
57
- // when the test suite itself is running in source mode.
58
- const registryPath = join(import.meta.dir, "..", "plugins", "registry.ts");
59
- const registerSource = `
60
- import { registerPlugin } from ${JSON.stringify(registryPath)};
61
- ${body}
62
- `;
63
- writeFileSync(join(pluginDir, "register.ts"), registerSource);
55
+ writeFileSync(join(pluginDir, "package.json"), JSON.stringify(pkg, null, 2));
56
+ for (const [rel, body] of Object.entries(files)) {
57
+ const parts = rel.split("/");
58
+ parts.pop();
59
+ if (parts.length > 0) {
60
+ mkdirSync(join(pluginDir, ...parts), { recursive: true });
61
+ }
62
+ writeFileSync(join(pluginDir, rel), body);
63
+ }
64
64
  }
65
65
 
66
66
  function clearPluginsDir(): void {
@@ -73,17 +73,14 @@ describe("user plugin loader", () => {
73
73
  clearPluginsDir();
74
74
  });
75
75
 
76
- test("loads a valid plugin whose register.ts calls registerPlugin()", async () => {
76
+ test("loads a plugin via its package.json manifest and registers it", async () => {
77
77
  writePlugin(
78
78
  "my-plugin",
79
- `
80
- registerPlugin({
81
- manifest: {
82
- name: "my-plugin",
83
- version: "0.0.1",
84
- },
85
- });
86
- `,
79
+ { name: "my-plugin", version: "0.1.0" },
80
+ {
81
+ "hooks/init.ts":
82
+ "export default async function init(_ctx: unknown): Promise<void> {}\n",
83
+ },
87
84
  );
88
85
 
89
86
  await loadUserPlugins();
@@ -91,34 +88,22 @@ registerPlugin({
91
88
  const registered = getRegisteredPlugins();
92
89
  expect(registered).toHaveLength(1);
93
90
  expect(registered[0]?.manifest.name).toBe("my-plugin");
91
+ expect(typeof registered[0]?.hooks?.init).toBe("function");
94
92
  });
95
93
 
96
94
  test("per-plugin failure is isolated: other plugins still load", async () => {
97
- // Plugin A throws at import time. The loader must log and move on so
98
- // Plugin B still ends up registered — one bad user plugin cannot brick
99
- // the entire user-plugin surface or crash the daemon.
100
- writePlugin(
101
- "broken-plugin",
102
- `
103
- throw new Error("boom at import time");
104
- `,
105
- );
106
- writePlugin(
107
- "good-plugin",
108
- `
109
- registerPlugin({
110
- manifest: {
111
- name: "good-plugin",
112
- version: "0.0.1",
113
- },
114
- });
115
- `,
116
- );
95
+ // Plugin A has a malformed package.json; the loader must isolate the
96
+ // failure and still register the healthy sibling — one bad user plugin
97
+ // cannot brick the entire user-plugin surface or crash the daemon.
98
+ const brokenDir = join(PLUGINS_DIR, "broken-plugin");
99
+ mkdirSync(brokenDir, { recursive: true });
100
+ writeFileSync(join(brokenDir, "package.json"), "{ not valid json");
101
+
102
+ writePlugin("good-plugin", { name: "good-plugin", version: "0.1.0" });
117
103
 
118
104
  await loadUserPlugins();
119
105
 
120
- const registered = getRegisteredPlugins();
121
- const names = registered.map((p) => p.manifest.name);
106
+ const names = getRegisteredPlugins().map((p) => p.manifest.name);
122
107
  // Order is not guaranteed (filesystem-dependent) — assert membership.
123
108
  expect(names).toContain("good-plugin");
124
109
  expect(names).not.toContain("broken-plugin");
@@ -132,92 +117,9 @@ registerPlugin({
132
117
  expect(getRegisteredPlugins()).toHaveLength(0);
133
118
  });
134
119
 
135
- test("plugin with hanging top-level await is timed out and skipped", async () => {
136
- // A plugin whose module evaluation never resolves (hanging top-level
137
- // await) would otherwise block daemon startup indefinitely. The loader
138
- // must bound the import with a timeout so the hang is isolated the same
139
- // way a thrown error would be. A neighboring well-behaved plugin must
140
- // still load.
141
- writePlugin(
142
- "hanging-plugin",
143
- `
144
- await new Promise(() => {
145
- // Intentionally never resolves — simulates a plugin whose top-level
146
- // await blocks forever.
147
- });
148
- registerPlugin({
149
- manifest: {
150
- name: "hanging-plugin",
151
- version: "0.0.1",
152
- },
153
- });
154
- `,
155
- );
156
- writePlugin(
157
- "healthy-plugin",
158
- `
159
- registerPlugin({
160
- manifest: {
161
- name: "healthy-plugin",
162
- version: "0.0.1",
163
- },
164
- });
165
- `,
166
- );
167
-
168
- // Use a short test-only timeout so the suite does not wait the full
169
- // production 10s for the hung-plugin path.
170
- await loadUserPlugins({ importTimeoutMs: 250 });
171
-
172
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
173
- expect(names).toContain("healthy-plugin");
174
- expect(names).not.toContain("hanging-plugin");
175
- });
176
-
177
- test("plugin whose top-level await resolves AFTER the timeout cannot register late", async () => {
178
- // Codex/Devin P1 regression: racing `import(moduleUrl)` against a timeout
179
- // only stops the loader from awaiting the module — it does NOT cancel
180
- // module evaluation. A plugin whose top-level await eventually resolves
181
- // continues running in the background and would otherwise call
182
- // `registerPlugin()` after `loadUserPlugins()` has returned (and after
183
- // `bootstrapPlugins()` has potentially already walked the registry),
184
- // leaving the plugin visible to `getMiddlewaresFor()` with its `init()`
185
- // hook never invoked.
186
- //
187
- // The `closeRegistration()` latch must reject that late arrival so the
188
- // registry stays consistent with the bootstrap invariant.
189
- writePlugin(
190
- "slow-late-plugin",
191
- `
192
- await new Promise((resolve) => setTimeout(resolve, 200));
193
- registerPlugin({
194
- manifest: {
195
- name: "slow-late-plugin",
196
- version: "0.0.1",
197
- },
198
- });
199
- `,
200
- );
201
-
202
- // Time out well before the plugin's top-level await resolves. The loader
203
- // returns immediately; the abandoned import keeps evaluating in the
204
- // background.
205
- await loadUserPlugins({ importTimeoutMs: 25 });
206
-
207
- // Wait long enough for the abandoned import's top-level await to resolve
208
- // and try to `registerPlugin()`. The closed-registration latch must
209
- // reject the call; the `.catch(() => {})` on the abandoned import must
210
- // swallow the resulting rejection so the test does not see an
211
- // unhandled-rejection crash.
212
- await new Promise((resolve) => setTimeout(resolve, 400));
213
-
214
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
215
- expect(names).not.toContain("slow-late-plugin");
216
- });
217
-
218
- test("subdirectory without register.{ts,js} is silently skipped", async () => {
219
- // Populate a directory that looks like a plugin but lacks a register
220
- // file. The loader must skip it without throwing.
120
+ test("subdirectory without package.json is silently skipped", async () => {
121
+ // Populate a directory that looks like a plugin but lacks a manifest.
122
+ // The loader must skip it without throwing.
221
123
  const stubDir = join(PLUGINS_DIR, "not-a-plugin");
222
124
  mkdirSync(stubDir, { recursive: true });
223
125
  writeFileSync(join(stubDir, "README.md"), "# not actually a plugin\n");
@@ -226,146 +128,12 @@ registerPlugin({
226
128
  expect(getRegisteredPlugins()).toHaveLength(0);
227
129
  });
228
130
 
229
- describe("experimental plugin framework branch", () => {
230
- /**
231
- * Write a directory-convention plugin (package.json + optional
232
- * hooks/tools default exports). Mirrors `writePlugin()` above but
233
- * targets the new experimental loader path.
234
- */
235
- function writeExperimentalPlugin(
236
- name: string,
237
- pkg: Record<string, unknown>,
238
- files: Record<string, string> = {},
239
- ): void {
240
- const pluginDir = join(PLUGINS_DIR, name);
241
- mkdirSync(pluginDir, { recursive: true });
242
- writeFileSync(
243
- join(pluginDir, "package.json"),
244
- JSON.stringify(pkg, null, 2),
245
- );
246
- for (const [rel, body] of Object.entries(files)) {
247
- const parts = rel.split("/");
248
- parts.pop();
249
- if (parts.length > 0) {
250
- mkdirSync(join(pluginDir, ...parts), { recursive: true });
251
- }
252
- writeFileSync(join(pluginDir, rel), body);
253
- }
254
- }
255
-
256
- test("loads a plugin via the package.json branch and registers it", async () => {
257
- writeExperimentalPlugin(
258
- "experimental-one",
259
- { name: "experimental-one", version: "0.1.0" },
260
- {
261
- "hooks/init.ts":
262
- "export default async function init(_ctx: unknown): Promise<void> {}\n",
263
- },
264
- );
265
-
266
- await loadUserPlugins();
267
-
268
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
269
- expect(names).toContain("experimental-one");
270
- const registered = getRegisteredPlugins().find(
271
- (p) => p.manifest.name === "experimental-one",
272
- );
273
- expect(typeof registered?.hooks?.init).toBe("function");
274
- });
275
-
276
- test("strips npm scope from package.json name", async () => {
277
- writeExperimentalPlugin("scoped", {
278
- name: "@vellumai/cool-plugin",
279
- version: "0.1.0",
280
- });
281
-
282
- await loadUserPlugins();
131
+ test("strips npm scope from package.json name", async () => {
132
+ writePlugin("scoped", { name: "@vellumai/cool-plugin", version: "0.1.0" });
283
133
 
284
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
285
- expect(names).toContain("cool-plugin");
286
- });
287
-
288
- test("a broken experimental plugin is logged and skipped without affecting others", async () => {
289
- // Plugin A has a malformed package.json; Plugin B is a healthy
290
- // legacy register.ts. The loader must isolate A's failure and still
291
- // register B — same per-plugin contract as the legacy path.
292
- const brokenDir = join(PLUGINS_DIR, "broken-experimental");
293
- mkdirSync(brokenDir, { recursive: true });
294
- writeFileSync(join(brokenDir, "package.json"), "{ not valid json");
295
-
296
- writePlugin(
297
- "healthy-legacy",
298
- `
299
- registerPlugin({
300
- manifest: {
301
- name: "healthy-legacy",
302
- version: "0.0.1",
303
- },
304
- });
305
- `,
306
- );
307
-
308
- await loadUserPlugins();
309
-
310
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
311
- expect(names).toContain("healthy-legacy");
312
- expect(names).not.toContain("broken-experimental");
313
- });
314
-
315
- test("experimental and legacy plugins coexist in one workspace", async () => {
316
- writeExperimentalPlugin("new-style", {
317
- name: "new-style",
318
- version: "0.1.0",
319
- });
320
- writePlugin(
321
- "old-style",
322
- `
323
- registerPlugin({
324
- manifest: {
325
- name: "old-style",
326
- version: "0.0.1",
327
- },
328
- });
329
- `,
330
- );
331
-
332
- await loadUserPlugins();
333
-
334
- const names = getRegisteredPlugins()
335
- .map((p) => p.manifest.name)
336
- .sort();
337
- expect(names).toEqual(["new-style", "old-style"]);
338
- });
339
-
340
- test("package.json branch wins over a stale register.ts in the same dir", async () => {
341
- // A migrated plugin may keep its old register.ts on disk while it
342
- // adopts the new convention. The package.json gate takes the
343
- // experimental path and the legacy register.ts is never imported,
344
- // so the plugin must register exactly once.
345
- const dir = join(PLUGINS_DIR, "migrated");
346
- mkdirSync(dir, { recursive: true });
347
- writeFileSync(
348
- join(dir, "package.json"),
349
- JSON.stringify({ name: "migrated", version: "0.1.0" }),
350
- );
351
- // A register.ts that would double-register if both paths fired.
352
- const registryPath = join(
353
- import.meta.dir,
354
- "..",
355
- "plugins",
356
- "registry.ts",
357
- );
358
- writeFileSync(
359
- join(dir, "register.ts"),
360
- `import { registerPlugin } from ${JSON.stringify(registryPath)};
361
- registerPlugin({ manifest: { name: "migrated", version: "0.0.1", requires: { pluginRuntime: "v1" } } });
362
- `,
363
- );
364
-
365
- await loadUserPlugins();
134
+ await loadUserPlugins();
366
135
 
367
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
368
- expect(names.filter((n) => n === "migrated")).toHaveLength(1);
369
- });
136
+ const names = getRegisteredPlugins().map((p) => p.manifest.name);
137
+ expect(names).toContain("cool-plugin");
370
138
  });
371
139
  });
@@ -0,0 +1,161 @@
1
+ /**
2
+ * Unit tests for AcpAgentProcess capability getters.
3
+ *
4
+ * The getters reflect the InitializeResponse captured during initialize();
5
+ * before that resolves (or after kill()) they must report false. The
6
+ * connection is stubbed directly so no child process is spawned.
7
+ */
8
+
9
+ import { describe, expect, test } from "bun:test";
10
+
11
+ import type { InitializeResponse } from "@agentclientprotocol/sdk";
12
+
13
+ import { AcpAgentProcess } from "../agent-process.js";
14
+
15
+ function makeProcess(): AcpAgentProcess {
16
+ return new AcpAgentProcess(
17
+ "test-agent",
18
+ { command: "echo", args: [] },
19
+ () => {
20
+ throw new Error("client factory should not be called in this test");
21
+ },
22
+ );
23
+ }
24
+
25
+ /** Injects a stub connection whose initialize() resolves with `response`. */
26
+ function stubConnection(
27
+ proc: AcpAgentProcess,
28
+ response: InitializeResponse,
29
+ ): void {
30
+ (
31
+ proc as unknown as {
32
+ connection: { initialize: () => Promise<InitializeResponse> };
33
+ }
34
+ ).connection = {
35
+ initialize: () => Promise.resolve(response),
36
+ };
37
+ }
38
+
39
+ describe("AcpAgentProcess capability getters", () => {
40
+ test("both getters return false before initialize() resolves", () => {
41
+ const proc = makeProcess();
42
+ expect(proc.supportsLoadSession).toBe(false);
43
+ expect(proc.supportsSessionResume).toBe(false);
44
+ });
45
+
46
+ test("supportsLoadSession reflects agentCapabilities.loadSession", async () => {
47
+ const proc = makeProcess();
48
+ stubConnection(proc, {
49
+ protocolVersion: 1,
50
+ agentCapabilities: { loadSession: true },
51
+ });
52
+
53
+ await proc.initialize();
54
+
55
+ expect(proc.supportsLoadSession).toBe(true);
56
+ expect(proc.supportsSessionResume).toBe(false);
57
+ });
58
+
59
+ test("supportsSessionResume reflects agentCapabilities.sessionCapabilities.resume", async () => {
60
+ const proc = makeProcess();
61
+ stubConnection(proc, {
62
+ protocolVersion: 1,
63
+ agentCapabilities: { sessionCapabilities: { resume: {} } },
64
+ });
65
+
66
+ await proc.initialize();
67
+
68
+ expect(proc.supportsSessionResume).toBe(true);
69
+ expect(proc.supportsLoadSession).toBe(false);
70
+ });
71
+
72
+ test("both getters return false when the agent advertises no capabilities", async () => {
73
+ const proc = makeProcess();
74
+ stubConnection(proc, { protocolVersion: 1 });
75
+
76
+ await proc.initialize();
77
+
78
+ expect(proc.supportsLoadSession).toBe(false);
79
+ expect(proc.supportsSessionResume).toBe(false);
80
+ });
81
+
82
+ test("kill() clears the captured initialize response", async () => {
83
+ const proc = makeProcess();
84
+ stubConnection(proc, {
85
+ protocolVersion: 1,
86
+ agentCapabilities: {
87
+ loadSession: true,
88
+ sessionCapabilities: { resume: {} },
89
+ },
90
+ });
91
+
92
+ await proc.initialize();
93
+ expect(proc.supportsLoadSession).toBe(true);
94
+ expect(proc.supportsSessionResume).toBe(true);
95
+
96
+ proc.kill();
97
+
98
+ expect(proc.supportsLoadSession).toBe(false);
99
+ expect(proc.supportsSessionResume).toBe(false);
100
+ });
101
+ });
102
+
103
+ describe("AcpAgentProcess loadSession/resumeSession", () => {
104
+ /** Injects a stub connection that records loadSession/resumeSession params. */
105
+ function stubSessionConnection(proc: AcpAgentProcess): {
106
+ loadCalls: unknown[];
107
+ resumeCalls: unknown[];
108
+ } {
109
+ const loadCalls: unknown[] = [];
110
+ const resumeCalls: unknown[] = [];
111
+ (proc as unknown as { connection: unknown }).connection = {
112
+ loadSession: (params: unknown) => {
113
+ loadCalls.push(params);
114
+ return Promise.resolve({});
115
+ },
116
+ resumeSession: (params: unknown) => {
117
+ resumeCalls.push(params);
118
+ return Promise.resolve({});
119
+ },
120
+ };
121
+ return { loadCalls, resumeCalls };
122
+ }
123
+
124
+ test("loadSession forwards { sessionId, cwd, mcpServers: [] } to the connection", async () => {
125
+ const proc = makeProcess();
126
+ const { loadCalls } = stubSessionConnection(proc);
127
+
128
+ await proc.loadSession("session-1", "/tmp/project");
129
+
130
+ expect(loadCalls).toEqual([
131
+ { sessionId: "session-1", cwd: "/tmp/project", mcpServers: [] },
132
+ ]);
133
+ });
134
+
135
+ test("resumeSession forwards { sessionId, cwd, mcpServers: [] } to the connection", async () => {
136
+ const proc = makeProcess();
137
+ const { resumeCalls } = stubSessionConnection(proc);
138
+
139
+ await proc.resumeSession("session-2", "/tmp/project");
140
+
141
+ expect(resumeCalls).toEqual([
142
+ { sessionId: "session-2", cwd: "/tmp/project", mcpServers: [] },
143
+ ]);
144
+ });
145
+
146
+ test("loadSession throws when the process is not spawned", async () => {
147
+ const proc = makeProcess();
148
+
149
+ await expect(proc.loadSession("session-1", "/tmp/project")).rejects.toThrow(
150
+ 'ACP agent "test-agent" is not spawned',
151
+ );
152
+ });
153
+
154
+ test("resumeSession throws when the process is not spawned", async () => {
155
+ const proc = makeProcess();
156
+
157
+ await expect(
158
+ proc.resumeSession("session-1", "/tmp/project"),
159
+ ).rejects.toThrow('ACP agent "test-agent" is not spawned');
160
+ });
161
+ });
@@ -62,3 +62,43 @@ describe("VellumAcpClientHandler.sessionUpdate", () => {
62
62
  expect(handler.responseText).toBe("");
63
63
  });
64
64
  });
65
+
66
+ describe("VellumAcpClientHandler replay suppression", () => {
67
+ function messageChunk(text: string): SessionNotification {
68
+ return {
69
+ sessionId: ACP_SESSION_ID,
70
+ update: {
71
+ sessionUpdate: "agent_message_chunk",
72
+ content: { type: "text", text },
73
+ },
74
+ };
75
+ }
76
+
77
+ test("updates received while suppressed are dropped", async () => {
78
+ const { handler, sent } = makeHandler();
79
+
80
+ handler.beginReplaySuppression();
81
+ await handler.sessionUpdate(messageChunk("replayed history"));
82
+
83
+ expect(sent).toHaveLength(0);
84
+ expect(handler.responseText).toBe("");
85
+ });
86
+
87
+ test("updates after endReplaySuppression() flow normally", async () => {
88
+ const { handler, sent } = makeHandler();
89
+
90
+ handler.beginReplaySuppression();
91
+ await handler.sessionUpdate(messageChunk("replayed history"));
92
+ handler.endReplaySuppression();
93
+ await handler.sessionUpdate(messageChunk("live response"));
94
+
95
+ expect(sent).toHaveLength(1);
96
+ expect(sent[0]).toEqual({
97
+ type: "acp_session_update",
98
+ acpSessionId: ACP_SESSION_ID,
99
+ updateType: "agent_message_chunk",
100
+ content: "live response",
101
+ });
102
+ expect(handler.responseText).toBe("live response");
103
+ });
104
+ });
@@ -0,0 +1,82 @@
1
+ /**
2
+ * Shared test helpers for the `acp_session_history` table.
3
+ *
4
+ * Several suites (session-manager resume/persistence, the ACP route
5
+ * handlers) seed and read history rows directly via SQL; this module
6
+ * consolidates the copy-pasted row shape + insert/read/clear helpers.
7
+ * Tests must run `initializeDb()` themselves before calling these.
8
+ */
9
+
10
+ import { getSqlite } from "../../../memory/db-connection.js";
11
+
12
+ /** Raw column snapshot of an `acp_session_history` row. */
13
+ export interface HistoryRow {
14
+ id: string;
15
+ agent_id: string;
16
+ acp_session_id: string;
17
+ parent_conversation_id: string;
18
+ started_at: number;
19
+ completed_at: number | null;
20
+ status: string;
21
+ stop_reason: string | null;
22
+ error: string | null;
23
+ event_log_json: string;
24
+ cwd: string | null;
25
+ }
26
+
27
+ export function clearHistory(): void {
28
+ getSqlite().run("DELETE FROM acp_session_history");
29
+ }
30
+
31
+ /**
32
+ * Inserts a history row. Every field except `id` defaults to the values
33
+ * the resume suites were built around (a completed claude run in
34
+ * /tmp/proj); pass explicit values to override, including `null` where the
35
+ * column is nullable (e.g. `cwd: null` for legacy rows).
36
+ */
37
+ export function insertHistoryRow(row: {
38
+ id: string;
39
+ agentId?: string;
40
+ acpSessionId?: string;
41
+ parentConversationId?: string;
42
+ startedAt?: number;
43
+ completedAt?: number | null;
44
+ status?: string;
45
+ stopReason?: string | null;
46
+ error?: string | null;
47
+ eventLogJson?: string;
48
+ cwd?: string | null;
49
+ }): void {
50
+ getSqlite()
51
+ .query(
52
+ `INSERT INTO acp_session_history (
53
+ id, agent_id, acp_session_id, parent_conversation_id,
54
+ started_at, completed_at, status, stop_reason, error,
55
+ event_log_json, cwd
56
+ ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
57
+ )
58
+ .run(
59
+ row.id,
60
+ row.agentId ?? "claude",
61
+ row.acpSessionId ?? "proto-old",
62
+ row.parentConversationId ?? "conv-1",
63
+ row.startedAt ?? 1234,
64
+ row.completedAt === undefined ? 5678 : row.completedAt,
65
+ row.status ?? "completed",
66
+ row.stopReason === undefined ? "end_turn" : row.stopReason,
67
+ row.error ?? null,
68
+ row.eventLogJson ?? "[]",
69
+ row.cwd === undefined ? "/tmp/proj" : row.cwd,
70
+ );
71
+ }
72
+
73
+ export function readHistoryRow(id: string): HistoryRow | null {
74
+ return getSqlite()
75
+ .query(
76
+ `SELECT id, agent_id, acp_session_id, parent_conversation_id,
77
+ started_at, completed_at, status, stop_reason, error,
78
+ event_log_json, cwd
79
+ FROM acp_session_history WHERE id = ?`,
80
+ )
81
+ .get(id) as HistoryRow | null;
82
+ }