@vellumai/assistant 0.8.8 → 0.8.9-staging.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (340) hide show
  1. package/bun.lock +2 -2
  2. package/examples/plugins/echo/README.md +61 -60
  3. package/examples/plugins/echo/hooks/post-tool-use.ts +18 -0
  4. package/examples/plugins/echo/hooks/stop.ts +16 -0
  5. package/examples/plugins/echo/hooks/user-prompt-submit.ts +18 -0
  6. package/examples/plugins/echo/package.json +1 -2
  7. package/examples/plugins/echo/src/emit.ts +19 -0
  8. package/node_modules/@vellumai/skill-host-contracts/src/skill-host.ts +7 -6
  9. package/openapi.yaml +236 -6
  10. package/package.json +2 -2
  11. package/src/__tests__/agent-loop-callsite-precedence.test.ts +69 -14
  12. package/src/__tests__/agent-loop-exit-reason.test.ts +185 -140
  13. package/src/__tests__/agent-loop-mutable-latest-user-message.test.ts +50 -35
  14. package/src/__tests__/agent-loop-output-hooks.test.ts +357 -0
  15. package/src/__tests__/agent-loop-override-profile.test.ts +25 -6
  16. package/src/__tests__/agent-loop-provider-error-recording.test.ts +41 -21
  17. package/src/__tests__/agent-loop-thinking.test.ts +36 -20
  18. package/src/__tests__/agent-loop.test.ts +441 -96
  19. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +14 -14
  20. package/src/__tests__/agent-wake-override-profile.test.ts +17 -21
  21. package/src/__tests__/anthropic-provider.test.ts +1 -1
  22. package/src/__tests__/app-control-flow.test.ts +1 -1
  23. package/src/__tests__/app-dir-path-guard.test.ts +1 -0
  24. package/src/__tests__/approval-cascade.test.ts +5 -4
  25. package/src/__tests__/approval-routes-http.test.ts +4 -1
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +1 -1
  27. package/src/__tests__/channel-approval-routes.test.ts +1 -1
  28. package/src/__tests__/channel-approvals.test.ts +1 -1
  29. package/src/__tests__/compaction-circuit.test.ts +258 -0
  30. package/src/__tests__/compaction-direct.test.ts +132 -0
  31. package/src/__tests__/compaction-events.test.ts +5 -5
  32. package/src/__tests__/conversation-abort-tool-results.test.ts +6 -4
  33. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +7 -10
  34. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +59 -103
  35. package/src/__tests__/conversation-agent-loop-overflow.test.ts +94 -189
  36. package/src/__tests__/conversation-agent-loop.test.ts +249 -490
  37. package/src/__tests__/conversation-clean-command.test.ts +5 -2
  38. package/src/__tests__/conversation-confirmation-signals.test.ts +5 -4
  39. package/src/__tests__/conversation-crud-inference-profile.test.ts +7 -9
  40. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +4 -4
  41. package/src/__tests__/conversation-process-callsite.test.ts +14 -14
  42. package/src/__tests__/conversation-provider-retry-repair.test.ts +18 -16
  43. package/src/__tests__/conversation-queue.test.ts +9 -9
  44. package/src/__tests__/conversation-runtime-assembly.test.ts +923 -231
  45. package/src/__tests__/conversation-runtime-workspace.test.ts +115 -20
  46. package/src/__tests__/conversation-slash-queue.test.ts +6 -4
  47. package/src/__tests__/conversation-slash-unknown.test.ts +6 -4
  48. package/src/__tests__/conversation-speed-override.test.ts +10 -9
  49. package/src/__tests__/conversation-starter-routes.test.ts +14 -6
  50. package/src/__tests__/conversation-workspace-cache-state.test.ts +23 -20
  51. package/src/__tests__/conversation-workspace-injection.test.ts +68 -6
  52. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +14 -11
  53. package/src/__tests__/conversations-import-system-filter.test.ts +101 -0
  54. package/src/__tests__/credential-security-invariants.test.ts +0 -1
  55. package/src/__tests__/db-acp-history.test.ts +101 -0
  56. package/src/__tests__/dynamic-page-surface.test.ts +31 -0
  57. package/src/__tests__/empty-response-hook.test.ts +1 -1
  58. package/src/__tests__/file-write-tool.test.ts +63 -0
  59. package/src/__tests__/gateway-only-guard.test.ts +12 -2
  60. package/src/__tests__/guardian-grant-minting.test.ts +1 -1
  61. package/src/__tests__/guardian-routing-invariants.test.ts +2 -4
  62. package/src/__tests__/handlers-user-message-approval-consumption.test.ts +1 -1
  63. package/src/__tests__/heartbeat-disk-pressure.test.ts +1 -0
  64. package/src/__tests__/heartbeat-service.test.ts +1 -0
  65. package/src/__tests__/history-repair-hook.test.ts +1 -1
  66. package/src/__tests__/host-app-control-routes.test.ts +1 -1
  67. package/src/__tests__/host-cu-routes-targeted.test.ts +3 -3
  68. package/src/__tests__/inference-profile-reaper.test.ts +62 -0
  69. package/src/__tests__/inference-profile-session-handler.test.ts +86 -0
  70. package/src/__tests__/injector-background-turn.test.ts +13 -23
  71. package/src/__tests__/injector-chain.test.ts +268 -44
  72. package/src/__tests__/injector-disk-pressure.test.ts +210 -52
  73. package/src/__tests__/injector-document-comments.test.ts +97 -114
  74. package/src/__tests__/injector-pkb-v2-silenced.test.ts +2 -2
  75. package/src/__tests__/injector-v3-suppression.test.ts +4 -4
  76. package/src/__tests__/list-messages-client-message-id.test.ts +91 -0
  77. package/src/__tests__/list-messages-hidden-metadata.test.ts +38 -0
  78. package/src/__tests__/memory-retrieval-hook.test.ts +73 -6
  79. package/src/__tests__/memory-v2-static-injector.test.ts +86 -8
  80. package/src/__tests__/parallel-tool.benchmark.test.ts +35 -8
  81. package/src/__tests__/plugin-api-shim.test.ts +6 -9
  82. package/src/__tests__/plugin-bootstrap.test.ts +12 -23
  83. package/src/__tests__/plugin-registry.test.ts +3 -49
  84. package/src/__tests__/plugin-types.test.ts +0 -70
  85. package/src/__tests__/reaction-persistence.test.ts +1 -1
  86. package/src/__tests__/send-endpoint-busy.test.ts +4 -1
  87. package/src/__tests__/skill-feature-flags-integration.test.ts +33 -0
  88. package/src/__tests__/steer-tool-repair.test.ts +1 -1
  89. package/src/__tests__/subagent-call-site-routing.test.ts +1 -1
  90. package/src/__tests__/subagent-detail.test.ts +25 -7
  91. package/src/__tests__/subagent-fork-notifications.test.ts +1 -3
  92. package/src/__tests__/subagent-fork-spawn.test.ts +1 -1
  93. package/src/__tests__/subagent-manager-notify.test.ts +1 -3
  94. package/src/__tests__/subagent-notify-parent.test.ts +1 -3
  95. package/src/__tests__/subagent-spawn-tool-fork.test.ts +1 -1
  96. package/src/__tests__/title-generate-hook.test.ts +1 -1
  97. package/src/__tests__/tool-error-hook.test.ts +1 -1
  98. package/src/__tests__/tool-result-truncate-hook.test.ts +1 -1
  99. package/src/__tests__/user-plugin-loader.test.ts +54 -286
  100. package/src/acp/__tests__/agent-process.test.ts +161 -0
  101. package/src/acp/__tests__/client-handler.test.ts +40 -0
  102. package/src/acp/__tests__/helpers/acp-history-db.ts +82 -0
  103. package/src/acp/__tests__/helpers/exec-file-stub.ts +101 -0
  104. package/src/acp/__tests__/prepare-agent-env.test.ts +137 -0
  105. package/src/acp/__tests__/session-manager-persistence.test.ts +95 -28
  106. package/src/acp/__tests__/session-manager-resume.test.ts +736 -0
  107. package/src/acp/agent-process.ts +61 -1
  108. package/src/acp/auto-install.test.ts +196 -0
  109. package/src/acp/auto-install.ts +177 -0
  110. package/src/acp/client-handler.ts +31 -0
  111. package/src/acp/feature-gate.test.ts +48 -0
  112. package/src/acp/feature-gate.ts +34 -0
  113. package/src/acp/prepare-agent-env.ts +83 -29
  114. package/src/acp/resolve-agent.test.ts +320 -7
  115. package/src/acp/resolve-agent.ts +182 -18
  116. package/src/acp/resume-hint.ts +25 -0
  117. package/src/acp/session-manager.ts +495 -73
  118. package/src/acp/types.ts +8 -0
  119. package/src/agent/compaction-circuit.ts +60 -102
  120. package/src/agent/loop.ts +390 -240
  121. package/src/api/responses/conversation-message.ts +14 -1
  122. package/src/approvals/guardian-request-resolvers.ts +1 -1
  123. package/src/background-wake/next-wake.ts +1 -0
  124. package/src/cli/commands/db/__tests__/repair.test.ts +3 -1
  125. package/src/cli/commands/plugins.ts +43 -37
  126. package/src/cli/lib/__tests__/install-from-github.test.ts +429 -111
  127. package/src/cli/lib/__tests__/plugin-catalog-cache.test.ts +196 -0
  128. package/src/cli/lib/__tests__/plugin-details.test.ts +372 -0
  129. package/src/cli/lib/__tests__/plugin-marketplace.test.ts +220 -0
  130. package/src/cli/lib/__tests__/search-plugins.test.ts +226 -32
  131. package/src/cli/lib/install-from-github.ts +464 -55
  132. package/src/cli/lib/plugin-catalog-cache.ts +84 -0
  133. package/src/cli/lib/plugin-details.ts +409 -0
  134. package/src/cli/lib/plugin-marketplace.ts +197 -0
  135. package/src/cli/lib/search-plugins.ts +195 -29
  136. package/src/config/__tests__/feature-flag-registry-guard.test.ts +2 -2
  137. package/src/config/acp-defaults.test.ts +10 -0
  138. package/src/config/acp-defaults.ts +6 -0
  139. package/src/config/bundled-skills/acp/SKILL.md +83 -31
  140. package/src/config/bundled-skills/acp/TOOLS.json +4 -4
  141. package/src/config/bundled-skills/app-builder/SKILL.md +224 -381
  142. package/src/config/bundled-skills/app-builder/TOOLS.json +29 -0
  143. package/src/config/bundled-skills/app-builder/references/DESIGN_SYSTEM.md +48 -0
  144. package/src/config/bundled-skills/app-builder/references/RESPONSIVE.md +57 -0
  145. package/src/config/bundled-skills/app-builder/references/SLIDES.md +38 -0
  146. package/src/config/bundled-skills/app-builder/tools/app-list.ts +62 -0
  147. package/src/config/bundled-skills/document-editor/SKILL.md +28 -23
  148. package/src/config/bundled-skills/document-editor/TOOLS.json +1 -1
  149. package/src/config/bundled-tool-registry.ts +2 -0
  150. package/src/config/feature-flag-registry.json +14 -5
  151. package/src/config/schemas/heartbeat.ts +9 -0
  152. package/src/context/strip-injections.ts +8 -2
  153. package/src/context/window-manager.ts +27 -13
  154. package/src/daemon/conversation-agent-loop-handlers.ts +10 -35
  155. package/src/daemon/conversation-agent-loop.ts +167 -1005
  156. package/src/daemon/conversation-lifecycle.ts +11 -255
  157. package/src/daemon/conversation-process.ts +8 -136
  158. package/src/daemon/conversation-registry.ts +159 -0
  159. package/src/daemon/conversation-runtime-assembly.ts +293 -392
  160. package/src/daemon/conversation-store.ts +9 -90
  161. package/src/daemon/conversation-surfaces.ts +24 -8
  162. package/src/daemon/conversation-workspace.ts +17 -0
  163. package/src/daemon/conversation.ts +383 -56
  164. package/src/daemon/external-plugins-bootstrap.ts +14 -19
  165. package/src/daemon/handlers/conversations.ts +3 -1
  166. package/src/daemon/handlers/skills.ts +4 -1
  167. package/src/daemon/host-proxy-preactivation.ts +1 -3
  168. package/src/daemon/lifecycle.ts +21 -0
  169. package/src/daemon/server.ts +2 -0
  170. package/src/daemon/wake-conversation-ops.ts +269 -0
  171. package/src/embedded/plugin-api.ts +2 -2
  172. package/src/export/__tests__/transcript-formatter.test.ts +5 -0
  173. package/src/heartbeat/__tests__/heartbeat-service.test.ts +3 -0
  174. package/src/heartbeat/heartbeat-run-store.ts +23 -1
  175. package/src/heartbeat/heartbeat-service.ts +26 -0
  176. package/src/ipc/__tests__/browser-ipc.test.ts +1 -1
  177. package/src/ipc/__tests__/ui-request-route.test.ts +3 -3
  178. package/src/ipc/skill-routes/__tests__/memory.test.ts +15 -0
  179. package/src/ipc/skill-routes/memory.ts +4 -2
  180. package/src/memory/__tests__/jobs-worker-v2-schedule.test.ts +87 -0
  181. package/src/memory/conversation-crud.ts +29 -19
  182. package/src/memory/conversation-starter-checkpoints.ts +1 -0
  183. package/src/memory/db-init.ts +2 -0
  184. package/src/memory/job-handlers/conversation-starters.ts +13 -2
  185. package/src/memory/jobs/__tests__/embed-concept-page.test.ts +5 -4
  186. package/src/memory/jobs-worker.ts +25 -1
  187. package/src/memory/migrations/272-acp-session-history-cwd.ts +36 -0
  188. package/src/memory/migrations/index.ts +1 -0
  189. package/src/memory/schema/acp.ts +4 -0
  190. package/src/memory/v2/__tests__/consolidation-job.test.ts +3 -3
  191. package/src/memory/v2/consolidation-job.ts +13 -4
  192. package/src/plugin-api/constants.ts +4 -0
  193. package/src/plugin-api/index.ts +6 -5
  194. package/src/plugin-api/types.ts +75 -0
  195. package/src/plugins/defaults/compaction/compact.ts +59 -0
  196. package/src/plugins/defaults/compaction/manager-store.ts +44 -0
  197. package/src/plugins/defaults/compaction/package.json +1 -2
  198. package/src/plugins/defaults/empty-response/package.json +0 -1
  199. package/src/plugins/defaults/history-repair/package.json +0 -1
  200. package/src/plugins/defaults/index.ts +135 -26
  201. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +103 -38
  202. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit-temp.ts +167 -56
  203. package/src/plugins/defaults/memory-retrieval/injector-chain.ts +2 -2
  204. package/src/plugins/defaults/{injectors/register.ts → memory-retrieval/injectors.ts} +148 -73
  205. package/src/plugins/defaults/memory-retrieval/unified-turn-context.ts +223 -0
  206. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/assign.test.ts +4 -4
  207. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/live-integration.test.ts +9 -6
  208. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/maintain-job.test.ts +5 -5
  209. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/orchestrate.test.ts +8 -5
  210. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/reconcile.test.ts +2 -2
  211. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/render-injection.test.ts +1 -1
  212. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/router.test.ts +10 -5
  213. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/selection-log-store.test.ts +8 -8
  214. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/selector.test.ts +5 -5
  215. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/shadow-plugin.test.ts +16 -17
  216. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/types.test.ts +2 -2
  217. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/assign.ts +9 -5
  218. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/capabilities.ts +5 -2
  219. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +14 -0
  220. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +19 -0
  221. package/src/plugins/defaults/memory-v3-shadow/injector.ts +75 -0
  222. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/maintain-job.ts +15 -8
  223. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/orchestrate.ts +2 -2
  224. package/src/plugins/defaults/memory-v3-shadow/package.json +14 -0
  225. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/page-content.ts +2 -2
  226. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/provider-blocks.ts +1 -1
  227. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/reconcile.ts +7 -3
  228. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/render-injection.ts +1 -1
  229. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/router.ts +5 -5
  230. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/selection-log-store.ts +4 -4
  231. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/selector.ts +7 -7
  232. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/shadow-plugin.ts +32 -94
  233. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/tree.ts +1 -1
  234. package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/types.ts +1 -1
  235. package/src/plugins/defaults/title-generate/package.json +0 -1
  236. package/src/plugins/defaults/tool-error/package.json +0 -1
  237. package/src/plugins/defaults/tool-result-truncate/package.json +0 -1
  238. package/src/plugins/pipeline.ts +6 -293
  239. package/src/plugins/registry.ts +9 -37
  240. package/src/plugins/types.ts +76 -381
  241. package/src/plugins/user-loader.ts +30 -127
  242. package/src/proactive-artifact/aux-message-injector.ts +1 -1
  243. package/src/proactive-artifact/job.test.ts +1 -1
  244. package/src/prompts/__tests__/system-prompt.test.ts +6 -0
  245. package/src/prompts/templates/BOOTSTRAP-ACTIVATION-RAIL.md +35 -3
  246. package/src/runtime/__tests__/agent-wake.test.ts +555 -691
  247. package/src/runtime/__tests__/interactive-ui.test.ts +1 -1
  248. package/src/runtime/agent-wake.ts +108 -209
  249. package/src/runtime/assistant-event-hub.ts +1 -1
  250. package/src/runtime/channel-approvals.ts +1 -1
  251. package/src/runtime/interactive-ui.ts +1 -1
  252. package/src/runtime/routes/__tests__/acp-routes.test.ts +283 -55
  253. package/src/runtime/routes/__tests__/conversation-list-routes.test.ts +1 -1
  254. package/src/runtime/routes/__tests__/plugins-routes.test.ts +398 -73
  255. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +5 -4
  256. package/src/runtime/routes/__tests__/surface-content-routes.test.ts +4 -1
  257. package/src/runtime/routes/acp-routes.test.ts +89 -25
  258. package/src/runtime/routes/acp-routes.ts +81 -29
  259. package/src/runtime/routes/approval-routes.ts +1 -1
  260. package/src/runtime/routes/browser-routes.ts +1 -1
  261. package/src/runtime/routes/browser-tabs-routes.ts +6 -10
  262. package/src/runtime/routes/conversation-cli-routes.ts +1 -1
  263. package/src/runtime/routes/conversation-list-routes.ts +1 -1
  264. package/src/runtime/routes/conversation-query-routes.ts +1 -1
  265. package/src/runtime/routes/conversation-routes.ts +28 -2
  266. package/src/runtime/routes/conversation-starter-routes.ts +13 -7
  267. package/src/runtime/routes/conversations-import-routes.ts +24 -7
  268. package/src/runtime/routes/host-app-control-routes.ts +1 -1
  269. package/src/runtime/routes/host-cu-routes.ts +1 -1
  270. package/src/runtime/routes/identity-routes.ts +18 -3
  271. package/src/runtime/routes/inbound-message-handler.ts +1 -1
  272. package/src/runtime/routes/inference-profile-session-handler.ts +11 -0
  273. package/src/runtime/routes/inference-profile-session-reaper.ts +6 -0
  274. package/src/runtime/routes/memory-v3-routes.ts +16 -6
  275. package/src/runtime/routes/playground/helpers.ts +1 -1
  276. package/src/runtime/routes/plugins-routes.ts +336 -35
  277. package/src/runtime/routes/surface-conversation-resolver.ts +4 -3
  278. package/src/runtime/routes/work-items-routes.ts +2 -4
  279. package/src/runtime/services/conversation-serializer.ts +1 -1
  280. package/src/signals/cancel.ts +2 -4
  281. package/src/subagent/manager.ts +21 -5
  282. package/src/tools/acp/context.ts +20 -0
  283. package/src/tools/acp/list-agents.test.ts +7 -1
  284. package/src/tools/acp/spawn.test.ts +158 -55
  285. package/src/tools/acp/spawn.ts +47 -72
  286. package/src/tools/acp/steer.test.ts +105 -8
  287. package/src/tools/acp/steer.ts +48 -17
  288. package/src/tools/apps/executors.ts +13 -8
  289. package/src/tools/filesystem/write.ts +34 -0
  290. package/src/tools/subagent/spawn.ts +2 -4
  291. package/src/tools/ui-surface/definitions.ts +25 -5
  292. package/src/workspace/migrations/051-seed-conversation-summarization-callsite.ts +4 -5
  293. package/src/workspace/migrations/097-enable-adaptive-thinking-managed-profiles.ts +69 -45
  294. package/docs/plugins.md +0 -832
  295. package/examples/plugins/echo/register.ts +0 -143
  296. package/src/__tests__/circuit-breaker-pipeline.test.ts +0 -405
  297. package/src/__tests__/compaction-pipeline.test.ts +0 -210
  298. package/src/__tests__/compaction-timeout-recovery.test.ts +0 -251
  299. package/src/__tests__/overflow-reduce-pipeline.test.ts +0 -667
  300. package/src/__tests__/pipeline-runner.test.ts +0 -554
  301. package/src/__tests__/plugin-external-api.test.ts +0 -68
  302. package/src/daemon/wake-target-adapter.ts +0 -253
  303. package/src/plugins/defaults/circuit-breaker/middlewares/circuitBreaker.ts +0 -93
  304. package/src/plugins/defaults/circuit-breaker/package.json +0 -15
  305. package/src/plugins/defaults/circuit-breaker/register.ts +0 -39
  306. package/src/plugins/defaults/compaction/middlewares/compaction.ts +0 -25
  307. package/src/plugins/defaults/compaction/register.ts +0 -35
  308. package/src/plugins/defaults/compaction/terminal.ts +0 -73
  309. package/src/plugins/defaults/empty-response/register.ts +0 -23
  310. package/src/plugins/defaults/history-repair/register.ts +0 -24
  311. package/src/plugins/defaults/overflow-reduce/middlewares/overflowReduce.ts +0 -126
  312. package/src/plugins/defaults/overflow-reduce/package.json +0 -15
  313. package/src/plugins/defaults/overflow-reduce/register.ts +0 -42
  314. package/src/plugins/defaults/title-generate/register.ts +0 -35
  315. package/src/plugins/defaults/tool-error/register.ts +0 -23
  316. package/src/plugins/defaults/tool-result-truncate/register.ts +0 -24
  317. package/src/plugins/external-api.ts +0 -104
  318. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/capabilities.test.ts +0 -0
  319. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/core.test.ts +0 -0
  320. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/fixtures/eval-turns.json +0 -0
  321. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/fixtures/live-turns.json +0 -0
  322. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/health.test.ts +0 -0
  323. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/needle.test.ts +0 -0
  324. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/provider-blocks.test.ts +0 -0
  325. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/snapshot.test.ts +0 -0
  326. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/tree.test.ts +0 -0
  327. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/working-set-eviction.test.ts +0 -0
  328. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/__tests__/working-set-skeleton.test.ts +0 -0
  329. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/core.ts +0 -0
  330. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/README.md +0 -0
  331. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/assignments.json +0 -0
  332. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/core.json +0 -0
  333. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-a/topic-x.md +0 -0
  334. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-a/topic-y.md +0 -0
  335. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/data/leaves/domain-b/topic-z.md +0 -0
  336. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/health.ts +0 -0
  337. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/llm-retry.ts +0 -0
  338. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/needle.ts +0 -0
  339. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/snapshot.ts +0 -0
  340. /package/src/{memory/v3 → plugins/defaults/memory-v3-shadow}/working-set.ts +0 -0
@@ -7,6 +7,7 @@ interface SteerCall {
7
7
  instruction: string;
8
8
  }
9
9
 
10
+ // Direct steer (no connected client -> no resume fallback).
10
11
  const steerCalls: SteerCall[] = [];
11
12
  const defaultSteer = (acpSessionId: string, instruction: string) => {
12
13
  steerCalls.push({ acpSessionId, instruction });
@@ -15,6 +16,13 @@ const defaultSteer = (acpSessionId: string, instruction: string) => {
15
16
  let steerImpl: (acpSessionId: string, instruction: string) => Promise<void> =
16
17
  defaultSteer;
17
18
 
19
+ // steerOrResume (connected client path).
20
+ const steerOrResumeCalls: Array<SteerCall & { send: unknown }> = [];
21
+ let steerOrResumeImpl: (
22
+ acpSessionId: string,
23
+ instruction: string,
24
+ ) => Promise<{ resumed: boolean }> = async () => ({ resumed: false });
25
+
18
26
  // Spread the real module's exports so transitive importers that pull other
19
27
  // names from `../../acp/index.js` still resolve at parse time. Bun's `mock.module` is
20
28
  // process-global and returns *exactly* the keys the factory returns.
@@ -24,35 +32,50 @@ mock.module("../../acp/index.js", () => ({
24
32
  getAcpSessionManager: () => ({
25
33
  steer: (acpSessionId: string, instruction: string) =>
26
34
  steerImpl(acpSessionId, instruction),
35
+ steerOrResume: (
36
+ acpSessionId: string,
37
+ instruction: string,
38
+ send: unknown,
39
+ ) => {
40
+ steerOrResumeCalls.push({ acpSessionId, instruction, send });
41
+ return steerOrResumeImpl(acpSessionId, instruction);
42
+ },
27
43
  }),
28
44
  }));
29
45
 
30
46
  const { executeAcpSteer } = await import("./steer.js");
31
47
 
32
- function makeContext(): ToolContext {
48
+ function makeContext(opts?: { withClient?: boolean }): ToolContext {
33
49
  return {
34
50
  workingDir: "/tmp",
35
51
  conversationId: "conv-test",
36
52
  trustClass: "guardian",
37
- };
53
+ ...(opts?.withClient ? { sendToClient: () => {} } : {}),
54
+ } as ToolContext;
38
55
  }
39
56
 
40
57
  beforeEach(() => {
41
58
  steerCalls.length = 0;
59
+ steerOrResumeCalls.length = 0;
42
60
  steerImpl = defaultSteer;
61
+ steerOrResumeImpl = async () => ({ resumed: false });
43
62
  });
44
63
 
45
64
  describe("executeAcpSteer", () => {
46
- test("happy path: returns steered status and forwards args to manager", async () => {
65
+ test("happy path: returns steered status and forwards args to steerOrResume", async () => {
47
66
  const result = await executeAcpSteer(
48
67
  { acp_session_id: "acp-123", instruction: "stop, do X instead" },
49
- makeContext(),
68
+ makeContext({ withClient: true }),
50
69
  );
51
70
 
52
71
  expect(result.isError).toBe(false);
53
- expect(steerCalls).toEqual([
54
- { acpSessionId: "acp-123", instruction: "stop, do X instead" },
55
- ]);
72
+ expect(steerOrResumeCalls).toHaveLength(1);
73
+ expect(steerOrResumeCalls[0]).toMatchObject({
74
+ acpSessionId: "acp-123",
75
+ instruction: "stop, do X instead",
76
+ });
77
+ expect(typeof steerOrResumeCalls[0]!.send).toBe("function");
78
+ expect(steerCalls).toEqual([]);
56
79
 
57
80
  const parsed = JSON.parse(result.content as string);
58
81
  expect(parsed).toEqual({
@@ -71,6 +94,7 @@ describe("executeAcpSteer", () => {
71
94
  expect(result.isError).toBe(true);
72
95
  expect(result.content).toContain('"instruction" is required');
73
96
  expect(steerCalls).toEqual([]);
97
+ expect(steerOrResumeCalls).toEqual([]);
74
98
  });
75
99
 
76
100
  test("missing acp_session_id returns isError", async () => {
@@ -82,9 +106,23 @@ describe("executeAcpSteer", () => {
82
106
  expect(result.isError).toBe(true);
83
107
  expect(result.content).toContain('"acp_session_id" is required');
84
108
  expect(steerCalls).toEqual([]);
109
+ expect(steerOrResumeCalls).toEqual([]);
110
+ });
111
+
112
+ test("no connected client: steers directly and never resumes", async () => {
113
+ const result = await executeAcpSteer(
114
+ { acp_session_id: "acp-direct", instruction: "redirect" },
115
+ makeContext(),
116
+ );
117
+
118
+ expect(result.isError).toBe(false);
119
+ expect(steerCalls).toEqual([
120
+ { acpSessionId: "acp-direct", instruction: "redirect" },
121
+ ]);
122
+ expect(steerOrResumeCalls).toEqual([]);
85
123
  });
86
124
 
87
- test("manager.steer throwing 'session not found' surfaces the error", async () => {
125
+ test("'session not found' without a connected client surfaces the error", async () => {
88
126
  steerImpl = () =>
89
127
  Promise.reject(new Error('ACP session "acp-x" not found'));
90
128
 
@@ -96,5 +134,64 @@ describe("executeAcpSteer", () => {
96
134
  expect(result.isError).toBe(true);
97
135
  expect(result.content).toContain('Could not steer ACP session "acp-x"');
98
136
  expect(result.content).toContain("not found");
137
+ expect(steerOrResumeCalls).toEqual([]);
138
+ });
139
+
140
+ test("resumed session reports the resumed flag and message", async () => {
141
+ steerOrResumeImpl = async () => ({ resumed: true });
142
+
143
+ const result = await executeAcpSteer(
144
+ { acp_session_id: "acp-gone", instruction: "keep going" },
145
+ makeContext({ withClient: true }),
146
+ );
147
+
148
+ expect(result.isError).toBe(false);
149
+ expect(steerOrResumeCalls).toHaveLength(1);
150
+
151
+ const parsed = JSON.parse(result.content as string);
152
+ expect(parsed).toEqual({
153
+ acpSessionId: "acp-gone",
154
+ status: "steered",
155
+ resumed: true,
156
+ message:
157
+ "Session was resumed from history; new instruction is now running.",
158
+ });
159
+ });
160
+
161
+ test("resume failure returns its actionable error message", async () => {
162
+ steerOrResumeImpl = () =>
163
+ Promise.reject(
164
+ new Error(
165
+ 'ACP session "acp-legacy" was recorded before resume support (no working directory persisted) and cannot be resumed. Spawn a new session instead.',
166
+ ),
167
+ );
168
+
169
+ const result = await executeAcpSteer(
170
+ { acp_session_id: "acp-legacy", instruction: "more work" },
171
+ makeContext({ withClient: true }),
172
+ );
173
+
174
+ expect(result.isError).toBe(true);
175
+ expect(result.content).toContain(
176
+ 'Could not steer ACP session "acp-legacy"',
177
+ );
178
+ expect(result.content).toContain("recorded before resume support");
179
+ });
180
+
181
+ test("plain steer errors surface unchanged", async () => {
182
+ steerOrResumeImpl = () =>
183
+ Promise.reject(
184
+ new Error(
185
+ 'ACP session "acp-init" is not running (status: initializing)',
186
+ ),
187
+ );
188
+
189
+ const result = await executeAcpSteer(
190
+ { acp_session_id: "acp-init", instruction: "redirect" },
191
+ makeContext({ withClient: true }),
192
+ );
193
+
194
+ expect(result.isError).toBe(true);
195
+ expect(result.content).toContain("is not running");
99
196
  });
100
197
  });
@@ -1,9 +1,10 @@
1
1
  import { getAcpSessionManager } from "../../acp/index.js";
2
2
  import type { ToolContext, ToolExecutionResult } from "../types.js";
3
+ import { getSendToClient } from "./context.js";
3
4
 
4
5
  export async function executeAcpSteer(
5
6
  input: Record<string, unknown>,
6
- _context: ToolContext,
7
+ context: ToolContext,
7
8
  ): Promise<ToolExecutionResult> {
8
9
  const acpSessionId = input.acp_session_id as string;
9
10
  if (!acpSessionId) {
@@ -15,24 +16,54 @@ export async function executeAcpSteer(
15
16
  return { content: '"instruction" is required.', isError: true };
16
17
  }
17
18
 
18
- try {
19
- const manager = getAcpSessionManager();
20
- await manager.steer(acpSessionId, instruction);
19
+ const manager = getAcpSessionManager();
20
+ const sendToClient = getSendToClient(context);
21
21
 
22
- return {
23
- content: JSON.stringify({
24
- acpSessionId,
25
- status: "steered",
26
- message:
27
- "Interrupted in-flight prompt; new instruction is now running.",
28
- }),
29
- isError: false,
30
- };
22
+ try {
23
+ if (!sendToClient) {
24
+ // Without a connected client there is no one to receive a resumed
25
+ // session's events, so skip the transparent resume fallback and
26
+ // steer the in-memory session only.
27
+ await manager.steer(acpSessionId, instruction);
28
+ return steeredResult(acpSessionId, { resumed: false });
29
+ }
30
+ // Sessions no longer in memory (completed, or lost to a daemon
31
+ // restart) are transparently resumed from persisted history and the
32
+ // instruction fired in the same call. Failure messages carry the
33
+ // actionable hint (e.g. "recorded before resume support", agent
34
+ // capability missing).
35
+ const { resumed } = await manager.steerOrResume(
36
+ acpSessionId,
37
+ instruction,
38
+ sendToClient,
39
+ );
40
+ return steeredResult(acpSessionId, { resumed });
31
41
  } catch (err) {
32
42
  const msg = err instanceof Error ? err.message : String(err);
33
- return {
34
- content: `Could not steer ACP session "${acpSessionId}": ${msg}`,
35
- isError: true,
36
- };
43
+ return steerError(acpSessionId, msg);
37
44
  }
38
45
  }
46
+
47
+ function steeredResult(
48
+ acpSessionId: string,
49
+ opts: { resumed: boolean },
50
+ ): ToolExecutionResult {
51
+ return {
52
+ content: JSON.stringify({
53
+ acpSessionId,
54
+ status: "steered",
55
+ ...(opts.resumed ? { resumed: true } : {}),
56
+ message: opts.resumed
57
+ ? "Session was resumed from history; new instruction is now running."
58
+ : "Interrupted in-flight prompt; new instruction is now running.",
59
+ }),
60
+ isError: false,
61
+ };
62
+ }
63
+
64
+ function steerError(acpSessionId: string, msg: string): ToolExecutionResult {
65
+ return {
66
+ content: `Could not steer ACP session "${acpSessionId}": ${msg}`,
67
+ isError: true,
68
+ };
69
+ }
@@ -76,14 +76,12 @@ export interface AppCreateInput {
76
76
  name: string;
77
77
  description?: string;
78
78
  schema_json?: string;
79
- /**
80
- * Retired single-file shortcut. Kept in the type so legacy or stale callers
81
- * get a clear tool error instead of silently creating a v2 app with stale
82
- * scaffold content.
83
- */
79
+ /** Retired single-file shortcut. Returns a guidance error. */
84
80
  html?: unknown;
85
- /** Retired single-file multi-page shortcut. */
81
+ /** Retired single-file multi-page shortcut. Returns a guidance error. */
86
82
  pages?: unknown;
83
+ /** Lenient alias. Folded into preview.icon when preview.icon is absent. */
84
+ icon?: unknown;
87
85
  auto_open?: boolean;
88
86
  preview?: Record<string, unknown>;
89
87
  source_files?: Record<string, string>;
@@ -98,11 +96,14 @@ export async function executeAppCreate(
98
96
  const description = input.description;
99
97
  const schemaJson = input.schema_json ?? "{}";
100
98
 
99
+ // Retired shortcut: a top-level `html` is no longer accepted. Reject with a
100
+ // helpful message (rather than a cryptic schema error) so the model writes a
101
+ // multi-file TSX app under src/ instead.
101
102
  if (Object.prototype.hasOwnProperty.call(input, "html")) {
102
103
  return {
103
104
  content: JSON.stringify({
104
105
  error:
105
- "app_create no longer accepts html. Create the app scaffold, write src/index.html and src/main.tsx with file_write, then call app_refresh.",
106
+ "app_create no longer accepts html. Build a multi-file TSX app under src/ (src/index.html + src/main.tsx + src/App.tsx) instead.",
106
107
  }),
107
108
  isError: true,
108
109
  };
@@ -157,7 +158,11 @@ export async function executeAppCreate(
157
158
 
158
159
  // Extract icon from preview if provided - only persist emoji-like values,
159
160
  // not URLs which would render as raw strings in UI and bundle manifests.
160
- const rawIcon = preview?.icon as string | undefined;
161
+ // Lenient alias: a top-level `icon` is folded in when preview.icon is absent.
162
+ const rawIcon = (preview?.icon ??
163
+ (typeof input.icon === "string" ? input.icon : undefined)) as
164
+ | string
165
+ | undefined;
161
166
  const icon = rawIcon && !rawIcon.startsWith("http") ? rawIcon : undefined;
162
167
 
163
168
  const app = store.createApp({
@@ -1,5 +1,6 @@
1
1
  import { join, resolve, sep } from "node:path";
2
2
 
3
+ import { getAppsDir } from "../../memory/app-store.js";
3
4
  import { enqueuePkbIndexJob } from "../../memory/jobs/embed-pkb-file.js";
4
5
  import { PKB_WORKSPACE_SCOPE } from "../../memory/pkb/types.js";
5
6
  import { RiskLevel } from "../../permissions/types.js";
@@ -17,6 +18,29 @@ import type {
17
18
 
18
19
  const logger = getLogger("file-write");
19
20
 
21
+ /**
22
+ * Detects an attempt to write a self-contained interactive HTML document —
23
+ * the signature of a "visualization" / "artifact" the model should be
24
+ * building as a real app via the app-builder skill, not dumping as a loose
25
+ * file. We deliberately trip ONLY on standalone docs with a substantial
26
+ * INLINE script (the data + rendering live in the file). app-builder's own
27
+ * scaffold writes a thin shell whose only script is an external module
28
+ * (`<script type="module" src="/src/main.tsx">`) with an empty body, so this
29
+ * never blocks the app-builder workflow it redirects to.
30
+ */
31
+ const STANDALONE_HTML_RE = /<!doctype\s+html|<html[\s>]/i;
32
+ const INLINE_SCRIPT_RE = /<script\b(?![^>]*\bsrc=)[^>]*>[\s\S]{400,}?<\/script>/i;
33
+
34
+ function isSelfContainedArtifactHtml(path: string, content: string): boolean {
35
+ if (!/\.html?$/i.test(path)) return false;
36
+ if (content.length < 3000) return false;
37
+ if (!STANDALONE_HTML_RE.test(content)) return false;
38
+ return INLINE_SCRIPT_RE.test(content);
39
+ }
40
+
41
+ const ARTIFACT_REDIRECT_MESSAGE =
42
+ 'Error: This looks like a self-contained interactive visualization/artifact written as a loose HTML file. Do not build these as standalone .html files. Load the app-builder skill first with `skill_load` using `skill: "app-builder"`, then build it as a real persistent app with `app_create` (the skill loads frontend-design for the visual pass and provides chart widgets). If this genuinely needs to be a raw HTML file inside an existing code project, write it under that project folder.';
43
+
20
44
  /**
21
45
  * Returns `true` iff `absPath` is an absolute path that resolves strictly
22
46
  * inside `pkbRoot`. Matches the containment semantics used elsewhere in the
@@ -82,6 +106,16 @@ export const fileWriteTool = {
82
106
  };
83
107
  }
84
108
 
109
+ // Redirect self-contained interactive HTML artifacts to app-builder.
110
+ // Exempt writes that land inside the apps directory (app-builder's own
111
+ // scaffold/iteration writes) so we never block the workflow we point to.
112
+ if (isSelfContainedArtifactHtml(rawPath, fileContent)) {
113
+ const candidate = resolve(context.workingDir, rawPath);
114
+ if (!isInsidePkbRoot(candidate, getAppsDir())) {
115
+ return { content: ARTIFACT_REDIRECT_MESSAGE, isError: true };
116
+ }
117
+ }
118
+
85
119
  const ops = new FileSystemOps((path, opts) =>
86
120
  sandboxPolicy(path, context.workingDir, opts),
87
121
  );
@@ -1,4 +1,4 @@
1
- import { findConversation } from "../../daemon/conversation-store.js";
1
+ import { findConversation } from "../../daemon/conversation-registry.js";
2
2
  import { getConversationOverrideProfile } from "../../memory/conversation-crud.js";
3
3
  import type { Message } from "../../providers/types.js";
4
4
  import { getSubagentManager } from "../../subagent/index.js";
@@ -102,9 +102,7 @@ export async function executeSubagentSpawn(
102
102
  ...(inheritedOverrideProfile
103
103
  ? { overrideProfile: inheritedOverrideProfile }
104
104
  : {}),
105
- ...(context.toolUseId
106
- ? { parentToolUseId: context.toolUseId }
107
- : {}),
105
+ ...(context.toolUseId ? { parentToolUseId: context.toolUseId } : {}),
108
106
  ...forkFields,
109
107
  },
110
108
  sendToClient as (msg: unknown) => void,
@@ -19,7 +19,7 @@ import type {
19
19
  // ---------------------------------------------------------------------------
20
20
 
21
21
  const APP_BUILDER_ARTIFACT_RE =
22
- /\b(app|apps|application|applications|website|websites|site|sites|dashboard|dashboards|game|games|calculator|calculators|tracker|trackers|visualization|visualizations|visualisation|visualisations|tool|tools|utility|utilities|counter|counters)\b/i;
22
+ /\b(app|apps|application|applications|website|websites|site|sites|dashboard|dashboards|game|games|calculator|calculators|tracker|trackers|visualization|visualizations|visualisation|visualisations|visualize|visualise|artifact|artifacts|chart|charts|graph|graphs|tool|tools|utility|utilities|counter|counters)\b/i;
23
23
  const APP_BUILDER_BUILD_RE =
24
24
  /\b(build|building|built|create|creating|created|make|making|made|generate|generating|generated)\b/i;
25
25
 
@@ -58,11 +58,31 @@ function isDynamicPageAppSubstitute(input: Record<string, unknown>): boolean {
58
58
  }
59
59
 
60
60
  const text = collectRoutingText(input).join(" ");
61
- if (!APP_BUILDER_ARTIFACT_RE.test(text)) {
62
- return false;
61
+ if (
62
+ APP_BUILDER_ARTIFACT_RE.test(text) &&
63
+ (APP_BUILDER_BUILD_RE.test(text) || /\b(app|application)\b/i.test(text))
64
+ ) {
65
+ return true;
63
66
  }
64
67
 
65
- return APP_BUILDER_BUILD_RE.test(text) || /\b(app|application)\b/i.test(text);
68
+ // Second signal: even when the model gives the surface a clean,
69
+ // non-app-sounding title (dodging the text regex above), substantial
70
+ // interactive HTML is an app being smuggled in as a transient surface.
71
+ // A genuinely transient page is small and static; an app has real
72
+ // scripted markup. Keep the bar high so simple snippets still pass.
73
+ return isSubstantialInteractiveHtml(input);
74
+ }
75
+
76
+ const INTERACTIVE_HTML_RE =
77
+ /<script\b|on[a-z]+\s*=|addEventListener|new Chart\b|window\.vellum\b/i;
78
+
79
+ function isSubstantialInteractiveHtml(input: Record<string, unknown>): boolean {
80
+ const data = asRecord(input.data);
81
+ const html = data?.html;
82
+ if (typeof html !== "string") {
83
+ return false;
84
+ }
85
+ return html.length > 2000 && INTERACTIVE_HTML_RE.test(html);
66
86
  }
67
87
 
68
88
  function collectRoutingText(input: Record<string, unknown>): string[] {
@@ -116,7 +136,7 @@ export const uiShowTool = {
116
136
  "- file_upload: { prompt, acceptedTypes?, maxFiles? }\n" +
117
137
  "- task_preferences: {} (no data needed — categories are rendered client-side)\n" +
118
138
  '- work_result: { eyebrow?, status?: "completed"|"partial"|"failed"|"in_progress", summary?, metrics?: [{ label, value, detail?, tone?: "neutral"|"positive"|"warning"|"negative" }], sections?: [{ id?, title, description?, type?: "items"|"timeline"|"diff"|"artifacts"|"warnings", items?: [{ id?, title, description?, status?, tone?, metadata?: [{ label, value }], href? }], diffs?: [{ label?, before?, after? }] }] }. Shows a structured receipt after real work: what changed, what was skipped, proof points, and next actions. Keep display-only unless explicit follow-up buttons are needed.\n\n' +
119
- "Proactively show a task_progress card before multi-step or long-running work (web searches, file operations, research). Show it before your first tool call, then update steps as work progresses.",
139
+ "Emit a task_progress card BEFORE your first tool call on any multi-step, long-running, or post-form turn (web searches, file operations, research), and keep its steps updated as work progresses. Skills that estimate >30s of work should declare progress upfront with concrete step labels (and counts when known).",
120
140
  category: "ui-surface",
121
141
  defaultRiskLevel: RiskLevel.Low,
122
142
  executionTarget: "host",
@@ -9,10 +9,9 @@ import type { WorkspaceMigration } from "./types.js";
9
9
  * `conversationSummarization` is invoked from `ContextWindowManager.
10
10
  * updateSummary()` during mid-loop compaction. Without a call-site entry it
11
11
  * falls through to `llm.default` (opus + `effort: "max"` + `thinking:
12
- * { enabled: true }` + `maxTokens: 64000`), which is far too expensive for
13
- * summarizing a ~150k-token transcript inside the agent-loop plugin
14
- * pipeline's 30s budget — we were hitting `PluginTimeoutError` and hard-
15
- * failing the turn.
12
+ * { enabled: true }` + `maxTokens: 64000`), which is far too expensive and
13
+ * slow for summarizing a ~150k-token transcript inside the agent loop —
14
+ * the summary call would stall the turn.
16
15
  *
17
16
  * This migration seeds `effort: "low"` and `thinking: { enabled: false }`
18
17
  * (and opus-4.7 as the model when absent) so the summary call runs cheaply
@@ -99,7 +98,7 @@ export const seedConversationSummarizationCallsiteMigration: WorkspaceMigration
99
98
  },
100
99
  down(_workspaceDir: string): void {
101
100
  // Forward-only: removing the seeded defaults would reintroduce the
102
- // 30s pipeline-budget timeout this migration fixes.
101
+ // expensive, slow summary call this migration fixes.
103
102
  },
104
103
  };
105
104
 
@@ -20,65 +20,89 @@ import type { WorkspaceMigration } from "./types.js";
20
20
  // explicitly disabled. It skips profiles that:
21
21
  // - Don't exist (no profile to patch)
22
22
  // - Already have thinking enabled (idempotent)
23
- // - Are not source: "managed" (user-created profiles are untouched)
23
+ // - Are source: "user" (user-created profiles are untouched)
24
+ // - Have a non-managed, non-absent source (unknown origin)
24
25
  // - Use a non-Anthropic provider (adaptive thinking is Anthropic-specific)
25
26
 
26
27
  const ADAPTIVE_THINKING = { enabled: true, streamThinking: true } as const;
27
28
  const TARGET_PROFILES = ["balanced", "quality-optimized"] as const;
28
29
 
29
- export const enableAdaptiveThinkingManagedProfilesMigration: WorkspaceMigration =
30
- {
31
- id: "097-enable-adaptive-thinking-managed-profiles",
32
- description:
33
- "Enable adaptive thinking on managed balanced and quality-optimized profiles",
34
- run(workspaceDir: string): void {
35
- const configPath = join(workspaceDir, "config.json");
36
- if (!existsSync(configPath)) return;
30
+ /**
31
+ * Patch managed Anthropic profiles that are missing adaptive thinking.
32
+ *
33
+ * Exported so lifecycle.ts can re-run the repair after mergeDefaultWorkspaceConfig()
34
+ * and seedInferenceProfiles(). On-platform instances with a config overlay have their
35
+ * profiles overwritten by the overlay merge (which runs after workspace migrations),
36
+ * so the migration alone is insufficient — the post-overlay call ensures the repair
37
+ * sticks even when the overlay supplies profiles without thinking enabled.
38
+ *
39
+ * The function is idempotent: profiles that already have thinking enabled are skipped.
40
+ */
41
+ export function repairAdaptiveThinkingOnManagedProfiles(
42
+ workspaceDir: string,
43
+ ): void {
44
+ const configPath = join(workspaceDir, "config.json");
45
+ if (!existsSync(configPath)) return;
37
46
 
38
- let config: Record<string, unknown>;
39
- try {
40
- const raw = JSON.parse(readFileSync(configPath, "utf-8"));
41
- if (!raw || typeof raw !== "object" || Array.isArray(raw)) return;
42
- config = raw as Record<string, unknown>;
43
- } catch {
44
- return;
45
- }
47
+ let config: Record<string, unknown>;
48
+ try {
49
+ const raw = JSON.parse(readFileSync(configPath, "utf-8"));
50
+ if (!raw || typeof raw !== "object" || Array.isArray(raw)) return;
51
+ config = raw as Record<string, unknown>;
52
+ } catch {
53
+ return;
54
+ }
46
55
 
47
- const llm = readObject(config.llm);
48
- if (llm === null) return;
56
+ const llm = readObject(config.llm);
57
+ if (llm === null) return;
49
58
 
50
- const profiles = readObject(llm.profiles);
51
- if (profiles === null) return;
59
+ const profiles = readObject(llm.profiles);
60
+ if (profiles === null) return;
52
61
 
53
- let changed = false;
62
+ let changed = false;
54
63
 
55
- for (const name of TARGET_PROFILES) {
56
- const profile = readObject(profiles[name]);
57
- if (profile === null) continue;
64
+ for (const name of TARGET_PROFILES) {
65
+ const profile = readObject(profiles[name]);
66
+ if (profile === null) continue;
58
67
 
59
- // Only patch managed Anthropic profiles.
60
- if (profile.source !== "managed") continue;
61
- if (
62
- typeof profile.provider === "string" &&
63
- profile.provider !== "anthropic"
64
- ) {
65
- continue;
66
- }
68
+ // Only patch managed Anthropic profiles.
69
+ // Legacy profiles created before the `source` metadata field was introduced
70
+ // have source=undefined. Treat these as managed when the profile name is one
71
+ // of the canonical managed names (which TARGET_PROFILES already guarantees)
72
+ // and the provider is Anthropic (or absent). Explicit `source: "user"`
73
+ // profiles are always skipped.
74
+ if (profile.source === "user") continue;
75
+ if (profile.source !== undefined && profile.source !== "managed") continue;
76
+ if (
77
+ typeof profile.provider === "string" &&
78
+ profile.provider !== "anthropic"
79
+ ) {
80
+ continue;
81
+ }
67
82
 
68
- // Skip if thinking is already enabled.
69
- const thinking = readObject(profile.thinking);
70
- if (thinking !== null && thinking.enabled === true) continue;
83
+ // Skip if thinking is already enabled.
84
+ const thinking = readObject(profile.thinking);
85
+ if (thinking !== null && thinking.enabled === true) continue;
71
86
 
72
- profile.thinking = { ...ADAPTIVE_THINKING };
73
- profiles[name] = profile;
74
- changed = true;
75
- }
87
+ profile.thinking = { ...ADAPTIVE_THINKING };
88
+ profiles[name] = profile;
89
+ changed = true;
90
+ }
76
91
 
77
- if (changed) {
78
- llm.profiles = profiles;
79
- config.llm = llm;
80
- writeFileSync(configPath, JSON.stringify(config, null, 2) + "\n");
81
- }
92
+ if (changed) {
93
+ llm.profiles = profiles;
94
+ config.llm = llm;
95
+ writeFileSync(configPath, JSON.stringify(config, null, 2) + "\n");
96
+ }
97
+ }
98
+
99
+ export const enableAdaptiveThinkingManagedProfilesMigration: WorkspaceMigration =
100
+ {
101
+ id: "097-enable-adaptive-thinking-managed-profiles",
102
+ description:
103
+ "Enable adaptive thinking on managed balanced and quality-optimized profiles",
104
+ run(workspaceDir: string): void {
105
+ repairAdaptiveThinkingOnManagedProfiles(workspaceDir);
82
106
  },
83
107
  down(_workspaceDir: string): void {
84
108
  // Forward-only.