@vellumai/assistant 0.8.8 → 0.8.9-dev.202606091926.ebb2d62

package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts

@@ -22,7 +22,6 @@ import type { Message } from "../providers/types.js";
 
 mock.module("../memory/conversation-crud.js", () => ({
   getConversationOverrideProfile: () => undefined,
-  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 mock.module("../config/loader.js", () => ({
@@ -62,36 +61,37 @@ mock.module("../daemon/disk-pressure-guard.js", () => ({
   }),
 }));
 
+import type { Conversation } from "../daemon/conversation.js";
 import {
   __resetWakeChainForTests,
   wakeAgentForOpportunity,
-  type WakeTarget,
 } from "../runtime/agent-wake.js";
 
-function makeTarget(): WakeTarget {
-  const history: Message[] = [];
+function makeTarget(): Conversation {
+  const messages: Message[] = [];
   let processing = false;
-  return {
+  const target = {
     conversationId: "conv-wake-callsite",
     agentLoop: {
-      run: (async (messages: Message[]) => ({
+      run: async ({ messages }: { messages: Message[] }) => ({
         history: messages,
         exitReason: null,
         appendedNewMessages: false,
         newMessages: [],
-      })) as WakeTarget["agentLoop"]["run"],
+      }),
     },
-    getMessages: () => history,
-    pushMessage: (msg) => {
-      history.push(msg);
-    },
-    emitAgentEvent: () => {},
+    messages,
+    getMessages: () => messages,
     isProcessing: () => processing,
-    markProcessing: (on) => {
+    setProcessing: (on: boolean) => {
       processing = on;
     },
-    persistTailMessage: async () => {},
+    setTrustContext: () => {},
+    getTurnChannelContext: () => null,
+    getTurnInterfaceContext: () => null,
+    drainQueue: async () => {},
   };
+  return target as unknown as Conversation;
 }
 
 beforeEach(() => {

package/src/__tests__/agent-wake-override-profile.test.ts

@@ -48,8 +48,9 @@ mock.module("../config/loader.js", () => ({
   }),
 }));
 
-import type { AgentEvent, AgentLoopRunOptions } from "../agent/loop.js";
+import type { AgentLoopRunOptions } from "../agent/loop.js";
 import { LLMSchema } from "../config/schemas/llm.js";
+import type { Conversation } from "../daemon/conversation.js";
 import { RetryProvider } from "../providers/retry.js";
 import type {
   Message,
@@ -60,7 +61,6 @@ import type {
 import {
   __resetWakeChainForTests,
   wakeAgentForOpportunity,
-  type WakeTarget,
 } from "../runtime/agent-wake.js";
 
 interface RunArgs {
@@ -69,44 +69,40 @@ interface RunArgs {
 }
 
 function makeTarget(): {
-  target: WakeTarget;
+  target: Conversation;
   runArgs: RunArgs[];
 } {
   const runArgs: RunArgs[] = [];
-  const history: Message[] = [
+  const messages: Message[] = [
     { role: "user", content: [{ type: "text", text: "hi" }] },
   ];
   let processing = false;
 
-  const target: WakeTarget = {
+  const target = {
     conversationId: "conv-wake-override",
     agentLoop: {
-      run: (async (
-        messages: Message[],
-        _onEvent: (event: AgentEvent) => void | Promise<void>,
-        options?: AgentLoopRunOptions,
-      ) => {
+      run: async (options: AgentLoopRunOptions) => {
         runArgs.push({
-          messages: [...messages],
+          messages: [...options.messages],
           options,
         });
         // Return the input verbatim → silent no-op (no assistant tail).
         // Wake never yields at a checkpoint, so the pause-reason is null.
-        return { history: messages, exitReason: null };
-      }) as WakeTarget["agentLoop"]["run"],
-    },
-    getMessages: () => history,
-    pushMessage: (msg) => {
-      history.push(msg);
+        return { history: options.messages, exitReason: null };
+      },
     },
-    emitAgentEvent: () => {},
+    messages,
+    getMessages: () => messages,
     isProcessing: () => processing,
-    markProcessing: (on) => {
+    setProcessing: (on: boolean) => {
       processing = on;
     },
-    persistTailMessage: async () => {},
+    setTrustContext: () => {},
+    getTurnChannelContext: () => null,
+    getTurnInterfaceContext: () => null,
+    drainQueue: async () => {},
   };
-  return { target, runArgs };
+  return { target: target as unknown as Conversation, runArgs };
 }
 
 beforeEach(() => {

package/src/__tests__/anthropic-provider.test.ts

@@ -2,7 +2,11 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 import type { Anthropic } from "@anthropic-ai/sdk";
 
-import type { Message, ToolDefinition } from "../providers/types.js";
+import type {
+  ContentBlock,
+  Message,
+  ToolDefinition,
+} from "../providers/types.js";
 
 // ---------------------------------------------------------------------------
 // Mock Anthropic SDK — must be before importing the provider
@@ -102,7 +106,6 @@ mock.module("@anthropic-ai/sdk", () => ({
 }));
 
 // Import after mocking
-import { cachedTextBlock } from "../memory/v3/provider-blocks.js";
 import { AnthropicProvider } from "../providers/anthropic/client.js";
 import {
   isPlaceholderSentinelText,
@@ -138,6 +141,18 @@ function toolResultMsg(toolUseId: string, content: string): Message {
   };
 }
 
+// A stable prefix text block carrying a 1h-TTL cache_control breakpoint, as a
+// caller may stamp before the provider sees it. The internal ContentBlock type
+// omits cache_control (only the provider transforms it onto the wire), so reach
+// it via a cast.
+function cachedPrefixBlock(text: string): ContentBlock {
+  return {
+    type: "text",
+    text,
+    cache_control: { type: "ephemeral", ttl: "1h" },
+  } as unknown as ContentBlock;
+}
+
 const sampleTools: ToolDefinition[] = [
   {
     name: "file_read",
@@ -325,13 +340,13 @@ describe("AnthropicProvider — Cache-Control Characterization", () => {
   });
 
   test("preserves a caller's 1h block cache_control and sends the extended-cache beta (non-Haiku)", async () => {
-    // v3's `cachedTextBlock` stamps a stable prefix block with a 1h TTL; the
-    // non-Haiku path must forward it unchanged and send the beta header.
+    // A caller that stamps a stable prefix block with a 1h TTL: the non-Haiku
+    // path must forward it unchanged and send the beta header.
     await provider.sendMessage([
       {
         role: "user",
         content: [
-          cachedTextBlock("stable pages block"),
+          cachedPrefixBlock("stable pages block"),
           { type: "text", text: "volatile current message" },
         ],
       },
@@ -349,7 +364,7 @@ describe("AnthropicProvider — Cache-Control Characterization", () => {
 
   test("strips ttl from a caller's block cache_control and omits the beta for Haiku", async () => {
     // Haiku doesn't support the extended-cache-ttl beta, so a caller-stamped
-    // 1h ttl (e.g. from `cachedTextBlock`) must be stripped before sending.
+    // 1h ttl on a message block must be stripped before sending.
     const haiku = new AnthropicProvider(
       "sk-ant-test",
       "claude-haiku-4-5-20251001",
@@ -358,7 +373,7 @@ describe("AnthropicProvider — Cache-Control Characterization", () => {
       {
         role: "user",
         content: [
-          cachedTextBlock("stable pages block"),
+          cachedPrefixBlock("stable pages block"),
           { type: "text", text: "volatile current message" },
         ],
       },
@@ -385,7 +400,7 @@ describe("AnthropicProvider — Cache-Control Characterization", () => {
         {
           role: "user",
           content: [
-            cachedTextBlock("stable pages block"),
+            cachedPrefixBlock("stable pages block"),
             { type: "text", text: "volatile current message" },
           ],
         },

package/src/__tests__/app-builder-tool-scripts.test.ts

@@ -81,6 +81,7 @@ mock.module("../bundler/app-compiler.js", () => ({
 import * as appCreateScript from "../config/bundled-skills/app-builder/tools/app-create.js";
 import * as appDeleteScript from "../config/bundled-skills/app-builder/tools/app-delete.js";
 import * as appRefreshScript from "../config/bundled-skills/app-builder/tools/app-refresh.js";
+import * as appUpdateScript from "../config/bundled-skills/app-builder/tools/app-update.js";
 
 // ---------------------------------------------------------------------------
 // Tests
@@ -171,4 +172,24 @@ describe("app-builder skill tool scripts", () => {
       expect(parsed.appId).toBe("app-1");
     });
   });
+
+  // ---- app-update --------------------------------------------------------
+
+  describe("app-update", () => {
+    test("exports a run function", () => {
+      expect(typeof appUpdateScript.run).toBe("function");
+    });
+
+    test("delegates to executeAppUpdate and returns result", async () => {
+      const result = await appUpdateScript.run(
+        { app_id: "app-1", name: "Renamed" },
+        makeContext(),
+      );
+      expect(result.isError).toBe(false);
+      const parsed = JSON.parse(result.content);
+      expect(parsed.updated).toBe(true);
+      expect(parsed.appId).toBe("app-1");
+      expect(parsed.name).toBe("Renamed");
+    });
+  });
 });

package/src/__tests__/app-control-flow.test.ts

@@ -103,7 +103,7 @@ const { ROUTES } = await import("../runtime/routes/host-app-control-routes.js");
 const { surfaceProxyResolver } =
   await import("../daemon/conversation-surfaces.js");
 const { setConversation, clearConversations } =
-  await import("../daemon/conversation-store.js");
+  await import("../daemon/conversation-registry.js");
 type SurfaceConversationContext =
   import("../daemon/conversation-surfaces.js").SurfaceConversationContext;
 

package/src/__tests__/app-dir-path-guard.test.ts

@@ -19,6 +19,7 @@ const ALLOWLIST = new Set([
   "assistant/src/memory/app-store.ts", // defines getAppsDir
   "assistant/src/memory/app-git-service.ts", // uses getAppsDir for git repo root, not per-app paths
   "assistant/src/daemon/app-source-watcher.ts", // uses getAppsDir for recursive fs.watch root, not per-app paths
+  "assistant/src/tools/filesystem/write.ts", // uses getAppsDir as an exemption root for the artifact-HTML guard, not per-app paths
 ]);
 
 function isTestFile(filePath: string): boolean {

package/src/__tests__/app-executors.test.ts

@@ -32,6 +32,7 @@ import type { AppStore } from "../tools/apps/executors.js";
 import {
   executeAppCreate,
   executeAppRefresh,
+  executeAppUpdate,
 } from "../tools/apps/executors.js";
 
 // ---------------------------------------------------------------------------
@@ -89,6 +90,46 @@ function mockStore(
 // ---------------------------------------------------------------------------
 
 describe("executeAppCreate", () => {
+  test("falls back to the preview title when the name is omitted or blank", async () => {
+    let createdParams: Record<string, unknown> | undefined;
+    const app = makeMultifileApp({ name: "Coffee Tracker" });
+    const store: AppStore = {
+      ...mockStore(app, {}),
+      createApp: (params) => {
+        createdParams = params as unknown as Record<string, unknown>;
+        return app;
+      },
+    };
+
+    const result = await executeAppCreate(
+      { name: "   ", preview: { title: "Coffee Tracker" } },
+      store,
+    );
+
+    expect(result.isError).toBe(false);
+    expect(createdParams?.name).toBe("Coffee Tracker");
+  });
+
+  test("defaults the name to 'New App' when neither name nor preview title is given", async () => {
+    let createdParams: Record<string, unknown> | undefined;
+    const app = makeMultifileApp({ name: "New App" });
+    const store: AppStore = {
+      ...mockStore(app, {}),
+      createApp: (params) => {
+        createdParams = params as unknown as Record<string, unknown>;
+        return app;
+      },
+    };
+
+    const result = await executeAppCreate(
+      {} as unknown as Parameters<typeof executeAppCreate>[0],
+      store,
+    );
+
+    expect(result.isError).toBe(false);
+    expect(createdParams?.name).toBe("New App");
+  });
+
   test("creates multifile app with src/ scaffold", async () => {
     const files: Record<string, string> = {};
     let createdParams: Record<string, unknown> | undefined;
@@ -408,3 +449,94 @@ describe("executeAppRefresh", () => {
     expect(parsed.error).toContain("not found");
   });
 });
+
+// ---------------------------------------------------------------------------
+// executeAppUpdate
+// ---------------------------------------------------------------------------
+
+describe("executeAppUpdate", () => {
+  test("updates metadata and recompiles a multifile app", async () => {
+    const app = makeMultifileApp({ name: "Old", description: "old desc" });
+    let updateArgs: unknown;
+    const store: AppStore = {
+      ...mockStore(app),
+      updateApp: (_id, updates) => {
+        updateArgs = updates;
+        return { ...app, ...updates };
+      },
+    };
+
+    const result = await executeAppUpdate(
+      { app_id: app.id, name: "New Name", description: "new desc" },
+      store,
+    );
+
+    expect(result.isError).toBe(false);
+    expect(updateArgs).toEqual({ name: "New Name", description: "new desc" });
+    const parsed = JSON.parse(result.content);
+    expect(parsed.updated).toBe(true);
+    expect(parsed.name).toBe("New Name");
+    expect(parsed.description).toBe("new desc");
+    expect(parsed.compiled).toBe(true);
+  });
+
+  test("writes source_files before recompiling", async () => {
+    const files: Record<string, string> = {};
+    const app = makeMultifileApp();
+    const store: AppStore = {
+      ...mockStore(app, files),
+      updateApp: (_id, updates) => ({ ...app, ...updates }),
+    };
+
+    const result = await executeAppUpdate(
+      { app_id: app.id, source_files: { "src/App.tsx": "// new code" } },
+      store,
+    );
+
+    expect(result.isError).toBe(false);
+    expect(files["src/App.tsx"]).toBe("// new code");
+    expect(JSON.parse(result.content).compiled).toBe(true);
+  });
+
+  test("legacy app: updates without compiling", async () => {
+    const app = makeLegacyApp({ name: "Legacy" });
+    const store: AppStore = {
+      ...mockStore(app),
+      updateApp: (_id, updates) => ({ ...app, ...updates }),
+    };
+
+    const result = await executeAppUpdate(
+      { app_id: app.id, name: "Renamed" },
+      store,
+    );
+
+    expect(result.isError).toBe(false);
+    const parsed = JSON.parse(result.content);
+    expect(parsed.updated).toBe(true);
+    expect(parsed.name).toBe("Renamed");
+    expect(parsed.compiled).toBeUndefined();
+  });
+
+  test("returns error for unknown app", async () => {
+    const store = mockStore(makeMultifileApp());
+    const result = await executeAppUpdate({ app_id: "nope" }, store);
+
+    expect(result.isError).toBe(true);
+    expect(JSON.parse(result.content).error).toContain("not found");
+  });
+
+  test("rejects invalid source_files", async () => {
+    const app = makeMultifileApp();
+    const store = mockStore(app);
+    const result = await executeAppUpdate(
+      {
+        app_id: app.id,
+        source_files: { "src/App.tsx": 123 as unknown as string },
+      },
+      store,
+    );
+
+    expect(result.isError).toBe(true);
+    expect(JSON.parse(result.content).error).toContain("must be a string");
+  });
+});

package/src/__tests__/approval-cascade.test.ts

@@ -173,9 +173,10 @@ mock.module("../memory/retriever.js", () => ({
   injectMemoryRecallAsUserBlock: (msgs: Message[]) => msgs,
 }));
 
-mock.module("../context/window-manager.js", () => ({
+mock.module("../plugins/defaults/compaction/window-manager.js", () => ({
   ContextWindowManager: class {
     constructor() {}
+    updateConfig() {}
     shouldCompact() {
       return { needed: false, estimatedTokens: 0 };
     }
@@ -208,10 +209,10 @@ mock.module("../agent/loop.js", () => ({
     getActiveModel() {
       return undefined;
     }
-    async run(
-      _messages: Message[],
-      _onEvent: (event: AgentEvent) => void,
-    ): Promise<Message[]> {
+    async run(_options: {
+      messages: Message[];
+      onEvent: (event: AgentEvent) => void;
+    }): Promise<Message[]> {
       return [];
     }
   },

package/src/__tests__/approval-routes-http.test.ts

@@ -119,12 +119,15 @@ mock.module("../permissions/trust-store.js", () => ({
 // ---------------------------------------------------------------------------
 let _conversationFactory: (() => Conversation) | undefined;
 
-mock.module("../daemon/conversation-store.js", () => ({
+mock.module("../daemon/conversation-registry.js", () => ({
   findConversation: () => {
     // Return the current test session for any conversation ID lookup.
     if (!_conversationFactory) return undefined;
     return _conversationFactory();
   },
+}));
+
+mock.module("../daemon/conversation-store.js", () => ({
   getOrCreateConversation: async () => {
     if (!_conversationFactory)
       throw new Error("_conversationFactory not set in test");

package/src/__tests__/background-workers-disk-pressure.test.ts

@@ -117,7 +117,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   findMostRecentRetrospectiveFor: mock(() => null),
   forkConversation: mock(() => ({ id: "conv-fork" })),
   getConversationOverrideProfile: () => undefined,
-  getConversationOverrideProfileFromRow: () => undefined,
+  resolveOverrideProfile: () => undefined,
   getConversationMemoryScopeId: () => "default",
   getConversationOriginChannel: () => null,
   getConversationOriginInterface: () => null,

package/src/__tests__/build-persisted-content.test.ts

@@ -54,7 +54,10 @@ mock.module("../memory/llm-request-log-store.js", () => ({
 }));
 
 // ── Imports (after mocks) ─────────────────────────────────────────────────────
-import { buildPersistedAssistantContent } from "../daemon/conversation-agent-loop-handlers.js";
+import {
+  buildPersistedAssistantContent,
+  stampThinkingTiming,
+} from "../daemon/conversation-agent-loop-handlers.js";
 import type { ToolActivityMetadata } from "../daemon/message-types/web-activity.js";
 import type { ContentBlock } from "../providers/types.js";
 
@@ -182,3 +185,74 @@ describe("buildPersistedAssistantContent — native activityMetadata", () => {
     expect(block._activityMetadata).toBeUndefined();
   });
 });
+
+describe("stampThinkingTiming", () => {
+  test("stamps internal timing onto thinking blocks by position", () => {
+    // GIVEN a turn that interleaves text and two thinking blocks AND the
+    // per-block timing captured while streaming (one entry per thinking block,
+    // in stream order)
+    const content = [
+      { type: "thinking", thinking: "first", signature: "s1" },
+      { type: "text", text: "answer" },
+      { type: "thinking", thinking: "second", signature: "s2" },
+    ] as unknown as ContentBlock[];
+    const timings = [
+      { startedAt: 100, completedAt: 250 },
+      { startedAt: 400, completedAt: 480 },
+    ];
+
+    // WHEN the content is stamped before persistence
+    const stamped = stampThinkingTiming(content, timings) as unknown as Array<
+      Record<string, unknown>
+    >;
+
+    // THEN each thinking block carries the `_`-prefixed timing for its position
+    expect(stamped[0]).toMatchObject({
+      type: "thinking",
+      _startedAt: 100,
+      _completedAt: 250,
+    });
+    expect(stamped[2]).toMatchObject({
+      type: "thinking",
+      _startedAt: 400,
+      _completedAt: 480,
+    });
+    // AND the interleaved text block is left untouched
+    expect(stamped[1]).toEqual({ type: "text", text: "answer" });
+  });
+
+  test("leaves thinking blocks unstamped when no timing was captured", () => {
+    // GIVEN thinking content but an empty timing list (thinking streaming was
+    // disabled, so no per-block timing was recorded this turn)
+    const content = [
+      { type: "thinking", thinking: "first", signature: "s1" },
+    ] as unknown as ContentBlock[];
+
+    // WHEN the content is stamped with no timing
+    const stamped = stampThinkingTiming(content, []);
+
+    // THEN the original content is returned unchanged so the UI hides duration,
+    // exactly as a tool call with no timing
+    expect(stamped).toBe(content);
+    expect(stamped[0]).not.toHaveProperty("_startedAt");
+  });
+
+  test("stamps only the thinking blocks that have a matching timing entry", () => {
+    // GIVEN two thinking blocks but only one captured timing entry (e.g. the
+    // second block opened after the timing array was already finalized)
+    const content = [
+      { type: "thinking", thinking: "first", signature: "s1" },
+      { type: "thinking", thinking: "second", signature: "s2" },
+    ] as unknown as ContentBlock[];
+    const timings = [{ startedAt: 100, completedAt: 250 }];
+
+    // WHEN the content is stamped
+    const stamped = stampThinkingTiming(content, timings) as unknown as Array<
+      Record<string, unknown>
+    >;
+
+    // THEN the first block is stamped and the unmatched second block is left as-is
+    expect(stamped[0]).toMatchObject({ _startedAt: 100, _completedAt: 250 });
+    expect(stamped[1]).not.toHaveProperty("_startedAt");
+  });
+});

package/src/__tests__/channel-approval-routes.test.ts

@@ -16,7 +16,7 @@ mock.module("../util/logger.js", () => ({
 }));
 
 const _conversationMocks = new Map<string, unknown>();
-mock.module("../daemon/conversation-store.js", () => ({
+mock.module("../daemon/conversation-registry.js", () => ({
   findConversation: (id: string) => _conversationMocks.get(id),
 }));
 

package/src/__tests__/channel-approvals.test.ts

@@ -11,7 +11,7 @@ mock.module("../util/logger.js", () => ({
 
 // Map conversationId → mock session so findConversation returns the right mock.
 const conversationMocks = new Map<string, unknown>();
-mock.module("../daemon/conversation-store.js", () => ({
+mock.module("../daemon/conversation-registry.js", () => ({
   findConversation: (id: string) => conversationMocks.get(id),
 }));