@vellumai/assistant 0.8.8 → 0.8.9-dev.202606091853.fbaa2ae

package/src/runtime/routes/conversation-routes.ts

@@ -680,7 +680,14 @@ export function handleListMessages({
   // assistant message has tool_use blocks but its matching user tool_result
   // is left visible, the result will render as a standalone orphan because
   // `mergeToolResultsIntoAssistantMessages` has nothing to merge it into.
-  const visibleFilter = (m: MessageRow) => !isHiddenMessage(m.metadata);
+  //
+  // Only renderable roles reach this UI-facing transcript. `system` rows (a
+  // permitted `MessageRole`, e.g. skill-authored context) are agent-context
+  // scaffolding, never a displayed turn, so they are dropped here at the
+  // source rather than narrowed away per-client.
+  const visibleFilter = (m: MessageRow) =>
+    !isHiddenMessage(m.metadata) &&
+    (m.role === "user" || m.role === "assistant");
 
   if (isPaginated) {
     const result = getMessagesPaginated(
@@ -772,14 +779,21 @@ export function handleListMessages({
       },
     );
 
+    // `visibleFilter` has already dropped every non-renderable role, so the
+    // only values reaching here are `user` and `assistant`; narrow the raw DB
+    // `string` to the wire union.
+    const role: "user" | "assistant" =
+      msg.role === "assistant" ? "assistant" : "user";
+
     return {
       id: msg.id,
-      role: msg.role,
+      role,
       content,
       createdAt: msg.createdAt,
       sentAt,
       subagentNotification,
       slackMessage,
+      clientMessageId: msg.clientMessageId ?? undefined,
     };
   });
 
@@ -916,6 +930,7 @@ export function handleListMessages({
     return {
       id: m.id ?? "",
       ...(mergedMessageIds.length > 0 ? { mergedMessageIds } : {}),
+      ...(m.clientMessageId ? { clientMessageId: m.clientMessageId } : {}),
       role: m.role,
       // Flat plain-text body the legacy Swift client reads directly; see the
       // `content` field on ConversationMessageSchema for why this must stay.
@@ -1354,6 +1369,11 @@ export async function handleSendMessage(
       mapping.conversationId,
       requestedInferenceProfile,
     );
+    conversation.applyInferenceProfileState({
+      profile: requestedInferenceProfile,
+      sessionId: null,
+      expiresAt: null,
+    });
   }
 
   // Store pre-chat onboarding context on the conversation when this is the
@@ -1721,6 +1741,7 @@ export async function handleSendMessage(
         ...(body.automated === true ? { automated: true } : {}),
       },
       isInteractive,
+      sourceActorPrincipalId,
       transport,
       clientMessageId,
     });
@@ -1822,6 +1843,7 @@ export async function handleSendMessage(
     userMessageInterface: sourceInterface,
     assistantMessageInterface: sourceInterface,
   });
+  conversation.currentTurnSourceActorPrincipalId = sourceActorPrincipalId;
 
   await conversation.ensureActorScopedHistory();
 
@@ -2657,6 +2679,12 @@ export const ROUTES: RouteDefinition[] = [
       conversationType: z.string().optional(),
       slashCommand: z.string().optional(),
       clientTimezone: z.string().optional(),
+      clientMessageId: z
+        .string()
+        .describe(
+          "Client-generated idempotency nonce. Persisted on the row and echoed back on the message_echo event and the messages snapshot so the client can correlate its optimistic row by identity. Duplicate sends for the same (conversation, clientMessageId) are deduplicated server-side.",
+        )
+        .optional(),
       inferenceProfile: z.string().nullable().optional(),
       riskThreshold: z.enum(VALID_RISK_THRESHOLDS).optional(),
       onboarding: z

package/src/runtime/routes/conversation-starter-routes.ts

@@ -11,6 +11,7 @@ import { z } from "zod";
 import {
   checkpointKey,
   CK_ITEM_COUNT,
+  CK_LAST_ATTEMPT_AT,
   CK_LAST_GEN_AT,
   countActiveMemoryNodes,
   getCheckpointValue,
@@ -42,10 +43,11 @@ const starterItemSchema = z.object({
 
 type StarterItem = z.infer<typeof starterItemSchema>;
 
-export const CONVERSATION_STARTERS_STALE_TTL_MS = 24 * 60 * 60 * 1000;
+export const CONVERSATION_STARTERS_STALE_TTL_MS = 4 * 60 * 60 * 1000;
 
-/** Minimum interval between re-enqueue attempts triggered by invalid items. */
-const REFRESH_COOLDOWN_MS = 60_000;
+/** Minimum interval between re-enqueue attempts (prevents tight retry loops
+ *  when generation repeatedly fails or produces 0 valid starters). */
+const REFRESH_COOLDOWN_MS = 5 * 60 * 1000;
 
 function hasActiveConversationStarterJob(
   db: ReturnType<typeof getDb>,
@@ -199,12 +201,16 @@ function handleListConversationStarters({
       Date.now() - lastGenAt >= CONVERSATION_STARTERS_STALE_TTL_MS;
     const checkpointAhead = lastCount != null && totalActive < lastCount;
     let hasActiveJob = hasActiveConversationStarterJob(db, scopeId);
+    const lastAttemptAt = parseCheckpointInt(
+      getCheckpointValue(checkpointKey(CK_LAST_ATTEMPT_AT, scopeId)),
+    );
     const withinCooldown =
-      lastGenAt != null && Date.now() - lastGenAt < REFRESH_COOLDOWN_MS;
+      lastAttemptAt != null && Date.now() - lastAttemptAt < REFRESH_COOLDOWN_MS;
     const shouldRefresh =
-      staleByAge ||
-      checkpointAhead ||
-      (invalidItemCount > 0 && totalActive > 0 && !withinCooldown);
+      !withinCooldown &&
+      (staleByAge ||
+        checkpointAhead ||
+        (invalidItemCount > 0 && totalActive > 0));
 
     if (shouldRefresh && !hasActiveJob && isMemoryEnabled()) {
       enqueueMemoryJob("generate_conversation_starters", { scopeId });

package/src/runtime/routes/conversations-import-routes.ts

@@ -46,7 +46,10 @@ interface ImportPayload {
 
 // -- Helpers (ported from CLI) --
 
-function resolveTimestamps(conv: ImportConversation): {
+function resolveTimestamps(
+  conv: ImportConversation,
+  messages: ImportMessage[],
+): {
   convCreatedAt: number;
   convUpdatedAt: number;
   messageTimestamps: number[];
@@ -54,13 +57,23 @@ function resolveTimestamps(conv: ImportConversation): {
   const now = Date.now();
   const convCreatedAt = conv.createdAt ?? now;
   const convUpdatedAt = conv.updatedAt ?? conv.createdAt ?? now;
-  const messageTimestamps = conv.messages.map((msg, i) => {
+  const messageTimestamps = messages.map((msg, i) => {
     if (msg.createdAt != null) return msg.createdAt;
     return convCreatedAt + i;
   });
   return { convCreatedAt, convUpdatedAt, messageTimestamps };
 }
 
+/**
+ * The messages store is UI-facing (`ConversationMessage`), so only renderable
+ * turns are persisted. Non-renderable roles (e.g. agent-context `system`
+ * rows an export might carry) are dropped here rather than imported — the
+ * import still succeeds with the displayable turns.
+ */
+function isRenderableRole(role: string): role is "user" | "assistant" {
+  return role === "user" || role === "assistant";
+}
+
 // -- Handler --
 
 async function handleConversationsImport({ body }: RouteHandlerArgs) {
@@ -99,12 +112,16 @@ async function handleConversationsImport({ body }: RouteHandlerArgs) {
         }
       }
 
+      const messages = conv.messages.filter((msg) =>
+        isRenderableRole(msg.role),
+      );
+
       const { convCreatedAt, convUpdatedAt, messageTimestamps } =
-        resolveTimestamps(conv);
+        resolveTimestamps(conv, messages);
 
       const conversation = createConversation(conv.title);
 
-      for (const msg of conv.messages) {
+      for (const msg of messages) {
         const contentStr =
           typeof msg.content === "string"
             ? msg.content
@@ -144,8 +161,8 @@ async function handleConversationsImport({ body }: RouteHandlerArgs) {
       }
 
       // Index messages
-      for (let i = 0; i < dbMessages.length && i < conv.messages.length; i++) {
-        const msg = conv.messages[i];
+      for (let i = 0; i < dbMessages.length && i < messages.length; i++) {
+        const msg = messages[i];
         const contentStr =
           typeof msg.content === "string"
             ? msg.content
@@ -176,7 +193,7 @@ async function handleConversationsImport({ body }: RouteHandlerArgs) {
       }
 
       imported++;
-      totalMessages += conv.messages.length;
+      totalMessages += messages.length;
     } catch (err) {
       errors.push({
         index: idx,

package/src/runtime/routes/host-app-control-routes.ts

@@ -14,7 +14,7 @@
  */
 import { z } from "zod";
 
-import { findConversation } from "../../daemon/conversation-store.js";
+import { findConversation } from "../../daemon/conversation-registry.js";
 import type {
   HostAppControlResultPayload,
   HostAppControlState,

package/src/runtime/routes/host-cu-routes.ts

@@ -6,7 +6,7 @@
  */
 import { z } from "zod";
 
-import { findConversation } from "../../daemon/conversation-store.js";
+import { findConversation } from "../../daemon/conversation-registry.js";
 import { ACTOR_PRINCIPALS } from "../auth/route-policy.js";
 import {
   enforceSameActorOrThrow,

package/src/runtime/routes/identity-routes.ts

@@ -33,6 +33,7 @@ import { NotFoundError } from "./errors.js";
 import {
   getCachedIntro,
   readWorkspaceGreetings,
+  readWorkspaceIdentityIntro,
   setCachedIntro,
 } from "./identity-intro-cache.js";
 import type { RouteDefinition } from "./types.js";
@@ -455,16 +456,30 @@ function getIdentityIntro(): IdentityIntroResponse {
     return identityIntroResponse(FALLBACK_GREETINGS, "fallback");
   }
 
-  // 2. Cached LLM-generated greetings
+  // 2. Cached LLM-generated greetings (populated by background refresh)
   const cached = getCachedIntro();
   if (cached) {
     return identityIntroResponse(cached.greetings, "cache");
   }
 
-  // 3. Trigger fresh generation without blocking the empty-state UI.
+  // 3. Identity intro tagline from `## Identity Intro` in IDENTITY.md
+  //    (written during onboarding by BOOTSTRAP.md instructions)
+  const identityIntro = readWorkspaceIdentityIntro();
+  if (identityIntro) {
+    // Still trigger background generation so the next request gets
+    // LLM-generated greetings instead of the static tagline.
+    const refreshing = triggerEmptyStateGreetingGeneration();
+    return identityIntroResponse(
+      [identityIntro, ...FALLBACK_GREETINGS],
+      "workspace",
+      refreshing,
+    );
+  }
+
+  // 4. Trigger fresh generation without blocking the empty-state UI.
   const refreshing = triggerEmptyStateGreetingGeneration();
 
-  // 4. Generic fallback only when generation is unavailable.
+  // 5. Generic fallback only when generation is unavailable.
   return identityIntroResponse(FALLBACK_GREETINGS, "fallback", refreshing);
 }
 

package/src/runtime/routes/inbound-message-handler.ts

@@ -20,7 +20,7 @@ import {
   createApprovalConversationGenerator,
   createApprovalCopyGenerator,
 } from "../../daemon/approval-generators.js";
-import { findConversation } from "../../daemon/conversation-store.js";
+import { findConversation } from "../../daemon/conversation-registry.js";
 import {
   canonicalizeTimeZone,
   resolveTurnTimezoneContext,

package/src/runtime/routes/inbound-stages/acl-enforcement.ts

@@ -23,7 +23,7 @@ import {
   findByInviteCodeHash,
   findByInviteCodeHashAnyChannel,
 } from "../../../memory/invite-store.js";
-import { MESSAGE_PREVIEW_MAX_LENGTH } from "../../../notifications/copy-composer.js";
+import { MESSAGE_PREVIEW_MAX_LENGTH } from "../../../notifications/access-request-copy.js";
 import { resolveGuardianName } from "../../../prompts/user-reference.js";
 import { getLogger } from "../../../util/logger.js";
 import { truncate } from "../../../util/truncate.js";
@@ -332,12 +332,12 @@ export async function enforceIngressAcl(
 
             return {
               resolvedMember: null,
-              earlyResponse: ({
+              earlyResponse: {
                 accepted: true,
                 denied: true,
                 reason: "verification_challenge_sent",
                 verificationSessionId: slackVerifyResult.sessionId,
-              }),
+              },
             };
           }
         }
@@ -375,12 +375,12 @@ export async function enforceIngressAcl(
 
             return {
               resolvedMember: null,
-              earlyResponse: ({
+              earlyResponse: {
                 accepted: true,
                 denied: true,
                 reason: "verification_challenge_sent",
                 verificationSessionId: emailVerifyResult.sessionId,
-              }),
+              },
             };
           }
         }
@@ -438,14 +438,14 @@ export async function enforceIngressAcl(
 
         return {
           resolvedMember: null,
-          earlyResponse: ({
+          earlyResponse: {
             accepted: true,
             denied: true,
             reason: "not_a_member",
             // Include reply text so the gateway can deliver directly when
             // callback delivery failed (e.g. signing-key mismatch → 401).
             ...(!replyDelivered && { replyText }),
-          }),
+          },
         };
       }
     }
@@ -610,12 +610,12 @@ export async function enforceIngressAcl(
 
               return {
                 resolvedMember,
-                earlyResponse: ({
+                earlyResponse: {
                   accepted: true,
                   denied: true,
                   reason: "verification_challenge_sent",
                   verificationSessionId: slackVerifyResult.sessionId,
-                }),
+                },
               };
             }
           }
@@ -682,12 +682,12 @@ export async function enforceIngressAcl(
           }
           return {
             resolvedMember,
-            earlyResponse: ({
+            earlyResponse: {
               accepted: true,
               denied: true,
               reason: `member_${channelStatusToMemberStatus(resolvedMember.channel.status)}`,
               ...(!inactiveReplyDelivered && { replyText: inactiveReplyText }),
-            }),
+            },
           };
         }
       }
@@ -722,15 +722,14 @@ export async function enforceIngressAcl(
         }
         return {
           resolvedMember,
-          earlyResponse: ({
+          earlyResponse: {
             accepted: true,
             denied: true,
             reason: "policy_deny",
             ...(!denyReplyDelivered && { replyText: denyReplyText }),
-          }),
+          },
         };
       }
-
     }
   }
 
@@ -786,11 +785,11 @@ async function handleInviteTokenIntercept(params: {
   );
 
   if (dedupResult.duplicate) {
-    return ({
+    return {
       accepted: true,
       duplicate: true,
       eventId: dedupResult.eventId,
-    });
+    };
   }
 
   const outcome = redeemInvite({
@@ -835,11 +834,11 @@ async function handleInviteTokenIntercept(params: {
       }
     }
     markProcessed(dedupResult.eventId);
-    return ({
+    return {
       accepted: true,
       eventId: dedupResult.eventId,
       inviteRedemption: "already_member",
-    });
+    };
   }
 
   const replyText = getInviteRedemptionReply(outcome);
@@ -861,22 +860,22 @@ async function handleInviteTokenIntercept(params: {
 
   if (outcome.ok && outcome.type === "redeemed") {
     markProcessed(dedupResult.eventId);
-    return ({
+    return {
       accepted: true,
       eventId: dedupResult.eventId,
       inviteRedemption: "redeemed",
       memberId: outcome.memberId,
-    });
+    };
   }
 
   // Failed redemption — inform the user and deny
   markProcessed(dedupResult.eventId);
-  return ({
+  return {
     accepted: true,
     eventId: dedupResult.eventId,
     denied: true,
     inviteRedemption: outcome.reason,
-  });
+  };
 }
 
 // ---------------------------------------------------------------------------
@@ -942,11 +941,11 @@ async function handleInviteCodeIntercept(params: {
       );
 
       if (dedupResult.duplicate) {
-        return ({
+        return {
           accepted: true,
           duplicate: true,
           eventId: dedupResult.eventId,
-        });
+        };
       }
 
       const mismatchReply = "This invite is not valid for this channel.";
@@ -965,12 +964,12 @@ async function handleInviteCodeIntercept(params: {
         }
       }
       markProcessed(dedupResult.eventId);
-      return ({
+      return {
         accepted: true,
         eventId: dedupResult.eventId,
         denied: true,
         inviteRedemption: "channel_mismatch",
-      });
+      };
     }
     return null;
   }
@@ -988,11 +987,11 @@ async function handleInviteCodeIntercept(params: {
   );
 
   if (dedupResult.duplicate) {
-    return ({
+    return {
       accepted: true,
       duplicate: true,
       eventId: dedupResult.eventId,
-    });
+    };
   }
 
   let outcome: ReturnType<typeof redeemInviteByCode>;
@@ -1046,11 +1045,11 @@ async function handleInviteCodeIntercept(params: {
       }
     }
     markProcessed(dedupResult.eventId);
-    return ({
+    return {
       accepted: true,
       eventId: dedupResult.eventId,
       inviteRedemption: "already_member",
-    });
+    };
   }
 
   const replyText = getInviteRedemptionReply(outcome);
@@ -1072,22 +1071,22 @@ async function handleInviteCodeIntercept(params: {
 
   if (outcome.ok && outcome.type === "redeemed") {
     markProcessed(dedupResult.eventId);
-    return ({
+    return {
       accepted: true,
       eventId: dedupResult.eventId,
       inviteRedemption: "redeemed",
       memberId: outcome.memberId,
-    });
+    };
   }
 
   // Failed redemption (expired, revoked, etc.) — inform and deny
   markProcessed(dedupResult.eventId);
-  return ({
+  return {
     accepted: true,
     eventId: dedupResult.eventId,
     denied: true,
     inviteRedemption: !outcome.ok ? outcome.reason : undefined,
-  });
+  };
 }
 
 // ---------------------------------------------------------------------------

package/src/runtime/routes/inference-profile-session-handler.ts

@@ -15,6 +15,7 @@
 import { randomUUID } from "node:crypto";
 
 import { loadConfig } from "../../config/loader.js";
+import { findConversation } from "../../daemon/conversation-registry.js";
 import {
   getConversation,
   listActiveInferenceProfileSessions,
@@ -118,6 +119,11 @@ export async function setInferenceProfileSession({
       };
     }
     setConversationInferenceProfileSession(resolvedId, null, null, null);
+    findConversation(resolvedId)?.applyInferenceProfileState({
+      profile: null,
+      sessionId: null,
+      expiresAt: null,
+    });
     publishConversationInferenceProfileChanged(
       {
         conversationId: resolvedId,
@@ -188,6 +194,11 @@ export async function setInferenceProfileSession({
     newSessionId ?? null,
     newExpiresAt ?? null,
   );
+  findConversation(resolvedId)?.applyInferenceProfileState({
+    profile,
+    sessionId: newSessionId ?? null,
+    expiresAt: newExpiresAt ?? null,
+  });
 
   publishConversationInferenceProfileChanged(
     {

package/src/runtime/routes/inference-profile-session-reaper.ts

@@ -11,6 +11,7 @@
  * background sweeps in `http-server.ts`.
  */
 
+import { findConversation } from "../../daemon/conversation-registry.js";
 import { clearExpiredInferenceProfiles } from "../../memory/conversation-crud.js";
 import { getLogger } from "../../util/logger.js";
 import { publishConversationInferenceProfileChanged } from "../sync/resource-sync-events.js";
@@ -37,6 +38,11 @@ export function tickInferenceProfileReaper(): void {
   const now = Date.now();
   const cleared = clearExpiredInferenceProfiles(now);
   for (const { conversationId } of cleared) {
+    findConversation(conversationId)?.applyInferenceProfileState({
+      profile: null,
+      sessionId: null,
+      expiresAt: null,
+    });
     publishConversationInferenceProfileChanged({
       conversationId,
       profile: null,