@vellumai/assistant 0.8.7 → 0.8.8-dev.202606052332.17fc8ea

package/src/daemon/conversation.ts

@@ -52,7 +52,6 @@ import { registerToolTraceListener } from "../events/tool-trace-listener.js";
 import { resolveCanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
 import {
   getConversation,
-  getConversationOriginChannel,
   getConversationOverrideProfileFromRow,
   setConversationHistoryStrippedAt,
 } from "../memory/conversation-crud.js";
@@ -68,6 +67,7 @@ import type { TrustClass } from "../runtime/actor-trust-resolver.js";
 import { broadcastMessage } from "../runtime/assistant-event-hub.js";
 import type { AuthContext } from "../runtime/auth/types.js";
 import type { InteractiveUiResult } from "../runtime/interactive-ui.js";
+import { publishSyncInvalidation } from "../runtime/sync/sync-publisher.js";
 import { ToolExecutor } from "../tools/executor.js";
 import { getAllToolDefinitions } from "../tools/registry.js";
 import type { ToolLifecycleEvent } from "../tools/types.js";
@@ -127,9 +127,7 @@ import type { ToolSetupContext } from "./conversation-tool-setup.js";
 import {
   createResolveToolsCallback,
   createToolExecutor,
-  resolveTrustClass,
 } from "./conversation-tool-setup.js";
-import { refreshWorkspaceTopLevelContextIfNeeded as refreshWorkspaceImpl } from "./conversation-workspace.js";
 import { canonicalizeTimeZone } from "./date-context.js";
 import { HostAppControlProxy } from "./host-app-control-proxy.js";
 import { HostCuProxy } from "./host-cu-proxy.js";
@@ -143,6 +141,7 @@ import type {
 import type { ConversationTransportMetadata } from "./message-types/conversations.js";
 import { isHostProxyTransport } from "./message-types/conversations.js";
 import type { ConfirmationStateChanged } from "./message-types/messages.js";
+import { conversationMetadataSyncTag } from "./message-types/sync.js";
 import { TraceEmitter } from "./trace-emitter.js";
 
 const log = getLogger("conversation");
@@ -159,7 +158,7 @@ export type {
   QueueDrainReason,
   QueuePolicy,
 } from "./conversation-queue-manager.js";
-import type { TrustContext } from "./trust-context.js";
+import { resolveTrustClass, type TrustContext } from "./trust-context.js";
 
 export interface ConversationConstructorOptions {
   maxTokens?: number;
@@ -174,7 +173,7 @@ export class Conversation {
   /** @internal */ provider: Provider;
   /** @internal */ messages: Message[] = [];
   /** @internal */ agentLoop: AgentLoop;
-  /** @internal */ processing = false;
+  private _processing = false;
   private stale = false;
   /** @internal */ abortController: AbortController | null = null;
   /** @internal */ prompter: PermissionPrompter;
@@ -733,7 +732,30 @@ export class Conversation {
   }
 
   isProcessing(): boolean {
-    return this.processing;
+    return this._processing;
+  }
+
+  /**
+   * Mutate the server-authoritative `processing` flag. Web/Capacitor/CLI
+   * caches treat this flag as the source of truth for the avatar streaming
+   * ring and thinking indicator, so the `true → false` clear must announce
+   * itself: the daemon flips it in the agent-loop `finally` (after an awaited
+   * turn-boundary commit), which is later than the user-visible terminal SSE
+   * events, and a racing metadata refetch can otherwise re-read the
+   * not-yet-cleared `true` and clobber the client's optimistic `false`.
+   *
+   * Emitting a metadata invalidation on the clear lets every client GET the
+   * authoritative `false`, per the multi-client-sync contract in AGENTS.md
+   * ("emit the invalidation after the canonical state write succeeds").
+   */
+  setProcessing(value: boolean): void {
+    const wasProcessing = this._processing;
+    this._processing = value;
+    if (wasProcessing && !value) {
+      void publishSyncInvalidation([
+        conversationMetadataSyncTag(this.conversationId),
+      ]);
+    }
   }
 
   markStale(): void {
@@ -795,6 +817,7 @@ export class Conversation {
     this.cesClient = undefined;
     this.activeContextNodeIds = this.graphMemory.tracker.getActiveNodeIds();
     this.graphMemory.persistState();
+    this.graphMemory.dispose();
     disposeConversation(this);
   }
 
@@ -836,7 +859,7 @@ export class Conversation {
   }
 
   canHandoffAtCheckpoint(): boolean {
-    return this.processing && this.hasQueuedMessages();
+    return this._processing && this.hasQueuedMessages();
   }
 
   hasPendingConfirmation(requestId: string): boolean {
@@ -1020,9 +1043,7 @@ export class Conversation {
     }
   }
 
-  async forceCompact(options?: {
-    targetInputTokensOverride?: number;
-  }): Promise<ContextWindowResult> {
+  async forceCompact(): Promise<ContextWindowResult> {
     const conversationRow = getConversation(this.conversationId);
     const overrideProfile =
       getConversationOverrideProfileFromRow(conversationRow) ?? null;
@@ -1066,11 +1087,7 @@ export class Conversation {
       this.abortController?.signal ?? undefined,
       {
         force: true,
-        lastCompactedAt: this.contextCompactedAt ?? undefined,
-        conversationOriginChannel:
-          getConversationOriginChannel(this.conversationId) ?? undefined,
         overrideProfile,
-        targetInputTokensOverride: options?.targetInputTokensOverride,
         actorTrustClass: this.trustContext?.trustClass,
       },
     );
@@ -1081,7 +1098,6 @@ export class Conversation {
     // etc.) — skip those so they don't silently reset the counter.
     if (result.summaryFailed !== undefined) {
       await this.agentLoop.compactionCircuit.recordOutcome(
-        this,
         result.summaryFailed,
         this.sendToClient,
       );
@@ -1251,7 +1267,7 @@ export class Conversation {
   async persistUserMessage(
     options: PersistMessageOptions,
   ): Promise<{ id: string; deduplicated: boolean }> {
-    if (!this.processing) {
+    if (!this._processing) {
       await this.ensureActorScopedHistory();
     }
     return persistUserMessageImpl(this, options);
@@ -1328,10 +1344,6 @@ export class Conversation {
 
   // ── Workspace ────────────────────────────────────────────────────
 
-  refreshWorkspaceTopLevelContextIfNeeded(): void {
-    refreshWorkspaceImpl(this);
-  }
-
   markWorkspaceTopLevelDirty(): void {
     this.workspaceTopLevelDirty = true;
   }

package/src/daemon/external-plugins-bootstrap.ts

@@ -2,23 +2,23 @@
  * Plugin bootstrap — runs every registered plugin's `init()` hook once during
  * daemon startup.
  *
- * Plugins register themselves via side-effect imports elsewhere in the boot
- * sequence (first-party) or at runtime (hot-reload). By the time
- * {@link bootstrapPlugins} runs, the registry has been fully populated for
- * this boot cycle. This function:
+ * The registry is populated before this runs: first-party defaults are
+ * registered explicitly (step 1 below), user plugins are registered by the
+ * user-plugin loader from the workspace `plugins/` directory, and hot-reload
+ * registers at runtime. By the time {@link bootstrapPlugins} runs, the
+ * registry has been fully populated for this boot cycle. This function:
  *
  * 1. Registers the canonical first-party default plugins via
- *    {@link registerDefaultPlugins} (one per pipeline). Registration is
- *    idempotent so repeat calls (e.g. during integration tests) do not throw.
+ *    {@link registerDefaultPlugins}. Registration is idempotent so repeat
+ *    calls (e.g. during integration tests) do not throw.
  * 2. Walks {@link getRegisteredPlugins} in registration order.
  * 3. For each plugin, consults `manifest.requiresFlag` against
  *    {@link isAssistantFeatureFlagEnabled}. If any listed flag is disabled,
  *    the plugin is skipped wholesale — no `init()`, no tool/route/skill
  *    contributions, no entry in the shutdown hook, and the plugin is also
- *    dropped from the registry via {@link unregisterPlugin} so its middleware
- *    and injectors stop participating in pipeline runs and system-prompt
- *    assembly. This is the primary mechanism for shipping experimental
- *    plugins behind a feature flag.
+ *    dropped from the registry via {@link unregisterPlugin} so none of its
+ *    hooks participate in the turn lifecycle. This is the primary mechanism for
+ *    shipping experimental plugins behind a feature flag.
  * 4. Resolves the plugin's `manifest.requiresCredential` entries via the
  *    credential store helper ({@link getSecureKeyAsync}). In Docker mode
  *    that helper goes through the CES HTTP API transparently; in local mode
@@ -190,8 +190,8 @@ function getDisabledPluginFlag(
  * 1. Install the `globalThis.__vellumPluginRuntime` bridge so plugins can touch
  *    it from their module body (see `plugins/external-api.ts` — compiled-binary
  *    module identity).
- * 2. Register the first-party defaults so their middleware and injectors
- *    compose innermost, ahead of any user plugins.
+ * 2. Register the first-party defaults so their middleware composes innermost,
+ *    ahead of any user plugins.
  * 3. Load user plugins from `<workspaceDir>/plugins/*`. A failing user plugin is
  *    logged and skipped; `loadUserPlugins()` closes the registration window
  *    when it returns, so the defaults must already be registered by then.
@@ -228,7 +228,7 @@ export async function initializePlugins(): Promise<void> {
  */
 export async function bootstrapPlugins(): Promise<void> {
   // Register first-party default plugins. Each default wraps one of the
-  // assistant's canonical pipelines (`toolExecute`, `llmCall`, ...) with a
+  // assistant's canonical pipelines (`compaction`, `persistence`, ...) with a
   // passthrough so the pipeline shape is explicit at boot even when no
   // third-party plugins are loaded. Registration is idempotent via the
   // already-registered guard so repeated calls (e.g. during integration
@@ -237,8 +237,8 @@ export async function bootstrapPlugins(): Promise<void> {
 
   const plugins = getRegisteredPlugins();
   if (plugins.length === 0) {
-    // No-op fast path. The default injectors normally populate the registry,
-    // so this branch is primarily for tests that call
+    // No-op fast path. The default plugins normally populate the registry, so
+    // this branch is primarily for tests that call
     // `resetPluginRegistryForTests()` and stub the default registration.
     log.debug("bootstrapPlugins: registry empty — skipping");
     return;
@@ -262,9 +262,8 @@ export async function bootstrapPlugins(): Promise<void> {
   // Tear down a plugin's contributions AND remove it from the registry. The
   // two steps always move together on the bootstrap failure path: the former
   // clears tools/routes/skills (so they stop appearing to the model/HTTP
-  // server), the latter drops the plugin's entry from the Map (so
-  // `getMiddlewaresFor` / `getInjectors` don't re-enter an uninitialized
-  // plugin on the next pipeline invocation).
+  // server), the latter drops the plugin's entry from the Map (so the registry
+  // doesn't expose an uninitialized plugin's hooks).
   // Shutdown context is identical for every plugin in this boot — construct
   // once and reuse across the bootstrap-failure rollback and the normal
   // shutdown hook below. Only `assistantVersion` is exposed today; future

package/src/daemon/handlers/config-a2a.ts

@@ -10,6 +10,8 @@
  * - acceptA2AInvite()  — self-hosted broker: orchestrate complete + redeem across daemons
  */
 
+import { z } from "zod";
+
 import {
   getConfig,
   invalidateConfigCache,
@@ -38,42 +40,55 @@ const log = getLogger("config-a2a");
 
 // ── Result types ────────────────────────────────────────────────────
 
-export interface A2AConfigResult {
-  success: boolean;
-  enabled: boolean;
-  activeConnections: number;
-  error?: string;
-}
-
-export interface CreateA2AInviteResult {
-  success: boolean;
-  inviteId?: string;
-  token?: string;
-  expiresAt?: number;
-  senderGatewayUrl?: string;
-  error?: string;
-}
-
-export interface CompleteA2AInviteResult {
-  success: boolean;
-  sender?: { assistantId: string; displayName: string; gatewayUrl: string };
-  error?: string;
-}
-
-export interface RedeemA2AInviteResult {
-  success: boolean;
-  contactId?: string;
-  alreadyConnected?: boolean;
-  error?: string;
-}
-
-export interface AcceptA2AInviteResult {
-  success: boolean;
-  contactId?: string;
-  alreadyConnected?: boolean;
-  error?: string;
-  errorCode?: string;
-}
+export const A2AConfigResultSchema = z.object({
+  success: z.boolean(),
+  enabled: z.boolean(),
+  activeConnections: z.number(),
+  error: z.string().optional(),
+});
+export type A2AConfigResult = z.infer<typeof A2AConfigResultSchema>;
+
+export const CreateA2AInviteResultSchema = z.object({
+  success: z.boolean(),
+  inviteId: z.string().optional(),
+  token: z.string().optional(),
+  expiresAt: z.number().optional(),
+  senderGatewayUrl: z.string().optional(),
+  error: z.string().optional(),
+});
+export type CreateA2AInviteResult = z.infer<typeof CreateA2AInviteResultSchema>;
+
+export const CompleteA2AInviteResultSchema = z.object({
+  success: z.boolean(),
+  sender: z
+    .object({
+      assistantId: z.string(),
+      displayName: z.string(),
+      gatewayUrl: z.string(),
+    })
+    .optional(),
+  error: z.string().optional(),
+});
+export type CompleteA2AInviteResult = z.infer<
+  typeof CompleteA2AInviteResultSchema
+>;
+
+export const RedeemA2AInviteResultSchema = z.object({
+  success: z.boolean(),
+  contactId: z.string().optional(),
+  alreadyConnected: z.boolean().optional(),
+  error: z.string().optional(),
+});
+export type RedeemA2AInviteResult = z.infer<typeof RedeemA2AInviteResultSchema>;
+
+export const AcceptA2AInviteResultSchema = z.object({
+  success: z.boolean(),
+  contactId: z.string().optional(),
+  alreadyConnected: z.boolean().optional(),
+  error: z.string().optional(),
+  errorCode: z.string().optional(),
+});
+export type AcceptA2AInviteResult = z.infer<typeof AcceptA2AInviteResultSchema>;
 
 // ── Config operations ───────────────────────────────────────────────
 

package/src/daemon/handlers/config-slack-channel.ts

@@ -1,3 +1,5 @@
+import { z } from "zod";
+
 import {
   getConfig,
   invalidateConfigCache,
@@ -26,20 +28,24 @@ import { log as _log } from "./shared.js";
 
 // -- Result type --
 
-export interface SlackChannelConfigResult {
-  success: boolean;
-  hasBotToken: boolean;
-  hasAppToken: boolean;
-  hasUserToken: boolean;
-  connected: boolean;
-  teamId?: string;
-  teamName?: string;
-  teamUrl?: string;
-  botUserId?: string;
-  botUsername?: string;
-  error?: string;
-  warning?: string;
-}
+export const SlackChannelConfigResultSchema = z.object({
+  success: z.boolean(),
+  hasBotToken: z.boolean(),
+  hasAppToken: z.boolean(),
+  hasUserToken: z.boolean(),
+  connected: z.boolean(),
+  teamId: z.string().optional(),
+  teamName: z.string().optional(),
+  teamUrl: z.string().optional(),
+  botUserId: z.string().optional(),
+  botUsername: z.string().optional(),
+  error: z.string().optional(),
+  warning: z.string().optional(),
+});
+
+export type SlackChannelConfigResult = z.infer<
+  typeof SlackChannelConfigResultSchema
+>;
 
 // -- Helpers --
 

package/src/daemon/handlers/config-telegram.ts

@@ -1,3 +1,5 @@
+import { z } from "zod";
+
 import { getIsPlatform } from "../../config/env-registry.js";
 import {
   invalidateConfigCache,
@@ -26,7 +28,6 @@ import {
   deleteCredentialMetadata,
   upsertCredentialMetadata,
 } from "../../tools/credentials/metadata-store.js";
-import type { TelegramConfigResponse } from "../message-protocol.js";
 import { log } from "./shared.js";
 
 const TELEGRAM_BOT_TOKEN_IN_URL_PATTERN =
@@ -60,7 +61,20 @@ function summarizeTelegramError(err: unknown): string {
 
 // -- Transport-agnostic result type (omits the `type` discriminant) --
 
-export type TelegramConfigResult = Omit<TelegramConfigResponse, "type">;
+export const TelegramConfigResultSchema = z.object({
+  success: z.boolean(),
+  hasBotToken: z.boolean(),
+  botId: z.string().optional(),
+  botUsername: z.string().optional(),
+  connected: z.boolean(),
+  hasWebhookSecret: z.boolean(),
+  lastError: z.string().optional(),
+  error: z.string().optional(),
+  commandsRegistered: z.array(z.string()).optional(),
+  warning: z.string().optional(),
+});
+
+export type TelegramConfigResult = z.infer<typeof TelegramConfigResultSchema>;
 
 // -- Extracted business logic functions --
 

package/src/daemon/handlers/conversations.ts

@@ -8,9 +8,11 @@ import { createAbortReason } from "../../util/abort-reasons.js";
 import { truncate } from "../../util/truncate.js";
 import { regenerate } from "../conversation-history.js";
 import {
-  clearAllActiveConversations,
   conversationEntries,
   findConversation,
+} from "../conversation-registry.js";
+import {
+  clearAllActiveConversations,
   getOrCreateConversation,
   touchConversation,
 } from "../conversation-store.js";