@vellumai/assistant 0.8.6 → 0.8.7

package/src/__tests__/conversation-analysis-routes.test.ts

@@ -95,7 +95,7 @@ describe("POST /v1/conversations/:id/analyze", () => {
       "analysis-1",
       "user",
       expect.any(String),
-      { provenanceTrustClass: "unknown" },
+      { metadata: { provenanceTrustClass: "unknown" } },
     );
     expect(mockConversation.setTrustContext).toHaveBeenCalledWith({
       trustClass: "unknown",
@@ -117,7 +117,6 @@ describe("POST /v1/conversations/:id/analyze", () => {
     expect(mockConversation.runAgentLoop).toHaveBeenCalledWith(
       expect.any(String),
       "msg-1",
-      undefined,
       expect.objectContaining({ isInteractive: false, isUserMessage: true }),
     );
   });
@@ -140,7 +139,6 @@ describe("POST /v1/conversations/:id/analyze", () => {
       expect(mockConversation.runAgentLoop).toHaveBeenCalledWith(
         expect.any(String),
         "msg-1",
-        undefined,
         expect.objectContaining({ isInteractive: false, isUserMessage: true }),
       );
     } finally {

package/src/__tests__/conversation-app-control-lifecycle.test.ts

@@ -148,9 +148,9 @@ function makeConversation(): Conversation {
     "conv-app-control",
     provider,
     "system prompt",
-    4096,
     () => {},
     "/tmp",
+    { maxTokens: 4096 },
   );
   conv.setTrustContext({ trustClass: "guardian", sourceChannel: "vellum" });
   return conv;

package/src/__tests__/conversation-clear-safety.test.ts

@@ -44,9 +44,17 @@ import {
 } from "../memory/conversation-crud.js";
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
-import { enforcePolicy, getPolicy } from "../runtime/auth/route-policy.js";
+import { enforcePolicy } from "../runtime/auth/route-policy.js";
 import type { AuthContext, Scope } from "../runtime/auth/types.js";
 import { ROUTES } from "../runtime/routes/conversation-management-routes.js";
+
+/** Look up a route's policy by endpoint+method on the route module's ROUTES. */
+function routePolicy(endpoint: string, method?: string) {
+  const route = ROUTES.find(
+    (r) => r.endpoint === endpoint && (!method || r.method === method),
+  );
+  return route?.policy ?? null;
+}
 import { BadRequestError } from "../runtime/routes/errors.js";
 
 initializeDb();
@@ -79,43 +87,45 @@ function buildAuthContext(overrides?: {
 // ---------------------------------------------------------------------------
 
 describe("DELETE /v1/conversations — route policy", () => {
-  test("conversations/clear-all requires settings.write scope", () => {
+  test("DELETE /conversations requires settings.write scope", () => {
     authDisabled = false;
-    const policy = getPolicy("conversations/clear-all");
-    expect(policy).toBeDefined();
+    const policy = routePolicy("conversations", "DELETE");
+    expect(policy).not.toBeNull();
     expect(policy!.requiredScopes).toContain("settings.write");
   });
 
   test("chat.write-only token is rejected with 403 for clear-all", () => {
     authDisabled = false;
+    const policy = routePolicy("conversations", "DELETE");
     const ctx = buildAuthContext({
       scopes: ["chat.read", "chat.write"],
     });
-    const result = enforcePolicy("conversations/clear-all", ctx);
+    const result = enforcePolicy("conversations", policy, ctx);
     expect(result).not.toBeNull();
     expect(result!.status).toBe(403);
   });
 
   test("settings.write token is allowed through clear-all policy", () => {
     authDisabled = false;
+    const policy = routePolicy("conversations", "DELETE");
     const ctx = buildAuthContext({
       scopes: ["settings.write"],
     });
-    const result = enforcePolicy("conversations/clear-all", ctx);
+    const result = enforcePolicy("conversations", policy, ctx);
     expect(result).toBeNull();
   });
 
-  test("single-conversation DELETE (conversations:DELETE) only requires chat.write", () => {
+  test("single-conversation DELETE only requires chat.write", () => {
     authDisabled = false;
-    const policy = getPolicy("conversations:DELETE");
-    expect(policy).toBeDefined();
+    const policy = routePolicy("conversations/:id", "DELETE");
+    expect(policy).not.toBeNull();
     expect(policy!.requiredScopes).toContain("chat.write");
     expect(policy!.requiredScopes).not.toContain("settings.write");
 
     const ctx = buildAuthContext({
       scopes: ["chat.read", "chat.write"],
     });
-    const result = enforcePolicy("conversations:DELETE", ctx);
+    const result = enforcePolicy("conversations/:id", policy, ctx);
     expect(result).toBeNull();
   });
 });

package/src/__tests__/conversation-confirmation-signals.test.ts

@@ -11,11 +11,8 @@
  */
 import { describe, expect, mock, test } from "bun:test";
 
-import type {
-  AgentEvent,
-  CheckpointDecision,
-  CheckpointInfo,
-} from "../agent/loop.js";
+import { CompactionCircuit } from "../agent/compaction-circuit.js";
+import type { AgentEvent } from "../agent/loop.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { Message, ProviderResponse } from "../providers/types.js";
 
@@ -191,6 +188,7 @@ mock.module("../memory/llm-usage-store.js", () => ({
 
 mock.module("../agent/loop.js", () => ({
   AgentLoop: class {
+    compactionCircuit = new CompactionCircuit("test-conv");
     constructor() {}
     getToolTokenBudget() {
       return 0;
@@ -204,11 +202,6 @@ mock.module("../agent/loop.js", () => ({
     async run(
       _messages: Message[],
       _onEvent: (event: AgentEvent) => void,
-      _signal?: AbortSignal,
-      _requestId?: string,
-      _onCheckpoint?: (
-        checkpoint: CheckpointInfo,
-      ) => CheckpointDecision | Promise<CheckpointDecision>,
     ): Promise<Message[]> {
       return [];
     }
@@ -266,9 +259,9 @@ function makeConversation(
     "conv-signals-test",
     makeProvider(),
     "system prompt",
-    4096,
     sendToClient ?? (() => {}),
     process.env.VELLUM_WORKSPACE_DIR!,
+    { maxTokens: 4096 },
   );
 }
 
@@ -375,17 +368,12 @@ describe("centralized confirmation emissions", () => {
     const conversation = makeConversation((msg) => emitted.push(msg));
 
     seedPendingConfirmation(conversation, "req-ctx-1");
-    conversation.handleConfirmationResponse(
-      "req-ctx-1",
-      "allow",
-      undefined,
-      undefined,
-      undefined,
-      {
+    conversation.handleConfirmationResponse("req-ctx-1", "allow", {
+      emissionContext: {
         source: "inline_nl",
         decisionText: "yes please",
       },
-    );
+    });
 
     const confirmMsg = emitted.find(
       (m) =>
@@ -406,22 +394,12 @@ describe("activity version ordering", () => {
     const emitted: ServerMessage[] = [];
     const conversation = makeConversation((msg) => emitted.push(msg));
 
-    conversation.emitActivityState(
-      "thinking",
-      "message_dequeued",
-      "assistant_turn",
-    );
-    conversation.emitActivityState(
-      "streaming",
-      "first_text_delta",
-      "assistant_turn",
-    );
-    conversation.emitActivityState(
-      "tool_running",
-      "tool_use_start",
-      "assistant_turn",
-    );
-    conversation.emitActivityState("idle", "message_complete", "global");
+    conversation.emitActivityState("thinking", "message_dequeued");
+    conversation.emitActivityState("streaming", "first_text_delta");
+    conversation.emitActivityState("tool_running", "tool_use_start");
+    conversation.emitActivityState("idle", "message_complete", {
+      anchor: "global",
+    });
 
     const activityMsgs = emitted.filter(
       (m) => m.type === "assistant_activity_state",
@@ -445,11 +423,7 @@ describe("activity version ordering", () => {
     const conversation = makeConversation((msg) => emitted.push(msg));
 
     // Emit a baseline activity state
-    conversation.emitActivityState(
-      "thinking",
-      "message_dequeued",
-      "assistant_turn",
-    );
+    conversation.emitActivityState("thinking", "message_dequeued");
 
     const baselineMsg = emitted.find(
       (m) => m.type === "assistant_activity_state",
@@ -478,11 +452,7 @@ describe("sendToClient receives state signals", () => {
     const clientMsgs: ServerMessage[] = [];
     const conversation = makeConversation((msg) => clientMsgs.push(msg));
 
-    conversation.emitActivityState(
-      "thinking",
-      "message_dequeued",
-      "assistant_turn",
-    );
+    conversation.emitActivityState("thinking", "message_dequeued");
 
     expect(
       clientMsgs.filter((m) => m.type === "assistant_activity_state"),

package/src/__tests__/conversation-disk-view-integration.test.ts

@@ -127,7 +127,7 @@ describe("addMessage + syncMessageToDisk → disk view", () => {
   test("appends JSONL line for a text message", async () => {
     const conv = createConversation("Msg Test");
 
-    const msg = await addMessage(conv.id, "user", "Hello world", undefined, {
+    const msg = await addMessage(conv.id, "user", "Hello world", {
       skipIndexing: true,
     });
 
@@ -149,7 +149,7 @@ describe("addMessage + syncMessageToDisk → disk view", () => {
   test("message with attachment copies file and includes in JSONL", async () => {
     const conv = createConversation("Attach Test");
 
-    const msg = await addMessage(conv.id, "user", "See attached", undefined, {
+    const msg = await addMessage(conv.id, "user", "See attached", {
       skipIndexing: true,
     });
 

package/src/__tests__/conversation-disk-view.test.ts

@@ -387,13 +387,9 @@ describe("syncMessageToDisk", () => {
       originChannel: null,
     });
 
-    const msg = await addMessage(
-      conv.id,
-      "user",
-      "Hello, assistant!",
-      undefined,
-      { skipIndexing: true },
-    );
+    const msg = await addMessage(conv.id, "user", "Hello, assistant!", {
+      skipIndexing: true,
+    });
 
     syncMessageToDisk(conv.id, msg.id, conv.createdAt);
 
@@ -429,7 +425,7 @@ describe("syncMessageToDisk", () => {
       { type: "tool_use", name: "image_resize", input: { width: 800 } },
     ]);
 
-    const msg = await addMessage(conv.id, "assistant", content, undefined, {
+    const msg = await addMessage(conv.id, "assistant", content, {
       skipIndexing: true,
     });
 
@@ -458,7 +454,7 @@ describe("syncMessageToDisk", () => {
       originChannel: null,
     });
 
-    const msg = await addMessage(conv.id, "user", "See attached", undefined, {
+    const msg = await addMessage(conv.id, "user", "See attached", {
       skipIndexing: true,
     });
 
@@ -491,10 +487,10 @@ describe("syncMessageToDisk", () => {
       originChannel: null,
     });
 
-    const msg1 = await addMessage(conv.id, "user", "First", undefined, {
+    const msg1 = await addMessage(conv.id, "user", "First", {
       skipIndexing: true,
     });
-    const msg2 = await addMessage(conv.id, "assistant", "Second", undefined, {
+    const msg2 = await addMessage(conv.id, "assistant", "Second", {
       skipIndexing: true,
     });
 
@@ -523,7 +519,7 @@ describe("syncMessageToDisk", () => {
     );
     mkdirSync(legacyDirPath, { recursive: true });
 
-    const msg = await addMessage(conv.id, "user", "Legacy path", undefined, {
+    const msg = await addMessage(conv.id, "user", "Legacy path", {
       skipIndexing: true,
     });
 
@@ -551,7 +547,7 @@ describe("syncMessageToDisk", () => {
       originChannel: null,
     });
 
-    const msg = await addMessage(conv.id, "user", "Disk repair", undefined, {
+    const msg = await addMessage(conv.id, "user", "Disk repair", {
       skipIndexing: true,
     });
     const att = uploadAttachment("repair.png", "image/png", "iVBORw0K");
@@ -607,14 +603,13 @@ describe("rebuildConversationDiskViewFromDbState", () => {
       originChannel: null,
     });
 
-    const userMsg = await addMessage(conv.id, "user", "find docs", undefined, {
+    const userMsg = await addMessage(conv.id, "user", "find docs", {
       skipIndexing: true,
     });
     const assistantPart1 = await addMessage(
       conv.id,
       "assistant",
       JSON.stringify([{ type: "text", text: "Searching..." }]),
-      undefined,
       { skipIndexing: true },
     );
     const internalToolResult = await addMessage(
@@ -623,14 +618,12 @@ describe("rebuildConversationDiskViewFromDbState", () => {
       JSON.stringify([
         { type: "tool_result", tool_use_id: "tool-1", content: "done" },
       ]),
-      undefined,
       { skipIndexing: true },
     );
     const assistantPart2 = await addMessage(
       conv.id,
       "assistant",
       JSON.stringify([{ type: "text", text: "Found it." }]),
-      undefined,
       { skipIndexing: true },
     );