@vellumai/assistant 0.8.5 → 0.8.7

package/src/__tests__/avatar-identity-sync.test.ts

@@ -4,7 +4,10 @@ import { SYNC_TAGS } from "../daemon/message-types/sync.js";
 import type { AssistantEvent } from "../runtime/assistant-event.js";
 import { assistantEventHub } from "../runtime/assistant-event-hub.js";
 import { ROUTES as AVATAR_ROUTES } from "../runtime/routes/avatar-routes.js";
-import { publishIdentityChanged } from "../runtime/sync/resource-sync-events.js";
+import {
+  publishIdentityChanged,
+  publishIdentityIntroChanged,
+} from "../runtime/sync/resource-sync-events.js";
 
 async function waitFor(predicate: () => boolean): Promise<void> {
   const deadline = Date.now() + 500;
@@ -49,7 +52,7 @@ describe("avatar and identity sync events", () => {
     }
   });
 
-  test("identity changes emit legacy identity event and sync tag", async () => {
+  test("identity changes emit legacy identity event and identity sync tags", async () => {
     const received: AssistantEvent[] = [];
     const subscription = assistantEventHub.subscribe({
       type: "process",
@@ -78,7 +81,29 @@ describe("avatar and identity sync events", () => {
       });
       expect(received[1].message).toEqual({
         type: "sync_changed",
-        tags: [SYNC_TAGS.assistantIdentity],
+        tags: [SYNC_TAGS.assistantIdentity, SYNC_TAGS.assistantIdentityIntro],
+      });
+    } finally {
+      subscription.dispose();
+    }
+  });
+
+  test("identity intro changes emit only the identity intro sync tag", async () => {
+    const received: AssistantEvent[] = [];
+    const subscription = assistantEventHub.subscribe({
+      type: "process",
+      callback: (event) => {
+        received.push(event);
+      },
+    });
+
+    try {
+      publishIdentityIntroChanged();
+      await waitFor(() => received.length === 1);
+
+      expect(received[0].message).toEqual({
+        type: "sync_changed",
+        tags: [SYNC_TAGS.assistantIdentityIntro],
       });
     } finally {
       subscription.dispose();

package/src/__tests__/background-shell-bash.test.ts

@@ -2,7 +2,6 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 
 import type { WakeOptions } from "../runtime/agent-wake.js";
 import type { BackgroundTool } from "../tools/background-tool-registry.js";
-import type { Tool } from "../tools/types.js";
 
 // ── Mock modules ────────────────────────────────────────────────────────────
 
@@ -88,6 +87,8 @@ mock.module("../tools/background-tool-registry.js", () => ({
 
 // ── Imports (after mocks) ───────────────────────────────────────────────────
 
+import { shellTool } from "../tools/terminal/shell.js";
+
 const baseContext = {
   workingDir: process.env.VELLUM_WORKSPACE_DIR ?? "/tmp",
   conversationId: "conv-bg-test",
@@ -117,9 +118,7 @@ function waitForWake(
 }
 
 describe("bash tool background mode", () => {
-  let shellTool: Tool;
-
-  beforeEach(async () => {
+  beforeEach(() => {
     mockWakeAgentForOpportunity.mockClear();
     mockRegisterBackgroundTool.mockClear();
     mockRemoveBackgroundTool.mockClear();
@@ -128,9 +127,6 @@ describe("bash tool background mode", () => {
     mockIsBackgroundToolLimitReached.mockClear();
     mockIsBackgroundToolLimitReached.mockReturnValue(false);
     registeredTools.length = 0;
-
-    const mod = await import("../tools/terminal/shell.js");
-    shellTool = mod.shellTool;
   });
 
   afterEach(() => {

package/src/__tests__/background-workers-disk-pressure.test.ts

@@ -1,5 +1,7 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
+import { createMockLoggerModule } from "./helpers/mock-logger.js";
+
 // Default the warm-pool gate to OPEN — these tests probe background-job
 // disk-pressure behavior, not the pre-first-message guard.
 mock.module("../runtime/pre-first-message-gate.js", () => ({
@@ -7,14 +9,7 @@ mock.module("../runtime/pre-first-message-gate.js", () => ({
   _resetPreFirstMessageGateCacheForTests: () => {},
 }));
 
-mock.module("../util/logger.js", () => ({
-  getLogger: () => ({
-    info: () => {},
-    debug: () => {},
-    warn: () => {},
-    error: () => {},
-  }),
-}));
+mock.module("../util/logger.js", () => createMockLoggerModule());
 
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
@@ -157,6 +152,8 @@ mock.module("../memory/conversation-crud.js", () => ({
   setLastNotifiedInferenceProfile: mock(() => {}),
   setConversationHistoryStrippedAt: mock(() => {}),
   wipeConversation: mock(() => ({ memoryIds: [] })),
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
+  extractImageSourcePaths: () => undefined,
 }));
 
 mock.module("../memory/conversation-title-service.js", () => ({

package/src/__tests__/browser-skill-endstate.test.ts

@@ -12,7 +12,6 @@ mock.module("../config/loader.js", () => ({
 
 import { BROWSER_OPERATION_META } from "../browser/operations.js";
 import { BROWSER_OPERATIONS } from "../browser/types.js";
-import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
 import {
   projectSkillTools,
   resetSkillToolProjection,
@@ -23,6 +22,7 @@ import {
   getAllTools,
   initializeTools,
 } from "../tools/registry.js";
+import { setOverridesForTesting } from "./feature-flag-test-helpers.js";
 import {
   BROWSER_SKILL_ID,
   buildSkillLoadHistory,
@@ -30,13 +30,13 @@ import {
 
 afterAll(() => {
   __resetRegistryForTesting();
-  _setOverridesForTesting({});
+  setOverridesForTesting({});
 });
 
 describe("browser CLI-only architecture end-state", () => {
   beforeAll(async () => {
     __resetRegistryForTesting();
-    _setOverridesForTesting({
+    setOverridesForTesting({
       browser: true,
     });
     await initializeTools();

package/src/__tests__/btw-routes.test.ts

@@ -38,6 +38,7 @@ const mockAddMessage = mock(() => {});
 
 mock.module("../memory/conversation-crud.js", () => ({
   addMessage: mockAddMessage,
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 const MOCK_TOOLS = [
@@ -48,8 +49,8 @@ const MOCK_TOOLS = [
   },
 ];
 
-mock.module("../daemon/conversation-tool-setup.js", () => ({
-  buildToolDefinitions: () => MOCK_TOOLS,
+mock.module("../tools/registry.js", () => ({
+  getAllToolDefinitions: () => MOCK_TOOLS,
 }));
 
 const MOCK_SYSTEM_PROMPT = "You are a helpful assistant.";
@@ -130,16 +131,12 @@ import type { RouteHandlerArgs } from "../runtime/routes/types.js";
 function makeMockProvider(
   onSendMessage?: (
     messages: unknown[],
-    tools: unknown[],
-    systemPrompt: string | undefined,
-    options: SendMessageOptions | undefined,
+    options?: SendMessageOptions,
   ) => Promise<ProviderResponse>,
 ) {
   const defaultSendMessage = async (
     _messages: unknown[],
-    _tools: unknown[],
-    _systemPrompt: string | undefined,
-    options: SendMessageOptions | undefined,
+    options?: SendMessageOptions,
   ): Promise<ProviderResponse> => {
     options?.onEvent?.({ type: "text_delta", text: "hello" });
     return {
@@ -298,8 +295,7 @@ describe("POST /v1/btw", () => {
 
     expect(provider.sendMessage).toHaveBeenCalledTimes(1);
 
-    const [messages, tools, systemPrompt, options] =
-      provider.sendMessage.mock.calls[0];
+    const [messages, options] = provider.sendMessage.mock.calls[0];
 
     expect(messages).toHaveLength(3);
     expect(messages[0]).toEqual({
@@ -315,8 +311,8 @@ describe("POST /v1/btw", () => {
       content: [{ type: "text", text: "my question" }],
     });
 
-    expect(tools).toEqual(MOCK_TOOLS);
-    expect(systemPrompt).toBe(MOCK_SYSTEM_PROMPT);
+    expect(options!.tools).toEqual(MOCK_TOOLS);
+    expect(options!.systemPrompt).toBe(MOCK_SYSTEM_PROMPT);
     // Persona is resolved internally now; btw-routes no longer plumbs
     // it through to buildSystemPrompt.
     expect(mockBuildSystemPrompt).toHaveBeenCalledWith({
@@ -340,7 +336,7 @@ describe("POST /v1/btw", () => {
     await readStream(result as ReadableStream<Uint8Array>);
 
     expect(provider.sendMessage).toHaveBeenCalledTimes(1);
-    const [, , , options] = provider.sendMessage.mock.calls[0];
+    const [, options] = provider.sendMessage.mock.calls[0];
     expect(options!.config!.callSite).toBe("emptyStateGreeting");
   });
 
@@ -356,7 +352,7 @@ describe("POST /v1/btw", () => {
     await readStream(result as ReadableStream<Uint8Array>);
 
     expect(provider.sendMessage).toHaveBeenCalledTimes(1);
-    const [, , , options] = provider.sendMessage.mock.calls[0];
+    const [, options] = provider.sendMessage.mock.calls[0];
     expect(options!.config!.callSite).toBe("identityIntro");
   });
 

package/src/__tests__/call-controller.test.ts

@@ -252,16 +252,17 @@ import {
   getPendingCanonicalRequestByCallSessionId,
 } from "../memory/canonical-guardian-store.js";
 import { getMessages } from "../memory/conversation-crud.js";
-import { getDb, resetDb } from "../memory/db-connection.js";
+import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { resetTestTables } from "../memory/raw-query.js";
 import { conversations } from "../memory/schema.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 initializeDb();
 
 afterAll(() => {
-  resetDb();
+  resetDbForTesting();
 });
 
 // ── CallTransport mock factory ───────────────────────────────────────

package/src/__tests__/call-pointer-messages.test.ts

@@ -314,7 +314,7 @@ describe("addPointerMessage", () => {
     ensureConversation(convId);
     // Add a user message with guardian provenance metadata
     await addMessage(convId, "user", "hello", {
-      provenanceTrustClass: "guardian",
+      metadata: { provenanceTrustClass: "guardian" },
     });
 
     let processorCalled = false;
@@ -331,7 +331,7 @@ describe("addPointerMessage", () => {
     ensureConversation(convId);
     // Add a user message with trusted_contact provenance metadata
     await addMessage(convId, "user", "hello", {
-      provenanceTrustClass: "trusted_contact",
+      metadata: { provenanceTrustClass: "trusted_contact" },
     });
 
     let processorCalled = false;
@@ -346,7 +346,9 @@ describe("addPointerMessage", () => {
   test("unknown provenance trust class does not grant trusted audience", () => {
     const convId = "conv-ptr-unknown-provenance";
     ensureConversation(convId);
-    addMessage(convId, "user", "hello", { provenanceTrustClass: "unknown" });
+    addMessage(convId, "user", "hello", {
+      metadata: { provenanceTrustClass: "unknown" },
+    });
 
     const processorCalled = { value: false };
     setPointerMessageProcessor(async () => {

package/src/__tests__/call-site-routing-provider.test.ts

@@ -58,7 +58,7 @@ function makeProvider(
 ): Provider {
   return {
     name,
-    async sendMessage(_messages, _tools, _systemPrompt, options) {
+    async sendMessage(_messages: Message[], options?: SendMessageOptions) {
       onCall(options);
       return makeResponse(name);
     },
@@ -118,10 +118,7 @@ describe("CallSiteRoutingProvider", () => {
     );
 
     const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      // No callSite — must hit default even though `memoryRetrieval` is
+      DUMMY_MESSAGES, // No callSite — must hit default even though `memoryRetrieval` is
       // configured for openai.
       { config: {} },
     );
@@ -154,7 +151,7 @@ describe("CallSiteRoutingProvider", () => {
       makeConnectionHook({ "openai-conn": altProvider }),
     );
 
-    await wrapped.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await wrapped.sendMessage(DUMMY_MESSAGES, {
       config: { callSite: "memoryRetrieval" },
     });
 
@@ -190,12 +187,9 @@ describe("CallSiteRoutingProvider", () => {
       makeConnectionHook({ "openai-conn": altProvider }),
     );
 
-    const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      { config: { callSite: "memoryRetrieval" } },
-    );
+    const response = await wrapped.sendMessage(DUMMY_MESSAGES, {
+      config: { callSite: "memoryRetrieval" },
+    });
 
     expect(calls.default).toBe(0);
     expect(calls.alt).toBe(1);
@@ -229,12 +223,9 @@ describe("CallSiteRoutingProvider", () => {
       async () => null,
     );
 
-    const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      { config: { callSite: "memoryRetrieval" } },
-    );
+    const response = await wrapped.sendMessage(DUMMY_MESSAGES, {
+      config: { callSite: "memoryRetrieval" },
+    });
 
     expect(calls.default).toBe(1);
     expect(response.model).toBe("anthropic");
@@ -265,7 +256,7 @@ describe("CallSiteRoutingProvider", () => {
 
     let caught: unknown;
     try {
-      await wrapped.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+      await wrapped.sendMessage(DUMMY_MESSAGES, {
         config: { callSite: "memoryRetrieval" },
       });
     } catch (err) {
@@ -301,12 +292,9 @@ describe("CallSiteRoutingProvider", () => {
       makeConnectionHook({ "openai-conn": altProvider }),
     );
 
-    const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      { config: { callSite: "memoryRetrieval" } },
-    );
+    const response = await wrapped.sendMessage(DUMMY_MESSAGES, {
+      config: { callSite: "memoryRetrieval" },
+    });
 
     // actualProvider must reflect the alternative, not the default, so that
     // loop.ts / emitUsage / llm_call_finished log and bill the correct
@@ -346,12 +334,9 @@ describe("CallSiteRoutingProvider", () => {
       makeConnectionHook({ "openai-conn": altProvider }),
     );
 
-    const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      { config: { callSite: "memoryRetrieval" } },
-    );
+    const response = await wrapped.sendMessage(DUMMY_MESSAGES, {
+      config: { callSite: "memoryRetrieval" },
+    });
 
     expect(response.actualProvider).toBe("openai-via-proxy");
   });
@@ -368,12 +353,9 @@ describe("CallSiteRoutingProvider", () => {
       makeConnectionHook({}),
     );
 
-    const response = await wrapped.sendMessage(
-      DUMMY_MESSAGES,
-      undefined,
-      undefined,
-      { config: { callSite: "memoryRetrieval" } },
-    );
+    const response = await wrapped.sendMessage(DUMMY_MESSAGES, {
+      config: { callSite: "memoryRetrieval" },
+    });
 
     // No alternative was resolved — actualProvider should stay unset.
     expect(response.actualProvider).toBeUndefined();
@@ -434,7 +416,7 @@ describe("CallSiteRoutingProvider", () => {
     );
 
     expect(wrapped.name).toBe("anthropic"); // idle → default
-    await wrapped.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    await wrapped.sendMessage(DUMMY_MESSAGES, {
       config: { callSite: "memoryRetrieval" },
     });
     expect(namesDuringCall).toEqual(["openai"]); // mid-call → routed provider
@@ -511,10 +493,10 @@ describe("CallSiteRoutingProvider", () => {
     );
 
     // Start both calls concurrently (do not await yet).
-    const callA = wrapped.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    const callA = wrapped.sendMessage(DUMMY_MESSAGES, {
       config: { callSite: "memoryRetrieval" }, // → openai
     });
-    const callB = wrapped.sendMessage(DUMMY_MESSAGES, undefined, undefined, {
+    const callB = wrapped.sendMessage(DUMMY_MESSAGES, {
       config: { callSite: "conversationTitle" }, // → fireworks
     });
 

package/src/__tests__/catalog-files.test.ts

@@ -963,6 +963,7 @@ describe("createVellumCatalogProvider", () => {
     expect(slim!.kind).toBe("catalog");
     expect(slim!.origin).toBe("vellum");
     expect(slim!.status).toBe("available");
+    expect(slim!.category).toBe("knowledge");
   });
 
   test("toSlimSkill returns null for unknown skill", async () => {

package/src/__tests__/channel-approval-routes.test.ts

@@ -76,7 +76,7 @@ import {
   createCanonicalGuardianRequest,
   getCanonicalGuardianRequest,
 } from "../memory/canonical-guardian-store.js";
-import { getDb, resetDb } from "../memory/db-connection.js";
+import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import * as deliveryChannels from "../memory/delivery-channels.js";
 import {
@@ -90,6 +90,7 @@ import * as gatewayClient from "../runtime/gateway-client.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import { sweepExpiredGuardianApprovals } from "../runtime/routes/channel-guardian-routes.js";
 import { _setTestPollMaxWait } from "../runtime/routes/channel-route-shared.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 import { handleChannelInbound } from "./helpers/channel-test-adapter.js";
 import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
@@ -97,7 +98,7 @@ initializeDb();
 initAuthSigningKey(Buffer.from("test-signing-key-at-least-32-bytes-long"));
 
 afterAll(() => {
-  resetDb();
+  resetDbForTesting();
 });
 
 // ---------------------------------------------------------------------------
@@ -324,7 +325,9 @@ describe("inbound callback metadata triggers decision handling", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-cb-1", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-cb-1", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -361,7 +364,9 @@ describe("inbound callback metadata triggers decision handling", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-cb-2", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-cb-2", "deny", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -409,7 +414,9 @@ describe("inbound text matching approval phrases triggers decision handling", ()
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-txt-1", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-txt-1", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -553,7 +560,9 @@ describe("empty content with callbackData bypasses validation", () => {
     const body = (await res.json()) as Record<string, unknown>;
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-empty-1", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-empty-1", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -695,7 +704,9 @@ describe("callback requestId validation", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-match", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-match", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -729,7 +740,9 @@ describe("callback requestId validation", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-plaintext", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-plaintext", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -932,7 +945,9 @@ describe("plain-text channel approval decisions", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-pt-1", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-pt-1", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -965,7 +980,9 @@ describe("plain-text channel approval decisions", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-pt-2", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-pt-2", "deny", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -1097,7 +1114,9 @@ describe("guardian decision scoping — multiple pending approvals", () => {
     expect(body.approval).toBe("guardian_decision_applied");
 
     // The older request's session should have been called
-    expect(olderSession).toHaveBeenCalledWith("req-older", "allow");
+    expect(olderSession).toHaveBeenCalledWith("req-older", "allow", {
+      decisionContext: undefined,
+    });
 
     // The newer request's session should NOT have been called
     expect(newerSession).not.toHaveBeenCalled();
@@ -1243,7 +1262,9 @@ describe("expired guardian approval auto-denies via sweep", () => {
     await new Promise((resolve) => setTimeout(resolve, 10));
 
     // The session should have been denied
-    expect(sessionMock).toHaveBeenCalledWith("req-exp-1", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-exp-1", "deny", {
+      decisionContext: undefined,
+    });
 
     // Both requester and guardian should have been notified
     const requesterNotify = deliverSpy.mock.calls.filter(
@@ -1456,7 +1477,9 @@ describe("conversational approval engine — standard path", () => {
     expect(body.approval).toBe("decision_applied");
 
     // The session should have received an allow decision
-    expect(sessionMock).toHaveBeenCalledWith("req-conv-2", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-conv-2", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -1503,7 +1526,9 @@ describe("conversational approval engine — standard path", () => {
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
 
-    expect(sessionMock).toHaveBeenCalledWith("req-conv-3", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-conv-3", "deny", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -1555,7 +1580,9 @@ describe("conversational approval engine — standard path", () => {
 
     // The callback button should have been used directly, not the engine
     expect(mockConversationGenerator).not.toHaveBeenCalled();
-    expect(sessionMock).toHaveBeenCalledWith("req-conv-4", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-conv-4", "allow", {
+      decisionContext: undefined,
+    });
 
     deliverSpy.mockRestore();
   });
@@ -1704,7 +1731,9 @@ describe("guardian conversational approval via conversation engine", () => {
     expect(body.approval).toBe("guardian_decision_applied");
 
     // The session should have received an 'allow' decision
-    expect(sessionMock).toHaveBeenCalledWith("req-gnlp-1", "allow");
+    expect(sessionMock).toHaveBeenCalledWith("req-gnlp-1", "allow", {
+      decisionContext: undefined,
+    });
 
     // The approval record should have been updated (no longer pending)
     const pending = getAllPendingApprovalsByGuardianChat(
@@ -2096,7 +2125,9 @@ describe("requester cancel of guardian-gated pending request", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-cancel-1", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-cancel-1", "deny", {
+      decisionContext: undefined,
+    });
 
     // Requester should have been notified
     const requesterReply = deliverSpy.mock.calls.find(
@@ -2177,7 +2208,9 @@ describe("requester cancel of guardian-gated pending request", () => {
 
     expect(body.accepted).toBe(true);
     expect(body.approval).toBe("decision_applied");
-    expect(sessionMock).toHaveBeenCalledWith("req-cancel-2", "deny");
+    expect(sessionMock).toHaveBeenCalledWith("req-cancel-2", "deny", {
+      decisionContext: undefined,
+    });
 
     // Engine should have been called with reject-only allowed actions
     expect(mockConversationGenerator).toHaveBeenCalledTimes(1);
@@ -2604,7 +2637,6 @@ describe("background channel processing approval prompts", () => {
       async (
         conversationId: string,
         _content: string,
-        _attachmentIds?: string[],
         options?: Record<string, unknown>,
       ) => {
         processCalls.push({ options });
@@ -2665,7 +2697,6 @@ describe("background channel processing approval prompts", () => {
       async (
         conversationId: string,
         _content: string,
-        _attachmentIds?: string[],
         options?: Record<string, unknown>,
       ) => {
         processCalls.push({ options });
@@ -2723,7 +2754,6 @@ describe("background channel processing approval prompts", () => {
       async (
         _conversationId: string,
         _content: string,
-        _attachmentIds?: string[],
         options?: Record<string, unknown>,
       ) => {
         processCalls.push({ options });
@@ -2764,7 +2794,6 @@ describe("background channel processing approval prompts", () => {
       async (
         conversationId: string,
         _content: string,
-        _attachmentIds?: string[],
         options?: Record<string, unknown>,
       ) => {
         processCalls.push({ options });