@vellumai/assistant 0.8.5 → 0.8.6

package/src/__tests__/document-tool-security.test.ts

@@ -1,7 +1,7 @@
 import { beforeEach, describe, expect, test } from "bun:test";
 
 import { getDocumentById } from "../documents/document-store.js";
-import { getSqlite, resetDb } from "../memory/db-connection.js";
+import { getSqlite } from "../memory/db-connection.js";
 import {
   executeDocumentDelete,
   executeDocumentList,
@@ -9,6 +9,7 @@ import {
   executeDocumentUpdate,
 } from "../tools/document/document-tool.js";
 import type { ToolContext, ToolExecutionResult } from "../tools/types.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 function makeContext(overrides: Partial<ToolContext> = {}): ToolContext {
   return {
@@ -25,7 +26,7 @@ function parseResult<T>(result: ToolExecutionResult): T {
 }
 
 function bootstrapDocumentTables(): void {
-  resetDb();
+  resetDbForTesting();
   const raw = getSqlite();
   raw.exec(/*sql*/ `
     DROP TABLE IF EXISTS document_conversations;
@@ -256,3 +257,81 @@ describe("document tool security", () => {
     expect(getDocumentById("doc-current")).toBeNull();
   });
 });
+
+describe("executeDocumentUpdate — input validation", () => {
+  beforeEach(() => {
+    bootstrapDocumentTables();
+    seedFixtureDocuments();
+  });
+
+  test("returns Invalid input when surface_id is missing", () => {
+    const result = executeDocumentUpdate({}, makeContext());
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).toContain("Invalid input: surface_id is required");
+    expect(body.error).not.toContain("Document not found");
+  });
+
+  test("returns Invalid input when content is missing", () => {
+    const result = executeDocumentUpdate(
+      { surface_id: "doc-x" },
+      makeContext(),
+    );
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).toBe(
+      "Invalid input: content is required and must be a string",
+    );
+  });
+
+  test("allows empty string content (falls through to access check)", () => {
+    const result = executeDocumentUpdate(
+      { surface_id: "doc-x", content: "" },
+      makeContext(),
+    );
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    // Did NOT fail input validation; fell through to access/not-found path.
+    expect(body.error).toBe("Document not found");
+  });
+
+  test("returns Invalid input when mode is not replace or append", () => {
+    const result = executeDocumentUpdate(
+      { surface_id: "doc-x", content: "hi", mode: "bogus" },
+      makeContext(),
+    );
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).toBe(
+      'Invalid input: mode must be "replace" or "append"',
+    );
+  });
+
+  test("treats mode: null the same as undefined (factory validator accepts both)", () => {
+    // validateInputAgainstSchema treats null as "absent" for enum checks, so
+    // the executor must agree — { mode: null } should fall through to the
+    // access check, not return a confusing 'mode must be ...' error.
+    const result = executeDocumentUpdate(
+      { surface_id: "doc-x", content: "hi", mode: null },
+      makeContext(),
+    );
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).not.toContain("Invalid input: mode");
+    expect(body.error).toBe("Document not found");
+  });
+
+  test("executeDocumentRead returns Invalid input when surface_id is missing", () => {
+    const result = executeDocumentRead({}, makeContext());
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).toContain("Invalid input: surface_id is required");
+  });
+
+  test("executeDocumentDelete returns Invalid input when surface_id is missing", () => {
+    const result = executeDocumentDelete({}, makeContext());
+    expect(result.isError).toBe(true);
+    const body = parseResult<{ error: string }>(result);
+    expect(body.error).toContain("Invalid input: surface_id is required");
+  });
+});

package/src/__tests__/dynamic-skill-workflow-prompt.test.ts

@@ -46,18 +46,19 @@ mock.module("../config/loader.js", () => ({
 }));
 
 const { buildSystemPrompt } = await import("../prompts/system-prompt.js");
-const { _setOverridesForTesting } =
-  await import("../config/assistant-feature-flags.js");
+const { setOverridesForTesting } = await import(
+  "./feature-flag-test-helpers.js"
+);
 
 describe("Dynamic Skill Authoring Workflow moved to tool descriptions", () => {
   beforeEach(() => {
-    _setOverridesForTesting({
+    setOverridesForTesting({
       browser: true,
     });
   });
 
   afterEach(() => {
-    _setOverridesForTesting({});
+    setOverridesForTesting({});
   });
 
   test("system prompt no longer contains Dynamic Skill Authoring section", () => {

package/src/__tests__/encrypted-store-test-helpers.ts

@@ -0,0 +1,56 @@
+/**
+ * Test-only utilities for overriding the encrypted credential store paths.
+ *
+ * Replaces the removed `_setStorePath` and `_setStoreKeyPath` exports
+ * from `encrypted-store.ts`. Lives here (not in the source module)
+ * because production modules should not expose test backdoors.
+ *
+ * No source-module imports
+ * ------------------------
+ * This file has ZERO imports from `src/`. It accesses the store-path
+ * override state via the shared `globalThis.vellumAssistant.storePathOverride`
+ * slot that `src/security/store-path-override.ts` also reads/writes. The
+ * slot shape is duplicated here on purpose: keeping this file off the
+ * production import graph is what protects the test preload from a
+ * broken `node_modules` symlink (DB ghost #3). The two declarations MUST
+ * stay in sync — if you change one, change the other.
+ *
+ * Most tests no longer need these overrides: the test preload places
+ * `VELLUM_WORKSPACE_DIR` at `<tmpRoot>/workspace`, so `getProtectedDir()`
+ * resolves to `<tmpRoot>/protected` per process. The setters here exist
+ * for the small set of tests that exercise specific path scenarios
+ * (env-var fallbacks, migration corner cases, etc.).
+ */
+
+// Mirrors `src/security/store-path-override.ts`. Duplicated by design — see
+// the "No source-module imports" section above.
+type PathSlot = {
+  storePath: string | null;
+  storeKeyPath: string | null;
+};
+
+type VellumAssistantNamespace = {
+  storePathOverride?: PathSlot;
+};
+
+function pathSlot(): PathSlot {
+  const g = globalThis as { vellumAssistant?: VellumAssistantNamespace };
+  const ns = (g.vellumAssistant ??= {});
+  return (ns.storePathOverride ??= { storePath: null, storeKeyPath: null });
+}
+
+/**
+ * Override the encrypted store file path. Pass `null` to reset to the
+ * default (`<protectedDir>/keys.enc`).
+ */
+export function setStorePathForTesting(path: string | null): void {
+  pathSlot().storePath = path;
+}
+
+/**
+ * Override the store-key file path. Pass `null` to reset to the default
+ * (`<dirname(storePath)>/store.key`).
+ */
+export function setStoreKeyPathForTesting(path: string | null): void {
+  pathSlot().storeKeyPath = path;
+}

package/src/__tests__/encrypted-store.test.ts

@@ -24,7 +24,7 @@ import {
 } from "bun:test";
 
 // ---------------------------------------------------------------------------
-// Mock only the logger (not platform -- we use _setStorePath instead)
+// Mock only the logger (not platform -- we use setStorePathForTesting instead)
 // ---------------------------------------------------------------------------
 
 mock.module("../util/logger.js", () => ({
@@ -35,13 +35,15 @@ mock.module("../util/logger.js", () => ({
 }));
 
 import {
-  _setStoreKeyPath,
-  _setStorePath,
   deleteKey,
   getKey,
   listKeys,
   setKey,
 } from "../security/encrypted-store.js";
+import {
+  setStoreKeyPathForTesting,
+  setStorePathForTesting,
+} from "./encrypted-store-test-helpers.js";
 
 // ---------------------------------------------------------------------------
 // Use a temp directory so tests don't touch the real ~/.vellum
@@ -141,13 +143,13 @@ describe("encrypted-store", () => {
     for (const entry of readdirSync(TEST_DIR)) {
       rmSync(join(TEST_DIR, entry), { recursive: true, force: true });
     }
-    _setStorePath(STORE_PATH);
-    _setStoreKeyPath(STORE_KEY_PATH);
+    setStorePathForTesting(STORE_PATH);
+    setStoreKeyPathForTesting(STORE_KEY_PATH);
   });
 
   afterEach(() => {
-    _setStorePath(null);
-    _setStoreKeyPath(null);
+    setStorePathForTesting(null);
+    setStoreKeyPathForTesting(null);
   });
 
   afterAll(() => {
@@ -508,8 +510,8 @@ describe("encrypted-store", () => {
       // Point to a path in a non-existent subdirectory
       const nestedPath = join(TEST_DIR, "sub", "dir", "keys.enc");
       const nestedKeyPath = join(TEST_DIR, "sub", "dir", "store.key");
-      _setStorePath(nestedPath);
-      _setStoreKeyPath(nestedKeyPath);
+      setStorePathForTesting(nestedPath);
+      setStoreKeyPathForTesting(nestedKeyPath);
       const result = setKey("test", "value");
       expect(result).toBe(true);
       expect(getKey("test")).toBe("value");

package/src/__tests__/feature-flag-test-helpers.ts

@@ -0,0 +1,53 @@
+/**
+ * Test-only utilities for seeding the feature flag override cache.
+ *
+ * Replaces the removed `_setOverridesForTesting` export from
+ * `assistant-feature-flags.ts`. Lives here (not in the source module)
+ * because production modules should not expose test backdoors.
+ *
+ * No source-module imports
+ * ------------------------
+ * This file has ZERO imports from `src/`. It accesses the feature flag
+ * cache's state via the shared `globalThis.vellumAssistant.featureFlagCache`
+ * slot that `src/config/feature-flag-cache.ts` also reads/writes. The slot
+ * shape is duplicated here on purpose: keeping this file off the
+ * production import graph is what protects the test preload from a
+ * broken `node_modules` symlink (DB ghost #3). The two declarations MUST
+ * stay in sync — if you change one, change the other.
+ */
+
+// Mirrors `src/config/feature-flag-cache.ts`. Duplicated by design — see
+// the "No source-module imports" section above.
+type FlagSlot = {
+  overrides: Record<string, boolean> | null;
+  fromGateway: boolean;
+};
+
+type VellumAssistantNamespace = {
+  featureFlagCache?: FlagSlot;
+};
+
+function flagSlot(): FlagSlot {
+  const g = globalThis as { vellumAssistant?: VellumAssistantNamespace };
+  const ns = (g.vellumAssistant ??= {});
+  return (ns.featureFlagCache ??= { overrides: null, fromGateway: false });
+}
+
+/**
+ * Synchronously seed the feature flag override cache for the current test.
+ *
+ * Sets the cache to a clone of `overrides` and marks it as
+ * gateway-populated, so subsequent `initFeatureFlagOverrides()` calls are
+ * no-ops (preventing the production retry loop from running during tests).
+ *
+ * Tests that want the gateway IPC retry path to actually run should not
+ * call this — they should leave the cache empty or call
+ * `clearFeatureFlagOverridesCache()` from `assistant-feature-flags.ts`.
+ */
+export function setOverridesForTesting(
+  overrides: Record<string, boolean>,
+): void {
+  const s = flagSlot();
+  s.overrides = { ...overrides };
+  s.fromGateway = true;
+}

package/src/__tests__/filing-service.test.ts

@@ -83,6 +83,7 @@ mock.module("../memory/conversation-crud.js", () => ({
     createdConversations.push(opts);
     return { id: `conv-${++conversationIdCounter}`, ...opts };
   },
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 // Mock logger

package/src/__tests__/first-greeting.test.ts

@@ -96,7 +96,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -108,7 +108,7 @@ describe("first-greeting", () => {
         assistantName: "Remy",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Remy. Good to meet you.\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here.",
+        "Hey Alice, I'm Remy. Good to meet you.\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
       );
     });
 
@@ -119,7 +119,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey, I'm Pax. Let's see what you've got.\n\nWe can jump straight into whatever you've got, or take a few minutes to just talk first. What sounds right?",
+        "Hey, I'm Pax. Let's see what you've got.\n\nWe can jump straight into whatever you've got, or take a few minutes to just talk first. If you've got context or workflows from another assistant or harness, bring them over early and I'll port them with you. What sounds right?",
       );
     });
 
@@ -131,7 +131,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can start with whatever's in front of you, or just talk for a bit first. Either way.",
+        "Hey Alice, I'm Pax.\n\nWe can start with whatever's in front of you, or just talk for a bit first. Either way. If there's old context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -142,7 +142,7 @@ describe("first-greeting", () => {
         userName: "Alice",
       });
       expect(greeting).toBe(
-        "Hey Alice,\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+        "Hey Alice,\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -153,7 +153,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+        "Hey, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -173,7 +173,7 @@ describe("first-greeting", () => {
         tone: "warm",
       });
       expect(greeting).toBe(
-        "Hey,\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here.",
+        "Hey,\n\nWe can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
       );
     });
 
@@ -185,6 +185,17 @@ describe("first-greeting", () => {
       expect(unique.size).toBe(4);
     });
 
+    it("google-connected greeting points to Gmail only", () => {
+      const greeting = getCannedFirstGreeting({
+        ...base,
+        tone: "grounded",
+        googleConnected: true,
+      });
+      expect(greeting).toContain("scan Gmail");
+      expect(greeting).not.toContain("calendar");
+      expect(greeting).not.toContain("drive");
+    });
+
     it("unknown tone falls back to grounded defaults", () => {
       const greeting = getCannedFirstGreeting({
         ...base,
@@ -193,7 +204,7 @@ describe("first-greeting", () => {
         assistantName: "Pax",
       });
       expect(greeting).toBe(
-        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+        "Hey Alice, I'm Pax.\n\nWe can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -223,7 +234,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax.");
       expect(invite).toBe(
-        "We can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+        "We can get into whatever you've got, or just talk first — that tends to go better. Up to you. If you have context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -232,7 +243,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax. Good to meet you.");
       expect(invite).toBe(
-        "We can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here.",
+        "We can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here. If you have context or workflows from another assistant or harness, bring them over early and I can help port them.",
       );
     });
 
@@ -241,7 +252,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax. Let's see what you've got.");
       expect(invite).toBe(
-        "We can jump straight into whatever you've got, or take a few minutes to just talk first. What sounds right?",
+        "We can jump straight into whatever you've got, or take a few minutes to just talk first. If you've got context or workflows from another assistant or harness, bring them over early and I'll port them with you. What sounds right?",
       );
     });
 
@@ -250,7 +261,7 @@ describe("first-greeting", () => {
       const [intro, invite] = greeting.split("\n\n");
       expect(intro).toBe("Hey Bob, I'm Pax.");
       expect(invite).toBe(
-        "We can start with whatever's in front of you, or just talk for a bit first. Either way.",
+        "We can start with whatever's in front of you, or just talk for a bit first. Either way. If there's old context or workflows from another assistant or harness, bring them over early and I'll help port them.",
       );
     });
 
@@ -274,6 +285,45 @@ describe("first-greeting", () => {
     });
   });
 
+  describe("migration offer is present in every variant", () => {
+    const MIGRATION_MARKER = "bring them over early";
+
+    it("no-onboarding greeting includes the migration offer", () => {
+      expect(getCannedFirstGreeting(undefined)).toContain(MIGRATION_MARKER);
+      expect(CANNED_FIRST_GREETING).toContain(MIGRATION_MARKER);
+    });
+
+    it("minimal onboarding (falls back to CANNED) includes the migration offer", () => {
+      expect(
+        getCannedFirstGreeting({ tools: [], tasks: [], tone: "" }),
+      ).toContain(MIGRATION_MARKER);
+    });
+
+    it("every tone variant includes the migration offer", () => {
+      for (const tone of ["grounded", "warm", "energetic", "poetic"]) {
+        const greeting = getCannedFirstGreeting({
+          tools: [],
+          tasks: [],
+          tone,
+          userName: "Alice",
+          assistantName: "Pax",
+        });
+        expect(greeting).toContain(MIGRATION_MARKER);
+        expect(greeting).toContain("port them");
+      }
+    });
+
+    it("google-connected greeting still includes the migration offer", () => {
+      const greeting = getCannedFirstGreeting({
+        tools: [],
+        tasks: [],
+        tone: "warm",
+        googleConnected: true,
+      });
+      expect(greeting).toContain(MIGRATION_MARKER);
+    });
+  });
+
   describe("buildScanFirstMessage", () => {
     it("website variant includes 'my website' and the URL", () => {
       const msg = buildScanFirstMessage("https://acme.com", "website");

package/src/__tests__/gateway-flag-listener.test.ts

@@ -33,7 +33,6 @@ mock.module("../config/assistant-feature-flags.js", () => ({
   initFeatureFlagOverrides: async () => {},
   clearFeatureFlagOverridesCache: () => {},
   isAssistantFeatureFlagEnabled: () => true,
-  _setOverridesForTesting: () => {},
 }));
 
 // ---------------------------------------------------------------------------

package/src/__tests__/gemini-provider.test.ts

@@ -285,6 +285,32 @@ describe("GeminiProvider", () => {
     });
   });
 
+  test("omits thinkingConfig for models that do not support thinking", async () => {
+    fakeChunks = [textChunk("OK"), finishChunk("STOP", 10, 2)];
+
+    // gemini-2.5-flash-lite has supportsThinking: false in the catalog; the
+    // provider must not forward thinking params even when a thinking config is
+    // supplied (gemini is in THINKING_AWARE_PROVIDERS, so retry.ts no longer
+    // strips them).
+    const liteProvider = new GeminiProvider(
+      "test-api-key",
+      "gemini-2.5-flash-lite",
+    );
+    await liteProvider.sendMessage(
+      [{ role: "user", content: [{ type: "text", text: "Hi" }] }],
+      undefined,
+      undefined,
+      {
+        config: {
+          thinking: { type: "adaptive", level: "high", streamThinking: false },
+        },
+      },
+    );
+
+    const config = lastStreamParams!.config as Record<string, unknown>;
+    expect(config.thinkingConfig).toBeUndefined();
+  });
+
   test("omits thinkingConfig when wire shape is adaptive with no extras", async () => {
     fakeChunks = [textChunk("OK"), finishChunk("STOP", 10, 2)];
 

package/src/__tests__/guardian-action-sweep.test.ts

@@ -28,7 +28,7 @@ import {
   stopGuardianActionSweep,
   sweepExpiredGuardianActions,
 } from "../calls/guardian-action-sweep.js";
-import { getDb, resetDb } from "../memory/db-connection.js";
+import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import {
   createGuardianActionDelivery,
@@ -38,6 +38,7 @@ import {
   updateDeliveryStatus,
 } from "../memory/guardian-action-store.js";
 import { conversations } from "../memory/schema.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 initializeDb();
 
@@ -73,7 +74,7 @@ describe("guardian-action-sweep", () => {
 
   afterAll(() => {
     stopGuardianActionSweep();
-    resetDb();
+    resetDbForTesting();
   });
 
   test("sweepExpiredGuardianActions expires requests past their expiresAt", async () => {

package/src/__tests__/guardian-outbound-http.test.ts

@@ -88,7 +88,7 @@ globalThis.fetch = (async (
 // Now import modules under test (after mocks are in place)
 // ---------------------------------------------------------------------------
 
-import { getDb, resetDb } from "../memory/db-connection.js";
+import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { updateSessionDelivery } from "../runtime/channel-verification-service.js";
 import {
@@ -102,13 +102,14 @@ import {
   resendOutbound,
   startOutbound,
 } from "../runtime/verification-outbound-actions.js";
+import { resetDbForTesting } from "./db-test-helpers.js";
 
 // Initialize the database (creates all tables)
 initializeDb();
 
 afterAll(() => {
   globalThis.fetch = originalFetch;
-  resetDb();
+  resetDbForTesting();
 });
 
 function resetTables(): void {

package/src/__tests__/handlers-skills-memory-v2-reseed.test.ts

@@ -156,9 +156,54 @@ mock.module("../daemon/skill-memory-refresh.js", () => ({
   refreshSkillCapabilityMemories: mockRefreshSkillCapabilityMemories,
 }));
 
-mock.module("../util/platform.js", () => ({
-  getWorkspaceSkillsDir: () => "/tmp/test-skills",
-}));
+mock.module("../util/platform.js", () => {
+  const stub = () => "/tmp/test-stub";
+  return {
+    getWorkspaceSkillsDir: () => "/tmp/test-skills",
+    vellumRoot: stub,
+    isMacOS: () => false,
+    isLinux: () => true,
+    isWindows: () => false,
+    getPlatformName: () => "linux",
+    normalizeAssistantId: (id: string) => id,
+    getDataDir: stub,
+    getEmbeddingModelsDir: stub,
+    getSandboxRootDir: stub,
+    getSandboxWorkingDir: stub,
+    getSoundsDir: stub,
+    getAvatarDir: stub,
+    AVATAR_IMAGE_FILENAME: "avatar-image.png",
+    getAvatarImagePath: stub,
+    getXdgVellumConfigDirName: () => ".vellum",
+    getPidPath: stub,
+    getDbPath: stub,
+    getLogsDir: stub,
+    getHistoryPath: stub,
+    getProtectedDir: stub,
+    getSignalsDir: stub,
+    getDaemonStderrLogPath: stub,
+    getDaemonStartupLockPath: stub,
+    getExternalDir: stub,
+    getBinDir: stub,
+    getDotEnvPath: stub,
+    getEmbedWorkerPidPath: stub,
+    getWorkspaceDir: stub,
+    getWorkspaceDirDisplay: stub,
+    getWorkspaceConfigPath: stub,
+    getWorkspaceHooksDir: stub,
+    getWorkspacePluginsDir: stub,
+    getWorkspaceRoutesDir: stub,
+    getDeprecatedDir: stub,
+    getConversationsDir: stub,
+    getWorkspacePromptPath: stub,
+    getProfilerRootDir: stub,
+    getProfilerRunsDir: stub,
+    getProfilerRunDir: stub,
+    getSkillRuntimePath: stub,
+    getBundledBunPath: () => undefined,
+    ensureDataDir: () => {},
+  };
+});
 
 mock.module("../daemon/handlers/shared.js", () => ({
   CONFIG_RELOAD_DEBOUNCE_MS: 100,

package/src/__tests__/handlers-user-message-approval-consumption.test.ts

@@ -92,6 +92,7 @@ mock.module("../runtime/pending-interactions.js", () => ({
 
 mock.module("../memory/conversation-crud.js", () => ({
   addMessage: mock(async () => ({ id: "persisted-message-id" })),
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 mock.module("../config/loader.js", () => ({

package/src/__tests__/heartbeat-disk-pressure.test.ts

@@ -74,6 +74,7 @@ mock.module("../memory/conversation-crud.js", () => ({
   // addMessage. Disk-pressure short-circuits before addMessage ever runs,
   // but the mock module must still expose every name the real module does.
   addMessage: () => Promise.resolve({ id: "mock-msg-id" }),
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 const mockProcessMessage = mock(() => Promise.resolve({ messageId: "msg-1" }));

package/src/__tests__/heartbeat-service.test.ts

@@ -159,6 +159,7 @@ mock.module("../memory/conversation-crud.js", () => ({
     createdConversations.push(opts);
     return { id: `conv-${++conversationIdCounter}`, ...opts };
   },
+  reserveMessage: mock(async () => ({ id: "msg-reserve" })),
 }));
 
 // Mock logger — capture warn calls for unreachable-credential assertions