@vellumai/assistant 0.8.4 → 0.8.5

package/src/memory/v2/__tests__/injection.test.ts

@@ -577,8 +577,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Tell me about Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Tell me about Alice's editor" },
+      ],
       nowText: "Spring afternoon",
       messageId: "msg-1",
       config: makeConfig(),
@@ -613,8 +614,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -627,8 +629,12 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "And what about VS Code?",
-      assistantMessage: "Alice loves it.",
+      recentTurnPairs: [
+        {
+          assistantMessage: "Alice loves it.",
+          userMessage: "And what about VS Code?",
+        },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -654,8 +660,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Editor preferences",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Editor preferences" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -672,8 +679,12 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Tell me about Carol's music taste",
-      assistantMessage: "",
+      recentTurnPairs: [
+        {
+          assistantMessage: "",
+          userMessage: "Tell me about Carol's music taste",
+        },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -699,8 +710,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -720,8 +732,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Alice's editor again",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor again" },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -747,8 +760,12 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "tell me about the summarized page",
-      assistantMessage: "",
+      recentTurnPairs: [
+        {
+          assistantMessage: "",
+          userMessage: "tell me about the summarized page",
+        },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -781,8 +798,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "show me everything",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "show me everything" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -818,8 +836,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "show me the demo",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "show me the demo" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -851,8 +870,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "music and editors",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "music and editors" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -879,8 +899,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "carol",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "carol" }],
       nowText: "",
       messageId: "msg-1",
       config: makeConfig({ epsilon: 0.05 }),
@@ -901,8 +920,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "phantom",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "phantom" }],
       nowText: "",
       messageId: "msg-1",
       config: makeConfig(),
@@ -952,8 +970,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Help me with examples",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Help me with examples" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -992,8 +1011,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1031,8 +1051,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "examples",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "examples" }],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1049,8 +1068,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "more examples",
-      assistantMessage: "ok",
+      recentTurnPairs: [
+        { assistantMessage: "ok", userMessage: "more examples" },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -1078,8 +1098,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "anything",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "anything" }],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1104,8 +1123,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "anything",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "anything" }],
       nowText: "",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1133,8 +1151,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "How do I register a video?",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "How do I register a video?" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1175,8 +1194,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Help me",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "Help me" }],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1206,8 +1224,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "anything",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "anything" }],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1232,8 +1249,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "config",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "config" }],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1247,8 +1263,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "more config",
-      assistantMessage: "ok",
+      recentTurnPairs: [{ assistantMessage: "ok", userMessage: "more config" }],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -1269,8 +1284,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1285,8 +1301,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Reload context",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Reload context" },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       mode: "context-load",
@@ -1321,8 +1338,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "hi",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "hi" }],
       nowText: "",
       messageId: "msg-1",
       mode: "context-load",
@@ -1362,8 +1378,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1381,8 +1398,7 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Carol's music",
-      assistantMessage: "",
+      recentTurnPairs: [{ assistantMessage: "", userMessage: "Carol's music" }],
       nowText: "Now",
       messageId: "msg-2",
       config: makeConfig(),
@@ -1444,8 +1460,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1470,8 +1487,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1493,8 +1511,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Reload context",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Reload context" },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       mode: "context-load",
@@ -1533,8 +1552,12 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor and Bob's coffee",
-      assistantMessage: "",
+      recentTurnPairs: [
+        {
+          assistantMessage: "",
+          userMessage: "Alice's editor and Bob's coffee",
+        },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1551,8 +1574,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 2,
-      userMessage: "Reload context",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Reload context" },
+      ],
       nowText: "Now",
       messageId: "msg-2",
       mode: "context-load",
@@ -1581,8 +1605,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1624,8 +1649,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-1",
       currentTurn: 1,
-      userMessage: "music and editors",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "music and editors" },
+      ],
       nowText: "Now",
       messageId: "msg-1",
       config: makeConfig(),
@@ -1680,8 +1706,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-1",
         currentTurn: 1,
-        userMessage: "Alice's editor",
-        assistantMessage: "",
+        recentTurnPairs: [
+          { assistantMessage: "", userMessage: "Alice's editor" },
+        ],
         nowText: "Now",
         messageId: "msg-1",
         config: makeConfig(),
@@ -1726,8 +1753,9 @@ describe("injectMemoryV2Block", () => {
       database: db,
       conversationId: "conv-finalize",
       currentTurn: 7,
-      userMessage: "Alice's editor",
-      assistantMessage: "",
+      recentTurnPairs: [
+        { assistantMessage: "", userMessage: "Alice's editor" },
+      ],
       nowText: "Now",
       messageId: "msg-finalize",
       config: makeConfig(),
@@ -1799,8 +1827,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-1",
         currentTurn: 1,
-        userMessage: "Tell me about Alice",
-        assistantMessage: "",
+        recentTurnPairs: [
+          { assistantMessage: "", userMessage: "Tell me about Alice" },
+        ],
         nowText: "Now",
         messageId: "msg-1",
         config: makeConfig({ router: { enabled: true } }),
@@ -1853,8 +1882,7 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-fail",
         currentTurn: 3,
-        userMessage: "anything",
-        assistantMessage: "ok",
+        recentTurnPairs: [{ assistantMessage: "ok", userMessage: "anything" }],
         nowText: "Now",
         messageId: "msg-fail",
         config: makeConfig({ router: { enabled: true } }),
@@ -1909,8 +1937,9 @@ describe("injectMemoryV2Block", () => {
           database: db,
           conversationId: "conv-router-fail-save-throws",
           currentTurn: 5,
-          userMessage: "anything",
-          assistantMessage: "ok",
+          recentTurnPairs: [
+            { assistantMessage: "ok", userMessage: "anything" },
+          ],
           nowText: "Now",
           messageId: "msg-fail-save",
           config: makeConfig({ router: { enabled: true } }),
@@ -1945,8 +1974,7 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-abstain",
         currentTurn: 1,
-        userMessage: "small talk",
-        assistantMessage: "",
+        recentTurnPairs: [{ assistantMessage: "", userMessage: "small talk" }],
         nowText: "Now",
         messageId: "msg-abstain",
         config: makeConfig({ router: { enabled: true } }),
@@ -1984,8 +2012,7 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-missing",
         currentTurn: 1,
-        userMessage: "phantom",
-        assistantMessage: "",
+        recentTurnPairs: [{ assistantMessage: "", userMessage: "phantom" }],
         nowText: "Now",
         messageId: "msg-missing",
         config: makeConfig({ router: { enabled: true } }),
@@ -2032,8 +2059,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-dedup",
         currentTurn: 1,
-        userMessage: "Tell me about Alice",
-        assistantMessage: "",
+        recentTurnPairs: [
+          { assistantMessage: "", userMessage: "Tell me about Alice" },
+        ],
         nowText: "Now",
         messageId: "msg-1",
         config: makeConfig({ router: { enabled: true } }),
@@ -2053,8 +2081,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-dedup",
         currentTurn: 2,
-        userMessage: "And Bob?",
-        assistantMessage: "Sure",
+        recentTurnPairs: [
+          { assistantMessage: "Sure", userMessage: "And Bob?" },
+        ],
         nowText: "Now",
         messageId: "msg-2",
         config: makeConfig({ router: { enabled: true } }),
@@ -2086,8 +2115,7 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-source",
         currentTurn: 1,
-        userMessage: "Alice",
-        assistantMessage: "",
+        recentTurnPairs: [{ assistantMessage: "", userMessage: "Alice" }],
         nowText: "Now",
         messageId: "msg-1",
         config: makeConfig({ router: { enabled: true } }),
@@ -2105,8 +2133,7 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-router-source",
         currentTurn: 2,
-        userMessage: "Bob",
-        assistantMessage: "",
+        recentTurnPairs: [{ assistantMessage: "", userMessage: "Bob" }],
         nowText: "Now",
         messageId: "msg-2",
         config: makeConfig({ router: { enabled: true } }),
@@ -2142,8 +2169,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-flag-off",
         currentTurn: 1,
-        userMessage: "Alice's editor",
-        assistantMessage: "",
+        recentTurnPairs: [
+          { assistantMessage: "", userMessage: "Alice's editor" },
+        ],
         nowText: "Now",
         messageId: "msg-1",
         config: makeConfig({ router: { enabled: false } }),
@@ -2178,8 +2206,9 @@ describe("injectMemoryV2Block", () => {
         database: db,
         conversationId: "conv-context-load-router-on",
         currentTurn: 1,
-        userMessage: "Tell me about Alice",
-        assistantMessage: "",
+        recentTurnPairs: [
+          { assistantMessage: "", userMessage: "Tell me about Alice" },
+        ],
         nowText: "Now",
         messageId: "msg-1",
         mode: "context-load",

package/src/memory/v2/__tests__/qdrant.test.ts

@@ -887,4 +887,40 @@ describe("memory v2 qdrant — hybrid query", () => {
     );
     expect(results).toEqual([]);
   });
+
+  test("an empty dense vector runs a sparse-only query (skips the dense channels)", async () => {
+    state.collectionExistsBeforeCreate = true;
+    // Only the two sparse channels should fire. Queue body + summary sparse hits.
+    state.queryResponses.sparse.push({
+      points: [{ score: 7, payload: { slug: "people/alice" } }],
+    });
+    state.queryResponses.sparse.push({
+      points: [{ score: 5, payload: { slug: "people/alice" } }],
+    });
+
+    const results = await hybridQueryConceptPages(
+      [],
+      { indices: [1, 2], values: [0.5, 0.5] },
+      5,
+    );
+
+    // Regression: a 0-dimension dense vector used to be forwarded verbatim,
+    // drawing a Qdrant "Vector dimension error: expected dim N, got 0" 400.
+    // It must now skip the dense channels entirely — only sparse runs.
+    const usings = state.queryCalls.map((c) => c.using).sort();
+    expect(usings).toEqual(["sparse", "summary_sparse"]);
+    expect(state.queryCalls.some((c) => c.using === "dense")).toBe(false);
+    expect(state.queryCalls.some((c) => c.using === "summary_dense")).toBe(
+      false,
+    );
+
+    // The sparse hits still come back; the dense score stays undefined.
+    const alice = results.find((r) => r.slug === "people/alice");
+    expect(alice).toEqual({
+      slug: "people/alice",
+      sparseScore: 7,
+      summarySparseScore: 5,
+    });
+    expect(alice?.denseScore).toBeUndefined();
+  });
 });