@vellumai/assistant 0.8.3 → 0.8.4

package/src/__tests__/conversation-load-cleaned-at.test.ts

@@ -0,0 +1,279 @@
+import { beforeEach, describe, expect, mock, test } from "bun:test";
+
+mock.module("../util/logger.js", () => ({
+  getLogger: () =>
+    new Proxy({} as Record<string, unknown>, { get: () => () => {} }),
+}));
+
+mock.module("../providers/registry.js", () => ({
+  getProvider: () => ({ name: "mock-provider" }),
+  initializeProviders: async () => {},
+}));
+
+mock.module("../config/loader.js", () => ({
+  getConfig: () => ({
+    ui: {},
+    llm: {
+      default: {
+        provider: "mock-provider",
+        model: "mock-model",
+        maxTokens: 4096,
+        effort: "max" as const,
+        speed: "standard" as const,
+        temperature: null,
+        thinking: { enabled: false, streamThinking: true },
+        contextWindow: {
+          enabled: true,
+          maxInputTokens: 100000,
+          targetBudgetRatio: 0.3,
+          compactThreshold: 0.8,
+          summaryBudgetRatio: 0.05,
+          overflowRecovery: {
+            enabled: true,
+            safetyMarginRatio: 0.05,
+            maxAttempts: 3,
+            interactiveLatestTurnCompression: "summarize",
+            nonInteractiveLatestTurnCompression: "truncate",
+          },
+        },
+      },
+      profiles: {},
+      callSites: {},
+      pricingOverrides: [],
+    },
+    rateLimit: { maxRequestsPerMinute: 0 },
+  }),
+  loadRawConfig: () => ({}),
+  saveRawConfig: () => {},
+  invalidateConfigCache: () => {},
+}));
+
+mock.module("../prompts/system-prompt.js", () => ({
+  buildSystemPrompt: () => "system prompt",
+}));
+
+mock.module("../permissions/trust-store.js", () => ({
+  clearCache: () => {},
+}));
+
+mock.module("../security/secret-allowlist.js", () => ({
+  resetAllowlist: () => {},
+}));
+
+let mockDbMessages: Array<{
+  id: string;
+  role: string;
+  content: string;
+  createdAt: number;
+  metadata?: string | null;
+}> = [];
+let mockConversation: Record<string, unknown> | null = null;
+
+mock.module("../memory/conversation-crud.js", () => ({
+  updateConversationContextWindow: () => {},
+  deleteMessageById: () => {},
+  updateConversationTitle: () => {},
+  updateConversationUsage: () => {},
+  provenanceFromTrustContext: () => ({
+    source: "user",
+    trustContext: undefined,
+  }),
+  getConversationOriginInterface: () => null,
+  getConversationOriginChannel: () => null,
+  getMessages: () => mockDbMessages,
+  getConversation: () => mockConversation,
+  createConversation: () => ({ id: "conv-1" }),
+  addMessage: async () => ({ id: "persisted" }),
+  setConversationCleanedAt: () => {},
+  setConversationOriginChannelIfUnset: () => {},
+  setConversationOriginInterfaceIfUnset: () => {},
+}));
+
+mock.module("../memory/conversation-queries.js", () => ({
+  listConversations: () => [],
+}));
+
+import { Conversation } from "../daemon/conversation.js";
+
+function makeConversation(): Conversation {
+  const provider = {
+    name: "mock",
+    sendMessage: async () => ({
+      content: [],
+      model: "mock",
+      usage: { inputTokens: 0, outputTokens: 0 },
+      stopReason: "end_turn",
+    }),
+  };
+  const conv = new Conversation(
+    "conv-1",
+    provider,
+    "system prompt",
+    4096,
+    () => {},
+    "/tmp",
+  );
+  conv.setTrustContext({ trustClass: "guardian", sourceChannel: "vellum" });
+  return conv;
+}
+
+function textBlocks(content: ReadonlyArray<{ type: string; text?: string }>) {
+  return content
+    .filter((b): b is { type: "text"; text: string } => b.type === "text")
+    .map((b) => b.text);
+}
+
+describe("loadFromDb with cleanedAt", () => {
+  beforeEach(() => {
+    mockDbMessages = [];
+    mockConversation = null;
+  });
+
+  test("strips injection prefixes from pre-clean user content", async () => {
+    const cleanedAt = 1000;
+    mockConversation = {
+      id: "conv-1",
+      contextSummary: null,
+      contextCompactedMessageCount: 0,
+      cleanedAt,
+      totalInputTokens: 0,
+      totalOutputTokens: 0,
+      totalEstimatedCost: 0,
+    };
+    mockDbMessages = [
+      {
+        id: "m1",
+        role: "user",
+        content: JSON.stringify([
+          {
+            type: "text",
+            text: "<channel_capabilities>old</channel_capabilities>",
+          },
+          { type: "text", text: "Hello" },
+        ]),
+        createdAt: 500,
+      },
+      {
+        id: "m2",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Hi back" }]),
+        createdAt: 600,
+      },
+      {
+        id: "m3",
+        role: "user",
+        content: JSON.stringify([
+          {
+            type: "text",
+            text: "<channel_capabilities>fresh</channel_capabilities>",
+          },
+          { type: "text", text: "Second turn" },
+        ]),
+        createdAt: 1500,
+      },
+    ];
+
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
+
+    expect(messages).toHaveLength(3);
+    expect(textBlocks(messages[0].content)).toEqual(["Hello"]);
+    expect(textBlocks(messages[1].content)).toEqual(["Hi back"]);
+    expect(textBlocks(messages[2].content)).toEqual([
+      "<channel_capabilities>fresh</channel_capabilities>",
+      "Second turn",
+    ]);
+  });
+
+  test("skips metadata rehydration for pre-clean messages", async () => {
+    const cleanedAt = 1000;
+    mockConversation = {
+      id: "conv-1",
+      contextSummary: null,
+      contextCompactedMessageCount: 0,
+      cleanedAt,
+      totalInputTokens: 0,
+      totalOutputTokens: 0,
+      totalEstimatedCost: 0,
+    };
+    mockDbMessages = [
+      {
+        id: "m1",
+        role: "user",
+        content: JSON.stringify([{ type: "text", text: "Pre-clean turn" }]),
+        createdAt: 500,
+        metadata: JSON.stringify({
+          pkbContextBlock: "<knowledge_base>stale</knowledge_base>",
+        }),
+      },
+      {
+        id: "m2",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Reply" }]),
+        createdAt: 600,
+      },
+      {
+        id: "m3",
+        role: "user",
+        content: JSON.stringify([
+          { type: "text", text: "Mid post-clean turn" },
+        ]),
+        createdAt: 1500,
+        metadata: JSON.stringify({
+          pkbContextBlock: "<knowledge_base>kept</knowledge_base>",
+        }),
+      },
+      {
+        id: "m4",
+        role: "assistant",
+        content: JSON.stringify([{ type: "text", text: "Tail reply" }]),
+        createdAt: 1600,
+      },
+    ];
+
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
+
+    expect(textBlocks(messages[0].content)).toEqual(["Pre-clean turn"]);
+    expect(textBlocks(messages[2].content).join("\n")).toContain(
+      "<knowledge_base>kept</knowledge_base>",
+    );
+  });
+
+  test("leaves messages untouched when cleanedAt is null", async () => {
+    mockConversation = {
+      id: "conv-1",
+      contextSummary: null,
+      contextCompactedMessageCount: 0,
+      cleanedAt: null,
+      totalInputTokens: 0,
+      totalOutputTokens: 0,
+      totalEstimatedCost: 0,
+    };
+    mockDbMessages = [
+      {
+        id: "m1",
+        role: "user",
+        content: JSON.stringify([
+          {
+            type: "text",
+            text: "<channel_capabilities>kept</channel_capabilities>",
+          },
+          { type: "text", text: "Hi" },
+        ]),
+        createdAt: 500,
+      },
+    ];
+
+    const conversation = makeConversation();
+    await conversation.loadFromDb();
+    const messages = conversation.getMessages();
+
+    expect(textBlocks(messages[0].content)).toEqual([
+      "<channel_capabilities>kept</channel_capabilities>",
+      "Hi",
+    ]);
+  });
+});

package/src/__tests__/conversation-load-history-repair.test.ts

@@ -10,7 +10,7 @@ mock.module("../util/logger.js", () => ({
 
 mock.module("../providers/registry.js", () => ({
   getProvider: () => ({ name: "mock-provider" }),
-  initializeProviders: () => {},
+  initializeProviders: async () => {},
 }));
 
 mock.module("../config/loader.js", () => ({

package/src/__tests__/conversation-pairing.test.ts

@@ -250,7 +250,7 @@ describe("pairDeliveryWithConversation", () => {
     // Should NOT be the JSON dump
     expect(contentArg).not.toContain('"raw"');
     // Should be the runtime-composed seed from copy.title/body
-    expect(contentArg).toContain("Reminder");
+    expect(contentArg).toContain("Daily standup");
   });
 
   test("rejects very short conversationSeedMessage and uses runtime composer", async () => {
@@ -273,7 +273,7 @@ describe("pairDeliveryWithConversation", () => {
     const contentArg = addMessageMock.mock.calls[0]![2] as string;
     expect(contentArg).not.toBe("Hi");
     // Runtime composer builds from copy.title/body
-    expect(contentArg).toContain("Reminder");
+    expect(contentArg).toContain("Test reminder");
   });
 
   test("passes skipIndexing option to addMessage", async () => {

package/src/__tests__/conversation-process-callsite.test.ts

@@ -43,7 +43,7 @@ mock.module("../memory/guardian-action-store.js", () => ({
 const mockProviderStub = { name: "mock-provider" };
 mock.module("../providers/registry.js", () => ({
   getProvider: () => mockProviderStub,
-  initializeProviders: () => {},
+  initializeProviders: async () => {},
   listProviders: () => ["anthropic", "openai", "gemini"],
   resolveProviderFromConnection: async () => mockProviderStub,
 }));

package/src/__tests__/conversation-provider-retry-repair.test.ts

@@ -18,7 +18,7 @@ mock.module("../memory/guardian-action-store.js", () => ({
 
 mock.module("../providers/registry.js", () => ({
   getProvider: () => ({ name: "mock-provider" }),
-  initializeProviders: () => {},
+  initializeProviders: async () => {},
 }));
 
 mock.module("../config/loader.js", () => ({

package/src/__tests__/conversation-queue.test.ts

@@ -41,7 +41,7 @@ mock.module("../memory/guardian-action-store.js", () => ({
 
 mock.module("../providers/registry.js", () => ({
   getProvider: () => ({ name: "mock-provider" }),
-  initializeProviders: () => {},
+  initializeProviders: async () => {},
 }));
 
 mock.module("../config/loader.js", () => ({