@vellumai/assistant 0.8.2 → 0.8.4

package/src/__tests__/workspace-migration-088-deprecate-background-conversation-override.test.ts

@@ -0,0 +1,158 @@
+import {
+  existsSync,
+  mkdirSync,
+  mkdtempSync,
+  readFileSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+
+import { deprecateBackgroundConversationOverrideMigration } from "../workspace/migrations/088-deprecate-background-conversation-override.js";
+
+let workspaceDir: string;
+
+beforeEach(() => {
+  workspaceDir = mkdtempSync(join(tmpdir(), "vellum-migration-088-test-"));
+});
+
+afterEach(() => {
+  if (existsSync(workspaceDir)) {
+    rmSync(workspaceDir, { recursive: true, force: true });
+  }
+});
+
+function promptSystemDir(): string {
+  return join(workspaceDir, "prompts", "system");
+}
+
+function writeOverride(body: string): string {
+  const dir = promptSystemDir();
+  mkdirSync(dir, { recursive: true });
+  const filePath = join(dir, "08-background-conversation.md");
+  writeFileSync(filePath, body, "utf-8");
+  return filePath;
+}
+
+describe("088-deprecate-background-conversation-override migration", () => {
+  test("has expected id and description", () => {
+    expect(deprecateBackgroundConversationOverrideMigration.id).toBe(
+      "088-deprecate-background-conversation-override",
+    );
+    expect(
+      deprecateBackgroundConversationOverrideMigration.description,
+    ).toContain("08-background-conversation");
+  });
+
+  test("renames the override to .deprecated, preserving body", () => {
+    const body = "## Custom\n\nUser-customized background note.\n";
+    writeOverride(body);
+
+    deprecateBackgroundConversationOverrideMigration.run(workspaceDir);
+
+    const originalPath = join(
+      promptSystemDir(),
+      "08-background-conversation.md",
+    );
+    const deprecatedPath = join(
+      promptSystemDir(),
+      "08-background-conversation.md.deprecated",
+    );
+
+    expect(existsSync(originalPath)).toBe(false);
+    expect(existsSync(deprecatedPath)).toBe(true);
+    expect(readFileSync(deprecatedPath, "utf-8")).toBe(body);
+  });
+
+  test("no-ops when the override is absent", () => {
+    expect(() =>
+      deprecateBackgroundConversationOverrideMigration.run(workspaceDir),
+    ).not.toThrow();
+
+    const deprecatedPath = join(
+      promptSystemDir(),
+      "08-background-conversation.md.deprecated",
+    );
+    expect(existsSync(deprecatedPath)).toBe(false);
+  });
+
+  test("does not touch unrelated section overrides", () => {
+    const dir = promptSystemDir();
+    mkdirSync(dir, { recursive: true });
+    const otherPath = join(dir, "07-external-content.md");
+    writeFileSync(otherPath, "## External Content\n\nUntouched.\n", "utf-8");
+    writeOverride("body");
+
+    deprecateBackgroundConversationOverrideMigration.run(workspaceDir);
+
+    expect(readFileSync(otherPath, "utf-8")).toContain("Untouched");
+  });
+
+  test("is safe to re-run after the rename has happened", () => {
+    writeOverride("body");
+
+    deprecateBackgroundConversationOverrideMigration.run(workspaceDir);
+    expect(() =>
+      deprecateBackgroundConversationOverrideMigration.run(workspaceDir),
+    ).not.toThrow();
+
+    const deprecatedPath = join(
+      promptSystemDir(),
+      "08-background-conversation.md.deprecated",
+    );
+    expect(readFileSync(deprecatedPath, "utf-8")).toBe("body");
+  });
+
+  test("drops the .md and keeps the .deprecated copy when both exist", () => {
+    // A user re-created the override after a prior partial run. The bundled
+    // section is gone, so the .md would render unconditionally — drop it.
+    const dir = promptSystemDir();
+    mkdirSync(dir, { recursive: true });
+    const deprecatedPath = join(
+      dir,
+      "08-background-conversation.md.deprecated",
+    );
+    writeFileSync(deprecatedPath, "preserved.\n", "utf-8");
+    const recreatedPath = writeOverride("re-created body\n");
+
+    deprecateBackgroundConversationOverrideMigration.run(workspaceDir);
+
+    expect(existsSync(recreatedPath)).toBe(false);
+    expect(readFileSync(deprecatedPath, "utf-8")).toBe("preserved.\n");
+  });
+
+  test("down() restores the override when only .deprecated exists", () => {
+    writeOverride("body");
+    deprecateBackgroundConversationOverrideMigration.run(workspaceDir);
+
+    deprecateBackgroundConversationOverrideMigration.down(workspaceDir);
+
+    const overridePath = join(
+      promptSystemDir(),
+      "08-background-conversation.md",
+    );
+    const deprecatedPath = join(
+      promptSystemDir(),
+      "08-background-conversation.md.deprecated",
+    );
+    expect(existsSync(overridePath)).toBe(true);
+    expect(existsSync(deprecatedPath)).toBe(false);
+    expect(readFileSync(overridePath, "utf-8")).toBe("body");
+  });
+
+  test("down() is a no-op when only the .md exists", () => {
+    writeOverride("body");
+
+    expect(() =>
+      deprecateBackgroundConversationOverrideMigration.down(workspaceDir),
+    ).not.toThrow();
+
+    const overridePath = join(
+      promptSystemDir(),
+      "08-background-conversation.md",
+    );
+    expect(readFileSync(overridePath, "utf-8")).toBe("body");
+  });
+});

package/src/a2a/__tests__/agent-card.test.ts

@@ -0,0 +1,98 @@
+import { describe, expect, test } from "bun:test";
+
+import { buildAgentCard } from "../agent-card.js";
+
+describe("buildAgentCard", () => {
+  const BASE_PARAMS = {
+    assistantName: "Alice",
+    baseUrl: "https://example.com",
+  };
+
+  test("includes all required top-level fields", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.name).toBe("Alice");
+    expect(card.description).toBeDefined();
+    expect(card.version).toBe("1.0.0");
+    expect(card.supported_interfaces).toBeDefined();
+    expect(card.capabilities).toBeDefined();
+    expect(card.default_input_modes).toBeDefined();
+    expect(card.default_output_modes).toBeDefined();
+    expect(card.skills).toBeDefined();
+  });
+
+  test("interface URL is baseUrl + /a2a/message:send", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.supported_interfaces).toHaveLength(1);
+    expect(card.supported_interfaces[0].url).toBe(
+      "https://example.com/a2a/message:send",
+    );
+    expect(card.supported_interfaces[0].protocol_binding).toBe("JSONRPC");
+    expect(card.supported_interfaces[0].protocol_version).toBe("1.0");
+  });
+
+  test("push_notifications capability is true", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.capabilities.push_notifications).toBe(true);
+  });
+
+  test("streaming capability is false", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.capabilities.streaming).toBe(false);
+  });
+
+  test("extended_agent_card capability is false", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.capabilities.extended_agent_card).toBe(false);
+  });
+
+  test("defaults description when omitted", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.description).toBe("Alice — a Vellum AI assistant");
+  });
+
+  test("uses explicit description when provided", () => {
+    const card = buildAgentCard({
+      ...BASE_PARAMS,
+      assistantDescription: "A specialized research assistant",
+    });
+
+    expect(card.description).toBe("A specialized research assistant");
+  });
+
+  test("advertises text/plain as default input and output mode", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.default_input_modes).toEqual(["text/plain"]);
+    expect(card.default_output_modes).toEqual(["text/plain"]);
+  });
+
+  test("includes a conversation skill", () => {
+    const card = buildAgentCard(BASE_PARAMS);
+
+    expect(card.skills).toHaveLength(1);
+    expect(card.skills[0]).toEqual({
+      id: "conversation",
+      name: "General conversation",
+      description: "Send a message and receive a response",
+      tags: ["chat"],
+    });
+  });
+
+  test("constructs correct interface URL with trailing-slash base", () => {
+    const card = buildAgentCard({
+      ...BASE_PARAMS,
+      baseUrl: "https://example.com/",
+    });
+
+    // The URL is constructed by simple concatenation; callers normalize the base.
+    expect(card.supported_interfaces[0].url).toBe(
+      "https://example.com//a2a/message:send",
+    );
+  });
+});