@vellumai/assistant 0.8.12 → 0.9.0-staging.2

package/src/runtime/routes/inbound-stages/acl-enforcement.ts

@@ -2,10 +2,9 @@
  * Ingress ACL enforcement stage: resolves the inbound actor to a member
  * record, enforces allow/deny/escalate policies, handles invite token
  * intercepts, and notifies the guardian of denied access requests.
- *
- * Extracted from inbound-message-handler.ts to keep the top-level handler
- * focused on orchestration.
  */
+import type { SourceMetadata } from "@vellumai/gateway-client";
+
 import { isInviteCodeRedemptionEnabled } from "../../../channels/config.js";
 import type { ChannelId } from "../../../channels/types.js";
 import {
@@ -23,7 +22,7 @@ import {
   findByInviteCodeHash,
   findByInviteCodeHashAnyChannel,
 } from "../../../memory/invite-store.js";
-import { MESSAGE_PREVIEW_MAX_LENGTH } from "../../../notifications/access-request-copy.js";
+import { MESSAGE_PREVIEW_MAX_LENGTH } from "../../../notifications/notification-utils.js";
 import { resolveGuardianName } from "../../../prompts/user-reference.js";
 import { getLogger } from "../../../util/logger.js";
 import { truncate } from "../../../util/truncate.js";
@@ -85,7 +84,7 @@ export interface AclEnforcementParams {
   conversationExternalId: string;
   canonicalAssistantId: string;
   trimmedContent: string;
-  sourceMetadata: Record<string, unknown> | undefined;
+  sourceMetadata: SourceMetadata | undefined;
   actorDisplayName: string | undefined;
   actorUsername: string | undefined;
   replyCallbackUrl: string | undefined;
@@ -137,31 +136,22 @@ export async function enforceIngressAcl(
     externalMessageId,
   } = params;
 
+  // Trust signals from Slack users.info, forwarded via sourceMetadata.
+  const isStranger = sourceMetadata?.isStranger ?? undefined;
+  const isRestricted = sourceMetadata?.isRestricted ?? undefined;
+
+  // Slack message timestamp for permalink construction.
+  const messageTs = sourceMetadata?.messageId ?? undefined;
+
   let resolvedMember: ResolvedMember | null = null;
 
   // /start gv_<token> bootstrap commands must also bypass ACL — the user
   // hasn't been verified yet and needs to complete the bootstrap handshake.
-  const rawCommandIntentForAcl = sourceMetadata?.commandIntent;
+  const commandIntentForAcl = sourceMetadata?.commandIntent;
   const isBootstrapCommand =
-    rawCommandIntentForAcl &&
-    typeof rawCommandIntentForAcl === "object" &&
-    !Array.isArray(rawCommandIntentForAcl) &&
-    (rawCommandIntentForAcl as Record<string, unknown>).type === "start" &&
-    typeof (rawCommandIntentForAcl as Record<string, unknown>).payload ===
-      "string" &&
-    (
-      (rawCommandIntentForAcl as Record<string, unknown>).payload as string
-    ).startsWith("gv_");
-
-  // Parse invite token from /start payloads using the channel transport
-  // adapter. The token is extracted once here so both the ACL bypass and
-  // the intercept handler can reference it without re-parsing.
-  const commandIntentForAcl =
-    rawCommandIntentForAcl &&
-    typeof rawCommandIntentForAcl === "object" &&
-    !Array.isArray(rawCommandIntentForAcl)
-      ? (rawCommandIntentForAcl as Record<string, unknown>)
-      : undefined;
+    commandIntentForAcl?.type === "start" &&
+    typeof commandIntentForAcl.payload === "string" &&
+    commandIntentForAcl.payload.startsWith("gv_");
   const inviteAdapter = getInviteAdapterRegistry().get(sourceChannel);
   const inviteToken = inviteAdapter?.extractInboundToken?.({
     commandIntent: commandIntentForAcl,
@@ -195,9 +185,7 @@ export async function enforceIngressAcl(
       // any `/start gv_<garbage>` would bypass the not_a_member gate and
       // fall through to normal /start processing.
       if (isBootstrapCommand) {
-        const bootstrapPayload = (
-          rawCommandIntentForAcl as Record<string, unknown>
-        ).payload as string;
+        const bootstrapPayload = commandIntentForAcl!.payload!;
         const bootstrapTokenForAcl = bootstrapPayload.slice(3); // strip 'gv_' prefix
         const bootstrapSessionForAcl = resolveBootstrapToken(
           sourceChannel,
@@ -293,6 +281,9 @@ export async function enforceIngressAcl(
                   trimmedContent,
                   MESSAGE_PREVIEW_MAX_LENGTH,
                 ),
+                isStranger,
+                isRestricted,
+                messageTs,
               });
             } catch (err) {
               log.error(
@@ -365,6 +356,9 @@ export async function enforceIngressAcl(
                   trimmedContent,
                   MESSAGE_PREVIEW_MAX_LENGTH,
                 ),
+                isStranger,
+                isRestricted,
+                messageTs,
               });
             } catch (err) {
               log.error(
@@ -401,6 +395,9 @@ export async function enforceIngressAcl(
               trimmedContent,
               MESSAGE_PREVIEW_MAX_LENGTH,
             ),
+            isStranger,
+            isRestricted,
+            messageTs,
           });
           guardianNotified = accessResult.notified;
         } catch (err) {
@@ -457,9 +454,7 @@ export async function enforceIngressAcl(
         // (pending/revoked), but never for blocked members.
         let denyInactiveMember = true;
         if (!isBlockedMember && isBootstrapCommand) {
-          const bootstrapPayload = (
-            rawCommandIntentForAcl as Record<string, unknown>
-          ).payload as string;
+          const bootstrapPayload = commandIntentForAcl!.payload!;
           const bootstrapTokenForAcl = bootstrapPayload.slice(3);
           const bootstrapSessionForAcl = resolveBootstrapToken(
             sourceChannel,
@@ -575,6 +570,9 @@ export async function enforceIngressAcl(
                     trimmedContent,
                     MESSAGE_PREVIEW_MAX_LENGTH,
                   ),
+                  isStranger,
+                  isRestricted,
+                  messageTs,
                 });
               } catch (err) {
                 log.error(
@@ -640,6 +638,9 @@ export async function enforceIngressAcl(
                   trimmedContent,
                   MESSAGE_PREVIEW_MAX_LENGTH,
                 ),
+                isStranger,
+                isRestricted,
+                messageTs,
               });
               guardianNotified = accessResult.notified;
             } catch (err) {

package/src/runtime/routes/inbound-stages/background-dispatch.test.ts

@@ -85,7 +85,7 @@ mock.module("../../gateway-client.js", () => ({
   },
 }));
 
-mock.module("../channel-delivery-routes.js", () => ({
+mock.module("../../channel-reply-delivery.js", () => ({
   deliverReplyViaCallback: async (...args: unknown[]) => {
     const options = args[4] as
       | { messageId?: string; startFromSegment?: number; messageTs?: string }
@@ -296,7 +296,7 @@ describe("processChannelMessageInBackground — slack thread mapping", () => {
       },
     ]);
     expect(replyDeliveryCalls).toEqual([
-      { messageId: "assistant-msg-delivery-failure" },
+      { messageId: "assistant-msg-delivery-failure", startFromSegment: 0 },
     ]);
     expect(deliveryFailureEvents).toEqual(["evt-delivery-failure"]);
     expect(deliveredEvents).toEqual([]);
@@ -336,7 +336,7 @@ describe("processChannelMessageInBackground — slack thread mapping", () => {
       },
     ]);
     expect(replyDeliveryCalls).toEqual([
-      { messageId: "assistant-msg-fast-path" },
+      { messageId: "assistant-msg-fast-path", startFromSegment: 0 },
     ]);
     expect(deliveredEvents).toEqual(["evt-fast-path"]);
 
@@ -433,6 +433,7 @@ describe("processChannelMessageInBackground — slack thread mapping", () => {
     ]);
     expect(deliveredSegmentCounts).toEqual([
       { eventId: "evt-incremental-text", count: 1 },
+      { eventId: "evt-incremental-text", count: 1 },
     ]);
     expect(storedReplyMessageIds).toEqual([
       {
@@ -574,7 +575,7 @@ describe("processChannelMessageInBackground — slack thread mapping", () => {
         .filter(Boolean),
     ).toEqual([]);
     expect(replyDeliveryCalls).toEqual([
-      { messageId: "assistant-msg-channel-final" },
+      { messageId: "assistant-msg-channel-final", startFromSegment: 0 },
     ]);
     expect(deliveredEvents).toEqual(["evt-channel-final-delivery"]);
 
@@ -658,11 +659,12 @@ describe("processChannelMessageInBackground — slack thread mapping", () => {
         .filter(Boolean),
     ).toEqual(["First live response.", "Second live response."]);
     expect(replyDeliveryCalls).toEqual([
-      { messageId: "assistant-msg-live-failure-final" },
+      { messageId: "assistant-msg-live-failure-final", startFromSegment: 0 },
     ]);
     expect(deliveryFailureEvents).toEqual([]);
     expect(deliveredEvents).toEqual(["evt-live-failure-recovery"]);
     expect(deliveredSegmentCounts).toEqual([
+      { eventId: "evt-live-failure-recovery", count: 0 },
       { eventId: "evt-live-failure-recovery", count: 1 },
     ]);
 

package/src/runtime/routes/inbound-stages/background-dispatch.ts

@@ -14,16 +14,13 @@ import type { TrustContext } from "../../../daemon/trust-context.js";
 import {
   addSlackDmLiveDeliveredTextResponseIndex,
   getSlackDmLiveDeliveredTextResponseIndexes,
-  updateDeliveredSegmentCount,
 } from "../../../memory/delivery-channels.js";
 import {
   linkMessage,
   storeReplyMessageId,
 } from "../../../memory/delivery-crud.js";
 import {
-  markDeliveryDelivered,
   markProcessed,
-  recordDeliveryFailure,
   recordProcessingFailure,
 } from "../../../memory/delivery-status.js";
 import {
@@ -53,7 +50,7 @@ import {
   isSlackDeliveryCallbackUrl,
 } from "../../slack-dm-text-delivery.js";
 import { resolveRoutingState } from "../../trust-context-resolver.js";
-import { deliverReplyViaCallback } from "../channel-delivery-routes.js";
+import { finalizeEventDelivery } from "../channel-delivery-routes.js";
 import { deliverGeneratedApprovalPrompt } from "../guardian-approval-prompt.js";
 
 const log = getLogger("runtime-http");
@@ -326,32 +323,21 @@ export function processChannelMessageInBackground(
 
       if (replyCallbackUrl) {
         try {
-          if (slackDmTextDelivery) {
-            await slackDmTextDelivery.waitForPendingDeliveries();
-          }
-          const liveDeliveryResumeOptions =
-            slackDmTextDelivery?.getFinalDeliveryResumeOptions(replyMessageId);
-
-          await deliverReplyViaCallback(
+          await finalizeEventDelivery({
+            eventId,
             conversationId,
             externalChatId,
             replyCallbackUrl,
             assistantId,
-            {
-              messageId: replyMessageId,
-              sinceMessageId: userMessageId,
-              ...liveDeliveryResumeOptions,
-              onSegmentDelivered: (count) =>
-                updateDeliveredSegmentCount(eventId, count),
-            },
-          );
-          markDeliveryDelivered(eventId);
+            replyMessageId,
+            userMessageId,
+            slackDmTextDelivery,
+          });
         } catch (err) {
           log.error(
             { err, conversationId },
             "Background channel reply delivery failed",
           );
-          recordDeliveryFailure(eventId, err);
         }
       }
     } finally {

package/src/runtime/routes/inbound-stages/escalation-intercept.ts

@@ -34,7 +34,7 @@ export interface EscalationInterceptParams {
   eventId: string;
   content: string | undefined;
   attachmentIds: string[] | undefined;
-  sourceMetadata: Record<string, unknown> | undefined;
+  sourceMetadata: import("@vellumai/gateway-client").SourceMetadata | undefined;
   actorDisplayName: string | undefined;
   actorExternalId: string | undefined;
   actorUsername: string | undefined;
@@ -84,11 +84,11 @@ export function handleEscalationIntercept(
       { sourceChannel, channelId: resolvedMember.channel.id },
       "Ingress ACL: escalate policy but no guardian binding, denying",
     );
-    return ({
+    return {
       accepted: true,
       denied: true,
       reason: "escalate_no_guardian",
-    });
+    };
   }
 
   // Persist the raw payload so the decide handler can recover the original
@@ -159,9 +159,9 @@ export function handleEscalationIntercept(
     "Guardian escalation created — notification pipeline handles channel delivery",
   );
 
-  return ({
+  return {
     accepted: true,
     escalated: true,
     reason: "policy_escalate",
-  });
+  };
 }

package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts

@@ -32,7 +32,7 @@ export interface GuardianActivationInterceptParams {
   canonicalSenderId: string | null;
   actorDisplayName: string | undefined;
   actorUsername: string | undefined;
-  sourceMetadata: Record<string, unknown> | undefined;
+  sourceMetadata: import("@vellumai/gateway-client").SourceMetadata | undefined;
   replyCallbackUrl: string | undefined;
   assistantId: string;
   externalMessageId: string;
@@ -75,23 +75,14 @@ export async function handleGuardianActivationIntercept(
   } = params;
 
   // ── Extract commandIntent ──
-  const rawCommandIntent = sourceMetadata?.commandIntent;
-  const commandIntent =
-    rawCommandIntent &&
-    typeof rawCommandIntent === "object" &&
-    !Array.isArray(rawCommandIntent)
-      ? (rawCommandIntent as Record<string, unknown>)
-      : undefined;
+  const commandIntent = sourceMetadata?.commandIntent;
 
   // Only proceed for /start commands
   if (!commandIntent || commandIntent.type !== "start") return null;
 
   // If /start has a payload (e.g. gv_token, iv_token), let the existing
   // bootstrap/invite handlers deal with it.
-  if (
-    typeof commandIntent.payload === "string" &&
-    commandIntent.payload.length > 0
-  ) {
+  if (commandIntent.payload && commandIntent.payload.length > 0) {
     return null;
   }
 
@@ -110,7 +101,7 @@ export async function handleGuardianActivationIntercept(
   // Only checked here; marked as processed after successful session creation
   // so transient failures remain retryable.
   if (isAlreadyProcessed(externalMessageId)) {
-    return ({ accepted: true, guardianActivation: true });
+    return { accepted: true, guardianActivation: true };
   }
 
   // ── Idempotency: check for an existing active session from this sender ──
@@ -138,7 +129,7 @@ export async function handleGuardianActivationIntercept(
         });
       }
       markProcessed(externalMessageId);
-      return ({ accepted: true, guardianActivationPending: true });
+      return { accepted: true, guardianActivationPending: true };
     }
   }
 
@@ -193,5 +184,5 @@ export async function handleGuardianActivationIntercept(
     dedupeKey: `guardian-activation:${sessionResult.sessionId}`,
   });
 
-  return ({ accepted: true, guardianActivation: true });
+  return { accepted: true, guardianActivation: true };
 }

package/src/runtime/routes/inbound-stages/secret-ingress-check.ts

@@ -27,7 +27,7 @@ export interface SecretIngressCheckParams {
   content: string | undefined;
   trimmedContent: string;
   attachmentIds: string[] | undefined;
-  sourceMetadata: Record<string, unknown> | undefined;
+  sourceMetadata: import("@vellumai/gateway-client").SourceMetadata | undefined;
   actorDisplayName: string | undefined;
   actorExternalId: string | undefined;
   actorUsername: string | undefined;

package/src/runtime/routes/index.ts

@@ -110,6 +110,7 @@ import { ROUTES as PUBLISH_ROUTES } from "./publish-routes.js";
 import { ROUTES as QUESTION_ROUTES } from "./question-routes.js";
 import { ROUTES as RECORDING_ROUTES } from "./recording-routes.js";
 import { ROUTES as RENAME_CONVERSATION_ROUTES } from "./rename-conversation-routes.js";
+import { ROUTES as RETROSPECTIVE_ROUTES } from "./retrospective-routes.js";
 import { ROUTES as SANITY_ROUTES } from "./sanity-routes.js";
 import { ROUTES as SCHEDULE_ROUTES } from "./schedule-routes.js";
 import { ROUTES as SECRET_ROUTES } from "./secret-routes.js";
@@ -117,6 +118,7 @@ import { ROUTES as SEQUENCE_ROUTES } from "./sequence-routes.js";
 import { ROUTES as SETTINGS_ROUTES } from "./settings-routes.js";
 import { ROUTES as SKILL_ROUTES } from "./skills-routes.js";
 import { ROUTES as SLACK_CHANNEL_RESOLVE_ROUTES } from "./slack-channel-routes.js";
+import { ROUTES as SOUNDS_CONFIG_ROUTES } from "./sounds-config-routes.js";
 import { ROUTES as STT_ROUTES } from "./stt-routes.js";
 import { ROUTES as SUBAGENT_ROUTES } from "./subagents-routes.js";
 import { ROUTES as SUGGEST_TRUST_RULE_ROUTES } from "./suggest-trust-rule-routes.js";
@@ -138,6 +140,7 @@ import { ROUTES as WATCHER_ROUTES } from "./watcher-routes.js";
 import { ROUTES as WEBHOOK_ROUTES } from "./webhook-routes.js";
 import { ROUTES as WIPE_CONVERSATION_ROUTES } from "./wipe-conversation-routes.js";
 import { ROUTES as WORK_ITEM_ROUTES } from "./work-items-routes.js";
+import { ROUTES as WORKFLOW_ROUTES } from "./workflow-routes.js";
 import { ROUTES as WORKSPACE_COMMIT_ROUTES } from "./workspace-commit-routes.js";
 import { ROUTES as WORKSPACE_ROUTES } from "./workspace-routes.js";
 
@@ -238,10 +241,12 @@ export const ROUTES: RouteDefinition[] = [
   ...QUESTION_ROUTES,
   ...RECORDING_ROUTES,
   ...RENAME_CONVERSATION_ROUTES,
+  ...RETROSPECTIVE_ROUTES,
   ...SCHEDULE_ROUTES,
   ...SANITY_ROUTES,
   ...SECRET_ROUTES,
   ...SETTINGS_ROUTES,
+  ...SOUNDS_CONFIG_ROUTES,
   ...SKILL_ROUTES,
   ...A2A_ROUTES,
   ...SLACK_CHANNEL_CONFIG_ROUTES,
@@ -264,6 +269,7 @@ export const ROUTES: RouteDefinition[] = [
   ...USAGE_ROUTES,
   ...VERCEL_ROUTES,
   ...WORK_ITEM_ROUTES,
+  ...WORKFLOW_ROUTES,
   ...WATCHER_ROUTES,
   ...WEBHOOK_ROUTES,
   ...WIPE_CONVERSATION_ROUTES,

package/src/runtime/routes/log-export/AGENTS.md

@@ -5,7 +5,7 @@ from audit DB rows, daemon logs under `<workspace>/data/logs/`, and a
 sanitized `config.json` snapshot. This directory
 (`assistant/src/runtime/routes/log-export/`) houses the allowlist module
 that governs which subpaths of the user's workspace directory
-(`~/.vellum/workspace/`) are permitted to flow into that archive.
+(`$VELLUM_WORKSPACE_DIR/`) are permitted to flow into that archive.
 
 Workspace contents are **opt-in (allowlist), not opt-out**. The workspace
 contains arbitrary user files — skills, hooks, routes, conversations,

package/src/runtime/routes/log-export/workspace-allowlist.ts

@@ -3,7 +3,7 @@
  *
  * `POST /v1/export` collects audit DB rows, daemon logs, and a sanitized
  * `config.json` snapshot. This module governs which subpaths of the user's
- * workspace directory (`~/.vellum/workspace/`) are *opted in* to the export
+ * workspace directory (`$VELLUM_WORKSPACE_DIR/`) are *opted in* to the export
  * archive. The default is "nothing from the workspace ships" — every entry
  * here must be justified against the rules in `./AGENTS.md`.
  *

package/src/runtime/routes/migration-routes.ts

@@ -359,15 +359,11 @@ export async function handleMigrationExport(
         // flush on a multi-GB WAL file can otherwise stall the daemon's
         // event loop for the full duration of the flush.
         //
-        // FULL (not TRUNCATE): TRUNCATE has a side effect where, if the
-        // WAL is empty after the checkpoint, SQLite unlinks the WAL file
-        // from the directory. When the daemon's in-process connection
-        // still holds the original WAL fd, the unlink orphans that fd
-        // into a "ghost WAL" only the daemon can reach, and subsequent
-        // connections create a fresh WAL on disk — split-brain. FULL
-        // gives us the same flush-completion guarantee without the
-        // unlink side effect. See assistant/AGENTS.md "SQLite WAL
-        // checkpointing".
+        // FULL (not TRUNCATE): FULL blocks until every committed frame is
+        // written back to the main `.db` file, which is all the export
+        // needs since it copies that file. TRUNCATE additionally restarts
+        // the WAL and truncates it to zero bytes — extra work and blocking
+        // this path does not need.
         const result = await runAsyncSqlite("PRAGMA wal_checkpoint(FULL)");
         if (!result.ok) {
           // Best-effort: if the DB can't be checkpointed (e.g. not a valid

package/src/runtime/routes/plugins-routes.ts

@@ -295,6 +295,12 @@ const pluginLocalInfoSchema = z
       .describe(
         "Resolved commit the copy was installed at; null when no provenance was recorded.",
       ),
+    committedAt: z
+      .string()
+      .nullable()
+      .describe(
+        "ISO-8601 committer timestamp (UTC) of the installed commit — the human-readable version; null for installs predating commit-timestamp capture. Distinct from `installedAt`.",
+      ),
     version: z
       .string()
       .nullable()
@@ -342,6 +348,12 @@ const pluginRemoteInfoSchema = z
       .describe(
         "Pinned commit SHA the marketplace currently resolves installs to.",
       ),
+    committedAt: z
+      .string()
+      .nullable()
+      .describe(
+        "ISO-8601 committer timestamp (UTC) of the pinned commit, resolved from GitHub; null when the commit metadata could not be fetched.",
+      ),
     description: z.string().nullable(),
     homepage: z.string().nullable(),
     license: z.string().nullable(),
@@ -413,11 +425,23 @@ const pluginUpgradeResponseSchema = z.object({
     .describe(
       "Installed commit before the upgrade; null when no provenance was recorded.",
     ),
+  fromTimestamp: z
+    .string()
+    .nullable()
+    .describe(
+      "ISO-8601 committer timestamp (UTC) of `fromCommit` — the version moved from; null when not recorded.",
+    ),
   toCommit: z
     .string()
     .describe(
       "Marketplace-pinned commit the install was (or would be) moved to.",
     ),
+  toTimestamp: z
+    .string()
+    .nullable()
+    .describe(
+      "ISO-8601 committer timestamp (UTC) of `toCommit` — the version moved to; null when it could not be resolved.",
+    ),
   target: z
     .string()
     .describe("Absolute path to the installed plugin directory on the host."),
@@ -740,7 +764,9 @@ async function handleUpgradePlugin({
       name: result.name,
       outcome: result.outcome,
       fromCommit: result.fromCommit,
+      fromTimestamp: result.fromTimestamp,
       toCommit: result.toCommit,
+      toTimestamp: result.toTimestamp,
       target: result.target,
       fileCount: result.fileCount,
       dryRun: result.dryRun,

package/src/runtime/routes/ps-routes.ts

@@ -29,14 +29,16 @@ interface ProcessEntry {
   info?: string;
 }
 
-const processEntrySchema: z.ZodType<ProcessEntry> = z.lazy(() =>
-  z.object({
-    name: z.string(),
-    status: z.enum(["running", "not_running", "unreachable"]),
-    children: z.array(processEntrySchema).optional(),
-    info: z.string().optional(),
-  }),
-);
+const processEntrySchema: z.ZodType<ProcessEntry> = z
+  .lazy(() =>
+    z.object({
+      name: z.string(),
+      status: z.enum(["running", "not_running", "unreachable"]),
+      children: z.array(processEntrySchema).optional(),
+      info: z.string().optional(),
+    }),
+  )
+  .meta({ id: "ProcessEntry" });
 
 const psResponseSchema = z.object({
   processes: z.array(processEntrySchema),