@vellumai/assistant 0.8.12-staging.1 → 0.8.12

package/src/security/redact-json.ts

@@ -0,0 +1,61 @@
+/**
+ * JSON-aware secret redaction: walk a parsed JSON value and run
+ * `redactSecrets()` over every string leaf (object keys included).
+ *
+ * The redaction marker (`<redacted type="..." />`) contains double quotes,
+ * so splicing it into an already-serialized JSON document corrupts any
+ * string it lands inside. Callers that need to keep serialized JSON valid
+ * must redact the string leaves of the parsed value and re-stringify,
+ * rather than redacting the serialized text.
+ *
+ * Shared by the export-time staged-file sweep (`redact-staged-export.ts`)
+ * and the tool-audit listener (`tool-audit-listener.ts`). The hot-path pino
+ * log serializer (`util/log-redact.ts`) intentionally does not use this
+ * module.
+ */
+
+import { redactSecrets } from "./secret-scanner.js";
+
+export interface RedactedJsonValue {
+  /** Redacted copy of the input (the input itself is never mutated). */
+  value: unknown;
+  /** True when at least one string leaf was changed by redaction. */
+  changed: boolean;
+}
+
+interface RedactionState {
+  changed: boolean;
+}
+
+/**
+ * Redact secrets in every string leaf (keys included) of a parsed JSON
+ * value. Returns the redacted copy plus a `changed` flag so callers can
+ * keep unchanged content byte-identical (no gratuitous re-serialization).
+ */
+export function redactJsonStringLeaves(value: unknown): RedactedJsonValue {
+  const state: RedactionState = { changed: false };
+  return { value: walk(value, state), changed: state.changed };
+}
+
+function walk(value: unknown, state: RedactionState): unknown {
+  if (typeof value === "string") {
+    return redactString(value, state);
+  }
+  if (Array.isArray(value)) {
+    return value.map((item) => walk(item, state));
+  }
+  if (value !== null && typeof value === "object") {
+    return Object.fromEntries(
+      Object.entries(value).map(
+        ([key, val]) => [redactString(key, state), walk(val, state)] as const,
+      ),
+    );
+  }
+  return value;
+}
+
+function redactString(value: string, state: RedactionState): string {
+  const redacted = redactSecrets(value);
+  if (redacted !== value) state.changed = true;
+  return redacted;
+}

package/src/tools/tool-approval-handler.ts

@@ -5,6 +5,10 @@ import {
   getCanonicalGuardianRequest,
   updateCanonicalGuardianRequest,
 } from "../memory/canonical-guardian-store.js";
+import {
+  isUnparseableToolArgs,
+  unparseableToolArgsMessage,
+} from "../providers/unparseable-tool-args.js";
 import { isUntrustedTrustClass } from "../runtime/actor-trust-resolver.js";
 import { createOrReuseToolGrantRequest } from "../runtime/tool-grant-request-helper.js";
 import { redactSecrets } from "../security/secret-scanner.js";
@@ -241,6 +245,33 @@ export class ToolApprovalHandler {
       };
     }
 
+    // Reject tool calls whose arguments failed JSON parsing in the provider
+    // layer (wrapped under the `_raw` marker). Executing with the marker
+    // object would feed garbage input to the tool — and worse, a tool that
+    // tolerates missing fields can "succeed" (e.g. ui_show creating a
+    // typeless surface), so the model never learns its arguments were
+    // mangled. Fail loudly instead so the model retries.
+    if (isUnparseableToolArgs(input)) {
+      const msg = unparseableToolArgsMessage(name, input._raw);
+      const durationMs = Date.now() - startTime;
+      emitLifecycleEvent({
+        type: "error",
+        toolName: name,
+        executionTarget,
+        input,
+        workingDir: context.workingDir,
+        conversationId: context.conversationId,
+        requestId: context.requestId,
+        riskLevel,
+        decision: "error",
+        durationMs,
+        errorMessage: msg,
+        isExpected: true,
+        errorCategory: "tool_failure",
+      });
+      return { allowed: false, result: { content: msg, isError: true } };
+    }
+
     // Reject tool invocations targeting guardian control-plane endpoints from non-guardian actors.
     const guardianCheck = enforceVerificationControlPlanePolicy(
       name,

package/src/workspace/migrations/100-upgrade-quality-profile-to-fable-5.ts

@@ -0,0 +1,86 @@
+import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import type { WorkspaceMigration } from "./types.js";
+
+// Upgrade quality-optimized profiles to Claude Fable 5.
+//
+// The quality-optimized model intent moved to claude-fable-5 (#34498), but
+// the intent map is only consulted when a profile is seeded: off-platform
+// installs reseed managed profiles on every boot, while on-platform
+// workspaces keep the profile they were hatched with — the seeder skips
+// existing profiles there, and the hatch overlay is consumed exactly once.
+// Existing platform assistants are therefore stuck on whichever model the
+// quality intent pointed at when they hatched (claude-opus-4-7 or
+// claude-opus-4-8) until a migration rewrites it.
+//
+// Only the managed quality-optimized profile is touched — the user-owned
+// custom-quality-optimized copy is theirs to manage. Within it, only a model
+// still on a previous quality-intent default is upgraded — matching by model
+// value also covers the OpenRouter-prefixed ids. A profile whose model the
+// user changed to anything else is left untouched.
+
+const TARGET_PROFILES = ["quality-optimized"];
+
+const MODEL_UPGRADES: Record<string, string> = {
+  "claude-opus-4-7": "claude-fable-5",
+  "claude-opus-4-8": "claude-fable-5",
+  "anthropic/claude-opus-4.7": "anthropic/claude-fable-5",
+  "anthropic/claude-opus-4.8": "anthropic/claude-fable-5",
+};
+
+export const upgradeQualityProfileToFable5Migration: WorkspaceMigration = {
+  id: "100-upgrade-quality-profile-to-fable-5",
+  description:
+    "Upgrade the managed quality-optimized profile from Opus 4.7/4.8 to Claude Fable 5",
+  run(workspaceDir: string): void {
+    const configPath = join(workspaceDir, "config.json");
+    if (!existsSync(configPath)) return;
+
+    let config: Record<string, unknown>;
+    try {
+      const raw = JSON.parse(readFileSync(configPath, "utf-8"));
+      if (!raw || typeof raw !== "object" || Array.isArray(raw)) return;
+      config = raw as Record<string, unknown>;
+    } catch {
+      return;
+    }
+
+    const llm = readObject(config.llm);
+    if (llm === null) return;
+
+    const profiles = readObject(llm.profiles);
+    if (profiles === null) return;
+
+    let changed = false;
+
+    for (const name of TARGET_PROFILES) {
+      const profile = readObject(profiles[name]);
+      if (profile === null) continue;
+      if (typeof profile.model !== "string") continue;
+
+      const upgraded = MODEL_UPGRADES[profile.model];
+      if (upgraded === undefined) continue;
+
+      profile.model = upgraded;
+      profiles[name] = profile;
+      changed = true;
+    }
+
+    if (changed) {
+      llm.profiles = profiles;
+      config.llm = llm;
+      writeFileSync(configPath, JSON.stringify(config, null, 2) + "\n");
+    }
+  },
+  down(_workspaceDir: string): void {
+    // Forward-only.
+  },
+};
+
+function readObject(value: unknown): Record<string, unknown> | null {
+  if (value === null || typeof value !== "object" || Array.isArray(value)) {
+    return null;
+  }
+  return value as Record<string, unknown>;
+}

package/src/workspace/migrations/101-upgrade-balanced-economy-to-minimax-m3.ts

@@ -0,0 +1,70 @@
+import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import type { WorkspaceMigration } from "./types.js";
+
+// Switch the Balanced Economy profile from Kimi K2.6 to MiniMax M3.
+//
+// The Fireworks balanced model intent moved to MiniMax M3 (#34726), but the
+// intent map is only consulted when a profile is seeded: off-platform
+// installs reseed managed profiles on every boot, while on-platform
+// workspaces keep the profile they were hatched with — the seeder skips
+// existing profiles there. Existing platform assistants would otherwise stay
+// on Kimi K2.6 (including the now-dropped `suppress-cjk` logit-bias preset)
+// until a migration rewrites the profile.
+//
+// Only the managed balanced-economy profile still pointing at the old
+// default model is touched — a profile whose model the user changed is left
+// alone. The rewrite mirrors the new seed template: MiniMax M3, 32K max
+// output tokens, no logit-bias preset.
+
+const OLD_MODEL = "accounts/fireworks/models/kimi-k2p6";
+const NEW_MODEL = "accounts/fireworks/models/minimax-m3";
+
+export const upgradeBalancedEconomyToMinimaxM3Migration: WorkspaceMigration = {
+  id: "101-upgrade-balanced-economy-to-minimax-m3",
+  description:
+    "Switch the managed Balanced Economy profile from Kimi K2.6 to MiniMax M3",
+  run(workspaceDir: string): void {
+    const configPath = join(workspaceDir, "config.json");
+    if (!existsSync(configPath)) return;
+
+    let config: Record<string, unknown>;
+    try {
+      const raw = JSON.parse(readFileSync(configPath, "utf-8"));
+      if (!raw || typeof raw !== "object" || Array.isArray(raw)) return;
+      config = raw as Record<string, unknown>;
+    } catch {
+      return;
+    }
+
+    const llm = readObject(config.llm);
+    if (llm === null) return;
+
+    const profiles = readObject(llm.profiles);
+    if (profiles === null) return;
+
+    const profile = readObject(profiles["balanced-economy"]);
+    if (profile === null || profile.model !== OLD_MODEL) return;
+
+    profile.model = NEW_MODEL;
+    profile.description =
+      "Strong open model (MiniMax M3) at a lower price point";
+    profile.maxTokens = 32000;
+    delete profile.logitBias;
+    profiles["balanced-economy"] = profile;
+    llm.profiles = profiles;
+    config.llm = llm;
+    writeFileSync(configPath, JSON.stringify(config, null, 2) + "\n");
+  },
+  down(_workspaceDir: string): void {
+    // Forward-only.
+  },
+};
+
+function readObject(value: unknown): Record<string, unknown> | null {
+  if (value === null || typeof value !== "object" || Array.isArray(value)) {
+    return null;
+  }
+  return value as Record<string, unknown>;
+}

package/src/workspace/migrations/registry.ts

@@ -97,6 +97,8 @@ import { reduceQualityProfileEffortMigration } from "./096-reduce-quality-profil
 import { enableAdaptiveThinkingManagedProfilesMigration } from "./097-enable-adaptive-thinking-managed-profiles.js";
 import { removeStaleUpdatesBulletinFileMigration } from "./098-remove-stale-updates-bulletin-file.js";
 import { disableCacheOneShotCallsitesMigration } from "./099-disable-cache-one-shot-callsites.js";
+import { upgradeQualityProfileToFable5Migration } from "./100-upgrade-quality-profile-to-fable-5.js";
+import { upgradeBalancedEconomyToMinimaxM3Migration } from "./101-upgrade-balanced-economy-to-minimax-m3.js";
 import { migrateToWorkspaceVolumeMigration } from "./migrate-to-workspace-volume.js";
 import type { WorkspaceMigration } from "./types.js";
 
@@ -205,4 +207,6 @@ export const WORKSPACE_MIGRATIONS: WorkspaceMigration[] = [
   enableAdaptiveThinkingManagedProfilesMigration,
   removeStaleUpdatesBulletinFileMigration,
   disableCacheOneShotCallsitesMigration,
+  upgradeQualityProfileToFable5Migration,
+  upgradeBalancedEconomyToMinimaxM3Migration,
 ];