@vellumai/assistant 0.8.1 → 0.8.3

package/src/runtime/routes/conversation-query-routes.ts

@@ -28,6 +28,8 @@ import {
   loadRawConfig,
   saveRawConfig,
   setNestedValue,
+  withSuppressedConfigDiskWrites,
+  withSuppressedConfigDiskWritesSync,
 } from "../../config/loader.js";
 import { AssistantConfigSchema } from "../../config/schema.js";
 import { getSchemaAtPath } from "../../config/schema-utils.js";
@@ -57,12 +59,20 @@ import {
   getConversation,
   getMessageById,
 } from "../../memory/conversation-crud.js";
+import { getDb } from "../../memory/db-connection.js";
 import { clearEmbeddingBackendCache } from "../../memory/embedding-backend.js";
 import { getLlmRequestLogSource } from "../../memory/llm-request-log-source.js";
 import { getMemoryRecallLogByMessageIds } from "../../memory/memory-recall-log-store.js";
 import { getMemoryV2ActivationLogByMessageIds } from "../../memory/memory-v2-activation-log-store.js";
 import { MEMORY_V2_CONSOLIDATION_SOURCE } from "../../memory/v2/constants.js";
+import {
+  createConnection,
+  listConnections,
+  PROVIDERS_REQUIRING_BASE_URL_AND_MODELS,
+} from "../../providers/inference/connections.js";
+import { PROVIDER_CATALOG } from "../../providers/model-catalog.js";
 import { initializeProviders } from "../../providers/registry.js";
+import { credentialKey } from "../../security/credential-key.js";
 import { validateAllowlistFile } from "../../security/secret-allowlist.js";
 import { resolvePricingForUsage } from "../../util/pricing.js";
 import { BadRequestError, InternalError, NotFoundError } from "./errors.js";
@@ -229,7 +239,7 @@ function getModelSetContext(): ModelSetContext {
       watcher.suppressConfigReload = value;
     },
     updateConfigFingerprint() {
-      watcher.updateFingerprint();
+      withSuppressedConfigDiskWritesSync(() => watcher.updateFingerprint());
     },
     debounceTimers: watcher.timers,
   };
@@ -377,13 +387,42 @@ function readPlainObject(value: unknown): Record<string, unknown> | undefined {
 
 function handleGetConfig() {
   try {
-    return applyContextDefaultsToRawConfig(loadRawConfig());
+    const config = applyContextDefaultsToRawConfig(loadRawConfig());
+    enrichProfilesWithVisionFlag(config);
+    return config;
   } catch (err) {
     const message = err instanceof Error ? err.message : String(err);
     throw new InternalError(`Failed to read config: ${message}`);
   }
 }
 
+/**
+ * Annotate each profile in `config.llm.profiles` with `supportsVision`
+ * resolved from the model catalog. The flag is wire-only — it is never
+ * persisted to disk. Unknown (provider, model) pairs default to `true`
+ * (fail-open) so image upload remains available for custom / unlisted models.
+ */
+function enrichProfilesWithVisionFlag(config: unknown): void {
+  const root = readPlainObject(config);
+  if (!root) return;
+  const llm = readPlainObject(root.llm);
+  if (!llm) return;
+  const profiles = readPlainObject(llm.profiles);
+  if (!profiles) return;
+
+  for (const profile of Object.values(profiles)) {
+    const entry = readPlainObject(profile);
+    if (!entry) continue;
+    const provider = entry.provider;
+    const model = entry.model;
+    if (typeof provider !== "string" || typeof model !== "string") continue;
+
+    const catalogProvider = PROVIDER_CATALOG.find((p) => p.id === provider);
+    const catalogModel = catalogProvider?.models.find((m) => m.id === model);
+    entry.supportsVision = catalogModel?.supportsVision ?? true;
+  }
+}
+
 /**
  * Return the JSON Schema for the assistant config (full or scoped).
  *
@@ -471,15 +510,14 @@ async function commitConfigWrite(
 
   clearEmbeddingBackendCache();
   invalidateConfigCache();
-  // Reinitialize providers so the live registry reflects the new config
-  // (e.g. a mode flip between managed and your-own). Isolated try/catch so
-  // a provider reinit failure doesn't mask the successful config save.
-  // Only advance the config fingerprint on success - if reinit failed, leave
-  // it stale so the watcher can detect the saved config on the next event
-  // and retry provider initialization.
+  // Reinitialize providers so the live registry reflects the new config.
+  // Suppress disk writes inside loadConfig() — we just wrote the raw config
+  // and the first-launch seed path would overwrite it with full defaults.
   try {
-    await initializeProviders(getConfig());
-    configWatcher.updateFingerprint();
+    await withSuppressedConfigDiskWrites(async () => {
+      await initializeProviders(getConfig());
+      configWatcher.updateFingerprint();
+    });
   } catch (err) {
     const message = err instanceof Error ? err.message : String(err);
     log.error({ err }, `${opLabel} config: provider reinit failed: ${message}`);
@@ -577,7 +615,7 @@ function handleValidateAllowlist() {
   }
 }
 
-function handleReplaceInferenceProfile({
+async function handleReplaceInferenceProfile({
   pathParams = {},
   body,
 }: RouteHandlerArgs) {
@@ -616,32 +654,58 @@ function handleReplaceInferenceProfile({
       );
     }
   }
-  try {
-    const raw = loadRawConfig();
-    if (isManaged) {
-      // Partial overlay: keep every existing key intact, only update label
-      // and/or status from the fragment. Using `replaceInferenceProfileConfig`
-      // here would wipe the UI-owned seed fields (provider, model, advanced
-      // params) because that function assumes the body carries the full UI
-      // surface.
-      patchManagedProfileFields(
-        raw,
-        name,
-        parsed.data as Record<string, unknown>,
-      );
-    } else {
-      replaceInferenceProfileConfig(
-        raw,
-        name,
-        parsed.data as Record<string, unknown>,
-      );
+  // When the UI sends provider but no provider_connection ("Any active X
+  // connection"), derive the connection now so the config deep-merge doesn't
+  // inherit a stale connection from the default layer.
+  const fragment = parsed.data as Record<string, unknown>;
+  if (!isManaged && fragment.provider && !fragment.provider_connection) {
+    const provider = fragment.provider as string;
+    const db = getDb();
+    const candidates = listConnections(db, { provider });
+    const active = candidates.find((c) => c.status === "active");
+    if (active) {
+      fragment.provider_connection = active.name;
+    } else if (!PROVIDERS_REQUIRING_BASE_URL_AND_MODELS.has(provider)) {
+      const connectionName = `${provider}-personal`;
+      const isKeyless = provider === "ollama";
+      const result = createConnection(db, {
+        name: connectionName,
+        provider,
+        auth: isKeyless
+          ? { type: "none" }
+          : {
+              type: "api_key",
+              credential: credentialKey(provider, "api_key"),
+            },
+      });
+      if (result.ok) {
+        fragment.provider_connection = connectionName;
+      }
     }
-    saveRawConfig(raw);
-    return { ok: true };
-  } catch (err) {
-    const message = err instanceof Error ? err.message : String(err);
-    throw new InternalError(`Failed to replace inference profile: ${message}`);
   }
+
+  const raw = loadRawConfig();
+  if (isManaged) {
+    // Partial overlay: keep every existing key intact, only update label
+    // and/or status from the fragment. Using `replaceInferenceProfileConfig`
+    // here would wipe the UI-owned seed fields (provider, model, advanced
+    // params) because that function assumes the body carries the full UI
+    // surface.
+    patchManagedProfileFields(raw, name, fragment);
+  } else {
+    replaceInferenceProfileConfig(raw, name, fragment);
+  }
+  // Route through `commitConfigWrite` so profile edits flow through the
+  // post-write side effects shared with `handlePatchConfig` /
+  // `handleSetConfig`: file-watcher suppression so the in-process reload
+  // doesn't race the explicit reinit, embedding backend cache clear,
+  // in-process `getConfig` cache invalidation, and provider registry
+  // reinitialization. `status: "disabled"` on a managed profile (and any
+  // `provider` / `model` / `provider_connection` change on a custom
+  // profile) must take effect immediately rather than waiting for the
+  // next watcher tick.
+  await commitConfigWrite(raw, "replace inference profile");
+  return { ok: true };
 }
 
 /**

package/src/runtime/routes/conversation-routes.ts

@@ -90,18 +90,24 @@ import {
   getOrCreateConversation,
 } from "../../memory/conversation-key-store.js";
 import { searchConversations } from "../../memory/conversation-queries.js";
+import { recordOnboardingEvent } from "../../memory/onboarding-events-store.js";
+import { buildSlackMessageDeepLinks } from "../../messaging/providers/slack/deep-link.js";
+import {
+  readSlackMetadataFromMessageMetadata,
+  type SlackMessageMetadata,
+} from "../../messaging/providers/slack/message-metadata.js";
 import { normalizeOnboardingContext } from "../../prompts/normalize-onboarding.js";
 import { writeOnboardingSection } from "../../prompts/persona-resolver.js";
 import { getConfiguredProvider } from "../../providers/provider-send-message.js";
 import type { Provider } from "../../providers/types.js";
 import { checkIngressForSecrets } from "../../security/secret-ingress.js";
+import { getSubagentManager } from "../../subagent/index.js";
 import { getLogger } from "../../util/logger.js";
 import {
   getInterfacesDir,
   getWorkspacePromptPath,
 } from "../../util/platform.js";
 import { silentlyWithLog } from "../../util/silently.js";
-import { buildAssistantEvent } from "../assistant-event.js";
 import { assistantEventHub, broadcastMessage } from "../assistant-event-hub.js";
 import { DAEMON_INTERNAL_ASSISTANT_ID } from "../assistant-scope.js";
 import { routeGuardianReply } from "../guardian-reply-router.js";
@@ -114,6 +120,10 @@ import type {
 } from "../http-types.js";
 import { resolveLocalTrustContext } from "../local-actor-identity.js";
 import * as pendingInteractions from "../pending-interactions.js";
+import {
+  publishConversationListAndMetadataChanged,
+  publishConversationMessagesChanged,
+} from "../sync/resource-sync-events.js";
 import {
   resolveTrustContext,
   withSourceChannel,
@@ -138,6 +148,36 @@ function isValidRiskThreshold(value: unknown): value is RiskThreshold {
   );
 }
 
+function buildSlackHistoryMessage(
+  slackMeta: SlackMessageMetadata | null,
+): RuntimeMessagePayload["slackMessage"] | undefined {
+  if (!slackMeta) return undefined;
+
+  const slackConfig = getConfig().slack;
+  const messageLink = buildSlackMessageDeepLinks({
+    teamId: slackConfig?.teamId,
+    teamUrl: slackConfig?.teamUrl,
+    channelId: slackMeta.channelId,
+    messageTs: slackMeta.channelTs,
+  });
+  const threadLink = slackMeta.threadTs
+    ? buildSlackMessageDeepLinks({
+        teamId: slackConfig?.teamId,
+        teamUrl: slackConfig?.teamUrl,
+        channelId: slackMeta.channelId,
+        messageTs: slackMeta.threadTs,
+      })
+    : undefined;
+
+  return {
+    channelId: slackMeta.channelId,
+    channelTs: slackMeta.channelTs,
+    ...(slackMeta.threadTs ? { threadTs: slackMeta.threadTs } : {}),
+    ...(messageLink ? { messageLink } : {}),
+    ...(threadLink ? { threadLink } : {}),
+  };
+}
+
 function collectCanonicalGuardianRequestHintIds(
   conversationId: string,
   sourceChannel: string,
@@ -339,6 +379,7 @@ async function tryConsumeCanonicalGuardianReply(params: {
       });
       onEvent({ type: "message_complete", conversationId: conversationId });
     }
+    publishConversationMessagesChanged(conversationId);
   } catch (err) {
     log.warn(
       { err, conversationId },
@@ -506,6 +547,9 @@ export function handleListMessages(
               ...(typeof n.conversationId === "string"
                 ? { conversationId: n.conversationId }
                 : {}),
+              ...(typeof n.objective === "string"
+                ? { objective: n.objective }
+                : {}),
             };
           }
         }
@@ -513,6 +557,9 @@ export function handleListMessages(
         // Ignore malformed metadata
       }
     }
+    const slackMessage = buildSlackHistoryMessage(
+      readSlackMetadataFromMessageMetadata(msg.metadata),
+    );
 
     // Strip <no_response/> markers from assistant messages so web/API
     // clients never see the raw sentinel. Only assistant messages produce
@@ -552,6 +599,7 @@ export function handleListMessages(
         textSegments: filteredSegments,
         contentOrder: filteredContentOrder,
         surfaces: rendered.surfaces,
+        slackMessage,
         ...(rendered.thinkingSegments.length > 0
           ? { thinkingSegments: rendered.thinkingSegments }
           : {}),
@@ -570,6 +618,7 @@ export function handleListMessages(
       textSegments: rendered.textSegments,
       contentOrder: rendered.contentOrder,
       surfaces: rendered.surfaces,
+      slackMessage,
       ...(rendered.thinkingSegments.length > 0
         ? { thinkingSegments: rendered.thinkingSegments }
         : {}),
@@ -678,6 +727,7 @@ export function handleListMessages(
       ...(m.subagentNotification
         ? { subagentNotification: m.subagentNotification }
         : {}),
+      ...(m.slackMessage ? { slackMessage: m.slackMessage } : {}),
     };
   });
 
@@ -1117,6 +1167,8 @@ export async function handleSendMessage(
       tone: string;
       userName?: string;
       assistantName?: string;
+      googleConnected?: boolean;
+      googleScopes?: string[];
     };
   };
 
@@ -1293,16 +1345,10 @@ export async function handleSendMessage(
   // that other clients don't yet know about.
   if (mapping.conversationType === "standard") {
     if (!hasMessages(mapping.conversationId)) {
-      smDeps.assistantEventHub
-        .publish(
-          buildAssistantEvent({
-            type: "conversation_list_invalidated",
-            reason: "created",
-          }),
-        )
-        .catch((err) => {
-          log.warn({ err }, "Failed to publish conversation_list_invalidated");
-        });
+      publishConversationListAndMetadataChanged(
+        "created",
+        mapping.conversationId,
+      );
     }
   }
 
@@ -1447,6 +1493,12 @@ export async function handleSendMessage(
   // that can service host_browser_request events; we restore that single
   // proxy explicitly below without relaxing `hasNoClient`.
   conversation.updateClient(broadcastMessage, !isInteractive);
+  if (isInteractive) {
+    getSubagentManager().updateParentSender(
+      mapping.conversationId,
+      broadcastMessage,
+    );
+  }
 
   // ── Canned first-greeting fast path ──
   // On a completely fresh workspace, skip LLM inference for the macOS
@@ -1509,6 +1561,18 @@ export async function handleSendMessage(
 
       if (isFirstOnboarding) {
         persistOnboardingArtifacts(body.onboarding!);
+        try {
+          recordOnboardingEvent({
+            screen: "complete",
+            tools: body.onboarding!.tools,
+            tasks: body.onboarding!.tasks,
+            tone: body.onboarding!.tone,
+            googleConnected: body.onboarding!.googleConnected,
+            googleScopes: body.onboarding!.googleScopes,
+          });
+        } catch (err) {
+          log.warn({ err }, "Failed to record onboarding telemetry event");
+        }
       }
 
       setTimeout(() => {
@@ -1525,6 +1589,7 @@ export async function handleSendMessage(
           conversationId,
         });
         broadcastMessage({ type: "message_complete", conversationId });
+        publishConversationMessagesChanged(conversationId);
         conversation.processing = false;
         silentlyWithLog(
           conversation.drainQueue(),
@@ -1550,6 +1615,18 @@ export async function handleSendMessage(
 
   if (isFirstOnboarding) {
     persistOnboardingArtifacts(body.onboarding!);
+    try {
+      recordOnboardingEvent({
+        screen: "complete",
+        tools: body.onboarding!.tools,
+        tasks: body.onboarding!.tasks,
+        tone: body.onboarding!.tone,
+        googleConnected: body.onboarding!.googleConnected,
+        googleScopes: body.onboarding!.googleScopes,
+      });
+    } catch (err) {
+      log.warn({ err }, "Failed to record onboarding telemetry event");
+    }
   }
 
   const attachments = hasAttachments
@@ -1828,6 +1905,7 @@ export async function handleSendMessage(
           type: "message_complete",
           conversationId: conversationId,
         });
+        publishConversationMessagesChanged(conversationId);
         conversation.processing = false;
         silentlyWithLog(conversation.drainQueue(), "slash-command queue drain");
       }, 0);
@@ -1869,6 +1947,7 @@ export async function handleSendMessage(
     // forceCompact() makes an LLM call that can exceed the client's
     // HTTP timeout on large contexts, causing a false "Failed to send".
     (async () => {
+      let assistantMessagePersisted = false;
       try {
         broadcastMessage({
           type: "user_message_echo",
@@ -1877,6 +1956,7 @@ export async function handleSendMessage(
           messageId: persisted.id,
           clientMessageId,
         });
+        publishConversationMessagesChanged(conversationId);
         conversation.emitActivityState(
           "thinking",
           "context_compacting",
@@ -1894,6 +1974,7 @@ export async function handleSendMessage(
           JSON.stringify(assistantMsg.content),
           channelMeta,
         );
+        assistantMessagePersisted = true;
         conversation.getMessages().push(assistantMsg);
 
         broadcastMessage({
@@ -1902,7 +1983,11 @@ export async function handleSendMessage(
           conversationId,
         });
         broadcastMessage({ type: "message_complete", conversationId });
+        publishConversationMessagesChanged(conversationId);
       } catch (err) {
+        if (assistantMessagePersisted) {
+          publishConversationMessagesChanged(conversationId);
+        }
         log.error({ err, conversationId }, "Compact command failed");
         broadcastMessage({
           type: "conversation_error",
@@ -1950,6 +2035,7 @@ export async function handleSendMessage(
     requestId,
     clientMessageId,
   });
+  publishConversationMessagesChanged(mapping.conversationId);
 
   // Fire-and-forget the agent loop; events flow to the hub via broadcastMessage.
   conversation

package/src/runtime/routes/documents-routes.ts

@@ -6,8 +6,12 @@
  */
 import { z } from "zod";
 
-import { saveDocument } from "../../documents/document-store.js";
-import { rawAll, rawGet } from "../../memory/raw-query.js";
+import {
+  getDocumentById,
+  getDocumentsForConversation,
+  saveDocument,
+} from "../../documents/document-store.js";
+import { rawAll } from "../../memory/raw-query.js";
 import { getLogger } from "../../util/logger.js";
 import { renderMarkdownToPDF } from "./document-pdf-renderer.js";
 import { BadRequestError, InternalError, NotFoundError } from "./errors.js";
@@ -16,65 +20,16 @@ import { RouteResponse } from "./types.js";
 
 const log = getLogger("documents-routes");
 
-interface DocumentRow {
+interface DocumentListRow {
   surface_id: string;
   conversation_id: string;
   title: string;
-  content: string;
   word_count: number;
   created_at: number;
   updated_at: number;
 }
 
-type DocumentListRow = Omit<DocumentRow, "content">;
-
-function loadDocument(surfaceId: string):
-  | {
-      success: true;
-      surfaceId: string;
-      conversationId: string;
-      title: string;
-      content: string;
-      wordCount: number;
-      createdAt: number;
-      updatedAt: number;
-    }
-  | { success: false; error: string } {
-  try {
-    const result = rawGet<DocumentRow>(
-      /*sql*/ `
-      SELECT surface_id, conversation_id, title, content, word_count, created_at, updated_at
-      FROM documents
-      WHERE surface_id = ?
-    `,
-      surfaceId,
-    );
-
-    if (result) {
-      log.info({ surfaceId }, "Loaded document");
-      return {
-        success: true,
-        surfaceId: result.surface_id,
-        conversationId: result.conversation_id,
-        title: result.title,
-        content: result.content,
-        wordCount: result.word_count,
-        createdAt: result.created_at,
-        updatedAt: result.updated_at,
-      };
-    }
-    log.info({ surfaceId }, "Document not found");
-    return { success: false, error: "Document not found" };
-  } catch (error) {
-    log.error({ err: error, surfaceId }, "Load error");
-    return {
-      success: false,
-      error: error instanceof Error ? error.message : "Unknown error",
-    };
-  }
-}
-
-function listDocuments(conversationId?: string): Array<{
+function listAllDocuments(): Array<{
   surfaceId: string;
   conversationId: string;
   title: string;
@@ -83,29 +38,11 @@ function listDocuments(conversationId?: string): Array<{
   updatedAt: number;
 }> {
   try {
-    let results: DocumentListRow[];
-
-    if (conversationId) {
-      // Query via junction table so we return the *matched* conversation_id
-      // (not the origin conversation_id from the documents table).
-      results = rawAll<DocumentListRow>(
-        /*sql*/ `
-        SELECT d.surface_id, dc.conversation_id AS conversation_id,
-               d.title, d.word_count, d.created_at, d.updated_at
-        FROM documents d
-        INNER JOIN document_conversations dc ON d.surface_id = dc.surface_id
-        WHERE dc.conversation_id = ?
-        ORDER BY d.updated_at DESC
-        `,
-        conversationId,
-      );
-    } else {
-      results = rawAll<DocumentListRow>(/*sql*/ `
-        SELECT surface_id, conversation_id, title, word_count, created_at, updated_at
-        FROM documents
-        ORDER BY updated_at DESC
-        `);
-    }
+    const results = rawAll<DocumentListRow>(/*sql*/ `
+      SELECT surface_id, conversation_id, title, word_count, created_at, updated_at
+      FROM documents
+      ORDER BY updated_at DESC
+      `);
 
     log.info({ count: results.length }, "Listed documents");
     return results.map((row) => ({
@@ -148,7 +85,9 @@ export const ROUTES: RouteDefinition[] = [
     }),
     handler: ({ queryParams }) => {
       const conversationId = queryParams?.conversationId ?? undefined;
-      const documents = listDocuments(conversationId);
+      const documents = conversationId
+        ? getDocumentsForConversation(conversationId)
+        : listAllDocuments();
       return { documents };
     },
   },
@@ -173,11 +112,11 @@ export const ROUTES: RouteDefinition[] = [
       updatedAt: z.number(),
     }),
     handler: ({ pathParams }) => {
-      const result = loadDocument(pathParams!.id);
-      if (!result.success) {
-        throw new NotFoundError(result.error);
+      const doc = getDocumentById(pathParams!.id);
+      if (!doc) {
+        throw new NotFoundError("Document not found");
       }
-      return result;
+      return { success: true, ...doc };
     },
   },
 
@@ -252,13 +191,13 @@ export const ROUTES: RouteDefinition[] = [
     description: "Render a document to PDF and return the binary content.",
     tags: ["documents"],
     handler: async ({ pathParams }) => {
-      const result = loadDocument(pathParams!.id);
-      if (!result.success) {
-        throw new NotFoundError(result.error);
+      const doc = getDocumentById(pathParams!.id);
+      if (!doc) {
+        throw new NotFoundError("Document not found");
       }
-      const pdfBuffer = await renderMarkdownToPDF(result.title, result.content);
+      const pdfBuffer = await renderMarkdownToPDF(doc.title, doc.content);
       const filename =
-        result.title
+        doc.title
           .replace(/[^a-zA-Z0-9_-]/g, "-")
           .replace(/-+/g, "-")
           .replace(/^-|-$/g, "") || "document";

package/src/runtime/routes/group-routes.ts

@@ -18,6 +18,7 @@ import {
   reorderGroups,
   updateGroup,
 } from "../../memory/group-crud.js";
+import { publishConversationListChanged } from "../sync/resource-sync-events.js";
 import { BadRequestError, ForbiddenError, NotFoundError } from "./errors.js";
 import type { RouteDefinition, RouteHandlerArgs } from "./types.js";
 
@@ -47,6 +48,7 @@ function handleCreateGroup({ body = {} }: RouteHandlerArgs) {
   }
   try {
     const group = createGroup(name);
+    publishConversationListChanged("created");
     return serializeGroup(group);
   } catch (err) {
     if (
@@ -90,6 +92,7 @@ function handleUpdateGroup({ pathParams = {}, body = {} }: RouteHandlerArgs) {
   if (!updated) {
     throw new NotFoundError("Group not found");
   }
+  publishConversationListChanged("reordered");
   return serializeGroup(updated);
 }
 
@@ -103,6 +106,7 @@ function handleDeleteGroup({ pathParams = {} }: RouteHandlerArgs) {
     throw new ForbiddenError("System groups cannot be deleted");
   }
   deleteGroup(groupId);
+  publishConversationListChanged("reordered");
 }
 
 function handleReorderGroups({ body = {} }: RouteHandlerArgs) {
@@ -131,6 +135,7 @@ function handleReorderGroups({ body = {} }: RouteHandlerArgs) {
     }
   }
   reorderGroups(updates);
+  publishConversationListChanged("reordered");
   return { ok: true };
 }