@vellumai/assistant 0.8.0 → 0.8.2

package/src/runtime/routes/memory-v2-routes.ts

@@ -1,8 +1,6 @@
 /**
- * Memory v2 route definitions — backfill + validate + reembed-skills.
- *
- * Migrated from `ipc/routes/memory-v2-backfill.ts` and
- * `ipc/routes/memory-v2-validate.ts` into the shared ROUTES array.
+ * Memory v2 route definitions — backfill, validate, concept-page reads,
+ * reembed-skills, and the activation-log concept-frequency aggregator.
  */
 import { stat } from "node:fs/promises";
 import { join } from "node:path";
@@ -10,16 +8,6 @@ import { join } from "node:path";
 import { z } from "zod";
 
 import { loadConfig } from "../../config/loader.js";
-import {
-  applyCorrectionIfCalibrated,
-  explainedVarianceRatio,
-  fitAnisotropyCalibration,
-  saveCalibration,
-} from "../../memory/anisotropy.js";
-import {
-  embedWithBackend,
-  selectEmbeddingBackend,
-} from "../../memory/embedding-backend.js";
 import {
   enqueueMemoryJob,
   type MemoryJobType,
@@ -39,17 +27,7 @@ import {
   readPage,
   renderPageContent,
 } from "../../memory/v2/page-store.js";
-import {
-  hybridQueryConceptPages,
-  sampleConceptPageDenseVectors,
-} from "../../memory/v2/qdrant.js";
-import { effectiveWeights } from "../../memory/v2/sim.js";
 import { seedV2SkillEntries } from "../../memory/v2/skill-store.js";
-import {
-  generateBm25QueryEmbedding,
-  getConceptPageCorpusStats,
-  rebuildConceptPageCorpusStats,
-} from "../../memory/v2/sparse-bm25.js";
 import { getLogger } from "../../util/logger.js";
 import { getWorkspaceDir } from "../../util/platform.js";
 import { RouteError } from "./errors.js";
@@ -132,7 +110,11 @@ export type MemoryV2ValidateResult = {
 async function handleValidate({
   body = {},
 }: RouteHandlerArgs): Promise<MemoryV2ValidateResult> {
-  requireMemoryV2Enabled();
+  // Intentionally NOT gated on `memory.v2.enabled`. Validate is a read-only
+  // diagnostic walk over the on-disk concept-page workspace and must be
+  // runnable before flipping the flag — operators (and the
+  // vellum-memory-v2-migration skill) use it as the final dry-run check
+  // immediately before enabling v2.
   MemoryV2ValidateParams.parse(body);
 
   const workspaceDir = getWorkspaceDir();
@@ -148,7 +130,7 @@ async function handleValidate({
       const page = await readPage(workspaceDir, slug);
       if (!page) continue;
       knownSlugs.add(slug);
-      const chars = Buffer.byteLength(page.body, "utf8");
+      const chars = page.body.length;
       if (chars > maxPageChars) {
         oversizedPages.push({ slug, chars });
       }
@@ -265,41 +247,6 @@ async function handleListConceptPages({
   return { pages };
 }
 
-// ── Rebuild BM25 corpus stats ───────────────────────────────────────────
-
-const MemoryV2RebuildCorpusStatsParams = z.object({}).strict();
-
-export interface MemoryV2RebuildCorpusStatsResult {
-  totalDocs: number;
-  avgDl: number;
-  /** Number of distinct hashed-token buckets that received any DF count. */
-  vocabularyBuckets: number;
-}
-
-async function handleRebuildCorpusStats({
-  body = {},
-}: RouteHandlerArgs): Promise<MemoryV2RebuildCorpusStatsResult> {
-  requireMemoryV2Enabled();
-  MemoryV2RebuildCorpusStatsParams.parse(body);
-  const workspaceDir = getWorkspaceDir();
-  await rebuildConceptPageCorpusStats(workspaceDir);
-  const stats = getConceptPageCorpusStats();
-  if (!stats) {
-    // The rebuild always swaps in a non-null table on success, so a missing
-    // value here means an unexpected reset between rebuild and read.
-    throw new RouteError(
-      "Corpus stats rebuild completed but no table is loaded",
-      "MEMORY_V2_CORPUS_STATS_MISSING",
-      500,
-    );
-  }
-  return {
-    totalDocs: stats.totalDocs,
-    avgDl: stats.avgDl,
-    vocabularyBuckets: stats.df.size,
-  };
-}
-
 // ── Reembed skills ──────────────────────────────────────────────────────
 
 const MemoryV2ReembedSkillsParams = z.object({}).strict();
@@ -316,226 +263,14 @@ async function handleReembedSkills({
 
   // Unlike the queued backfill jobs above, this is a CLI-driven sync
   // request: the operator wants the cache replaced before the next prompt
-  // assembly, so we await the seed inline rather than enqueueing it.
-  await seedV2SkillEntries();
+  // assembly, so we await the seed inline rather than enqueueing it. Pass
+  // `throwOnError` so embedding/Qdrant failures surface to the CLI instead
+  // of being swallowed by the default best-effort behavior.
+  await seedV2SkillEntries({ throwOnError: true });
 
   return { success: true };
 }
 
-// ── Explain similarity ──────────────────────────────────────────────────
-
-const MemoryV2ExplainSimilarityParams = z
-  .object({
-    userText: z.string().min(1),
-    assistantText: z.string().optional(),
-    nowText: z.string().optional(),
-    top: z.number().int().min(1).default(25),
-  })
-  .strict();
-
-export interface MemoryV2ExplainSimilarityRow {
-  slug: string;
-  /** Raw dense cosine score, or null when the slug missed the dense channel. */
-  denseScore: number | null;
-  /** Raw sparse score (Qdrant scale), or null when the slug missed sparse. */
-  sparseRaw: number | null;
-  /** Sparse score divided by the per-batch max, in [0, 1]. */
-  sparseNorm: number | null;
-  /** `clamp01(dense_weight·dense + sparse_weight·sparseNorm)` — the simBatch fused value. */
-  fused: number;
-}
-
-export interface MemoryV2ExplainSimilarityStats {
-  count: number;
-  min: number;
-  max: number;
-  mean: number;
-  stddev: number;
-}
-
-export interface MemoryV2ExplainSimilarityChannel {
-  channel: "user" | "assistant" | "now";
-  textPreview: string;
-  maxSparse: number;
-  /**
-   * Spread (max - min) of normalized sparse scores across this channel's
-   * hits. Drives adaptive sparse weighting — low spread means the sparse
-   * channel can't discriminate, so its weight collapses for this query.
-   */
-  sparseSpread: number;
-  /** Sparse weight after adaptive collapse (≤ the configured base). */
-  effectiveSparseWeight: number;
-  /** Dense weight after adaptive compensation (≥ the configured base). */
-  effectiveDenseWeight: number;
-  rows: MemoryV2ExplainSimilarityRow[];
-  stats: {
-    dense: MemoryV2ExplainSimilarityStats;
-    sparseRaw: MemoryV2ExplainSimilarityStats;
-    sparseNorm: MemoryV2ExplainSimilarityStats;
-    fused: MemoryV2ExplainSimilarityStats;
-  };
-}
-
-export interface MemoryV2ExplainSimilarityResult {
-  config: {
-    dense_weight: number;
-    sparse_weight: number;
-  };
-  channels: MemoryV2ExplainSimilarityChannel[];
-}
-
-function summarizeStats(values: number[]): MemoryV2ExplainSimilarityStats {
-  if (values.length === 0) {
-    return { count: 0, min: 0, max: 0, mean: 0, stddev: 0 };
-  }
-  let min = Infinity;
-  let max = -Infinity;
-  let sum = 0;
-  for (const v of values) {
-    if (v < min) min = v;
-    if (v > max) max = v;
-    sum += v;
-  }
-  const mean = sum / values.length;
-  let sqDiff = 0;
-  for (const v of values) sqDiff += (v - mean) * (v - mean);
-  const stddev = Math.sqrt(sqDiff / values.length);
-  return { count: values.length, min, max, mean, stddev };
-}
-
-async function scoreChannel(
-  channel: "user" | "assistant" | "now",
-  text: string,
-  top: number,
-  denseWeight: number,
-  sparseWeight: number,
-  config: ReturnType<typeof loadConfig>,
-): Promise<MemoryV2ExplainSimilarityChannel> {
-  const denseResult = await embedWithBackend(config, [text]);
-  const denseVec = await applyCorrectionIfCalibrated(
-    denseResult.vectors[0],
-    denseResult.provider,
-    denseResult.model,
-  );
-  const sparseVec = generateBm25QueryEmbedding(text);
-
-  const hits = await hybridQueryConceptPages(denseVec, sparseVec, top);
-
-  let maxSparse = 0;
-  for (const hit of hits) {
-    if (hit.sparseScore !== undefined && hit.sparseScore > maxSparse) {
-      maxSparse = hit.sparseScore;
-    }
-  }
-
-  // Mirror simBatch's adaptive weighting so the printed `fused` matches what
-  // production retrieval would actually score for this query — otherwise
-  // operators staring at the diagnostic would see different numbers than
-  // the activation pipeline saw.
-  const {
-    dense: effDense,
-    sparse: effSparse,
-    spread: sparseSpread,
-  } = effectiveWeights(hits, maxSparse, denseWeight, sparseWeight, config);
-
-  const rows: MemoryV2ExplainSimilarityRow[] = hits.map((hit) => {
-    const dense = hit.denseScore ?? 0;
-    const sparseNorm =
-      hit.sparseScore !== undefined && maxSparse > 0
-        ? hit.sparseScore / maxSparse
-        : 0;
-    const fusedRaw = effDense * dense + effSparse * sparseNorm;
-    const fused = Math.max(0, Math.min(1, fusedRaw));
-    return {
-      slug: hit.slug,
-      denseScore: hit.denseScore ?? null,
-      sparseRaw: hit.sparseScore ?? null,
-      sparseNorm: hit.sparseScore !== undefined ? sparseNorm : null,
-      fused,
-    };
-  });
-
-  rows.sort((a, b) => b.fused - a.fused);
-
-  const denseValues: number[] = [];
-  const sparseRawValues: number[] = [];
-  const sparseNormValues: number[] = [];
-  const fusedValues: number[] = [];
-  for (const row of rows) {
-    if (row.denseScore !== null) denseValues.push(row.denseScore);
-    if (row.sparseRaw !== null) sparseRawValues.push(row.sparseRaw);
-    if (row.sparseNorm !== null) sparseNormValues.push(row.sparseNorm);
-    fusedValues.push(row.fused);
-  }
-
-  return {
-    channel,
-    textPreview: text.length > 120 ? `${text.slice(0, 120)}…` : text,
-    maxSparse,
-    sparseSpread,
-    effectiveSparseWeight: effSparse,
-    effectiveDenseWeight: effDense,
-    rows,
-    stats: {
-      dense: summarizeStats(denseValues),
-      sparseRaw: summarizeStats(sparseRawValues),
-      sparseNorm: summarizeStats(sparseNormValues),
-      fused: summarizeStats(fusedValues),
-    },
-  };
-}
-
-async function handleExplainSimilarity({
-  body = {},
-}: RouteHandlerArgs): Promise<MemoryV2ExplainSimilarityResult> {
-  requireMemoryV2Enabled();
-  const params = MemoryV2ExplainSimilarityParams.parse(body);
-  const config = loadConfig();
-  const { dense_weight: denseWeight, sparse_weight: sparseWeight } =
-    config.memory.v2;
-
-  const channels: MemoryV2ExplainSimilarityChannel[] = [];
-  channels.push(
-    await scoreChannel(
-      "user",
-      params.userText,
-      params.top,
-      denseWeight,
-      sparseWeight,
-      config,
-    ),
-  );
-  if (params.assistantText && params.assistantText.length > 0) {
-    channels.push(
-      await scoreChannel(
-        "assistant",
-        params.assistantText,
-        params.top,
-        denseWeight,
-        sparseWeight,
-        config,
-      ),
-    );
-  }
-  if (params.nowText && params.nowText.length > 0) {
-    channels.push(
-      await scoreChannel(
-        "now",
-        params.nowText,
-        params.top,
-        denseWeight,
-        sparseWeight,
-        config,
-      ),
-    );
-  }
-
-  return {
-    config: { dense_weight: denseWeight, sparse_weight: sparseWeight },
-    channels,
-  };
-}
-
 // ── Concept injection frequency (debug-only) ────────────────────────────
 
 const MemoryV2ConceptFrequencyParams = z
@@ -555,93 +290,6 @@ async function handleConceptFrequency({
   return getConceptFrequencySummary(workspaceDir, { conversationId, sinceMs });
 }
 
-// ── Fit anisotropy calibration ──────────────────────────────────────────
-
-const MemoryV2FitAnisotropyParams = z
-  .object({
-    /**
-     * Number of leading principal components to project out at apply time.
-     * `1` is the canonical default for transformer embeddings; raise to 2-3
-     * only when the variance spectrum shows multiple dominant directions.
-     */
-    k: z.number().int().min(1).max(16).default(1),
-    /**
-     * Maximum number of stored vectors to pull from Qdrant for the fit.
-     * 5_000 is plenty for 3072-dim Gemini — power iteration converges fast
-     * and pulling the full corpus would just cost wall-clock time.
-     */
-    sample: z.number().int().min(1).max(100_000).default(5_000),
-  })
-  .strict();
-
-export interface MemoryV2FitAnisotropyResult {
-  provider: string;
-  model: string;
-  dim: number;
-  k: number;
-  sampleCount: number;
-  totalVariance: number;
-  componentVariance: number[];
-  /** `componentVariance[i] / totalVariance` for each component. */
-  explainedVarianceRatio: number[];
-  /** Absolute path the calibration was written to. */
-  path: string;
-}
-
-async function handleFitAnisotropy({
-  body = {},
-}: RouteHandlerArgs): Promise<MemoryV2FitAnisotropyResult> {
-  requireMemoryV2Enabled();
-  const { k, sample } = MemoryV2FitAnisotropyParams.parse(body);
-  const config = loadConfig();
-
-  const selection = await selectEmbeddingBackend(config);
-  if (!selection.backend) {
-    throw new RouteError(
-      `Cannot fit anisotropy calibration: ${selection.reason ?? "no embedding backend configured"}`,
-      "MEMORY_V2_NO_EMBEDDING_BACKEND",
-      409,
-    );
-  }
-
-  const vectors = await sampleConceptPageDenseVectors(sample);
-  if (vectors.length === 0) {
-    throw new RouteError(
-      "Cannot fit anisotropy calibration: the v2 concept-page collection is empty. " +
-        "Embed some concept pages first (run `assistant memory v2 reembed`), then retry.",
-      "MEMORY_V2_NO_VECTORS",
-      409,
-    );
-  }
-  if (vectors.length < k * 4) {
-    // PCA on too-few samples is unstable — refuse rather than hand back
-    // overfit components. The 4× heuristic is conservative; in practice
-    // anisotropy fits stabilise at a few hundred samples per component.
-    throw new RouteError(
-      `Cannot fit k=${k} components from only ${vectors.length} vectors — need at least ${k * 4}. ` +
-        "Embed more concept pages or fit a smaller k.",
-      "MEMORY_V2_INSUFFICIENT_VECTORS",
-      409,
-    );
-  }
-
-  const { provider, model } = selection.backend;
-  const calib = fitAnisotropyCalibration(vectors, k, { provider, model });
-  const path = await saveCalibration(calib);
-
-  return {
-    provider,
-    model,
-    dim: calib.dim,
-    k,
-    sampleCount: calib.sampleCount,
-    totalVariance: calib.totalVariance,
-    componentVariance: calib.componentVariance,
-    explainedVarianceRatio: explainedVarianceRatio(calib),
-    path,
-  };
-}
-
 // ── Route definitions ───────────────────────────────────────────────────
 
 export const ROUTES: RouteDefinition[] = [
@@ -663,7 +311,7 @@ export const ROUTES: RouteDefinition[] = [
     handler: handleValidate,
     summary: "Validate memory v2 workspace state",
     description:
-      "Read-only structural validation of the v2 workspace — reports orphan edges, oversized pages, and parse failures.",
+      "Read-only structural validation of the v2 workspace — reports orphan edges, oversized pages, and parse failures. Runnable regardless of memory.v2.enabled so operators can dry-run validation before flipping the flag.",
     tags: ["memory"],
     requestBody: MemoryV2ValidateParams,
   },
@@ -700,28 +348,6 @@ export const ROUTES: RouteDefinition[] = [
     tags: ["memory"],
     requestBody: MemoryV2ReembedSkillsParams,
   },
-  {
-    operationId: "memory_v2_explain_similarity",
-    method: "POST",
-    endpoint: "memory/v2/explain-similarity",
-    handler: handleExplainSimilarity,
-    summary: "Diagnose dense vs sparse similarity score distributions",
-    description:
-      "Read-only diagnostic. Embeds the supplied text(s), runs hybrid dense + sparse queries against the concept-page collection, and returns per-slug raw dense, raw sparse, normalized sparse, and fused scores plus per-channel summary stats. Used to investigate score-compression at the head of the activation distribution.",
-    tags: ["memory"],
-    requestBody: MemoryV2ExplainSimilarityParams,
-  },
-  {
-    operationId: "memory_v2_rebuild_corpus_stats",
-    method: "POST",
-    endpoint: "memory/v2/rebuild-corpus-stats",
-    handler: handleRebuildCorpusStats,
-    summary: "Rebuild the BM25 corpus statistics for memory v2",
-    description:
-      "Walks every concept page on disk, recomputes the document-frequency table and average document length used by the BM25 sparse channel, and atomically swaps the in-memory stats. Run after bulk content imports or to recover from a rebuild that errored at startup. Does not reembed individual page sparse vectors — pair with `assistant memory v2 reembed` when document-side weights need refreshing.",
-    tags: ["memory"],
-    requestBody: MemoryV2RebuildCorpusStatsParams,
-  },
   {
     operationId: "memory_v2_concept_frequency",
     method: "POST",
@@ -733,15 +359,4 @@ export const ROUTES: RouteDefinition[] = [
     tags: ["memory"],
     requestBody: MemoryV2ConceptFrequencyParams,
   },
-  {
-    operationId: "memory_v2_fit_anisotropy",
-    method: "POST",
-    endpoint: "memory/v2/fit-anisotropy",
-    handler: handleFitAnisotropy,
-    summary: "Fit the embedding anisotropy correction for memory v2",
-    description:
-      "Samples stored dense vectors from the concept-page Qdrant collection, fits a corpus mean + top-k principal components (Mu & Viswanath 'all-but-the-top'), and persists the calibration so subsequent embeds and queries apply the correction. Run `assistant memory v2 reembed` after fitting so stored vectors are written under the new calibration — until then, queries (corrected) and stored vectors (uncorrected) live in different spaces.",
-    tags: ["memory"],
-    requestBody: MemoryV2FitAnisotropyParams,
-  },
 ];

package/src/runtime/routes/notification-routes.ts

@@ -52,7 +52,7 @@ function handleNotificationIntentResult({ body = {} }: RouteHandlerArgs) {
 
 const AttentionHintsSchema = z.object({
   requiresAction: z.boolean(),
-  urgency: z.enum(["low", "medium", "high"]),
+  urgency: z.enum(["low", "medium", "high", "critical"]),
   deadlineAt: z.number().optional(),
   isAsyncBackground: z.boolean(),
   visibleInSourceNow: z.boolean(),
@@ -75,6 +75,7 @@ const EmitSignalParams = z.object({
   routingIntent: z
     .enum(["single_channel", "multi_channel", "all_channels"])
     .optional(),
+  conversationAffinityHint: z.record(z.string(), z.string()).optional(),
   dedupeKey: z.string().optional(),
   throwOnError: z.boolean().optional(),
 });
@@ -95,6 +96,7 @@ async function handleEmitSignal({ body = {} }: RouteHandlerArgs) {
     attentionHints: validated.attentionHints as AttentionHints,
     contextPayload: validated.contextPayload as Record<string, unknown>,
     routingIntent: validated.routingIntent,
+    conversationAffinityHint: validated.conversationAffinityHint,
     dedupeKey: validated.dedupeKey,
     throwOnError: validated.throwOnError,
   });

package/src/runtime/routes/oauth-apps.ts

@@ -11,8 +11,10 @@ import {
   deleteApp,
   disconnectOAuthProvider,
   getApp,
+  getAppByProviderAndClientId,
   getAppClientSecret,
   getConnection,
+  getMostRecentAppByProvider,
   getProvider,
   listApps,
   listConnections,
@@ -58,6 +60,22 @@ function normalizeHasRefreshToken(
 // Handlers
 // ---------------------------------------------------------------------------
 
+function formatAppRow(row: {
+  id: string;
+  provider: string;
+  clientId: string;
+  createdAt: number;
+  updatedAt: number;
+}) {
+  return {
+    id: row.id,
+    provider_key: row.provider,
+    client_id: row.clientId,
+    created_at: row.createdAt,
+    updated_at: row.updatedAt,
+  };
+}
+
 function handleListApps({ queryParams = {} }: RouteHandlerArgs) {
   const provider = queryParams.provider_key;
   if (!provider) {
@@ -74,16 +92,63 @@ function handleListApps({ queryParams = {} }: RouteHandlerArgs) {
 
   return {
     provider: providerSummary,
-    apps: filtered.map((row) => ({
-      id: row.id,
-      provider_key: row.provider,
-      client_id: row.clientId,
-      created_at: row.createdAt,
-      updated_at: row.updatedAt,
-    })),
+    apps: filtered.map(formatAppRow),
   };
 }
 
+function handleGetApp({ queryParams = {} }: RouteHandlerArgs) {
+  const { id, provider, client_id } = queryParams;
+
+  let row;
+  if (id) {
+    row = getApp(id);
+  } else if (provider && client_id) {
+    row = getAppByProviderAndClientId(provider, client_id);
+  } else if (provider) {
+    row = getMostRecentAppByProvider(provider);
+  } else {
+    throw new BadRequestError(
+      "Provide id, provider, or provider + client_id query parameters",
+    );
+  }
+
+  if (!row) {
+    const lookup = id
+      ? `id=${id}`
+      : provider && client_id
+        ? `provider=${provider}, client_id=${client_id}`
+        : `provider=${provider}`;
+    throw new NotFoundError(`No app found for ${lookup}`);
+  }
+
+  return { app: formatAppRow(row) };
+}
+
+async function handleUpsertApp({ body = {} }: RouteHandlerArgs) {
+  const b = body as Record<string, unknown>;
+  const providerKey = b.provider_key as string | undefined;
+  const clientId = b.client_id as string | undefined;
+
+  if (!providerKey || !clientId) {
+    throw new BadRequestError(
+      "provider_key and client_id are required",
+    );
+  }
+
+  const clientSecretOpts = b.client_secret
+    ? { clientSecretValue: b.client_secret as string }
+    : b.client_secret_credential_path
+      ? {
+          clientSecretCredentialPath:
+            b.client_secret_credential_path as string,
+        }
+      : undefined;
+
+  const row = await upsertApp(providerKey, clientId, clientSecretOpts);
+
+  return { app: formatAppRow(row) };
+}
+
 async function handleCreateApp({ body = {} }: RouteHandlerArgs) {
   const { provider_key, client_id, client_secret } = body as {
     provider_key?: string;
@@ -254,6 +319,46 @@ export const ROUTES: RouteDefinition[] = [
     ],
     handler: handleListApps,
   },
+  {
+    operationId: "oauth_apps_by_query_get",
+    endpoint: "oauth/apps/lookup",
+    method: "GET",
+    summary: "Get OAuth app",
+    description:
+      "Look up a single OAuth app by ID, provider + client_id, or provider (most recent).",
+    tags: ["oauth"],
+    requirePolicyEnforcement: true,
+    queryParams: [
+      {
+        name: "id",
+        type: "string",
+        description: "App UUID",
+      },
+      {
+        name: "provider",
+        type: "string",
+        description: "Provider key",
+      },
+      {
+        name: "client_id",
+        type: "string",
+        description: "OAuth client ID (requires provider)",
+      },
+    ],
+    handler: handleGetApp,
+  },
+  {
+    operationId: "oauth_apps_upsert",
+    endpoint: "oauth/apps/upsert",
+    method: "POST",
+    policyKey: "oauth/apps.upsert",
+    summary: "Upsert OAuth app",
+    description:
+      "Create or return an existing OAuth app registration. Updates client secret if provided.",
+    tags: ["oauth"],
+    requirePolicyEnforcement: true,
+    handler: handleUpsertApp,
+  },
   {
     operationId: "oauth_apps_post",
     endpoint: "oauth/apps",