@vellumai/assistant 0.8.0 → 0.8.1

package/src/cli/commands/oauth/apps.ts

@@ -1,17 +1,35 @@
 import type { Command } from "commander";
 
-import {
-  deleteApp,
-  getApp,
-  getAppByProviderAndClientId,
-  getMostRecentAppByProvider,
-  listApps,
-  upsertApp,
-} from "../../../oauth/oauth-store.js";
-import { credentialKey } from "../../../security/credential-key.js";
+import { cliIpcCall, exitFromIpcResult } from "../../../ipc/cli-client.js";
+import { registerCommand } from "../../lib/register-command.js";
 import { getCliLogger } from "../../logger.js";
 import { shouldOutputJson, writeOutput } from "../../output.js";
 
+const log = getCliLogger("cli");
+
+// ---------------------------------------------------------------------------
+// Types
+// ---------------------------------------------------------------------------
+
+interface AppRow {
+  id: string;
+  provider_key: string;
+  client_id: string;
+  created_at: number;
+  updated_at: number;
+}
+
+/** Format an app row for CLI output, converting timestamps to ISO strings. */
+function formatAppRow(row: AppRow) {
+  return {
+    id: row.id,
+    providerKey: row.provider_key,
+    clientId: row.client_id,
+    createdAt: new Date(row.created_at).toISOString(),
+    updatedAt: new Date(row.updated_at).toISOString(),
+  };
+}
+
 /**
  * Resolve a credential path input to its full internal format.
  *
@@ -33,39 +51,18 @@ function resolveCredentialPath(input: string): string {
 
   const service = input.slice(0, lastColon);
   const field = input.slice(lastColon + 1);
-  return credentialKey(service, field);
-}
-
-const log = getCliLogger("cli");
-
-/** Format an app row for output, converting timestamps to ISO strings. */
-function formatAppRow(row: {
-  id: string;
-  provider: string;
-  clientId: string;
-  createdAt: number;
-  updatedAt: number;
-}) {
-  return {
-    id: row.id,
-    // Wire key stays `providerKey` for backward compatibility with existing
-    // CLI script consumers of `assistant oauth apps list/get/upsert --json`;
-    // the internal Drizzle TS-side field is `provider`.
-    providerKey: row.provider,
-    clientId: row.clientId,
-    createdAt: new Date(row.createdAt).toISOString(),
-    updatedAt: new Date(row.updatedAt).toISOString(),
-  };
+  return `credential/${service}/${field}`;
 }
 
 export function registerAppCommands(oauth: Command): void {
-  const apps = oauth
-    .command("apps")
-    .description("Manage custom OAuth app registrations");
-
-  apps.addHelpText(
-    "after",
-    `
+  registerCommand(oauth, {
+    name: "apps",
+    transport: "ipc",
+    description: "Manage custom OAuth app registrations",
+    build: (apps) => {
+      apps.addHelpText(
+        "after",
+        `
 Apps represent custom OAuth client registrations — a client_id and optional
 client_secret linked to a provider. Each provider can have multiple apps
 (e.g. different client IDs for different environments). Only needed if using
@@ -78,77 +75,101 @@ Examples:
   $ assistant oauth apps get --provider google
   $ assistant oauth apps upsert --provider google --client-id abc123
   $ assistant oauth apps delete <id>`,
-  );
-
-  // ---------------------------------------------------------------------------
-  // apps list
-  // ---------------------------------------------------------------------------
-
-  apps
-    .command("list")
-    .description("List all OAuth app registrations")
-    .option(
-      "--provider-key <key>",
-      "Filter by provider key (exact match). Only apps associated with this provider are returned. Run 'assistant oauth providers list' to see available keys.",
-    )
-    .addHelpText(
-      "after",
-      `
+      );
+
+      // -----------------------------------------------------------------------
+      // apps list
+      // -----------------------------------------------------------------------
+
+      apps
+        .command("list")
+        .description("List all OAuth app registrations")
+        .option(
+          "--provider-key <key>",
+          "Filter by provider key (exact match). Run 'assistant oauth providers list' to see available keys.",
+        )
+        .addHelpText(
+          "after",
+          `
 Returns registered OAuth apps with their provider key, client ID, and
 timestamps. Output is an array of app objects.
 
 When --provider-key is specified, only apps whose provider exactly matches
 the given value are returned. Without the flag, all apps are listed.
 
-In JSON mode (--json), returns the array directly. In human mode, logs a
-summary count and prints the formatted list.
-
 Examples:
   $ assistant oauth apps list
   $ assistant oauth apps list --provider-key google
   $ assistant oauth apps list --provider-key slack --json`,
-    )
-    .action((opts: { providerKey?: string }, cmd: Command) => {
-      try {
-        let rows = listApps().map(formatAppRow);
-
-        if (opts.providerKey) {
-          rows = rows.filter((r) => r.providerKey === opts.providerKey);
-        }
-
-        if (!shouldOutputJson(cmd)) {
-          log.info(`Found ${rows.length} app(s)`);
-        }
-
-        writeOutput(cmd, rows);
-      } catch (err) {
-        const message = err instanceof Error ? err.message : String(err);
-        writeOutput(cmd, { ok: false, error: message });
-        process.exitCode = 1;
-      }
-    });
-
-  // ---------------------------------------------------------------------------
-  // apps get
-  // ---------------------------------------------------------------------------
-
-  apps
-    .command("get")
-    .description(
-      "Look up an OAuth app by ID, provider + client-id, or provider",
-    )
-    .option("--id <id>", "App ID (UUID) from 'assistant oauth apps list'")
-    .option(
-      "--provider <key>",
-      "Provider key (e.g. google) from 'assistant oauth providers list'",
-    )
-    .option(
-      "--client-id <id>",
-      "OAuth client ID (requires --provider). Find registered client IDs via 'assistant oauth apps list'.",
-    )
-    .addHelpText(
-      "after",
-      `
+        )
+        .action(async (opts: { providerKey?: string }, cmd: Command) => {
+          if (!opts.providerKey) {
+            // The IPC route requires provider_key. To support listing all
+            // apps, we first need to know the providers. For simplicity
+            // and backward compatibility, list providers first, then
+            // aggregate.
+            const provR = await cliIpcCall<{
+              providers: Array<{ provider_key: string }>;
+            }>("oauth_providers_get", { queryParams: {} });
+
+            if (!provR.ok) return exitFromIpcResult(provR);
+
+            const allRows: ReturnType<typeof formatAppRow>[] = [];
+            for (const p of provR.result?.providers ?? []) {
+              const r = await cliIpcCall<{
+                apps: AppRow[];
+              }>("oauth_apps_get", {
+                queryParams: { provider_key: p.provider_key },
+              });
+              if (r.ok && r.result?.apps) {
+                allRows.push(...r.result.apps.map(formatAppRow));
+              }
+            }
+
+            if (!shouldOutputJson(cmd)) {
+              log.info(`Found ${allRows.length} app(s)`);
+            }
+            writeOutput(cmd, allRows);
+            return;
+          }
+
+          const r = await cliIpcCall<{ apps: AppRow[] }>(
+            "oauth_apps_get",
+            { queryParams: { provider_key: opts.providerKey } },
+          );
+
+          if (!r.ok) return exitFromIpcResult(r);
+
+          const rows = (r.result?.apps ?? []).map(formatAppRow);
+
+          if (!shouldOutputJson(cmd)) {
+            log.info(`Found ${rows.length} app(s)`);
+          }
+
+          writeOutput(cmd, rows);
+        });
+
+      // -----------------------------------------------------------------------
+      // apps get
+      // -----------------------------------------------------------------------
+
+      apps
+        .command("get")
+        .description(
+          "Look up an OAuth app by ID, provider + client-id, or provider",
+        )
+        .option("--id <id>", "App ID (UUID) from 'assistant oauth apps list'")
+        .option(
+          "--provider <key>",
+          "Provider key (e.g. google) from 'assistant oauth providers list'",
+        )
+        .option(
+          "--client-id <id>",
+          "OAuth client ID (requires --provider). Find registered client IDs via 'assistant oauth apps list'.",
+        )
+        .addHelpText(
+          "after",
+          `
 Three lookup modes are supported:
 
   1. By app ID:
@@ -161,80 +182,80 @@ Three lookup modes are supported:
      $ assistant oauth apps get --provider google
 
 At least --id or --provider must be specified.`,
-    )
-    .action(
-      (
-        opts: { id?: string; provider?: string; clientId?: string },
-        cmd: Command,
-      ) => {
-        try {
-          let row;
-
-          if (opts.id) {
-            row = getApp(opts.id);
-          } else if (opts.provider && opts.clientId) {
-            row = getAppByProviderAndClientId(opts.provider, opts.clientId);
-          } else if (opts.provider) {
-            row = getMostRecentAppByProvider(opts.provider);
-          } else {
-            writeOutput(cmd, {
-              ok: false,
-              error:
-                "Provide --id, --provider, or --provider + --client-id. Run 'assistant oauth apps list' to see all registered apps.",
-            });
-            process.exitCode = 1;
-            return;
-          }
-
-          if (!row) {
-            const lookup = opts.id
-              ? `id=${opts.id}`
-              : opts.provider && opts.clientId
-                ? `provider=${opts.provider}, clientId=${opts.clientId}`
-                : `provider=${opts.provider}`;
-            writeOutput(cmd, {
-              ok: false,
-              error: `No app found for ${lookup}. Run 'assistant oauth apps list' to see registered apps, or 'assistant oauth apps upsert --help' to register a new one.`,
-            });
-            process.exitCode = 1;
-            return;
-          }
-
-          writeOutput(cmd, formatAppRow(row));
-        } catch (err) {
-          const message = err instanceof Error ? err.message : String(err);
-          writeOutput(cmd, { ok: false, error: message });
-          process.exitCode = 1;
-        }
-      },
-    );
-
-  // ---------------------------------------------------------------------------
-  // apps upsert
-  // ---------------------------------------------------------------------------
-
-  apps
-    .command("upsert")
-    .description("Create or return an existing OAuth app registration")
-    .requiredOption(
-      "--provider <key>",
-      "Provider key (e.g. google) from 'assistant oauth providers list'",
-    )
-    .requiredOption(
-      "--client-id <id>",
-      "OAuth client ID from the provider's developer console",
-    )
-    .option(
-      "--client-secret <secret>",
-      "OAuth client secret (stored in credential store)",
-    )
-    .option(
-      "--client-secret-credential-path <path>",
-      "Credential reference in service:field format (e.g. google:client_secret). Mutually exclusive with --client-secret.",
-    )
-    .addHelpText(
-      "after",
-      `
+        )
+        .action(
+          async (
+            opts: { id?: string; provider?: string; clientId?: string },
+            cmd: Command,
+          ) => {
+            if (!opts.id && !opts.provider) {
+              writeOutput(cmd, {
+                ok: false,
+                error:
+                  "Provide --id, --provider, or --provider + --client-id. Run 'assistant oauth apps list' to see all registered apps.",
+              });
+              process.exitCode = 1;
+              return;
+            }
+
+            const queryParams: Record<string, string> = {};
+            if (opts.id) queryParams.id = opts.id;
+            if (opts.provider) queryParams.provider = opts.provider;
+            if (opts.clientId) queryParams.client_id = opts.clientId;
+
+            const r = await cliIpcCall<{ app: AppRow }>(
+              "oauth_apps_by_query_get",
+              { queryParams },
+            );
+
+            if (!r.ok) {
+              if (r.statusCode === 404) {
+                const lookup = opts.id
+                  ? `id=${opts.id}`
+                  : opts.provider && opts.clientId
+                    ? `provider=${opts.provider}, clientId=${opts.clientId}`
+                    : `provider=${opts.provider}`;
+                writeOutput(cmd, {
+                  ok: false,
+                  error: `No app found for ${lookup}. Run 'assistant oauth apps list' to see registered apps, or 'assistant oauth apps upsert --help' to register a new one.`,
+                });
+                process.exitCode = 1;
+                return;
+              }
+              return exitFromIpcResult(r);
+            }
+
+            const row = r.result?.app;
+            writeOutput(cmd, row ? formatAppRow(row) : null);
+          },
+        );
+
+      // -----------------------------------------------------------------------
+      // apps upsert
+      // -----------------------------------------------------------------------
+
+      apps
+        .command("upsert")
+        .description("Create or return an existing OAuth app registration")
+        .requiredOption(
+          "--provider <key>",
+          "Provider key (e.g. google) from 'assistant oauth providers list'",
+        )
+        .requiredOption(
+          "--client-id <id>",
+          "OAuth client ID from the provider's developer console",
+        )
+        .option(
+          "--client-secret <secret>",
+          "OAuth client secret (stored in credential store)",
+        )
+        .option(
+          "--client-secret-credential-path <path>",
+          "Credential reference in service:field format (e.g. google:client_secret). Mutually exclusive with --client-secret.",
+        )
+        .addHelpText(
+          "after",
+          `
 Creates a new app registration or returns the existing one if an app with the
 same provider and client ID already exists. The client secret, if provided, is
 stored in the secure credential store — not in the database.
@@ -246,73 +267,81 @@ You can supply the client secret directly via --client-secret, or reference an
 existing credential in the store via --client-secret-credential-path. These two
 options are mutually exclusive — providing both is an error.
 
-The --client-secret-credential-path takes a \`service:field\` reference
-(e.g. \`google:client_secret\`).
-
 Examples:
   $ assistant oauth apps upsert --provider google --client-id abc123
   $ assistant oauth apps upsert --provider slack --client-id def456 --client-secret s3cret
   $ assistant oauth apps upsert --provider slack --client-id def456 --client-secret-credential-path "slack:client_secret"
   $ assistant oauth apps upsert --provider google --client-id abc123 --json`,
-    )
-    .action(
-      async (
-        opts: {
-          provider: string;
-          clientId: string;
-          clientSecret?: string;
-          clientSecretCredentialPath?: string;
-        },
-        cmd: Command,
-      ) => {
-        try {
-          if (opts.clientSecret && opts.clientSecretCredentialPath) {
-            writeOutput(cmd, {
-              ok: false,
-              error:
-                "Cannot provide both --client-secret and --client-secret-credential-path",
-            });
-            process.exitCode = 1;
-            return;
-          }
-
-          const resolvedPath = opts.clientSecretCredentialPath
-            ? resolveCredentialPath(opts.clientSecretCredentialPath)
-            : undefined;
-          const clientSecretOpts = opts.clientSecret
-            ? { clientSecretValue: opts.clientSecret }
-            : resolvedPath
-              ? { clientSecretCredentialPath: resolvedPath }
-              : undefined;
-          const row = await upsertApp(
-            opts.provider,
-            opts.clientId,
-            clientSecretOpts,
-          );
-
-          if (!shouldOutputJson(cmd)) {
-            log.info(`Upserted app: ${row.id} (provider: ${row.provider})`);
-          }
-
-          writeOutput(cmd, formatAppRow(row));
-        } catch (err) {
-          const message = err instanceof Error ? err.message : String(err);
-          writeOutput(cmd, { ok: false, error: message });
-          process.exitCode = 1;
-        }
-      },
-    );
-
-  // ---------------------------------------------------------------------------
-  // apps delete <id>
-  // ---------------------------------------------------------------------------
-
-  apps
-    .command("delete <id>")
-    .description("Delete an OAuth app registration by ID")
-    .addHelpText(
-      "after",
-      `
+        )
+        .action(
+          async (
+            opts: {
+              provider: string;
+              clientId: string;
+              clientSecret?: string;
+              clientSecretCredentialPath?: string;
+            },
+            cmd: Command,
+          ) => {
+            if (opts.clientSecret && opts.clientSecretCredentialPath) {
+              writeOutput(cmd, {
+                ok: false,
+                error:
+                  "Cannot provide both --client-secret and --client-secret-credential-path",
+              });
+              process.exitCode = 1;
+              return;
+            }
+
+            const body: Record<string, unknown> = {
+              provider_key: opts.provider,
+              client_id: opts.clientId,
+            };
+
+            if (opts.clientSecret) {
+              body.client_secret = opts.clientSecret;
+            } else if (opts.clientSecretCredentialPath) {
+              body.client_secret_credential_path = resolveCredentialPath(
+                opts.clientSecretCredentialPath,
+              );
+            }
+
+            const r = await cliIpcCall<{ app: AppRow }>(
+              "oauth_apps_upsert",
+              { body },
+            );
+
+            if (!r.ok) {
+              writeOutput(cmd, {
+                ok: false,
+                error: r.error ?? "Unknown error",
+              });
+              process.exitCode = 1;
+              return;
+            }
+
+            const row = r.result?.app;
+            if (row) {
+              if (!shouldOutputJson(cmd)) {
+                log.info(
+                  `Upserted app: ${row.id} (provider: ${row.provider_key})`,
+                );
+              }
+              writeOutput(cmd, formatAppRow(row));
+            }
+          },
+        );
+
+      // -----------------------------------------------------------------------
+      // apps delete <id>
+      // -----------------------------------------------------------------------
+
+      apps
+        .command("delete <id>")
+        .description("Delete an OAuth app registration by ID")
+        .addHelpText(
+          "after",
+          `
 Arguments:
   id   The app UUID to delete (as returned by "apps list" or "apps get")
 
@@ -325,29 +354,31 @@ Exits with code 1 if the app ID is not found.
 Examples:
   $ assistant oauth apps delete 550e8400-e29b-41d4-a716-446655440000
   $ assistant oauth apps delete 550e8400-e29b-41d4-a716-446655440000 --json`,
-    )
-    .action(async (id: string, _opts: unknown, cmd: Command) => {
-      try {
-        const deleted = await deleteApp(id);
-
-        if (!deleted) {
-          writeOutput(cmd, {
-            ok: false,
-            error: `App not found: ${id}. Run 'assistant oauth apps list' to see registered apps and their IDs.`,
-          });
-          process.exitCode = 1;
-          return;
-        }
-
-        if (!shouldOutputJson(cmd)) {
-          log.info(`Deleted app: ${id}`);
-        }
-
-        writeOutput(cmd, { ok: true, id });
-      } catch (err) {
-        const message = err instanceof Error ? err.message : String(err);
-        writeOutput(cmd, { ok: false, error: message });
-        process.exitCode = 1;
-      }
-    });
+        )
+        .action(async (id: string, _opts: unknown, cmd: Command) => {
+          const r = await cliIpcCall<{ ok: boolean }>(
+            "oauth_apps_delete",
+            { pathParams: { id } },
+          );
+
+          if (!r.ok) {
+            if (r.statusCode === 404) {
+              writeOutput(cmd, {
+                ok: false,
+                error: `App not found: ${id}. Run 'assistant oauth apps list' to see registered apps and their IDs.`,
+              });
+              process.exitCode = 1;
+              return;
+            }
+            return exitFromIpcResult(r);
+          }
+
+          if (!shouldOutputJson(cmd)) {
+            log.info(`Deleted app: ${id}`);
+          }
+
+          writeOutput(cmd, { ok: true, id });
+        });
+    },
+  });
 }