@vellumai/assistant 0.7.1 → 0.7.2

package/src/__tests__/host-app-control-routes.test.ts

@@ -0,0 +1,263 @@
+/**
+ * Unit tests for the /v1/host-app-control-result route handler.
+ *
+ * Resolution flows through `pendingInteractions.get/resolve` → `findConversation`
+ * → `conversation.hostAppControlProxy.resolve`. Late delivery (no pending
+ * interaction or no conversation) returns 200 without crashing.
+ */
+import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
+
+// ── Module mocks ─────────────────────────────────────────────────────
+
+mock.module("../config/env.js", () => ({
+  isHttpAuthDisabled: () => true,
+  hasUngatedHttpAuthDisabled: () => false,
+}));
+
+interface PendingEntry {
+  conversationId: string;
+  kind: string;
+}
+
+const pending = new Map<string, PendingEntry>();
+
+mock.module("../runtime/pending-interactions.js", () => ({
+  get: (requestId: string) => pending.get(requestId),
+  resolve: (requestId: string) => {
+    const entry = pending.get(requestId);
+    if (entry) pending.delete(requestId);
+    return entry;
+  },
+}));
+
+interface FakeConversation {
+  conversationId: string;
+  hostAppControlProxy?: {
+    resolve: (requestId: string, payload: unknown) => void;
+  };
+}
+
+const conversations = new Map<string, FakeConversation>();
+
+mock.module("../daemon/conversation-store.js", () => ({
+  findConversation: (id: string) => conversations.get(id),
+}));
+
+// ── Real imports (after mocks) ───────────────────────────────────────
+
+import { BadRequestError } from "../runtime/routes/errors.js";
+import { ROUTES } from "../runtime/routes/host-app-control-routes.js";
+
+afterAll(() => {
+  mock.restore();
+});
+
+const handleHostAppControlResult = ROUTES.find(
+  (r) => r.endpoint === "host-app-control-result",
+)!.handler;
+
+// ── Tests ────────────────────────────────────────────────────────────
+
+describe("handleHostAppControlResult", () => {
+  beforeEach(() => {
+    pending.clear();
+    conversations.clear();
+  });
+
+  test("happy path: forwards payload to conversation.hostAppControlProxy.resolve", async () => {
+    const requestId = "ac-req-happy";
+    const conversationId = "conv-1";
+    pending.set(requestId, { conversationId, kind: "host_app_control" });
+
+    const resolveCalls: Array<{ requestId: string; payload: unknown }> = [];
+    conversations.set(conversationId, {
+      conversationId,
+      hostAppControlProxy: {
+        resolve(rid, payload) {
+          resolveCalls.push({ requestId: rid, payload });
+        },
+      },
+    });
+
+    const result = await handleHostAppControlResult({
+      body: {
+        requestId,
+        state: "running",
+        pngBase64: "AAAA",
+        windowBounds: { x: 1, y: 2, width: 800, height: 600 },
+        executionResult: "ok",
+      },
+    });
+
+    expect(result).toEqual({ accepted: true });
+    expect(resolveCalls).toHaveLength(1);
+    expect(resolveCalls[0].requestId).toBe(requestId);
+    expect(resolveCalls[0].payload).toEqual({
+      requestId,
+      state: "running",
+      pngBase64: "AAAA",
+      windowBounds: { x: 1, y: 2, width: 800, height: 600 },
+      executionResult: "ok",
+    });
+
+    // Pending interaction was consumed.
+    expect(pending.has(requestId)).toBe(false);
+  });
+
+  test("happy path: end-to-end resolves the awaiting proxy promise with the payload", async () => {
+    const requestId = "ac-req-await";
+    const conversationId = "conv-await";
+    pending.set(requestId, { conversationId, kind: "host_app_control" });
+
+    // Wire a real awaiter — this mirrors the proxy's pending map behavior
+    // without coupling the route test to HostProxyBase internals.
+    let resolved: unknown;
+    const awaitable = new Promise<unknown>((resolveFn) => {
+      conversations.set(conversationId, {
+        conversationId,
+        hostAppControlProxy: {
+          resolve(rid, payload) {
+            if (rid === requestId) resolveFn(payload);
+          },
+        },
+      });
+    }).then((p) => {
+      resolved = p;
+      return p;
+    });
+
+    await handleHostAppControlResult({
+      body: { requestId, state: "running", executionResult: "done" },
+    });
+    await awaitable;
+
+    expect(resolved).toEqual({
+      requestId,
+      state: "running",
+      executionResult: "done",
+    });
+  });
+
+  test("late delivery (no pending interaction): returns 200, no crash", async () => {
+    const result = await handleHostAppControlResult({
+      body: {
+        requestId: "no-such-request",
+        state: "running",
+      },
+    });
+    expect(result).toEqual({ accepted: true });
+  });
+
+  test("late delivery (conversation gone): returns 200, no crash", async () => {
+    const requestId = "ac-req-orphan";
+    pending.set(requestId, {
+      conversationId: "conv-gone",
+      kind: "host_app_control",
+    });
+    // No conversation registered for "conv-gone".
+
+    const result = await handleHostAppControlResult({
+      body: { requestId, state: "running" },
+    });
+    expect(result).toEqual({ accepted: true });
+    // Pending interaction was still consumed so it cannot leak.
+    expect(pending.has(requestId)).toBe(false);
+  });
+
+  test("late delivery (proxy missing on conversation): returns 200, no crash", async () => {
+    const requestId = "ac-req-noproxy";
+    const conversationId = "conv-no-proxy";
+    pending.set(requestId, { conversationId, kind: "host_app_control" });
+    conversations.set(conversationId, { conversationId }); // hostAppControlProxy undefined
+
+    const result = await handleHostAppControlResult({
+      body: { requestId, state: "running" },
+    });
+    expect(result).toEqual({ accepted: true });
+    expect(pending.has(requestId)).toBe(false);
+  });
+
+  test("wrong pending kind: returns 200 without forwarding (treated as late delivery)", async () => {
+    const requestId = "ac-req-wrong-kind";
+    pending.set(requestId, { conversationId: "conv-1", kind: "host_cu" });
+
+    const resolveCalls: unknown[] = [];
+    conversations.set("conv-1", {
+      conversationId: "conv-1",
+      hostAppControlProxy: {
+        resolve: () => resolveCalls.push("called"),
+      },
+    });
+
+    const result = await handleHostAppControlResult({
+      body: { requestId, state: "running" },
+    });
+
+    expect(result).toEqual({ accepted: true });
+    expect(resolveCalls).toHaveLength(0);
+    // Wrong-kind interaction is not consumed.
+    expect(pending.has(requestId)).toBe(true);
+  });
+
+  test("malformed body (missing): throws BadRequestError", () => {
+    expect(() => handleHostAppControlResult({})).toThrow(BadRequestError);
+  });
+
+  test("malformed body (non-object): throws BadRequestError", () => {
+    expect(() =>
+      handleHostAppControlResult({
+        body: "not an object" as unknown as Record<string, unknown>,
+      }),
+    ).toThrow(BadRequestError);
+  });
+
+  test("malformed body (missing requestId): throws BadRequestError", () => {
+    expect(() =>
+      handleHostAppControlResult({ body: { state: "running" } }),
+    ).toThrow(BadRequestError);
+  });
+
+  test("malformed body (missing state): throws BadRequestError", () => {
+    expect(() =>
+      handleHostAppControlResult({ body: { requestId: "abc" } }),
+    ).toThrow(BadRequestError);
+  });
+
+  test("malformed body (invalid state): throws BadRequestError", () => {
+    expect(() =>
+      handleHostAppControlResult({
+        body: { requestId: "abc", state: "exploded" },
+      }),
+    ).toThrow(BadRequestError);
+  });
+
+  test("payload omits undefined optional fields (no leaking undefined keys)", async () => {
+    const requestId = "ac-req-min";
+    const conversationId = "conv-min";
+    pending.set(requestId, { conversationId, kind: "host_app_control" });
+
+    const resolveCalls: Array<{ payload: unknown }> = [];
+    conversations.set(conversationId, {
+      conversationId,
+      hostAppControlProxy: {
+        resolve(_rid, payload) {
+          resolveCalls.push({ payload });
+        },
+      },
+    });
+
+    await handleHostAppControlResult({
+      body: { requestId, state: "minimized" },
+    });
+
+    expect(resolveCalls).toHaveLength(1);
+    const payload = resolveCalls[0].payload as Record<string, unknown>;
+    expect(payload).toEqual({ requestId, state: "minimized" });
+    expect(Object.prototype.hasOwnProperty.call(payload, "pngBase64")).toBe(
+      false,
+    );
+    expect(Object.prototype.hasOwnProperty.call(payload, "windowBounds")).toBe(
+      false,
+    );
+  });
+});