@vellumai/assistant 0.6.6 → 0.7.0

package/src/__tests__/conversation-routes-disk-view.test.ts

@@ -18,7 +18,8 @@ import {
   getConversationByKey,
   getOrCreateConversation as getOrCreateConversationMapping,
 } from "../memory/conversation-key-store.js";
-import { getDb, initializeDb } from "../memory/db.js";
+import { getDb } from "../memory/db-connection.js";
+import { initializeDb } from "../memory/db-init.js";
 import { AssistantEventHub } from "../runtime/assistant-event-hub.js";
 import type { AuthContext } from "../runtime/auth/types.js";
 import {
@@ -28,6 +29,7 @@ import {
 } from "../runtime/chrome-extension-registry.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import { handleSendMessage } from "../runtime/routes/conversation-routes.js";
+import { callHandler } from "./helpers/call-route-handler.js";
 
 const testDir = process.env.VELLUM_WORKSPACE_DIR!;
 const conversationsDir = join(testDir, "conversations");
@@ -155,7 +157,6 @@ function createFakeConversation(conversationId: string): Conversation {
     memoryPolicy: {
       scopeId: "default",
       includeDefaultFallback: false,
-      strictSideEffects: false,
     },
     isProcessing(this: { processing: boolean }) {
       return this.processing;
@@ -219,6 +220,12 @@ function createFakeConversation(conversationId: string): Conversation {
     setHostFileProxy(this: { hostFileProxy: unknown }, proxy: unknown) {
       this.hostFileProxy = proxy;
     },
+    setHostTransferProxy(this: { hostTransferProxy: unknown }, proxy: unknown) {
+      this.hostTransferProxy = proxy;
+    },
+    getHostTransferProxy() {
+      return undefined;
+    },
     setHostCuProxy(this: { hostCuProxy: unknown }, proxy: unknown) {
       this.hostCuProxy = proxy;
     },
@@ -394,10 +401,25 @@ describe("macOS browser backend fallback (no extension, no cdp-inspect)", () =>
     const content = "Test macOS fallback path.";
     let capturedConversation: Conversation | undefined;
 
-    const response = await handleSendMessage(
+    const deps = {
+      sendMessageDeps: {
+        getOrCreateConversation: async (conversationId: string) => {
+          const conv = getOrCreateFakeConversation(conversationId);
+          capturedConversation = conv;
+          return conv;
+        },
+        assistantEventHub: new AssistantEventHub(),
+        resolveAttachments: () => [],
+      },
+    };
+    const response = await callHandler(
+      (args) => handleSendMessage(args, deps),
       new Request("http://localhost/v1/messages", {
         method: "POST",
-        headers: { "Content-Type": "application/json" },
+        headers: {
+          "Content-Type": "application/json",
+          "x-vellum-principal-type": authContext.principalType,
+        },
         body: JSON.stringify({
           conversationKey,
           content,
@@ -405,18 +427,8 @@ describe("macOS browser backend fallback (no extension, no cdp-inspect)", () =>
           interface: "macos",
         }),
       }),
-      {
-        sendMessageDeps: {
-          getOrCreateConversation: async (conversationId: string) => {
-            const conv = getOrCreateFakeConversation(conversationId);
-            capturedConversation = conv;
-            return conv;
-          },
-          assistantEventHub: new AssistantEventHub(),
-          resolveAttachments: () => [],
-        },
-      },
-      authContext,
+      undefined,
+      202,
     );
 
     expect(response.status).toBe(202);
@@ -452,10 +464,22 @@ describe("macOS browser backend fallback (no extension, no cdp-inspect)", () =>
     const conversationKey = `macos-metadata-${crypto.randomUUID()}`;
     const content = "Verify interface metadata persistence.";
 
-    const response = await handleSendMessage(
+    const response = await callHandler(
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async (conversationId: string) =>
+              getOrCreateFakeConversation(conversationId),
+            assistantEventHub: new AssistantEventHub(),
+            resolveAttachments: () => [],
+          },
+        }),
       new Request("http://localhost/v1/messages", {
         method: "POST",
-        headers: { "Content-Type": "application/json" },
+        headers: {
+          "Content-Type": "application/json",
+          "x-vellum-principal-type": authContext.principalType,
+        },
         body: JSON.stringify({
           conversationKey,
           content,
@@ -463,15 +487,8 @@ describe("macOS browser backend fallback (no extension, no cdp-inspect)", () =>
           interface: "macos",
         }),
       }),
-      {
-        sendMessageDeps: {
-          getOrCreateConversation: async (conversationId: string) =>
-            getOrCreateFakeConversation(conversationId),
-          assistantEventHub: new AssistantEventHub(),
-          resolveAttachments: () => [],
-        },
-      },
-      authContext,
+      undefined,
+      202,
     );
 
     expect(response.status).toBe(202);
@@ -553,10 +570,70 @@ describe("chrome-extension host_browser pending registration", () => {
     };
 
     const conversationKey = `chrome-ext-pending-${crypto.randomUUID()}`;
-    const response = await handleSendMessage(
+    const chromeDeps = {
+      sendMessageDeps: {
+        getOrCreateConversation: async (conversationId: string) => {
+          const conversation = createFakeConversation(
+            conversationId,
+          ) as unknown as {
+            hostBrowserProxy?: {
+              request: (
+                input: { cdpMethod: string; timeout_seconds?: number },
+                conversationId: string,
+              ) => Promise<{ content: string; isError: boolean }>;
+            };
+            processing: boolean;
+            abortController: AbortController | null;
+            currentRequestId?: string;
+            runAgentLoop: (
+              content: string,
+              userMessageId: string,
+              onEvent: (msg: Record<string, unknown>) => void,
+            ) => Promise<void>;
+            conversationId: string;
+          };
+
+          conversation.runAgentLoop = async function (
+            _content: string,
+            _userMessageId: string,
+            _onEvent: (msg: Record<string, unknown>) => void,
+          ): Promise<void> {
+            if (!this.hostBrowserProxy) {
+              throw new Error(
+                "Expected hostBrowserProxy to be provisioned for chrome-extension turn",
+              );
+            }
+            await this.hostBrowserProxy.request(
+              {
+                cdpMethod: "Browser.getVersion",
+                timeout_seconds: 0.05,
+              },
+              this.conversationId,
+            );
+            this.processing = false;
+            this.abortController = null;
+            this.currentRequestId = undefined;
+          };
+
+          conversationInstances.set(
+            conversationId,
+            conversation as unknown as Conversation,
+          );
+          return conversation as unknown as Conversation;
+        },
+        assistantEventHub: new AssistantEventHub(),
+        resolveAttachments: () => [],
+      },
+    };
+    const response = await callHandler(
+      (args) => handleSendMessage(args, chromeDeps),
       new Request("http://localhost/v1/messages", {
         method: "POST",
-        headers: { "Content-Type": "application/json" },
+        headers: {
+          "Content-Type": "application/json",
+          "x-vellum-actor-principal-id": actorAuthContext.actorPrincipalId!,
+          "x-vellum-principal-type": actorAuthContext.principalType,
+        },
         body: JSON.stringify({
           conversationKey,
           content: "Trigger host browser request via registry sender.",
@@ -564,63 +641,8 @@ describe("chrome-extension host_browser pending registration", () => {
           interface: "chrome-extension",
         }),
       }),
-      {
-        sendMessageDeps: {
-          getOrCreateConversation: async (conversationId: string) => {
-            const conversation = createFakeConversation(
-              conversationId,
-            ) as unknown as {
-              hostBrowserProxy?: {
-                request: (
-                  input: { cdpMethod: string; timeout_seconds?: number },
-                  conversationId: string,
-                ) => Promise<{ content: string; isError: boolean }>;
-              };
-              processing: boolean;
-              abortController: AbortController | null;
-              currentRequestId?: string;
-              runAgentLoop: (
-                content: string,
-                userMessageId: string,
-                onEvent: (msg: Record<string, unknown>) => void,
-              ) => Promise<void>;
-              conversationId: string;
-            };
-
-            conversation.runAgentLoop = async function (
-              _content: string,
-              _userMessageId: string,
-              _onEvent: (msg: Record<string, unknown>) => void,
-            ): Promise<void> {
-              if (!this.hostBrowserProxy) {
-                throw new Error(
-                  "Expected hostBrowserProxy to be provisioned for chrome-extension turn",
-                );
-              }
-              await this.hostBrowserProxy.request(
-                {
-                  cdpMethod: "Browser.getVersion",
-                  // Keep the test fast while still allowing assertion at send time.
-                  timeout_seconds: 0.05,
-                },
-                this.conversationId,
-              );
-              this.processing = false;
-              this.abortController = null;
-              this.currentRequestId = undefined;
-            };
-
-            conversationInstances.set(
-              conversationId,
-              conversation as unknown as Conversation,
-            );
-            return conversation as unknown as Conversation;
-          },
-          assistantEventHub: new AssistantEventHub(),
-          resolveAttachments: () => [],
-        },
-      },
-      actorAuthContext,
+      undefined,
+      202,
     );
 
     expect(response.status).toBe(202);
@@ -635,10 +657,22 @@ describe("conversationKey send path disk-view regression", () => {
     const conversationKey = `fresh-conv-key-${crypto.randomUUID()}`;
     const content = "Please persist this first turn.";
 
-    const response = await handleSendMessage(
+    const response = await callHandler(
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async (conversationId: string) =>
+              getOrCreateFakeConversation(conversationId),
+            assistantEventHub: new AssistantEventHub(),
+            resolveAttachments: () => [],
+          },
+        }),
       new Request("http://localhost/v1/messages", {
         method: "POST",
-        headers: { "Content-Type": "application/json" },
+        headers: {
+          "Content-Type": "application/json",
+          "x-vellum-principal-type": authContext.principalType,
+        },
         body: JSON.stringify({
           conversationKey,
           content,
@@ -646,15 +680,8 @@ describe("conversationKey send path disk-view regression", () => {
           interface: "macos",
         }),
       }),
-      {
-        sendMessageDeps: {
-          getOrCreateConversation: async (conversationId: string) =>
-            getOrCreateFakeConversation(conversationId),
-          assistantEventHub: new AssistantEventHub(),
-          resolveAttachments: () => [],
-        },
-      },
-      authContext,
+      undefined,
+      202,
     );
 
     expect(response.status).toBe(202);

package/src/__tests__/conversation-routes-guardian-reply.test.ts

@@ -105,8 +105,9 @@ mock.module("../runtime/trust-context-resolver.js", () => ({
 
 import type { AuthContext } from "../runtime/auth/types.js";
 import { handleSendMessage } from "../runtime/routes/conversation-routes.js";
+import { callHandler } from "./helpers/call-route-handler.js";
 
-const testAuthContext: AuthContext = {
+const _testAuthContext: AuthContext = {
   subject: "actor:self:test-guardian",
   principalType: "actor",
   assistantId: "self",
@@ -172,6 +173,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -179,7 +182,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "05BECB approve",
@@ -188,17 +191,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     const body = (await res.json()) as {
@@ -251,6 +255,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -258,7 +264,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "hello there",
@@ -267,17 +273,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -326,6 +333,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -333,7 +342,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "approve",
@@ -342,17 +351,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -405,6 +415,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -412,7 +424,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "A1B2C3 approve",
@@ -421,17 +433,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -480,6 +493,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -487,7 +502,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "reject",
@@ -496,17 +511,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -549,6 +565,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -556,7 +574,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "tell me more about this request",
@@ -565,17 +583,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    const res = await handleSendMessage(
-      req,
-      {
+    const res = await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
-      },
-      testAuthContext,
-    );
+      }),
+      req,
+      undefined,
+      202,
+      );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -620,6 +639,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -627,7 +648,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "no sorry, beats 0 and 3 should be new threads",
@@ -636,17 +657,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    await handleSendMessage(
-      req,
-      {
+    await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
         approvalConversationGenerator: mockGenerator as any,
-      },
-      testAuthContext,
+      }),
+      req,
+      undefined,
+      202,
     );
 
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -692,6 +714,8 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       setHostBashProxy: () => {},
       setHostBrowserProxy: () => {},
       setHostFileProxy: () => {},
+      setHostTransferProxy: () => {},
+      getHostTransferProxy: () => undefined,
       setHostCuProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
@@ -699,7 +723,7 @@ describe("handleSendMessage canonical guardian reply interception", () => {
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json" },
+      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "no sorry, beats 0 and 3 should be new threads",
@@ -708,17 +732,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       }),
     });
 
-    await handleSendMessage(
-      req,
-      {
+    await callHandler(
+      (args) => handleSendMessage(args, {
         sendMessageDeps: {
           getOrCreateConversation: async () => session,
           assistantEventHub: { publish: async () => {} } as any,
           resolveAttachments: () => [],
         },
         approvalConversationGenerator: mockGenerator as any,
-      },
-      testAuthContext,
+      }),
+      req,
+      undefined,
+      202,
     );
 
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);