@vellumai/assistant 0.6.5 → 0.6.6

package/src/__tests__/conversation-slash-unknown.test.ts

@@ -30,7 +30,7 @@ mock.module("../providers/registry.js", () => ({
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
-    
+
     llm: {
       default: {
         provider: "mock-provider",
@@ -206,6 +206,24 @@ mock.module("../config/skill-state.js", () => ({
     })),
 }));
 
+// Avoid real workspace-git initialization on /tmp — on CI runners,
+// `git add -A` under /tmp hits permission errors on systemd-private dirs,
+// which blocks `runAgentLoopImpl` for long enough to trip the test's
+// 5s timeout before `AgentLoop.run` is invoked.
+mock.module("../workspace/git-service.js", () => ({
+  getWorkspaceGitService: () => ({
+    ensureInitialized: async () => {},
+  }),
+}));
+
+mock.module("../workspace/turn-commit.js", () => ({
+  commitTurnChanges: async () => {},
+}));
+
+mock.module("../memory/app-git-service.js", () => ({
+  commitAppTurnChanges: async () => {},
+}));
+
 // ---------------------------------------------------------------------------
 // AgentLoop mock — tracks whether run() was called
 // ---------------------------------------------------------------------------
@@ -218,6 +236,9 @@ mock.module("../agent/loop.js", () => ({
     getToolTokenBudget() {
       return 0;
     }
+    getResolvedTools() {
+      return [];
+    }
     getActiveModel() {
       return undefined;
     }
@@ -226,7 +247,9 @@ mock.module("../agent/loop.js", () => ({
       onEvent: (event: AgentEvent) => void,
       _signal?: AbortSignal,
       _requestId?: string,
-      _onCheckpoint?: (checkpoint: CheckpointInfo) => CheckpointDecision,
+      _onCheckpoint?: (
+        checkpoint: CheckpointInfo,
+      ) => CheckpointDecision | Promise<CheckpointDecision>,
     ): Promise<Message[]> {
       agentLoopRunCalled = true;
       const assistantMsg: Message = {

package/src/__tests__/conversation-speed-override.test.ts

@@ -211,6 +211,9 @@ mock.module("../agent/loop.js", () => ({
     getToolTokenBudget() {
       return 0;
     }
+    getResolvedTools() {
+      return [];
+    }
     getActiveModel() {
       return undefined;
     }
@@ -219,7 +222,9 @@ mock.module("../agent/loop.js", () => ({
       _onEvent: (event: AgentEvent) => void,
       _signal?: AbortSignal,
       _requestId?: string,
-      _onCheckpoint?: (checkpoint: CheckpointInfo) => CheckpointDecision,
+      _onCheckpoint?: (
+        checkpoint: CheckpointInfo,
+      ) => CheckpointDecision | Promise<CheckpointDecision>,
     ): Promise<Message[]> {
       return [];
     }

package/src/__tests__/conversation-title-service.test.ts

@@ -214,6 +214,122 @@ describe("conversation-title-service", () => {
     );
   });
 
+  test("rejects meta-failure outputs like 'Missing Context' and uses fallback", async () => {
+    mockRunBtwSidechain.mockImplementationOnce(async () => ({
+      text: "Missing Context",
+      hadTextDeltas: true,
+      response: {
+        content: [{ type: "text", text: "Missing Context" }],
+        model: "test-model",
+        usage: { inputTokens: 10, outputTokens: 5 },
+        stopReason: "end_turn",
+      },
+    }));
+
+    const provider = {
+      name: "test-provider",
+      sendMessage: mock(async () => {
+        throw new Error("should not call directly");
+      }),
+    };
+
+    const result = await generateAndPersistConversationTitle({
+      conversationId: "conv-1",
+      provider,
+      userMessage: "so about that t-shirt...",
+    });
+
+    expect(result.title).toBe("Untitled Conversation");
+    expect(mockUpdateConversationTitle).toHaveBeenCalledWith(
+      "conv-1",
+      "Untitled Conversation",
+      1,
+    );
+  });
+
+  test.each([
+    "missing context",
+    "No Context",
+    "Insufficient Context",
+    "Unclear Request",
+    "No Topic",
+    "Empty Conversation",
+  ])("rejects meta-failure variant: %s", async (bad) => {
+    mockRunBtwSidechain.mockImplementationOnce(async () => ({
+      text: bad,
+      hadTextDeltas: true,
+      response: {
+        content: [{ type: "text", text: bad }],
+        model: "test-model",
+        usage: { inputTokens: 10, outputTokens: 5 },
+        stopReason: "end_turn",
+      },
+    }));
+
+    const provider = {
+      name: "test-provider",
+      sendMessage: mock(async () => {
+        throw new Error("should not call directly");
+      }),
+    };
+
+    const result = await generateAndPersistConversationTitle({
+      conversationId: "conv-1",
+      provider,
+      userMessage: "something",
+    });
+
+    expect(result.title).toBe("Untitled Conversation");
+  });
+
+  test("regeneration skips LLM call when recent messages have no extractable text", async () => {
+    mockGetMessages.mockReturnValueOnce([
+      {
+        role: "assistant",
+        content: JSON.stringify([
+          { type: "tool_use", id: "toolu_1", name: "bash", input: {} },
+        ]),
+      },
+      {
+        role: "user",
+        content: JSON.stringify([
+          {
+            type: "tool_result",
+            tool_use_id: "toolu_1",
+            content: [{ type: "image", source: {} }],
+          },
+        ]),
+      },
+      {
+        role: "assistant",
+        content: JSON.stringify([
+          { type: "tool_use", id: "toolu_2", name: "bash", input: {} },
+        ]),
+      },
+    ]);
+
+    mockGetConversation.mockReturnValueOnce({
+      title: "Existing Title",
+      isAutoTitle: 1,
+    });
+
+    const provider = {
+      name: "test-provider",
+      sendMessage: mock(async () => {
+        throw new Error("should not call directly");
+      }),
+    };
+
+    const result = await regenerateConversationTitle({
+      conversationId: "conv-1",
+      provider,
+    });
+
+    expect(mockRunBtwSidechain).not.toHaveBeenCalled();
+    expect(mockUpdateConversationTitle).not.toHaveBeenCalled();
+    expect(result).toEqual({ title: "Existing Title", updated: false });
+  });
+
   test("title prompt content does not contain generation instructions", async () => {
     const provider = {
       name: "test-provider",

package/src/__tests__/conversation-tool-setup-app-refresh.test.ts

@@ -44,7 +44,9 @@ mock.module("../tools/browser/browser-screencast.js", () => ({
   registerConversationSender: mock(() => {}),
 }));
 
-// Mock app-store functions used by handleAppChange in tool-side-effects
+// Stub app-store functions used by other modules (e.g. app-source-watcher,
+// conversation-surfaces) so tool-side-effects' hooks can run without touching
+// the real app store during tests.
 mock.module("../memory/app-store.js", () => ({
   getApp: mock(() => null),
   getAppDirPath: mock(() => "/tmp/test-apps/dummy"),
@@ -286,6 +288,44 @@ describe("session-tool-setup app refresh side effects", () => {
 
       expect(broadcastSpy).not.toHaveBeenCalled();
     });
+
+    test("fires notify side effects regardless of compile outcome reported in payload", async () => {
+      // The hook observes the tool result but does not branch on compile
+      // status fields inside it. Whether the executor reports a successful
+      // compile or returns compile_errors, the hook still refreshes
+      // surfaces and broadcasts — compile retries are the LLM's
+      // responsibility via a follow-up tool call, not the hook's.
+      const ctx = makeCtx();
+      const executor = makeFakeExecutor({
+        content: JSON.stringify({
+          id: "new-app-err",
+          name: "Busted",
+          compiled: false,
+          compile_errors: [{ text: "syntax error" }],
+        }),
+        isError: false,
+      });
+      const broadcastSpy = mock(() => {});
+
+      const toolFn = createToolExecutor(
+        executor as unknown as ToolExecutor,
+        noopPrompter,
+        noopSecretPrompter,
+        ctx,
+        noopLifecycleHandler,
+        broadcastSpy,
+      );
+
+      await toolFn("app_create", { name: "Busted", html: "" });
+
+      expect(refreshSpy).toHaveBeenCalledTimes(1);
+      expect(broadcastSpy.mock.calls.length).toBeGreaterThanOrEqual(1);
+      expect((broadcastSpy.mock.calls as unknown[][])[0][0]).toEqual({
+        type: "app_files_changed",
+        appId: "new-app-err",
+      });
+      expect(updatePublishedSpy).toHaveBeenCalledTimes(1);
+    });
   });
 
   // ── app_delete side effects ────────────────────────────────────────
@@ -435,5 +475,4 @@ describe("session-tool-setup app refresh side effects", () => {
       expect(updatePublishedSpy).toHaveBeenCalledTimes(1);
     });
   });
-
 });

package/src/__tests__/conversation-usage.test.ts

@@ -105,7 +105,7 @@ describe("recordUsage", () => {
     expect(events[0].estimatedCostUsd).toBe(
       expectedPricing.estimatedCostUsd ?? null,
     );
-    // Sanity: fast should be 6x standard ($30 * 6 = $180)
+    // Sanity: fast should be 6x standard (claude-opus-4-6 at $5/$25 → $30 * 6 = $180)
     expect(expectedPricing.estimatedCostUsd).toBe(180);
   });
 

package/src/__tests__/conversation-workspace-cache-state.test.ts

@@ -24,7 +24,7 @@ mock.module("../providers/registry.js", () => ({
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
-    
+
     llm: {
       default: {
         provider: "mock-provider",
@@ -167,6 +167,9 @@ mock.module("../agent/loop.js", () => ({
     getToolTokenBudget() {
       return 0;
     }
+    getResolvedTools() {
+      return [];
+    }
     getActiveModel() {
       return undefined;
     }

package/src/__tests__/conversation-workspace-injection.test.ts

@@ -227,6 +227,9 @@ mock.module("../agent/loop.js", () => ({
     getToolTokenBudget() {
       return 0;
     }
+    getResolvedTools() {
+      return [];
+    }
     getActiveModel() {
       return undefined;
     }

package/src/__tests__/conversation-workspace-tool-tracking.test.ts

@@ -31,7 +31,7 @@ mock.module("../providers/registry.js", () => ({
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     ui: {},
-    
+
     llm: {
       default: {
         provider: "mock-provider",
@@ -211,6 +211,9 @@ mock.module("../agent/loop.js", () => ({
     getToolTokenBudget() {
       return 0;
     }
+    getResolvedTools() {
+      return [];
+    }
     getActiveModel() {
       return undefined;
     }

package/src/__tests__/credential-health-service.test.ts

@@ -50,6 +50,21 @@ mock.module("../oauth/oauth-store.js", () => ({
   getProvider: (provider: string) =>
     mockProviders.find((p) => p.provider === provider),
   isProviderConnected: () => false,
+  // Needed by manual-token-connection.ts at import time — these aren't
+  // invoked in this test suite but must resolve so the module loads.
+  createConnection: () => {
+    throw new Error("createConnection not mocked");
+  },
+  deleteConnection: () => {
+    throw new Error("deleteConnection not mocked");
+  },
+  getConnectionByProvider: () => undefined,
+  updateConnection: () => {
+    throw new Error("updateConnection not mocked");
+  },
+  upsertApp: async () => {
+    throw new Error("upsertApp not mocked");
+  },
 }));
 
 mock.module("../util/logger.js", () => ({
@@ -63,11 +78,8 @@ mock.module("../util/logger.js", () => ({
 
 // ── Import under test ────────────────────────────────────────────────
 
-const {
-  checkAllCredentials,
-  checkCredentialForProvider,
-  _setFetchFn,
-} = await import("../credential-health/credential-health-service.js");
+const { checkAllCredentials, checkCredentialForProvider, _setFetchFn } =
+  await import("../credential-health/credential-health-service.js");
 
 // Inject mock fetch via the test helper (Bun's global fetch can't be
 // overridden via globalThis assignment).
@@ -125,10 +137,7 @@ function addConnection(
 }
 
 function setToken(connectionId: string, token = "mock-token") {
-  secureKeyValues.set(
-    `oauth_connection/${connectionId}/access_token`,
-    token,
-  );
+  secureKeyValues.set(`oauth_connection/${connectionId}/access_token`, token);
 }
 
 // ── Tests ────────────────────────────────────────────────────────────
@@ -322,6 +331,66 @@ describe("credential-health-service", () => {
     expect(slack!.status).toBe("healthy");
   });
 
+  describe("manual-token providers", () => {
+    // slack_channel and telegram store their primary access token at
+    // credential/<provider>/bot_token rather than at
+    // oauth_connection/<id>/access_token. The health check must resolve the
+    // provider-specific path via manualTokenAccessCredentialKey — otherwise
+    // every manual-token connection gets flagged as missing_token and ends
+    // up in the heartbeat <credential-status> block even when credentials
+    // are valid.
+
+    test("slack_channel is healthy when bot_token is present and ping succeeds", async () => {
+      addProvider("slack_channel", {
+        pingUrl: "https://slack.com/api/auth.test",
+      });
+      addConnection("slack_channel", "conn-slack", {
+        expiresAt: null,
+        hasRefreshToken: false,
+        grantedScopes: [],
+      });
+      secureKeyValues.set("credential/slack_channel/bot_token", "xoxb-valid");
+
+      const report = await checkAllCredentials();
+      expect(report.results).toHaveLength(1);
+      expect(report.results[0]!.status).toBe("healthy");
+      expect(report.unhealthy).toHaveLength(0);
+    });
+
+    test("slack_channel is missing_token when bot_token is absent, even if OAuth access-token path is populated", async () => {
+      addProvider("slack_channel", {
+        pingUrl: "https://slack.com/api/auth.test",
+      });
+      addConnection("slack_channel", "conn-slack", {
+        expiresAt: null,
+        hasRefreshToken: false,
+        grantedScopes: [],
+      });
+      // Write to the OAuth access-token path — this must be IGNORED for
+      // manual-token providers, otherwise the fix isn't routing correctly.
+      secureKeyValues.set(
+        "oauth_connection/conn-slack/access_token",
+        "should-be-ignored",
+      );
+
+      const report = await checkAllCredentials();
+      expect(report.results[0]!.status).toBe("missing_token");
+    });
+
+    test("telegram resolves to credential/telegram/bot_token", async () => {
+      addProvider("telegram");
+      addConnection("telegram", "conn-tg", {
+        expiresAt: null,
+        hasRefreshToken: false,
+        grantedScopes: [],
+      });
+      secureKeyValues.set("credential/telegram/bot_token", "telegram-token");
+
+      const report = await checkAllCredentials();
+      expect(report.results[0]!.status).toBe("healthy");
+    });
+  });
+
   describe("checkCredentialForProvider", () => {
     test("returns null when no connections exist", async () => {
       const result = await checkCredentialForProvider("google");

package/src/__tests__/credential-security-invariants.test.ts

@@ -206,8 +206,7 @@ describe("Invariant 2: no generic plaintext secret read API", () => {
       "config/bundled-skills/media-processing/tools/analyze-keyframes.ts", // keyframe analysis tool API key lookup
       "providers/registry.ts", // provider registry API key lookup for initialization
       "providers/provider-availability.ts", // provider availability API key check
-      "media/app-icon-generator.ts", // app icon generation API key lookup
-      "media/avatar-router.ts", // avatar generation API key lookup
+      "media/image-credentials.ts", // shared image-gen credential resolver (provider API key lookup)
       "memory/embedding-backend.ts", // embedding backend API key lookup
       "daemon/providers-setup.ts", // provider initialization API key lookup
       "workspace/migrations/006-services-config.ts", // services config migration reads provider API keys
@@ -216,6 +215,7 @@ describe("Invariant 2: no generic plaintext secret read API", () => {
       "daemon/handlers/config-model.ts", // masked provider key display
       "providers/speech-to-text/resolve.ts", // STT provider API key lookup
       "daemon/lifecycle.ts", // CES client injection into secure-keys at startup
+      "daemon/external-plugins-bootstrap.ts", // reads credentials at plugin init (manifest.requiresCredential) via the CES-mediated getSecureKeyAsync path
       "inbound/platform-callback-registration.ts", // managed credential lookup for platform base URL, assistant ID, and API key
       "tts/providers/elevenlabs-provider.ts", // ElevenLabs TTS API key lookup
       "tts/providers/deepgram-provider.ts", // Deepgram TTS API key lookup

package/src/__tests__/db-schedule-syntax-migration.test.ts

@@ -43,6 +43,7 @@ describe("schedule_syntax column migration", () => {
         status TEXT NOT NULL DEFAULT 'active',
         quiet INTEGER NOT NULL DEFAULT 0,
         reuse_conversation INTEGER NOT NULL DEFAULT 0,
+        script TEXT,
         created_at INTEGER NOT NULL,
         updated_at INTEGER NOT NULL
       )