@vellumai/assistant 0.6.3 → 0.6.5

package/src/workspace/migrations/045-release-notes-meet-avatar.ts

@@ -0,0 +1,130 @@
+import {
+  appendFileSync,
+  existsSync,
+  readFileSync,
+  writeFileSync,
+} from "node:fs";
+import { join } from "node:path";
+
+import { getLogger } from "../../util/logger.js";
+import type { WorkspaceMigration } from "./types.js";
+
+const log = getLogger("workspace-migration-045-release-notes-meet-avatar");
+
+const MIGRATION_ID = "045-release-notes-meet-avatar";
+const MARKER = `<!-- release-note-id:${MIGRATION_ID} -->`;
+
+const RELEASE_NOTE = `${MARKER}
+## Meet video avatar with lip-sync (v1)
+
+I can now appear as a video avatar during Google Meet calls, with lip-sync
+driven by my TTS output. v1 uses the TalkingHead.js renderer running inside
+the meet-bot container; hosted renderers (Simli, HeyGen) and GPU sidecars
+(SadTalker, MuseTalk) are additive follow-ups and are not yet available.
+
+### One-time setup (required before enabling)
+
+The repo currently ships a placeholder \`default-avatar.glb\` at
+\`skills/meet-join/meet-controller-ext/avatar/default-avatar.glb\` that is
+**0 bytes** — the avatar will fail fast at enable time until you replace
+it with a real Ready Player Me model. Export a \`.glb\` from Ready Player Me
+and drop it at that path before turning the feature on.
+
+### Host setup (Linux only)
+
+The avatar publishes frames to a virtual camera via \`v4l2loopback\`. On
+the Linux host that runs the assistant:
+
+\`\`\`bash
+sudo apt-get install v4l2loopback-dkms
+sudo modprobe v4l2loopback video_nr=10 card_label="VellumAvatar" exclusive_caps=1
+\`\`\`
+
+macOS bare-metal is **not supported** for the avatar in v1 — the virtual
+camera stack is Linux-specific.
+
+### Enabling the avatar
+
+In your Meet service config, set:
+
+\`\`\`json
+{
+  "services": {
+    "meet": {
+      "avatar": { "enabled": true, "renderer": "talking-head" }
+    }
+  }
+}
+\`\`\`
+
+**Docker mode:** additionally export \`VELLUM_MEET_AVATAR=1\` in the CLI
+environment **before** spawning the instance, so the CLI bind-mounts
+\`/dev/video10\` into the assistant container. Without this, the inner
+\`dockerd\` has no device to pass through to the meet-bot.
+
+### New tools
+
+Two new assistant tools are available (feature-flag gated on \`meet\`):
+
+- \`meet_enable_avatar\` — turn the avatar on for a meeting.
+- \`meet_disable_avatar\` — turn the avatar off for a meeting.
+
+Ask me to enable or disable my avatar in a Meet and I'll call these for you.
+`;
+
+/**
+ * Release-notes migration for the Meet video avatar feature (Phase 4).
+ *
+ * Per AGENTS.md § Release Update Hygiene, user-facing changes ship notes via a
+ * workspace migration that appends to `<workspace>/UPDATES.md`. The in-file
+ * HTML marker guards against duplicate appends if the runner re-executes this
+ * migration after a mid-run crash (between `appendFileSync` and the runner's
+ * checkpoint promotion to `applied`), which the runner's own checkpoint state
+ * does not cover on its own.
+ */
+export const releaseNotesMeetAvatarMigration: WorkspaceMigration = {
+  id: MIGRATION_ID,
+  description:
+    "Append release notes for Meet video avatar with lip-sync to UPDATES.md",
+
+  run(workspaceDir: string): void {
+    const updatesPath = join(workspaceDir, "UPDATES.md");
+
+    try {
+      if (existsSync(updatesPath)) {
+        const existing = readFileSync(updatesPath, "utf-8");
+        if (existing.includes(MARKER)) {
+          // Marker already present — a prior run of this migration appended
+          // the note. Short-circuit to keep the migration idempotent across
+          // the narrow crash window between append and runner checkpoint.
+          return;
+        }
+        // Ensure separation from prior content.
+        const needsLeadingNewline = !existing.endsWith("\n\n");
+        const prefix = existing.endsWith("\n") ? "\n" : "\n\n";
+        appendFileSync(
+          updatesPath,
+          needsLeadingNewline ? `${prefix}${RELEASE_NOTE}` : RELEASE_NOTE,
+          "utf-8",
+        );
+      } else {
+        writeFileSync(updatesPath, RELEASE_NOTE, "utf-8");
+      }
+      log.info(
+        { path: updatesPath },
+        "Appended Meet video avatar release note",
+      );
+    } catch (err) {
+      log.warn(
+        { err, path: updatesPath },
+        "Failed to append Meet video avatar release note to UPDATES.md",
+      );
+    }
+  },
+
+  down(_workspaceDir: string): void {
+    // Forward-only: UPDATES.md is a user-facing bulletin the assistant
+    // processes and deletes on its own. Attempting to reverse a note that may
+    // have already been read/deleted would risk surprising user-visible state.
+  },
+};

package/src/workspace/migrations/AGENTS.md

@@ -6,6 +6,6 @@ Each migration file must be **fully self-contained**. All helper functions, cons
 
 - **No external exports.** Migration files must not export anything other than the single `WorkspaceMigration` object. Other code must never import from a migration file.
 - **Duplicate rather than share.** If two migrations need the same helper, duplicate it in both files. Migrations are write-once code — they run once per assistant and are never modified after release. Duplication is preferable to coupling.
-- **Allowed imports:** `./types.js` (for the `WorkspaceMigration` interface) and `../../util/logger.js` (for structured logging). All other dependencies should be inlined.
+- **Allowed imports:** `./types.js` (for the `WorkspaceMigration` interface), `../../util/logger.js` (for structured logging), and Node/Bun runtime built-ins (`node:fs`, `node:path`, `node:crypto`, `bun:sqlite`, etc.). All other dependencies — both project-internal modules and third-party npm packages — must be inlined. Do not import from shared modules like `../../memory/` or `../../config/`, and do not add npm dependencies.
 - **Graceful on all platforms.** Migrations run on macOS, Linux, and in Docker. Platform-specific operations must no-op gracefully on unsupported platforms — never throw.
 - **Idempotent.** Migrations must be safe to re-run if interrupted. The runner checkpoints state as `"started"` before execution and `"completed"` after, so a crash mid-migration triggers a re-run on next startup.

package/src/workspace/migrations/registry.ts

@@ -27,6 +27,22 @@ import { removeOrphanedOptimizedImagesCacheMigration } from "./027-remove-orphan
 import { recoverConversationsFromDiskViewMigration } from "./028-recover-conversations-from-disk-view.js";
 import { seedPkbMigration } from "./029-seed-pkb.js";
 import { seedPkbAutoinjectMigration } from "./030-seed-pkb-autoinject.js";
+import { dropUserMdMigration } from "./031-drop-user-md.js";
+import { llmLogRetentionZeroToNullMigration } from "./031-llm-log-retention-zero-to-null.js";
+import { ttsProviderUnificationMigration } from "./032-tts-provider-unification.js";
+import { sttServiceExplicitConfigMigration } from "./033-stt-service-explicit-config.js";
+import { removeCallsVoiceTranscriptionProviderMigration } from "./034-remove-calls-voice-transcription-provider.js";
+import { seedSlackChannelPersonaMigration } from "./035-seed-slack-channel-persona.js";
+import { updatePkbIndexBarMigration } from "./036-update-pkb-index-bar.js";
+import { createMeetsDirMigration } from "./037-create-meets-dir.js";
+import { unifyLlmCallSiteConfigsMigration } from "./038-unify-llm-callsite-configs.js";
+import { dropLegacyLlmKeysMigration } from "./039-drop-legacy-llm-keys.js";
+import { seedLatencyCallSiteDefaultsMigration } from "./040-seed-latency-callsite-defaults.js";
+import { backfillGoogleGmailSettingsScopeMigration } from "./041-backfill-google-gmail-settings-scope.js";
+import { fixBackfillGoogleGmailSettingsScopeMigration } from "./042-fix-backfill-google-gmail-settings-scope.js";
+import { releaseNotesLatexRenderingMigration } from "./043-release-notes-latex-rendering.js";
+import { bumpStaleProviderStreamTimeoutMigration } from "./044-bump-stale-provider-stream-timeout.js";
+import { releaseNotesMeetAvatarMigration } from "./045-release-notes-meet-avatar.js";
 import { migrateToWorkspaceVolumeMigration } from "./migrate-to-workspace-volume.js";
 import type { WorkspaceMigration } from "./types.js";
 
@@ -65,4 +81,20 @@ export const WORKSPACE_MIGRATIONS: WorkspaceMigration[] = [
   recoverConversationsFromDiskViewMigration,
   seedPkbMigration,
   seedPkbAutoinjectMigration,
+  llmLogRetentionZeroToNullMigration,
+  ttsProviderUnificationMigration,
+  dropUserMdMigration,
+  sttServiceExplicitConfigMigration,
+  removeCallsVoiceTranscriptionProviderMigration,
+  seedSlackChannelPersonaMigration,
+  updatePkbIndexBarMigration,
+  createMeetsDirMigration,
+  unifyLlmCallSiteConfigsMigration,
+  dropLegacyLlmKeysMigration,
+  seedLatencyCallSiteDefaultsMigration,
+  backfillGoogleGmailSettingsScopeMigration,
+  fixBackfillGoogleGmailSettingsScopeMigration,
+  releaseNotesLatexRenderingMigration,
+  bumpStaleProviderStreamTimeoutMigration,
+  releaseNotesMeetAvatarMigration,
 ];

package/src/workspace/provider-commit-message-generator.ts

@@ -14,7 +14,6 @@ export type LLMFallbackReason =
   | "missing_provider_api_key"
   | "breaker_open"
   | "insufficient_budget"
-  | "missing_fast_model"
   | "provider_not_initialized"
   | "timeout"
   | "provider_error"
@@ -40,19 +39,13 @@ Rules:
 - Total output must be under 300 characters
 - If you cannot determine a meaningful message, respond with exactly: FALLBACK`;
 
-const PROVIDER_DEFAULT_FAST_MODELS: Record<string, string> = {
-  anthropic: "claude-haiku-4-5-20251001",
-  openai: "gpt-4o-mini",
-  gemini: "gemini-2.0-flash",
-};
-
 // Providers that can be initialized without an API key (e.g., Ollama runs locally)
 const KEYLESS_PROVIDERS = new Set(["ollama"]);
 
 const deterministicProvider = new DefaultCommitMessageProvider();
 
 function getProviderCandidates(config: ReturnType<typeof getConfig>): string[] {
-  return [config.services.inference.provider];
+  return [config.llm.default.provider];
 }
 
 function buildDeterministicResult(
@@ -118,22 +111,22 @@ export class ProviderCommitMessageGenerator {
     // 3. selected-provider API key preflight (except keyless providers)
     // 4. breaker_open
     // 5. insufficient_budget
-    // 6. missing_fast_model
-    // 7. call provider → timeout / provider_error / invalid_output
+    // 6. call provider → timeout / provider_error / invalid_output
     // ──────────────────────────────────────────────────────────────────
 
     // Step 1: Feature gate
     if (!llmConfig.enabled) {
       return buildDeterministicResult(context, "disabled");
     }
-    if (!llmConfig.useConfiguredProvider) {
-      return buildDeterministicResult(context, "disabled");
-    }
 
-    // Step 2: Resolve configured provider.
-    // If nothing is resolvable, differentiate likely missing-key cases from
-    // true registry/init failures.
-    const resolved = await resolveConfiguredProvider();
+    // Step 2: Resolve configured provider via the commit-message call site,
+    // so model + maxTokens + temperature come from `llm.callSites.commitMessage`
+    // (with `llm.default` as the fallback). Operational fields (`enabled`,
+    // `timeoutMs`, `breaker`, `maxFilesInPrompt`, `maxDiffBytes`,
+    // `minRemainingTurnBudgetMs`) remain on `workspaceGit.commitMessageLLM`
+    // and are read above. If nothing is resolvable, differentiate likely
+    // missing-key cases from true registry/init failures.
+    const resolved = await resolveConfiguredProvider("commitMessage");
     if (!resolved) {
       const candidates = getProviderCandidates(config);
       const hasAnyKeylessCandidate = candidates.some((name) =>
@@ -153,7 +146,7 @@ export class ProviderCommitMessageGenerator {
         return buildDeterministicResult(context, "missing_provider_api_key");
       }
       log.debug(
-        { provider: config.services.inference.provider },
+        { provider: config.llm.default.provider },
         "Provider not initialized; falling back to deterministic",
       );
       return buildDeterministicResult(context, "provider_not_initialized");
@@ -200,23 +193,7 @@ export class ProviderCommitMessageGenerator {
       }
     }
 
-    // Step 5: Fast model preflight — resolve before any provider call
-    const fastModel =
-      llmConfig.providerFastModelOverrides[providerName] ??
-      PROVIDER_DEFAULT_FAST_MODELS[providerName];
-
-    if (!fastModel) {
-      log.debug(
-        {
-          provider: providerName,
-          configuredProvider: config.services.inference.provider,
-        },
-        "No fast model resolvable for provider; falling back to deterministic",
-      );
-      return buildDeterministicResult(context, "missing_fast_model");
-    }
-
-    // Step 6 + 7: Call the provider
+    // Step 5: Call the provider
     try {
       // Build prompt
       const fileList = options.changedFiles
@@ -263,9 +240,13 @@ export class ProviderCommitMessageGenerator {
           {
             signal: ac.signal,
             config: {
-              model: fastModel,
-              max_tokens: llmConfig.maxTokens,
-              temperature: llmConfig.temperature,
+              // `callSite` lets the provider resolve model, max_tokens, and
+              // temperature from `llm.callSites.commitMessage` (with
+              // `llm.default` as the fallback). Operational fields
+              // (`enabled`, `timeoutMs`, `breaker`, `maxFilesInPrompt`,
+              // `maxDiffBytes`, `minRemainingTurnBudgetMs`) remain on
+              // `workspaceGit.commitMessageLLM` and are read above.
+              callSite: "commitMessage",
             },
           },
         );

package/src/workspace/top-level-renderer.ts

@@ -2,6 +2,18 @@ import { homedir, userInfo } from "node:os";
 
 import type { TopLevelSnapshot } from "./top-level-scanner.js";
 
+// `os.userInfo()` throws `SystemError` when the current UID has no passwd
+// entry (possible in sandboxed/containerized envs, including the daemon's
+// own container). Guarding here keeps the renderer safe since this runs
+// inside the daemon and crashing would break workspace context injection.
+function safeUserInfoUsername(): string {
+  try {
+    return userInfo().username;
+  } catch {
+    return "unknown";
+  }
+}
+
 export interface WorkspaceTopLevelRenderOptions {
   conversationAttachmentsPath?: string | null;
   /**
@@ -41,7 +53,7 @@ export function renderWorkspaceTopLevelContext(
     lines.push("(list truncated — more entries exist)");
   }
   lines.push(`Host home directory: ${options.hostHomeDir ?? homedir()}`);
-  lines.push(`Host username: ${options.hostUsername ?? userInfo().username}`);
+  lines.push(`Host username: ${options.hostUsername ?? safeUserInfoUsername()}`);
   lines.push("</workspace>");
   return lines.join("\n");
 }

package/src/workspace/turn-commit.ts

@@ -9,7 +9,12 @@
  * preventing cross-turn attribution of file changes.
  */
 
+import { existsSync, readFileSync } from "node:fs";
+
+import { parseIdentityFields } from "../daemon/handlers/identity.js";
+import { syncIdentityNameToPlatform } from "../platform/sync-identity.js";
 import { getLogger } from "../util/logger.js";
+import { getWorkspacePromptPath } from "../util/platform.js";
 import { getEnrichmentService } from "./commit-message-enrichment-service.js";
 import {
   type CommitContext,
@@ -166,6 +171,32 @@ export async function commitTurnChanges(
         "Turn-boundary commit created",
       );
 
+      // If IDENTITY.md changed, trigger a best-effort sync of the
+      // assistant name to the platform record.  This acts as a fallback
+      // for environments where fs.watch / inotify is unreliable (e.g.
+      // container runtimes using gVisor or Docker-in-Docker).
+      if (
+        uniqueFiles.some(
+          (f) => f === "IDENTITY.md" || f.endsWith("/IDENTITY.md"),
+        )
+      ) {
+        try {
+          const identityPath = getWorkspacePromptPath("IDENTITY.md");
+          if (existsSync(identityPath)) {
+            const content = readFileSync(identityPath, "utf-8");
+            const fields = parseIdentityFields(content);
+            if (fields.name) {
+              syncIdentityNameToPlatform(fields.name);
+            }
+          }
+        } catch (syncErr) {
+          log.debug(
+            { syncErr },
+            "Identity sync after turn-commit failed (non-fatal)",
+          );
+        }
+      }
+
       // Fire-and-forget enrichment — never blocks turn completion
       try {
         const commitHash = await gitService.getHeadHash();

package/src/__tests__/email-cli.test.ts

@@ -1,297 +0,0 @@
-import { mkdirSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-
-// ---------------------------------------------------------------------------
-// Test isolation: override VELLUM_WORKSPACE_DIR so guardrails state uses a temp dir
-// ---------------------------------------------------------------------------
-const testDir = join(tmpdir(), `email-cli-test-${Date.now()}`);
-const originalWorkspaceDir = process.env.VELLUM_WORKSPACE_DIR;
-
-beforeEach(() => {
-  mkdirSync(testDir, { recursive: true });
-  process.env.VELLUM_WORKSPACE_DIR = testDir;
-});
-
-afterEach(() => {
-  if (originalWorkspaceDir === undefined) {
-    delete process.env.VELLUM_WORKSPACE_DIR;
-  } else {
-    process.env.VELLUM_WORKSPACE_DIR = originalWorkspaceDir;
-  }
-  try {
-    rmSync(testDir, { recursive: true, force: true });
-  } catch {
-    // Ignore cleanup errors
-  }
-});
-
-// ---------------------------------------------------------------------------
-// Provider factory tests
-// ---------------------------------------------------------------------------
-describe("email provider factory", () => {
-  test("getActiveProviderName defaults to agentmail", async () => {
-    const { getActiveProviderName } =
-      await import("../email/providers/index.js");
-    expect(getActiveProviderName()).toBe("agentmail");
-  });
-
-  test("SUPPORTED_PROVIDERS includes agentmail", async () => {
-    const { SUPPORTED_PROVIDERS } = await import("../email/providers/index.js");
-    expect(SUPPORTED_PROVIDERS).toContain("agentmail");
-  });
-
-  test("createProvider throws without API key", async () => {
-    const { createProvider } = await import("../email/providers/index.js");
-    try {
-      await createProvider("agentmail");
-      // If we get here, the API key might be set in the env
-      // The important thing is it doesn't throw for wrong reasons
-    } catch (err) {
-      expect(err instanceof Error).toBe(true);
-      expect((err as Error).message).toContain("API key");
-    }
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Service guardrail tests (via guardrails module directly)
-// ---------------------------------------------------------------------------
-describe("email guardrails", () => {
-  test("pause blocks sends (returns outbound_paused)", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.setOutboundPaused(true);
-    expect(guardrails.isOutboundPaused()).toBe(true);
-
-    const result = guardrails.checkSendGuardrails(["user@example.com"]);
-    expect(result).not.toBeNull();
-    expect(result!.error).toBe("outbound_paused");
-  });
-
-  test("resume allows sends", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.setOutboundPaused(true);
-    guardrails.setOutboundPaused(false);
-
-    const result = guardrails.checkSendGuardrails(["user@example.com"]);
-    expect(result).toBeNull();
-  });
-
-  test("daily cap enforced", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.setDailySendCap(2);
-    guardrails.incrementDailySendCount();
-    guardrails.incrementDailySendCount();
-
-    const result = guardrails.checkSendGuardrails(["user@example.com"]);
-    expect(result).not.toBeNull();
-    expect(result!.error).toBe("daily_cap_reached");
-    expect(result!.count).toBe(2);
-    expect(result!.cap).toBe(2);
-  });
-
-  test("blocklist checked", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.addAddressRule("block", "*@spam.com");
-
-    const result = guardrails.checkSendGuardrails(["user@spam.com"]);
-    expect(result).not.toBeNull();
-    expect(result!.error).toBe("address_blocked");
-    expect(result!.address).toBe("user@spam.com");
-  });
-
-  test("allowlist enforcement", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.addAddressRule("allow", "*@trusted.com");
-
-    expect(guardrails.checkSendGuardrails(["bob@trusted.com"])).toBeNull();
-
-    const result = guardrails.checkSendGuardrails(["bob@untrusted.com"]);
-    expect(result).not.toBeNull();
-    expect(result!.error).toBe("address_blocked");
-    expect(result!.reason).toBe("not in allowlist");
-  });
-
-  test("rule lifecycle: add, list, remove", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    const rule = guardrails.addAddressRule("block", "*@evil.com");
-    expect(rule.id).toBeTruthy();
-    expect(rule.type).toBe("block");
-
-    const rules = guardrails.listRules();
-    expect(rules.length).toBe(1);
-    expect(rules[0].pattern).toBe("*@evil.com");
-
-    expect(guardrails.removeAddressRule(rule.id)).toBe(true);
-    expect(guardrails.listRules().length).toBe(0);
-  });
-
-  test("remove non-existent rule returns false", async () => {
-    const guardrails = await import("../email/guardrails.js");
-    expect(guardrails.removeAddressRule("non-existent")).toBe(false);
-  });
-
-  test("default cap is 25", async () => {
-    const guardrails = await import("../email/guardrails.js");
-    expect(guardrails.getDailySendCap()).toBe(25);
-  });
-
-  test("incrementDailySendCount returns new count", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    expect(guardrails.incrementDailySendCount()).toBe(1);
-    expect(guardrails.incrementDailySendCount()).toBe(2);
-    expect(guardrails.getDailySendCount()).toBe(2);
-  });
-
-  test("guardrails check priority: pause > cap > blocklist", async () => {
-    const guardrails = await import("../email/guardrails.js");
-
-    guardrails.setOutboundPaused(true);
-    guardrails.setDailySendCap(0);
-    guardrails.addAddressRule("block", "*@blocked.com");
-
-    const result = guardrails.checkSendGuardrails(["user@blocked.com"]);
-    expect(result!.error).toBe("outbound_paused");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Service layer tests (with mocked provider)
-// ---------------------------------------------------------------------------
-describe("email service guardrails integration", () => {
-  test("GuardrailError has correct structure", async () => {
-    const { GuardrailError } = await import("../email/service.js");
-
-    const err = new GuardrailError("outbound_paused", "Send blocked", {
-      extra: true,
-    });
-    expect(err.code).toBe("outbound_paused");
-    expect(err.message).toBe("Send blocked");
-    expect(err.details).toEqual({ extra: true });
-    expect(err.name).toBe("GuardrailError");
-    expect(err instanceof Error).toBe(true);
-  });
-
-  test("getEmailService returns singleton", async () => {
-    const { getEmailService } = await import("../email/service.js");
-    const a = getEmailService();
-    const b = getEmailService();
-    expect(a).toBe(b);
-  });
-
-  test("service getProviderName returns default", async () => {
-    const { getEmailService } = await import("../email/service.js");
-    const svc = getEmailService();
-    expect(svc.getProviderName()).toBe("agentmail");
-  });
-
-  test("service guardrails methods work", async () => {
-    const { getEmailService } = await import("../email/service.js");
-    const svc = getEmailService();
-
-    const initial = svc.getGuardrails();
-    expect(initial.paused).toBe(false);
-    expect(initial.dailyCap).toBe(25);
-
-    svc.setGuardrails({ paused: true, dailyCap: 10 });
-    const updated = svc.getGuardrails();
-    expect(updated.paused).toBe(true);
-    expect(updated.dailyCap).toBe(10);
-  });
-
-  test("service address rule methods work", async () => {
-    const { getEmailService } = await import("../email/service.js");
-    const svc = getEmailService();
-
-    const rule = svc.addRule("block", "*@test.com");
-    expect(rule.type).toBe("block");
-
-    const rules = svc.listAddressRules();
-    expect(rules.length).toBe(1);
-
-    expect(svc.removeRule(rule.id)).toBe(true);
-    expect(svc.listAddressRules().length).toBe(0);
-  });
-});
-
-// ---------------------------------------------------------------------------
-// JSON output format / contract tests
-// ---------------------------------------------------------------------------
-describe("email JSON contract", () => {
-  test("guardrails status has expected shape", async () => {
-    const guardrails = await import("../email/guardrails.js");
-    const status = guardrails.getGuardrailsStatus();
-    const json = JSON.stringify(status);
-    const parsed = JSON.parse(json);
-
-    expect(parsed).toHaveProperty("paused");
-    expect(parsed).toHaveProperty("dailyCap");
-    expect(parsed).toHaveProperty("dailyCount");
-    expect(parsed).toHaveProperty("rules");
-    expect(typeof parsed.paused).toBe("boolean");
-    expect(typeof parsed.dailyCap).toBe("number");
-    expect(typeof parsed.dailyCount).toBe("number");
-    expect(Array.isArray(parsed.rules)).toBe(true);
-  });
-
-  test("address rule has expected JSON fields", async () => {
-    const guardrails = await import("../email/guardrails.js");
-    const rule = guardrails.addAddressRule("block", "*@test.com");
-    const parsed = JSON.parse(JSON.stringify(rule));
-
-    expect(parsed).toHaveProperty("id");
-    expect(parsed).toHaveProperty("type");
-    expect(parsed).toHaveProperty("pattern");
-    expect(parsed).toHaveProperty("createdAt");
-    expect(parsed.type).toBe("block");
-    expect(parsed.pattern).toBe("*@test.com");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Provider interface conformance
-// ---------------------------------------------------------------------------
-describe("AgentMailProvider interface", () => {
-  test("AgentMailProvider implements all required methods", async () => {
-    const { AgentMailProvider } =
-      await import("../email/providers/agentmail.js");
-
-    // Create with a dummy client — we won't call any methods
-    const provider = new AgentMailProvider({} as never);
-
-    // Verify all interface methods exist
-    const requiredMethods = [
-      "health",
-      "setupDomain",
-      "getDomainDnsRecords",
-      "verifyDomain",
-      "ensureInboxes",
-      "setupWebhook",
-      "createDraft",
-      "listDrafts",
-      "getDraft",
-      "deleteDraft",
-      "sendDraft",
-      "listMessages",
-      "getMessage",
-      "listThreads",
-      "getThread",
-    ];
-
-    for (const method of requiredMethods) {
-      expect(
-        typeof (provider as unknown as Record<string, unknown>)[method],
-      ).toBe("function");
-    }
-
-    expect(provider.name).toBe("agentmail");
-  });
-});